source4/registry/local: avoid str_list_length() to check first element
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Fri, 6 May 2016 03:30:57 +0000 (15:30 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 9 May 2016 23:43:14 +0000 (01:43 +0200)
We don't need to walk to the end of the list to find out if the first
one is NULL.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/lib/registry/local.c

index 2afb65c7d599f69439f3af3e6d7ff0f061234233..6079efd6543e7345a6432a3e16a0bb15a57476dd 100644 (file)
@@ -389,7 +389,7 @@ WERROR reg_mount_hive(struct registry_context *rctx,
        mp->path.predefined_key = key_id;
        mp->prev = mp->next = NULL;
        mp->key = hive_key;
-       if (elements != NULL && str_list_length(elements) != 0) {
+       if (elements != NULL && elements[0] != NULL) {
                mp->path.elements = talloc_array(mp, const char *,
                                                 str_list_length(elements));
                W_ERROR_HAVE_NO_MEMORY(mp->path.elements);