git.samba.org
/
kai
/
samba-autobuild
/
.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
f0072d3
)
idmap-hash: Fix Coverity ID 709119 Unused pointer value
author
Volker Lendecke
<vl@samba.org>
Wed, 20 Jun 2012 06:40:22 +0000
(08:40 +0200)
committer
Michael Adam
<obnox@samba.org>
Wed, 20 Jun 2012 08:51:14 +0000
(10:51 +0200)
"p" is overwritten further down again before it's first use
Signed-off-by: Michael Adam <obnox@samba.org>
source3/winbindd/idmap_hash/mapfile.c
patch
|
blob
|
history
diff --git
a/source3/winbindd/idmap_hash/mapfile.c
b/source3/winbindd/idmap_hash/mapfile.c
index 075f0f25cc42958350d2fc22c0273580300e6c79..b1f2e6eb5ceda04ac1e61e27d46d88fa34c04beb 100644
(file)
--- a/
source3/winbindd/idmap_hash/mapfile.c
+++ b/
source3/winbindd/idmap_hash/mapfile.c
@@
-67,7
+67,7
@@
static bool mapfile_read_line(fstring key, fstring value)
if (!lw_map_file)
return false;
- if (
(p = x_fgets(buffer, sizeof(buffer)-1, lw_map_file)
) == NULL) {
+ if (
x_fgets(buffer, sizeof(buffer)-1, lw_map_file
) == NULL) {
return false;
}