s3: Fix Coverity ID 581 -- NEGATIVE_RETURNS
authorVolker Lendecke <vl@samba.org>
Fri, 18 Sep 2009 18:20:07 +0000 (20:20 +0200)
committerVolker Lendecke <vl@samba.org>
Fri, 18 Sep 2009 18:20:39 +0000 (20:20 +0200)
source3/lib/dprintf.c

index 631c45a8078890be0cecdf95445f8d256296515e..835d34076e5f2fea2af0ccd7e5cb655cb7b05464 100644 (file)
@@ -66,6 +66,10 @@ again:
        }
 
        clen = convert_string(CH_UNIX, CH_DISPLAY, p, ret, p2, maxlen, True);
+       if (clen == -1) {
+               ret = -1;
+               goto out;
+       }
 
        if (clen >= maxlen) {
                /* it didn't fit - try a larger buffer */