selftest: Fail testsuite on unknown environment

The status quo was that tests in typo'd/unknown environments would be skipped.
This was a side effect of the mechanism by which samba3 tests were run, which
has now been changed.

For an example of this being a problem in the past, see commit 523bd03f (which
fixes an issue I noticed when reading subunit logs, and which did not fail the
test).

Signed-off-by: Jamie McClymont <jamiemcclymont@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>

diff --git a/selftest/selftest.pl b/selftest/selftest.pl
index fad0191e89e6323c67877eab367d02b7e7ac498e..12452bc420d320a7be82be37df941d1aacb91f17 100755 (executable)
--- a/selftest/selftest.pl
+++ b/selftest/selftest.pl
@@ -1117,8 +1117,8 @@ $envvarstr
                        next;
                } elsif ($envvars eq "UNKNOWN") {
                        Subunit::start_testsuite($name);
-                       Subunit::end_testsuite($name, "skip",
-                               "environment $envname is unknown in this test backend - skipping");
+                       Subunit::end_testsuite($name, "error",
+                               "environment $envname is unknown - exiting");
                        next;
                }