ldb: Indicate that the ltdb_dn_list_sort() in list_union is a bit subtle.
authorAndrew Bartlett <abartlet@samba.org>
Mon, 28 May 2018 01:02:16 +0000 (13:02 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Wed, 30 May 2018 02:23:27 +0000 (04:23 +0200)
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
lib/ldb/ldb_tdb/ldb_index.c

index dbe5983..1a5867b 100644 (file)
@@ -1310,6 +1310,9 @@ static bool list_union(struct ldb_context *ldb,
        /*
         * Sort the lists (if not in GUID DN mode) so we can do
         * the de-duplication during the merge
+        *
+        * NOTE: This can sort the in-memory index values, as list or
+        * list2 might not be a copy!
         */
        ltdb_dn_list_sort(ltdb, list);
        ltdb_dn_list_sort(ltdb, list2);