lib-pyldb: Block elements should be surrounded by {} in py_msg.setitem()
authorKamen Mazdrashki <kamenim@samba.org>
Thu, 20 Nov 2014 03:07:47 +0000 (04:07 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 25 Nov 2014 06:24:12 +0000 (07:24 +0100)
Change-Id: I0d09374b27708fcaad3523d985a2db7983dbd81a
Signed-off-by: Kamen Mazdrashki <kamenim@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Nov 25 07:24:12 CET 2014 on sn-devel-104

lib/ldb/pyldb.c

index a9ec637838455a8fc964b028d57ebe6ccbedd1ce..ee751b363e08bdc857e9b052f652e3b6a6abb8d5 100644 (file)
@@ -2863,8 +2863,9 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
                int ret;
                struct ldb_message_element *el = PyObject_AsMessageElement(self->msg,
                                                                           value, 0, attr_name);
-               if (el == NULL)
+               if (el == NULL) {
                        return -1;
+               }
                ldb_msg_remove_attr(pyldb_Message_AsMessage(self), attr_name);
                ret = ldb_msg_add(pyldb_Message_AsMessage(self), el, el->flags);
                if (ret != LDB_SUCCESS) {