Fix bug #10187 - Missing talloc_free can leak stackframe in error path.
authorJeremy Allison <jra@samba.org>
Tue, 8 Oct 2013 22:01:38 +0000 (15:01 -0700)
committerDavid Disseldorp <ddiss@samba.org>
Wed, 9 Oct 2013 01:50:56 +0000 (03:50 +0200)
Fix error path.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Wed Oct  9 03:50:56 CEST 2013 on sn-devel-104

source3/winbindd/winbindd_msrpc.c

index e86838cf58582e02a83a23a4cc516ab86c890e50..61447d3acf016bf059a92c29aa2ee66d7aff18c5 100644 (file)
@@ -944,8 +944,9 @@ static NTSTATUS msrpc_trusted_domains(struct winbindd_domain *domain,
        }
 
        status = cm_connect_lsa(domain, tmp_ctx, &lsa_pipe, &lsa_policy);
-       if (!NT_STATUS_IS_OK(status))
-               return status;
+       if (!NT_STATUS_IS_OK(status)) {
+               goto done;
+       }
 
        status = rpc_trusted_domains(tmp_ctx,
                                     lsa_pipe,