s4-drsuapi: Use sam_ctx consistently in dcesrv_drsuapi_DsGetNCChanges()
authorTim Beale <timbeale@catalyst.net.nz>
Sun, 13 Aug 2017 23:02:05 +0000 (11:02 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 29 Aug 2017 05:23:28 +0000 (07:23 +0200)
commitf8a30d31677bab7956a2176a2fa4aed45f124187
tree8b8fccbbe701882792b00f2bda1717ac5578adc0
parentdd863b604984c1504895f376ec64f58e27e53efa
s4-drsuapi: Use sam_ctx consistently in dcesrv_drsuapi_DsGetNCChanges()

Trying to use bstate->sam_ctx_system by mistake can cause crashes if
non-admin users replicate. To avoid this problem we use the sam_ctx
variable, however it wasn't used consistently everywhere. Replace the
remaining references to b_state->sam_ctx to avoid potential confusion.

This change was made based on review feedback from Metze.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Garming Sam <garming@catalyst.net.nz>
source4/rpc_server/drsuapi/getncchanges.c