This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
- the Free Software Foundation; either version 2 of the License, or
+ the Free Software Foundation; either version 3 of the License, or
(at your option) any later version.
This program is distributed in the hope that it will be useful,
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
- along with this program; if not, write to the Free Software
- Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
#include "includes.h"
-#include "torture/torture.h"
#include "libcli/raw/libcliraw.h"
+#include "libcli/raw/raw_proto.h"
#include "libcli/libcli.h"
#include "system/filesys.h"
#include "torture/util.h"
+#include "torture/raw/proto.h"
#define BASEDIR "\\test_notify"
-#define CHECK_STATUS(status, correct) do { \
- if (!NT_STATUS_EQUAL(status, correct)) { \
- printf("(%d) Incorrect status %s - should be %s\n", \
- __LINE__, nt_errstr(status), nt_errstr(correct)); \
- ret = False; \
- goto done; \
- }} while (0)
-
-
-#define CHECK_VAL(v, correct) do { \
- if ((v) != (correct)) { \
- printf("(%d) wrong value for %s 0x%x should be 0x%x\n", \
- __LINE__, #v, (int)v, (int)correct); \
- ret = False; \
- goto done; \
- }} while (0)
-
-#define CHECK_WSTR(field, value, flags) do { \
- if (!field.s || strcmp(field.s, value) || wire_bad_flags(&field, flags, cli)) { \
- printf("(%d) %s [%s] != %s\n", __LINE__, #field, field.s, value); \
- ret = False; \
- goto done; \
- }} while (0)
-
+#define CHECK_WSTR(tctx, field, value, flags) \
+do { \
+ torture_assert_str_equal(tctx, field.s, value, "values don't match"); \
+ torture_assert(tctx, \
+ !wire_bad_flags(&field, STR_UNICODE, cli->transport), \
+ "wire_bad_flags"); \
+} while (0)
/*
basic testing of change notify on directories
*/
-static BOOL test_notify_dir(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
+static bool test_notify_dir(struct torture_context *mem_ctx,
+ struct smbcli_state *cli,
+ struct smbcli_state *cli2)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
union smb_close cl;
int i, count, fnum, fnum2;
struct smbcli_request *req, *req2;
extern int torture_numops;
- printf("TESTING CHANGE NOTIFY ON DIRECTRIES\n");
-
+ printf("TESTING CHANGE NOTIFY ON DIRECTORIES\n");
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.fname = BASEDIR;
status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
fnum2 = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
- printf("testing notify cancel\n");
+ printf("Testing notify cancel\n");
req = smb_raw_changenotify_send(cli->tree, ¬ify);
smb_raw_ntcancel(req);
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_CANCELLED);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status, NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
- printf("testing notify mkdir\n");
+ printf("Testing notify mkdir\n");
req = smb_raw_changenotify_send(cli->tree, ¬ify);
- smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
+ smbcli_mkdir(cli2->tree, BASEDIR "\\subdir-name");
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name", STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "more than one change");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
- printf("testing notify rmdir\n");
+ printf("Testing notify rmdir\n");
req = smb_raw_changenotify_send(cli->tree, ¬ify);
- smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+ smbcli_rmdir(cli2->tree, BASEDIR "\\subdir-name");
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name", STR_UNICODE);
-
- printf("testing notify mkdir - rmdir - mkdir - rmdir\n");
-
- smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
- smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
- smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
- smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "more than one change");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("Testing notify mkdir - rmdir - mkdir - rmdir\n");
+
+ smbcli_mkdir(cli2->tree, BASEDIR "\\subdir-name");
+ smbcli_rmdir(cli2->tree, BASEDIR "\\subdir-name");
+ smbcli_mkdir(cli2->tree, BASEDIR "\\subdir-name");
+ smbcli_rmdir(cli2->tree, BASEDIR "\\subdir-name");
+ smb_msleep(200);
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 4);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name", STR_UNICODE);
- CHECK_VAL(notify.out.changes[1].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[1].name, "subdir-name", STR_UNICODE);
- CHECK_VAL(notify.out.changes[2].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[2].name, "subdir-name", STR_UNICODE);
- CHECK_VAL(notify.out.changes[3].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[3].name, "subdir-name", STR_UNICODE);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 4, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[1].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[1].name, "subdir-name",
+ STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[2].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[2].name, "subdir-name",
+ STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[3].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[3].name, "subdir-name",
+ STR_UNICODE);
count = torture_numops;
- printf("testing buffered notify on create of %d files\n", count);
+ printf("Testing buffered notify on create of %d files\n", count);
for (i=0;i<count;i++) {
char *fname = talloc_asprintf(cli, BASEDIR "\\test%d.txt", i);
int fnum3 = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
- if (fnum3 == -1) {
- printf("Failed to create %s - %s\n",
- fname, smbcli_errstr(cli->tree));
- ret = False;
- goto done;
- }
+ torture_assert_int_not_equal_goto(mem_ctx, fnum3, -1, ret, done,
+ talloc_asprintf(mem_ctx, "Failed to create %s - %s",
+ fname, smbcli_errstr(cli->tree)));
talloc_free(fname);
smbcli_close(cli->tree, fnum3);
}
/* (1st notify) setup a new notify on a different directory handle.
This new notify won't see the events above. */
- notify.in.file.fnum = fnum2;
+ notify.nttrans.in.file.fnum = fnum2;
req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
/* (2nd notify) whereas this notify will see the above buffered events,
and it directly returns the buffered events */
- notify.in.file.fnum = fnum;
+ notify.nttrans.in.file.fnum = fnum;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ status = smbcli_unlink(cli->tree, BASEDIR "\\nonexistent.txt");
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_OBJECT_NAME_NOT_FOUND,
+ ret, done,
+ "smbcli_unlink");
+
/* (1st unlink) as the 2nd notify directly returns,
this unlink is only seen by the 1st notify and
the 3rd notify (later) */
- printf("testing notify on unlink for the first file\n");
- status = smbcli_unlink(cli->tree, BASEDIR "\\test0.txt");
- CHECK_STATUS(status, NT_STATUS_OK);
+ printf("Testing notify on unlink for the first file\n");
+ status = smbcli_unlink(cli2->tree, BASEDIR "\\test0.txt");
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smbcli_unlink");
/* receive the reply from the 2nd notify */
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
-
- CHECK_VAL(notify.out.num_changes, count);
- for (i=1;i<notify.out.num_changes;i++) {
- CHECK_VAL(notify.out.changes[i].action, NOTIFY_ACTION_ADDED);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ count, ret, done,
+ "wrong number of changes");
+ for (i=1;i<count;i++) {
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[i].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
}
- CHECK_WSTR(notify.out.changes[0].name, "test0.txt", STR_UNICODE);
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "test0.txt",
+ STR_UNICODE);
- /* and now from the 1st notify */
+ printf("and now from the 1st notify\n");
status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[0].name, "test0.txt", STR_UNICODE);
-
- /* (3rd notify) this notify will only see the 1st unlink */
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "test0.txt",
+ STR_UNICODE);
+
+ printf("(3rd notify) this notify will only see the 1st unlink\n");
req = smb_raw_changenotify_send(cli->tree, ¬ify);
- printf("testing notify on wildcard unlink for %d files\n", count-1);
+ status = smbcli_unlink(cli->tree, BASEDIR "\\nonexistent.txt");
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_OBJECT_NAME_NOT_FOUND,
+ ret, done,
+ "smbcli_unlink");
+
+ printf("Testing notify on wildcard unlink for %d files\n", count-1);
/* (2nd unlink) do a wildcard unlink */
- status = smbcli_unlink(cli->tree, BASEDIR "\\test*.txt");
- CHECK_STATUS(status, NT_STATUS_OK);
+ status = smbcli_unlink(cli2->tree, BASEDIR "\\test*.txt");
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
- /* recev the 3rd notify */
+ /* receive the 3rd notify */
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[0].name, "test0.txt", STR_UNICODE);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "test0.txt",
+ STR_UNICODE);
/* and we now see the rest of the unlink calls on both directory handles */
- notify.in.file.fnum = fnum;
+ notify.nttrans.in.file.fnum = fnum;
+ sleep(3);
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, count-1);
- for (i=0;i<notify.out.num_changes;i++) {
- CHECK_VAL(notify.out.changes[i].action, NOTIFY_ACTION_REMOVED);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ count - 1, ret, done,
+ "wrong number of changes");
+ for (i=0;i<notify.nttrans.out.num_changes;i++) {
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[i].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
}
- notify.in.file.fnum = fnum2;
+ notify.nttrans.in.file.fnum = fnum2;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, count-1);
- for (i=0;i<notify.out.num_changes;i++) {
- CHECK_VAL(notify.out.changes[i].action, NOTIFY_ACTION_REMOVED);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ count - 1, ret, done,
+ "wrong number of changes");
+ for (i=0;i<notify.nttrans.out.num_changes;i++) {
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[i].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
}
- printf("testing if a close() on the dir handle triggers the notify reply\n");
+ printf("Testing if a close() on the dir handle triggers the notify reply\n");
- notify.in.file.fnum = fnum;
+ notify.nttrans.in.file.fnum = fnum;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
cl.close.level = RAW_CLOSE_CLOSE;
cl.close.in.file.fnum = fnum;
cl.close.in.write_time = 0;
status = smb_raw_close(cli->tree, &cl);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_close");
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 0);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 0, ret, done, "no changes expected");
done:
smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
return ret;
}
+/*
+ * Check notify reply for a rename action. Not sure if this is a valid thing
+ * to do, but depending on timing between inotify and messaging we get the
+ * add/remove/modify in any order. This routines tries to find the action/name
+ * pair in any of the three following notify_changes.
+ */
+
+static bool check_rename_reply(struct torture_context *tctx,
+ struct smbcli_state *cli,
+ int line,
+ struct notify_changes *actions,
+ uint32_t action, const char *name)
+{
+ int i;
+
+ for (i=0; i<3; i++) {
+ if (actions[i].action == action) {
+ CHECK_WSTR(tctx, actions[i].name, name, STR_UNICODE);
+ return true;
+ }
+ }
+
+ torture_result(tctx, TORTURE_FAIL,
+ __location__": (%d) expected action %d, not found\n",
+ line, action);
+ return false;
+}
/*
testing of recursive change notify
*/
-static BOOL test_notify_recursive(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
+static bool test_notify_recursive(struct torture_context *mem_ctx,
+ struct smbcli_state *cli,
+ struct smbcli_state *cli2)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
int fnum;
struct smbcli_request *req1, *req2;
printf("TESTING CHANGE NOTIFY WITH RECURSION\n");
-
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.fname = BASEDIR;
status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify, on file or directory name
changes. Setup both with and without recursion */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME | FILE_NOTIFY_CHANGE_ATTRIBUTES | FILE_NOTIFY_CHANGE_CREATION;
+ notify.nttrans.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.in.recursive = true;
req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
- notify.in.recursive = False;
+ notify.nttrans.in.recursive = false;
req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
/* cancel initial requests so the buffer is setup */
smb_raw_ntcancel(req1);
status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_CANCELLED);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
smb_raw_ntcancel(req2);
status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_CANCELLED);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
+ /*
+ * Make notifies a bit more interesting in a cluster by doing
+ * the changes against different nodes with --unclist
+ */
smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
- smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name\\subname1");
- smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name\\subname2");
- smbcli_rename(cli->tree, BASEDIR "\\subdir-name\\subname1", BASEDIR "\\subdir-name\\subname1-r");
+ smbcli_mkdir(cli2->tree, BASEDIR "\\subdir-name\\subname1");
+ smbcli_close(cli->tree,
+ smbcli_open(cli->tree, BASEDIR "\\subdir-name\\subname2", O_CREAT, 0));
+ smbcli_rename(cli2->tree, BASEDIR "\\subdir-name\\subname1",
+ BASEDIR "\\subdir-name\\subname1-r");
smbcli_rename(cli->tree, BASEDIR "\\subdir-name\\subname2", BASEDIR "\\subname2-r");
- smbcli_rename(cli->tree, BASEDIR "\\subname2-r", BASEDIR "\\subname3-r");
+ smbcli_rename(cli2->tree, BASEDIR "\\subname2-r",
+ BASEDIR "\\subname3-r");
- notify.in.completion_filter = 0;
- notify.in.recursive = True;
+ notify.nttrans.in.completion_filter = 0;
+ notify.nttrans.in.recursive = true;
+ smb_msleep(200);
req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name\\subname1-r");
- smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
- smbcli_rmdir(cli->tree, BASEDIR "\\subname3-r");
+ smbcli_rmdir(cli2->tree, BASEDIR "\\subdir-name");
+ smbcli_unlink(cli->tree, BASEDIR "\\subname3-r");
- notify.in.recursive = False;
+ notify.nttrans.in.recursive = false;
req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
-
- CHECK_VAL(notify.out.num_changes, 9);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name", STR_UNICODE);
- CHECK_VAL(notify.out.changes[1].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[1].name, "subdir-name\\subname1", STR_UNICODE);
- CHECK_VAL(notify.out.changes[2].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[2].name, "subdir-name\\subname2", STR_UNICODE);
- CHECK_VAL(notify.out.changes[3].action, NOTIFY_ACTION_OLD_NAME);
- CHECK_WSTR(notify.out.changes[3].name, "subdir-name\\subname1", STR_UNICODE);
- CHECK_VAL(notify.out.changes[4].action, NOTIFY_ACTION_NEW_NAME);
- CHECK_WSTR(notify.out.changes[4].name, "subdir-name\\subname1-r", STR_UNICODE);
-
- CHECK_VAL(notify.out.changes[5].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[5].name, "subdir-name\\subname2", STR_UNICODE);
- CHECK_VAL(notify.out.changes[6].action, NOTIFY_ACTION_ADDED);
- CHECK_WSTR(notify.out.changes[6].name, "subname2-r", STR_UNICODE);
-
- CHECK_VAL(notify.out.changes[7].action, NOTIFY_ACTION_OLD_NAME);
- CHECK_WSTR(notify.out.changes[7].name, "subname2-r", STR_UNICODE);
- CHECK_VAL(notify.out.changes[8].action, NOTIFY_ACTION_NEW_NAME);
- CHECK_WSTR(notify.out.changes[8].name, "subname3-r", STR_UNICODE);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 11, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[1].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[1].name,
+ "subdir-name\\subname1", STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[2].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[2].name,
+ "subdir-name\\subname2", STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[3].action,
+ NOTIFY_ACTION_OLD_NAME, ret, done,
+ "wrong action (exp: OLD_NAME)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[3].name,
+ "subdir-name\\subname1", STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[4].action,
+ NOTIFY_ACTION_NEW_NAME, ret, done,
+ "wrong action (exp: NEW_NAME)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[4].name,
+ "subdir-name\\subname1-r", STR_UNICODE);
+
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[5],
+ NOTIFY_ACTION_ADDED, "subname2-r");
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[5],
+ NOTIFY_ACTION_REMOVED, "subdir-name\\subname2");
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[5],
+ NOTIFY_ACTION_MODIFIED, "subname2-r");
+
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[8],
+ NOTIFY_ACTION_OLD_NAME, "subname2-r");
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[8],
+ NOTIFY_ACTION_NEW_NAME, "subname3-r");
+ ret &= check_rename_reply(mem_ctx,
+ cli, __LINE__, ¬ify.nttrans.out.changes[8],
+ NOTIFY_ACTION_MODIFIED, "subname3-r");
+
+ if (!ret) {
+ goto done;
+ }
status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 3, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name,
+ "subdir-name\\subname1-r", STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[1].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[1].name, "subdir-name",
+ STR_UNICODE);
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[2].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[2].name, "subname3-r",
+ STR_UNICODE);
+
+done:
+ smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
+ return ret;
+}
+
+/*
+ testing of change notify mask change
+*/
+static bool test_notify_mask_change(struct torture_context *mem_ctx,
+ struct smbcli_state *cli)
+{
+ bool ret = true;
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int fnum;
+ struct smbcli_request *req1, *req2;
+
+ printf("TESTING CHANGE NOTIFY WITH MASK CHANGE\n");
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ /*
+ get a handle on the directory
+ */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+
+ status = smb_raw_open(cli->tree, mem_ctx, &io);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ /* ask for a change notify, on file or directory name
+ changes. Setup both with and without recursion */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_ATTRIBUTES;
+ notify.nttrans.in.file.fnum = fnum;
+
+ notify.nttrans.in.recursive = true;
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ notify.nttrans.in.recursive = false;
+ req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ /* cancel initial requests so the buffer is setup */
+ smb_raw_ntcancel(req1);
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
+
+ smb_raw_ntcancel(req2);
+ status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
+
+ notify.nttrans.in.recursive = true;
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ /* Set to hidden then back again. */
+ smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));
+ smbcli_setatr(cli->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_HIDDEN, 0);
+ smbcli_unlink(cli->tree, BASEDIR "\\tname1");
+
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_MODIFIED, ret, done,
+ "wrong action (exp: MODIFIED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "tname1",
+ STR_UNICODE);
+
+ /* Now try and change the mask to include other events.
+ * This should not work - once the mask is set on a directory
+ * fnum it seems to be fixed until the fnum is closed. */
+
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME | FILE_NOTIFY_CHANGE_ATTRIBUTES | FILE_NOTIFY_CHANGE_CREATION;
+ notify.nttrans.in.recursive = true;
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ notify.nttrans.in.recursive = false;
+ req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
+ smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name\\subname1");
+ smbcli_close(cli->tree,
+ smbcli_open(cli->tree, BASEDIR "\\subdir-name\\subname2", O_CREAT, 0));
+ smbcli_rename(cli->tree, BASEDIR "\\subdir-name\\subname1", BASEDIR "\\subdir-name\\subname1-r");
+ smbcli_rename(cli->tree, BASEDIR "\\subdir-name\\subname2", BASEDIR "\\subname2-r");
+ smbcli_rename(cli->tree, BASEDIR "\\subname2-r", BASEDIR "\\subname3-r");
+
+ smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name\\subname1-r");
+ smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+ smbcli_unlink(cli->tree, BASEDIR "\\subname3-r");
+
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_MODIFIED, ret, done,
+ "wrong action (exp: MODIFIED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subname2-r",
+ STR_UNICODE);
- CHECK_VAL(notify.out.num_changes, 3);
- CHECK_VAL(notify.out.changes[0].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name\\subname1-r", STR_UNICODE);
- CHECK_VAL(notify.out.changes[1].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[1].name, "subdir-name", STR_UNICODE);
- CHECK_VAL(notify.out.changes[2].action, NOTIFY_ACTION_REMOVED);
- CHECK_WSTR(notify.out.changes[2].name, "subname3-r", STR_UNICODE);
+ status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_MODIFIED, ret, done,
+ "wrong action (exp: MODIFIED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subname3-r",
+ STR_UNICODE);
done:
smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
return ret;
}
/*
testing of mask bits for change notify
*/
-static BOOL test_notify_mask(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
+static bool test_notify_mask(struct torture_context *tctx,
+ struct smbcli_state *cli,
+ struct smbcli_state *cli2)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
+ union smb_chkpath chkpath;
int fnum, fnum2;
uint32_t mask;
int i;
char c = 1;
+ struct timeval tv;
+ NTTIME t;
printf("TESTING CHANGE NOTIFY COMPLETION FILTERS\n");
-
+
+ torture_assert(tctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ tv = timeval_current_ofs(1000, 0);
+ t = timeval_to_nttime(&tv);
+
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.security_flags = 0;
io.ntcreatex.in.fname = BASEDIR;
- notify.in.buffer_size = 1000;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.recursive = true;
+
+ chkpath.chkpath.in.path = "\\";
-#define NOTIFY_MASK_TEST(setup, op, cleanup, Action, expected, nchanges) \
- do { for (mask=i=0;i<32;i++) { \
+#define NOTIFY_MASK_TEST(test_name, setup, op, cleanup, Action, expected, nchanges) \
+ do { \
+ smbcli_getatr(cli->tree, test_name, NULL, NULL, NULL); \
+ for (mask=i=0;i<32;i++) { \
struct smbcli_request *req; \
- status = smb_raw_open(cli->tree, mem_ctx, &io); \
- CHECK_STATUS(status, NT_STATUS_OK); \
+ status = smb_raw_open(cli->tree, tctx, &io); \
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done, \
+ "smb_raw_open"); \
fnum = io.ntcreatex.out.file.fnum; \
setup \
- notify.in.file.fnum = fnum; \
- notify.in.completion_filter = (1<<i); \
+ notify.nttrans.in.file.fnum = fnum; \
+ notify.nttrans.in.completion_filter = (1<<i); \
req = smb_raw_changenotify_send(cli->tree, ¬ify); \
+ smb_raw_chkpath(cli->tree, &chkpath); \
op \
- msleep(10); smb_raw_ntcancel(req); \
- status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify); \
+ smb_msleep(200); smb_raw_ntcancel(req); \
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify); \
cleanup \
+ smbcli_close(cli->tree, fnum); \
if (NT_STATUS_EQUAL(status, NT_STATUS_CANCELLED)) continue; \
- CHECK_STATUS(status, NT_STATUS_OK); \
- if (nchanges != notify.out.num_changes || \
- notify.out.changes[0].action != Action || \
- strcmp(notify.out.changes[0].name.s, "tname1") != 0) { \
- printf("nchanges=%d action=%d filter=0x%08x\n", \
- notify.out.num_changes, \
- notify.out.changes[0].action, \
- notify.in.completion_filter); \
- ret = False; \
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done, \
+ "smbcli_close"); \
+ /* special case to cope with file rename behaviour */ \
+ if (nchanges == 2 && notify.nttrans.out.num_changes == 1 && \
+ notify.nttrans.out.changes[0].action == NOTIFY_ACTION_MODIFIED && \
+ ((expected) & FILE_NOTIFY_CHANGE_ATTRIBUTES) && \
+ Action == NOTIFY_ACTION_OLD_NAME) { \
+ printf("(rename file special handling OK)\n"); \
+ } else { \
+ torture_assert_int_equal_goto(tctx, \
+ notify.nttrans.out.num_changes,\
+ nchanges, ret, done, \
+ talloc_asprintf(tctx, \
+ "nchanges=%d expected=%d action=%d " \
+ "filter=0x%08x\n", \
+ notify.nttrans.out.num_changes, \
+ nchanges, \
+ notify.nttrans.out.changes[0].action, \
+ notify.nttrans.in.completion_filter)); \
+ torture_assert_int_equal_goto(tctx, \
+ notify.nttrans.out.changes[0].action, \
+ Action, ret, done, \
+ talloc_asprintf(tctx, \
+ "nchanges=%d action=%d " \
+ "expectedAction=%d filter=0x%08x\n", \
+ notify.nttrans.out.num_changes, \
+ notify.nttrans.out.changes[0].action, \
+ Action, \
+ notify.nttrans.in.completion_filter)); \
+ torture_assert_str_equal_goto(tctx, \
+ notify.nttrans.out.changes[0].name.s, \
+ "tname1", ret, done, \
+ talloc_asprintf(tctx, \
+ "nchanges=%d action=%d filter=0x%08x " \
+ "name=%s expected_name=tname1\n", \
+ notify.nttrans.out.num_changes, \
+ notify.nttrans.out.changes[0].action, \
+ notify.nttrans.in.completion_filter, \
+ notify.nttrans.out.changes[0].name.s));\
} \
mask |= (1<<i); \
- smbcli_close(cli->tree, fnum); \
} \
- CHECK_VAL(mask, expected); \
- } while (0)
+ if ((expected) != mask) { \
+ torture_assert_int_not_equal_goto(tctx, ((expected) & ~mask), \
+ 0, ret, done, "Too few bits"); \
+ printf("WARNING: trigger on too many bits. mask=0x%08x expected=0x%08x\n", \
+ mask, expected); \
+ } \
+ } while (0);
- printf("testing mkdir\n");
- NOTIFY_MASK_TEST(;,
+ printf("Testing mkdir\n");
+ NOTIFY_MASK_TEST("Testing mkdir",;,
smbcli_mkdir(cli->tree, BASEDIR "\\tname1");,
- smbcli_rmdir(cli->tree, BASEDIR "\\tname1");,
+ smbcli_rmdir(cli2->tree, BASEDIR "\\tname1");,
NOTIFY_ACTION_ADDED,
FILE_NOTIFY_CHANGE_DIR_NAME, 1);
- printf("testing create file\n");
- NOTIFY_MASK_TEST(;,
+ printf("Testing create file\n");
+ NOTIFY_MASK_TEST("Testing create file",;,
smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));,
- smbcli_unlink(cli->tree, BASEDIR "\\tname1");,
+ smbcli_unlink(cli2->tree, BASEDIR "\\tname1");,
NOTIFY_ACTION_ADDED,
FILE_NOTIFY_CHANGE_FILE_NAME, 1);
- printf("testing unlink\n");
- NOTIFY_MASK_TEST(
+ printf("Testing unlink\n");
+ NOTIFY_MASK_TEST("Testing unlink",
smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));,
- smbcli_unlink(cli->tree, BASEDIR "\\tname1");,
+ smbcli_unlink(cli2->tree, BASEDIR "\\tname1");,
;,
NOTIFY_ACTION_REMOVED,
FILE_NOTIFY_CHANGE_FILE_NAME, 1);
- printf("testing rmdir\n");
- NOTIFY_MASK_TEST(
+ printf("Testing rmdir\n");
+ NOTIFY_MASK_TEST("Testing rmdir",
smbcli_mkdir(cli->tree, BASEDIR "\\tname1");,
- smbcli_rmdir(cli->tree, BASEDIR "\\tname1");,
+ smbcli_rmdir(cli2->tree, BASEDIR "\\tname1");,
;,
NOTIFY_ACTION_REMOVED,
FILE_NOTIFY_CHANGE_DIR_NAME, 1);
- printf("testing rename file\n");
- NOTIFY_MASK_TEST(
+ printf("Testing rename file\n");
+ NOTIFY_MASK_TEST("Testing rename file",
smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));,
- smbcli_rename(cli->tree, BASEDIR "\\tname1", BASEDIR "\\tname2");,
+ smbcli_rename(cli2->tree, BASEDIR "\\tname1", BASEDIR "\\tname2");,
smbcli_unlink(cli->tree, BASEDIR "\\tname2");,
NOTIFY_ACTION_OLD_NAME,
FILE_NOTIFY_CHANGE_FILE_NAME|FILE_NOTIFY_CHANGE_ATTRIBUTES|FILE_NOTIFY_CHANGE_CREATION, 2);
- printf("testing rename dir\n");
- NOTIFY_MASK_TEST(
+ printf("Testing rename dir\n");
+ NOTIFY_MASK_TEST("Testing rename dir",
smbcli_mkdir(cli->tree, BASEDIR "\\tname1");,
- smbcli_rename(cli->tree, BASEDIR "\\tname1", BASEDIR "\\tname2");,
+ smbcli_rename(cli2->tree, BASEDIR "\\tname1", BASEDIR "\\tname2");,
smbcli_rmdir(cli->tree, BASEDIR "\\tname2");,
NOTIFY_ACTION_OLD_NAME,
FILE_NOTIFY_CHANGE_DIR_NAME, 2);
- printf("testing set path attribute\n");
- NOTIFY_MASK_TEST(
+ printf("Testing set path attribute\n");
+ NOTIFY_MASK_TEST("Testing set path attribute",
smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));,
- smbcli_setatr(cli->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_HIDDEN, 0);,
+ smbcli_setatr(cli2->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_HIDDEN, 0);,
smbcli_unlink(cli->tree, BASEDIR "\\tname1");,
NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_ATTRIBUTES, 1);
- printf("testing set path write time\n");
- NOTIFY_MASK_TEST(
+ printf("Testing set path write time\n");
+ NOTIFY_MASK_TEST("Testing set path write time",
smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1", O_CREAT, 0));,
- smbcli_setatr(cli->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_NORMAL, 1000);,
+ smbcli_setatr(cli2->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_NORMAL, 1000);,
smbcli_unlink(cli->tree, BASEDIR "\\tname1");,
NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_LAST_WRITE, 1);
- printf("testing set file attribute\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_fsetatr(cli->tree, fnum2, FILE_ATTRIBUTE_HIDDEN, 0, 0, 0, 0);,
- (smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
+ printf("Testing set file attribute\n");
+ NOTIFY_MASK_TEST("Testing set file attribute",
+ fnum2 = create_complex_file(cli2, tctx, BASEDIR "\\tname1");,
+ smbcli_fsetatr(cli2->tree, fnum2, FILE_ATTRIBUTE_HIDDEN, 0, 0, 0, 0);,
+ (smbcli_close(cli2->tree, fnum2), smbcli_unlink(cli2->tree, BASEDIR "\\tname1"));,
NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_ATTRIBUTES, 1);
- printf("testing set file create time\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_fsetatr(cli->tree, fnum2, 0, 1000*1000, 0, 0, 0);,
- (smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
- NOTIFY_ACTION_MODIFIED,
- FILE_NOTIFY_CHANGE_CREATION, 1);
+ if (torture_setting_bool(tctx, "samba3", false)) {
+ printf("Samba3 does not yet support create times "
+ "everywhere\n");
+ }
+ else {
+ printf("Testing set file create time\n");
+ NOTIFY_MASK_TEST("Testing set file create time",
+ fnum2 = create_complex_file(cli, tctx,
+ BASEDIR "\\tname1");,
+ smbcli_fsetatr(cli->tree, fnum2, 0, t, 0, 0, 0);,
+ (smbcli_close(cli->tree, fnum2),
+ smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
+ NOTIFY_ACTION_MODIFIED,
+ FILE_NOTIFY_CHANGE_CREATION, 1);
+ }
- printf("testing set file access time\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_fsetatr(cli->tree, fnum2, 0, 0, 1000*1000, 0, 0);,
+ printf("Testing set file access time\n");
+ NOTIFY_MASK_TEST("Testing set file access time",
+ fnum2 = create_complex_file(cli, tctx, BASEDIR "\\tname1");,
+ smbcli_fsetatr(cli->tree, fnum2, 0, 0, t, 0, 0);,
(smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_LAST_ACCESS, 1);
- printf("testing set file write time\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_fsetatr(cli->tree, fnum2, 0, 0, 0, 1000*1000, 0);,
+ printf("Testing set file write time\n");
+ NOTIFY_MASK_TEST("Testing set file write time",
+ fnum2 = create_complex_file(cli, tctx, BASEDIR "\\tname1");,
+ smbcli_fsetatr(cli->tree, fnum2, 0, 0, 0, t, 0);,
(smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
NOTIFY_ACTION_MODIFIED,
FILE_NOTIFY_CHANGE_LAST_WRITE, 1);
- printf("testing set file change time\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_fsetatr(cli->tree, fnum2, 0, 0, 0, 0, 1000*1000);,
+ printf("Testing set file change time\n");
+ NOTIFY_MASK_TEST("Testing set file change time",
+ fnum2 = create_complex_file(cli, tctx, BASEDIR "\\tname1");,
+ smbcli_fsetatr(cli->tree, fnum2, 0, 0, 0, 0, t);,
(smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
NOTIFY_ACTION_MODIFIED,
0, 1);
- printf("testing write\n");
- NOTIFY_MASK_TEST(
- fnum2 = create_complex_file(cli, mem_ctx, BASEDIR "\\tname1");,
- smbcli_write(cli->tree, fnum2, 1, &c, 10000, 1);,
- (smbcli_close(cli->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
+ printf("Testing write\n");
+ NOTIFY_MASK_TEST("Testing write",
+ fnum2 = create_complex_file(cli2, tctx, BASEDIR "\\tname1");,
+ smbcli_write(cli2->tree, fnum2, 1, &c, 10000, 1);,
+ (smbcli_close(cli2->tree, fnum2), smbcli_unlink(cli->tree, BASEDIR "\\tname1"));,
NOTIFY_ACTION_MODIFIED,
0, 1);
+ printf("Testing truncate\n");
+ NOTIFY_MASK_TEST("Testing truncate",
+ fnum2 = create_complex_file(cli2, tctx, BASEDIR "\\tname1");,
+ smbcli_ftruncate(cli2->tree, fnum2, 10000);,
+ (smbcli_close(cli2->tree, fnum2), smbcli_unlink(cli2->tree, BASEDIR "\\tname1"));,
+ NOTIFY_ACTION_MODIFIED,
+ FILE_NOTIFY_CHANGE_SIZE | FILE_NOTIFY_CHANGE_ATTRIBUTES, 1);
+
done:
smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
return ret;
}
/*
basic testing of change notify on files
*/
-static BOOL test_notify_file(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
+static bool test_notify_file(struct torture_context *mem_ctx,
+ struct smbcli_state *cli)
{
NTSTATUS status;
- BOOL ret = True;
+ bool ret = true;
union smb_open io;
union smb_close cl;
- struct smb_notify notify;
+ union smb_notify notify;
struct smbcli_request *req;
int fnum;
const char *fname = BASEDIR "\\file.txt";
printf("TESTING CHANGE NOTIFY ON FILES\n");
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
io.ntcreatex.in.create_options = 0;
io.ntcreatex.in.security_flags = 0;
io.ntcreatex.in.fname = fname;
status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.file.fnum = fnum;
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_STREAM_NAME;
- notify.in.recursive = False;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_STREAM_NAME;
+ notify.nttrans.in.recursive = false;
- printf("testing if notifies on file handles are invalid (should be)\n");
+ printf("Testing if notifies on file handles are invalid (should be)\n");
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_INVALID_PARAMETER);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_INVALID_PARAMETER,
+ ret, done,
+ "smb_raw_changenotify_recv");
cl.close.level = RAW_CLOSE_CLOSE;
cl.close.in.file.fnum = fnum;
cl.close.in.write_time = 0;
status = smb_raw_close(cli->tree, &cl);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_close");
status = smbcli_unlink(cli->tree, fname);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smbcli_unlink");
done:
smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
return ret;
}
/*
basic testing of change notifies followed by a tdis
*/
-static BOOL test_notify_tdis(TALLOC_CTX *mem_ctx)
+static bool test_notify_tdis(struct torture_context *tctx,
+ struct smbcli_state *cli1)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
int fnum;
struct smbcli_request *req;
printf("TESTING CHANGE NOTIFY FOLLOWED BY TDIS\n");
- if (!torture_open_connection(&cli)) {
- return False;
- }
+ torture_assert(tctx, torture_setup_dir(cli1, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ torture_assert(tctx, torture_open_connection(&cli, tctx, 0),
+ "Failed to open connection.");
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.security_flags = 0;
io.ntcreatex.in.fname = BASEDIR;
- status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ status = smb_raw_open(cli->tree, tctx, &io);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smbcli_tdis(cli);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smbcli_tdis");
+ cli->tree = NULL;
- status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 0);
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(tctx, notify.nttrans.out.num_changes,
+ 0, ret, done, "no changes expected");
done:
torture_close_connection(cli);
+ smbcli_deltree(cli1->tree, BASEDIR);
return ret;
}
/*
basic testing of change notifies followed by a exit
*/
-static BOOL test_notify_exit(TALLOC_CTX *mem_ctx)
+static bool test_notify_exit(struct torture_context *tctx,
+ struct smbcli_state *cli1)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
int fnum;
struct smbcli_request *req;
printf("TESTING CHANGE NOTIFY FOLLOWED BY EXIT\n");
- if (!torture_open_connection(&cli)) {
- return False;
- }
+ torture_assert(tctx, torture_setup_dir(cli1, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ torture_assert(tctx, torture_open_connection(&cli, tctx, 0),
+ "Failed to open connection.");
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.security_flags = 0;
io.ntcreatex.in.fname = BASEDIR;
- status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ status = smb_raw_open(cli->tree, tctx, &io);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_exit(cli->session);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_exit");
- status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 0);
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(tctx, notify.nttrans.out.num_changes,
+ 0, ret, done, "no changes expected");
done:
torture_close_connection(cli);
+ smbcli_deltree(cli1->tree, BASEDIR);
return ret;
}
/*
basic testing of change notifies followed by a ulogoff
*/
-static BOOL test_notify_ulogoff(TALLOC_CTX *mem_ctx)
+static bool test_notify_ulogoff(struct torture_context *tctx,
+ struct smbcli_state *cli1)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
int fnum;
struct smbcli_request *req;
printf("TESTING CHANGE NOTIFY FOLLOWED BY ULOGOFF\n");
- if (!torture_open_connection(&cli)) {
- return False;
- }
+ torture_assert(tctx, torture_setup_dir(cli1, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ torture_assert(tctx, torture_open_connection(&cli, tctx, 0),
+ "Failed to open connection.");
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.security_flags = 0;
io.ntcreatex.in.fname = BASEDIR;
- status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ status = smb_raw_open(cli->tree, tctx, &io);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
req = smb_raw_changenotify_send(cli->tree, ¬ify);
status = smb_raw_ulogoff(cli->session);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_ulogoff");
- status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 0);
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(tctx, notify.nttrans.out.num_changes,
+ 0, ret, done, "no changes expected");
done:
torture_close_connection(cli);
+ smbcli_deltree(cli1->tree, BASEDIR);
return ret;
}
+static void tcp_dis_handler(struct smbcli_transport *t, void *p)
+{
+ struct smbcli_state *cli = (struct smbcli_state *)p;
+ smbcli_transport_dead(cli->transport, NT_STATUS_LOCAL_DISCONNECT);
+ cli->transport = NULL;
+ cli->tree = NULL;
+}
+/*
+ basic testing of change notifies followed by tcp disconnect
+*/
+static bool test_notify_tcp_dis(struct torture_context *tctx,
+ struct smbcli_state *cli1)
+{
+ bool ret = true;
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int fnum;
+ struct smbcli_request *req;
+ struct smbcli_state *cli = NULL;
+
+ printf("TESTING CHANGE NOTIFY FOLLOWED BY TCP DISCONNECT\n");
+
+ torture_assert(tctx, torture_setup_dir(cli1, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ torture_assert(tctx, torture_open_connection(&cli, tctx, 0),
+ "Failed to open connection.");
+
+ /*
+ get a handle on the directory
+ */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+
+ status = smb_raw_open(cli->tree, tctx, &io);
+ torture_assert_ntstatus_ok_goto(tctx, status, ret, done,
+ "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ /* ask for a change notify,
+ on file or directory name changes */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
+
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ smbcli_transport_idle_handler(cli->transport, tcp_dis_handler, 250, cli);
+
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_equal_goto(tctx, status,
+ NT_STATUS_LOCAL_DISCONNECT,
+ ret, done,
+ "smb_raw_changenotify_recv");
+
+done:
+ torture_close_connection(cli);
+ smbcli_deltree(cli1->tree, BASEDIR);
+ return ret;
+}
/*
test setting up two change notify requests on one handle
*/
-static BOOL test_notify_double(struct smbcli_state *cli, TALLOC_CTX *mem_ctx)
+static bool test_notify_double(struct torture_context *mem_ctx,
+ struct smbcli_state *cli)
{
- BOOL ret = True;
+ bool ret = true;
NTSTATUS status;
- struct smb_notify notify;
+ union smb_notify notify;
union smb_open io;
int fnum;
struct smbcli_request *req1, *req2;
printf("TESTING CHANGE NOTIFY TWICE ON ONE DIRECTORY\n");
-
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
/*
get a handle on the directory
*/
io.generic.level = RAW_OPEN_NTCREATEX;
- io.ntcreatex.in.root_fid = 0;
+ io.ntcreatex.in.root_fid.fnum = 0;
io.ntcreatex.in.flags = 0;
io.ntcreatex.in.access_mask = SEC_FILE_ALL;
io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
io.ntcreatex.in.fname = BASEDIR;
status = smb_raw_open(cli->tree, mem_ctx, &io);
- CHECK_STATUS(status, NT_STATUS_OK);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
fnum = io.ntcreatex.out.file.fnum;
/* ask for a change notify,
on file or directory name changes */
- notify.in.buffer_size = 1000;
- notify.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
- notify.in.file.fnum = fnum;
- notify.in.recursive = True;
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
req2 = smb_raw_changenotify_send(cli->tree, ¬ify);
smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name", STR_UNICODE);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name2");
status = smb_raw_changenotify_recv(req2, mem_ctx, ¬ify);
- CHECK_STATUS(status, NT_STATUS_OK);
- CHECK_VAL(notify.out.num_changes, 1);
- CHECK_WSTR(notify.out.changes[0].name, "subdir-name2", STR_UNICODE);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "subdir-name2",
+ STR_UNICODE);
done:
smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
return ret;
}
+
/*
- basic testing of change notify
+ test multiple change notifies at different depths and with/without recursion
*/
-BOOL torture_raw_notify(struct torture_context *torture)
+static bool test_notify_tree(struct torture_context *mem_ctx,
+ struct smbcli_state *cli,
+ struct smbcli_state *cli2)
{
- struct smbcli_state *cli;
- BOOL ret = True;
- TALLOC_CTX *mem_ctx;
+ bool ret = true;
+ union smb_notify notify;
+ union smb_open io;
+ struct smbcli_request *req;
+ struct timeval tv;
+ struct {
+ const char *path;
+ bool recursive;
+ uint32_t filter;
+ int expected;
+ int fnum;
+ int counted;
+ } dirs[] = {
+ {BASEDIR "\\abc", true, FILE_NOTIFY_CHANGE_NAME, 30 },
+ {BASEDIR "\\zqy", true, FILE_NOTIFY_CHANGE_NAME, 8 },
+ {BASEDIR "\\atsy", true, FILE_NOTIFY_CHANGE_NAME, 4 },
+ {BASEDIR "\\abc\\foo", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\abc\\blah", true, FILE_NOTIFY_CHANGE_NAME, 13 },
+ {BASEDIR "\\abc\\blah", false, FILE_NOTIFY_CHANGE_NAME, 7 },
+ {BASEDIR "\\abc\\blah\\a", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\abc\\blah\\b", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\abc\\blah\\c", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\abc\\fooblah", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\zqy\\xx", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\zqy\\yyy", true, FILE_NOTIFY_CHANGE_NAME, 2 },
+ {BASEDIR "\\zqy\\..", true, FILE_NOTIFY_CHANGE_NAME, 40 },
+ {BASEDIR, true, FILE_NOTIFY_CHANGE_NAME, 40 },
+ {BASEDIR, false,FILE_NOTIFY_CHANGE_NAME, 6 },
+ {BASEDIR "\\atsy", false,FILE_NOTIFY_CHANGE_NAME, 4 },
+ {BASEDIR "\\abc", true, FILE_NOTIFY_CHANGE_NAME, 24 },
+ {BASEDIR "\\abc", false,FILE_NOTIFY_CHANGE_FILE_NAME, 0 },
+ {BASEDIR "\\abc", true, FILE_NOTIFY_CHANGE_FILE_NAME, 0 },
+ {BASEDIR "\\abc", true, FILE_NOTIFY_CHANGE_NAME, 24 },
+ };
+ int i;
+ NTSTATUS status;
+ bool all_done = false;
+
+ printf("TESTING CHANGE NOTIFY FOR DIFFERENT DEPTHS\n");
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 20000;
+
+ /*
+ setup the directory tree, and the notify buffer on each directory
+ */
+ for (i=0;i<ARRAY_SIZE(dirs);i++) {
+ io.ntcreatex.in.fname = dirs[i].path;
+ status = smb_raw_open(cli->tree, mem_ctx, &io);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
+ dirs[i].fnum = io.ntcreatex.out.file.fnum;
+
+ notify.nttrans.in.completion_filter = dirs[i].filter;
+ notify.nttrans.in.file.fnum = dirs[i].fnum;
+ notify.nttrans.in.recursive = dirs[i].recursive;
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smb_raw_ntcancel(req);
+ status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
+ }
+
+ /* trigger 2 events in each dir */
+ for (i=0;i<ARRAY_SIZE(dirs);i++) {
+ char *path = talloc_asprintf(mem_ctx, "%s\\test.dir", dirs[i].path);
+ /*
+ * Make notifies a bit more interesting in a cluster
+ * by doing the changes against different nodes with
+ * --unclist
+ */
+ smbcli_mkdir(cli->tree, path);
+ smbcli_rmdir(cli2->tree, path);
+ talloc_free(path);
+ }
+
+ /* give a bit of time for the events to propogate */
+ tv = timeval_current();
+
+ do {
+ /* count events that have happened in each dir */
+ for (i=0;i<ARRAY_SIZE(dirs);i++) {
+ notify.nttrans.in.file.fnum = dirs[i].fnum;
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smb_raw_ntcancel(req);
+ notify.nttrans.out.num_changes = 0;
+ status = smb_raw_changenotify_recv(req, mem_ctx, ¬ify);
+ dirs[i].counted += notify.nttrans.out.num_changes;
+ }
- if (!torture_open_connection(&cli)) {
- return False;
+ all_done = true;
+
+ for (i=0;i<ARRAY_SIZE(dirs);i++) {
+ if (dirs[i].counted != dirs[i].expected) {
+ all_done = false;
+ }
+ }
+ } while (!all_done && timeval_elapsed(&tv) < 20);
+
+ printf("took %.4f seconds to propogate all events\n", timeval_elapsed(&tv));
+
+ for (i=0;i<ARRAY_SIZE(dirs);i++) {
+ torture_assert_int_equal_goto(mem_ctx,
+ dirs[i].counted, dirs[i].expected, ret, done,
+ talloc_asprintf(mem_ctx,
+ "unexpected number of events for '%s'",
+ dirs[i].path));
+ }
+
+ /*
+ run from the back, closing and deleting
+ */
+ for (i=ARRAY_SIZE(dirs)-1;i>=0;i--) {
+ smbcli_close(cli->tree, dirs[i].fnum);
+ smbcli_rmdir(cli->tree, dirs[i].path);
}
- mem_ctx = talloc_init("torture_raw_notify");
+done:
+ smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
+ return ret;
+}
+
+/*
+ Test response when cached server events exceed single NT NOTFIY response
+ packet size.
+*/
+static bool test_notify_overflow(struct torture_context *mem_ctx,
+ struct smbcli_state *cli)
+{
+ bool ret = true;
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int fnum;
+ int count = 100;
+ struct smbcli_request *req1;
+ int i;
+
+ printf("TESTING CHANGE NOTIFY EVENT OVERFLOW\n");
+
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ /* get a handle on the directory */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+ NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+
+ status = smb_raw_open(cli->tree, mem_ctx, &io);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ /* ask for a change notify, on name changes. */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
- if (!torture_setup_dir(cli, BASEDIR)) {
- return False;
+ notify.nttrans.in.recursive = true;
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ /* cancel initial requests so the buffer is setup */
+ smb_raw_ntcancel(req1);
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_equal_goto(mem_ctx, status,
+ NT_STATUS_CANCELLED,
+ ret, done,
+ "smb_raw_changenotify_recv");
+
+ /* open a lot of files, filling up the server side notify buffer */
+ printf("Testing overflowed buffer notify on create of %d files\n",
+ count);
+ for (i=0;i<count;i++) {
+ char *fname = talloc_asprintf(cli, BASEDIR "\\test%d.txt", i);
+ int fnum2 = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR,
+ DENY_NONE);
+ torture_assert_int_not_equal_goto(mem_ctx, fnum2, -1, ret, done,
+ talloc_asprintf(mem_ctx, "Failed to create %s - %s",
+ fname, smbcli_errstr(cli->tree)));
+ talloc_free(fname);
+ smbcli_close(cli->tree, fnum2);
}
+ /* expect that 0 events will be returned with NT_STATUS_OK */
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 0, ret, done, "no changes expected");
+
+done:
+ smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
+ return ret;
+}
+
+/*
+ Test if notifications are returned for changes to the base directory.
+ They shouldn't be.
+*/
+static bool test_notify_basedir(struct torture_context *mem_ctx,
+ struct smbcli_state *cli)
+{
+ bool ret = true;
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int fnum;
+ struct smbcli_request *req1;
+
+ printf("TESTING CHANGE NOTIFY BASEDIR EVENTS\n");
- ret &= test_notify_dir(cli, mem_ctx);
- ret &= test_notify_mask(cli, mem_ctx);
- ret &= test_notify_recursive(cli, mem_ctx);
- ret &= test_notify_file(cli, mem_ctx);
- ret &= test_notify_tdis(mem_ctx);
- ret &= test_notify_exit(mem_ctx);
- ret &= test_notify_ulogoff(mem_ctx);
- ret &= test_notify_double(cli, mem_ctx);
+ torture_assert(mem_ctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ /* get a handle on the directory */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+ NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+ status = smb_raw_open(cli->tree, mem_ctx, &io);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ /* create a test file that will also be modified */
+ smbcli_close(cli->tree, smbcli_open(cli->tree, BASEDIR "\\tname1",
+ O_CREAT, 0));
+
+ /* ask for a change notify, on attribute changes. */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_ATTRIBUTES;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
+
+ req1 = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ /* set attribute on the base dir */
+ smbcli_setatr(cli->tree, BASEDIR, FILE_ATTRIBUTE_HIDDEN, 0);
+
+ /* set attribute on a file to assure we receive a notification */
+ smbcli_setatr(cli->tree, BASEDIR "\\tname1", FILE_ATTRIBUTE_HIDDEN, 0);
+ smb_msleep(200);
+
+ /* check how many responses were given, expect only 1 for the file */
+ status = smb_raw_changenotify_recv(req1, mem_ctx, ¬ify);
+ torture_assert_ntstatus_ok_goto(mem_ctx, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(mem_ctx, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(mem_ctx,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_MODIFIED, ret, done,
+ "wrong action (exp: MODIFIED)");
+ CHECK_WSTR(mem_ctx, notify.nttrans.out.changes[0].name, "tname1",
+ STR_UNICODE);
+
+done:
smb_raw_exit(cli->session);
smbcli_deltree(cli->tree, BASEDIR);
- torture_close_connection(cli);
- talloc_free(mem_ctx);
return ret;
}
+
+
+/*
+ create a secondary tree connect - used to test for a bug in Samba3 messaging
+ with change notify
+*/
+static struct smbcli_tree *secondary_tcon(struct smbcli_state *cli,
+ struct torture_context *tctx)
+{
+ NTSTATUS status;
+ const char *share, *host;
+ struct smbcli_tree *tree;
+ union smb_tcon tcon;
+
+ share = torture_setting_string(tctx, "share", NULL);
+ host = torture_setting_string(tctx, "host", NULL);
+
+ printf("create a second tree context on the same session\n");
+ tree = smbcli_tree_init(cli->session, tctx, false);
+
+ tcon.generic.level = RAW_TCON_TCONX;
+ tcon.tconx.in.flags = TCONX_FLAG_EXTENDED_RESPONSE;
+ tcon.tconx.in.password = data_blob(NULL, 0);
+ tcon.tconx.in.path = talloc_asprintf(tctx, "\\\\%s\\%s", host, share);
+ tcon.tconx.in.device = "A:";
+ status = smb_raw_tcon(tree, tctx, &tcon);
+ if (!NT_STATUS_IS_OK(status)) {
+ talloc_free(tree);
+ printf("Failed to create secondary tree\n");
+ return NULL;
+ }
+
+ tree->tid = tcon.tconx.out.tid;
+ printf("tid1=%d tid2=%d\n", cli->tree->tid, tree->tid);
+
+ return tree;
+}
+
+
+/*
+ very simple change notify test
+*/
+static bool test_notify_tcon(struct torture_context *torture,
+ struct smbcli_state *cli)
+{
+ bool ret = true;
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int fnum;
+ struct smbcli_request *req;
+ extern int torture_numops;
+ struct smbcli_tree *tree = NULL;
+
+ printf("TESTING SIMPLE CHANGE NOTIFY\n");
+
+ torture_assert(torture, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ /*
+ get a handle on the directory
+ */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ | NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+
+ status = smb_raw_open(cli->tree, torture, &io);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ status = smb_raw_open(cli->tree, torture, &io);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_open");
+
+ /* ask for a change notify,
+ on file or directory name changes */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = true;
+
+ printf("Testing notify mkdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("Testing notify rmdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("SIMPLE CHANGE NOTIFY OK\n");
+
+ printf("TESTING WITH SECONDARY TCON\n");
+ tree = secondary_tcon(cli, torture);
+
+ printf("Testing notify mkdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("Testing notify rmdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("CHANGE NOTIFY WITH TCON OK\n");
+
+ printf("Disconnecting secondary tree\n");
+ status = smb_tree_disconnect(tree);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_tree_disconnect");
+ talloc_free(tree);
+
+ printf("Testing notify mkdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_mkdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_ADDED, ret, done,
+ "wrong action (exp: ADDED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("Testing notify rmdir\n");
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ smbcli_rmdir(cli->tree, BASEDIR "\\subdir-name");
+
+ status = smb_raw_changenotify_recv(req, torture, ¬ify);
+ torture_assert_ntstatus_ok_goto(torture, status, ret, done,
+ "smb_raw_changenotify_recv");
+ torture_assert_int_equal_goto(torture, notify.nttrans.out.num_changes,
+ 1, ret, done, "wrong number of changes");
+ torture_assert_int_equal_goto(torture,
+ notify.nttrans.out.changes[0].action,
+ NOTIFY_ACTION_REMOVED, ret, done,
+ "wrong action (exp: REMOVED)");
+ CHECK_WSTR(torture, notify.nttrans.out.changes[0].name, "subdir-name",
+ STR_UNICODE);
+
+ printf("CHANGE NOTIFY WITH TDIS OK\n");
+done:
+ smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
+ return ret;
+}
+
+
+/*
+ testing alignment of multiple change notify infos
+*/
+static bool test_notify_alignment(struct torture_context *tctx,
+ struct smbcli_state *cli)
+{
+ NTSTATUS status;
+ union smb_notify notify;
+ union smb_open io;
+ int i, fnum, fnum2;
+ struct smbcli_request *req;
+ const char *fname = BASEDIR "\\starter";
+ const char *fnames[] = { "a",
+ "ab",
+ "abc",
+ "abcd" };
+ int num_names = ARRAY_SIZE(fnames);
+ char *fpath = NULL;
+
+ torture_comment(tctx, "TESTING CHANGE NOTIFY REPLY ALIGNMENT\n");
+
+ torture_assert(tctx, torture_setup_dir(cli, BASEDIR),
+ "Failed to setup up test directory: " BASEDIR);
+
+ /* get a handle on the directory */
+ io.generic.level = RAW_OPEN_NTCREATEX;
+ io.ntcreatex.in.root_fid.fnum = 0;
+ io.ntcreatex.in.flags = 0;
+ io.ntcreatex.in.access_mask = SEC_FILE_ALL;
+ io.ntcreatex.in.create_options = NTCREATEX_OPTIONS_DIRECTORY;
+ io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+ io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ |
+ NTCREATEX_SHARE_ACCESS_WRITE;
+ io.ntcreatex.in.alloc_size = 0;
+ io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN;
+ io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+ io.ntcreatex.in.security_flags = 0;
+ io.ntcreatex.in.fname = BASEDIR;
+
+ status = smb_raw_open(cli->tree, tctx, &io);
+ torture_assert_ntstatus_ok(tctx, status, "smb_raw_open");
+ fnum = io.ntcreatex.out.file.fnum;
+
+ /* ask for a change notify, on file creation */
+ notify.nttrans.level = RAW_NOTIFY_NTTRANS;
+ notify.nttrans.in.buffer_size = 1000;
+ notify.nttrans.in.completion_filter = FILE_NOTIFY_CHANGE_FILE_NAME;
+ notify.nttrans.in.file.fnum = fnum;
+ notify.nttrans.in.recursive = false;
+
+ /* start change tracking */
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+
+ fnum2 = smbcli_open(cli->tree, fname, O_CREAT|O_RDWR, DENY_NONE);
+ torture_assert(tctx, fnum2 != -1, smbcli_errstr(cli->tree));
+ smbcli_close(cli->tree, fnum2);
+
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_ok(tctx, status, "smb_raw_changenotify_recv");
+
+ /* create 4 files that will cause CHANGE_NOTIFY_INFO structures
+ * to be returned in the same packet with all possible 4-byte padding
+ * permutations. As per MS-CIFS 2.2.7.4.2 these structures should be
+ * 4-byte aligned. */
+
+ for (i = 0; i < num_names; i++) {
+ fpath = talloc_asprintf(tctx, "%s\\%s", BASEDIR, fnames[i]);
+ fnum2 = smbcli_open(cli->tree, fpath,
+ O_CREAT|O_RDWR, DENY_NONE);
+ torture_assert(tctx, fnum2 != -1, smbcli_errstr(cli->tree));
+ smbcli_close(cli->tree, fnum2);
+ talloc_free(fpath);
+ }
+
+ /* We send a notify packet, and let smb_raw_changenotify_recv() do
+ * the alignment checking for us. */
+ req = smb_raw_changenotify_send(cli->tree, ¬ify);
+ status = smb_raw_changenotify_recv(req, tctx, ¬ify);
+ torture_assert_ntstatus_ok(tctx, status, "smb_raw_changenotify_recv");
+
+ /* Do basic checking for correctness. */
+ torture_assert(tctx, notify.nttrans.out.num_changes == num_names, "");
+ for (i = 0; i < num_names; i++) {
+ torture_assert(tctx, notify.nttrans.out.changes[i].action ==
+ NOTIFY_ACTION_ADDED, "");
+ CHECK_WSTR(tctx, notify.nttrans.out.changes[i].name, fnames[i],
+ STR_UNICODE);
+ }
+
+ smb_raw_exit(cli->session);
+ smbcli_deltree(cli->tree, BASEDIR);
+ return true;
+}
+
+struct torture_suite *torture_raw_notify(TALLOC_CTX *mem_ctx)
+{
+ struct torture_suite *suite = torture_suite_create(mem_ctx, "notify");
+
+ torture_suite_add_1smb_test(suite, "tcon", test_notify_tcon);
+ torture_suite_add_2smb_test(suite, "dir", test_notify_dir);
+ torture_suite_add_2smb_test(suite, "mask", test_notify_mask);
+ torture_suite_add_2smb_test(suite, "recursive", test_notify_recursive);
+ torture_suite_add_1smb_test(suite, "mask_change",
+ test_notify_mask_change);
+ torture_suite_add_1smb_test(suite, "file", test_notify_file);
+ torture_suite_add_1smb_test(suite, "tdis", test_notify_tdis);
+ torture_suite_add_1smb_test(suite, "exit", test_notify_exit);
+ torture_suite_add_1smb_test(suite, "ulogoff", test_notify_ulogoff);
+ torture_suite_add_1smb_test(suite, "tcp_dis", test_notify_tcp_dis);
+ torture_suite_add_1smb_test(suite, "double", test_notify_double);
+ torture_suite_add_2smb_test(suite, "tree", test_notify_tree);
+ torture_suite_add_1smb_test(suite, "overflow", test_notify_overflow);
+ torture_suite_add_1smb_test(suite, "basedir", test_notify_basedir);
+ torture_suite_add_1smb_test(suite, "alignment", test_notify_alignment);
+
+ return suite;
+}
git.samba.org / kai / samba-autobuild / .git / blobdiff