Merge commit 'release-4-0-0alpha15' into master4-tmp
[kai/samba-autobuild/.git] / source4 / lib / ldb / pyldb.c
index 2f87b8cdc3a5c8549b58de14338201613d429eff..e2a2e7180e1de8bc2994a7752faeb934ece79d2b 100644 (file)
@@ -7,10 +7,12 @@
    Copyright (C) 2006 Simo Sorce <idra@samba.org>
    Copyright (C) 2007-2010 Jelmer Vernooij <jelmer@samba.org>
    Copyright (C) 2009-2010 Matthias Dieter Wallnöfer
+   Copyright (C) 2009-2011 Andrew Tridgell
+   Copyright (C) 2009-2011 Andrew Bartlett
 
-        ** NOTE! The following LGPL license applies to the ldb
-        ** library. This does NOT imply that all of Samba is released
-        ** under the LGPL
+    ** NOTE! The following LGPL license applies to the ldb
+    ** library. This does NOT imply that all of Samba is released
+    ** under the LGPL
 
    This library is free software; you can redistribute it and/or
    modify it under the terms of the GNU Lesser General Public
 */
 
 #include <Python.h>
-#include "replace.h"
+#include <pytalloc.h>
 #include "ldb_private.h"
 #include "pyldb.h"
 
+void initldb(void);
+static PyObject *PyLdbMessage_FromMessage(struct ldb_message *msg);
+static PyObject *PyExc_LdbError;
+
+staticforward PyTypeObject PyLdbControl;
+staticforward PyTypeObject PyLdbResult;
+staticforward PyTypeObject PyLdbMessage;
+staticforward PyTypeObject PyLdbModule;
+staticforward PyTypeObject PyLdbDn;
+staticforward PyTypeObject PyLdb;
+staticforward PyTypeObject PyLdbMessageElement;
+staticforward PyTypeObject PyLdbTree;
+static PyObject *PyLdb_FromLdbContext(struct ldb_context *ldb_ctx);
+static PyObject *PyLdbModule_FromModule(struct ldb_module *mod);
+static struct ldb_message_element *PyObject_AsMessageElement(
+                                                     TALLOC_CTX *mem_ctx,
+                                                     PyObject *set_obj,
+                                                     unsigned int flags,
+                                                     const char *attr_name);
+
 /* There's no Py_ssize_t in 2.4, apparently */
 #if PY_MAJOR_VERSION == 2 && PY_MINOR_VERSION < 5
 typedef int Py_ssize_t;
@@ -42,42 +64,165 @@ typedef intargfunc ssizeargfunc;
 #define Py_RETURN_NONE return Py_INCREF(Py_None), Py_None
 #endif
 
-static void PyErr_SetLdbError(PyObject *error, int ret, struct ldb_context *ldb_ctx)
+#define SIGN(a) (((a) == 0)?0:((a) < 0?-1:1))
+
+
+
+static PyObject *py_ldb_control_str(PyLdbControlObject *self)
 {
-       if (ret == LDB_ERR_PYTHON_EXCEPTION)
-               return; /* Python exception should already be set, just keep that */
+       if (self->data != NULL) {
+               char* control = ldb_control_to_string(self->mem_ctx, self->data);
+               if (control == NULL) {
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+               return PyString_FromString(control);
+       } else {
+               return PyString_FromFormat("ldb control");
+       }
+}
 
-       PyErr_SetObject(error, 
-                                       Py_BuildValue(discard_const_p(char, "(i,s)"), ret, 
-                                 ldb_ctx == NULL?ldb_strerror(ret):ldb_errstring(ldb_ctx)));
+static void py_ldb_control_dealloc(PyLdbControlObject *self)
+{
+       if (self->mem_ctx != NULL) {
+               talloc_free(self->mem_ctx);
+       }
+       self->data = NULL;
+       self->ob_type->tp_free(self);
 }
 
-static PyObject *PyExc_LdbError;
+static PyObject *py_ldb_control_get_oid(PyLdbControlObject *self)
+{
+       return PyString_FromString(self->data->oid);
+}
 
-PyAPI_DATA(PyTypeObject) PyLdbMessage;
-PyAPI_DATA(PyTypeObject) PyLdbModule;
-PyAPI_DATA(PyTypeObject) PyLdbDn;
-PyAPI_DATA(PyTypeObject) PyLdb;
-PyAPI_DATA(PyTypeObject) PyLdbMessageElement;
-PyAPI_DATA(PyTypeObject) PyLdbTree;
+static PyObject *py_ldb_control_get_critical(PyLdbControlObject *self)
+{
+       return PyBool_FromLong(self->data->critical);
+}
 
-static PyObject *PyLdb_FromLdbContext(struct ldb_context *ldb_ctx);
+static PyObject *py_ldb_control_set_critical(PyLdbControlObject *self, PyObject *value, void *closure)
+{
+       if (PyObject_IsTrue(value)) {
+               self->data->critical = true;
+       } else {
+               self->data->critical = false;
+       }
+       return 0;
+}
 
-static PyObject *PyObject_FromLdbValue(struct ldb_context *ldb_ctx, 
-                                                          struct ldb_message_element *el, 
-                                                          struct ldb_val *val)
+static PyObject *py_ldb_control_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)
 {
-       struct ldb_val new_val;
-       TALLOC_CTX *mem_ctx = talloc_new(NULL);
-       PyObject *ret;
+       char *data = NULL;
+       const char * const kwnames[] = { "ldb", "data", NULL };
+       struct ldb_control *parsed_controls;
+       PyLdbControlObject *ret;
+       PyObject *py_ldb;
+       TALLOC_CTX *mem_ctx;
+       struct ldb_context *ldb_ctx;
 
-       new_val = *val;
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "Os",
+                                        discard_const_p(char *, kwnames),
+                                        &py_ldb, &data))
+               return NULL;
 
-       ret = PyString_FromStringAndSize((const char *)new_val.data, new_val.length);
+       mem_ctx = talloc_new(NULL);
+       if (mem_ctx == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
 
-       talloc_free(mem_ctx);
+       ldb_ctx = PyLdb_AsLdbContext(py_ldb);
+       parsed_controls = ldb_parse_control_from_string(ldb_ctx, mem_ctx, data);
 
-       return ret;
+       if (!parsed_controls) {
+               talloc_free(mem_ctx);
+               PyErr_SetString(PyExc_ValueError, "unable to parse control string");
+               return NULL;
+       }
+
+       ret = PyObject_New(PyLdbControlObject, type);
+       if (ret == NULL) {
+               PyErr_NoMemory();
+               talloc_free(mem_ctx);
+               return NULL;
+       }
+
+       ret->mem_ctx = mem_ctx;
+
+       ret->data = talloc_move(mem_ctx, &parsed_controls);
+       if (ret->data == NULL) {
+               Py_DECREF(ret);
+               PyErr_NoMemory();
+               talloc_free(mem_ctx);
+               return NULL;
+       }
+
+       return (PyObject *)ret;
+}
+
+static PyGetSetDef py_ldb_control_getset[] = {
+       { discard_const_p(char, "oid"), (getter)py_ldb_control_get_oid, NULL, NULL },
+       { discard_const_p(char, "critical"), (getter)py_ldb_control_get_critical, (setter)py_ldb_control_set_critical, NULL },
+       { NULL }
+};
+
+static PyTypeObject PyLdbControl = {
+       .tp_name = "ldb.control",
+       .tp_dealloc = (destructor)py_ldb_control_dealloc,
+       .tp_getattro = PyObject_GenericGetAttr,
+       .tp_basicsize = sizeof(PyLdbControlObject),
+       .tp_getset = py_ldb_control_getset,
+       .tp_doc = "LDB control.",
+       .tp_str = (reprfunc)py_ldb_control_str,
+       .tp_new = py_ldb_control_new,
+       .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+};
+
+static void PyErr_SetLdbError(PyObject *error, int ret, struct ldb_context *ldb_ctx)
+{
+       if (ret == LDB_ERR_PYTHON_EXCEPTION)
+               return; /* Python exception should already be set, just keep that */
+
+       PyErr_SetObject(error, 
+                       Py_BuildValue(discard_const_p(char, "(i,s)"), ret,
+                                     ldb_ctx == NULL?ldb_strerror(ret):ldb_errstring(ldb_ctx)));
+}
+
+static PyObject *PyObject_FromLdbValue(struct ldb_val *val)
+{
+       return PyString_FromStringAndSize((const char *)val->data, val->length);
+}
+
+/**
+ * Create a Python object from a ldb_result.
+ *
+ * @param result LDB result to convert
+ * @return Python object with converted result (a list object)
+ */
+static PyObject *PyLdbControl_FromControl(struct ldb_control *control)
+{
+       TALLOC_CTX *ctl_ctx = talloc_new(NULL);
+       PyLdbControlObject *ctrl;
+       if (ctl_ctx == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       ctrl = (PyLdbControlObject *)PyLdbControl.tp_alloc(&PyLdbControl, 0);
+       if (ctrl == NULL) {
+               talloc_free(ctl_ctx);
+               PyErr_NoMemory();
+               return NULL;
+       }
+       ctrl->mem_ctx = ctl_ctx;
+       ctrl->data = talloc_steal(ctrl->mem_ctx, control);
+       if (ctrl->data == NULL) {
+               Py_DECREF(ctrl);
+               PyErr_NoMemory();
+               return NULL;
+       }
+       return (PyObject*) ctrl;
 }
 
 /**
@@ -88,17 +233,90 @@ static PyObject *PyObject_FromLdbValue(struct ldb_context *ldb_ctx,
  */
 static PyObject *PyLdbResult_FromResult(struct ldb_result *result)
 {
-       PyObject *ret;
+       PyLdbResultObject *ret;
+       PyObject *list, *controls, *referals;
        Py_ssize_t i;
+
        if (result == NULL) {
                Py_RETURN_NONE;
-       } 
-       ret = PyList_New(result->count);
+       }
+
+       ret = (PyLdbResultObject *)PyLdbResult.tp_alloc(&PyLdbResult, 0);
+       if (ret == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       list = PyList_New(result->count);
+       if (list == NULL) {
+               PyErr_NoMemory();
+               Py_DECREF(ret);
+               return NULL;
+       }
+
        for (i = 0; i < result->count; i++) {
-               PyList_SetItem(ret, i, PyLdbMessage_FromMessage(result->msgs[i])
-               );
+               PyList_SetItem(list, i, PyLdbMessage_FromMessage(result->msgs[i]));
        }
-       return ret;
+
+       ret->mem_ctx = talloc_new(NULL);
+       if (ret->mem_ctx == NULL) {
+               Py_DECREF(list);
+               Py_DECREF(ret);
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       ret->msgs = list;
+
+       if (result->controls) {
+               controls = PyList_New(1);
+               if (controls == NULL) {
+                       Py_DECREF(ret);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+               for (i=0; result->controls[i]; i++) {
+                       PyObject *ctrl = (PyObject*) PyLdbControl_FromControl(result->controls[i]);
+                       if (ctrl == NULL) {
+                               Py_DECREF(ret);
+                               Py_DECREF(controls);
+                               PyErr_NoMemory();
+                               return NULL;
+                       }
+                       PyList_SetItem(controls, i, ctrl);
+               }
+       } else {
+               /*
+                * No controls so we keep an empty list
+                */
+               controls = PyList_New(0);
+               if (controls == NULL) {
+                       Py_DECREF(ret);
+                       PyErr_NoMemory();
+                       return NULL;
+               }
+       }
+
+       ret->controls = controls;
+
+       i = 0;
+
+       while (result->refs && result->refs[i]) {
+               i++;
+       }
+
+       referals = PyList_New(i);
+       if (referals == NULL) {
+               Py_DECREF(ret);
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       for (i = 0;result->refs && result->refs[i]; i++) {
+               PyList_SetItem(referals, i, PyString_FromString(result->refs[i]));
+       }
+       ret->referals = referals;
+       return (PyObject *)ret;
 }
 
 /**
@@ -110,7 +328,7 @@ static PyObject *PyLdbResult_FromResult(struct ldb_result *result)
  * @return a ldb_result, or NULL if the conversion failed
  */
 static struct ldb_result *PyLdbResult_AsResult(TALLOC_CTX *mem_ctx, 
-                                                                                          PyObject *obj)
+                                              PyObject *obj)
 {
        struct ldb_result *res;
        Py_ssize_t i;
@@ -168,6 +386,62 @@ static PyObject *py_ldb_dn_canonical_ex_str(PyLdbDnObject *self)
        return PyString_FromString(ldb_dn_canonical_ex_string(self->dn, self->dn));
 }
 
+static PyObject *py_ldb_dn_extended_str(PyLdbDnObject *self, PyObject *args, PyObject *kwargs)
+{
+       const char * const kwnames[] = { "mode", NULL };
+       int mode = 1;
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|i",
+                                        discard_const_p(char *, kwnames),
+                                        &mode))
+               return NULL;
+       return PyString_FromString(ldb_dn_get_extended_linearized(self->dn, self->dn, mode));
+}
+
+static PyObject *py_ldb_dn_get_extended_component(PyLdbDnObject *self, PyObject *args)
+{
+       char *name;
+       const struct ldb_val *val;
+
+       if (!PyArg_ParseTuple(args, "s", &name))
+               return NULL;
+       val = ldb_dn_get_extended_component(self->dn, name);
+       if (val == NULL) {
+               Py_RETURN_NONE;
+       }
+
+       return PyString_FromStringAndSize((const char *)val->data, val->length);
+}
+
+static PyObject *py_ldb_dn_set_extended_component(PyLdbDnObject *self, PyObject *args)
+{
+       char *name;
+       PyObject *value;
+       int err;
+
+       if (!PyArg_ParseTuple(args, "sO", &name, &value))
+               return NULL;
+
+       if (value == Py_None) {
+               err = ldb_dn_set_extended_component(self->dn, name, NULL);
+       } else {
+               struct ldb_val val;
+               if (!PyString_Check(value)) {
+                       PyErr_SetString(PyExc_TypeError, "Expected a string argument");
+                       return NULL;
+               }
+               val.data = (uint8_t *)PyString_AsString(value);
+               val.length = PyString_Size(value);
+               err = ldb_dn_set_extended_component(self->dn, name, &val);
+       }
+
+       if (err != LDB_SUCCESS) {
+               PyErr_SetString(PyExc_TypeError, "Failed to set extended component");
+               return NULL;
+       }
+
+       Py_RETURN_NONE;
+}
+
 static PyObject *py_ldb_dn_repr(PyLdbDnObject *self)
 {
        return PyString_FromFormat("Dn(%s)", PyObject_REPR(PyString_FromString(ldb_dn_get_linearized(self->dn))));
@@ -269,8 +543,9 @@ static PyMethodDef py_ldb_dn_methods[] = {
        { "canonical_ex_str", (PyCFunction)py_ldb_dn_canonical_ex_str, METH_NOARGS,
                "S.canonical_ex_str() -> string\n"
                "Canonical version of this DN (like a posix path, with terminating newline)." },
-       { "check_special", (PyCFunction)py_ldb_dn_is_special, METH_VARARGS, 
-               NULL },
+       { "extended_str", (PyCFunction)py_ldb_dn_extended_str, METH_VARARGS | METH_KEYWORDS,
+               "S.extended_str(mode=1) -> string\n"
+               "Extended version of this DN" },
        { "parent", (PyCFunction)py_ldb_dn_get_parent, METH_NOARGS,
                "S.parent() -> dn\n"
                "Get the parent for this DN." },
@@ -281,7 +556,14 @@ static PyMethodDef py_ldb_dn_methods[] = {
                "S.add_base(dn) -> None\n"
                "Add a base DN to this DN." },
        { "check_special", (PyCFunction)py_ldb_dn_check_special, METH_VARARGS,
-               NULL },
+               "S.check_special(name) -> bool\n\n"
+               "Check if name is a special DN name"},
+       { "get_extended_component", (PyCFunction)py_ldb_dn_get_extended_component, METH_VARARGS,
+               "S.get_extended_component(name) -> string\n\n"
+               "returns a DN extended component as a binary string"},
+       { "set_extended_component", (PyCFunction)py_ldb_dn_set_extended_component, METH_VARARGS,
+               "S.set_extended_component(name, value) -> string\n\n"
+               "set a DN extended component as a binary string"},
        { NULL }
 };
 
@@ -339,8 +621,7 @@ static PyObject *py_ldb_dn_new(PyTypeObject *type, PyObject *args, PyObject *kwa
        }
 
        ret = ldb_dn_new(mem_ctx, ldb_ctx, str);
-
-       if (ret == NULL || !ldb_dn_validate(ret)) {
+       if (!ldb_dn_validate(ret)) {
                talloc_free(mem_ctx);
                PyErr_SetString(PyExc_ValueError, "unable to parse dn string");
                return NULL;
@@ -360,10 +641,10 @@ static PyObject *py_ldb_dn_new(PyTypeObject *type, PyObject *args, PyObject *kwa
 static void py_ldb_dn_dealloc(PyLdbDnObject *self)
 {
        talloc_free(self->mem_ctx);
-       self->ob_type->tp_free(self);
+       PyObject_Del(self);
 }
 
-PyTypeObject PyLdbDn = {
+static PyTypeObject PyLdbDn = {
        .tp_name = "ldb.Dn",
        .tp_methods = py_ldb_dn_methods,
        .tp_str = (reprfunc)py_ldb_dn_get_linearized,
@@ -373,7 +654,7 @@ PyTypeObject PyLdbDn = {
        .tp_doc = "A LDB distinguished name.",
        .tp_new = py_ldb_dn_new,
        .tp_dealloc = (destructor)py_ldb_dn_dealloc,
-       .tp_basicsize = sizeof(PyLdbObject),
+       .tp_basicsize = sizeof(PyLdbDnObject),
        .tp_flags = Py_TPFLAGS_DEFAULT,
 };
 
@@ -490,7 +771,7 @@ static PyObject *py_ldb_get_default_basedn(PyLdbObject *self)
 }
 
 static const char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list, 
-                                                                               const char *paramname)
+                                       const char *paramname)
 {
        const char **ret;
        Py_ssize_t i;
@@ -499,6 +780,11 @@ static const char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list,
                return NULL;
        }
        ret = talloc_array(NULL, const char *, PyList_Size(list)+1);
+       if (ret == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+
        for (i = 0; i < PyList_Size(list); i++) {
                PyObject *item = PyList_GetItem(list, i);
                if (!PyString_Check(item)) {
@@ -506,7 +792,7 @@ static const char **PyList_AsStringList(TALLOC_CTX *mem_ctx, PyObject *list,
                        return NULL;
                }
                ret[i] = talloc_strndup(ret, PyString_AsString(item),
-                                                          PyString_Size(item));
+                                       PyString_Size(item));
        }
        ret[i] = NULL;
        return ret;
@@ -518,11 +804,11 @@ static int py_ldb_init(PyLdbObject *self, PyObject *args, PyObject *kwargs)
        char *url = NULL;
        PyObject *py_options = Py_None;
        const char **options;
-       int flags = 0;
+       unsigned int flags = 0;
        int ret;
        struct ldb_context *ldb;
 
-       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ziO:Ldb.__init__",
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|zIO:Ldb.__init__",
                                         discard_const_p(char *, kwnames),
                                         &url, &flags, &py_options))
                return -1;
@@ -573,13 +859,13 @@ static PyObject *py_ldb_new(PyTypeObject *type, PyObject *args, PyObject *kwargs
 static PyObject *py_ldb_connect(PyLdbObject *self, PyObject *args, PyObject *kwargs)
 {
        char *url;
-       int flags = 0;
+       unsigned int flags = 0;
        PyObject *py_options = Py_None;
        int ret;
        const char **options;
        const char * const kwnames[] = { "url", "flags", "options", NULL };
 
-       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|ziO",
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|zIO",
                                         discard_const_p(char *, kwnames),
                                         &url, &flags, &py_options))
                return NULL;
@@ -600,7 +886,7 @@ static PyObject *py_ldb_connect(PyLdbObject *self, PyObject *args, PyObject *kwa
        Py_RETURN_NONE;
 }
 
-static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args)
+static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args, PyObject *kwargs)
 {
        PyObject *py_msg;
        PyObject *py_controls = Py_None;
@@ -610,8 +896,12 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args)
        struct ldb_message *msg;
        int ret;
        TALLOC_CTX *mem_ctx;
+       bool validate=true;
+       const char * const kwnames[] = { "message", "controls", "validate", NULL };
 
-       if (!PyArg_ParseTuple(args, "O|O", &py_msg, &py_controls))
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|Ob",
+                                        discard_const_p(char *, kwnames),
+                                        &py_msg, &py_controls, &validate))
                return NULL;
 
        mem_ctx = talloc_new(NULL);
@@ -636,11 +926,13 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args)
        }
        msg = PyLdbMessage_AsMessage(py_msg);
 
-       ret = ldb_msg_sanity_check(ldb_ctx, msg);
-       if (ret != LDB_SUCCESS) {
-               PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
-               talloc_free(mem_ctx);
-               return NULL;
+       if (validate) {
+               ret = ldb_msg_sanity_check(ldb_ctx, msg);
+               if (ret != LDB_SUCCESS) {
+                       PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
+                       talloc_free(mem_ctx);
+                       return NULL;
+               }
        }
 
        ret = ldb_build_mod_req(&req, ldb_ctx, mem_ctx, msg, parsed_controls,
@@ -651,23 +943,23 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args)
                return NULL;
        }
 
-        /* do request and autostart a transaction */
+       /* do request and autostart a transaction */
        /* Then let's LDB handle the message error in case of pb as they are meaningful */
 
        ret = ldb_transaction_start(ldb_ctx);
        if (ret != LDB_SUCCESS) {
                talloc_free(mem_ctx);
                PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
-        }
+       }
 
-        ret = ldb_request(ldb_ctx, req);
-        if (ret == LDB_SUCCESS) {
-                ret = ldb_wait(req->handle, LDB_WAIT_ALL);
-        }
+       ret = ldb_request(ldb_ctx, req);
+       if (ret == LDB_SUCCESS) {
+                       ret = ldb_wait(req->handle, LDB_WAIT_ALL);
+       }
 
        if (ret == LDB_SUCCESS) {
-                ret = ldb_transaction_commit(ldb_ctx);
-        } else {
+               ret = ldb_transaction_commit(ldb_ctx);
+       } else {
                ldb_transaction_cancel(ldb_ctx);
                if (ldb_ctx->err_string == NULL) {
                        /* no error string was setup by the backend */
@@ -682,21 +974,78 @@ static PyObject *py_ldb_modify(PyLdbObject *self, PyObject *args)
 }
 
 
-static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args)
+/**
+ * Obtain a ldb message from a Python Dictionary object.
+ *
+ * @param mem_ctx Memory context
+ * @param py_obj Python Dictionary object
+ * @param ldb_ctx LDB context
+ * @param mod_flags Flags to be set on every message element
+ * @return ldb_message on success or NULL on failure
+ */
+static struct ldb_message *PyDict_AsMessage(TALLOC_CTX *mem_ctx,
+                                           PyObject *py_obj,
+                                           struct ldb_context *ldb_ctx,
+                                           unsigned int mod_flags)
 {
-       PyObject *py_msg;
-       int ret;
-       Py_ssize_t dict_pos, msg_pos;
-       struct ldb_message_element *msgel;
        struct ldb_message *msg;
+       unsigned int msg_pos = 0;
+       Py_ssize_t dict_pos = 0;
+       PyObject *key, *value;
+       struct ldb_message_element *msg_el;
+       PyObject *dn_value = PyDict_GetItemString(py_obj, "dn");
+
+       msg = ldb_msg_new(mem_ctx);
+       msg->elements = talloc_zero_array(msg, struct ldb_message_element, PyDict_Size(py_obj));
+
+       if (dn_value) {
+               if (!PyObject_AsDn(msg, dn_value, ldb_ctx, &msg->dn)) {
+                       PyErr_SetString(PyExc_TypeError, "unable to import dn object");
+                       return NULL;
+               }
+               if (msg->dn == NULL) {
+                       PyErr_SetString(PyExc_TypeError, "dn set but not found");
+                       return NULL;
+               }
+       } else {
+               PyErr_SetString(PyExc_TypeError, "no dn set");
+               return NULL;
+       }
+
+       while (PyDict_Next(py_obj, &dict_pos, &key, &value)) {
+               char *key_str = PyString_AsString(key);
+               if (strcmp(key_str, "dn") != 0) {
+                       msg_el = PyObject_AsMessageElement(msg->elements, value,
+                                                          mod_flags, key_str);
+                       if (msg_el == NULL) {
+                               PyErr_SetString(PyExc_TypeError, "unable to import element");
+                               return NULL;
+                       }
+                       memcpy(&msg->elements[msg_pos], msg_el, sizeof(*msg_el));
+                       msg_pos++;
+               }
+       }
+
+       msg->num_elements = msg_pos;
+
+       return msg;
+}
+
+static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args, PyObject *kwargs)
+{
+       PyObject *py_obj;
+       int ret;
        struct ldb_context *ldb_ctx;
        struct ldb_request *req;
-       PyObject *key, *value;
+       struct ldb_message *msg = NULL;
        PyObject *py_controls = Py_None;
        TALLOC_CTX *mem_ctx;
        struct ldb_control **parsed_controls;
+       const char * const kwnames[] = { "message", "controls", NULL };
 
-       if (!PyArg_ParseTuple(args, "O|O", &py_msg, &py_controls ))
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|O",
+                                        discard_const_p(char *, kwnames),
+                                        &py_obj, &py_controls))
                return NULL;
 
        mem_ctx = talloc_new(NULL);
@@ -713,59 +1062,32 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args)
                parsed_controls = ldb_parse_control_strings(ldb_ctx, mem_ctx, controls);
                talloc_free(controls);
        }
-       if (PyDict_Check(py_msg)) {
-               PyObject *dn_value = PyDict_GetItemString(py_msg, "dn");
-               msg = ldb_msg_new(mem_ctx);
-               msg->elements = talloc_zero_array(msg, struct ldb_message_element, PyDict_Size(py_msg));
-               msg_pos = dict_pos = 0;
-               if (dn_value) {
-                       if (!PyObject_AsDn(msg, dn_value, ldb_ctx, &msg->dn)) {
-                               PyErr_SetString(PyExc_TypeError, "unable to import dn object");
-                               talloc_free(mem_ctx);
-                               return NULL;
-                       }
-                       if (msg->dn == NULL) {
-                               PyErr_SetString(PyExc_TypeError, "dn set but not found");
-                               talloc_free(mem_ctx);
-                               return NULL;
-                       }
-               }
 
-               while (PyDict_Next(py_msg, &dict_pos, &key, &value)) {
-                       char *key_str = PyString_AsString(key);
-                       if (strcmp(key_str, "dn") != 0) {
-                               msgel = PyObject_AsMessageElement(msg->elements, value, 0, key_str);
-                               if (msgel == NULL) {
-                                       PyErr_SetString(PyExc_TypeError, "unable to import element");
-                                       talloc_free(mem_ctx);
-                                       return NULL;
-                               }
-                               memcpy(&msg->elements[msg_pos], msgel, sizeof(*msgel));
-                               msg_pos++;
-                       }
-               }
-
-               if (msg->dn == NULL) {
-                       PyErr_SetString(PyExc_TypeError, "no dn set");
-                       talloc_free(mem_ctx);
-                       return NULL;
-               }
-
-               msg->num_elements = msg_pos;
+       if (PyLdbMessage_Check(py_obj)) {
+               msg = PyLdbMessage_AsMessage(py_obj);
+       } else if (PyDict_Check(py_obj)) {
+               msg = PyDict_AsMessage(mem_ctx, py_obj, ldb_ctx, LDB_FLAG_MOD_ADD);
        } else {
-               msg = PyLdbMessage_AsMessage(py_msg);
+               PyErr_SetString(PyExc_TypeError,
+                               "Dictionary or LdbMessage object expected!");
        }
-        
+
+       if (!msg) {
+               /* we should have a PyErr already set */
+               talloc_free(mem_ctx);
+               return NULL;
+       }
+
        ret = ldb_msg_sanity_check(ldb_ctx, msg);
-        if (ret != LDB_SUCCESS) {
+       if (ret != LDB_SUCCESS) {
                PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
                talloc_free(mem_ctx);
                return NULL;
-        }
+       }
 
-        ret = ldb_build_add_req(&req, ldb_ctx, mem_ctx, msg, parsed_controls,
+       ret = ldb_build_add_req(&req, ldb_ctx, mem_ctx, msg, parsed_controls,
                                NULL, ldb_op_default_callback, NULL);
-        if (ret != LDB_SUCCESS) {
+       if (ret != LDB_SUCCESS) {
                PyErr_SetString(PyExc_TypeError, "failed to build request");
                talloc_free(mem_ctx);
                return NULL;
@@ -774,21 +1096,21 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args)
         /* do request and autostart a transaction */
        /* Then let's LDB handle the message error in case of pb as they are meaningful */
 
-        ret = ldb_transaction_start(ldb_ctx);
-        if (ret != LDB_SUCCESS) {
+       ret = ldb_transaction_start(ldb_ctx);
+       if (ret != LDB_SUCCESS) {
                talloc_free(mem_ctx);
                PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, ldb_ctx);
-        }
+       }
 
-        ret = ldb_request(ldb_ctx, req);
-        if (ret == LDB_SUCCESS) {
-                ret = ldb_wait(req->handle, LDB_WAIT_ALL);
-        
+       ret = ldb_request(ldb_ctx, req);
+       if (ret == LDB_SUCCESS) {
+                       ret = ldb_wait(req->handle, LDB_WAIT_ALL);
+       } 
 
        if (ret == LDB_SUCCESS) {
-                ret = ldb_transaction_commit(ldb_ctx);
-        } else {
-               ldb_transaction_cancel(ldb_ctx);
+                       ret = ldb_transaction_commit(ldb_ctx);
+       } else {
+               ldb_transaction_cancel(ldb_ctx);
                if (ldb_ctx->err_string == NULL) {
                        /* no error string was setup by the backend */
                        ldb_asprintf_errstring(ldb_ctx, "%s (%d)", ldb_strerror(ret), ret);
@@ -801,7 +1123,7 @@ static PyObject *py_ldb_add(PyLdbObject *self, PyObject *args)
        Py_RETURN_NONE;
 }
 
-static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args)
+static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args, PyObject *kwargs)
 {
        PyObject *py_dn;
        struct ldb_dn *dn;
@@ -811,8 +1133,11 @@ static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args)
        PyObject *py_controls = Py_None;
        TALLOC_CTX *mem_ctx;
        struct ldb_control **parsed_controls;
+       const char * const kwnames[] = { "dn", "controls", NULL };
 
-       if (!PyArg_ParseTuple(args, "O|O", &py_dn, &py_controls))
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "O|O",
+                                        discard_const_p(char *, kwnames),
+                                        &py_dn, &py_controls))
                return NULL;
 
        mem_ctx = talloc_new(NULL);
@@ -873,7 +1198,7 @@ static PyObject *py_ldb_delete(PyLdbObject *self, PyObject *args)
        Py_RETURN_NONE;
 }
 
-static PyObject *py_ldb_rename(PyLdbObject *self, PyObject *args)
+static PyObject *py_ldb_rename(PyLdbObject *self, PyObject *args, PyObject *kwargs)
 {
        PyObject *py_dn1, *py_dn2;
        struct ldb_dn *dn1, *dn2;
@@ -884,10 +1209,13 @@ static PyObject *py_ldb_rename(PyLdbObject *self, PyObject *args)
        struct ldb_control **parsed_controls;
        struct ldb_context *ldb_ctx;
        struct ldb_request *req;
+       const char * const kwnames[] = { "dn1", "dn2", "controls", NULL };
 
        ldb_ctx = PyLdb_AsLdbContext(self);
 
-       if (!PyArg_ParseTuple(args, "OO|O", &py_dn1, &py_dn2, &py_controls))
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "OO|O",
+                                        discard_const_p(char *, kwnames),
+                                        &py_dn1, &py_dn2, &py_controls))
                return NULL;
 
 
@@ -994,7 +1322,7 @@ static PyObject *ldb_ldif_to_pyobject(struct ldb_ldif *ldif)
 }
 
 
-static PyObject *py_ldb_write_ldif(PyLdbMessageObject *self, PyObject *args)
+static PyObject *py_ldb_write_ldif(PyLdbObject *self, PyObject *args)
 {
        int changetype;
        PyObject *py_msg;
@@ -1340,17 +1668,17 @@ static PyMethodDef py_ldb_methods[] = {
        { "connect", (PyCFunction)py_ldb_connect, METH_VARARGS|METH_KEYWORDS, 
                "S.connect(url, flags=0, options=None) -> None\n"
                "Connect to a LDB URL." },
-       { "modify", (PyCFunction)py_ldb_modify, METH_VARARGS
-               "S.modify(message) -> None\n"
+       { "modify", (PyCFunction)py_ldb_modify, METH_VARARGS|METH_KEYWORDS,
+               "S.modify(message, controls=None, validate=False) -> None\n"
                "Modify an entry." },
-       { "add", (PyCFunction)py_ldb_add, METH_VARARGS
-               "S.add(message) -> None\n"
+       { "add", (PyCFunction)py_ldb_add, METH_VARARGS|METH_KEYWORDS,
+               "S.add(message, controls=None) -> None\n"
                "Add an entry." },
-       { "delete", (PyCFunction)py_ldb_delete, METH_VARARGS,
-               "S.delete(dn) -> None\n"
+       { "delete", (PyCFunction)py_ldb_delete, METH_VARARGS|METH_KEYWORDS,
+               "S.delete(dn, controls=None) -> None\n"
                "Remove an entry." },
-       { "rename", (PyCFunction)py_ldb_rename, METH_VARARGS,
-               "S.rename(old_dn, new_dn) -> None\n"
+       { "rename", (PyCFunction)py_ldb_rename, METH_VARARGS|METH_KEYWORDS,
+               "S.rename(old_dn, new_dn, controls=None) -> None\n"
                "Rename an entry." },
        { "search", (PyCFunction)py_ldb_search, METH_VARARGS|METH_KEYWORDS,
                "S.search(base=None, scope=None, expression=None, attrs=None, controls=None) -> msgs\n"
@@ -1396,7 +1724,7 @@ static PyMethodDef py_ldb_methods[] = {
        { NULL },
 };
 
-PyObject *PyLdbModule_FromModule(struct ldb_module *mod)
+static PyObject *PyLdbModule_FromModule(struct ldb_module *mod)
 {
        PyLdbModuleObject *ret;
 
@@ -1425,13 +1753,15 @@ static int py_ldb_contains(PyLdbObject *self, PyObject *obj)
        struct ldb_context *ldb_ctx = PyLdb_AsLdbContext(self);
        struct ldb_dn *dn;
        struct ldb_result *result;
+       unsigned int count;
        int ret;
-       int count;
 
-       if (!PyObject_AsDn(ldb_ctx, obj, ldb_ctx, &dn))
+       if (!PyObject_AsDn(ldb_ctx, obj, ldb_ctx, &dn)) {
                return -1;
+       }
 
-       ret = ldb_search(ldb_ctx, ldb_ctx, &result, dn, LDB_SCOPE_BASE, NULL, NULL);
+       ret = ldb_search(ldb_ctx, ldb_ctx, &result, dn, LDB_SCOPE_BASE, NULL,
+                        NULL);
        if (ret != LDB_SUCCESS) {
                PyErr_SetLdbError(PyExc_LdbError, ret, ldb_ctx);
                return -1;
@@ -1441,6 +1771,14 @@ static int py_ldb_contains(PyLdbObject *self, PyObject *obj)
 
        talloc_free(result);
 
+       if (count > 1) {
+               PyErr_Format(PyExc_RuntimeError,
+                            "Searching for [%s] dn gave %u results!",
+                            ldb_dn_get_linearized(dn),
+                            count);
+               return -1;
+       }
+
        return count;
 }
 
@@ -1468,7 +1806,7 @@ static void py_ldb_dealloc(PyLdbObject *self)
        self->ob_type->tp_free(self);
 }
 
-PyTypeObject PyLdb = {
+static PyTypeObject PyLdb = {
        .tp_name = "ldb.Ldb",
        .tp_methods = py_ldb_methods,
        .tp_repr = (reprfunc)py_ldb_repr,
@@ -1483,6 +1821,91 @@ PyTypeObject PyLdb = {
        .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
 };
 
+static void py_ldb_result_dealloc(PyLdbResultObject *self)
+{
+       talloc_free(self->mem_ctx);
+       Py_DECREF(self->msgs);
+       Py_DECREF(self->referals);
+       Py_DECREF(self->controls);
+       self->ob_type->tp_free(self);
+}
+
+static PyObject *py_ldb_result_get_msgs(PyLdbResultObject *self, void *closure)
+{
+       Py_INCREF(self->msgs);
+       return self->msgs;
+}
+
+static PyObject *py_ldb_result_get_controls(PyLdbResultObject *self, void *closure)
+{
+       Py_INCREF(self->controls);
+       return self->controls;
+}
+
+static PyObject *py_ldb_result_get_referals(PyLdbResultObject *self, void *closure)
+{
+       Py_INCREF(self->referals);
+       return self->referals;
+}
+
+static PyObject *py_ldb_result_get_count(PyLdbResultObject *self, void *closure)
+{
+       Py_ssize_t size;
+       if (self->msgs == NULL) {
+               PyErr_SetString(PyExc_AttributeError, "Count attribute is meaningless in this context");
+               return NULL;
+       }
+       size = PyList_Size(self->msgs);
+       return PyInt_FromLong(size);
+}
+
+static PyGetSetDef py_ldb_result_getset[] = {
+       { discard_const_p(char, "controls"), (getter)py_ldb_result_get_controls, NULL, NULL },
+       { discard_const_p(char, "msgs"), (getter)py_ldb_result_get_msgs, NULL, NULL },
+       { discard_const_p(char, "referals"), (getter)py_ldb_result_get_referals, NULL, NULL },
+       { discard_const_p(char, "count"), (getter)py_ldb_result_get_count, NULL, NULL },
+       { NULL }
+};
+
+static PyObject *py_ldb_result_iter(PyLdbResultObject *self)
+{
+       return PyObject_GetIter(self->msgs);
+}
+
+static Py_ssize_t py_ldb_result_len(PyLdbResultObject *self)
+{
+       return PySequence_Size(self->msgs);
+}
+
+static PyObject *py_ldb_result_find(PyLdbResultObject *self, Py_ssize_t idx)
+{
+       return PySequence_GetItem(self->msgs, idx);
+}
+
+static PySequenceMethods py_ldb_result_seq = {
+       .sq_length = (lenfunc)py_ldb_result_len,
+       .sq_item = (ssizeargfunc)py_ldb_result_find,
+};
+
+static PyObject *py_ldb_result_repr(PyLdbObject *self)
+{
+       return PyString_FromFormat("<ldb result>");
+}
+
+
+static PyTypeObject PyLdbResult = {
+       .tp_name = "ldb.Result",
+       .tp_repr = (reprfunc)py_ldb_result_repr,
+       .tp_dealloc = (destructor)py_ldb_result_dealloc,
+       .tp_iter = (getiterfunc)py_ldb_result_iter,
+       .tp_getset = py_ldb_result_getset,
+       .tp_getattro = PyObject_GenericGetAttr,
+       .tp_basicsize = sizeof(PyLdbResultObject),
+       .tp_as_sequence = &py_ldb_result_seq,
+       .tp_doc = "LDB result.",
+       .tp_flags = Py_TPFLAGS_DEFAULT|Py_TPFLAGS_BASETYPE,
+};
+
 static PyObject *py_ldb_module_repr(PyLdbModuleObject *self)
 {
        return PyString_FromFormat("<ldb module '%s'>", PyLdbModule_AsModule(self)->ops->name);
@@ -1659,10 +2082,10 @@ static PyMethodDef py_ldb_module_methods[] = {
 static void py_ldb_module_dealloc(PyLdbModuleObject *self)
 {
        talloc_free(self->mem_ctx);
-       self->ob_type->tp_free(self);
+       PyObject_Del(self);
 }
 
-PyTypeObject PyLdbModule = {
+static PyTypeObject PyLdbModule = {
        .tp_name = "ldb.LdbModule",
        .tp_methods = py_ldb_module_methods,
        .tp_repr = (reprfunc)py_ldb_module_repr,
@@ -1687,16 +2110,18 @@ PyTypeObject PyLdbModule = {
  * @param attr_name Name of the attribute
  * @return New ldb_message_element, allocated as child of mem_ctx
  */
-struct ldb_message_element *PyObject_AsMessageElement(TALLOC_CTX *mem_ctx,
+static struct ldb_message_element *PyObject_AsMessageElement(
+                                                     TALLOC_CTX *mem_ctx,
                                                      PyObject *set_obj,
-                                                     int flags,
+                                                     unsigned int flags,
                                                      const char *attr_name)
 {
        struct ldb_message_element *me;
 
        if (PyLdbMessageElement_Check(set_obj)) {
                PyLdbMessageElementObject *set_obj_as_me = (PyLdbMessageElementObject *)set_obj;
-               /* We have to talloc_reference() the memory context, not the pointer which may not actually be it's own context */
+               /* We have to talloc_reference() the memory context, not the pointer
+                * which may not actually be it's own context */
                if (talloc_reference(mem_ctx, set_obj_as_me->mem_ctx)) {
                        return PyLdbMessageElement_AsMessageElement(set_obj);
                }
@@ -1704,6 +2129,10 @@ struct ldb_message_element *PyObject_AsMessageElement(TALLOC_CTX *mem_ctx,
        }
 
        me = talloc(mem_ctx, struct ldb_message_element);
+       if (me == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
 
        me->name = talloc_strdup(me, attr_name);
        me->flags = flags;
@@ -1750,7 +2179,7 @@ static PyObject *ldb_msg_element_to_set(struct ldb_context *ldb_ctx,
 
        for (i = 0; i < me->num_values; i++) {
                PyList_SetItem(result, i,
-                       PyObject_FromLdbValue(ldb_ctx, me, &me->values[i]));
+                       PyObject_FromLdbValue(&me->values[i]));
        }
 
        return result;
@@ -1758,29 +2187,26 @@ static PyObject *ldb_msg_element_to_set(struct ldb_context *ldb_ctx,
 
 static PyObject *py_ldb_msg_element_get(PyLdbMessageElementObject *self, PyObject *args)
 {
-       int i;
-       if (!PyArg_ParseTuple(args, "i", &i))
+       unsigned int i;
+       if (!PyArg_ParseTuple(args, "I", &i))
                return NULL;
-       if (i < 0 || i >= PyLdbMessageElement_AsMessageElement(self)->num_values)
+       if (i >= PyLdbMessageElement_AsMessageElement(self)->num_values)
                Py_RETURN_NONE;
 
-       return PyObject_FromLdbValue(NULL, PyLdbMessageElement_AsMessageElement(self), 
-                                                                &(PyLdbMessageElement_AsMessageElement(self)->values[i]));
+       return PyObject_FromLdbValue(&(PyLdbMessageElement_AsMessageElement(self)->values[i]));
 }
 
 static PyObject *py_ldb_msg_element_flags(PyLdbMessageElementObject *self, PyObject *args)
 {
-       struct ldb_message_element *el;
-
-       el = PyLdbMessageElement_AsMessageElement(self);
+       struct ldb_message_element *el = PyLdbMessageElement_AsMessageElement(self);
        return PyInt_FromLong(el->flags);
 }
 
 static PyObject *py_ldb_msg_element_set_flags(PyLdbMessageElementObject *self, PyObject *args)
 {
-       int flags;
+       unsigned int flags;
        struct ldb_message_element *el;
-       if (!PyArg_ParseTuple(args, "i", &flags))
+       if (!PyArg_ParseTuple(args, "I", &flags))
                return NULL;
 
        el = PyLdbMessageElement_AsMessageElement(self);
@@ -1817,8 +2243,9 @@ static PySequenceMethods py_ldb_msg_element_seq = {
 
 static int py_ldb_msg_element_cmp(PyLdbMessageElementObject *self, PyLdbMessageElementObject *other)
 {
-       return ldb_msg_element_compare(PyLdbMessageElement_AsMessageElement(self), 
-                                                                  PyLdbMessageElement_AsMessageElement(other));
+       int ret = ldb_msg_element_compare(PyLdbMessageElement_AsMessageElement(self),
+                                                                         PyLdbMessageElement_AsMessageElement(other));
+       return SIGN(ret);
 }
 
 static PyObject *py_ldb_msg_element_iter(PyLdbMessageElementObject *self)
@@ -1826,10 +2253,10 @@ static PyObject *py_ldb_msg_element_iter(PyLdbMessageElementObject *self)
        return PyObject_GetIter(ldb_msg_element_to_set(NULL, PyLdbMessageElement_AsMessageElement(self)));
 }
 
-PyObject *PyLdbMessageElement_FromMessageElement(struct ldb_message_element *el, TALLOC_CTX *mem_ctx)
+static PyObject *PyLdbMessageElement_FromMessageElement(struct ldb_message_element *el, TALLOC_CTX *mem_ctx)
 {
        PyLdbMessageElementObject *ret;
-       ret = (PyLdbMessageElementObject *)PyLdbMessageElement.tp_alloc(&PyLdbMessageElement, 0);
+       ret = PyObject_New(PyLdbMessageElementObject, &PyLdbMessageElement);
        if (ret == NULL) {
                PyErr_NoMemory();
                return NULL;
@@ -1847,13 +2274,13 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
 {
        PyObject *py_elements = NULL;
        struct ldb_message_element *el;
-       int flags = 0;
+       unsigned int flags = 0;
        char *name = NULL;
        const char * const kwnames[] = { "elements", "flags", "name", NULL };
        PyLdbMessageElementObject *ret;
        TALLOC_CTX *mem_ctx;
 
-       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|Ois",
+       if (!PyArg_ParseTupleAndKeywords(args, kwargs, "|OIs",
                                         discard_const_p(char *, kwnames),
                                         &py_elements, &flags, &name))
                return NULL;
@@ -1865,20 +2292,39 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
        }
 
        el = talloc_zero(mem_ctx, struct ldb_message_element);
+       if (el == NULL) {
+               PyErr_NoMemory();
+               talloc_free(mem_ctx);
+               return NULL;
+       }
 
        if (py_elements != NULL) {
                Py_ssize_t i;
                if (PyString_Check(py_elements)) {
                        el->num_values = 1;
                        el->values = talloc_array(el, struct ldb_val, 1);
+                       if (el->values == NULL) {
+                               talloc_free(mem_ctx);
+                               PyErr_NoMemory();
+                               return NULL;
+                       }
                        el->values[0].length = PyString_Size(py_elements);
-                       el->values[0].data = talloc_memdup(el, 
+                       el->values[0].data = talloc_memdup(el->values
                                (uint8_t *)PyString_AsString(py_elements), el->values[0].length+1);
                } else if (PySequence_Check(py_elements)) {
                        el->num_values = PySequence_Size(py_elements);
                        el->values = talloc_array(el, struct ldb_val, el->num_values);
+                       if (el->values == NULL) {
+                               talloc_free(mem_ctx);
+                               PyErr_NoMemory();
+                               return NULL;
+                       }
                        for (i = 0; i < el->num_values; i++) {
                                PyObject *item = PySequence_GetItem(py_elements, i);
+                               if (item == NULL) {
+                                       talloc_free(mem_ctx);
+                                       return NULL;
+                               }
                                if (!PyString_Check(item)) {
                                        PyErr_Format(PyExc_TypeError, 
                                                     "Expected string as element %zd in list", i);
@@ -1886,7 +2332,7 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
                                        return NULL;
                                }
                                el->values[i].length = PyString_Size(item);
-                               el->values[i].data = talloc_memdup(el, 
+                               el->values[i].data = talloc_memdup(el,
                                        (uint8_t *)PyString_AsString(item), el->values[i].length+1);
                        }
                } else {
@@ -1900,9 +2346,8 @@ static PyObject *py_ldb_msg_element_new(PyTypeObject *type, PyObject *args, PyOb
        el->flags = flags;
        el->name = talloc_strdup(el, name);
 
-       ret = (PyLdbMessageElementObject *)PyLdbMessageElement.tp_alloc(&PyLdbMessageElement, 0);
+       ret = PyObject_New(PyLdbMessageElementObject, type);
        if (ret == NULL) {
-               PyErr_NoMemory();
                talloc_free(mem_ctx);
                return NULL;
        }
@@ -1943,17 +2388,17 @@ static PyObject *py_ldb_msg_element_str(PyLdbMessageElementObject *self)
 
        if (el->num_values == 1)
                return PyString_FromStringAndSize((char *)el->values[0].data, el->values[0].length);
-       else 
+       else
                Py_RETURN_NONE;
 }
 
 static void py_ldb_msg_element_dealloc(PyLdbMessageElementObject *self)
 {
        talloc_free(self->mem_ctx);
-       self->ob_type->tp_free(self);
+       PyObject_Del(self);
 }
 
-PyTypeObject PyLdbMessageElement = {
+static PyTypeObject PyLdbMessageElement = {
        .tp_name = "ldb.MessageElement",
        .tp_basicsize = sizeof(PyLdbMessageElementObject),
        .tp_dealloc = (destructor)py_ldb_msg_element_dealloc,
@@ -1967,6 +2412,45 @@ PyTypeObject PyLdbMessageElement = {
        .tp_flags = Py_TPFLAGS_DEFAULT,
 };
 
+
+static PyObject *py_ldb_msg_from_dict(PyTypeObject *type, PyObject *args)
+{
+       PyObject *py_ldb;
+       PyObject *py_dict;
+       PyObject *py_ret;
+       struct ldb_message *msg;
+       struct ldb_context *ldb_ctx;
+       unsigned int mod_flags = LDB_FLAG_MOD_REPLACE;
+
+       if (!PyArg_ParseTuple(args, "O!O!|I",
+                             &PyLdb, &py_ldb, &PyDict_Type, &py_dict,
+                             &mod_flags)) {
+               return NULL;
+       }
+
+       /* mask only flags we are going to use */
+       mod_flags = LDB_FLAG_MOD_TYPE(mod_flags);
+       if (!mod_flags) {
+               PyErr_SetString(PyExc_ValueError,
+                               "FLAG_MOD_ADD, FLAG_MOD_REPLACE or FLAG_MOD_DELETE"
+                               " expected as mod_flag value");
+               return NULL;
+       }
+
+       ldb_ctx = PyLdb_AsLdbContext(py_ldb);
+
+       msg = PyDict_AsMessage(ldb_ctx, py_dict, ldb_ctx, mod_flags);
+       if (!msg) {
+               return NULL;
+       }
+
+       py_ret = PyLdbMessage_FromMessage(msg);
+
+       talloc_unlink(ldb_ctx, msg);
+
+       return py_ret;
+}
+
 static PyObject *py_ldb_msg_remove_attr(PyLdbMessageObject *self, PyObject *args)
 {
        char *name;
@@ -2025,15 +2509,20 @@ static PyObject *py_ldb_msg_getitem(PyLdbMessageObject *self, PyObject *py_name)
 
 static PyObject *py_ldb_msg_get(PyLdbMessageObject *self, PyObject *args)
 {
-       PyObject *name, *ret;
-       if (!PyArg_ParseTuple(args, "O", &name))
+       PyObject *name, *ret, *retobj;
+       retobj = NULL;
+       if (!PyArg_ParseTuple(args, "O|O", &name, &retobj))
                return NULL;
 
        ret = py_ldb_msg_getitem_helper(self, name);
        if (ret == NULL) {
                if (PyErr_Occurred())
                        return NULL;
-               Py_RETURN_NONE;
+               if (retobj != NULL) {
+                       return retobj;
+               } else {
+                       Py_RETURN_NONE;
+               }
        }
        return ret;
 }
@@ -2048,16 +2537,63 @@ static PyObject *py_ldb_msg_items(PyLdbMessageObject *self)
                j++;
        }
        for (i = 0; i < msg->num_elements; i++, j++) {
-               PyList_SetItem(l, j, Py_BuildValue("(sO)", msg->elements[i].name, PyLdbMessageElement_FromMessageElement(&msg->elements[i], msg->elements)));
+               PyObject *py_el = PyLdbMessageElement_FromMessageElement(&msg->elements[i], msg->elements);
+               PyObject *value = Py_BuildValue("(sO)", msg->elements[i].name, py_el);
+               PyList_SetItem(l, j, value);
+       }
+       return l;
+}
+
+static PyObject *py_ldb_msg_elements(PyLdbMessageObject *self)
+{
+       struct ldb_message *msg = PyLdbMessage_AsMessage(self);
+       Py_ssize_t i = 0;
+       PyObject *l = PyList_New(msg->num_elements);
+       for (i = 0; i < msg->num_elements; i++) {
+               PyList_SetItem(l, i, PyLdbMessageElement_FromMessageElement(&msg->elements[i], msg->elements));
        }
        return l;
 }
 
-static PyMethodDef py_ldb_msg_methods[] = { 
-       { "keys", (PyCFunction)py_ldb_msg_keys, METH_NOARGS, NULL },
-       { "remove", (PyCFunction)py_ldb_msg_remove_attr, METH_VARARGS, NULL },
+static PyObject *py_ldb_msg_add(PyLdbMessageObject *self, PyObject *args)
+{
+       struct ldb_message *msg = PyLdbMessage_AsMessage(self);
+       PyLdbMessageElementObject *py_element;
+       int ret;
+       struct ldb_message_element *el;
+
+       if (!PyArg_ParseTuple(args, "O!", &PyLdbMessageElement, &py_element))
+               return NULL;
+
+       el = talloc_reference(msg, py_element->el);
+       if (el == NULL) {
+               PyErr_NoMemory();
+               return NULL;
+       }
+
+       ret = ldb_msg_add(msg, el, el->flags);
+       PyErr_LDB_ERROR_IS_ERR_RAISE(PyExc_LdbError, ret, NULL);
+
+       Py_RETURN_NONE;
+}
+
+static PyMethodDef py_ldb_msg_methods[] = {
+       { "from_dict", (PyCFunction)py_ldb_msg_from_dict, METH_CLASS | METH_VARARGS,
+               "Message.from_dict(ldb, dict, mod_flag=FLAG_MOD_REPLACE) -> ldb.Message\n"
+               "Class method to create ldb.Message object from Dictionary.\n"
+               "mod_flag is one of FLAG_MOD_ADD, FLAG_MOD_REPLACE or FLAG_MOD_DELETE."},
+       { "keys", (PyCFunction)py_ldb_msg_keys, METH_NOARGS, 
+               "S.keys() -> list\n\n"
+               "Return sequence of all attribute names." },
+       { "remove", (PyCFunction)py_ldb_msg_remove_attr, METH_VARARGS, 
+               "S.remove(name)\n\n"
+               "Remove all entries for attributes with the specified name."},
        { "get", (PyCFunction)py_ldb_msg_get, METH_VARARGS, NULL },
        { "items", (PyCFunction)py_ldb_msg_items, METH_NOARGS, NULL },
+       { "elements", (PyCFunction)py_ldb_msg_elements, METH_NOARGS, NULL },
+       { "add", (PyCFunction)py_ldb_msg_add, METH_VARARGS,
+               "S.append(element)\n\n"
+               "Add an element to this message." },
        { NULL },
 };
 
@@ -2079,7 +2615,7 @@ static int py_ldb_msg_setitem(PyLdbMessageObject *self, PyObject *name, PyObject
                PyErr_SetNone(PyExc_TypeError);
                return -1;
        }
-       
+
        attr_name = PyString_AsString(name);
        if (value == NULL) {
                /* delitem */
@@ -2153,7 +2689,7 @@ static PyObject *py_ldb_msg_new(PyTypeObject *type, PyObject *args, PyObject *kw
        return (PyObject *)py_ret;
 }
 
-PyObject *PyLdbMessage_FromMessage(struct ldb_message *msg)
+static PyObject *PyLdbMessage_FromMessage(struct ldb_message *msg)
 {
        PyLdbMessageObject *ret;
 
@@ -2203,7 +2739,7 @@ static PyObject *py_ldb_msg_repr(PyLdbMessageObject *self)
 static void py_ldb_msg_dealloc(PyLdbMessageObject *self)
 {
        talloc_free(self->mem_ctx);
-       self->ob_type->tp_free(self);
+       PyObject_Del(self);
 }
 
 static int py_ldb_msg_compare(PyLdbMessageObject *py_msg1,
@@ -2217,33 +2753,33 @@ static int py_ldb_msg_compare(PyLdbMessageObject *py_msg1,
        if ((msg1->dn != NULL) || (msg2->dn != NULL)) {
                ret = ldb_dn_compare(msg1->dn, msg2->dn);
                if (ret != 0) {
-                       return ret;
+                       return SIGN(ret);
                }
        }
 
        ret = msg1->num_elements - msg2->num_elements;
        if (ret != 0) {
-               return ret;
+               return SIGN(ret);
        }
 
        for (i = 0; i < msg1->num_elements; i++) {
                ret = ldb_msg_element_compare_name(&msg1->elements[i],
                                                   &msg2->elements[i]);
                if (ret != 0) {
-                       return ret;
+                       return SIGN(ret);
                }
 
                ret = ldb_msg_element_compare(&msg1->elements[i],
                                              &msg2->elements[i]);
                if (ret != 0) {
-                       return ret;
+                       return SIGN(ret);
                }
        }
 
        return 0;
 }
 
-PyTypeObject PyLdbMessage = {
+static PyTypeObject PyLdbMessage = {
        .tp_name = "ldb.Message",
        .tp_methods = py_ldb_msg_methods,
        .tp_getset = py_ldb_msg_getset,
@@ -2257,7 +2793,7 @@ PyTypeObject PyLdbMessage = {
        .tp_compare = (cmpfunc)py_ldb_msg_compare,
 };
 
-PyObject *PyLdbTree_FromTree(struct ldb_parse_tree *tree)
+static PyObject *PyLdbTree_FromTree(struct ldb_parse_tree *tree)
 {
        PyLdbTreeObject *ret;
 
@@ -2275,10 +2811,10 @@ PyObject *PyLdbTree_FromTree(struct ldb_parse_tree *tree)
 static void py_ldb_tree_dealloc(PyLdbTreeObject *self)
 {
        talloc_free(self->mem_ctx);
-       self->ob_type->tp_free(self);
+       PyObject_Del(self);
 }
 
-PyTypeObject PyLdbTree = {
+static PyTypeObject PyLdbTree = {
        .tp_name = "ldb.Tree",
        .tp_basicsize = sizeof(PyLdbTreeObject),
        .tp_dealloc = (destructor)py_ldb_tree_dealloc,
@@ -2657,6 +3193,12 @@ void initldb(void)
        if (PyType_Ready(&PyLdbTree) < 0)
                return;
 
+       if (PyType_Ready(&PyLdbResult) < 0)
+               return;
+
+       if (PyType_Ready(&PyLdbControl) < 0)
+               return;
+
        m = Py_InitModule3("ldb", py_ldb_global_methods, 
                "An interface to LDB, a LDAP-like API that can either to talk an embedded database (TDB-based) or a standards-compliant LDAP server.");
        if (m == NULL)
@@ -2735,6 +3277,8 @@ void initldb(void)
        Py_INCREF(&PyLdbMessage);
        Py_INCREF(&PyLdbMessageElement);
        Py_INCREF(&PyLdbTree);
+       Py_INCREF(&PyLdbResult);
+       Py_INCREF(&PyLdbControl);
 
        PyModule_AddObject(m, "Ldb", (PyObject *)&PyLdb);
        PyModule_AddObject(m, "Dn", (PyObject *)&PyLdbDn);
@@ -2742,6 +3286,17 @@ void initldb(void)
        PyModule_AddObject(m, "MessageElement", (PyObject *)&PyLdbMessageElement);
        PyModule_AddObject(m, "Module", (PyObject *)&PyLdbModule);
        PyModule_AddObject(m, "Tree", (PyObject *)&PyLdbTree);
+       PyModule_AddObject(m, "Control", (PyObject *)&PyLdbControl);
 
        PyModule_AddObject(m, "__version__", PyString_FromString(PACKAGE_VERSION));
+
+#define ADD_LDB_STRING(val)  PyModule_AddObject(m, #val, PyString_FromString(val))
+
+       ADD_LDB_STRING(LDB_SYNTAX_DN);
+       ADD_LDB_STRING(LDB_SYNTAX_DN);
+       ADD_LDB_STRING(LDB_SYNTAX_DIRECTORY_STRING);
+       ADD_LDB_STRING(LDB_SYNTAX_INTEGER);
+       ADD_LDB_STRING(LDB_SYNTAX_BOOLEAN);
+       ADD_LDB_STRING(LDB_SYNTAX_OCTET_STRING);
+       ADD_LDB_STRING(LDB_SYNTAX_UTC_TIME);
 }