s3-eventlog: remove fixup_eventlog_entry.
[kai/samba-autobuild/.git] / source3 / rpc_server / srv_eventlog_lib.c
index 8c7ce4a648554264f82f20df2c061eca71c18b41..57b3be43adbe9ff03e78e9030ac0882e5260c1d4 100644 (file)
-
-/* 
+/*
  *  Unix SMB/CIFS implementation.
  *  Eventlog utility  routines
  *  Copyright (C) Marcin Krzysztof Porwit    2005,
+ *  Copyright (C) Brian Moran                2005.
  *  Copyright (C) Gerald (Jerry) Carter      2005.
- *  
+ *  Copyright (C) Guenther Deschner          2009.
+ *
  *  This program is free software; you can redistribute it and/or modify
  *  it under the terms of the GNU General Public License as published by
- *  the Free Software Foundation; either version 2 of the License, or
+ *  the Free Software Foundation; either version 3 of the License, or
  *  (at your option) any later version.
- *  
+ *
  *  This program is distributed in the hope that it will be useful,
  *  but WITHOUT ANY WARRANTY; without even the implied warranty of
  *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  *  GNU General Public License for more details.
- *  
+ *
  *  You should have received a copy of the GNU General Public License
- *  along with this program; if not, write to the Free Software
- *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ *  along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
 #include "includes.h"
 
+/* maintain a list of open eventlog tdbs with reference counts */
 
-/****************************************************************
-Init an Eventlog TDB, and return it. If null, something bad happened.
-****************************************************************/
-TDB_CONTEXT *init_eventlog_tdb( char *tdbfilename )
+static ELOG_TDB *open_elog_list;
+
+/********************************************************************
+ Init an Eventlog TDB, and return it. If null, something bad
+ happened.
+********************************************************************/
+
+TDB_CONTEXT *elog_init_tdb( char *tdbfilename )
 {
-       TDB_CONTEXT *the_tdb;
+       TDB_CONTEXT *tdb;
+
+       DEBUG(10,("elog_init_tdb: Initializing eventlog tdb (%s)\n",
+               tdbfilename));
 
-       unlink( tdbfilename );
+       tdb = tdb_open_log( tdbfilename, 0, TDB_DEFAULT,
+               O_RDWR|O_CREAT|O_TRUNC, 0660 );
 
-       the_tdb =
-               tdb_open_log( tdbfilename, 0, TDB_DEFAULT, O_RDWR | O_CREAT,
-                             0664 );
-       if ( the_tdb == NULL ) {
-               DEBUG( 1, ( "Can't open tdb for [%s]\n", tdbfilename ) );
+       if ( !tdb ) {
+               DEBUG( 0, ( "Can't open tdb for [%s]\n", tdbfilename ) );
                return NULL;
        }
-       tdb_store_int32( the_tdb, VN_oldest_entry, 1 );
-       tdb_store_int32( the_tdb, VN_next_record, 1 );
 
        /* initialize with defaults, copy real values in here from registry */
 
-       tdb_store_int32( the_tdb, VN_maxsize, 0x80000 );
-       tdb_store_int32( the_tdb, VN_retention, 0x93A80 );
-
-       tdb_store_int32( the_tdb, VN_version, EVENTLOG_DATABASE_VERSION_V1 );
-       return the_tdb;
-}
+       tdb_store_int32( tdb, EVT_OLDEST_ENTRY, 1 );
+       tdb_store_int32( tdb, EVT_NEXT_RECORD, 1 );
+       tdb_store_int32( tdb, EVT_MAXSIZE, 0x80000 );
+       tdb_store_int32( tdb, EVT_RETENTION, 0x93A80 );
 
-/* make the tdb file name for an event log, given destination buffer and size */
-char *mk_tdbfilename( char *dest_buffer, char *eventlog_name, int size_dest )
-{
-       pstring ondisk_name;
+       tdb_store_int32( tdb, EVT_VERSION, EVENTLOG_DATABASE_VERSION_V1 );
 
-       if ( !dest_buffer )
-               return NULL;
-
-       pstrcpy( ondisk_name, "EV" );
-       pstrcat( ondisk_name, eventlog_name );
-       pstrcat( ondisk_name, ".tdb" );
+       return tdb;
+}
 
-       memset( dest_buffer, 0, size_dest );
+/********************************************************************
+ make the tdb file name for an event log, given destination buffer
+ and size. Caller must free memory.
+********************************************************************/
 
-       /* BAD things could happen if the dest_buffer is not large enough... */
-       if ( strlen( ondisk_name ) > size_dest ) {
-               DEBUG( 3, ( "Buffer not big enough for filename\n" ) );
+char *elog_tdbname(TALLOC_CTX *ctx, const char *name )
+{
+       char *path = talloc_asprintf(ctx, "%s/%s.tdb",
+                       state_path("eventlog"),
+                       name);
+       if (!path) {
                return NULL;
        }
-
-       strncpy( dest_buffer, ondisk_name, size_dest );
-
-       return dest_buffer;
+       strlower_m(path);
+       return path;
 }
 
 
-/* count the number of bytes in the TDB */
-
-/* Arg! Static Globals! */
+/********************************************************************
+ this function is used to count up the number of bytes in a
+ particular TDB
+********************************************************************/
 
-static int eventlog_tdbcount;
-static int eventlog_tdbsize;
+struct trav_size_struct {
+       int size;
+       int rec_count;
+};
 
-/* this function is used to count up the number of bytes in a particular TDB */
-int eventlog_tdb_size_fn( TDB_CONTEXT * tdb, TDB_DATA key, TDB_DATA data,
+static int eventlog_tdb_size_fn( TDB_CONTEXT * tdb, TDB_DATA key, TDB_DATA data,
                          void *state )
 {
-       eventlog_tdbsize += data.dsize;
-       eventlog_tdbcount++;
+       struct trav_size_struct  *tsize = (struct trav_size_struct *)state;
+
+       tsize->size += data.dsize;
+       tsize->rec_count++;
+
        return 0;
 }
 
-/* returns the size of the eventlog, and if MaxSize is a non-null ptr, puts 
-   the MaxSize there. This is purely a way not to have yet another function that solely
-   reads the maxsize of the eventlog. Yeah, that's it.  */
+/********************************************************************
+ returns the size of the eventlog, and if MaxSize is a non-null
+ ptr, puts the MaxSize there. This is purely a way not to have yet
+ another function that solely reads the maxsize of the eventlog.
+ Yeah, that's it.
+********************************************************************/
 
-int eventlog_tdb_size( TDB_CONTEXT * tdb, int *MaxSize, int *Retention )
+int elog_tdb_size( TDB_CONTEXT * tdb, int *MaxSize, int *Retention )
 {
+       struct trav_size_struct tsize;
+
        if ( !tdb )
                return 0;
-       eventlog_tdbcount = 0;
-       eventlog_tdbsize = 0;
 
-       tdb_traverse( tdb, eventlog_tdb_size_fn, NULL );
+       ZERO_STRUCT( tsize );
+
+       tdb_traverse( tdb, eventlog_tdb_size_fn, &tsize );
 
        if ( MaxSize != NULL ) {
-               *MaxSize = tdb_fetch_int32( tdb, VN_maxsize );
+               *MaxSize = tdb_fetch_int32( tdb, EVT_MAXSIZE );
        }
 
        if ( Retention != NULL ) {
-               *Retention = tdb_fetch_int32( tdb, VN_retention );
+               *Retention = tdb_fetch_int32( tdb, EVT_RETENTION );
        }
 
        DEBUG( 1,
-              ( "eventlog size: [%d] for [%d] records\n", eventlog_tdbsize,
-                eventlog_tdbcount ) );
-       return eventlog_tdbsize;
+              ( "eventlog size: [%d] for [%d] records\n", tsize.size,
+                tsize.rec_count ) );
+       return tsize.size;
 }
 
+/********************************************************************
+ Discard early event logs until we have enough for 'needed' bytes...
+ NO checking done beforehand to see that we actually need to do
+ this, and it's going to pluck records one-by-one. So, it's best
+ to determine that this needs to be done before doing it.
 
-/* 
-   Discard early event logs until we have enough for 'needed' bytes...
-   NO checking done beforehand to see that we actually need to do this, and
-   it's going to pluck records one-by-one. So, it's best to determine that this 
-   needs to be done before doing it.  
-
-   Setting whack_by_date to True indicates that eventlogs falling outside of the 
-   retention range need to go...
+ Setting whack_by_date to True indicates that eventlogs falling
+ outside of the retention range need to go...
 
-*/
-
-/* return True if we made enough room to accommodate needed bytes */
+ return True if we made enough room to accommodate needed bytes
+********************************************************************/
 
-BOOL make_way_for_eventlogs( TDB_CONTEXT * the_tdb, int32 needed,
-                            BOOL whack_by_date )
+static bool make_way_for_eventlogs( TDB_CONTEXT * the_tdb, int32_t needed,
+                                   bool whack_by_date )
 {
-       int start_record, i, new_start;
-       int end_record;
-       int nbytes, reclen, len, Retention, MaxSize;
-
-       int tresv1, trecnum, timegen, timewr;
-
+       int32_t start_record, i, new_start;
+       int32_t end_record;
+       int32_t reclen, tresv1, trecnum, timegen, timewr;
+       int nbytes, len, Retention, MaxSize;
        TDB_DATA key, ret;
-       TALLOC_CTX *mem_ctx = NULL;
-
        time_t current_time, exp_time;
 
        /* discard some eventlogs */
@@ -153,17 +156,14 @@ BOOL make_way_for_eventlogs( TDB_CONTEXT * the_tdb, int32 needed,
        /* read eventlogs from oldest_entry -- there can't be any discontinuity in recnos,
           although records not necessarily guaranteed to have successive times */
        /* */
-       mem_ctx = talloc_init( "make_way_for_eventlogs" );      /* Homage to BPG */
 
-       if ( mem_ctx == NULL )
-               return False;   /* can't allocate memory indicates bigger problems */
        /* lock */
-       tdb_lock_bystring( the_tdb, VN_next_record, 1 );
+       tdb_lock_bystring_with_timeout( the_tdb, EVT_NEXT_RECORD, 1 );
        /* read */
-       end_record = tdb_fetch_int32( the_tdb, VN_next_record );
-       start_record = tdb_fetch_int32( the_tdb, VN_oldest_entry );
-       Retention = tdb_fetch_int32( the_tdb, VN_retention );
-       MaxSize = tdb_fetch_int32( the_tdb, VN_maxsize );
+       end_record = tdb_fetch_int32( the_tdb, EVT_NEXT_RECORD );
+       start_record = tdb_fetch_int32( the_tdb, EVT_OLDEST_ENTRY );
+       Retention = tdb_fetch_int32( the_tdb, EVT_RETENTION );
+       MaxSize = tdb_fetch_int32( the_tdb, EVT_MAXSIZE );
 
        time( &current_time );
 
@@ -174,37 +174,45 @@ BOOL make_way_for_eventlogs( TDB_CONTEXT * the_tdb, int32 needed,
        nbytes = 0;
 
        DEBUG( 3,
-              ( "MaxSize [%d] Retention [%d] Current Time [%d]  exp_time [%d]\n",
-                MaxSize, Retention, (uint32)current_time, (uint32)exp_time ) );
+              ( "MaxSize [%d] Retention [%d] Current Time [%u]  exp_time [%u]\n",
+                MaxSize, Retention, (unsigned int)current_time, (unsigned int)exp_time ) );
        DEBUG( 3,
-              ( "Start Record [%d] End Record [%d]\n", start_record,
-                end_record ) );
+              ( "Start Record [%u] End Record [%u]\n",
+               (unsigned int)start_record,
+               (unsigned int)end_record ));
 
        for ( i = start_record; i < end_record; i++ ) {
                /* read a record, add the amt to nbytes */
-               key.dsize = sizeof( int32 );
-               key.dptr = ( char * ) ( int32 * ) & i;
+               key.dsize = sizeof(int32_t);
+               key.dptr = (unsigned char *)&i;
                ret = tdb_fetch( the_tdb, key );
                if ( ret.dsize == 0 ) {
                        DEBUG( 8,
                               ( "Can't find a record for the key, record [%d]\n",
                                 i ) );
-                       tdb_unlock_bystring( the_tdb, VN_next_record );
+                       tdb_unlock_bystring( the_tdb, EVT_NEXT_RECORD );
                        return False;
                }
                nbytes += ret.dsize;    /* note this includes overhead */
 
                len = tdb_unpack( ret.dptr, ret.dsize, "ddddd", &reclen,
                                  &tresv1, &trecnum, &timegen, &timewr );
+               if (len == -1) {
+                       DEBUG( 10,("make_way_for_eventlogs: tdb_unpack failed.\n"));
+                       tdb_unlock_bystring( the_tdb, EVT_NEXT_RECORD );
+                       SAFE_FREE( ret.dptr );
+                       return False;
+               }
+
                DEBUG( 8,
-                      ( "read record %d, record size is [%d], total so far [%d]\n",
-                        i, reclen, nbytes ) );
+                      ( "read record %u, record size is [%d], total so far [%d]\n",
+                        (unsigned int)i, reclen, nbytes ) );
 
                SAFE_FREE( ret.dptr );
 
                /* note that other servers may just stop writing records when the size limit
-                  is reached, and there are no records older than 'retention'. This doesn't 
-                  like a very useful thing to do, so instead we whack (as in sleeps with the 
+                  is reached, and there are no records older than 'retention'. This doesn't
+                  like a very useful thing to do, so instead we whack (as in sleeps with the
                   fishes) just enough records to fit the what we need.  This behavior could
                   be changed to 'match', if the need arises. */
 
@@ -215,29 +223,29 @@ BOOL make_way_for_eventlogs( TDB_CONTEXT * the_tdb, int32 needed,
        }
 
        DEBUG( 3,
-              ( "nbytes [%d] needed [%d] start_record is [%d], should be set to [%d]\n",
-                nbytes, needed, start_record, i ) );
+              ( "nbytes [%d] needed [%d] start_record is [%u], should be set to [%u]\n",
+                nbytes, needed, (unsigned int)start_record, (unsigned int)i ) );
        /* todo - remove eventlog entries here and set starting record to start_record... */
        new_start = i;
        if ( start_record != new_start ) {
                for ( i = start_record; i < new_start; i++ ) {
-                       key.dsize = sizeof( int32 );
-                       key.dptr = ( char * ) ( int32 * ) & i;
+                       key.dsize = sizeof(int32_t);
+                       key.dptr = (unsigned char *)&i;
                        tdb_delete( the_tdb, key );
                }
 
-               tdb_store_int32( the_tdb, VN_oldest_entry, new_start );
+               tdb_store_int32( the_tdb, EVT_OLDEST_ENTRY, new_start );
        }
-       tdb_unlock_bystring( the_tdb, VN_next_record );
+       tdb_unlock_bystring( the_tdb, EVT_NEXT_RECORD );
        return True;
 }
 
-/*
-  some hygiene for an eventlog - see how big it is, and then 
-  calculate how many bytes we need to remove                   
-*/
+/********************************************************************
+  some hygiene for an eventlog - see how big it is, and then
+  calculate how many bytes we need to remove
+********************************************************************/
 
-BOOL prune_eventlog( TDB_CONTEXT * tdb )
+bool prune_eventlog( TDB_CONTEXT * tdb )
 {
        int MaxSize, Retention, CalcdSize;
 
@@ -246,7 +254,7 @@ BOOL prune_eventlog( TDB_CONTEXT * tdb )
                return False;
        }
 
-       CalcdSize = eventlog_tdb_size( tdb, &MaxSize, &Retention );
+       CalcdSize = elog_tdb_size( tdb, &MaxSize, &Retention );
        DEBUG( 3,
               ( "Calculated size [%d] MaxSize [%d]\n", CalcdSize,
                 MaxSize ) );
@@ -259,7 +267,10 @@ BOOL prune_eventlog( TDB_CONTEXT * tdb )
        return make_way_for_eventlogs( tdb, 0, True );
 }
 
-BOOL can_write_to_eventlog( TDB_CONTEXT * tdb, int32 needed )
+/********************************************************************
+********************************************************************/
+
+static bool can_write_to_eventlog( TDB_CONTEXT * tdb, int32_t needed )
 {
        int calcd_size;
        int MaxSize, Retention;
@@ -274,7 +285,7 @@ BOOL can_write_to_eventlog( TDB_CONTEXT * tdb, int32 needed )
        MaxSize = 0;
        Retention = 0;
 
-       calcd_size = eventlog_tdb_size( tdb, &MaxSize, &Retention );
+       calcd_size = elog_tdb_size( tdb, &MaxSize, &Retention );
 
        if ( calcd_size <= MaxSize )
                return True;    /* you betcha */
@@ -299,172 +310,152 @@ BOOL can_write_to_eventlog( TDB_CONTEXT * tdb, int32 needed )
        return make_way_for_eventlogs( tdb, calcd_size - MaxSize, False );
 }
 
-TDB_CONTEXT *open_eventlog_tdb( char *tdbfilename )
-{
-       TDB_CONTEXT *the_tdb;
+/*******************************************************************
+*******************************************************************/
 
-       the_tdb =
-               tdb_open_log( tdbfilename, 0, TDB_DEFAULT, O_RDWR | O_CREAT,
-                             0664 );
-       if ( the_tdb == NULL ) {
-               return init_eventlog_tdb( tdbfilename );
-       }
-       if ( EVENTLOG_DATABASE_VERSION_V1 !=
-            tdb_fetch_int32( the_tdb, VN_version ) ) {
-               tdb_close( the_tdb );
-               return init_eventlog_tdb( tdbfilename );
+ELOG_TDB *elog_open_tdb( const char *logname, bool force_clear, bool read_only )
+{
+       TDB_CONTEXT *tdb = NULL;
+       uint32_t vers_id;
+       ELOG_TDB *ptr;
+       char *tdbpath = NULL;
+       ELOG_TDB *tdb_node = NULL;
+       char *eventlogdir;
+       TALLOC_CTX *ctx = talloc_tos();
+
+       /* check for invalid options */
+
+       if (force_clear && read_only) {
+               DEBUG(1,("elog_open_tdb: Invalid flags\n"));
+               return NULL;
        }
-       return the_tdb;
-}
 
-/* write an eventlog entry. Note that we have to lock, read next eventlog, increment, write, write the record, unlock */
+       /* first see if we have an open context */
 
-/* coming into this, ee has the eventlog record, and the auxilliary date (computer name, etc.) 
-   filled into the other structure. Before packing into a record, this routine will calc the 
-   appropriate padding, etc., and then blast out the record in a form that can be read back in */
-int write_eventlog_tdb( TDB_CONTEXT * the_tdb, Eventlog_entry * ee )
-{
-       int32 next_record;
-       uint8 *packed_ee;
-       TALLOC_CTX *mem_ctx = NULL;
-       TDB_DATA kbuf, ebuf;
-       uint32 n_packed;
+       for ( ptr=open_elog_list; ptr; ptr=ptr->next ) {
+               if ( strequal( ptr->name, logname ) ) {
+                       ptr->ref_count++;
 
-       if ( !ee )
-               return 0;
+                       /* trick to alow clearing of the eventlog tdb.
+                          The force_clear flag should imply that someone
+                          has done a force close.  So make sure the tdb
+                          is NULL.  If this is a normal open, then just
+                          return the existing reference */
 
-       mem_ctx = talloc_init( "write_eventlog_tdb" );
+                       if ( force_clear ) {
+                               SMB_ASSERT( ptr->tdb == NULL );
+                               break;
+                       }
+                       else
+                               return ptr;
+               }
+       }
 
-       if ( mem_ctx == NULL )
-               return 0;
+       /* make sure that the eventlog dir exists */
 
-       if ( !ee )
-               return 0;
-       /* discard any entries that have bogus time, which usually indicates a bogus entry as well. */
-       if ( ee->record.time_generated == 0 )
-               return 0;
+       eventlogdir = state_path( "eventlog" );
+       if ( !directory_exist( eventlogdir ) )
+               mkdir( eventlogdir, 0755 );
 
-#define MARGIN 512
+       /* get the path on disk */
 
-       /* todo - check for sanity in next_record */
+       tdbpath = elog_tdbname(ctx, logname);
+       if (!tdbpath) {
+               return NULL;
+       }
 
-       fixup_eventlog_entry( ee );
+       DEBUG(7,("elog_open_tdb: Opening %s...(force_clear == %s)\n",
+               tdbpath, force_clear?"True":"False" ));
 
-       if ( !can_write_to_eventlog( the_tdb, ee->record.length ) ) {
-               DEBUG( 3, ( "Can't write to Eventlog, no room \n" ) );
-               talloc_destroy( mem_ctx );
-               return 0;
-       }
+       /* the tdb wasn't already open or this is a forced clear open */
 
-       /* alloc mem for the packed version */
-       packed_ee = TALLOC( mem_ctx, ee->record.length + MARGIN );
-       if ( !packed_ee ) {
-               talloc_destroy( mem_ctx );
-               return 0;
+       if ( !force_clear ) {
+
+               tdb = tdb_open_log( tdbpath, 0, TDB_DEFAULT, read_only ? O_RDONLY : O_RDWR , 0 );
+               if ( tdb ) {
+                       vers_id = tdb_fetch_int32( tdb, EVT_VERSION );
+
+                       if ( vers_id != EVENTLOG_DATABASE_VERSION_V1 ) {
+                               DEBUG(1,("elog_open_tdb: Invalid version [%d] on file [%s].\n",
+                                       vers_id, tdbpath));
+                               tdb_close( tdb );
+                               tdb = elog_init_tdb( tdbpath );
+                       }
+               }
        }
 
-       /* need to read the record number and insert it into the entry here */
+       if ( !tdb )
+               tdb = elog_init_tdb( tdbpath );
 
-       /* lock */
-       tdb_lock_bystring( the_tdb, VN_next_record, 1 );
-       /* read */
-       next_record = tdb_fetch_int32( the_tdb, VN_next_record );
-
-       n_packed =
-               tdb_pack( packed_ee, ee->record.length + MARGIN,
-                         "ddddddwwwwddddddBBdBBBd", ee->record.length,
-                         ee->record.reserved1, next_record,
-                         ee->record.time_generated, ee->record.time_written,
-                         ee->record.event_id, ee->record.event_type,
-                         ee->record.num_strings, ee->record.event_category,
-                         ee->record.reserved2,
-                         ee->record.closing_record_number,
-                         ee->record.string_offset,
-                         ee->record.user_sid_length,
-                         ee->record.user_sid_offset, ee->record.data_length,
-                         ee->record.data_offset,
-                         ee->data_record.source_name_len,
-                         ee->data_record.source_name,
-                         ee->data_record.computer_name_len,
-                         ee->data_record.computer_name,
-                         ee->data_record.sid_padding,
-                         ee->record.user_sid_length, ee->data_record.sid,
-                         ee->data_record.strings_len,
-                         ee->data_record.strings,
-                         ee->data_record.user_data_len,
-                         ee->data_record.user_data,
-                         ee->data_record.data_padding );
-
-       /*DEBUG(3,("write_eventlog_tdb: packed into  %d\n",n_packed)); */
+       /* if we got a valid context, then add it to the list */
 
-       /* increment the record count */
+       if ( tdb ) {
+               /* on a forced clear, just reset the tdb context if we already
+                  have an open entry in the list */
 
-       kbuf.dsize = sizeof( int32 );
-       kbuf.dptr = ( uint8 * ) & next_record;
+               if ( ptr ) {
+                       ptr->tdb = tdb;
+                       return ptr;
+               }
 
-       ebuf.dsize = n_packed;
-       ebuf.dptr = packed_ee;
+               if ( !(tdb_node = TALLOC_ZERO_P( NULL, ELOG_TDB)) ) {
+                       DEBUG(0,("elog_open_tdb: talloc() failure!\n"));
+                       tdb_close( tdb );
+                       return NULL;
+               }
 
-       if ( tdb_store( the_tdb, kbuf, ebuf, 0 ) ) {
-               /* DEBUG(1,("write_eventlog_tdb: Can't write record %d to eventlog\n",next_record)); */
-               tdb_unlock_bystring( the_tdb, VN_next_record );
-               talloc_destroy( mem_ctx );
-               return 0;
+               tdb_node->name = talloc_strdup( tdb_node, logname );
+               tdb_node->tdb = tdb;
+               tdb_node->ref_count = 1;
+
+               DLIST_ADD( open_elog_list, tdb_node );
        }
-       next_record++;
-       tdb_store_int32( the_tdb, VN_next_record, next_record );
-       tdb_unlock_bystring( the_tdb, VN_next_record );
-       talloc_destroy( mem_ctx );
-       return ( next_record - 1 );
+
+       return tdb_node;
 }
 
-/* calculate the correct fields etc for an eventlog entry */
+/*******************************************************************
+ Wrapper to handle reference counts to the tdb
+*******************************************************************/
 
-void fixup_eventlog_entry( Eventlog_entry * ee )
+int elog_close_tdb( ELOG_TDB *etdb, bool force_close )
 {
-       /* fix up the eventlog entry structure as necessary */
+       TDB_CONTEXT *tdb;
 
-       ee->data_record.sid_padding =
-               ( ( 4 -
-                   ( ( ee->data_record.source_name_len +
-                       ee->data_record.computer_name_len ) % 4 ) ) % 4 );
-       ee->data_record.data_padding =
-               ( 4 -
-                 ( ( ee->data_record.strings_len +
-                     ee->data_record.user_data_len ) % 4 ) ) % 4;
-       ee->record.length = sizeof( Eventlog_record );
-       ee->record.length += ee->data_record.source_name_len;
-       ee->record.length += ee->data_record.computer_name_len;
-       if ( ee->record.user_sid_length == 0 ) {
-               /* Should not pad to a DWORD boundary for writing out the sid if there is
-                  no SID, so just propagate the padding to pad the data */
-               ee->data_record.data_padding += ee->data_record.sid_padding;
-               ee->data_record.sid_padding = 0;
+       if ( !etdb )
+               return 0;
+
+       etdb->ref_count--;
+
+       SMB_ASSERT( etdb->ref_count >= 0 );
+
+       if ( etdb->ref_count == 0 ) {
+               tdb = etdb->tdb;
+               DLIST_REMOVE( open_elog_list, etdb );
+               TALLOC_FREE( etdb );
+               return tdb_close( tdb );
        }
-       /* DEBUG(10, ("sid_padding is [%d].\n", ee->data_record.sid_padding)); */
-       /* DEBUG(10, ("data_padding is [%d].\n", ee->data_record.data_padding)); */
 
-       ee->record.length += ee->data_record.sid_padding;
-       ee->record.length += ee->record.user_sid_length;
-       ee->record.length += ee->data_record.strings_len;
-       ee->record.length += ee->data_record.user_data_len;
-       ee->record.length += ee->data_record.data_padding;
-       /* need another copy of length at the end of the data */
-       ee->record.length += sizeof( ee->record.length );
+       if ( force_close ) {
+               tdb = etdb->tdb;
+               etdb->tdb = NULL;
+               return tdb_close( tdb );
+       }
+
+       return 0;
 }
 
 /********************************************************************
-Note that it's a pretty good idea to initialize the Eventlog_entry structure to zero's before
-calling parse_logentry on an batch of lines that may resolve to a record.
-ALSO, it's a good idea to remove any linefeeds (that's EOL to you and me) on the lines going in.
-
+ Note that it's a pretty good idea to initialize the Eventlog_entry
+ structure to zero's before calling parse_logentry on an batch of
+ lines that may resolve to a record.  ALSO, it's a good idea to
+ remove any linefeeds (that's EOL to you and me) on the lines
+ going in.
 ********************************************************************/
 
-BOOL parse_logentry( char *line, Eventlog_entry * entry, BOOL * eor )
+bool parse_logentry( TALLOC_CTX *mem_ctx, char *line, struct eventlog_Record_tdb *entry, bool * eor )
 {
        char *start = NULL, *stop = NULL;
-       pstring temp;
-       int temp_len = 0;
 
        start = line;
 
@@ -483,32 +474,32 @@ BOOL parse_logentry( char *line, Eventlog_entry * entry, BOOL * eor )
 
        if ( 0 == strncmp( start, "LEN", stop - start ) ) {
                /* This will get recomputed later anyway -- probably not necessary */
-               entry->record.length = atoi( stop + 1 );
+               entry->size = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "RS1", stop - start ) ) {
                /* For now all these reserved entries seem to have the same value,
                   which can be hardcoded to int(1699505740) for now */
-               entry->record.reserved1 = atoi( stop + 1 );
+               entry->reserved = talloc_strdup(mem_ctx, "eLfL");
        } else if ( 0 == strncmp( start, "RCN", stop - start ) ) {
-               entry->record.record_number = atoi( stop + 1 );
+               entry->record_number = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "TMG", stop - start ) ) {
-               entry->record.time_generated = atoi( stop + 1 );
+               entry->time_generated = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "TMW", stop - start ) ) {
-               entry->record.time_written = atoi( stop + 1 );
+               entry->time_written = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "EID", stop - start ) ) {
-               entry->record.event_id = atoi( stop + 1 );
+               entry->event_id = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "ETP", stop - start ) ) {
                if ( strstr( start, "ERROR" ) ) {
-                       entry->record.event_type = EVENTLOG_ERROR_TYPE;
+                       entry->event_type = EVENTLOG_ERROR_TYPE;
                } else if ( strstr( start, "WARNING" ) ) {
-                       entry->record.event_type = EVENTLOG_WARNING_TYPE;
+                       entry->event_type = EVENTLOG_WARNING_TYPE;
                } else if ( strstr( start, "INFO" ) ) {
-                       entry->record.event_type = EVENTLOG_INFORMATION_TYPE;
+                       entry->event_type = EVENTLOG_INFORMATION_TYPE;
                } else if ( strstr( start, "AUDIT_SUCCESS" ) ) {
-                       entry->record.event_type = EVENTLOG_AUDIT_SUCCESS;
+                       entry->event_type = EVENTLOG_AUDIT_SUCCESS;
                } else if ( strstr( start, "AUDIT_FAILURE" ) ) {
-                       entry->record.event_type = EVENTLOG_AUDIT_FAILURE;
+                       entry->event_type = EVENTLOG_AUDIT_FAILURE;
                } else if ( strstr( start, "SUCCESS" ) ) {
-                       entry->record.event_type = EVENTLOG_SUCCESS;
+                       entry->event_type = EVENTLOG_SUCCESS;
                } else {
                        /* some other eventlog type -- currently not defined in MSDN docs, so error out */
                        return False;
@@ -518,104 +509,444 @@ BOOL parse_logentry( char *line, Eventlog_entry * entry, BOOL * eor )
 /*
   else if(0 == strncmp(start, "NST", stop - start))
   {
-  entry->record.num_strings = atoi(stop + 1);
+  entry->num_of_strings = atoi(stop + 1);
   }
 */
        else if ( 0 == strncmp( start, "ECT", stop - start ) ) {
-               entry->record.event_category = atoi( stop + 1 );
+               entry->event_category = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "RS2", stop - start ) ) {
-               entry->record.reserved2 = atoi( stop + 1 );
+               entry->reserved_flags = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "CRN", stop - start ) ) {
-               entry->record.closing_record_number = atoi( stop + 1 );
+               entry->closing_record_number = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "USL", stop - start ) ) {
-               entry->record.user_sid_length = atoi( stop + 1 );
+               entry->sid_length = atoi( stop + 1 );
        } else if ( 0 == strncmp( start, "SRC", stop - start ) ) {
-               memset( temp, 0, sizeof( temp ) );
                stop++;
                while ( isspace( stop[0] ) ) {
                        stop++;
                }
-               temp_len = strlen( stop );
-               strncpy( temp, stop, temp_len );
-               rpcstr_push( ( void * ) ( entry->data_record.source_name ),
-                            temp, sizeof( entry->data_record.source_name ),
-                            STR_TERMINATE );
-               entry->data_record.source_name_len =
-                       ( strlen_w( entry->data_record.source_name ) * 2 ) +
-                       2;
+               entry->source_name_len = strlen_m_term(stop);
+               entry->source_name = talloc_strdup(mem_ctx, stop);
+               if (entry->source_name_len == (uint32_t)-1 ||
+                               entry->source_name == NULL) {
+                       return false;
+               }
        } else if ( 0 == strncmp( start, "SRN", stop - start ) ) {
-               memset( temp, 0, sizeof( temp ) );
                stop++;
                while ( isspace( stop[0] ) ) {
                        stop++;
                }
-               temp_len = strlen( stop );
-               strncpy( temp, stop, temp_len );
-               rpcstr_push( ( void * ) ( entry->data_record.computer_name ),
-                            temp, sizeof( entry->data_record.computer_name ),
-                            STR_TERMINATE );
-               entry->data_record.computer_name_len =
-                       ( strlen_w( entry->data_record.computer_name ) * 2 ) +
-                       2;
+               entry->computer_name_len = strlen_m_term(stop);
+               entry->computer_name = talloc_strdup(mem_ctx, stop);
+               if (entry->computer_name_len == (uint32_t)-1 ||
+                               entry->computer_name == NULL) {
+                       return false;
+               }
        } else if ( 0 == strncmp( start, "SID", stop - start ) ) {
-               memset( temp, 0, sizeof( temp ) );
+               smb_ucs2_t *dummy = NULL;
                stop++;
                while ( isspace( stop[0] ) ) {
                        stop++;
                }
-               temp_len = strlen( stop );
-               strncpy( temp, stop, temp_len );
-               rpcstr_push( ( void * ) ( entry->data_record.sid ), temp,
-                            sizeof( entry->data_record.sid ),
-                            STR_TERMINATE );
-               entry->record.user_sid_length =
-                       ( strlen_w( entry->data_record.sid ) * 2 ) + 2;
+               entry->sid_length = rpcstr_push_talloc(mem_ctx,
+                               &dummy,
+                               stop);
+               entry->sid = data_blob_talloc(mem_ctx, dummy, entry->sid_length);
+               if (entry->sid_length == (uint32_t)-1 ||
+                               entry->sid.data == NULL) {
+                       return false;
+               }
        } else if ( 0 == strncmp( start, "STR", stop - start ) ) {
+               size_t tmp_len;
                /* skip past initial ":" */
                stop++;
                /* now skip any other leading whitespace */
-               while ( isspace( stop[0] ) ) {
+               while ( isspace(stop[0])) {
                        stop++;
                }
-               temp_len = strlen( stop );
-               memset( temp, 0, sizeof( temp ) );
-               strncpy( temp, stop, temp_len );
-               rpcstr_push( ( void * ) ( entry->data_record.strings +
-                                         entry->data_record.strings_len ),
-                            temp,
-                            sizeof( entry->data_record.strings ) -
-                            entry->data_record.strings_len, STR_TERMINATE );
-               entry->data_record.strings_len += temp_len + 1;
-               entry->record.num_strings++;
+               tmp_len = strlen_m_term(stop);
+               if (tmp_len == (size_t)-1) {
+                       return false;
+               }
+               if (!add_string_to_array(mem_ctx, stop, &entry->strings,
+                                        (int *)&entry->num_of_strings)) {
+                       return false;
+               }
+               entry->strings_len += tmp_len;
        } else if ( 0 == strncmp( start, "DAT", stop - start ) ) {
-               /* Now that we're done processing the STR data, adjust the length to account for
-                  unicode, then proceed with the DAT data. */
-               entry->data_record.strings_len *= 2;
                /* skip past initial ":" */
                stop++;
                /* now skip any other leading whitespace */
                while ( isspace( stop[0] ) ) {
                        stop++;
                }
-               entry->data_record.user_data_len = strlen( stop );
-               memset( entry->data_record.user_data, 0,
-                       sizeof( entry->data_record.user_data ) );
-               if ( entry->data_record.user_data_len > 0 ) {
-                       /* copy no more than the first 1024 bytes */
-                       if ( entry->data_record.user_data_len >
-                            sizeof( entry->data_record.user_data ) )
-                               entry->data_record.user_data_len =
-                                       sizeof( entry->data_record.
-                                               user_data );
-                       memcpy( entry->data_record.user_data, stop,
-                               entry->data_record.user_data_len );
+               entry->data_length = strlen_m(stop);
+               entry->data = data_blob_talloc(mem_ctx, stop, entry->data_length);
+               if (!entry->data.data) {
+                       return false;
                }
        } else {
                /* some other eventlog entry -- not implemented, so dropping on the floor */
                DEBUG( 10, ( "Unknown entry [%s]. Ignoring.\n", line ) );
                /* For now return true so that we can keep on parsing this mess. Eventually
                   we will return False here. */
-               return True;
+               return true;
        }
-       return True;
+       return true;
+}
+
+/*******************************************************************
+ calculate the correct fields etc for an eventlog entry
+*******************************************************************/
+
+size_t fixup_eventlog_record_tdb(struct eventlog_Record_tdb *r)
+{
+       size_t size = 56; /* static size of integers before buffers start */
+
+       r->source_name_len = strlen_m_term(r->source_name) * 2;
+       r->computer_name_len = strlen_m_term(r->computer_name) * 2;
+       r->strings_len = ndr_size_string_array(r->strings,
+               r->num_of_strings, LIBNDR_FLAG_STR_NULLTERM) * 2;
+
+       /* fix up the eventlog entry structure as necessary */
+       r->sid_padding = ( ( 4 - ( ( r->source_name_len + r->computer_name_len ) % 4 ) ) % 4 );
+       r->padding =       ( 4 - ( ( r->strings_len + r->data_length ) % 4 ) ) % 4;
+
+       if (r->sid_length == 0) {
+               /* Should not pad to a DWORD boundary for writing out the sid if there is
+                  no SID, so just propagate the padding to pad the data */
+               r->padding += r->sid_padding;
+               r->sid_padding = 0;
+       }
+
+       size += r->source_name_len;
+       size += r->computer_name_len;
+       size += r->sid_padding;
+       size += r->sid_length;
+       size += r->strings_len;
+       size += r->data_length;
+       size += r->padding;
+       /* need another copy of length at the end of the data */
+       size += sizeof(r->size);
+
+       r->size = size;
+
+       return size;
+}
+
+
+/********************************************************************
+ ********************************************************************/
+
+struct eventlog_Record_tdb *evlog_pull_record_tdb(TALLOC_CTX *mem_ctx,
+                                                 TDB_CONTEXT *tdb,
+                                                 uint32_t record_number)
+{
+       struct eventlog_Record_tdb *r;
+       TDB_DATA data, key;
+
+       int32_t srecno;
+       enum ndr_err_code ndr_err;
+       DATA_BLOB blob;
+
+       srecno = record_number;
+       key.dptr = (unsigned char *)&srecno;
+       key.dsize = sizeof(int32_t);
+
+       data = tdb_fetch(tdb, key);
+       if (data.dsize == 0) {
+               DEBUG(8,("evlog_pull_record_tdb: "
+                       "Can't find a record for the key, record %d\n",
+                       record_number));
+               return NULL;
+       }
+
+       r = talloc_zero(mem_ctx, struct eventlog_Record_tdb);
+       if (!r) {
+               goto done;
+       }
+
+       blob = data_blob_const(data.dptr, data.dsize);
+
+       ndr_err = ndr_pull_struct_blob(&blob, mem_ctx, NULL, r,
+                          (ndr_pull_flags_fn_t)ndr_pull_eventlog_Record_tdb);
+
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               DEBUG(10,("evlog_pull_record_tdb: failed to decode record %d\n",
+                       record_number));
+               TALLOC_FREE(r);
+               goto done;
+       }
+
+       if (DEBUGLEVEL >= 10) {
+               NDR_PRINT_DEBUG(eventlog_Record_tdb, r);
+       }
+
+       DEBUG(10,("evlog_pull_record_tdb: retrieved entry for record %d\n",
+               record_number));
+ done:
+       SAFE_FREE(data.dptr);
+
+       return r;
+}
+
+/********************************************************************
+ ********************************************************************/
+
+struct EVENTLOGRECORD *evlog_pull_record(TALLOC_CTX *mem_ctx,
+                                        TDB_CONTEXT *tdb,
+                                        uint32_t record_number)
+{
+       struct eventlog_Record_tdb *t;
+       struct EVENTLOGRECORD *r;
+       NTSTATUS status;
+
+       r = talloc_zero(mem_ctx, struct EVENTLOGRECORD);
+       if (!r) {
+               return NULL;
+       }
+
+       t = evlog_pull_record_tdb(r, tdb, record_number);
+       if (!t) {
+               talloc_free(r);
+               return NULL;
+       }
+
+       status = evlog_tdb_entry_to_evt_entry(r, t, r);
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(r);
+               return NULL;
+       }
+
+       r->Length = r->Length2 = ndr_size_EVENTLOGRECORD(r, NULL, 0);
+
+       return r;
+}
+
+/********************************************************************
+ write an eventlog entry. Note that we have to lock, read next
+ eventlog, increment, write, write the record, unlock
+
+ coming into this, ee has the eventlog record, and the auxilliary date
+ (computer name, etc.) filled into the other structure. Before packing
+ into a record, this routine will calc the appropriate padding, etc.,
+ and then blast out the record in a form that can be read back in
+ ********************************************************************/
+
+NTSTATUS evlog_push_record_tdb(TALLOC_CTX *mem_ctx,
+                              TDB_CONTEXT *tdb,
+                              struct eventlog_Record_tdb *r,
+                              uint32_t *record_number)
+{
+       TDB_DATA kbuf, ebuf;
+       DATA_BLOB blob;
+       enum ndr_err_code ndr_err;
+       int ret;
+
+       if (!r) {
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+
+       if (!can_write_to_eventlog(tdb, r->size)) {
+               return NT_STATUS_EVENTLOG_CANT_START;
+       }
+
+       /* need to read the record number and insert it into the entry here */
+
+       /* lock */
+       ret = tdb_lock_bystring_with_timeout(tdb, EVT_NEXT_RECORD, 1);
+       if (ret == -1) {
+               return NT_STATUS_LOCK_NOT_GRANTED;
+       }
+
+       /* read */
+       r->record_number = tdb_fetch_int32(tdb, EVT_NEXT_RECORD);
+
+       ndr_err = ndr_push_struct_blob(&blob, mem_ctx, NULL, r,
+                     (ndr_push_flags_fn_t)ndr_push_eventlog_Record_tdb);
+       if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
+               tdb_unlock_bystring(tdb, EVT_NEXT_RECORD);
+               return ndr_map_error2ntstatus(ndr_err);
+       }
+
+       /* increment the record count */
+
+       kbuf.dsize = sizeof(int32_t);
+       kbuf.dptr = (uint8_t *)&r->record_number;
+
+       ebuf.dsize = blob.length;
+       ebuf.dptr  = blob.data;
+
+       ret = tdb_store(tdb, kbuf, ebuf, 0);
+       if (ret == -1) {
+               tdb_unlock_bystring(tdb, EVT_NEXT_RECORD);
+               return NT_STATUS_EVENTLOG_FILE_CORRUPT;
+       }
+
+       ret = tdb_store_int32(tdb, EVT_NEXT_RECORD, r->record_number + 1);
+       if (ret == -1) {
+               tdb_unlock_bystring(tdb, EVT_NEXT_RECORD);
+               return NT_STATUS_EVENTLOG_FILE_CORRUPT;
+       }
+       tdb_unlock_bystring(tdb, EVT_NEXT_RECORD);
+
+       if (record_number) {
+               *record_number = r->record_number;
+       }
+
+       return NT_STATUS_OK;
+}
+
+/********************************************************************
+ ********************************************************************/
+
+NTSTATUS evlog_push_record(TALLOC_CTX *mem_ctx,
+                          TDB_CONTEXT *tdb,
+                          struct EVENTLOGRECORD *r,
+                          uint32_t *record_number)
+{
+       struct eventlog_Record_tdb *t;
+       NTSTATUS status;
+
+       t = talloc_zero(mem_ctx, struct eventlog_Record_tdb);
+       if (!t) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       status = evlog_evt_entry_to_tdb_entry(t, r, t);
+       if (!NT_STATUS_IS_OK(status)) {
+               talloc_free(t);
+               return status;
+       }
+
+       status = evlog_push_record_tdb(mem_ctx, tdb, t, record_number);
+       talloc_free(t);
+
+       return status;
+}
+
+/********************************************************************
+ ********************************************************************/
+
+NTSTATUS evlog_evt_entry_to_tdb_entry(TALLOC_CTX *mem_ctx,
+                                     const struct EVENTLOGRECORD *e,
+                                     struct eventlog_Record_tdb *t)
+{
+       uint32_t i;
+
+       ZERO_STRUCTP(t);
+
+       t->size                         = e->Length;
+       t->reserved                     = e->Reserved;
+       t->record_number                = e->RecordNumber;
+       t->time_generated               = e->TimeGenerated;
+       t->time_written                 = e->TimeWritten;
+       t->event_id                     = e->EventID;
+       t->event_type                   = e->EventType;
+       t->num_of_strings               = e->NumStrings;
+       t->event_category               = e->EventCategory;
+       t->reserved_flags               = e->ReservedFlags;
+       t->closing_record_number        = e->ClosingRecordNumber;
+
+       t->stringoffset                 = e->StringOffset;
+       t->sid_length                   = e->UserSidLength;
+       t->sid_offset                   = e->UserSidOffset;
+       t->data_length                  = e->DataLength;
+       t->data_offset                  = e->DataOffset;
+
+       t->source_name_len              = 2 * strlen_m_term(e->SourceName);
+       t->source_name                  = talloc_strdup(mem_ctx, e->SourceName);
+       NT_STATUS_HAVE_NO_MEMORY(t->source_name);
+
+       t->computer_name_len            = 2 * strlen_m_term(e->Computername);
+       t->computer_name                = talloc_strdup(mem_ctx, e->Computername);
+       NT_STATUS_HAVE_NO_MEMORY(t->computer_name);
+
+       /* t->sid_padding; */
+       if (e->UserSidLength > 0) {
+               const char *sid_str = NULL;
+               smb_ucs2_t *dummy = NULL;
+               sid_str = sid_string_talloc(mem_ctx, &e->UserSid);
+               t->sid_length = rpcstr_push_talloc(mem_ctx, &dummy, sid_str);
+               if (t->sid_length == -1) {
+                       return NT_STATUS_NO_MEMORY;
+               }
+               t->sid = data_blob_talloc(mem_ctx, (uint8_t *)dummy, t->sid_length);
+               NT_STATUS_HAVE_NO_MEMORY(t->sid.data);
+       }
+
+       t->strings                      = talloc_array(mem_ctx, const char *, e->NumStrings);
+       for (i=0; i < e->NumStrings; i++) {
+               t->strings[i]           = talloc_strdup(t->strings, e->Strings[i]);
+               NT_STATUS_HAVE_NO_MEMORY(t->strings[i]);
+       }
+
+       t->strings_len                  = 2 * ndr_size_string_array(t->strings, t->num_of_strings, LIBNDR_FLAG_STR_NULLTERM);
+       t->data                         = data_blob_talloc(mem_ctx, e->Data, e->DataLength);
+       /* t->padding                   = r->Pad; */
+
+       return NT_STATUS_OK;
+}
+
+/********************************************************************
+ ********************************************************************/
+
+NTSTATUS evlog_tdb_entry_to_evt_entry(TALLOC_CTX *mem_ctx,
+                                     const struct eventlog_Record_tdb *t,
+                                     struct EVENTLOGRECORD *e)
+{
+       uint32_t i;
+
+       ZERO_STRUCTP(e);
+
+       e->Length               = t->size;
+       e->Reserved             = t->reserved;
+       e->RecordNumber         = t->record_number;
+       e->TimeGenerated        = t->time_generated;
+       e->TimeWritten          = t->time_written;
+       e->EventID              = t->event_id;
+       e->EventType            = t->event_type;
+       e->NumStrings           = t->num_of_strings;
+       e->EventCategory        = t->event_category;
+       e->ReservedFlags        = t->reserved_flags;
+       e->ClosingRecordNumber  = t->closing_record_number;
+
+       e->StringOffset         = t->stringoffset;
+       e->UserSidLength        = t->sid_length;
+       e->UserSidOffset        = t->sid_offset;
+       e->DataLength           = t->data_length;
+       e->DataOffset           = t->data_offset;
+
+       e->SourceName           = talloc_strdup(mem_ctx, t->source_name);
+       NT_STATUS_HAVE_NO_MEMORY(e->SourceName);
+
+       e->Computername         = talloc_strdup(mem_ctx, t->computer_name);
+       NT_STATUS_HAVE_NO_MEMORY(e->Computername);
+
+       if (t->sid_length > 0) {
+               const char *sid_str = NULL;
+               size_t len;
+               if (!convert_string_talloc(mem_ctx, CH_UTF16, CH_UNIX,
+                                          t->sid.data, t->sid.length,
+                                          &sid_str, &len, false)) {
+                       return NT_STATUS_INVALID_SID;
+               }
+               if (len > 0) {
+                       e->UserSid = *string_sid_talloc(mem_ctx, sid_str);
+               }
+       }
+
+       e->Strings              = talloc_array(mem_ctx, const char *, t->num_of_strings);
+       for (i=0; i < t->num_of_strings; i++) {
+               e->Strings[i] = talloc_strdup(e->Strings, t->strings[i]);
+               NT_STATUS_HAVE_NO_MEMORY(e->Strings[i]);
+       }
+
+       e->Data                 = (uint8_t *)talloc_memdup(mem_ctx, t->data.data, t->data_length);
+       e->Pad                  = talloc_strdup(mem_ctx, "");
+       NT_STATUS_HAVE_NO_MEMORY(e->Pad);
+
+       e->Length2              = t->size;
+
+       return NT_STATUS_OK;
 }