s3-auth remove sanitized_username from auth_serversupplied_info
[kai/samba-autobuild/.git] / source3 / auth / auth_util.c
index 1839f3d422ca6391aa8cbfee9e8d2703057b5194..b8cc871b62e8fc9917c9ba9718ee96bdd1be4f5e 100644 (file)
@@ -145,7 +145,7 @@ NTSTATUS make_user_info_map(struct auth_usersupplied_info **user_info,
                              plaintext, password_state);
        if (NT_STATUS_IS_OK(result)) {
                /* We have tried mapping */
-               (*user_info)->mapped_state = True;
+               (*user_info)->mapped_state = true;
                /* did we actually map the user to a different name? */
                (*user_info)->was_mapped = was_mapped;
        }
@@ -185,7 +185,7 @@ bool make_user_info_netlogon_network(struct auth_usersupplied_info **user_info,
        if (NT_STATUS_IS_OK(status)) {
                (*user_info)->logon_parameters = logon_parameters;
        }
-       ret = NT_STATUS_IS_OK(status) ? True : False;
+       ret = NT_STATUS_IS_OK(status) ? true : false;
 
        data_blob_free(&lm_blob);
        data_blob_free(&nt_blob);
@@ -288,7 +288,7 @@ bool make_user_info_netlogon_interactive(struct auth_usersupplied_info **user_in
                        (*user_info)->logon_parameters = logon_parameters;
                }
 
-               ret = NT_STATUS_IS_OK(nt_status) ? True : False;
+               ret = NT_STATUS_IS_OK(nt_status) ? true : false;
                data_blob_free(&local_lm_blob);
                data_blob_free(&local_nt_blob);
                return ret;
@@ -344,7 +344,7 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
                                                   (const char *)plaintext_password.data,
                                                   plaintext_password.length);
        if (!plaintext_password_string) {
-               return False;
+               return false;
        }
 
        ret = make_user_info_map(
@@ -363,7 +363,7 @@ bool make_user_info_for_reply(struct auth_usersupplied_info **user_info,
        }
 
        data_blob_free(&local_lm_blob);
-       return NT_STATUS_IS_OK(ret) ? True : False;
+       return NT_STATUS_IS_OK(ret) ? true : false;
 }
 
 /****************************************************************************
@@ -387,7 +387,7 @@ NTSTATUS make_user_info_for_reply_enc(struct auth_usersupplied_info **user_info,
 }
 
 /****************************************************************************
- Create a guest user_info blob, for anonymous authenticaion.
+ Create a guest user_info blob, for anonymous authentication.
 ****************************************************************************/
 
 bool make_user_info_guest(const struct tsocket_address *remote_address,
@@ -405,7 +405,7 @@ bool make_user_info_guest(const struct tsocket_address *remote_address,
                                   NULL,
                                   AUTH_PASSWORD_RESPONSE);
 
-       return NT_STATUS_IS_OK(nt_status) ? True : False;
+       return NT_STATUS_IS_OK(nt_status) ? true : false;
 }
 
 static NTSTATUS log_nt_token(struct security_token *token)
@@ -457,16 +457,16 @@ static NTSTATUS log_nt_token(struct security_token *token)
 NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
                            const struct auth_serversupplied_info *server_info,
                            DATA_BLOB *session_key,
-                           struct auth3_session_info **session_info_out)
+                           const char *smb_username, /* for ->sanitized_username, for %U subs */
+                           struct auth_session_info **session_info_out)
 {
        struct security_token *t;
        NTSTATUS status;
        size_t i;
        struct dom_sid tmp_sid;
-       struct auth3_session_info *session_info;
+       struct auth_session_info *session_info;
        struct wbcUnixId *ids;
-       struct auth_user_info_dc *user_info_dc;
-       union netr_Validation val;
+       fstring tmp;
 
        /* Ensure we can't possible take a code path leading to a
         * null defref. */
@@ -474,7 +474,7 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
                return NT_STATUS_LOGON_FAILURE;
        }
 
-       session_info = make_auth3_session_info(mem_ctx);
+       session_info = talloc_zero(mem_ctx, struct auth_session_info);
        if (!session_info) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -500,13 +500,11 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_MEMORY;
        }
 
-       session_info->unix_info->sanitized_username = talloc_strdup(session_info, server_info->sanitized_username);
-       if (!session_info->unix_info->sanitized_username) {
-               TALLOC_FREE(session_info);
-               return NT_STATUS_NO_MEMORY;
-       }
+       /* This is a potentially untrusted username for use in %U */
+       alpha_strcpy(tmp, smb_username, ". _-$", sizeof(tmp));
+       session_info->unix_info->sanitized_username =
+                               talloc_strdup(session_info->unix_info, tmp);
 
-       session_info->unix_info->guest = server_info->guest;
        session_info->unix_info->system = server_info->system;
 
        if (session_key) {
@@ -547,22 +545,16 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
                return NT_STATUS_OK;
        }
 
-       val.sam3 = server_info->info3;
-
-       /* Convert into something we can build a struct
-        * auth_session_info from.  Most of the work here
-        * will be to convert the SIDS, which we will then ignore, but
-        * this is the easier way to handle it */
-       status = make_user_info_dc_netlogon_validation(talloc_tos(), "", 3, &val, &user_info_dc);
+       /* We need to populate session_info->info with the information found in server_info->info3 */
+       status = make_user_info_SamBaseInfo(session_info, "", &server_info->info3->base,
+                                           server_info->guest == false,
+                                           &session_info->info);
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(0, ("conversion of info3 into user_info_dc failed!\n"));
+               DEBUG(0, ("conversion of info3 into auth_user_info failed!\n"));
                TALLOC_FREE(session_info);
                return status;
        }
 
-       session_info->info = talloc_move(session_info, &user_info_dc->info);
-       talloc_free(user_info_dc);
-
        /*
         * If winbind is not around, we can not make much use of the SIDs the
         * domain controller provided us with. Likewise if the user name was
@@ -571,14 +563,17 @@ NTSTATUS create_local_token(TALLOC_CTX *mem_ctx,
 
        if (((lp_server_role() == ROLE_DOMAIN_MEMBER) && !winbind_ping()) ||
            (server_info->nss_token)) {
+               char *found_username = NULL;
                status = create_token_from_username(session_info,
                                                    server_info->unix_name,
                                                    server_info->guest,
                                                    &session_info->unix_token->uid,
                                                    &session_info->unix_token->gid,
-                                                   &session_info->unix_info->unix_name,
+                                                   &found_username,
                                                    &session_info->security_token);
-
+               if (NT_STATUS_IS_OK(status)) {
+                       session_info->unix_info->unix_name = found_username;
+               }
        } else {
                status = create_local_nt_token_from_info3(session_info,
                                                          server_info->guest,
@@ -758,10 +753,8 @@ NTSTATUS make_server_info_pw(struct auth_serversupplied_info **server_info,
        }
 
        result->unix_name = talloc_strdup(result, unix_username);
-       result->sanitized_username = sanitize_username(result, unix_username);
 
-       if ((result->unix_name == NULL)
-           || (result->sanitized_username == NULL)) {
+       if (result->unix_name == NULL) {
                TALLOC_FREE(result);
                return NT_STATUS_NO_MEMORY;
        }
@@ -789,7 +782,7 @@ static NTSTATUS get_guest_info3(TALLOC_CTX *mem_ctx,
                return NT_STATUS_NO_SUCH_USER;
        }
 
-       /* Set acount name */
+       /* Set account name */
        tmp = talloc_strdup(mem_ctx, pwd->pw_name);
        if (tmp == NULL) {
                return NT_STATUS_NO_MEMORY;
@@ -817,6 +810,9 @@ static NTSTATUS get_guest_info3(TALLOC_CTX *mem_ctx,
        /* Primary gid */
        info3->base.primary_gid = BUILTIN_RID_GUESTS;
 
+       /* Set as guest */
+       info3->base.user_flags = NETLOGON_GUEST;
+
        TALLOC_FREE(pwd);
        return NT_STATUS_OK;
 }
@@ -828,11 +824,11 @@ static NTSTATUS get_guest_info3(TALLOC_CTX *mem_ctx,
 
  The resulting structure is a 'session_info' because
  create_local_token() has already been called on it.  This is quite
- nasty, as the auth subsystem isn't expect this, but the behaviour is
+ nasty, as the auth subsystem isn't expect this, but the behavior is
  left as-is for now.
 ***************************************************************************/
 
-static NTSTATUS make_new_session_info_guest(struct auth3_session_info **session_info, struct auth_serversupplied_info **server_info)
+static NTSTATUS make_new_session_info_guest(struct auth_session_info **session_info, struct auth_serversupplied_info **server_info)
 {
        static const char zeros[16] = {0};
        const char *guest_account = lp_guestaccount();
@@ -840,7 +836,6 @@ static NTSTATUS make_new_session_info_guest(struct auth3_session_info **session_
        struct netr_SamInfo3 info3;
        TALLOC_CTX *tmp_ctx;
        NTSTATUS status;
-       fstring tmp;
 
        tmp_ctx = talloc_stackframe();
        if (tmp_ctx == NULL) {
@@ -867,12 +862,14 @@ static NTSTATUS make_new_session_info_guest(struct auth3_session_info **session_
                goto done;
        }
 
-       (*server_info)->guest = True;
+       (*server_info)->guest = true;
 
        /* This should not be done here (we should produce a server
         * info, and later construct a session info from it), but for
-        * now this does not change the previous behaviours */
-       status = create_local_token(tmp_ctx, *server_info, NULL, session_info);
+        * now this does not change the previous behavior */
+       status = create_local_token(tmp_ctx, *server_info, NULL,
+                                   (*server_info)->info3->base.account_name.string,
+                                   session_info);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(0, ("create_local_token failed: %s\n",
                          nt_errstr(status)));
@@ -885,10 +882,6 @@ static NTSTATUS make_new_session_info_guest(struct auth3_session_info **session_
           all zeros! */
        (*session_info)->session_key = data_blob(zeros, sizeof(zeros));
 
-       alpha_strcpy(tmp, (*server_info)->info3->base.account_name.string,
-                    ". _-$", sizeof(tmp));
-       (*session_info)->unix_info->sanitized_username = talloc_strdup(*session_info, tmp);
-
        status = NT_STATUS_OK;
 done:
        TALLOC_FREE(tmp_ctx);
@@ -901,7 +894,7 @@ done:
 ***************************************************************************/
 
 static NTSTATUS make_new_session_info_system(TALLOC_CTX *mem_ctx,
-                                           struct auth3_session_info **session_info)
+                                           struct auth_session_info **session_info)
 {
        struct passwd *pwd;
        NTSTATUS status;
@@ -935,7 +928,7 @@ static NTSTATUS make_new_session_info_system(TALLOC_CTX *mem_ctx,
 }
 
 /****************************************************************************
-  Fake a auth3_session_info just from a username (as a
+  Fake a auth_session_info just from a username (as a
   session_info structure, with create_local_token() already called on
   it.
 ****************************************************************************/
@@ -943,7 +936,7 @@ static NTSTATUS make_new_session_info_system(TALLOC_CTX *mem_ctx,
 NTSTATUS make_session_info_from_username(TALLOC_CTX *mem_ctx,
                                         const char *username,
                                         bool is_guest,
-                                        struct auth3_session_info **session_info)
+                                        struct auth_session_info **session_info)
 {
        struct auth_serversupplied_info *result;
        struct passwd *pwd;
@@ -956,9 +949,8 @@ NTSTATUS make_session_info_from_username(TALLOC_CTX *mem_ctx,
 
        status = make_server_info_pw(&result, pwd->pw_name, pwd);
 
-       TALLOC_FREE(pwd);
-
        if (!NT_STATUS_IS_OK(status)) {
+               TALLOC_FREE(pwd);
                return status;
        }
 
@@ -966,7 +958,8 @@ NTSTATUS make_session_info_from_username(TALLOC_CTX *mem_ctx,
        result->guest = is_guest;
 
        /* Now turn the server_info into a session_info with the full token etc */
-       status = create_local_token(mem_ctx, result, NULL, session_info);
+       status = create_local_token(mem_ctx, result, NULL, pwd->pw_name, session_info);
+       TALLOC_FREE(pwd);
        talloc_free(result);
        return status;
 }
@@ -985,7 +978,7 @@ NTSTATUS make_session_info_from_username(TALLOC_CTX *mem_ctx,
  * - The 'server_info' parameter allows the missing 'info3' to be copied across.
  */
 static struct auth_serversupplied_info *copy_session_info_serverinfo_guest(TALLOC_CTX *mem_ctx,
-                                                                          const struct auth3_session_info *src,
+                                                                          const struct auth_session_info *src,
                                                                           struct auth_serversupplied_info *server_info)
 {
        struct auth_serversupplied_info *dst;
@@ -998,12 +991,12 @@ static struct auth_serversupplied_info *copy_session_info_serverinfo_guest(TALLO
        /* This element must be provided to convert back to an auth_serversupplied_info */
        SMB_ASSERT(src->unix_info);
 
-       dst->guest = src->unix_info->guest;
-       dst->system = src->unix_info->system;
+       dst->guest = true;
+       dst->system = false;
 
        /* This element must be provided to convert back to an
-        * auth_serversupplied_info.  This needs to be from hte
-        * auth3_session_info because the group values in particular
+        * auth_serversupplied_info.  This needs to be from the
+        * auth_session_info because the group values in particular
         * may change during create_local_token() processing */
        SMB_ASSERT(src->unix_token);
        dst->utok.uid = src->unix_token->uid;
@@ -1048,32 +1041,26 @@ static struct auth_serversupplied_info *copy_session_info_serverinfo_guest(TALLO
                return NULL;
        }
 
-       dst->sanitized_username = talloc_strdup(dst, src->unix_info->sanitized_username);
-       if (!dst->sanitized_username) {
-               TALLOC_FREE(dst);
-               return NULL;
-       }
-
        return dst;
 }
 
-struct auth3_session_info *copy_session_info(TALLOC_CTX *mem_ctx,
-                                            const struct auth3_session_info *src)
+struct auth_session_info *copy_session_info(TALLOC_CTX *mem_ctx,
+                                            const struct auth_session_info *src)
 {
-       struct auth3_session_info *dst;
+       struct auth_session_info *dst;
        DATA_BLOB blob;
        enum ndr_err_code ndr_err;
 
        ndr_err = ndr_push_struct_blob(
                &blob, talloc_tos(), src,
-               (ndr_push_flags_fn_t)ndr_push_auth3_session_info);
+               (ndr_push_flags_fn_t)ndr_push_auth_session_info);
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               DEBUG(0, ("copy_session_info(): ndr_push_auth3_session_info failed: "
+               DEBUG(0, ("copy_session_info(): ndr_push_auth_session_info failed: "
                           "%s\n", ndr_errstr(ndr_err)));
                return NULL;
        }
 
-       dst = talloc(mem_ctx, struct auth3_session_info);
+       dst = talloc(mem_ctx, struct auth_session_info);
        if (dst == NULL) {
                DEBUG(0, ("talloc failed\n"));
                TALLOC_FREE(blob.data);
@@ -1082,11 +1069,11 @@ struct auth3_session_info *copy_session_info(TALLOC_CTX *mem_ctx,
 
        ndr_err = ndr_pull_struct_blob(
                &blob, dst, dst,
-               (ndr_pull_flags_fn_t)ndr_pull_auth3_session_info);
+               (ndr_pull_flags_fn_t)ndr_pull_auth_session_info);
        TALLOC_FREE(blob.data);
 
        if (!NDR_ERR_CODE_IS_SUCCESS(ndr_err)) {
-               DEBUG(0, ("copy_session_info(): ndr_pull_auth3_session_info failed: "
+               DEBUG(0, ("copy_session_info(): ndr_pull_auth_session_info failed: "
                           "%s\n", ndr_errstr(ndr_err)));
                TALLOC_FREE(dst);
                return NULL;
@@ -1100,7 +1087,7 @@ struct auth3_session_info *copy_session_info(TALLOC_CTX *mem_ctx,
  * SMB level session key with SystemLibraryDTC
  */
 
-bool session_info_set_session_key(struct auth3_session_info *info,
+bool session_info_set_session_key(struct auth_session_info *info,
                                 DATA_BLOB session_key)
 {
        TALLOC_FREE(info->session_key.data);
@@ -1111,14 +1098,14 @@ bool session_info_set_session_key(struct auth3_session_info *info,
        return (info->session_key.data != NULL);
 }
 
-static struct auth3_session_info *guest_info = NULL;
+static struct auth_session_info *guest_info = NULL;
 
 static struct auth_serversupplied_info *guest_server_info = NULL;
 
 bool init_guest_info(void)
 {
        if (guest_info != NULL)
-               return True;
+               return true;
 
        return NT_STATUS_IS_OK(make_new_session_info_guest(&guest_info, &guest_server_info));
 }
@@ -1128,20 +1115,20 @@ NTSTATUS make_server_info_guest(TALLOC_CTX *mem_ctx,
 {
        /* This is trickier than it would appear to need to be because
         * we are trying to avoid certain costly operations when the
-        * structure is converted to a 'auth3_session_info' again in
+        * structure is converted to a 'auth_session_info' again in
         * create_local_token() */
        *server_info = copy_session_info_serverinfo_guest(mem_ctx, guest_info, guest_server_info);
        return (*server_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 }
 
 NTSTATUS make_session_info_guest(TALLOC_CTX *mem_ctx,
-                               struct auth3_session_info **session_info)
+                               struct auth_session_info **session_info)
 {
        *session_info = copy_session_info(mem_ctx, guest_info);
        return (*session_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 }
 
-static struct auth3_session_info *system_info = NULL;
+static struct auth_session_info *system_info = NULL;
 
 NTSTATUS init_system_info(void)
 {
@@ -1152,14 +1139,14 @@ NTSTATUS init_system_info(void)
 }
 
 NTSTATUS make_session_info_system(TALLOC_CTX *mem_ctx,
-                               struct auth3_session_info **session_info)
+                               struct auth_session_info **session_info)
 {
        if (system_info == NULL) return NT_STATUS_UNSUCCESSFUL;
        *session_info = copy_session_info(mem_ctx, system_info);
        return (*session_info != NULL) ? NT_STATUS_OK : NT_STATUS_NO_MEMORY;
 }
 
-const struct auth3_session_info *get_session_info_system(void)
+const struct auth_session_info *get_session_info_system(void)
 {
     return system_info;
 }
@@ -1172,13 +1159,13 @@ bool copy_current_user(struct current_user *dst, struct current_user *src)
        groups = (gid_t *)memdup(src->ut.groups,
                                 sizeof(gid_t) * src->ut.ngroups);
        if ((src->ut.ngroups != 0) && (groups == NULL)) {
-               return False;
+               return false;
        }
 
        nt_token = dup_nt_token(NULL, src->nt_user_token);
        if (nt_token == NULL) {
                SAFE_FREE(groups);
-               return False;
+               return false;
        }
 
        dst->conn = src->conn;
@@ -1188,7 +1175,7 @@ bool copy_current_user(struct current_user *dst, struct current_user *src)
        dst->ut.ngroups = src->ut.ngroups;
        dst->ut.groups = groups;
        dst->nt_user_token = nt_token;
-       return True;
+       return true;
 }
 
 /***************************************************************************
@@ -1228,7 +1215,7 @@ static NTSTATUS check_account(TALLOC_CTX *mem_ctx, const char *domain,
                return NT_STATUS_NO_MEMORY;
        }
 
-       passwd = smb_getpwnam(mem_ctx, dom_user, &real_username, True );
+       passwd = smb_getpwnam(mem_ctx, dom_user, &real_username, true );
        if (!passwd) {
                DEBUG(3, ("Failed to find authenticated user %s via "
                          "getpwnam(), denying access.\n", dom_user));
@@ -1241,7 +1228,7 @@ static NTSTATUS check_account(TALLOC_CTX *mem_ctx, const char *domain,
 
        *pwd = passwd;
 
-       /* This is pointless -- there is no suport for differing 
+       /* This is pointless -- there is no support for differing
           unix and windows names.  Make sure to always store the 
           one we actually looked up and succeeded. Have I mentioned
           why I hate the 'winbind use default domain' parameter?   
@@ -1418,13 +1405,6 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
 
        result->unix_name = talloc_strdup(result, found_username);
 
-       result->sanitized_username = sanitize_username(result,
-                                                      result->unix_name);
-       if (result->sanitized_username == NULL) {
-               TALLOC_FREE(result);
-               return NT_STATUS_NO_MEMORY;
-       }
-
        /* copy in the info3 */
        result->info3 = i3 = copy_netr_SamInfo3(result, info3);
        if (result->info3 == NULL) {
@@ -1437,7 +1417,7 @@ NTSTATUS make_server_info_info3(TALLOC_CTX *mem_ctx,
        result->utok.gid = pwd->pw_gid;
 
        /* We can't just trust that the primary group sid sent us is something
-        * we can really use. Obtain the useable sid, and store the original
+        * we can really use. Obtain the usable sid, and store the original
         * one as an additional group if it had to be replaced */
        nt_status = get_primary_group_sid(mem_ctx, found_username,
                                          &pwd, &group_sid);
@@ -1528,7 +1508,7 @@ bool is_trusted_domain(const char* dom_name)
        /* no trusted domains for a standalone server */
 
        if ( lp_server_role() == ROLE_STANDALONE )
-               return False;
+               return false;
 
        if (dom_name == NULL || dom_name[0] == '\0') {
                return false;
@@ -1547,7 +1527,7 @@ bool is_trusted_domain(const char* dom_name)
                ret = pdb_get_trusteddom_pw(dom_name, NULL, NULL, NULL);
                unbecome_root();
                if (ret)
-                       return True;
+                       return true;
        }
        else {
                wbcErr result;
@@ -1557,12 +1537,12 @@ bool is_trusted_domain(const char* dom_name)
                result = wb_is_trusted_domain(dom_name);
 
                if (result == WBC_ERR_SUCCESS) {
-                       return True;
+                       return true;
                }
 
                if (result == WBC_ERR_DOMAIN_NOT_FOUND) {
                        /* winbind could not find the domain */
-                       return False;
+                       return false;
                }
 
                /* The only other possible result is that winbind is not up
@@ -1577,9 +1557,39 @@ bool is_trusted_domain(const char* dom_name)
         * domains (like a domain member would use  */
 
        if ( trustdom_cache_fetch(dom_name, &trustdom_sid) ) {
-               return True;
+               return true;
        }
 
-       return False;
+       return false;
 }
 
+
+
+/*
+  on a logon error possibly map the error to success if "map to guest"
+  is set approriately
+*/
+NTSTATUS do_map_to_guest_server_info(NTSTATUS status,
+                                    struct auth_serversupplied_info **server_info,
+                                    const char *user, const char *domain)
+{
+       user = user ? user : "";
+       domain = domain ? domain : "";
+
+       if (NT_STATUS_EQUAL(status, NT_STATUS_NO_SUCH_USER)) {
+               if ((lp_map_to_guest() == MAP_TO_GUEST_ON_BAD_USER) ||
+                   (lp_map_to_guest() == MAP_TO_GUEST_ON_BAD_PASSWORD)) {
+                       DEBUG(3,("No such user %s [%s] - using guest account\n",
+                                user, domain));
+                       status = make_server_info_guest(NULL, server_info);
+               }
+       } else if (NT_STATUS_EQUAL(status, NT_STATUS_WRONG_PASSWORD)) {
+               if (lp_map_to_guest() == MAP_TO_GUEST_ON_BAD_PASSWORD) {
+                       DEBUG(3,("Registered username %s for guest access\n",
+                               user));
+                       status = make_server_info_guest(NULL, server_info);
+               }
+       }
+
+       return status;
+}