s4:torture/rpc/session_key.c: add explicit check for NTSTATUS r.out.result
[kai/samba-autobuild/.git] / source4 / torture / rpc / session_key.c
1 /* 
2    Unix SMB/CIFS implementation.
3    test suite for lsa rpc operations
4
5    Copyright (C) Andrew Tridgell 2003
6    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2004-2005
7    
8    This program is free software; you can redistribute it and/or modify
9    it under the terms of the GNU General Public License as published by
10    the Free Software Foundation; either version 3 of the License, or
11    (at your option) any later version.
12    
13    This program is distributed in the hope that it will be useful,
14    but WITHOUT ANY WARRANTY; without even the implied warranty of
15    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
16    GNU General Public License for more details.
17    
18    You should have received a copy of the GNU General Public License
19    along with this program.  If not, see <http://www.gnu.org/licenses/>.
20 */
21
22 #include "includes.h"
23 #include "librpc/gen_ndr/ndr_lsa_c.h"
24
25 #include "libcli/auth/libcli_auth.h"
26 #include "torture/rpc/rpc.h"
27 #include "lib/cmdline/popt_common.h"
28 #include "param/param.h"
29
30 static void init_lsa_String(struct lsa_String *name, const char *s)
31 {
32         name->string = s;
33 }
34
35 static bool test_CreateSecret_basic(struct dcerpc_pipe *p, 
36                                     struct torture_context *tctx,
37                                     struct policy_handle *handle)
38 {
39         NTSTATUS status;
40         struct lsa_CreateSecret r;
41         struct lsa_SetSecret r3;
42         struct lsa_QuerySecret r4;
43         struct policy_handle sec_handle;
44         struct lsa_DeleteObject d;
45         struct lsa_DATA_BUF buf1;
46         struct lsa_DATA_BUF_PTR bufp1;
47         DATA_BLOB enc_key;
48         DATA_BLOB session_key;
49         NTTIME old_mtime, new_mtime;
50         DATA_BLOB blob1, blob2;
51         const char *secret1 = "abcdef12345699qwerty";
52         char *secret2;
53         char *secname;
54         struct dcerpc_binding_handle *b = p->binding_handle;
55
56         secname = talloc_asprintf(tctx, "torturesecret-%u", (unsigned int)random());
57
58         torture_comment(tctx, "Testing CreateSecret of %s\n", secname);
59                 
60         init_lsa_String(&r.in.name, secname);
61         
62         r.in.handle = handle;
63         r.in.access_mask = SEC_FLAG_MAXIMUM_ALLOWED;
64         r.out.sec_handle = &sec_handle;
65         
66         torture_assert_ntstatus_ok(tctx, dcerpc_lsa_CreateSecret_r(b, tctx, &r),
67                 "CreateSecret failed");
68         torture_assert_ntstatus_ok(tctx, r.out.result, "CreateSecret failed");
69         
70         status = dcerpc_fetch_session_key(p, &session_key);
71         torture_assert_ntstatus_ok(tctx, status, "dcerpc_fetch_session_key failed");
72         
73         enc_key = sess_encrypt_string(secret1, &session_key);
74         
75         r3.in.sec_handle = &sec_handle;
76         r3.in.new_val = &buf1;
77         r3.in.old_val = NULL;
78         r3.in.new_val->data = enc_key.data;
79         r3.in.new_val->length = enc_key.length;
80         r3.in.new_val->size = enc_key.length;
81         
82         torture_comment(tctx, "Testing SetSecret\n");
83         
84         torture_assert_ntstatus_ok(tctx, dcerpc_lsa_SetSecret_r(b, tctx, &r3),
85                 "SetSecret failed");
86         torture_assert_ntstatus_ok(tctx, r3.out.result, "SetSecret failed");
87                 
88         r3.in.sec_handle = &sec_handle;
89         r3.in.new_val = &buf1;
90         r3.in.old_val = NULL;
91         r3.in.new_val->data = enc_key.data;
92         r3.in.new_val->length = enc_key.length;
93         r3.in.new_val->size = enc_key.length;
94         
95         /* break the encrypted data */
96         enc_key.data[0]++;
97         
98         torture_comment(tctx, "Testing SetSecret with broken key\n");
99         
100         torture_assert_ntstatus_ok(tctx, dcerpc_lsa_SetSecret_r(b, tctx, &r3),
101                 "SetSecret failed");
102         torture_assert_ntstatus_equal(tctx, r3.out.result, NT_STATUS_UNKNOWN_REVISION,
103                 "SetSecret should have failed UNKNOWN_REVISION");
104         
105         data_blob_free(&enc_key);
106         
107         ZERO_STRUCT(new_mtime);
108         ZERO_STRUCT(old_mtime);
109         
110         /* fetch the secret back again */
111         r4.in.sec_handle = &sec_handle;
112         r4.in.new_val = &bufp1;
113         r4.in.new_mtime = &new_mtime;
114         r4.in.old_val = NULL;
115         r4.in.old_mtime = NULL;
116         
117         bufp1.buf = NULL;
118         
119         torture_comment(tctx, "Testing QuerySecret\n");
120         torture_assert_ntstatus_ok(tctx, dcerpc_lsa_QuerySecret_r(b, tctx, &r4),
121                 "QuerySecret failed");
122         torture_assert_ntstatus_ok(tctx, r4.out.result, "QuerySecret failed");
123         if (r4.out.new_val == NULL || r4.out.new_val->buf == NULL)
124                 torture_fail(tctx, "No secret buffer returned");
125         blob1.data = r4.out.new_val->buf->data;
126         blob1.length = r4.out.new_val->buf->size;
127         
128         blob2 = data_blob_talloc(tctx, NULL, blob1.length);
129         
130         secret2 = sess_decrypt_string(tctx, &blob1, &session_key);
131         
132         torture_assert_str_equal(tctx, secret1, secret2, "Returned secret invalid");
133
134         d.in.handle = &sec_handle;
135         d.out.handle = &sec_handle;
136         torture_assert_ntstatus_ok(tctx, dcerpc_lsa_DeleteObject_r(b, tctx, &d),
137                 "DeleteObject failed");
138         torture_assert_ntstatus_ok(tctx, d.out.result, "delete should have returned OKINVALID_HANDLE");
139         return true;
140 }
141
142 struct secret_settings {
143         uint32_t bindoptions;
144         bool keyexchange;
145         bool ntlm2;
146         bool lm_key;
147 };
148
149 static bool test_secrets(struct torture_context *torture, const void *_data)
150 {
151         struct dcerpc_pipe *p;
152         struct policy_handle *handle;
153         struct dcerpc_binding *binding;
154         const struct secret_settings *settings = 
155                 (const struct secret_settings *)_data;
156         NTSTATUS status;
157         struct dcerpc_binding_handle *b;
158
159         lp_set_cmdline(torture->lp_ctx, "ntlmssp client:keyexchange", settings->keyexchange?"True":"False");
160         lp_set_cmdline(torture->lp_ctx, "ntlmssp_client:ntlm2", settings->ntlm2?"True":"False");
161         lp_set_cmdline(torture->lp_ctx, "ntlmssp_client:lm_key", settings->lm_key?"True":"False");
162
163         torture_assert_ntstatus_ok(torture, torture_rpc_binding(torture, &binding), 
164                                    "Getting bindoptions");
165
166         binding->flags |= settings->bindoptions;
167
168         if (binding->flags & DCERPC_PUSH_BIGENDIAN) {
169                 if (torture_setting_bool(torture, "samba3", false)) {
170                         torture_skip(torture, "skipping bigendian test against samba3\n");
171                 }
172         }
173
174         status = dcerpc_pipe_connect_b(torture, &p, binding,
175                                        &ndr_table_lsarpc,
176                                        cmdline_credentials,
177                                        torture->ev,
178                                        torture->lp_ctx);
179
180         torture_assert_ntstatus_ok(torture, status, "connect");
181         b = p->binding_handle;
182
183         if (!test_lsa_OpenPolicy2(b, torture, &handle)) {
184                 talloc_free(p);
185                 return false;
186         }
187
188         torture_assert(torture, handle, "OpenPolicy2 failed.  This test cannot run against this server");
189         
190         if (!test_CreateSecret_basic(p, torture, handle)) {
191                 talloc_free(p);
192                 return false;
193         }
194
195         talloc_free(p);
196
197         return true;
198 }
199
200 static struct torture_tcase *add_test(struct torture_suite *suite, uint32_t bindoptions, 
201                                      bool keyexchange, bool ntlm2, bool lm_key)
202 {
203         char *name = NULL;
204         struct secret_settings *settings;
205
206         settings = talloc_zero(suite, struct secret_settings);
207         settings->bindoptions = bindoptions;
208
209         if (bindoptions == DCERPC_PUSH_BIGENDIAN)
210                 name = talloc_strdup(suite, "bigendian");
211         else if (bindoptions == DCERPC_SEAL)
212                 name = talloc_strdup(suite, "seal");
213         else if (bindoptions == 0) 
214                 name = talloc_strdup(suite, "none");
215         else
216                 name = talloc_strdup(suite, "unknown");
217
218         name = talloc_asprintf_append_buffer(name, " keyexchange:%s", keyexchange?"yes":"no");
219         settings->keyexchange = keyexchange;
220
221         name = talloc_asprintf_append_buffer(name, " ntlm2:%s", ntlm2?"yes":"no");
222         settings->ntlm2 = ntlm2;
223
224         name = talloc_asprintf_append_buffer(name, " lm_key:%s", lm_key?"yes":"no");
225         settings->lm_key = lm_key;
226
227         return torture_suite_add_simple_tcase_const(suite, name, test_secrets,
228                         settings);
229 }
230
231 static const bool bool_vals[] = { true, false };
232
233 /* TEST session key correctness by pushing and pulling secrets */
234 struct torture_suite *torture_rpc_lsa_secrets(TALLOC_CTX *mem_ctx)
235 {
236         struct torture_suite *suite = torture_suite_create(mem_ctx, "LSA-SECRETS");
237         int keyexchange, ntlm2, lm_key;
238
239         for (keyexchange = 0; keyexchange < ARRAY_SIZE(bool_vals); keyexchange++) {
240                 for (ntlm2 = 0; ntlm2 < ARRAY_SIZE(bool_vals); ntlm2++) {
241                         for (lm_key = 0; lm_key < ARRAY_SIZE(bool_vals); lm_key++) {
242                                 add_test(suite, DCERPC_PUSH_BIGENDIAN, bool_vals[keyexchange], bool_vals[ntlm2], 
243                                          bool_vals[lm_key]);
244                                 add_test(suite, DCERPC_SEAL, bool_vals[keyexchange], bool_vals[ntlm2], bool_vals[lm_key]);
245                                 add_test(suite, 0, bool_vals[keyexchange], bool_vals[ntlm2], bool_vals[lm_key]);
246                         }
247                 }
248         }
249
250         return suite;
251 }