12 years agor23185: Try to fix the IRIX build, also add the forgotten file_id.c in .26
Volker Lendecke [Tue, 29 May 2007 10:48:42 +0000 (10:48 +0000)]
r23185: Try to fix the IRIX build, also add the forgotten file_id.c in .26
(This used to be commit 5360e6405b170137e558fd0696ebd6030e0f5deb)

12 years agor23184: Checkin for Tridge: Add a speed test to tdbtool
Volker Lendecke [Tue, 29 May 2007 10:15:01 +0000 (10:15 +0000)]
r23184: Checkin for Tridge: Add a speed test to tdbtool
(This used to be commit a343521439f68c76c9939f04eea96c6e6d6b01e4)

12 years agor23183: Check in a change made by Tridge:
Volker Lendecke [Tue, 29 May 2007 09:30:34 +0000 (09:30 +0000)]
r23183: Check in a change made by Tridge:

This replaces the internal explicit dev/ino file id representation by a
"struct file_id". This is necessary as cluster file systems and NFS
don't necessarily assign the same device number to the shared file
system. With this structure in place we can now easily add different
schemes to map a file to a unique 64-bit device node.

Jeremy, you might note that I did not change the external interface of

(This used to be commit 9b10dbbd5de8813fc15ebbb6be9b18010ffe8139)

12 years agor23173: Convert sessionid.tdb to ctdb. The 3.0.26 patch is a bit larger because
Volker Lendecke [Mon, 28 May 2007 13:33:54 +0000 (13:33 +0000)]
r23173: Convert sessionid.tdb to ctdb. The 3.0.26 patch is a bit larger because
it brings across the tdb-based list_sessions
(This used to be commit 0153386c1a3625b2f699863991893f399c40af48)

12 years agor23172: Change shutdown_other_smbds to use connections_traverse instead of
Volker Lendecke [Mon, 28 May 2007 12:39:39 +0000 (12:39 +0000)]
r23172: Change shutdown_other_smbds to use connections_traverse instead of
(This used to be commit ccb5eb245e962b0264b337c2d0275c22e2a36830)

12 years agor23171: Convert connections.tdb to dbwrap
Volker Lendecke [Mon, 28 May 2007 11:38:42 +0000 (11:38 +0000)]
r23171: Convert connections.tdb to dbwrap
(This used to be commit 80a1f43825063bbbda896175d99700ede5a4757a)

12 years agor23170: Add map_nt_error_from_tdb()
Volker Lendecke [Mon, 28 May 2007 11:08:58 +0000 (11:08 +0000)]
r23170: Add map_nt_error_from_tdb()
(This used to be commit 02beae81c8ecef7cfe300a29852d74813c9409bf)

12 years agor23169: Merge 535 of Tridge's bzr tree:
Volker Lendecke [Sun, 27 May 2007 17:12:08 +0000 (17:12 +0000)]
r23169: Merge 535 of Tridge's bzr tree:

  store the right data after cleaning lock records. This fixes
  RAW-BENCH-LOCK after a recovery on a cluster
(This used to be commit 3da3086dbf594fbdc4cfabf78f8d3ea1df4dc8ce)

12 years agor23168: Move the lp_max_connections() into service.c.
Volker Lendecke [Sun, 27 May 2007 16:34:49 +0000 (16:34 +0000)]
r23168: Move the lp_max_connections() into service.c.
(This used to be commit 4afe37d431b6eb475769a2057025da9aa8d1bb14)

12 years agor23167: Remove an unused parameter
Volker Lendecke [Sun, 27 May 2007 16:22:12 +0000 (16:22 +0000)]
r23167: Remove an unused parameter
(This used to be commit 3452a870d58cdddf03ddf6ee698bca8416e05cbf)

12 years agor23166: Bring samba.org's iniparser copy in sync with the upstream version 2.17.
Lars Müller [Sun, 27 May 2007 15:58:19 +0000 (15:58 +0000)]
r23166: Bring samba.org's iniparser copy in sync with the upstream version 2.17.
(This used to be commit 3fa98245d98436a0f042ffca9bf102e9f920bace)

12 years agor23165: Convert brlock.tdb to dbwrap
Volker Lendecke [Sun, 27 May 2007 10:35:14 +0000 (10:35 +0000)]
r23165: Convert brlock.tdb to dbwrap
(This used to be commit 84f9885cf8cc57dcf3c2738d6b245de314890a41)

12 years agor23164: Minor cosmetic checkin
Volker Lendecke [Sun, 27 May 2007 10:25:23 +0000 (10:25 +0000)]
r23164: Minor cosmetic checkin
(This used to be commit 8de1ac9fadb1b0dcac28eef32f7826e9e3a7eca4)

12 years agor23163: Convert locking.tdb to dbwrap
Volker Lendecke [Sun, 27 May 2007 09:57:05 +0000 (09:57 +0000)]
r23163: Convert locking.tdb to dbwrap
(This used to be commit afe90224bf151acf6c7be8974408f79cfd459dbf)

12 years agor23162: Make use of messaging_send_buf
Volker Lendecke [Sun, 27 May 2007 09:29:26 +0000 (09:29 +0000)]
r23162: Make use of messaging_send_buf
(This used to be commit 3f8186fe85a897b104cd825a005333259d6d008b)

12 years agor23161: Add TDB_VOLATILE as open_flag to activate the per-hashchain dead record
Volker Lendecke [Sun, 27 May 2007 09:22:11 +0000 (09:22 +0000)]
r23161: Add TDB_VOLATILE as open_flag to activate the per-hashchain dead record
(This used to be commit 945f73fa39ba6f2b637379ac20d52b4d0306d77f)

12 years agor23156: Install the smb_share_modes.h header file.
Lars Müller [Sat, 26 May 2007 13:33:56 +0000 (13:33 +0000)]
r23156: Install the smb_share_modes.h header file.
(This used to be commit e03a67ebc622aefb898b58aee55ac9ebadadd349)

12 years agor23155: Rename INSTALLPERMS to INSTALLPERMS_BIN to differenciate clearer from
Lars Müller [Sat, 26 May 2007 13:30:45 +0000 (13:30 +0000)]
r23155: Rename INSTALLPERMS to INSTALLPERMS_BIN to differenciate clearer from
(This used to be commit 7a9ea106ff7ce54029bcd604d7a89b7134c2b885)

12 years agor23154: Add INSTALLPERMS_DATA set to 0644 to install the header files with this
Lars Müller [Sat, 26 May 2007 13:24:56 +0000 (13:24 +0000)]
r23154: Add INSTALLPERMS_DATA set to 0644 to install the header files with this
permission set instead of 0755.
(This used to be commit 1db52993eda542757e80e1d7d2ce82a9c9abd93a)

12 years agor23151: Re-arrange the logic so it looks identical to the
Jeremy Allison [Sat, 26 May 2007 01:26:09 +0000 (01:26 +0000)]
r23151: Re-arrange the logic so it looks identical to the
"file existed" case above. This has no functional
change but is easier to see that it's doing the
same thing.
(This used to be commit 0a7d8362be8379b77e6afb803ab88d726ae7877d)

12 years agor23150: Fix Samba3 in the build farm again. In the case where the
Jeremy Allison [Sat, 26 May 2007 01:19:51 +0000 (01:19 +0000)]
r23150: Fix Samba3 in the build farm again. In the case where the
file was being created and we go into the race condition check,
we were testing for compatible open modes, but were not breaking
oplocks in the same way as if the file existed. This meant that
we weren't going into the code path that sets fsp->oplock = FAKE_LEVEL_II_OPLOCK
if the client didn't ask for an oplock on file create. We need
to do this as internally it's what Windows does.
(This used to be commit 9b9513856e9e9f84d5acd94e3e3d6e73358ee7dc)

12 years agor23148: Fix old old bug in cli_smbwrite() (not incrementing
Jeremy Allison [Fri, 25 May 2007 23:50:35 +0000 (23:50 +0000)]
r23148: Fix old old bug in cli_smbwrite() (not incrementing
data being sent). Patch from mnix@wanm.com.au.
(This used to be commit 2524d85465ba5406e684199c10f59e685ab860b5)

12 years agor23147: Patch #4566 from jacob berkman <jberkman@novell.com>. Pass password data...
Jeremy Allison [Fri, 25 May 2007 22:04:03 +0000 (22:04 +0000)]
r23147: Patch #4566 from jacob berkman <jberkman@novell.com>. Pass password data to krb5_prompter.
(This used to be commit 232fc5d69d44404df13f6516864352f9a5721552)

12 years agor23128: Fix typo.
Günther Deschner [Thu, 24 May 2007 23:17:24 +0000 (23:17 +0000)]
r23128: Fix typo.

(This used to be commit 52fdbbda53df79461322b9d21aba998f19181df8)

12 years agor23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx,
Günther Deschner [Thu, 24 May 2007 23:11:11 +0000 (23:11 +0000)]
r23127: Fill in some more netlogon dsgetdcname flavours (netr_DsRGetDCNameEx,
netr_DsRGetDCNameEx2) and add new ds request and reply flags, also add some
more WERROR codes.

(This used to be commit 37ae7f419702c563bcd0d9c27c02bde7efd34dd7)

12 years agor23122: Fix bug #4655. We marshall the enumdataex correctly,
Jeremy Allison [Thu, 24 May 2007 20:40:46 +0000 (20:40 +0000)]
r23122: Fix bug #4655. We marshall the enumdataex correctly,
but W2K3 doesn't follow our rules when sending data to
us. Ensure we look for the data at the correct offsets
when reading the data.
Too late for 3.0.25a - don't merge.
(This used to be commit a871191395eef6ed76f9e7666fd1c0fde3105984)

12 years agor23121: Fix Bug #2727 and let pam_smbpass at least link and dlopen correctly again.
Günther Deschner [Thu, 24 May 2007 20:26:07 +0000 (20:26 +0000)]
r23121: Fix Bug #2727 and let pam_smbpass at least link and dlopen correctly again.

Thanks to Bartlomiej Solarz-Niesluchowski <Bartlomiej.Solarz-Niesluchowski@wit.edu.pl>.

(This used to be commit ba956ab8e4097d46bbad12caf2fad6857f463618)

12 years agor23117: Factor out local messaging.
Volker Lendecke [Thu, 24 May 2007 14:47:24 +0000 (14:47 +0000)]
r23117: Factor out local messaging.

This removes message_block / message_unblock. I've talked to Jeremy and
Günther, giving them my reasons why I believe they have no effect.
Neither could come up with a counter-argument, so they go :-)
(This used to be commit a925e0991ffbaea4a533bab3a5d61e5d367d46c8)

12 years agor23116: Fix typo, found by Karolin Seeger
Volker Lendecke [Thu, 24 May 2007 13:49:10 +0000 (13:49 +0000)]
r23116: Fix typo, found by Karolin Seeger
(This used to be commit a7b9581a5c01b701129cdd5a7a330748f9e3859e)

12 years agor23112: Trim down the message.c API slightly: The messages_pending_for_pid is now
Volker Lendecke [Thu, 24 May 2007 11:09:37 +0000 (11:09 +0000)]
r23112: Trim down the message.c API slightly: The messages_pending_for_pid is now
replaced by MSG_FLAG_LOWPRIORITY or'ed into the msg_type. To enable this,
changed the msg_type definitions to hexadecimal.

This way we could theoretically add the MSG_FLAG_NODUPLICATES again, but I
would rather not do this, because that one is racy and can't be guaranteed at
(This used to be commit 3f5eb8a9600839a9f9c44c553f0bda6df22b30b0)

12 years agor23109: Redo the change from r22772 I accidentially undid in r23108.
Michael Adam [Thu, 24 May 2007 09:06:15 +0000 (09:06 +0000)]
r23109: Redo the change from r22772 I accidentially undid in r23108.

(This used to be commit 18a7e739ea5d19b2e220641e19662e2c263d281a)

12 years agor23108: Add defines of RTLD_NOW and RTLD_GLOBAL to replace.h.
Michael Adam [Thu, 24 May 2007 07:15:36 +0000 (07:15 +0000)]
r23108: Add defines of RTLD_NOW and RTLD_GLOBAL to replace.h.
Fixing build of ldb for instance on some systems without dlfcn.h.
(This used to be commit 5a06726e6873accd255d584e2c18e62dfcac108d)

12 years agor23107: Fix renames on file descriptors that are supposed to overwrite the
Jeremy Allison [Thu, 24 May 2007 01:57:02 +0000 (01:57 +0000)]
r23107: Fix renames on file descriptors that are supposed to overwrite the
target. Needs merging for 3.0.25a (sorry).
(This used to be commit a56bce3d44e89b4fd7806cc5b464c7481ec0197f)

12 years agor23106: Use lchown for symlinks.
Jeremy Allison [Thu, 24 May 2007 00:13:24 +0000 (00:13 +0000)]
r23106: Use lchown for symlinks.
(This used to be commit b98175440b2c235fe223b4375441f15ea027a5b2)

12 years agor23105: Add lchown to the vfs layer. We need this in the POSIX code.
Jeremy Allison [Wed, 23 May 2007 23:55:12 +0000 (23:55 +0000)]
r23105: Add lchown to the vfs layer. We need this in the POSIX code.
(This used to be commit 932523cbb508db869b726768e86bfa8e248f768b)

12 years agor23100: Implement the delete on close semantics I've just tested for
Jeremy Allison [Wed, 23 May 2007 21:32:10 +0000 (21:32 +0000)]
r23100: Implement the delete on close semantics I've just tested for
in Samba4 smbtorture. Fix rename on an open file handle.
Needed for 3.0.25a.
(This used to be commit a301467d5f645dada27093ddfd74890b88bb4ce8)

12 years agor23098: Fix the case of the #include statements so this module can be built on a
James Peach [Wed, 23 May 2007 20:48:53 +0000 (20:48 +0000)]
r23098: Fix the case of the #include statements so this module can be built on a
case-sensitive filesystem.
(This used to be commit 0fd0b57107fcdbf7eda85b3f3b969c5dc9eaadc5)

12 years agor23097: Add a new configure option to disable building SWAT (it is still built by
James Peach [Wed, 23 May 2007 20:46:07 +0000 (20:46 +0000)]
r23097: Add a new configure option to disable building SWAT (it is still built by
(This used to be commit 910d498a0e44d1c2b76ccddef0cf05e693cf580e)

12 years agor23096: Make the lock failure message prettier.
James Peach [Wed, 23 May 2007 20:38:14 +0000 (20:38 +0000)]
r23096: Make the lock failure message prettier.
(This used to be commit 853f41edb8b23d7fdfaba9c4bb37dc27af92a982)

12 years agor23095: Support systems that have their PAM headers in /usr/include/pam.
James Peach [Wed, 23 May 2007 20:31:28 +0000 (20:31 +0000)]
r23095: Support systems that have their PAM headers in /usr/include/pam.
(This used to be commit f1e8de4b576b3954d456cb64c02417908bab8da4)

12 years agor23094: Update the iconv detection to handle cross-compiles better. If we are
James Peach [Wed, 23 May 2007 19:57:13 +0000 (19:57 +0000)]
r23094: Update the iconv detection to handle cross-compiles better. If we are
cross-compiling, we accept the first iconv library that we find (with a
(This used to be commit 9417832155d634864f37d0fdb173ec607c154069)

12 years agor23093: Allow modules with the same name but different types.
James Peach [Wed, 23 May 2007 19:10:04 +0000 (19:10 +0000)]
r23093: Allow modules with the same name but different types.
(This used to be commit 190a69b1f9d7a0f858ed56c505c2d3c473273463)

12 years agor23091: Add rpccli_netlogon_sam_network_logon_ex, fix its parsing. This does not
Volker Lendecke [Wed, 23 May 2007 15:17:49 +0000 (15:17 +0000)]
r23091: Add rpccli_netlogon_sam_network_logon_ex, fix its parsing. This does not
use the credential chain and only works over netlogon, but it would
allow multiple outstanding auth requests for a single workstation
(This used to be commit 123290d0947191abca4a3b3d81718c823c1bc4a0)

12 years agor23088: Fix rename for cifsfs client. This may be needed for
Jeremy Allison [Tue, 22 May 2007 23:56:47 +0000 (23:56 +0000)]
r23088: Fix rename for cifsfs client. This may be needed for
(This used to be commit 02e4f6b0f1f1a1cc6bfe5fed7866eb5b18ab87e0)

12 years agor23087: Fix POSIX setfilepathinfo to use lstat, not stat.
Jeremy Allison [Tue, 22 May 2007 22:35:13 +0000 (22:35 +0000)]
r23087: Fix POSIX setfilepathinfo to use lstat, not stat.
Still missing lchown (will add this for 3.0.26).
Don't merge for 3.0.25a - possibly 3.0.25b (if it
(This used to be commit f546750176a22cdd7298a73afc81587923baaff9)

12 years agor23082: Ooops - that portion of the last checkin was by accident.
Michael Adam [Tue, 22 May 2007 21:17:31 +0000 (21:17 +0000)]
r23082: Ooops - that portion of the last checkin was by accident.
Before comitting that, I have to verify that it does not
break anything...

(This used to be commit 55ea93d47e72d13b7e6d6900eea5da1e9a49ff8d)

12 years agor23081: Reorder the lsa_lookup_sids functions so that the order makes more sense...
Michael Adam [Tue, 22 May 2007 21:04:56 +0000 (21:04 +0000)]
r23081: Reorder the lsa_lookup_sids functions so that the order makes more sense...
(This used to be commit 374dea8c6f5192224ee46e0c3c9b63221028858e)

12 years agor23080: Fix bug #4637 - we hads missed some cases where
Jeremy Allison [Tue, 22 May 2007 20:20:01 +0000 (20:20 +0000)]
r23080: Fix bug #4637 - we hads missed some cases where
we were calling PRS_ALLOC_MEM with zero count.
(This used to be commit 9a10736e6fa276ca4b0726fbb7baf0daafbdc46d)

12 years agor23078: Don't handle return code NT_STATUS_NONE_MAPPED from lookup sids
Michael Adam [Tue, 22 May 2007 15:13:32 +0000 (15:13 +0000)]
r23078: Don't handle return code NT_STATUS_NONE_MAPPED from lookup sids
as an error. (This is purely cosmetic here, issuing a success
message at the end.)
(This used to be commit 4d9e8c91dc387cef37ea9035ac4483916e854732)

12 years agor23077: Minor cleanup
Volker Lendecke [Tue, 22 May 2007 14:31:26 +0000 (14:31 +0000)]
r23077: Minor cleanup
(This used to be commit 72ed8388252bed07627b3a4636744dc8acf1c98b)

12 years agor23075: more duplicate code blocks from bad merge
Gerald Carter [Tue, 22 May 2007 13:55:31 +0000 (13:55 +0000)]
r23075: more duplicate code blocks from bad merge
(This used to be commit 86b6a41d5784a0214810c9cbc52ca5e99952898d)

12 years agor23074: Remove duplicate code blocks from bad merge
Gerald Carter [Tue, 22 May 2007 13:43:34 +0000 (13:43 +0000)]
r23074: Remove duplicate code blocks from bad merge
(This used to be commit 2c64638934e83e5716e47986adbb1fa07c057486)

12 years agor23073: In the internal rpccli_lsa_lookup_sids_noalloc(), use a temporary
Michael Adam [Tue, 22 May 2007 13:40:01 +0000 (13:40 +0000)]
r23073: In the internal rpccli_lsa_lookup_sids_noalloc(), use a temporary
talloc context for use with the actual rpc query and response.
So the the parent context does not get flooded by the posslibly
large amount of response data (when looking up a lot of sids).

Note: It not possible, to simply use the names and domains arrays
as talloc contexts for the talloc_strdup calls, because from
rpccli_lsa_lookup_sids_all, this is called with names + offset
and domains + offset where names and domains are talloced
arraye for the complete response.
(This used to be commit 8e60900c5c5fccbe1718b805b6b1628d32b920d0)

12 years agor23072: In winbindd_ads.c:lookup_groupmem, replace the bottleneck
Michael Adam [Tue, 22 May 2007 12:49:41 +0000 (12:49 +0000)]
r23072: In winbindd_ads.c:lookup_groupmem, replace the bottleneck
dn_lookup loop by a rpccli_lsa_lookupsids_all (see r23070)
call. This replaces one ldap search per member sid by one
rpc call per 1000 sids. This greatly speeds up groupmem
lookups for groups with lots of users.

Since the loop in lookup_groupmem was the only use of dn_lookup,
the function is removed.

(This used to be commit 88dac65ab1b951d445f0eedb638e9ace93139872)

12 years agor23070: The lsa rpc lookup sids call has a maximum number of SIDS to be
Michael Adam [Tue, 22 May 2007 11:30:35 +0000 (11:30 +0000)]
r23070: The lsa rpc lookup sids call has a maximum number of SIDS to be
looked up at one time. This limit is at 20480 for w2k3.
Our rpccli_lsa_lookup_sids function ignores this limit, so when
we give the server too long a list of SIDs, then we will get
nothing back. Since typically rpccli_lsa_lookup_sids is given
one SID  (or a small number of SIDS), this did not do harm
up to now. But since I want to use lsa_lookup_sids in a subsequent
modification to winbindd_ads.c:lookup_groupmem to get rid of
a vast number of dn_lookup calls to the server, I had to make
sure we do it correctly.

I have added a function rpccli_lsa_lookup_sids_all function
that has the same prototype but internally splits the list
of SIDs up into hunks of a (conservative, hard coded) 1000
SIDs each for a first go.

If this approach is agreed upon, the new function could replace
the original rpccli_lsa_lookup_sids function.

(This used to be commit 66ff0bc6c39f86a9830dc508cd891e33638b475d)

12 years agor23068: Fix some uninitialized variables in the solarisacl module
Volker Lendecke [Tue, 22 May 2007 10:05:56 +0000 (10:05 +0000)]
r23068: Fix some uninitialized variables in the solarisacl module
(This used to be commit 569c04a2445a74469663cec33ae42ddfcdbe1dfc)

12 years agor23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'm
Volker Lendecke [Mon, 21 May 2007 22:17:13 +0000 (22:17 +0000)]
r23055: Rewrite messages.c to use auto-generated marshalling in the tdb. I'm
doing this because for the clustering the marshalling is needed in more
than one place, so I wanted a decent routine to marshall a message_rec
struct which was not there before.

Tridge, this seems about the same speed as it used to be before, the
librpc/ndr overhead in my tests was under the noise.

(This used to be commit eaefd00563173dfabb7716c5695ac0a2f7139bb6)

12 years agor23054: Move the check for the lookup_domain of S-1-22-{1,2} before the
Gerald Carter [Mon, 21 May 2007 21:33:51 +0000 (21:33 +0000)]
r23054: Move the check for the lookup_domain of S-1-22-{1,2} before the
check for IS_DC.  Otherwise we will for example fail to lookup a
sid of S-1-22-1-780 because it has no valid struct winbindd_domain*
in the list.   Thanks to Simo for the catch.
(This used to be commit f53aa56998411b90de238e12e9c3de7f2ff0d2b6)

12 years agor23051: sid_to_[ug]id fixes for smbd
Simo Sorce [Mon, 21 May 2007 20:51:15 +0000 (20:51 +0000)]
r23051: sid_to_[ug]id fixes for smbd
(This used to be commit 2d636ad2a33d0ca61bf6022feceed47dd68ef855)

12 years agor23048: Simo is correct in that winbind_lookup{sid,name}_async() needs
Gerald Carter [Mon, 21 May 2007 20:36:22 +0000 (20:36 +0000)]
r23048: Simo is correct in that winbind_lookup{sid,name}_async() needs
to be able to handle SIDs in the S-1-22-{1,2} domain in order
for winbindd_sid_to_uid(), et. al. to succeed.  For 3.0.25a,
we will short circuit in the sid_to_uid() family of functions
so that smbd is ok.

For 3.0.26, we need to allow winbindd to handle all types of SIDs.
(This used to be commit d70cec31965de41d3296c9b585ff0aea4f2bcffe)

12 years agor23046: Few missing merges from cleaning out the Centeris winbindd tree.
Gerald Carter [Mon, 21 May 2007 19:12:14 +0000 (19:12 +0000)]
r23046: Few missing merges from cleaning out the Centeris winbindd tree.
Nothing of major interest.  Will fix a few problems with one way trusts.
(This used to be commit 3d48a7e72d9268fd495e0ca4b6e73bed5bb57214)

12 years agor23041: Remainder of fix for 4630: fix special case of unix_to_nt_time() for
Jim McDonough [Mon, 21 May 2007 16:01:22 +0000 (16:01 +0000)]
r23041: Remainder of fix for 4630: fix special case of unix_to_nt_time() for
TIME_T_MAX, and also display of it in http_timestring()
(This used to be commit 2553b6a56d20ef6273001ae3b090e156e676592c)

12 years agor23040: Activate the winbindd cache validation code in the
Michael Adam [Mon, 21 May 2007 15:58:27 +0000 (15:58 +0000)]
r23040: Activate the winbindd cache validation code in the
winbindd main function.

I have tested and somewhat extended the code, and it seems
to do a good job. I have possibly not caught all error
conditions though.

(This used to be commit 8c517f9aacef300e4280896e36ff71dc9aa35dc3)

12 years agor23039: merge from SAMBA_3_0_26:
Stefan Metzmacher [Mon, 21 May 2007 13:40:27 +0000 (13:40 +0000)]
r23039: merge from SAMBA_3_0_26:

use a helper function to construct the TDB_DATA key
as strlen_m() is totally wrong here anyway

(This used to be commit fb77cc7fbc0100c66365109ae6c3cc4824079a2e)

12 years agor23025: Some logic simplifications
Volker Lendecke [Sun, 20 May 2007 20:28:45 +0000 (20:28 +0000)]
r23025: Some logic simplifications
(This used to be commit d3f16722b2c3c68b03e55b5100d979921c3f284d)

12 years agor23024: Ok, neither the duplicates_allowed nor the timeout argument to
Volker Lendecke [Sun, 20 May 2007 20:11:23 +0000 (20:11 +0000)]
r23024: Ok, neither the duplicates_allowed nor the timeout argument to
message_send_pid is used anymore. Two users of duplicates_allowed: winbind and
the printer notify system.

I don't thing this really changes semantics: duplicates_allowed is hell racy
anyway, we can't guarantee that we don't send the same message in sequence
twice, and I think the only thing we can harm with the print notify is

For winbind I talked to Günther, and he did not seem too worried.

(This used to be commit 75b3ae6a761c33ae6a70799340a1e8c1edea265e)

12 years agor23023: Get rid of the only caller of message_send_pid_with_timeout(). This replaces
Volker Lendecke [Sun, 20 May 2007 19:43:49 +0000 (19:43 +0000)]
r23023: Get rid of the only caller of message_send_pid_with_timeout(). This replaces
the timeouts on the individual message send calls with an overall timeout on
all the calls.

The timeout in message_send_pid_with_timeout() did not make much sense IMO
anyway, because the tdb_fetch() for the messages_pending_for_pid was blocking
in a readlock anyway, we "just" did the timeout for the write lock.

This new code goes through the full wait for the write lock once and then
breaks out of sending the notifies instead of running into the timeout per

Jerry, please check this!


(This used to be commit 697099f06e1aa432187f802b9c2632607e3de46e)

12 years agor23022: Reformatting
Volker Lendecke [Sun, 20 May 2007 17:00:18 +0000 (17:00 +0000)]
r23022: Reformatting
(This used to be commit 782ee7291683d061767688b23f93ac0865e46331)

12 years agor23016: Remove extra & - thanks to Volker for spotting this.
Jeremy Allison [Sat, 19 May 2007 22:29:59 +0000 (22:29 +0000)]
r23016: Remove extra & - thanks to Volker for spotting this.
(This used to be commit c2c970fd50b293031390358d72aaa7bd94da6e6d)

12 years agor23015: Make message_(de)register static to messages.c
Volker Lendecke [Sat, 19 May 2007 21:53:28 +0000 (21:53 +0000)]
r23015: Make message_(de)register static to messages.c
(This used to be commit a8082a3c7c3d1e68c27fc3bf42f3d44402cc6f9f)

12 years agor23014: For all branches, ensure that if we're blocked on a POSIX
Jeremy Allison [Sat, 19 May 2007 20:57:12 +0000 (20:57 +0000)]
r23014: For all branches, ensure that if we're blocked on a POSIX
lock we know nothing about that we retry the lock every
10 seconds instead of waiting for the standard select
timeout. This is how we used to (and are supposed to)
(This used to be commit fa18fc25a50cf13c687ae88e7e5e2dda1120e017)

12 years agor23010: Make the output of "smbcontrol --help" match that of "smbcontrol help".
James Peach [Sat, 19 May 2007 04:59:00 +0000 (04:59 +0000)]
r23010: Make the output of "smbcontrol --help" match that of "smbcontrol help".
Bug #3181.
(This used to be commit 94b0997ef1bd993587dfeef4e0a8d366c5371e9f)

12 years agor23009: Both contains a strchr_m(server,'/') few lines after replacing all / with \.
James Peach [Sat, 19 May 2007 04:23:04 +0000 (04:23 +0000)]
r23009: Both contains a strchr_m(server,'/') few lines after replacing all / with \.
This patch removes this dead code.

Patch from Pascal Terjan <pterjan@mandriva.com> for bug #2313.
(This used to be commit 04b84baef344206d97776e04a25f4bd214eea28f)

12 years agor23007: Ensure we don't allow large read over the possible
Jeremy Allison [Sat, 19 May 2007 01:27:34 +0000 (01:27 +0000)]
r23007: Ensure we don't allow large read over the possible
packet size.
(This used to be commit 5d465dd2d559df29d18a844137c8e14ffbb1a269)

12 years agor23006: Arg. Fix stupid typo in 64-bit path.
Jeremy Allison [Fri, 18 May 2007 23:56:34 +0000 (23:56 +0000)]
r23006: Arg. Fix stupid typo in 64-bit path.
(This used to be commit 80a63123907c3291d8bdc6d364bf7343f4f084a0)

12 years agor23005: If we're running on a system where time_t is 8 bytes
Jeremy Allison [Fri, 18 May 2007 23:38:56 +0000 (23:38 +0000)]
r23005: If we're running on a system where time_t is 8 bytes
we have to take care to preserve the "special" values
for Windows of 0x80000000 and 0x7FFFFFFF when casting
between time_t and uint32. Add conversion functions
(and use them).
(This used to be commit 4e1a0b2549f7c11326deed2801de19564af0f16a)

12 years agor23001: - Fix but #4634. Type of the size parameter to getpeername was wrong.
Derrell Lipman [Fri, 18 May 2007 13:42:48 +0000 (13:42 +0000)]
r23001: - Fix but #4634.  Type of the size parameter to getpeername was wrong.
(This used to be commit 6675c8acf1d83b7131d38f09f381062b6a604c7e)

12 years agor22998: merge from SAMBA_4_0:
Stefan Metzmacher [Fri, 18 May 2007 09:50:56 +0000 (09:50 +0000)]
r22998: merge from SAMBA_4_0:

only if the output of which has a leading '/' the output is useful...

(This used to be commit 5c5aa1f862ad5e765b18c8dbc981af3012b48cb7)

12 years agor22994: Fix HP/UX compiler flags by Don McCall. Lets see how the other HP/UX
Volker Lendecke [Fri, 18 May 2007 08:35:01 +0000 (08:35 +0000)]
r22994: Fix HP/UX compiler flags by Don McCall. Lets see how the other HP/UX
boxes like this. Thanks, Don!
(This used to be commit c53cf972cf35fc344eb40078a1a778260a3de07f)

12 years agor22982: Do not prompt for password on sec=none for mount.cifs (and allow guest
Steve French [Thu, 17 May 2007 22:40:48 +0000 (22:40 +0000)]
r22982: Do not prompt for password on sec=none for mount.cifs (and allow guest
option to pass to kernel code so it can know when to retry)
(This used to be commit 500d9236c419be6ec32cc209279aeea2234f1a21)

12 years agor22979: Revert previous checkin (which had some debug junk) and fix misc frees that
Steve French [Thu, 17 May 2007 22:28:28 +0000 (22:28 +0000)]
r22979: Revert previous checkin (which had some debug junk) and fix misc frees that
valgrind noticed
(This used to be commit c8aa60692ba23c43820b820db3371a86dfbf40b5)

12 years agor22978: Don't use current_user to prep the security ctx in change_to_user
Gerald Carter [Thu, 17 May 2007 22:27:42 +0000 (22:27 +0000)]
r22978: Don't use current_user to prep the security ctx in change_to_user
since any SID/uid/gid translation calls will reset the struct when
popping the security ctx.  This should fix the standalone server
configuration issues reported by David Rankin (thanks for the logs).
(This used to be commit 63cb25bad19d9600399a6ee2221497d71e805320)

12 years agor22977: Trim noise by removing redundant WARNING log message that
Gerald Carter [Thu, 17 May 2007 19:56:54 +0000 (19:56 +0000)]
r22977: Trim noise by removing redundant WARNING log message that
would flood at log level 2.  We know when we're using the legacy
mapping code anyways since it will log an informative msg.
(This used to be commit 51aac0fcb4528df790aa3ae078f9ef639cc01363)

12 years agor22976: whoops typo
Simo Sorce [Thu, 17 May 2007 19:26:08 +0000 (19:26 +0000)]
r22976: whoops typo
(This used to be commit 2d4c3a7520e3fa8b61d717a83ae63a633f433ea3)

12 years agor22975: BUG 4616: Don't return a dns or forest name when replying to the
Gerald Carter [Thu, 17 May 2007 19:16:27 +0000 (19:16 +0000)]
r22975: BUG 4616: Don't return a dns or forest name when replying to the
DsDGetPrimaryRoleInfo() and configured for security = domain.
(This used to be commit 55ba4a04d0efe2ae7b0d945648b2db801ff9e9f1)

12 years agor22974: enable relro with PIE if available, this gives extra protection to the ELF...
Simo Sorce [Thu, 17 May 2007 18:20:16 +0000 (18:20 +0000)]
r22974: enable relro with PIE if available, this gives extra protection to the ELF segment
(This used to be commit 708a9cb08ea8ffd0aee8ed5d8d8d14193306ce9a)

12 years agor22973: Apparently, 3.0.25 broke smb4k badly ;-)
Alexander Bokovoy [Thu, 17 May 2007 13:56:19 +0000 (13:56 +0000)]
r22973: Apparently, 3.0.25 broke smb4k badly ;-)
smb4k uses 'net rap server domain' to list servers in domain.
Previously we just ignored all arguments in net_rap_server() but now we don't
as 'net rap server name' has added an explicit check on arguments.

Allow 'net rap server domain' to aid smb4k. Any other arguments will cause help message.
(This used to be commit 8f78b6ce3a635110ba7afe32f3536097d51cb4fc)

12 years agor22956: Fix security=server (bug #4622). Volker's patch
Jeremy Allison [Wed, 16 May 2007 22:52:17 +0000 (22:52 +0000)]
r22956: Fix security=server (bug #4622). Volker's patch
(slightly truncated by me). Will be in 3.0.25a.
(This used to be commit 039fb906af883a7ca1a68955f1b36b583fe1b698)

12 years agor22955: Disable dependency tracking by default.
James Peach [Wed, 16 May 2007 22:34:58 +0000 (22:34 +0000)]
r22955: Disable dependency tracking by default.
(This used to be commit 2dddd502c9150128c6d1b28c083554d8519c4fd3)

12 years agor22954: More messaging_register
Volker Lendecke [Wed, 16 May 2007 20:56:39 +0000 (20:56 +0000)]
r22954: More messaging_register
(This used to be commit 9b8df24107ffe3016031e5257c5680689f061886)

12 years agor22953: Well, this apparently has never been tested. But *this* code never saw a
Volker Lendecke [Wed, 16 May 2007 20:02:32 +0000 (20:02 +0000)]
r22953: Well, this apparently has never been tested. But *this* code never saw a
release yet .... ;-))
(This used to be commit f93b6353fe18e2c992a3dad96afd1a4c16032c55)

12 years agor22950: Fix the issue Volker reported here :
Jeremy Allison [Wed, 16 May 2007 17:17:25 +0000 (17:17 +0000)]
r22950: Fix the issue Volker reported here :

"Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in

        if (len <= 0) {

in line 136 of clientgen.c throws a failure."

The irritating thing is that I already had it correct in
SAMBA_3_0_26 and forgot to merge the change across.

len == 0 is a valid return - I messed that up when
converting client_receive_smb() to return a length
rather than a BOOL.

Doh !

(This used to be commit a398bdf08d9efac51af28aed29f2c0f151cd5aad)

12 years agor22943: More message_register -> messaging_register
Volker Lendecke [Wed, 16 May 2007 14:45:09 +0000 (14:45 +0000)]
r22943: More message_register -> messaging_register
(This used to be commit caece8975b0c2bad56d6a6a576bf8ce54626183f)

12 years agor22942: Some message_register -> messaging_register conversions
Volker Lendecke [Wed, 16 May 2007 14:24:06 +0000 (14:24 +0000)]
r22942: Some message_register -> messaging_register conversions
(This used to be commit 65335a420645202fc79c599a1177838ec19a4075)

12 years agor22934: Change smbcontrol to use messaging_register instead of message_register
Volker Lendecke [Wed, 16 May 2007 13:02:53 +0000 (13:02 +0000)]
r22934: Change smbcontrol to use messaging_register instead of message_register
(This used to be commit e3d985c581ffc597aea932858d27c421643d2868)

12 years agor22932: Use the same symbol in sizeof and cast for talloc.
Michael Adam [Wed, 16 May 2007 11:57:37 +0000 (11:57 +0000)]
r22932: Use the same symbol in sizeof and cast for talloc.
(This used to be commit 550498e68db9305e31da38dbc9c642961418a8b0)

12 years agor22931: Fix logic in detection of the need to replace dlopen and friends.
Michael Adam [Wed, 16 May 2007 11:15:16 +0000 (11:15 +0000)]
r22931: Fix logic in detection of the need to replace dlopen and friends.
Originally, dlfcn.o was only added to LIBREPLACEOBJ if dlopen
was found in libdl but header dlfcn.h was not appropriate.

(This used to be commit 2c72980a808a9ebe5518c6e03baa66e6b97cc7db)

12 years agor22930: Next attempt to get the build farm in line.
Volker Lendecke [Wed, 16 May 2007 10:59:04 +0000 (10:59 +0000)]
r22930: Next attempt to get the build farm in line.

Jeremy, please check this and merge if appropriate.
(This used to be commit 0bdf4f1a5937abd0ef266700115d74396bc1629c)

12 years agor22929: Attempt to fix some build farm failures: On port 139 the first
Volker Lendecke [Wed, 16 May 2007 09:53:41 +0000 (09:53 +0000)]
r22929: Attempt to fix some build farm failures: On port 139 the first
successful packet gives len==0 from the server, so the = in

        if (len <= 0) {

in line 136 of clientgen.c throws a failure.

Jeremy, please fix this properly, I'm not merging this to 3_0_26 so that
you can filter it when you merge.

(This used to be commit 9c5111d8c5064a43762d7d0146acff5e7691dafd)

12 years agor22928: Use better success error code.
Günther Deschner [Wed, 16 May 2007 09:42:29 +0000 (09:42 +0000)]
r22928: Use better success error code.

(This used to be commit cdfcbb176ac11e0f6f63ab38bf3c24d25a6c6153)