Stefan Metzmacher [Mon, 31 Mar 2008 10:01:24 +0000 (12:01 +0200)]
libwbclient: use WBC_ERROR_IS_OK() in BAIL_ON_WBC_ERROR() macro
metze
Michael Adam [Tue, 1 Apr 2008 13:51:51 +0000 (15:51 +0200)]
test: add diagnostic message to net_registry test.
Michael
Michael Adam [Tue, 1 Apr 2008 13:50:24 +0000 (15:50 +0200)]
test: fix net_registry test "set value to different type" to track error count
missing backslash in call... :-}
Michael
Michael Adam [Tue, 1 Apr 2008 13:43:35 +0000 (15:43 +0200)]
test: some cosmetics to net_registry tests.
Michael
Michael Adam [Tue, 1 Apr 2008 13:35:12 +0000 (15:35 +0200)]
test: fix net_registry tests to correctly capture output of commands inside one test
so that failure output is not clobbered by output of previous
successful commands.
Michael
Michael Adam [Tue, 1 Apr 2008 13:19:05 +0000 (15:19 +0200)]
test: fix use of printf in net_registry tests.
actually 'printf "%s\n"' is the proper replacement of 'echo -e'
Michael
Michael Adam [Tue, 1 Apr 2008 13:55:59 +0000 (15:55 +0200)]
po/genmsg: be more portable, use 'printf "%s"' instead of 'echo -n'
Michael
Michael Adam [Tue, 1 Apr 2008 13:54:34 +0000 (15:54 +0200)]
mkversion: be more portable, use 'print "%s"' instead of 'echo -n'
Michael
Michael Adam [Tue, 1 Apr 2008 13:53:54 +0000 (15:53 +0200)]
installswat: be more portable, use 'printf "%s"' instead of 'echo -n'
Michael
Michael Adam [Tue, 1 Apr 2008 13:52:54 +0000 (15:52 +0200)]
configure: be more portable, use 'printf "%s"' instead of "echo -n"
Michael
Michael Adam [Tue, 1 Apr 2008 11:45:55 +0000 (13:45 +0200)]
test: be more portable. replace 'echo -n' by 'printf "%s"' in test_functions.sh
Michael
Michael Adam [Tue, 1 Apr 2008 11:43:20 +0000 (13:43 +0200)]
test: be more portable: replace 'echo -n' by 'printf "%s"' in selftest.sh
Michael
Stefan Metzmacher [Tue, 1 Apr 2008 10:29:12 +0000 (12:29 +0200)]
smbd: ignore nttrans renames as w2k3 does
This lets us pass the RAW-RENAME test.
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Tue, 1 Apr 2008 09:26:29 +0000 (11:26 +0200)]
account_pol: use db_open_trans()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 19:04:35 +0000 (20:04 +0100)]
account_pol: use dbwrap_trans_store_uint32()
metze
Volker Lendecke [Fri, 28 Mar 2008 11:09:56 +0000 (12:09 +0100)]
Convert account_pol.tdb to dbwrap
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Sun, 30 Mar 2008 11:11:22 +0000 (13:11 +0200)]
dbwrap: fix a confusing "tdb_chainunlock failed" message
Unlock before we cancel the transaction...
metze
Stefan Metzmacher [Fri, 28 Mar 2008 19:03:30 +0000 (20:03 +0100)]
dbwrap: add dbwrap_trans_store_uint32()
metze
Volker Lendecke [Fri, 28 Mar 2008 11:02:28 +0000 (12:02 +0100)]
Add dbwrap_trans_*_bystring
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Fri, 28 Mar 2008 10:57:54 +0000 (11:57 +0100)]
Convert dbwrap_trans_delete to NTSTATUS
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Fri, 28 Mar 2008 10:53:00 +0000 (11:53 +0100)]
Convert dbwrap_trans_store to NTSTATUS
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Volker Lendecke [Fri, 28 Mar 2008 08:42:37 +0000 (09:42 +0100)]
Add dbwrap_[fetch|store]_uint32
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Fri, 28 Mar 2008 07:27:11 +0000 (08:27 +0100)]
sharesec: use db_open_trans()
metze
Volker Lendecke [Thu, 27 Mar 2008 22:10:57 +0000 (23:10 +0100)]
Convert share_info.tdb to dbwrap
Stefan Metzmacher [Fri, 28 Mar 2008 11:20:06 +0000 (12:20 +0100)]
mapping_tdb: use the correct sid for the key creation
metze
Stefan Metzmacher [Thu, 27 Mar 2008 16:39:58 +0000 (17:39 +0100)]
mapping_tdb: use db_open_trans()
metze
Volker Lendecke [Thu, 27 Mar 2008 16:10:31 +0000 (17:10 +0100)]
Protect group_mapping.tdb ops with transactions
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Stefan Metzmacher [Thu, 27 Mar 2008 15:55:35 +0000 (16:55 +0100)]
pdb_tdb: use != 0 instead off == -1 for dbwrap functions
metze
Stefan Metzmacher [Tue, 1 Apr 2008 09:02:01 +0000 (11:02 +0200)]
passdb: guard pdb_generate_sam_sid() with a transaction
This prevents possible races with some dbwrap backends
metze
Stefan Metzmacher [Tue, 1 Apr 2008 09:00:59 +0000 (11:00 +0200)]
passdb/secrets: add secrets_db_ctx() to get the db_context
metze
Stefan Metzmacher [Tue, 1 Apr 2008 10:56:38 +0000 (12:56 +0200)]
regdb: let regdb_fetch_keys() handle NULL and failure cases in the same way and return -1
metze
Stefan Metzmacher [Tue, 1 Apr 2008 10:48:08 +0000 (12:48 +0200)]
regdb: get the seqnum before the record, to not miss something
metze
Stefan Metzmacher [Tue, 1 Apr 2008 10:38:54 +0000 (12:38 +0200)]
regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
This is the fixed version of commit
5c28c74aa06a82559f498373b3d6e9892d5c2cbe.
metze
Michael Adam [Tue, 1 Apr 2008 10:48:25 +0000 (12:48 +0200)]
test: make registry tests more portable: protect some grep patterns in ' '.
Michael
Michael Adam [Tue, 1 Apr 2008 10:45:06 +0000 (12:45 +0200)]
test: make registry tests more portable: use 'printf "%s"' instead of 'echo -e'
Michael
Jeremy Allison [Tue, 1 Apr 2008 00:01:27 +0000 (17:01 -0700)]
Ok, final move of this code :-). I think I've found the correct
place for it now where it will cause minimal disruption (only
call the extra message_dispatch just before reading the next
smb off the wire).
Jeremy.
Jeremy Allison [Mon, 31 Mar 2008 23:56:21 +0000 (16:56 -0700)]
Move the message_dispatch() call after the check for errno on
the select return. We don't want the call to message_dispatch
to mess up the errno value.
Jeremy.
Jeremy Allison [Mon, 31 Mar 2008 23:46:20 +0000 (16:46 -0700)]
Reduce the race condition in Samba4 in RAW-RENAME test. We rename a file
using trans2 setfileinfo on one connection, and then check the
file name has changed on the other. In Samba we achieve this by
sending a local message to the other process. This change causes
us to re-scan for incoming messages after we've woken up from the
select (which is cheap if there are no pending messages). This reduces
the race significantly. Volker please review.
Jeremy.
Günther Deschner [Mon, 31 Mar 2008 22:32:23 +0000 (00:32 +0200)]
Fix build of rpcclient.
Guenther
Günther Deschner [Mon, 31 Mar 2008 22:14:00 +0000 (00:14 +0200)]
Fix build warning.
Guenther
Günther Deschner [Mon, 31 Mar 2008 22:11:55 +0000 (00:11 +0200)]
Fix SRVSVC NetShareInfo level 502 client-side.
Guenther
Günther Deschner [Mon, 31 Mar 2008 22:02:48 +0000 (00:02 +0200)]
Fix SRVSVC ShareInfo level 502 server side handling.
Guenther
Günther Deschner [Mon, 31 Mar 2008 21:55:16 +0000 (23:55 +0200)]
Re-run make idl.
Guenther
Günther Deschner [Mon, 31 Mar 2008 21:52:36 +0000 (23:52 +0200)]
Fix IDL for srvsvc_NetShareInfo502. It does indeed contain a sec_desc_buf.
Guenther
Günther Deschner [Mon, 31 Mar 2008 21:51:34 +0000 (23:51 +0200)]
Fix SRVSVC ShareInfo max_users handling server side.
Guenther
Günther Deschner [Mon, 31 Mar 2008 21:47:26 +0000 (23:47 +0200)]
Re-run make idl.
Guenther
Günther Deschner [Mon, 31 Mar 2008 21:45:26 +0000 (23:45 +0200)]
Use uint32 in max_users field in SRVSVC ShareInfo levels consistently.
Guenther
Günther Deschner [Mon, 31 Mar 2008 20:49:03 +0000 (22:49 +0200)]
Fix _srvsvc_NetShareSetInfo.
Guenther
Michael Adam [Mon, 31 Mar 2008 11:54:39 +0000 (13:54 +0200)]
test: add test script for testing "net registry".
Michael
Jeff Layton [Mon, 10 Mar 2008 19:54:36 +0000 (15:54 -0400)]
mount.cifs: fix several problems when mounting subdirectories of shares (try 2)
This patch is the second patch to attempt to fix up some of the problems
with mounting subdirectories of shares. The earlier patch didn't handle
this correctly when POSIX extensions were enabled. This one does.
This is a bit of a confusing area since the different components of
a service string have different rules:
1) hostname: no '/' (slash) or '\' (backslash) is allowed to be
embedded within the string
2) sharename: same rules as hostname
3) prefixpath: '\' *is* allowed to be embedded in a path component,
iff POSIX extensions are enabled. Otherwise, neither
character is allowed.
The idea here is to allow either character to act as a delimiter when we
know that the character can't be anything but a delimiter (namely
everywhere up to the start of the prefixpath). The patch will convert
any '\' unconditionally to '/' in the UNC portion of the string.
However, inside the prefixpath, we can't make assumptions about what
constitutes a delimiter because POSIX allows for embedded '\'
characters. So there we don't attempt to do any conversion, and pass the
prefixpath to the kernel as is. Once the kernel determines whether POSIX
extensions are enabled, it can then convert the path if needed and it's
able to do so. A patch to handle this has already been committed to the
cifs-2.6 git tree.
This patch also fixes an annoyance. When you mount a subdir of a share,
mount.cifs munges the device string so that you can't tell what the
prefixpath is. So if I mount:
//server/share/p1/p2/p3
..then /proc/mounts and mtab will show only:
//server/share
Finally, it also tries to apply some consistent rules to the uppercasing
of strings.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Gerald W. Carter [Mon, 31 Mar 2008 19:33:53 +0000 (14:33 -0500)]
Patch from Nicholas Brealey <nick@brealey.org> to distinguish between WinXP and WinXP64.
Defines a new value for the %a variable when detecting a Windows XP 64-bit client.
Günther Deschner [Mon, 31 Mar 2008 18:43:18 +0000 (20:43 +0200)]
Re-add support for the samr parameters string.
(dialin settings, terminal server settings, etc.)
Guenther
Günther Deschner [Mon, 31 Mar 2008 18:42:26 +0000 (20:42 +0200)]
Re-run make idl.
Guenther
Günther Deschner [Mon, 31 Mar 2008 18:40:56 +0000 (20:40 +0200)]
The parameters string (aka munged dial string) in samr is not a normal lsa_String.
Guenther
Günther Deschner [Mon, 31 Mar 2008 18:40:16 +0000 (20:40 +0200)]
Add init_samr_parameters_string().
Guenther
Gerald W. Carter [Mon, 31 Mar 2008 18:39:54 +0000 (13:39 -0500)]
Fix enumeration of forest trusts from our root domain.
Do not overwrite the domain->domain_flags when setting infomation
in set_dc_type_and_flags_connect().
Gerald W. Carter [Thu, 27 Mar 2008 20:23:36 +0000 (15:23 -0500)]
DIsplay the short domain name in "wbinfo -m " by default.
This fixes wbinfo -m to make preexisting behavior.
Also adds the dns domain to the --verbose output.
Steven Danneman [Tue, 25 Mar 2008 23:58:40 +0000 (16:58 -0700)]
Augmented "wbinfo -m" to list additional information about the type, direction, and transitivty of trusts.
* added several helper functions to convert the trust_flags field in the
winbindd_tdc_domain to more useful administrator ideas of trust type, trust
direction, and trust transitivity.
* converted winbindd_list_trusted_domains() to enumerate the trusted domain
cache, instead of the domain list, and return additional trust information to
the calling process
* modified wbinfo to pretty print this additional trust information when a new
--verbose switch is given with -m. Thus "wbinfo -m" and "wbinfo -all-domains"
output as before, but "wbinfo --verbose -m" prints extra trust info.
* updated some comments and fixed typos
Steven Danneman [Tue, 25 Mar 2008 23:50:58 +0000 (16:50 -0700)]
Forest root trust flags won't overwrite child trust flags
* changed the behavior of winbind_ads.c:trusted_domains() to not overwrite
existing trust information if we're joined to a child domain, and querying the
forest root domain. Previously if we were joined to a child domain, we'd
request all known trust information from this child domain (our primary domain)
and store it in the tdc. We'd then request all trust information from our tree
root (to get the forests we transitively trust) and overwrite the existing trust
information we already had from the perspective of the tree root.
* updated several comments and fixed typos
Michael Adam [Mon, 31 Mar 2008 11:51:49 +0000 (13:51 +0200)]
test: add (and unify) sectioning output of subtests in tests_all.sh
Michael
Michael Adam [Mon, 31 Mar 2008 11:33:12 +0000 (13:33 +0200)]
test: add possibility to select tests to run via tests_all.sh (make test)
This allows to select the tests to run with tests_all.sh by setting
the environment variable "RUNTESTS". Example:
RUNTESTS="smbclient_s3_encrypted wbinfo_s3" make test
Michael
Michael Adam [Mon, 31 Mar 2008 11:20:08 +0000 (13:20 +0200)]
test: in tests_all.sh, wrap calls to test scripts into shell functions.
This is in preparation for enabling running only selected test scripts
through "make test".
Michael
Michael Adam [Mon, 31 Mar 2008 15:20:07 +0000 (17:20 +0200)]
registry: reg_deletevalue should return error, when the value does not exist.
Michael
Stefan Metzmacher [Fri, 28 Mar 2008 18:39:43 +0000 (19:39 +0100)]
wbinfo: use wbcAllocateGid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:39:16 +0000 (19:39 +0100)]
wbinfo: use wbcAllocateUid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:38:24 +0000 (19:38 +0100)]
wbinfo: use wbcSidToGid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:37:50 +0000 (19:37 +0100)]
wbinfo: use wbcSidToUid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:37:02 +0000 (19:37 +0100)]
wbinfo: use wbcGitToSid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:34:10 +0000 (19:34 +0100)]
wbinfo: use wbcUidToSid()
metze
Stefan Metzmacher [Fri, 28 Mar 2008 18:01:54 +0000 (19:01 +0100)]
wbinfo: use wbcPing()
metze
Michael Adam [Mon, 31 Mar 2008 09:58:35 +0000 (11:58 +0200)]
build: fix configure option --with-static-libs=libXYZ
This should not prevent building but linking of shared lib for
subsystem XYZ (example --with-static-libs=libtdb).
m4 quotation is tricky...
Michael
Michael Adam [Sun, 30 Mar 2008 00:25:45 +0000 (01:25 +0100)]
Revert "regdb: use dbwrap->fetch() instead of fetch_locked() for readonly access"
This reverts commit
4e2be189e97f653b75bd88135a631ce0f42db267.
Metze, this broke the registry (reg_api layer), but I don't yet know
exactly how and why. By the way, the locks there had the purpose of
fetching the seqnum that really matches the data.
This needs some more thought / debugging. But I wanted to have
the tree in a working state again.
Michael
Volker Lendecke [Sat, 29 Mar 2008 11:23:26 +0000 (12:23 +0100)]
Fix a segfault (an uninitialized variable)
Michael Adam [Sat, 29 Mar 2008 00:05:17 +0000 (01:05 +0100)]
winbindd_cache: add missing validation function for pwinfo cache entry
Michael
Jeremy Allison [Sat, 29 Mar 2008 00:32:52 +0000 (17:32 -0700)]
Fix missing '&&'.
Jeremy.
Jeremy Allison [Sat, 29 Mar 2008 00:31:33 +0000 (17:31 -0700)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Sat, 29 Mar 2008 00:31:06 +0000 (17:31 -0700)]
Only allow sendfile on non-stream fsp's. Should fix make test for streams
as sendfile isn't implemented in the streams vfs modules yet.
Jeremy.
Günther Deschner [Fri, 28 Mar 2008 23:49:09 +0000 (00:49 +0100)]
Zero initial return_authenticator in net rpc samdump.
Guenther
Günther Deschner [Fri, 28 Mar 2008 23:47:42 +0000 (00:47 +0100)]
Don't let winbind getgroups crash when we have no gids in the token.
Guenther
Günther Deschner [Fri, 28 Mar 2008 22:46:26 +0000 (23:46 +0100)]
Re-run make idl.
Guenther
Günther Deschner [Fri, 28 Mar 2008 22:44:43 +0000 (23:44 +0100)]
Fill in netr_NegotiateFlags.
Guenther
Günther Deschner [Fri, 28 Mar 2008 22:39:57 +0000 (23:39 +0100)]
Add some paranoia fixes for _wkssvc_NetrJoinDomain2/UnjoinDomain2.
Guenther
Stefan Metzmacher [Fri, 28 Mar 2008 14:06:56 +0000 (15:06 +0100)]
mapping_ldb: fix memory leak in group enumeration
metze
Jeremy Allison [Fri, 28 Mar 2008 17:12:07 +0000 (10:12 -0700)]
Fix bug #5326 - OS/2 servers give strange "high word" replies for print jobs.
Jeremy.
Günther Deschner [Fri, 28 Mar 2008 15:39:02 +0000 (16:39 +0100)]
Support "net ads join" format while joining to a specific ou.
libnetjoin now supports Computers/Servers/Unix as well as
ou=Computers,ou=Servers,ou=Unix,dc=ber,dc=realm,dc=com.
Guenther
Günther Deschner [Fri, 28 Mar 2008 15:33:54 +0000 (16:33 +0100)]
Add ads_check_ou_dn().
Guenther
Michael Adam [Fri, 28 Mar 2008 14:49:13 +0000 (15:49 +0100)]
Add a talloc context parameter to current_timestring() to fix memleaks.
current_timestring used to return a string talloced to talloc_tos().
When called by DEBUG from a TALLOC_FREE, this produced messages
"no talloc stackframe around, leaking memory". For example when
used from net conf.
This also adds a temporary talloc context to alloc_sub_basic().
For this purpose, the exit strategy is slightly altered: a common
exit point is used for success and failure.
Michael
Michael Adam [Fri, 28 Mar 2008 14:39:52 +0000 (15:39 +0100)]
srv_winreg: add a debug message to _winreg_CreateKey().
Michael
Michael Adam [Fri, 28 Mar 2008 00:21:49 +0000 (01:21 +0100)]
net: add a "net registry" subcommand to locally access the registry.
The interface is like that of net rpc registry.
Access is direct local access to the registry tdb through reg_api.
Michael
Volker Lendecke [Fri, 28 Mar 2008 14:21:14 +0000 (15:21 +0100)]
More ssize_t->SMB_OFF_T
Stefan Metzmacher [Fri, 28 Mar 2008 06:56:20 +0000 (07:56 +0100)]
libreplace(samba4): let LIBREPLACE depend on LIBREPLACE_NETWORK for now
This should fix the build on solaris.
Later this needs better fixing...
metze
(cherry picked from commit
89b7955733c34e9699a3b43ee54de92cb9469b90)
Stefan Metzmacher [Mon, 24 Mar 2008 20:05:30 +0000 (21:05 +0100)]
wbinfo: use wbcDomainInfo()
metze
Stefan Metzmacher [Mon, 24 Mar 2008 19:44:34 +0000 (20:44 +0100)]
wbinfo: use wbcGetgrnam()
metze
Stefan Metzmacher [Mon, 24 Mar 2008 19:32:14 +0000 (20:32 +0100)]
wbinfo: use wbcListUsers() and wbcListGroups()
metze
Stefan Metzmacher [Sun, 23 Mar 2008 21:41:45 +0000 (22:41 +0100)]
wbinfo: use wbcLookupUserSids()
metze
Stefan Metzmacher [Mon, 24 Mar 2008 20:07:01 +0000 (21:07 +0100)]
libwbclient: remove prototype of non existing wbcDomainSequenceNumbers()
metze
Stefan Metzmacher [Mon, 24 Mar 2008 19:31:37 +0000 (20:31 +0100)]
libwbclient: add wbcListUsers() and wbcListGroups()
metze
Stefan Metzmacher [Fri, 21 Mar 2008 09:18:54 +0000 (10:18 +0100)]
libwbclient: add wbcLookupUserSids()
metze
Günther Deschner [Fri, 28 Mar 2008 13:13:27 +0000 (14:13 +0100)]
Add Support for DOMAIN\DCNAME syntax in libnetjoin.
This format is used by Windows to enforce joining to a specific DC.
Guenther
Günther Deschner [Fri, 28 Mar 2008 12:53:33 +0000 (13:53 +0100)]
Let libnetjoin find the dc in wkssvc NetrJoinDomain2/UnjoinDomain2.
Guenther