Günther Deschner [Wed, 14 May 2008 21:50:25 +0000 (23:50 +0200)]
Fix Bug #5465 (joining with createcomputer=ou1/ou2/ou3).
Guenther
(This used to be commit
f3251ba03a69c2fd0335861177159a32b2bc9477)
Jeremy Allison [Wed, 14 May 2008 21:10:39 +0000 (14:10 -0700)]
Fix bug #5464. Pointed out by Herb @ Connectathon. In fork_domain_child() we call :
CatchChild();
*before* we fork the domain child. This call establishes a signal handler that
eats SIGCLD signals and doesn't call sys_select_signal() as the main daemon
SIGCLD handler should do. This causes the parent to ignore dead children and
time out, instead of calling winbind_child_died() on receipt of the signal. The
correct fix is to move the CatchChild call into the child code after the fork.
Jeremy.
(This used to be commit
8d701a142be2b75dc30ad215bc178af902eb4af9)
Jeremy Allison [Wed, 14 May 2008 21:10:05 +0000 (14:10 -0700)]
Ensure we don't keep searching for sharename if it's
not the start of the list.
Jeremy.
(This used to be commit
15857534b76bc66ad122510100aa224f17250465)
Kai Blin [Mon, 12 May 2008 12:39:03 +0000 (14:39 +0200)]
configure: Kill linker warnings about 32bit libs on 64bit Linux.
(This used to be commit
9a40cbd66f71c49af4c72ed826d66c5f037a3171)
Günther Deschner [Wed, 14 May 2008 07:42:23 +0000 (09:42 +0200)]
dsgetdcname: In case we didn't get a mailslot reply, don't cache the nodestatus.
Guenther
(This used to be commit
12e47be02f93e2f41af5772f6a83568b3574d032)
Günther Deschner [Wed, 14 May 2008 07:41:24 +0000 (09:41 +0200)]
mailslot: Also pick domain name and pdc name from type 15 cldap reply.
Guenther
(This used to be commit
836877c4005ba081c0a4cc97726830d6dbd62d34)
Kai Blin [Wed, 14 May 2008 07:02:22 +0000 (09:02 +0200)]
AFS: The dummy afs_createtoken_str should return NULL, not False.
(This used to be commit
c84d49429191423a81d558042fe949c26f5de5fe)
Jim McDonough [Tue, 13 May 2008 22:42:18 +0000 (18:42 -0400)]
Merge branch 'v3-3-test' of git://git.samba.org/samba into 3.3-test
(This used to be commit
6dd44ebf22762e852b43e7dbcd095a58cc45abad)
Jeremy Allison [Tue, 13 May 2008 22:25:26 +0000 (15:25 -0700)]
Fix debug message.
Jeremy.
(This used to be commit
08d168f0e5b8fb07e95a5118a839e0da53e9d363)
Jeremy Allison [Tue, 13 May 2008 22:02:11 +0000 (15:02 -0700)]
Second part of patch for bug #5460. Cope with pathnames
that don't look like \xxx\yyy, cope with arbitrary length.
Jeremy.
(This used to be commit
635035d999fcd8e06b70c8cb1137127c289dc9e6)
Jeremy Allison [Tue, 13 May 2008 21:01:19 +0000 (14:01 -0700)]
Fix bug #5460. The problem is RHEL5.0 shipped a CIFS client
that sets the DFS bit on pathnames but doesn't
send DFS paths. This causes lookups to fail as
the smbd/msdfs.c code now just eats the first
two parts of the pathname and uses the rest as
the local path. The previous hostname check
used to protect us from that as we knew that
when the hostname was invalid it was a local
path (and a broken client).
I didn't want to put that check back in, but
came up with another idea - even though the
hostname can be a different one, the sharename
must be valid on this machine. So we can check
for a valid sharename instead.
Jeremy.
(This used to be commit
e1cda82f6f7de3306a653af920756c1640057f2d)
Jim McDonough [Tue, 13 May 2008 20:57:01 +0000 (16:57 -0400)]
Enable winbind child processes to do something with signals,
in particular closing and reopening logs on SIGHUP.
Conflicts:
source/winbindd/winbindd.c
(This used to be commit
0f7b11accec7df1c0e9a9dc0828a5e0c5ddec4cb)
coffeedude [Tue, 13 May 2008 17:58:52 +0000 (12:58 -0500)]
libwbclient: Abstract the DS_XXX flags for DsGetDcName().
The wbcLookupDomainController() call supports a set of flags
defined in wbclient.h. Add a mapping function between these
flags and the original DS_XXX flags in order to prevent having
to include the generated RPC headers in wbclient.h.
(This used to be commit
31614cd5e08dd6389c66e6ddf9f2d5429c6ab033)
coffeedude [Tue, 13 May 2008 17:52:20 +0000 (12:52 -0500)]
libwbclient: Add wbcLogoffUser() and wbcLookupDomainController().
Add new APIs calls for WINBINDD_PAM_LOGOFF and WINBINDD_DSGETDCNAME
ops.
(This used to be commit
cb5e8f60ac3313aec726c01687a040e6e0e42c10)
Volker Lendecke [Tue, 13 May 2008 14:23:19 +0000 (16:23 +0200)]
Fix signing problem in the client with transs requests
This is a different fix than Jeremy put into 3-0-test with
040db1ce85 and other
branches with different hashes. Jeremy, I think your fix led to bug 5436, so I
reverted your fix. This fixes the original problem I found with the transs
requests for large rpc queries in a different way. Please check!
Thanks,
Volker
(This used to be commit
c572d537e088a3fffb057181cad9a3692e40b815)
Volker Lendecke [Tue, 13 May 2008 13:19:46 +0000 (15:19 +0200)]
Revert "Fix signing bug found by Volker. That one was *subtle*."
This reverts commit
816aea6c1a426eb2450061b847729e22bdac33a0.
(This used to be commit
e402e6508ca0806deef4c4044cfa6461b682850a)
Karolin Seeger [Tue, 13 May 2008 12:01:52 +0000 (14:01 +0200)]
tests_all.sh: Do not execute $SMB4TORTURE --version if it is not available.
Improve error message if no SMB4TORTURE is available.
Karolin
(This used to be commit
443691eb2614919043406f94e9c71b49230612d5)
Karolin Seeger [Tue, 13 May 2008 08:18:37 +0000 (10:18 +0200)]
man pages: Correct version string.
As Samba 3.2 will be out soon, man pages should be correct for both versions,
Samba 3.0 and 3.2.
Karolin
(This used to be commit
9c59c1895d8d3621f38b67ecf88109c81130c886)
coffeedude [Mon, 12 May 2008 22:33:01 +0000 (17:33 -0500)]
net ads: Upper case he realm name when calling kinit() using machine creds.
Needed fix for the DNS Update option as part of "net ads join"
(This used to be commit
aebae0b71b427838fdc6344d69d6dea87a5dd58b)
Volker Lendecke [Sat, 10 May 2008 22:25:55 +0000 (00:25 +0200)]
Make sure we have serversupplied_info->sanitized_username everywhere
(This used to be commit
88423a17b966652eba4085e88f7ddb5c86b463dd)
Volker Lendecke [Sat, 10 May 2008 22:25:27 +0000 (00:25 +0200)]
With force user, we have the same base token for all vuids
(This used to be commit
0f19bc3f65bfc132aea1de1e76fcb4ee625a050f)
Volker Lendecke [Sat, 10 May 2008 22:23:01 +0000 (00:23 +0200)]
Fix a memleak in new auth_serversupplied code
(This used to be commit
f23e970848b6e6655453fa65f6f160f624acfcff)
Volker Lendecke [Sat, 10 May 2008 21:27:21 +0000 (23:27 +0200)]
Volker Lendecke [Thu, 8 May 2008 14:06:42 +0000 (16:06 +0200)]
Remove "user" from connection_struct
(This used to be commit
368454a27cb53a408ec416cbf37235b304592fb5)
Volker Lendecke [Sat, 10 May 2008 09:01:26 +0000 (11:01 +0200)]
Add a comment explaining server_info in connection_struct
(This used to be commit
35438a940734340d5d6389ae0551fe3c25902f93)
Volker Lendecke [Thu, 8 May 2008 13:53:55 +0000 (15:53 +0200)]
Remove the unix token info from connection_struct
(This used to be commit
2834dacc8d49f77fe55fb5d7e3eb2dda431d1d3d)
Volker Lendecke [Thu, 8 May 2008 13:09:02 +0000 (15:09 +0200)]
Replace nt_user_token with server_info in connection_struct
(This used to be commit
a3738aef59e97d4533010b048534d937d36c0950)
Volker Lendecke [Thu, 8 May 2008 10:14:43 +0000 (12:14 +0200)]
Empty some nonempty blank lines
(This used to be commit
1a406def02bf171b223467d6b76317586d6205fc)
Volker Lendecke [Thu, 8 May 2008 09:49:14 +0000 (11:49 +0200)]
Use TALLOC_ZERO_P instead of separate ZERO_STRUCTP in dup_nt_token
(This used to be commit
124a2c71852f39fcfe62ea19a5a8d25638d47400)
Volker Lendecke [Thu, 8 May 2008 09:47:43 +0000 (11:47 +0200)]
Make use of talloc_tos() in change_to_user()
(This used to be commit
c4bed3a48b86d44ad641250add2fc189af7e72f5)
Volker Lendecke [Wed, 7 May 2008 13:51:42 +0000 (15:51 +0200)]
Next try at making the vuid cache circular
Jeremy, please check!
(This used to be commit
a34f73521712e3820d417f0d9ed811723b7681d6)
Volker Lendecke [Wed, 7 May 2008 12:36:15 +0000 (14:36 +0200)]
find_forced_group can directly change the token in server_info
Now that we have a token that is correctly set up with gids already, this saves
manual translation of the SIDs to GIDs.
(This used to be commit
6136a6d9d7301c65f37e2bf485681138cddd8bd2)
Volker Lendecke [Wed, 7 May 2008 12:28:23 +0000 (14:28 +0200)]
Add an error return in find_forced_group()
(This used to be commit
93ce0705c14f222bda3e6204f4b54ba1893f33e1)
Volker Lendecke [Wed, 7 May 2008 12:25:47 +0000 (14:25 +0200)]
Do not unnecessarily mess with the results in find_forced_group()
(This used to be commit
6d9860d09b54c61625f011c2d56d710aa59d7686)
Volker Lendecke [Wed, 7 May 2008 11:16:20 +0000 (13:16 +0200)]
Replace find_forced_user by a direct call to make_serverinfo_from_username
(This used to be commit
7991e6764b4187ba86802569dfdc5816e6137f78)
Volker Lendecke [Wed, 7 May 2008 10:42:36 +0000 (12:42 +0200)]
Simplify make_connection_snum: Copy connection_struct info from server_info
(This used to be commit
5aa3cdf355c179d89c2703f528919194ab084337)
Volker Lendecke [Wed, 7 May 2008 10:20:18 +0000 (12:20 +0200)]
Add "server_info" to connection_struct
This will replace all the user identity stuff in connection_struct, for now it
is just a source where the other fields in connection_struct are filled from.
(This used to be commit
0f53f9e7db9f99f239c4d0950452d0e2cde2ae8b)
Volker Lendecke [Tue, 6 May 2008 20:12:04 +0000 (22:12 +0200)]
Remove unused "force_group" from connection_struct
(This used to be commit
03944f8d8934cff74e19fc036f7611c1491e0d57)
Volker Lendecke [Tue, 6 May 2008 19:50:08 +0000 (21:50 +0200)]
"status" -> "pstatus" in make_connection_snum
(This used to be commit
3ce395e61e931a77c5d2f52f39c7e3f71a9605a9)
Volker Lendecke [Tue, 6 May 2008 15:48:22 +0000 (17:48 +0200)]
Add create_connection_server_info() -- not used yet
(This used to be commit
50bf075f7556fd09e0081175c31a5020a8eaf4d6)
Volker Lendecke [Tue, 6 May 2008 15:47:26 +0000 (17:47 +0200)]
Add function make_serverinfo_from_username()
This will be used for 'security=share' and 'force user'
(This used to be commit
88e43097cafcd2849d9f1200a377357fde4cce99)
Volker Lendecke [Tue, 6 May 2008 15:26:49 +0000 (17:26 +0200)]
Add a mem_ctx argument to make_server_info_guest()
(This used to be commit
e4a9492967f3d2b64f27943f99414608e0c03d21)
Volker Lendecke [Tue, 6 May 2008 14:10:23 +0000 (16:10 +0200)]
Make copy_serverinfo non-static, add mem_ctx
(This used to be commit
a3651ced9e0859578df8cc44da64e7a8066bde76)
Volker Lendecke [Sat, 10 May 2008 08:58:23 +0000 (10:58 +0200)]
Fix the build with DNS_UPDATES
(This used to be commit
6c9500c290fe0d6d71d4c33eb265906ce3a1d9f3)
Kai Blin [Thu, 8 May 2008 09:23:38 +0000 (11:23 +0200)]
net: more whitespace cleanup
(This used to be commit
ef0184d580500734fc7af51e1c790b075180a3d0)
Kai Blin [Fri, 9 May 2008 21:22:12 +0000 (23:22 +0200)]
net: Remove globals
(This used to be commit
1e9319cf88b65a2a8d4f5099a1fe5297e405ed2e)
Kai Blin [Thu, 8 May 2008 07:14:16 +0000 (09:14 +0200)]
net: Some whitespace clean-up.
(This used to be commit
4dcce8b653671c8ce907f8353df1db8a5c8f8e19)
Kai Blin [Fri, 9 May 2008 20:50:04 +0000 (22:50 +0200)]
net: Fix usage string.
(This used to be commit
e3470e9a1b19c239d6fa576f8c8c1a5a5c3b5d3c)
Michael Adam [Fri, 9 May 2008 23:28:58 +0000 (01:28 +0200)]
packaging: remove references to smbmount and friends from samba-ctdb spec file
Michael
(This used to be commit
66c4d58f38557df618f026ddb661190dc02af719)
Michael Adam [Fri, 9 May 2008 23:26:52 +0000 (01:26 +0200)]
packaging: fix GPL version in samba-ctdb specfile.
Michael
(This used to be commit
35543d8815b004d3b29771f07998ee7ee820b567)
Michael Adam [Fri, 9 May 2008 23:23:10 +0000 (01:23 +0200)]
packaging: rename RHEL4-CTDB --> RHEL-CTDB
Michael
(This used to be commit
711af98d2ce708421a413fe46a386ea9e19d2517)
Michael Adam [Sat, 10 May 2008 00:18:55 +0000 (02:18 +0200)]
packaging: add x perms to samba-ctdb filter-requires-samba.sh script.
Michael
(This used to be commit
7520007efd31d7a81cacc3c2744e6a95dbdc08d4)
Michael Adam [Sat, 10 May 2008 00:18:08 +0000 (02:18 +0200)]
packaging: add x perms to samba-ctdb makerpms.sh script.
Michael
(This used to be commit
405b0f8273ddd397d050b519419193dd8c978aba)
Andrew Tridgell [Fri, 9 May 2008 01:21:16 +0000 (11:21 +1000)]
fixed version in spec file
(This used to be commit
e7023592cbca002d94c47f73a2dc6c3e0a4c4a40)
Andrew Tridgell [Fri, 9 May 2008 00:06:03 +0000 (10:06 +1000)]
merge in spec file from Michael
(This used to be commit
4aaaf792fe3b972d7ca5737bf7343fbda766d9b0)
Michael Adam [Fri, 9 May 2008 22:13:11 +0000 (00:13 +0200)]
loadparm: Fix activation of registry globals in lp_load_*.
This completes
bba04a8fba6fd5cf62578733cfdabea590e8ff51:
The reverted logic has to be put into the callers
lp_load() and lp_load_initial_only() of lp_load_ex(), too.
Silly bug.
Michael
(This used to be commit
c1f300c76e882f2d108596aa3dbc211d545c665a)
Jeremy Allison [Fri, 9 May 2008 21:51:45 +0000 (14:51 -0700)]
Fix replacement getpass. If we ^C at the prompt echo was left off.
Jeremy.
(This used to be commit
e54c71954ae484fe4a4e195db33440490e78e256)
Jeremy Allison [Fri, 9 May 2008 18:14:45 +0000 (11:14 -0700)]
Remove a couple of uses of SMB_VFS_GET_NT_ACL(), use
SMB_VFS_FGET_NT_ACL instead. I'd like to ultimately
remove SMB_VFS_GET_NT_ACL.
Jeremy.
(This used to be commit
4221937b68e2414295279b27c5f12a80f826ed4b)
Günther Deschner [Fri, 9 May 2008 15:56:04 +0000 (17:56 +0200)]
dsgetdcname: add reminder that we need to support ipv6 here once we know how.
Guenther
(This used to be commit
4b3617bf505a835a6d4bb9b80c4ad837a2082dea)
Günther Deschner [Fri, 9 May 2008 15:41:50 +0000 (17:41 +0200)]
dsgetdcname: make use of nbt_cldap_netlogon_15.
Guenther
(This used to be commit
5b0eda98f3d127399770f7a037ad3277dbe23393)
Günther Deschner [Fri, 9 May 2008 15:40:29 +0000 (17:40 +0200)]
re-run make idl.
Guenther
(This used to be commit
5a216d2340bb06a8866718d1b4b07265006bd900)
Günther Deschner [Fri, 9 May 2008 15:39:53 +0000 (17:39 +0200)]
IDL: Fix nbt_cldap_netlogon union, removing the default member.
Guenther
(This used to be commit
a56d7999a445f7157f85e5636f5b2c5e471a98e2)
Günther Deschner [Fri, 9 May 2008 15:24:38 +0000 (17:24 +0200)]
IDL: Add nbt_cldap_netlogon_15.
Guenther
(This used to be commit
5e91bd1d2bfe458c6f8b3696f99e0f75e43cbae8)
Günther Deschner [Thu, 8 May 2008 16:32:22 +0000 (18:32 +0200)]
dsgetdcname: use existing messaging_context if possible.
Guenther
(This used to be commit
7889516a384c155a9045aad4409c041fddd0d98d)
Günther Deschner [Thu, 8 May 2008 12:24:46 +0000 (14:24 +0200)]
dsgetdcname: the forest name should never be empty.
Guenther
(This used to be commit
2c0a96f1e5fc065fdbeb5671cfa693009321dde8)
Günther Deschner [Thu, 8 May 2008 12:23:20 +0000 (14:23 +0200)]
Use strip_hostname after dsgetdcname/getdcname calls.
Guenther
(This used to be commit
82cbb3269b2e764c9c2a2fbcbe9c29feae07fb62)
Günther Deschner [Thu, 8 May 2008 12:16:50 +0000 (14:16 +0200)]
util: add strip_hostname() to strip of leading '\\'.
Guenther
(This used to be commit
dbf96120d8b33e592bfd3e9df1777f1670e218be)
Günther Deschner [Thu, 8 May 2008 10:16:04 +0000 (12:16 +0200)]
dsgetdcname: add map_dc_and_domain_names() for consolidating returned names.
Guenther
(This used to be commit
eb7fee6e2a00326c03aa013058247e06279a4930)
Günther Deschner [Wed, 7 May 2008 19:31:59 +0000 (21:31 +0200)]
cldap: move out cldap object to fix the build.
Guenther
(This used to be commit
56be9c98d24e64bf855439df21766d30f448f407)
Günther Deschner [Wed, 7 May 2008 19:25:05 +0000 (21:25 +0200)]
dsgetdcname: fix gencache store for dsgetdcname().
While storing always a type 29 reply structure in gencache, we are now able to
deliver correct data according to return flags such as DS_RETURN_FLAT_NAME and
DS_RETURN_DNS_NAME out of the cached data from gencache.
Guenther
(This used to be commit
c67b6dc0ca866781043e443177d550e23b83ae36)
Günther Deschner [Wed, 7 May 2008 19:08:20 +0000 (21:08 +0200)]
dsgetdcname: pure cosmetics.
Guenther
(This used to be commit
4b56c294e8ba045c84cab538b3d286e433d292ed)
Günther Deschner [Wed, 7 May 2008 19:06:23 +0000 (21:06 +0200)]
dsgetdcname: simply call ourself with DS_FORCE_REDISCOVERY after cache expiry.
Guenther
(This used to be commit
847f258632f6d49a3fd45f466c5d3d8c6222ff85)
Günther Deschner [Wed, 7 May 2008 19:04:10 +0000 (21:04 +0200)]
dsgetdcname: be more paranoid about the existance of an ip_address.
Guenther
(This used to be commit
d13fe66f3d9ba152e3e8197ee6682e175163a6cd)
Günther Deschner [Wed, 7 May 2008 19:02:50 +0000 (21:02 +0200)]
dsgetdcname: remove invalid assumption in discover_dc_dns().
Guenther
(This used to be commit
f48b2e844b673e99c84cb24f3c3718352ab93ce5)
Günther Deschner [Wed, 7 May 2008 16:57:43 +0000 (18:57 +0200)]
dsgetdcname: mailslot replies are identical to the cldap ones, use cldap everywhere.
Guenther
(This used to be commit
fe904ee77a7fec1674e9db660978c40c17897f77)
Günther Deschner [Wed, 7 May 2008 16:55:45 +0000 (18:55 +0200)]
dsgetdcname: wait a little longer for mailslot replies.
Guenther
(This used to be commit
bc0d7a90dcc7bf702b24feb16abf4634ff178671)
Günther Deschner [Wed, 7 May 2008 16:39:24 +0000 (18:39 +0200)]
dsgetdcname: map additional flags to nt_version.
Guenther
(This used to be commit
1009123b8600e6ccebe180f4a2f87c217638fef8)
Günther Deschner [Wed, 7 May 2008 16:38:37 +0000 (18:38 +0200)]
dsgetdcname: use make_dc_info_from_cldap_reply() for cldap replies.
Guenther
(This used to be commit
a3e5b073f0474543ca74b40775ce1d7f80719c96)
Günther Deschner [Wed, 7 May 2008 16:36:03 +0000 (18:36 +0200)]
dsgetdcname: add make_dc_info_from_cldap_reply().
Guenther
(This used to be commit
9db2e50a20caabaf90ce03203a066ddd7820d33a)
Günther Deschner [Wed, 7 May 2008 14:49:39 +0000 (16:49 +0200)]
dsgetdcname: add get_cldap_reply_server_flags().
Guenther
(This used to be commit
3c05c56d4c0aac8106684cda3152c65299c63075)
Günther Deschner [Wed, 7 May 2008 13:49:09 +0000 (15:49 +0200)]
cldap: let ads_cldap_netlogon() return all possible cldap replies.
Guenther
(This used to be commit
6f9d5e1cc94bc90685b54c04622b8f3357bd2f69)
Günther Deschner [Wed, 7 May 2008 13:21:41 +0000 (15:21 +0200)]
dsgetdcname: add pull_mailslot_cldap_reply().
Guenther
(This used to be commit
95fb01d8702342265f8837a368dc42f4a4d394d5)
Günther Deschner [Wed, 7 May 2008 12:38:35 +0000 (14:38 +0200)]
dsgetdcname: add map_ds_flags_to_nt_version.
Guenther
(This used to be commit
1809ea22c31ee28e109f49701f91534177027165)
Jeremy Allison [Fri, 9 May 2008 05:07:35 +0000 (22:07 -0700)]
Fix bug #5452 - smbclient put always creates zero length
files. Thanks to Kai Engert <kengert@redhat.com> for
reporting.
Jeremy.
(This used to be commit
687275cd532f8f8ad710acd222a0c76625da53c6)
Jeremy Allison [Fri, 9 May 2008 01:09:07 +0000 (18:09 -0700)]
Yay ! Remove a VFS entry. Removed the set_nt_acl() call,
this can only be done via fset_nt_acl() using an open
file/directory handle. I'd like to do the same with
get_nt_acl() but am concerned about efficiency
problems with "hide unreadable/hide unwritable" when
doing a directory listing (this would mean opening
every file in the dir on list).
Moving closer to rationalizing the ACL model and
maybe moving the POSIX calls into a posix_acl VFS
module rather than having them as first class citizens
of the VFS.
Jeremy.
(This used to be commit
f487f742cb903a06fbf2be006ddc9ce9063339ed)
Michael Adam [Thu, 8 May 2008 16:08:41 +0000 (18:08 +0200)]
registry: add removal of secdesc of a key to regdb_store_keys().
Michael
(This used to be commit
a01d8fe5e89ca9620d23198b11e5ae605a97e5a6)
Michael Adam [Thu, 8 May 2008 16:05:58 +0000 (18:05 +0200)]
registry: add comments to removing lists in regdb_store_keys().
Michael
(This used to be commit
3e89217e7edea5d7ec707de065d38b1921ed09af)
Michael Adam [Thu, 8 May 2008 15:59:32 +0000 (17:59 +0200)]
registry: change order of deleting value and subkey lists in store_keys().
Next step in the plan to make store_keys safer without transactions.
Michael
(This used to be commit
f7c8718dead63964481954a86427b8c05d15452c)
Michael Adam [Thu, 8 May 2008 14:55:14 +0000 (16:55 +0200)]
registry: adapt comment to first step in regdb_store_keys().
Michael
(This used to be commit
97592db08a109ffbea8c85b17686fa565c5cf8c9)
Michael Adam [Thu, 8 May 2008 14:32:51 +0000 (16:32 +0200)]
registry: adapt comment of last step in regdb_store_keys().
adding number (3) ....
Michael
(This used to be commit
a03a17365d64f7fe83a9f2e866c4f069a1dd1682)
Michael Adam [Thu, 8 May 2008 12:33:02 +0000 (14:33 +0200)]
registry: regdb_store_keys: move storing the subkey list down after removing values.
Michael
(This used to be commit
986030cdda828f7f87c5464d1837324b7033e27e)
Michael Adam [Tue, 6 May 2008 08:06:34 +0000 (10:06 +0200)]
registry: add comment explaining workflow to make store_keys safe w/o transactions
/*
* Make the store operation as safe as possible without transactions:
*
* (1) For each subkey removed from ctr compared with old_subkeys:
*
* (a) First delete the value db entry.
*
* (b) Next delete the secdesc db record.
*
* (c) Then delete the subkey list entry.
*
* (2) Now write the list of subkeys of the parent key,
* deleting removed entries and adding new ones.
*
* (3) Finally create the subkey list entries for the added keys.
*
* This way if we crash half-way in between deleting the subkeys
* and storing the parent's list of subkeys, no old data can pop up
* out of the blue when re-adding keys later on.
*/
The workflow is going to be modified to meet this agendain the next commits.
Michael
(This used to be commit
55dd9bdd148fc942e15aacfe9f6b38b1a5c53158)
Michael Adam [Wed, 7 May 2008 12:01:49 +0000 (14:01 +0200)]
registry: check for existence of non base key in regdb_store_keys() before proceeding.
Michael
(This used to be commit
52413c94fcc56c4055de4d35bea8a00646352122)
Michael Adam [Wed, 7 May 2008 22:34:35 +0000 (00:34 +0200)]
registry: add a function regdb_key_is_base_key() to check whether is composite.
This partly duplicates code from regdb_key_exists(). Maybe refactor later.
Michael
(This used to be commit
c27d03bba842ecf99f23b22dc40fa7df33392fa0)
Michael Adam [Wed, 7 May 2008 11:50:01 +0000 (13:50 +0200)]
registry: check for existence of key in regdb_set_secdesc() before proceeding.
Michael
(This used to be commit
347bab7f4aca7f26a88affea954a514c25735abf)
Michael Adam [Wed, 7 May 2008 11:48:28 +0000 (13:48 +0200)]
registry: check for existence of key in regdb_get_secdesc() before proceeding.
Michael
(This used to be commit
727e5a87c0ed3e0a2b9c2b508b1f81e6a6d26732)
Michael Adam [Wed, 7 May 2008 11:45:02 +0000 (13:45 +0200)]
registry: check for existence of key in regdb_store_values() before proceeding.
Michael
(This used to be commit
8a2c9d965d332ccd290089b92e9cfbba2413067c)
Michael Adam [Wed, 7 May 2008 11:42:48 +0000 (13:42 +0200)]
registry: check for existence of key in regdb_fetch_keys() before proceeding.
Michael
(This used to be commit
cf653e101d1b2c38b5e9de35732421a120213170)
Michael Adam [Wed, 7 May 2008 11:27:56 +0000 (13:27 +0200)]
registry: check for existence of key in regdb_fetch_values() first.
This uses the new semantics for existence of a key.
Michael
(This used to be commit
56a58690d3ab2e01ed28388bd59424d3abc7a0d3)
Michael Adam [Wed, 7 May 2008 11:26:13 +0000 (13:26 +0200)]
registry: free talloc context on error path in regdb_fetch_values().
Michael
(This used to be commit
978aef3a862065be856b36b38d72d581c3ac0ba1)