16 years agoIf signing starts successfully, don't just turn it off automatically if
Jeremy Allison [Tue, 25 Nov 2003 18:15:52 +0000 (18:15 +0000)]
If signing starts successfully, don't just turn it off automatically if
it fails later. Only turn it off automatically if it fails at the start.
(This used to be commit 4a145531c2b6353291cd25f14f5572aa31e86594)

16 years agoDo not add NTLM2 to the NTLMSSP flags unconditionally - allow the
Andrew Bartlett [Tue, 25 Nov 2003 11:25:38 +0000 (11:25 +0000)]
Do not add NTLM2 to the NTLMSSP flags unconditionally - allow the
defaults specified by the caller to prevail.

Don't use NTLM2 for RPC pipes, until we know how it works in signing or sealing.

Call ntlmssp_sign_init() unconditionally in the client - we setup the
session key, why not setup the rest of the data.

Andrew Bartlett
(This used to be commit 48123f7e42c3fde85887de23c80ceee04c2f6281)

16 years agoPatch for #263 from jpjanosi@us.ibm.com.
Jeremy Allison [Tue, 25 Nov 2003 02:04:03 +0000 (02:04 +0000)]
Patch for #263 from jpjanosi@us.ibm.com.
(This used to be commit 0f2a50316d8245ea9c441f0ea08e1a0fd9a92583)

16 years agoWhen server signing is set to "auto", if the client doesn't sign just
Jeremy Allison [Tue, 25 Nov 2003 00:32:51 +0000 (00:32 +0000)]
When server signing is set to "auto", if the client doesn't sign just
ignore it. Only fail if signing is set to "required".
(This used to be commit 8916ddfc39c3e70265188926f24034152f0e7b6b)

16 years agostrequal() returns a BOOL, not an int like strcmp(); this fixes a bug in check_bind_r...
Gerald Carter [Mon, 24 Nov 2003 20:22:12 +0000 (20:22 +0000)]
strequal() returns a BOOL, not an int like strcmp(); this fixes a bug in check_bind_response()
(This used to be commit 5e062f72baad6f7a70f1a3c8cf190535ccacc89e)

16 years agoAdded "passwd chat timeout" parameter. Docs to follow.
Jeremy Allison [Mon, 24 Nov 2003 20:18:47 +0000 (20:18 +0000)]
Added "passwd chat timeout" parameter. Docs to follow.
(This used to be commit 16097f2072085432f4c669d9e008023f36f7afbb)

16 years agopatch from Matthias Hilbig for bug 467; use the dns name (or IP) as the originating...
Gerald Carter [Mon, 24 Nov 2003 18:37:19 +0000 (18:37 +0000)]
patch from Matthias Hilbig for bug 467; use the dns name (or IP) as the originating client name when using CUPS
(This used to be commit 71333299a6e6bc6d74d2172f71e3fe21ef75aa3c)

16 years agomore access fixes for group enumeration in LDAP; bug 281
Gerald Carter [Mon, 24 Nov 2003 17:31:38 +0000 (17:31 +0000)]
more access fixes for group enumeration in LDAP; bug 281
(This used to be commit 68283407e0f366d8315f4be6caed67eb6fe84b85)

16 years agoPatch by emil@disksites.com <Emil Rasamat> to ensure we always always
Andrew Bartlett [Sun, 23 Nov 2003 00:16:54 +0000 (00:16 +0000)]
Patch by emil@disksites.com <Emil Rasamat> to ensure we always always
free() each auth method. (We had relied on the use of talloc() only, despite providing the free() callback)

Andrew Bartlett
(This used to be commit 5872c0e26e3407c7c1dcf2074a36896a3ca1325a)

16 years agoAdd server-side support for variable-length session keys (as used by
Andrew Bartlett [Sun, 23 Nov 2003 00:04:29 +0000 (00:04 +0000)]
Add server-side support for variable-length session keys (as used by
DES based krb5 logins).

Andrew Bartlett
(This used to be commit 240b0d178e1b4a3556207bdf2e342c70155f64ee)

16 years agoAdd support for variable-length session keys in our client code.
Andrew Bartlett [Sat, 22 Nov 2003 23:38:41 +0000 (23:38 +0000)]
Add support for variable-length session keys in our client code.

This means that we now support 'net rpc join' with KRB5 (des based)
logins.  Now, you need to hack 'net' to do that, but the principal is

When we add kerberos to 'net rpc', it should be possible to still do
user management and the like over RPC.

(server-side support to follow shortly)

Andrew Bartlett
(This used to be commit 9ecf9408d98639186b283f1acf0fac46417547d0)

16 years agoChanges all over the shop, but all towards:
Andrew Bartlett [Sat, 22 Nov 2003 13:19:38 +0000 (13:19 +0000)]
Changes all over the shop, but all towards:
 - NTLM2 support in the server
 - KEY_EXCH support in the server
 - variable length session keys.

In detail:

 - NTLM2 is an extension of NTLMv1, that is compatible with existing
domain controllers (unlike NTLMv2, which requires a DC upgrade).

 * This is known as 'NTLMv2 session security' *

(This is not yet implemented on the RPC pipes however, so there may
well still be issues for PDC setups, particuarly around password
changes.  We do not fully understand the sign/seal implications of
NTLM2 on RPC pipes.)

This requires modifications to our authentication subsystem, as we
must handle the 'challege' input into the challenge-response algorithm
being changed.  This also needs to be turned off for
'security=server', which does not support this.

- KEY_EXCH is another 'security' mechanism, whereby the session key
actually used by the server is sent by the client, rather than being
the shared-secret directly or indirectly.

- As both these methods change the session key, the auth subsystem
needed to be changed, to 'override' session keys provided by the

- There has also been a major overhaul of the NTLMSSP subsystem, to merge the 'client' and 'server' functions, so they both operate on a single structure.  This should help the SPNEGO implementation.

- The 'names blob' in NTLMSSP is always in unicode - never in ascii.
Don't make an ascii version ever.

- The other big change is to allow variable length session keys.  We
have always assumed that session keys are 16 bytes long - and padded
to this length if shorter.  However, Kerberos session keys are 8 bytes
long, when the krb5 login uses DES.

 * This fix allows SMB signging on machines not yet running MIT KRB5 1.3.1. *

- Add better DEBUG() messages to ntlm_auth, warning administrators of
misconfigurations that prevent access to the privileged pipe.  This
should help reduce some of the 'it just doesn't work' issues.

- Fix data_blob_talloc() to behave the same way data_blob() does when
passed a NULL data pointer.  (just allocate)

REMEMBER to make clean after this commit - I have changed plenty of data structures...
(This used to be commit f3bbc87b0dac63426cda6fac7a295d3aad810ecc)

16 years agoinclude WWW-Authenticate field in 401 response for bad auth attempt; bug 629
Gerald Carter [Sat, 22 Nov 2003 06:16:01 +0000 (06:16 +0000)]
include WWW-Authenticate field in 401 response for bad auth attempt; bug 629
(This used to be commit 879d0f15ea260d61c56c5b841065ecb2f5ec26ca)

16 years agoadding a useful debug
Gerald Carter [Sat, 22 Nov 2003 06:15:28 +0000 (06:15 +0000)]
adding a useful debug
(This used to be commit e374ce779efaec001c1476e0710ceaa9c3b84e8d)

16 years agofix winbind ping call so that SWAT correctly determines if winbindd is running; bug 398
Gerald Carter [Sat, 22 Nov 2003 04:47:34 +0000 (04:47 +0000)]
fix winbind ping call so that SWAT correctly determines if winbindd is running; bug 398
(This used to be commit 04e37283f230b28f3019bfab3a71dde5e4ae4e23)

16 years agoEnsure that items in a list of strings containing whitespace
Gerald Carter [Sat, 22 Nov 2003 04:33:36 +0000 (04:33 +0000)]
Ensure that items in a list of strings containing whitespace
are written out surrounded by single quotes.  This means that
both double and single quotes are now used to surround
strings in smb.conf.  This is a slight change from the previous
behavior but needed or else things like

    printer admin = +ntadmin, 'VALE\Domain, Admin'

get written to smb.conf by SWAT.
(This used to be commit 5bf91c79d620e34ac71d72c80f74e47754d49dcb)

16 years agoFix for rename across filesystems. Noticed by Rainer Link <link@foo.fh-furtwangen...
Jeremy Allison [Fri, 21 Nov 2003 23:01:37 +0000 (23:01 +0000)]
Fix for rename across filesystems. Noticed by Rainer Link <link@foo.fh-furtwangen.de>.
(This used to be commit 598d9d3e5f612133e0528a1a8907745d715b61ed)

16 years agoFix Jerry's no-proto bug :-).
Jeremy Allison [Fri, 21 Nov 2003 19:20:07 +0000 (19:20 +0000)]
Fix Jerry's no-proto bug :-).
(This used to be commit 48153f7a07cc04b849a79778fdc3e76af6c6eb13)

16 years agomake sure we don't append the ldap suffix when writing out the ldap XXX suffix values...
Gerald Carter [Fri, 21 Nov 2003 19:11:48 +0000 (19:11 +0000)]
make sure we don't append the ldap suffix when writing out the ldap XXX suffix values in SWAT; based on tpot's original patch; bug 328
(This used to be commit 12a06dd9807ea3a10f8220d6e7c33b4b79ae25b4)

16 years agoUpdate WHATSNEW.txt with text from release branch
Alexander Bokovoy [Fri, 21 Nov 2003 10:54:33 +0000 (10:54 +0000)]
Update WHATSNEW.txt with text from release branch
(This used to be commit 56fc6962fb32de180a6b1af9259e0a7b580daeab)

16 years agoTypo fix.
Rafal Szczesniak [Thu, 20 Nov 2003 23:56:42 +0000 (23:56 +0000)]
Typo fix.
(This used to be commit 5054a1731e3bf3bec0687304af63fed475d5f864)

16 years agoLook at error before using it in debug statement.
Jeremy Allison [Wed, 19 Nov 2003 22:57:56 +0000 (22:57 +0000)]
Look at error before using it in debug statement.
(This used to be commit 69550332f33496b0a513914e2290fdb256bc2958)

16 years agoAdded useful information to debug lines.
Rafal Szczesniak [Wed, 19 Nov 2003 22:56:02 +0000 (22:56 +0000)]
Added useful information to debug lines.
Patch by metze.

(This used to be commit 2eef3c7bc182bb2c0c483190570ee1a297047ad2)

16 years agochanging versionb to pre4
Gerald Carter [Wed, 19 Nov 2003 18:33:19 +0000 (18:33 +0000)]
changing versionb to pre4
(This used to be commit 8c46576f64cc54abd3bc43312559b960af220b60)

16 years agoadded a wbtest program that shows how to access winbindd extended nss
Andrew Tridgell [Wed, 19 Nov 2003 08:14:09 +0000 (08:14 +0000)]
added a wbtest program that shows how to access winbindd extended nss
functionality directly from an application.

This is under a liberal license as we want application vendors to be
able to use the example code
(This used to be commit 8d848de45d75bf6ac69cb921e04abf36a66117c4)

16 years agoas discussed on irc, this is a small patch that allows a few more
Andrew Tridgell [Wed, 19 Nov 2003 08:11:14 +0000 (08:11 +0000)]
as discussed on irc, this is a small patch that allows a few more
winbind functions to be accessed via NSS. This provides a much cleaner
way for applications that need (for example) to provide name->sid
mappings to do this via NSS rather than having to know the winbindd
pipe protocol (as this might change).

This patch also adds a varient of the winbindd_getgroups() call called
winbindd_getusersids() that provides direct SID->SIDs listing of a
users supplementary groups. This is enough to allow non-Samba
applications to do ACL checking.

A test program for the new functionality will be committed shortly.

I also added the 'wbinfo --user-sids' option to expose the new
function in wbinfo.
(This used to be commit 702b35da0ac7c73aa5a6603f871d865565bbe278)

16 years agoGroup quotas patch from "Heinreichsberger, Helmut" <Helmut.Heinreichsberger@wincor...
Jeremy Allison [Wed, 19 Nov 2003 02:19:34 +0000 (02:19 +0000)]
Group quotas patch from "Heinreichsberger, Helmut" <Helmut.Heinreichsberger@wincor-nixdorf.com>
(This used to be commit 06c9e9163010a1035f448f76c4084228dc95334f)

16 years agoCorrect fix for checking of '$' name termination.
Jeremy Allison [Wed, 19 Nov 2003 00:18:45 +0000 (00:18 +0000)]
Correct fix for checking of '$' name termination.
(This used to be commit ec2339645283c9e489659a8892c317bb9f7610f0)

16 years agoUseful debug message. Patch by metze.
Rafal Szczesniak [Tue, 18 Nov 2003 19:15:29 +0000 (19:15 +0000)]
Useful debug message. Patch by metze.

(This used to be commit 8b06364b53ea01ec7a21f3fbe86afad02fe21dd8)

16 years agoRemove unneeded second open for filename ending in '.' now we know it's
Jeremy Allison [Tue, 18 Nov 2003 02:06:41 +0000 (02:06 +0000)]
Remove unneeded second open for filename ending in '.' now we know it's
a mangled name. Added const. Fix inspired by Andrew Bartlett ideas.
(This used to be commit 87eb336d659dfa5e92b495dd76a0f2e534931293)

16 years agoEnsure we mangle names ending in '.' in hash2 mangling method.
Jeremy Allison [Tue, 18 Nov 2003 01:47:27 +0000 (01:47 +0000)]
Ensure we mangle names ending in '.' in hash2 mangling method.
(This used to be commit fc2af591f5a2b08caa7389150c8cc5e298bd0ed4)

16 years agoFix from Andrew Bartlett to fix up the munged-dial problem.
Jeremy Allison [Mon, 17 Nov 2003 22:07:47 +0000 (22:07 +0000)]
Fix from Andrew Bartlett to fix up the munged-dial problem.
(This used to be commit 703b1b76e25fc83b3b84767c0e1b64c97c21bf09)

16 years agoThis fixes a bug when establishing trust against a german W2k3 AD server. In
Volker Lendecke [Mon, 17 Nov 2003 18:00:43 +0000 (18:00 +0000)]
This fixes a bug when establishing trust against a german W2k3 AD server. In
the bind response to WKSSVC it does not send \PIPE\ntsvcs as NT4 (did not
check w2k) but \PIPE\wkssvc. I'm not sure whether we should make this check at
all, so making it a bit more liberal should hopefully not really hurt.

(This used to be commit 029dcb351bcfab70ed0afa4acf4bd64316bfd757)

16 years ago* make sure we only enumerate group mapping entries
Gerald Carter [Mon, 17 Nov 2003 16:06:10 +0000 (16:06 +0000)]
* make sure we only enumerate group mapping entries
  (not /etc/group) even when doing local aliases

* remove "hide local users" parameter; we have this
  behavior built into 3.0
(This used to be commit a7685a069766ac720f0b26fe01b0e17fc388fca3)

16 years agoupdates from Buchan
Gerald Carter [Mon, 17 Nov 2003 14:15:14 +0000 (14:15 +0000)]
updates from Buchan
(This used to be commit bd0813e609759758b77fd130e304ccaca33f94c6)

16 years agofirst draft of release notes for 3.0.1pre3
Gerald Carter [Fri, 14 Nov 2003 03:32:21 +0000 (03:32 +0000)]
first draft of release notes for 3.0.1pre3
(This used to be commit d4cbd00dfe0968cb5251434a9e2989affddef853)

16 years agofix more memory leaks in the LDAP backend code; patches from metze
Gerald Carter [Fri, 14 Nov 2003 03:28:03 +0000 (03:28 +0000)]
fix more memory leaks in the LDAP backend code; patches from metze
(This used to be commit e079c8842a24ff4f50483bea8ca6b11db4b2dc99)

16 years ago* Fix from SATOH Fumiyasu for bug 660 (failing to view print
Gerald Carter [Thu, 13 Nov 2003 20:15:17 +0000 (20:15 +0000)]
* Fix from SATOH Fumiyasu for bug 660 (failing to view print
  jobs) by only enforce the 'max reported print jobs' parameter
  when it is non-zero.

* Fixed bug 338 by making sure that data values are written
  out when we are marshalling an EnumPrinterDataEx() reply.
  This probably fixes other bugs reported against point-n-print
  feature in 3.0.0
(This used to be commit fd98af75d655449a677360f6991da5caabc88b4d)

16 years agoMore casty-foo ...
Richard Sharpe [Thu, 13 Nov 2003 17:35:00 +0000 (17:35 +0000)]
More casty-foo ...
(This used to be commit 00d5136ea0456115c25bf3c791616ef4bbbb8fc1)

16 years agoSquelch some warnings with more casty-foo.
Richard Sharpe [Thu, 13 Nov 2003 17:30:25 +0000 (17:30 +0000)]
Squelch some warnings with more casty-foo.
(This used to be commit d165a49d860443741e57458b8a819c6d54824fc5)

16 years agoFix a couple of warnings with casts.
Richard Sharpe [Thu, 13 Nov 2003 17:27:21 +0000 (17:27 +0000)]
Fix a couple of warnings with casts.
(This used to be commit 58d7a51c5762a444aae6a795a3703269134423d7)

16 years agoshow locked files for -u <user>; bug 590
Gerald Carter [Wed, 12 Nov 2003 22:35:50 +0000 (22:35 +0000)]
show locked files for -u <user>; bug 590
(This used to be commit d72d77c42741714f2e32d0e24e706929242f1c62)

16 years agoAdd testacl.c ... from Derrell Lipman.
Richard Sharpe [Wed, 12 Nov 2003 21:46:39 +0000 (21:46 +0000)]
Add testacl.c ... from Derrell Lipman.
(This used to be commit af42af75a45d6e6538009694704e11eb83c88457)

16 years agoOmit html documentation tree because it has been moved to the separate
Rafal Szczesniak [Wed, 12 Nov 2003 13:02:25 +0000 (13:02 +0000)]
Omit html documentation tree because it has been moved to the separate
module. Install though, in case one recreates the tree as it was before.

(This used to be commit d6857d191ca5aa24f791880e517b0e8db3d587eb)

16 years agoa small include file rearrangement that doesn't affect normal
Andrew Tridgell [Wed, 12 Nov 2003 01:51:10 +0000 (01:51 +0000)]
a small include file rearrangement that doesn't affect normal
compilation, but that allows Samba3 to take advantage of pre-compiled
headers in gcc if available.
(This used to be commit b3e024ce1da7c7e24fcacd8a2964dd2e4562ba39)

16 years agoadded support for "make pch" to build a precompiled header. Note that
Andrew Tridgell [Wed, 12 Nov 2003 01:01:47 +0000 (01:01 +0000)]
added support for "make pch" to build a precompiled header. Note that
this is not called by default and I don't think it should be - I think
the programmer should specifically ask for pch generation when they
want it.
(This used to be commit ef01aedfb4e97af9283b0d54dd362aad809016af)

16 years agofix crash bug due to empyrt munged dial string; patch from metze
Gerald Carter [Tue, 11 Nov 2003 19:22:00 +0000 (19:22 +0000)]
fix crash bug due to empyrt munged dial string; patch from metze
(This used to be commit ccd5665a65de6ccfdb9a5f490be1a7b5de486e2a)

16 years agoPatch from Andrew Bartlett <abartlet@samba.org> for security=server core
Jeremy Allison [Mon, 10 Nov 2003 19:33:42 +0000 (19:33 +0000)]
Patch from Andrew Bartlett <abartlet@samba.org> for security=server core
dump if server goes away.
(This used to be commit e61324cc6a222ca714530827068104f7a74c0911)

16 years agoFix a problem with configure on *BSD systems. Make sure we add -liconv etc
Richard Sharpe [Mon, 10 Nov 2003 05:34:51 +0000 (05:34 +0000)]
Fix a problem with configure on *BSD systems. Make sure we add -liconv etc
to LDFLAGS. One of the problems with configure/autoconf is that there seems
to be no separation of LDLFAGS etc in configure from the LDFLAGS it is
building for the Makefile.
(This used to be commit 63d7698208a0fc4dfd2e3158f5ccbb1b6d9a6baf)

16 years agoSkip over the winbind separator when looking up a user.
Volker Lendecke [Sun, 9 Nov 2003 17:23:57 +0000 (17:23 +0000)]
Skip over the winbind separator when looking up a user.

(This used to be commit 6b457d0c5c1a18b6e09c2c4cc489ce791aac3c6b)

16 years agoAdd new fields bad_password_count and logon_count
Jelmer Vernooij [Sun, 9 Nov 2003 14:09:27 +0000 (14:09 +0000)]
Add new fields bad_password_count and logon_count
(This used to be commit 58c21bc0d1e9a39e64ce7b9efd637dc776c06029)

16 years agolast update to WHATSNEW
Gerald Carter [Fri, 7 Nov 2003 23:14:09 +0000 (23:14 +0000)]
last update to WHATSNEW
(This used to be commit ad5588e3062f9f9a10e7102062805cae1cc50385)

16 years ago* only install swat html files once
Gerald Carter [Fri, 7 Nov 2003 23:04:06 +0000 (23:04 +0000)]
* only install swat html files once
* revert the change that prevent the guest
  account from being added to a passdb backend
  since it broke the build farm.
* apply patch from Alex Deiter to fix the
  "smbldap_open: cannot access when not root
  error" messages when looking up group
  information (bug 281)
(This used to be commit 9b8bf6a950186bd95abe952af4a7d35829b34ff8)

16 years agoHandle munged dial string. Patch from Aur?lien Degr?mont <adegremont@idealx.com>with...
Jeremy Allison [Fri, 7 Nov 2003 18:32:23 +0000 (18:32 +0000)]
Handle munged dial string. Patch from Aur?lien Degr?mont <adegremont@idealx.com>with memory leak fixes by me.
(This used to be commit e591854eda8568ed1a4ad6b9de64e523c02b4392)

16 years agoworking on release notes for 3.0.1pre2
Gerald Carter [Fri, 7 Nov 2003 17:33:37 +0000 (17:33 +0000)]
working on release notes for 3.0.1pre2
(This used to be commit d45441bb4f893e76c25aca1d40f23e0f0d347b51)

16 years agoSet vendor name.
Tim Potter [Fri, 7 Nov 2003 16:55:40 +0000 (16:55 +0000)]
Set vendor name.
(This used to be commit 9d8cacc4e6d6336455732286e5e6f90ac3f4ec49)

16 years agoSet vendor string.
Tim Potter [Fri, 7 Nov 2003 16:54:57 +0000 (16:54 +0000)]
Set vendor string.
(This used to be commit 0b28bed5058947ff95fdb64f4beb784c90d02afc)

16 years agoAdd vendor name to rpm preamble.
Tim Potter [Fri, 7 Nov 2003 16:53:25 +0000 (16:53 +0000)]
Add vendor name to rpm preamble.
(This used to be commit e68189ba863596ea92dc4fa199457bd93d322888)

16 years agofix for bug 680 (heads up). This gist is to map the
Gerald Carter [Fri, 7 Nov 2003 14:39:47 +0000 (14:39 +0000)]
fix for bug 680 (heads up).  This gist is to map the
UNIX entity foo to DOMAIN\foo instead of SERVER\foo
on members of a Samba domain when all UNIX accounts
are shared via NIS, et. al.

  * allow winbindd to match local accounts to domain SID
    when 'winbind trusted domains only = yes'

  * remove code in idmap_ldap that searches the user
    suffix and group suffix.  It's not needed and
    provides inconsistent functionality from the tdb backend.

This has been tested.  I'm still waiting on some more feedback
but This needs to be in 3.0.1pre2 for widespread use.
(This used to be commit ee272414e9965d7d550ba91d4e83997134dd51e6)

16 years agodon't allow setting of the guest account
Gerald Carter [Fri, 7 Nov 2003 14:32:25 +0000 (14:32 +0000)]
don't allow setting of the guest account
(This used to be commit e0eea3639425aa6f4b621cce6b33df9e9c67ba6d)

16 years agoImplement %i-Macro for the locally used IP address. With this you can again
Volker Lendecke [Fri, 7 Nov 2003 10:11:48 +0000 (10:11 +0000)]
Implement %i-Macro for the locally used IP address. With this you can again
have virtual hosts with different configurations on a single smbd even on port

(This used to be commit 3a7c8c4f0e7fcfc2e20e1ad5e4b8e3c215ef1f0d)

16 years agoSimple rename of get_socket_addr to get_peer_addr and get_socket_name to
Volker Lendecke [Fri, 7 Nov 2003 09:03:02 +0000 (09:03 +0000)]
Simple rename of get_socket_addr to get_peer_addr and get_socket_name to
get_peer_name. This is to get closer to the getsockname/getpeername system

Next step will be the %i macro for the local IP address. I still want to play
%L-games in times of port 445.

(This used to be commit d7162122eaf5d897e5de51604e431bfbaa20e905)

16 years agoI agree with vl's #if 0 here, and am not quite sure what I was
Andrew Bartlett [Fri, 7 Nov 2003 08:36:29 +0000 (08:36 +0000)]
I agree with vl's #if 0 here, and am not quite sure what I was
thinking with regard to the original code.

Let's keep samba simple, and just remove it.

Andrew Bartlett
(This used to be commit 156cf8bede52e1d33be980fd8841367253a60b9e)

16 years agoRemove compleatly wrong comments. (There were correct, 2 years ago...)
Andrew Bartlett [Fri, 7 Nov 2003 08:34:43 +0000 (08:34 +0000)]
Remove compleatly wrong comments.  (There were correct, 2 years ago...)

Andrew Bartlett
(This used to be commit 256b85802e5820847fbad4305fcb0f5da2e51975)

16 years agoAdd newline to debug message
Andrew Bartlett [Fri, 7 Nov 2003 08:29:29 +0000 (08:29 +0000)]
Add newline to debug message
(This used to be commit e0868b978ec5debf6b91aeeb85aa1f404d07a34b)

16 years agoA fix to allow configure to find iconv on a number of systems including those
Richard Sharpe [Thu, 6 Nov 2003 23:37:58 +0000 (23:37 +0000)]
A fix to allow configure to find iconv on a number of systems including those
that don't have such support in glibc.
(This used to be commit de6d5f1d1025bec8991944060df50eb2602f7221)

16 years agoFinal round of printf warnings fixes for the moment.
Tim Potter [Thu, 6 Nov 2003 22:11:08 +0000 (22:11 +0000)]
Final round of printf warnings fixes for the moment.
(This used to be commit 0519a7022b4979c0e8ddd4907f4b858a59299c06)

16 years agoFix bug #471. (const needed in lp_set_name_resolve_order).
Jeremy Allison [Thu, 6 Nov 2003 22:07:12 +0000 (22:07 +0000)]
Fix bug #471. (const needed in lp_set_name_resolve_order).
(This used to be commit 3c19ac5f1c9e393780e57028808871dfdc77b170)

16 years agoIgnore tallocdump binary. Previous commit was printf warning fixes and an
Tim Potter [Thu, 6 Nov 2003 22:02:36 +0000 (22:02 +0000)]
Ignore tallocdump binary.  Previous commit was printf warning fixes and an
accidental commit of some other stuff I was working on.
(This used to be commit cfccf00816d873f6d7b298e15536ec423c2cfe03)

16 years agoUndo accidentally committed stuff.
Tim Potter [Thu, 6 Nov 2003 21:55:48 +0000 (21:55 +0000)]
Undo accidentally committed stuff.
(This used to be commit 0a79519bc4b92b2f6e88b921d5ede761cc8ee2af)

16 years agoIgnore tallocdump binary.
Tim Potter [Thu, 6 Nov 2003 21:51:08 +0000 (21:51 +0000)]
Ignore tallocdump binary.
(This used to be commit addeb1c6c90faf5842db4a75f8db8d2325905b03)

16 years agorun krb5 logins through the username map if the winbindd lookup fails; bug 698
Gerald Carter [Thu, 6 Nov 2003 17:28:44 +0000 (17:28 +0000)]
run krb5 logins through the username map if the winbindd lookup fails; bug 698
(This used to be commit efe257bce2020e94d00946a27e2e586c82a1480f)

16 years agopatch from MORIYAMA Masayuki to save LDFLAGS during iconv detection; bug 570
Gerald Carter [Thu, 6 Nov 2003 17:23:47 +0000 (17:23 +0000)]
patch from MORIYAMA Masayuki to save LDFLAGS during iconv detection; bug 570
(This used to be commit 486f495ea7decb4abfdb4751ae124b036f3e5d16)

16 years agoUndo last commit to get things building again.
Tim Potter [Thu, 6 Nov 2003 16:58:33 +0000 (16:58 +0000)]
Undo last commit to get things building again.
(This used to be commit d3af6b443d9f52b007a1c022908d767edf238b9e)

16 years agobug 624; make sure to set the GUEST SID rather than using the PDB_DEFAULT flag
Gerald Carter [Thu, 6 Nov 2003 05:46:06 +0000 (05:46 +0000)]
bug 624; make sure to set the GUEST SID rather than using the PDB_DEFAULT flag
(This used to be commit ccc7634b1c4b7813a1d09af93572b1209e72dffb)

16 years agoApply the patch to fix iconv detection for FreeBSD to the Samba 3.0.0 branch
Richard Sharpe [Thu, 6 Nov 2003 05:44:55 +0000 (05:44 +0000)]
Apply the patch to fix iconv detection for FreeBSD to the Samba 3.0.0 branch
as well.
(This used to be commit 44be80e4883c8578b98ec02ac422c97229b063c5)

16 years agoCompile tdbdump by default.
Volker Lendecke [Wed, 5 Nov 2003 17:38:15 +0000 (17:38 +0000)]
Compile tdbdump by default.

(This used to be commit b628ba0fc00585cbe1443e0b146ee673f25bc50f)

16 years agoPatch from James Henstridge to allow rpcclient adddriver command to specify
Tim Potter [Wed, 5 Nov 2003 16:40:13 +0000 (16:40 +0000)]
Patch from James Henstridge to allow rpcclient adddriver command to specify
printer driver version.  Closes bug #514.
(This used to be commit c5865e3dfe0166a4714129a3ddfe1c39218e28f0)

16 years agomake sure that we expand %H (from vl); bug 612
Gerald Carter [Wed, 5 Nov 2003 04:34:31 +0000 (04:34 +0000)]
make sure that we expand %H (from vl); bug  612
(This used to be commit a77f5924304d03d8033d1ef5f6526373f5b67aa3)

16 years agoadded note about stripping comments from LDIF; bug 642
Gerald Carter [Wed, 5 Nov 2003 04:17:21 +0000 (04:17 +0000)]
added note about stripping comments from LDIF; bug 642
(This used to be commit 3f67b2bbfdbedc76d7265fc5333d5f71577d9c7b)

16 years agoFix coredump in cli_get_backup_list.
Jeremy Allison [Wed, 5 Nov 2003 00:17:14 +0000 (00:17 +0000)]
Fix coredump in cli_get_backup_list.
(This used to be commit 29413db303d30d28c2fb0cc6e6e963e725ad4101)

16 years agoFix debug message warning.
Jeremy Allison [Wed, 5 Nov 2003 00:16:01 +0000 (00:16 +0000)]
Fix debug message warning.
(This used to be commit 154793981a1b2aea2703ef4da4764a322bf90ca0)

16 years agoFix for bug #771. Fix packet length for browse list reply.
Jeremy Allison [Wed, 5 Nov 2003 00:12:49 +0000 (00:12 +0000)]
Fix for bug #771. Fix packet length for browse list reply.
(This used to be commit d085c94dacffbe8199e83315340e4f60d1f0b9a5)

16 years agoFix crash bug in smbclient completion. Closes bug #659.
Tim Potter [Tue, 4 Nov 2003 22:38:58 +0000 (22:38 +0000)]
Fix crash bug in smbclient completion.  Closes bug #659.
(This used to be commit 4480058d85ebe9175c4720c18100b459877dbd07)

16 years agoAdd ldaplibs to pdbedit link line. Fixes bug #651.
Tim Potter [Tue, 4 Nov 2003 21:17:22 +0000 (21:17 +0000)]
Add ldaplibs to pdbedit link line.  Fixes bug #651.
(This used to be commit e306c962685c8b17df520aebccf6f0d8e3d7ce3c)

16 years agoUse the actual size of the buffer in strftime instead of a made up value
Tim Potter [Tue, 4 Nov 2003 20:09:44 +0000 (20:09 +0000)]
Use the actual size of the buffer in strftime instead of a made up value
which just happens to be less than sizeof(fstring).  Closes #713.
(This used to be commit 761e13da4ef8294f0b131ad7f672d023b0d222f6)

16 years agoFix typo in debug statement.
Tim Potter [Tue, 4 Nov 2003 19:53:37 +0000 (19:53 +0000)]
Fix typo in debug statement.
(This used to be commit 66e5043553939be2b124bec8581f08b01fdf9c1e)

16 years agoGenerate 64-bit clean printf's for build options.
Tim Potter [Tue, 4 Nov 2003 19:47:40 +0000 (19:47 +0000)]
Generate 64-bit clean printf's for build options.
(This used to be commit 1814c29b7d5c2ab25f209fba0afb5c6d175a87d1)

16 years agoFix for bug #703, try lowercase netgroups lookups.
Jeremy Allison [Tue, 4 Nov 2003 18:24:33 +0000 (18:24 +0000)]
Fix for bug #703, try lowercase netgroups lookups.
(This used to be commit 8b06385e008a9433fa6efb941b997f7d6b182a65)

16 years agoFix missing bracket in quota quote - my fault.
Tim Potter [Tue, 4 Nov 2003 14:59:27 +0000 (14:59 +0000)]
Fix missing bracket in quota quote - my fault.
(This used to be commit fc30b6b5473124bad9c2c30b604bc21c9de258c1)

16 years agoUse a static string instead of malloced one in winbind_{off,on}() utility
Tim Potter [Tue, 4 Nov 2003 05:49:23 +0000 (05:49 +0000)]
Use a static string instead of malloced one in winbind_{off,on}() utility
(This used to be commit 7710232ba21305a1e3c9523ace82a5a419526b50)

16 years agoFix for winbindd on HPUX from albert chin (china@thewrittenword.com)
Jeremy Allison [Mon, 3 Nov 2003 21:05:47 +0000 (21:05 +0000)]
Fix for winbindd on HPUX from albert chin (china@thewrittenword.com)
(This used to be commit 119a89246bf84cb98b76cf3777c039fa8eb644f2)

16 years agoremoving #include <compat.h> in hopes to avoid problems with apache header files...
Gerald Carter [Mon, 3 Nov 2003 19:22:32 +0000 (19:22 +0000)]
removing #include <compat.h> in hopes to avoid problems with apache header files; will watch the build farm on this to make sure things don't blow up
(This used to be commit e92583cecd79adea25caedd1599ac8f36733a923)

16 years agoAC_CHECK_MEMBER seems to have problems for some versions of autoconf, at least
Volker Lendecke [Mon, 3 Nov 2003 18:11:00 +0000 (18:11 +0000)]
AC_CHECK_MEMBER seems to have problems for some versions of autoconf, at least
autoconf-2.53 on SLES8 does not correctly find the keyblock.

(This used to be commit c4f36a250a5126dac0d2f6d395d75a2437c8e56d)

16 years agoFix more 64-bit printf warnings.
Tim Potter [Mon, 3 Nov 2003 14:34:25 +0000 (14:34 +0000)]
Fix more 64-bit printf warnings.
(This used to be commit 23443e3aa079710221557e18158d0ddb8ff48a36)

16 years agoFix some uninitialised variable warnings.
Tim Potter [Mon, 3 Nov 2003 14:21:10 +0000 (14:21 +0000)]
Fix some uninitialised variable warnings.
(This used to be commit 68945027b5dc6b5e1aee13e4df4d11a34e42a3a9)

16 years agoPrintf fixes for 64-bit size_t.
Tim Potter [Sun, 2 Nov 2003 17:10:12 +0000 (17:10 +0000)]
Printf fixes for 64-bit size_t.
(This used to be commit 8e2c543ebf65e24e73433f69b1c281e1558e9080)

16 years agoTidy up calls to uname so as not to produce output on stderr if
Tim Potter [Sun, 2 Nov 2003 16:54:21 +0000 (16:54 +0000)]
Tidy up calls to uname so as not to produce output on stderr if
the command line argument being called isn't valid.
(This used to be commit d43922eade02d1826a108b45607f5776266fd05b)

16 years agoUse putenv() instead of setenv() in the winbind_{off,on}() functions. Some
Tim Potter [Sun, 2 Nov 2003 16:22:28 +0000 (16:22 +0000)]
Use putenv() instead of setenv() in the winbind_{off,on}() functions.  Some
platforms don't have setenv().
(This used to be commit a8b487c4cb5d181e59755f49063512b2729bccb5)

16 years agoAdd prototype for smbc_remove_unused_server() to fix compiler warning.
Tim Potter [Sun, 2 Nov 2003 14:15:36 +0000 (14:15 +0000)]
Add prototype for smbc_remove_unused_server() to fix compiler warning.
Bug #706.
(This used to be commit eaf69b1ae7883573830244664cb0a81661541d92)