Jelmer Vernooij [Thu, 1 Jan 2009 02:30:54 +0000 (03:30 +0100)]
make: Search for c tags in ../ as well.
Jeremy Allison [Thu, 1 Jan 2009 02:06:57 +0000 (18:06 -0800)]
Fix all warnings in source3 with gcc4.3.
Jeremy.
Jeremy Allison [Thu, 1 Jan 2009 00:30:11 +0000 (16:30 -0800)]
Fix more asprintf and "ignoring return code" warnings from gcc 4.3.
Jeremy.
Volker Lendecke [Thu, 25 Dec 2008 13:37:33 +0000 (14:37 +0100)]
Replace a static variable and alarm() calls by using sys_select()
Günther, please check!
Volker Lendecke [Thu, 25 Dec 2008 13:29:39 +0000 (14:29 +0100)]
Fix some nonempty blank lines
Volker Lendecke [Thu, 25 Dec 2008 13:26:17 +0000 (14:26 +0100)]
Make a CONST_DISCARD unnecessary by applying some const
Derrell, please check!
Volker Lendecke [Sat, 20 Dec 2008 09:42:02 +0000 (10:42 +0100)]
Replace "goto again" by "return NT_STATUS_RETRY" in receive_message_or_smb
This gives lower-level routines the chance to indicate a retry condition
Volker Lendecke [Thu, 25 Dec 2008 12:44:11 +0000 (13:44 +0100)]
Disable the use of splice(2)
On a debian lenny installation with a kernel that calls itself 2.6.28, I could
repeatably block smbd using splice. According to the output of netstat, the
recvq of the TCP connection was full and at the same time according to strace
smbd was stuck in a splice syscall trying to read from that TCP connection. We
can not protect ourselves from this condition, as nobody will ever notify us
that something is broken. So sadly we can't use splice yet at all. Maybe in
2.6.29...
Volker Lendecke [Tue, 23 Dec 2008 21:45:03 +0000 (22:45 +0100)]
Try to fix recvfile using splice on Linux
According to the splice(2) manpage, one of the file descriptors *must* be a
pipe. With this patch I could successfully run splice(2) on a debian lenny
installation.
Jeremy, please check!
Volker Lendecke [Wed, 24 Dec 2008 12:52:20 +0000 (13:52 +0100)]
Fix a "nested extern" warning
Volker Lendecke [Wed, 24 Dec 2008 12:51:47 +0000 (13:51 +0100)]
Rename parent_dirname_talloc() to parent_dirname()
Volker Lendecke [Wed, 24 Dec 2008 12:47:41 +0000 (13:47 +0100)]
Remove unused function parent_dirname
Volker Lendecke [Wed, 24 Dec 2008 12:46:22 +0000 (13:46 +0100)]
Use parent_dirname_talloc instead of parent_dirname in smb_unix_mknod
Volker Lendecke [Wed, 24 Dec 2008 12:44:44 +0000 (13:44 +0100)]
Use parent_dirname_talloc instead of parent_dirname in copy_internals
Volker Lendecke [Wed, 24 Dec 2008 12:41:42 +0000 (13:41 +0100)]
Use parent_dirname_talloc instead of parent_dirname in vfswrap_mkdir
Volker Lendecke [Wed, 24 Dec 2008 12:18:35 +0000 (13:18 +0100)]
Make use of TALLOC_MEMDUP in parent_dirname_talloc()
Volker Lendecke [Wed, 24 Dec 2008 12:05:25 +0000 (13:05 +0100)]
Remove unused function get_numlist()
Volker Lendecke [Wed, 31 Dec 2008 17:37:39 +0000 (18:37 +0100)]
recvfile can't be used for printing so far
Stefan Metzmacher [Mon, 29 Dec 2008 15:31:57 +0000 (16:31 +0100)]
s3:winbindd: we don't need to call messaging_reinit() twice
reinit_after_fork() already calls messaging_reinit()
metze
Volker Lendecke [Wed, 31 Dec 2008 09:49:57 +0000 (10:49 +0100)]
Enable individual smbtorture_s3 subtests in make test
Volker Lendecke [Tue, 30 Dec 2008 21:49:01 +0000 (22:49 +0100)]
Fix an ancient uninitialized variable read
The callers of open_file_ntcreate expect *psbuf to be filled correctly
Tim Prouty [Wed, 31 Dec 2008 02:46:53 +0000 (18:46 -0800)]
s3 build: Revert previous patch to fix the build
888524623d179ceb4d540f5ac0f3b013d3ce5735 broke the build. I'm
reverting it for the short term, while I work on a better fix.
Jeremy Allison [Wed, 31 Dec 2008 02:24:39 +0000 (18:24 -0800)]
Fix more "ignore return value" warnings from gcc 4.3.
Jeremy
Tim Prouty [Wed, 31 Dec 2008 00:02:09 +0000 (16:02 -0800)]
librpc: Re-run make idl-full from source3
Tim Prouty [Tue, 30 Dec 2008 21:47:58 +0000 (13:47 -0800)]
pidl: Fix a const build warning in the samba3 merged build
The warning:
../librpc/gen_ndr/ndr_spoolss.c: In function ‘ndr_pull_spoolss_EnumPrinterData’:
../librpc/gen_ndr/ndr_spoolss.c:14792: warning: passing argument 1 of ‘memset’ discards qualifiers from pointer target type
In some case the pidl generated code needs to memset a const struct
field. This causes the above warning. This patch discardeds the const
in this case. I'm open to a more elegant fix, but this eliminates the
warning and should be relatively safe.
Tim Prouty [Tue, 30 Dec 2008 21:41:18 +0000 (13:41 -0800)]
s3/s4: Move CONST_DISCARD into lib/util so it's available from s3 and s4
Tim Prouty [Tue, 30 Dec 2008 21:45:29 +0000 (13:45 -0800)]
s3 build: Remove redundant #defines that are in idl generated headers
This fixes a series of samba3 build warnings in the merged build:
'error: "X" redefined', where X is one of the redundant #defines
Tim Prouty [Tue, 30 Dec 2008 22:40:33 +0000 (14:40 -0800)]
s4: simplify some overly-complicated logic
Tim Prouty [Tue, 30 Dec 2008 20:53:34 +0000 (12:53 -0800)]
s3 build: Fix warning
Stefan Metzmacher [Thu, 18 Dec 2008 14:02:42 +0000 (15:02 +0100)]
s3:cluster: register the client connection via CTDB_CONTROL_TCP_ADD
This means we correctly pass IPv6 addresses too.
(CTDB_CONTROL_TCP_CLIENT was IPv4 only)
metze
Volker Lendecke [Tue, 30 Dec 2008 14:47:06 +0000 (15:47 +0100)]
Fix a memory leak in cups_pull_comment_location
We allocated "request" with ippNew, so we also should ippDelete it.
Volker Lendecke [Tue, 30 Dec 2008 13:05:26 +0000 (14:05 +0100)]
Fix a spinning smbd when printing
Without this, we end up adding more than one timed event. In the event handler
print_notify_event_send_messages() only one event will be deleted, all others
will fire indefinitely.
Volker Lendecke [Mon, 29 Dec 2008 21:07:56 +0000 (22:07 +0100)]
Print the vuid in BENCH-SESSSETUP
Volker Lendecke [Mon, 29 Dec 2008 21:06:08 +0000 (22:06 +0100)]
Second part of the bugfix for #5933
Incrementing the next vuid did not correctly overflow
Now we survive BENCH-SESSSETUP with -o 100000. Takes a while though :-)
Thanks a lot to Ofer Tal <otsmb@shmoop.org> for reporting #5933
Volker Lendecke [Mon, 29 Dec 2008 21:01:57 +0000 (22:01 +0100)]
First part of bugfix for #5933
Ofer Tal <otsmb@shmoop.org> fully correctly noted that we're incrementing
num_validated_vuids twice per session setup, but decrement it only once.
Looking at sesssetup.c we always call register_initial_vuid() before
register_existing_vuid(), so there's no point in incrementing it in
register_existing_vuid().
Jeremy, please check!
Volker Lendecke [Mon, 29 Dec 2008 20:07:41 +0000 (21:07 +0100)]
Move a comment to its place
Volker Lendecke [Mon, 29 Dec 2008 20:03:15 +0000 (21:03 +0100)]
Simplify invalidate_vuid slightly
get_valid_user_struct_internal() checks for UID_FIELD_INVALID itself
Volker Lendecke [Mon, 29 Dec 2008 20:01:13 +0000 (21:01 +0100)]
Simplify is_partial_auth_vuid slightly
Volker Lendecke [Mon, 29 Dec 2008 18:50:39 +0000 (19:50 +0100)]
Simplify invalidate_all_vuids() slightly
invalidate_vuid takes care of removing the user_struct from validated_users
Stefan Metzmacher [Tue, 30 Dec 2008 09:09:59 +0000 (10:09 +0100)]
Fix the merged build
metze
Stefan Metzmacher [Tue, 30 Dec 2008 07:58:52 +0000 (08:58 +0100)]
lib/tevent: fix standalone make distclean realdistclean
Bug report by Brad Hards <bradh@frogmouth.net>.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 20:07:11 +0000 (21:07 +0100)]
pidl: don't generate invalid C code
When we don't know how to handle a type for the python bindings,
we should not generate invalid C code.
Jelmer: please fix do the full fix for this.
metze
Stefan Metzmacher [Mon, 15 Dec 2008 18:28:27 +0000 (19:28 +0100)]
s3:pdb_tdb: store the next rid counter in passdb.tdb instead of winbind_idmap.tdb
This upgrades the TDBSAM_VERSION to 4 and SAMU_BUFFER_V4.
metze
Stefan Metzmacher [Tue, 16 Dec 2008 10:51:14 +0000 (11:51 +0100)]
s3:passdb: add SAMU_BUFFER_V4 with no changes
The upgrade is required because of the followin TDBSAM_VERSION
upgrade.
metze
Stefan Metzmacher [Mon, 15 Dec 2008 17:46:37 +0000 (18:46 +0100)]
s3:passdb: make marshalling struct samu from and to a buffer more generic
This marshalling isn't specific to tdbsam and it's
ugly to have the related functions in two different files.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 19:55:02 +0000 (20:55 +0100)]
s4:cluster: fix dependency to TDB_WRAP
metze
Stefan Metzmacher [Mon, 29 Dec 2008 19:24:57 +0000 (20:24 +0100)]
s4:lib/tevent: rename structs
list=""
list="$list event_context:tevent_context"
list="$list fd_event:tevent_fd"
list="$list timed_event:tevent_timer"
for s in $list; do
o=`echo $s | cut -d ':' -f1`
n=`echo $s | cut -d ':' -f2`
r=`git grep "struct $o" |cut -d ':' -f1 |sort -u`
files=`echo "$r" | grep -v source3 | grep -v nsswitch | grep -v packaging4`
for f in $files; do
cat $f | sed -e "s/struct $o/struct $n/g" > $f.tmp
mv $f.tmp $f
done
done
metze
Stefan Metzmacher [Mon, 29 Dec 2008 16:48:35 +0000 (17:48 +0100)]
s4:pvfs_aio: use tevent
metze
Stefan Metzmacher [Mon, 29 Dec 2008 16:33:51 +0000 (17:33 +0100)]
s4:sys_lease_linux: use tevent
metze
Volker Lendecke [Mon, 29 Dec 2008 16:08:38 +0000 (17:08 +0100)]
Fix SESSSETUP_BENCH torture test for long runtimes
deadtime hits without any files open. To enable long runtimes, open a file with
delete_on_close set.
Stefan Metzmacher [Mon, 29 Dec 2008 10:02:32 +0000 (11:02 +0100)]
s4:cluster: remove old/broken ctdb code
We don't need a full copy of ctdb...
If we want to readd cluster support,
we should just use a ctdb client library.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 10:24:05 +0000 (11:24 +0100)]
s4: remove unused dbwrap code
If we readd this later, we should share the code with
samba3 and make it async/non-blocking.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 10:52:53 +0000 (11:52 +0100)]
s4: Revert "r24284: change brlock_tdb.c to use the dbwrap API. This actually makes the"
This reverts commit
4792285282e2ec78ccb0ebc3cac6465d1d26ef10.
Conflicts:
source4/ntvfs/common/brlock_tdb.c
source4/ntvfs/common/config.mk
Volker Lendecke [Mon, 22 Dec 2008 21:42:44 +0000 (22:42 +0100)]
Add code to test write_data_iov a bit
Volker Lendecke [Mon, 22 Dec 2008 21:32:12 +0000 (22:32 +0100)]
Attempt to fix bug 5953: Make cli_send_smb_direct_writeX use writev
It seems there are SMB servers around which can't cope with the write header
being sent in a packet of its own. With writev we keep the advantage of direct
writes, giving the kernel the chance to coalesce the write calls.
Volker Lendecke [Mon, 22 Dec 2008 21:17:59 +0000 (22:17 +0100)]
Make write_data use write_data_iov
Volker Lendecke [Mon, 22 Dec 2008 21:17:28 +0000 (22:17 +0100)]
Add write_data_iov
Volker Lendecke [Sun, 21 Dec 2008 22:22:30 +0000 (23:22 +0100)]
Add sys_writev
Kai Blin [Sun, 28 Dec 2008 11:04:40 +0000 (12:04 +0100)]
s4 winbind: Copy SID to avoid "discard const" warning
Kai Blin [Fri, 26 Dec 2008 11:45:50 +0000 (12:45 +0100)]
s4 winbind: Add support for WINBINDD_GETGRGID call
Kai Blin [Fri, 26 Dec 2008 10:32:09 +0000 (11:32 +0100)]
s4 libnet: Add support for groupinfo by sid lookup
Kai Blin [Fri, 26 Dec 2008 10:08:13 +0000 (11:08 +0100)]
s4 winbind: Fix typos in debug output
Kai Blin [Fri, 26 Dec 2008 10:04:01 +0000 (11:04 +0100)]
wbinfo4: Add --gid-info option
Kai Blin [Fri, 26 Dec 2008 10:02:02 +0000 (11:02 +0100)]
wbinfo: Add --gid-info option.
Kai Blin [Fri, 26 Dec 2008 09:36:29 +0000 (10:36 +0100)]
s4 winbind: Add implementation for WINBINDD_GETGRNAM
Kai Blin [Fri, 26 Dec 2008 09:35:00 +0000 (10:35 +0100)]
s4 winbind: Avoid a "discards const" compiler warning.
Kai Blin [Fri, 26 Dec 2008 09:17:38 +0000 (10:17 +0100)]
s4 libnet: Add group_name member to struct libnet_GroupInfo's out struct.
Stefan Metzmacher [Mon, 29 Dec 2008 08:37:02 +0000 (09:37 +0100)]
s4:kdc: pass down event_context explicit
metze
Stefan Metzmacher [Mon, 29 Dec 2008 08:36:20 +0000 (09:36 +0100)]
s4:libnet_samdump_keytab: pass down event_context explicit
metze
Stefan Metzmacher [Wed, 17 Dec 2008 16:16:50 +0000 (17:16 +0100)]
s3:dbwrap: fix dbwrap_store_uint32() to match dbwrap_store_int32()
All callers expect 0 an success and -1 on error.
metze
Stefan Metzmacher [Mon, 29 Dec 2008 07:40:04 +0000 (08:40 +0100)]
pyglue: fix the build with automatic dependecies
metze
Stefan Metzmacher [Wed, 24 Dec 2008 12:52:57 +0000 (13:52 +0100)]
lib/tevent: rename event_* => tevent_* in the header file
We have compat macros to keep the callers happy.
metze
Steven Danneman [Mon, 29 Dec 2008 01:22:28 +0000 (17:22 -0800)]
Add -D option to sharesec util to delete the entire security descriptor.
* also modified --usage descriptions to be more accurate
Steven Danneman [Mon, 29 Dec 2008 01:21:36 +0000 (17:21 -0800)]
Change error messages in sharesec util to go to stderr instead of stdout
Steven Danneman [Mon, 29 Dec 2008 01:16:28 +0000 (17:16 -0800)]
Make sure share_info.tdb is open before attempting to delete an entry
Steven Danneman [Fri, 26 Dec 2008 20:41:29 +0000 (12:41 -0800)]
Make sharesec utility part of the default binary install.
Steven Danneman [Thu, 25 Dec 2008 01:03:22 +0000 (17:03 -0800)]
Cleaned up whitespace issues in sharesec.c
Jelmer Vernooij [Sun, 28 Dec 2008 03:12:46 +0000 (04:12 +0100)]
Fix Samba 3 merged build - include tevent.
Kai Blin [Fri, 26 Dec 2008 13:09:02 +0000 (14:09 +0100)]
Fix some tevent includes, trying to fix the build
Kai Blin [Fri, 26 Dec 2008 12:32:26 +0000 (13:32 +0100)]
Try to fix the build by fixing some typos in the vfs code
Jeremy Allison [Thu, 25 Dec 2008 20:13:12 +0000 (12:13 -0800)]
Fix bug #5990 - strict allocate should be checked before ftruncate
reported by and based on a patch by Yasuma Takeda
<yasuma@osstech.co.jp>.
Jeremy.
Michael Adam [Wed, 1 Oct 2008 06:53:15 +0000 (08:53 +0200)]
s3:idmap: Remove passd check from idmap_backends_unixid_to_sid().
As noted by Metzy, it makes no sense here to check id->sid.
What is worse, this might even be passed in uninitialized.
This still fixes the bug for me (of course), but we might need
to check, if another special handling of passdb is needed
(possibly changing from constant return code NT_STATUS_OK...)
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 1 Oct 2008 06:30:15 +0000 (08:30 +0200)]
s:Fix uid_to_sid mapping when the idmap cache is empty.
This failed for backends other than passed, since
idmap_backends_unixid_to_sid() always asked passdb first,
which returned Success no matter whether a mapping was
found or not.
One effect wast that getpwuid failed after "net cache flush".
Only after filling the cache with a getpwnam call it succeeded.
This fix makes the behaviour of idmap_backends_unixid_to_sid()
exactly the same as that of idmap_backends_sid_to_unixid()
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Wed, 24 Dec 2008 12:50:47 +0000 (13:50 +0100)]
lib/tevent: libtevent will change a lot until it's version 1.0.0
metze
Jelmer Vernooij [Wed, 24 Dec 2008 04:39:29 +0000 (05:39 +0100)]
Fix accidental condition inversion.
Jelmer Vernooij [Tue, 23 Dec 2008 23:15:43 +0000 (00:15 +0100)]
Rename samba-socket -> samba_socket to fix a couple more compiler
warnings.
Jelmer Vernooij [Tue, 23 Dec 2008 22:26:32 +0000 (23:26 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 22:24:12 +0000 (23:24 +0100)]
s4: Fix make clean to remove gen_ndr objects.
Jelmer Vernooij [Tue, 23 Dec 2008 22:22:57 +0000 (23:22 +0100)]
Fix more compiler warnings.
Jelmer Vernooij [Tue, 23 Dec 2008 22:02:54 +0000 (23:02 +0100)]
Use 32-bit smbpid in interface as required by SMB2, in line with
1bdd08227e7d046305705050f21f0f1b6dd6994a.
Jelmer Vernooij [Tue, 23 Dec 2008 21:57:11 +0000 (22:57 +0100)]
Fix more compiler warnings in various places.
Jelmer Vernooij [Tue, 23 Dec 2008 21:57:00 +0000 (22:57 +0100)]
Install tevent_internal.h, as Samba 4 needs it.
Jelmer Vernooij [Tue, 23 Dec 2008 21:12:23 +0000 (22:12 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Tue, 23 Dec 2008 21:11:21 +0000 (22:11 +0100)]
Fix compiler warnings in libnet.
Jelmer Vernooij [Tue, 23 Dec 2008 21:10:34 +0000 (22:10 +0100)]
Fix use of "time offset" parameter, and add test to make sure I don't break it again :-)
Jeremy Allison [Tue, 23 Dec 2008 20:11:12 +0000 (12:11 -0800)]
Fix more asprintf warnings and some error path errors.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:56:48 +0000 (11:56 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:45:26 +0000 (11:45 -0800)]
More asprintf warning fixes.
Jeremy.
Jeremy Allison [Tue, 23 Dec 2008 19:27:19 +0000 (11:27 -0800)]
Fix more asprintf errors and error code paths.
Jeremy.
Matthias Dieter Wallnöfer [Tue, 23 Dec 2008 19:17:59 +0000 (20:17 +0100)]
Add missing includes, required for use of gensec by 3rd-party
applications.