jra/samba/.git
15 years agoFix bug #5814 - Winbindd dumping core in a strange manner while doing "rescan_trusted...
Jeremy Allison [Wed, 8 Oct 2008 18:39:32 +0000 (11:39 -0700)]
Fix bug #5814 - Winbindd dumping core in a strange manner while doing "rescan_trusted_domain".
From analysis by hargagan <shargagan@novell.com> :
"The winbindd_child_died() is also getting called from process_loop() in case of
SIGCHLD signal. In this case it doesn't make the timeout_handler to NULL for
the first request. It then initiate a new request using
schedule_async_request() which installs a new timeout handler for the same
request. In such a case, for a badly unresponsive system both the timeout
handler can be called. For the first call the "private_data" will be cleared
and for another call the timeout handler will be detecting the double free. So,
for such a case as well, the winbindd_child_died() should make the
timeout_handler to NULL."
Jeremy.

15 years agoRemove unused CHECK_FSP macro
Volker Lendecke [Wed, 8 Oct 2008 10:56:04 +0000 (12:56 +0200)]
Remove unused CHECK_FSP macro

15 years agoRemove duplicate copy of manual page.
Jelmer Vernooij [Wed, 8 Oct 2008 10:08:52 +0000 (12:08 +0200)]
Remove duplicate copy of manual page.

15 years agofix libclinbtsrcdir variable.
Jelmer Vernooij [Wed, 8 Oct 2008 10:03:45 +0000 (12:03 +0200)]
fix libclinbtsrcdir variable.

15 years agoAdd manpage for nmblookup, move nmblookup closer to nbt library.
Jelmer Vernooij [Wed, 8 Oct 2008 09:56:46 +0000 (11:56 +0200)]
Add manpage for nmblookup, move nmblookup closer to nbt library.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Wed, 8 Oct 2008 01:39:17 +0000 (03:39 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoFix subunit files location after cherrypicks.
Jelmer Vernooij [Wed, 8 Oct 2008 01:33:38 +0000 (03:33 +0200)]
Fix subunit files location after cherrypicks.

15 years agoFix const warning.
Jeremy Allison [Wed, 8 Oct 2008 00:56:32 +0000 (17:56 -0700)]
Fix const warning.
Jeremy.

15 years agoUpdate vfs version as I've added a const to the security_descriptor paramter in fset_...
Jeremy Allison [Wed, 8 Oct 2008 00:50:01 +0000 (17:50 -0700)]
Update vfs version as I've added a const to the security_descriptor paramter in fset_nt_acl().
Need to watch the build farm to make sure I haven't broken the AIX or Solaris ACL modules.
Jeremy.

15 years agoFix path apparently gone wrong by cherrypick.
Jelmer Vernooij [Wed, 8 Oct 2008 00:23:51 +0000 (02:23 +0200)]
Fix path apparently gone wrong by cherrypick.

15 years agoMove all subunit files to lib directory.
Jelmer Vernooij [Wed, 8 Oct 2008 00:17:47 +0000 (02:17 +0200)]
Move all subunit files to lib directory.

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Wed, 8 Oct 2008 00:21:49 +0000 (02:21 +0200)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoFix syntax errors in minschema.
Jelmer Vernooij [Mon, 6 Oct 2008 23:23:34 +0000 (01:23 +0200)]
Fix syntax errors in minschema.

15 years agoImport tests for subunit python module.
Jelmer Vernooij [Tue, 7 Oct 2008 23:58:42 +0000 (01:58 +0200)]
Import tests for subunit python module.

15 years agoMove subunit helper utility to specific subunit directory.
Jelmer Vernooij [Tue, 7 Oct 2008 23:48:44 +0000 (01:48 +0200)]
Move subunit helper utility to specific subunit directory.

15 years agoAllow 'make testenv-dc', 'make testenv-member', etc.
Jelmer Vernooij [Mon, 6 Oct 2008 14:00:10 +0000 (16:00 +0200)]
Allow 'make testenv-dc', 'make testenv-member', etc.

15 years agoPrint proper error if include file can't be found.
Jelmer Vernooij [Mon, 6 Oct 2008 02:54:48 +0000 (04:54 +0200)]
Print proper error if include file can't be found.

15 years agoMake map_errno_from_nt_status() a generic call, not just a cli specific one.
Jeremy Allison [Tue, 7 Oct 2008 21:43:42 +0000 (14:43 -0700)]
Make map_errno_from_nt_status() a generic call, not just a cli specific one.
Remove some unused calls from vfs_acl_xattr. Test for SD's on existing files.
Jeremy.

15 years agoChanged variable name from f19086872ec734fff3f2119712ff24117bec4e5e to match v3-...
Tim Prouty [Tue, 7 Oct 2008 17:56:30 +0000 (10:56 -0700)]
Changed variable name from f19086872ec734fff3f2119712ff24117bec4e5e to match v3-[23]-test

15 years agoFixed build warning "passing arg from incompatible pointer type"
Tim Prouty [Tue, 7 Oct 2008 00:09:48 +0000 (17:09 -0700)]
Fixed build warning "passing arg from incompatible pointer type"

The fix explicitly makes the conversion from timeval to time_t using the
existing time utility functions.

Compiling modules/vfs_smb_traffic_analyzer.c
modules/vfs_smb_traffic_analyzer.c: In function `smb_traffic_analyzer_send_data':
modules/vfs_smb_traffic_analyzer.c:173: warning: passing arg 1 of `localtime' from incompatible pointer type

15 years agoFixed "declaration shadows global declaration" warnings.
Tim Prouty [Mon, 6 Oct 2008 23:41:46 +0000 (16:41 -0700)]
Fixed "declaration shadows global declaration" warnings.

The patch simply uses a more descriptive variable name for tcp_seq.

../lib/socket_wrapper/socket_wrapper.c:753: warning: declaration of 'tcp_seq' shadows a global declaration
/usr/include/netinet/tcp.h:40: warning: shadowed declaration is here
../lib/socket_wrapper/socket_wrapper.c: In function `swrap_marshall_packet':
../lib/socket_wrapper/socket_wrapper.c:919: warning: declaration of 'tcp_seq' shadows a global declaration
/usr/include/netinet/tcp.h:40: warning: shadowed declaration is here

15 years agoSet default trust kvno to -1
Andrew Bartlett [Fri, 3 Oct 2008 23:36:49 +0000 (16:36 -0700)]
Set default trust kvno to -1

15 years agoFix cross-realm authentication in Samba4's KDC.
Andrew Bartlett [Thu, 2 Oct 2008 18:30:14 +0000 (11:30 -0700)]
Fix cross-realm authentication in Samba4's KDC.

15 years agoAllow the PAC to be passed along during cross-realm authentication
Andrew Bartlett [Thu, 2 Oct 2008 18:29:34 +0000 (11:29 -0700)]
Allow the PAC to be passed along during cross-realm authentication

15 years agoUse the trust password version as kvno for trusts in Kerberos.
Andrew Bartlett [Wed, 1 Oct 2008 23:00:33 +0000 (16:00 -0700)]
Use the trust password version as kvno for trusts in Kerberos.

15 years agoStart implementing AD-style trusted domains in Samba4's NETLOGON server
Andrew Bartlett [Wed, 1 Oct 2008 20:31:22 +0000 (13:31 -0700)]
Start implementing AD-style trusted domains in Samba4's NETLOGON server

15 years agoStore trusted domain passwords in the LSA server
Andrew Bartlett [Wed, 1 Oct 2008 20:12:15 +0000 (13:12 -0700)]
Store trusted domain passwords in the LSA server

15 years agoMake RPC-LSA test for enumeration conditions more strict
Andrew Bartlett [Wed, 1 Oct 2008 20:11:11 +0000 (13:11 -0700)]
Make RPC-LSA test for enumeration conditions more strict

15 years agoAdd in secure channel type used by AD trusts
Andrew Bartlett [Wed, 1 Oct 2008 20:10:35 +0000 (13:10 -0700)]
Add in secure channel type used by AD trusts

15 years agoClarify use of manual parsers in trustInOutBlob (drsblobs.idl)
Andrew Bartlett [Wed, 1 Oct 2008 20:10:11 +0000 (13:10 -0700)]
Clarify use of manual parsers in trustInOutBlob (drsblobs.idl)

15 years agoImplement 'type unknown' names in the CrackNames code.
Andrew Bartlett [Tue, 30 Sep 2008 21:24:58 +0000 (14:24 -0700)]
Implement 'type unknown' names in the CrackNames code.

This guesses the type by running each of the possible options.

Andrew Bartlett

15 years agoRemove compleatly bogus rename test in partitions module.
Andrew Bartlett [Sat, 4 Oct 2008 17:25:46 +0000 (10:25 -0700)]
Remove compleatly bogus rename test in partitions module.

15 years agoRemove DESCRIPTION from generated schema lines.
Andrew Bartlett [Fri, 3 Oct 2008 23:36:04 +0000 (16:36 -0700)]
Remove DESCRIPTION from generated schema lines.

This is not permitted in the AD aggregate schema, and more trouble
than it is worth in the OpenLDAP schema due to escaping issues.

Andrew Bartlett

15 years agoFix Domain Trust creation with Windows 2008 (and many other tools)
Andrew Bartlett [Fri, 3 Oct 2008 23:25:59 +0000 (16:25 -0700)]
Fix Domain Trust creation with Windows 2008 (and many other tools)

A dITConentRules attribute (unlike objectClasses) must not contain a
'SUP'.

The ADSI layer in Windows would download the whole schema, and
validate it.  Thanks to the team at Microsoft for very long debugging
session to find this.

Andrew Bartlett

15 years agoidmap_adex: Add more debugging to the basic search function.
Gerald (Jerry) Carter [Mon, 6 Oct 2008 16:47:57 +0000 (11:47 -0500)]
idmap_adex: Add more debugging to the basic search function.

Log the dn of all located entries in order to verify search results.

15 years agoidmap_adex: Add log messages to dc_add_domain for easier debugging.
Gerald (Jerry) Carter [Mon, 6 Oct 2008 16:34:45 +0000 (11:34 -0500)]
idmap_adex: Add log messages to dc_add_domain for easier debugging.

Part of continue work on BUG 5806.

15 years agos4:rpc_server: tell the gensec layer that we want to do header signing
Stefan Metzmacher [Mon, 6 Oct 2008 17:39:53 +0000 (19:39 +0200)]
s4:rpc_server: tell the gensec layer that we want to do header signing

Note: header signing is still off by default, as the gensec backends
      don't support it together with seal yet.

metze

15 years agos4:gensec: pass down want_features to the spnego backend mech
Stefan Metzmacher [Wed, 1 Oct 2008 00:27:09 +0000 (02:27 +0200)]
s4:gensec: pass down want_features to the spnego backend mech

metze

15 years agoIf name_to_fqdn fails, retry with the dns domain the DC gave us
Volker Lendecke [Mon, 6 Oct 2008 12:49:10 +0000 (14:49 +0200)]
If name_to_fqdn fails, retry with the dns domain the DC gave us

This is a workaround for the cases where you want to join under a netbios name
that is different from your hostname, i.e. a name that can not be found in
/etc/hosts or dns. In these cases, name_to_fqdn fails or gives invalid results.

15 years agoLog in the parent winbind log where a request is going
Volker Lendecke [Mon, 6 Oct 2008 08:57:13 +0000 (10:57 +0200)]
Log in the parent winbind log where a request is going

15 years agoAdd netlogond auth method
Volker Lendecke [Mon, 22 Sep 2008 17:29:05 +0000 (19:29 +0200)]
Add netlogond auth method

This authenticates against a local running samba4 using SamLogonEx. We retrieve
the machine password using samba4's mymachinepwd script and store the schannel
key for re-use in secrets.tdb.

15 years agoAdd dyn_NCALRPCDIR
Volker Lendecke [Mon, 22 Sep 2008 17:24:59 +0000 (19:24 +0200)]
Add dyn_NCALRPCDIR

15 years agoStore a local schannel key in secrets.tdb
Volker Lendecke [Mon, 22 Sep 2008 17:23:21 +0000 (19:23 +0200)]
Store a local schannel key in secrets.tdb

15 years agos4:blackbox/test_ldb: test search by <GUID=...> and <SID=...>
Stefan Metzmacher [Thu, 2 Oct 2008 17:31:56 +0000 (19:31 +0200)]
s4:blackbox/test_ldb: test search by <GUID=...> and <SID=...>

metze

15 years agoFix some nonempty blank lines
Volker Lendecke [Sun, 5 Oct 2008 14:14:27 +0000 (16:14 +0200)]
Fix some nonempty blank lines

15 years agosmbd3 is unhappy if stderr is not open
Volker Lendecke [Sun, 5 Oct 2008 18:47:00 +0000 (20:47 +0200)]
smbd3 is unhappy if stderr is not open

15 years agoRe-enable build of smb_samba3.c after the rename smbd->samba
Volker Lendecke [Sun, 5 Oct 2008 14:09:18 +0000 (16:09 +0200)]
Re-enable build of smb_samba3.c after the rename smbd->samba

15 years agoRemove an unused variable
Volker Lendecke [Sun, 5 Oct 2008 13:48:55 +0000 (15:48 +0200)]
Remove an unused variable

15 years agoFix some missing error handlings
Volker Lendecke [Sun, 5 Oct 2008 11:58:09 +0000 (13:58 +0200)]
Fix some missing error handlings

15 years agoOS/X does not have rl_done in readline.h
Volker Lendecke [Sun, 5 Oct 2008 11:12:31 +0000 (13:12 +0200)]
OS/X does not have rl_done in readline.h

15 years agoFix an uninitialized variable warning
Volker Lendecke [Sun, 5 Oct 2008 08:55:30 +0000 (10:55 +0200)]
Fix an uninitialized variable warning

Not sure if we can ever not get domain and dns_domain, but gcc complained

15 years agoremove dependencies on my home domain
Andrew Tridgell [Sun, 5 Oct 2008 04:48:46 +0000 (15:48 +1100)]
remove dependencies on my home domain

(in other words, don't do commits in airports)

15 years agoremoved some debug lines I left in the last commit
Andrew Tridgell [Sat, 4 Oct 2008 21:17:16 +0000 (08:17 +1100)]
removed some debug lines I left in the last commit

15 years agoMerge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Sat, 4 Oct 2008 20:56:20 +0000 (13:56 -0700)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba

15 years agoFix an unlikely memleak found by the IBM checker
Volker Lendecke [Sat, 4 Oct 2008 20:17:30 +0000 (22:17 +0200)]
Fix an unlikely memleak found by the IBM checker

15 years agoFix an uninitialized variable found by the IBM Checker
Volker Lendecke [Sat, 4 Oct 2008 20:15:03 +0000 (22:15 +0200)]
Fix an uninitialized variable found by the IBM Checker

15 years agoFix a potential NULL deref in line 258 found by the IBM checker
Volker Lendecke [Sat, 4 Oct 2008 20:07:14 +0000 (22:07 +0200)]
Fix a potential NULL deref in line 258 found by the IBM checker

15 years ago"gwen/cc" does not like the double const :-)
Volker Lendecke [Sat, 4 Oct 2008 19:52:11 +0000 (21:52 +0200)]
"gwen/cc" does not like the double const :-)

15 years agoFix the build farm. In this branch cli_echo returns NTSTATUS.
Jeremy Allison [Sat, 4 Oct 2008 00:57:37 +0000 (17:57 -0700)]
Fix the build farm. In this branch cli_echo returns NTSTATUS.
Jeremy

15 years agoupdated the LSA and NETLOGON servers with fixes resulting from the AD
Andrew Tridgell [Sat, 4 Oct 2008 00:52:59 +0000 (17:52 -0700)]
updated the LSA and NETLOGON servers with fixes resulting from the AD
plugfest in Redmond

15 years agoexpanded the netlogon test to better simulate the WSPP NRPC test that
Andrew Tridgell [Sat, 4 Oct 2008 00:10:53 +0000 (17:10 -0700)]
expanded the netlogon test to better simulate the WSPP NRPC test that
we had some trouble with

15 years agofixed the ldb blackbox test to work with non-bourne shells (as needed
Andrew Tridgell [Sat, 4 Oct 2008 00:08:39 +0000 (17:08 -0700)]
fixed the ldb blackbox test to work with non-bourne shells (as needed
by ubuntu)

fixed spelling of 'wellknown'

15 years agoCorrectly fix smbclient to terminate on eof from server.
Jeremy Allison [Fri, 3 Oct 2008 21:58:41 +0000 (14:58 -0700)]
Correctly fix smbclient to terminate on eof from server.
Jeremy.

15 years agoSimply our main loop processing. A lot :-). Correctly use events for all the previous...
Jeremy Allison [Fri, 3 Oct 2008 21:18:35 +0000 (14:18 -0700)]
Simply our main loop processing. A lot :-). Correctly use events for all the previous "special" cases.
A step on the way to adding signals to the events and being able to merge the S3 event system with
the S4 one.
Jeremy.

15 years agoDocument "cups connection timeout".
Jeremy Allison [Fri, 3 Oct 2008 21:05:33 +0000 (14:05 -0700)]
Document "cups connection timeout".
Jeremy.

15 years agoMerge commit 'master/master'
Andrew Tridgell [Fri, 3 Oct 2008 19:23:00 +0000 (12:23 -0700)]
Merge commit 'master/master'

15 years agofixed the partition module and the GC handling
Andrew Tridgell [Fri, 3 Oct 2008 19:21:53 +0000 (12:21 -0700)]
fixed the partition module and the GC handling

 - when multiple partitions are searched, consider the search a
   success if any of the partitions return success

 - only search the right subset of partitions, looking at the scope
   and basedn of the search

This fixes several errors with GC searches

15 years agonet_dns: Make "lwinet ads dns register" honor the "interfaces" parameter.
Gerald (Jerry) Carter [Fri, 3 Oct 2008 15:51:54 +0000 (10:51 -0500)]
net_dns: Make "lwinet ads dns register" honor the "interfaces" parameter.

This is helpful on multihomed hosts that only require a subset
of IP addresses be registered with DNS.

15 years agolibaddns: Use the same prerequisite for DDNS update as Windows XP.
Gerald (Jerry) Carter [Fri, 3 Oct 2008 15:51:21 +0000 (10:51 -0500)]
libaddns: Use the same prerequisite for DDNS update as Windows XP.

   Hostname, TYPE: CNAME, CLASS: NONE

This has to have been broken for ages.  I cannot see
how it would have worked in any environment.

15 years agoFix regressions in patchfile after last patch, several other minor fixes.
Matthias Dieter Wallnöfer [Fri, 3 Oct 2008 12:29:47 +0000 (14:29 +0200)]
Fix regressions in patchfile after last patch, several other minor fixes.

15 years agofixed the sense of ldb base dn comparisons in two places, and use a
Andrew Tridgell [Fri, 3 Oct 2008 04:58:46 +0000 (21:58 -0700)]
fixed the sense of ldb base dn comparisons in two places, and use a
direct comparison instead of a sub-tree comparison in another

this fixes basedn searches on the global catalog port

15 years agofixed a talloc error in the rpc handle desctructor - destructors
Andrew Tridgell [Fri, 3 Oct 2008 04:57:27 +0000 (21:57 -0700)]
fixed a talloc error in the rpc handle desctructor - destructors
should not try to free the ptr they are given

15 years agowe need to listen on all interfaces in the CLDAP server as the windows
Andrew Tridgell [Fri, 3 Oct 2008 04:55:26 +0000 (21:55 -0700)]
we need to listen on all interfaces in the CLDAP server as the windows
CDLAP client ignores replies from the wrong IP

15 years agoFix crash bugs in error paths: ac is not yet initialized here, and we don't
Simo Sorce [Thu, 2 Oct 2008 21:15:00 +0000 (17:15 -0400)]
Fix crash bugs in error paths: ac is not yet initialized here, and we don't
need to call ldb_module_done in the main module functions, we can directly
return an error. ldb_module_done() is for callbacks

15 years agoDon't reject a successful alloc :-(.
Jeremy Allison [Thu, 2 Oct 2008 19:21:11 +0000 (12:21 -0700)]
Don't reject a successful alloc :-(.
Jeremy.

15 years agos4:blackblox/test_ldb: test searches via wellknownObjects
Stefan Metzmacher [Thu, 2 Oct 2008 16:49:11 +0000 (18:49 +0200)]
s4:blackblox/test_ldb: test searches via wellknownObjects

metze

15 years agos4:setup: add wellknownObjects to the domain object
Stefan Metzmacher [Thu, 2 Oct 2008 09:56:12 +0000 (11:56 +0200)]
s4:setup: add wellknownObjects to the domain object

metze

15 years agoFix bug 5805: don't close stdout
Derrell Lipman [Thu, 2 Oct 2008 13:03:32 +0000 (09:03 -0400)]
Fix bug 5805: don't close stdout

- When calling setup_logging multiple times, the code was closing the debug
  file descriptor before opening or assigning the new one.  We don't, however,
  want to close the debug file descriptor if it is stdout.

Derrell

15 years agos4:drsuapi.idl: fix some fields in drsuapi_DsRemoveDSServer()
Stefan Metzmacher [Thu, 2 Oct 2008 09:25:13 +0000 (11:25 +0200)]
s4:drsuapi.idl: fix some fields in drsuapi_DsRemoveDSServer()

metze

15 years agos4:rootdse: for now don't pass down controls for the rootdse search
Stefan Metzmacher [Thu, 2 Oct 2008 09:20:10 +0000 (11:20 +0200)]
s4:rootdse: for now don't pass down controls for the rootdse search

metze

15 years agos4:partition: register DOMAIN_SCOPE and SEARCH_OPTIONS controls
Stefan Metzmacher [Thu, 2 Oct 2008 09:22:33 +0000 (11:22 +0200)]
s4:partition: register DOMAIN_SCOPE and SEARCH_OPTIONS controls

metze

15 years agos4:partition: pass down the SEARCH_OPTIONS control as uncritical
Stefan Metzmacher [Thu, 2 Oct 2008 09:11:14 +0000 (11:11 +0200)]
s4:partition: pass down the SEARCH_OPTIONS control as uncritical

metze

15 years agos4:linked_attributes: fix a crash bug when the definition of a target attribute is...
Stefan Metzmacher [Thu, 2 Oct 2008 09:05:02 +0000 (11:05 +0200)]
s4:linked_attributes: fix a crash bug when the definition of a target attribute is missing

Windows 2003 has a broken schema where the definition of msDS-IsDomainFor
is missing (which is supposed to be the backlink of the msDS-HasDomainNCs
attribute.

Our schema is extracted from windows 2003, so we have the problem.

As the NET-API-BECOME-DC test triggers this bug, windows 2003
seems to just skip creating a backlink.

metze

15 years agos4:kludge_acl: just fake support for the SD_FLAGS control
Stefan Metzmacher [Thu, 2 Oct 2008 00:44:25 +0000 (02:44 +0200)]
s4:kludge_acl: just fake support for the SD_FLAGS control

metze

15 years agos4:extended_dn: add support for <GUID=...>, <SID=...> or <WKGUID=...,DC=...> as basedn
Stefan Metzmacher [Thu, 2 Oct 2008 00:30:48 +0000 (02:30 +0200)]
s4:extended_dn: add support for <GUID=...>, <SID=...> or <WKGUID=...,DC=...> as basedn

We resolve them into the real basedn before do the real search.

metze

15 years agos4:lib/ldb: fix stupid <SID=...> dn parsing bugs
Stefan Metzmacher [Thu, 2 Oct 2008 09:23:21 +0000 (11:23 +0200)]
s4:lib/ldb: fix stupid <SID=...> dn parsing bugs

metze

15 years agoThe IRIX compiler does not like embedded unnamed unions
Volker Lendecke [Thu, 2 Oct 2008 06:09:25 +0000 (08:09 +0200)]
The IRIX compiler does not like embedded unnamed unions

15 years agoAttempt to fix the build on IRIX
Volker Lendecke [Thu, 2 Oct 2008 01:37:52 +0000 (03:37 +0200)]
Attempt to fix the build on IRIX

Under irix, "sa_family" is a #define to sa_union.sa_generic.sa_family2

15 years agoFix bug 5798: "CFLAGS info lost in configure"
Volker Lendecke [Thu, 2 Oct 2008 00:17:04 +0000 (02:17 +0200)]
Fix bug 5798: "CFLAGS info lost in configure"

Michael, please check and merge to the other branches if it's right.

Thanks,

Volker

15 years agoFix bug #5080. Access to cups-printers via samba broken with cups 1.3.4, Unsupported...
Jeremy Allison [Wed, 1 Oct 2008 23:40:41 +0000 (16:40 -0700)]
Fix bug #5080. Access to cups-printers via samba broken with cups 1.3.4, Unsupported character set.
Cups 1.3.4 expects utf8 to be used in all messages to/from the server. We may be using a
different character set so we need to use talloc utf8 push/pull functions in all communication.
Needs more testing. Don't release until I've done a thorough test. I also have a version for 3.2.x.
Jeremy.

15 years agoWhitespace cleanup.
Jeremy Allison [Wed, 1 Oct 2008 22:01:05 +0000 (15:01 -0700)]
Whitespace cleanup.
Jeremy.

15 years agoFix use of DLIST_REMOVE as spotted by Constantine Vetoshev <gepardcv@gmail.com>.
Jeremy Allison [Wed, 1 Oct 2008 20:15:54 +0000 (13:15 -0700)]
Fix use of DLIST_REMOVE as spotted by Constantine Vetoshev <gepardcv@gmail.com>.
This API is unusual in that if used to remove a non-list head it nulls out
the next and prev pointers. This is what you want for debugging (don't want
an entry removed from the list to be still virtually linked into it) but
means there is no consistent idiom for use as the next and prev pointers
get trashed on removal from the list, meaning you must save them yourself.
You can use it one way when deleting everything via the head pointer, as
this preserves the next pointer, but you *must* use it another way when not
deleting everything via the head pointer. Fix all known uses of this (the main
one is in conn_free_internal() and would not free all the private data entries
for vfs modules. The other changes in web/statuspage.c and winbindd_util.c
are not strictly neccessary, as the head pointer is being used, but I've done
them for consistency. Long term we must revisit this as this API is too hard
to use correctly.
Jeremy.

15 years agoTurn the socket connections into a refcounted list - in the common case there'll...
Jeremy Allison [Wed, 1 Oct 2008 19:50:29 +0000 (12:50 -0700)]
Turn the socket connections into a refcounted list - in the common case there'll now only be one socket per smbd.
Changed the format of the wire data to (a) include a version number (V1) as the first element. (b) removed the
";)" at the end an replaced it with a "\n". Receiver can change back if needed, and now receiver can just log
"as-is" to a text file (making testing easier). Added my (C). Sorry Holger, but I've changed quite a bit now.
Jeremy.

15 years agoFix some syntax errors for use with ReST.
Jelmer Vernooij [Wed, 1 Oct 2008 16:06:55 +0000 (18:06 +0200)]
Fix some syntax errors for use with ReST.

15 years agoFix header.
Jelmer Vernooij [Wed, 1 Oct 2008 15:29:16 +0000 (17:29 +0200)]
Fix header.

15 years agoFix formatting to be compatible with ReST.
Jelmer Vernooij [Wed, 1 Oct 2008 15:28:12 +0000 (17:28 +0200)]
Fix formatting to be compatible with ReST.

15 years agoUpdate to refer to 3 and 4, not just Samba 3.
Jelmer Vernooij [Wed, 1 Oct 2008 15:27:42 +0000 (17:27 +0200)]
Update to refer to 3 and 4, not just Samba 3.

15 years agoConvert to allocated strings. Use write_data(), not send as this doesn't correctly
Jeremy Allison [Tue, 30 Sep 2008 23:19:37 +0000 (16:19 -0700)]
Convert to allocated strings. Use write_data(), not send as this doesn't correctly
deal with EINTR. Jim and Holger please check this still works.
Jeremy.

15 years agoRevert erroneous commit.
Jeremy Allison [Tue, 30 Sep 2008 22:26:26 +0000 (15:26 -0700)]
Revert erroneous commit.
Jeremy.

15 years agoRemove current_user_info - not needed.
Jeremy Allison [Tue, 30 Sep 2008 22:21:58 +0000 (15:21 -0700)]
Remove current_user_info - not needed.
Jeremy.