fix potential handle leak in _spoolss_open_printer_ex(); final fix for CR2102; review...

(This used to be commit 3d37e1ece913707f346c3c2459c3c42192a3a1a7)

diff --git a/source3/rpc_server/srv_spoolss_nt.c b/source3/rpc_server/srv_spoolss_nt.c
index 9c9dd438b3430d9b728827d8449378f22a5d3507..c2729001e42703072dac86bad926b02236007371 100644 (file)
--- a/source3/rpc_server/srv_spoolss_nt.c
+++ b/source3/rpc_server/srv_spoolss_nt.c
@@ -1623,8 +1623,10 @@ Can't find printer handle we created for printer %s\n", name ));
                /* NT doesn't let us connect to a printer if the connecting user
                   doesn't have print permission.  */
 
-               if (!get_printer_snum(p, handle, &snum))
+               if (!get_printer_snum(p, handle, &snum)) {
+                       close_printer_handle(p, handle);
                        return WERR_BADFID;
+               }
 
                se_map_standard(&printer_default->access_required, &printer_std_mapping);