r20274: add missing return statement and make it more explicit that we return a NULL...
authorStefan Metzmacher <metze@samba.org>
Wed, 20 Dec 2006 12:49:11 +0000 (12:49 +0000)
committerGerald (Jerry) Carter <jerry@samba.org>
Wed, 10 Oct 2007 19:29:29 +0000 (14:29 -0500)
metze
(This used to be commit 7256481f08b5e860308e73c2b51926b55b1f4c43)

source4/auth/kerberos/gssapi_parse.c

index 5226d77a2b783164edb751903319b82ee60206b3..7eefed7ac8c92d0870b588c6dbe0a4fa3ce45494 100644 (file)
 DATA_BLOB gensec_gssapi_gen_krb5_wrap(TALLOC_CTX *mem_ctx, const DATA_BLOB *ticket, const uint8_t tok_id[2])
 {
        struct asn1_data data;
-       DATA_BLOB ret = data_blob(NULL,0);
+       DATA_BLOB ret;
 
        if (!ticket->data) {
-               return ret;
+               return data_blob(NULL,0);
        }
 
        ZERO_STRUCT(data);
@@ -50,6 +50,7 @@ DATA_BLOB gensec_gssapi_gen_krb5_wrap(TALLOC_CTX *mem_ctx, const DATA_BLOB *tick
        if (data.has_error) {
                DEBUG(1,("Failed to build krb5 wrapper at offset %d\n", (int)data.ofs));
                asn1_free(&data);
+               return data_blob(NULL,0);
        }
 
        ret = data_blob_talloc(mem_ctx, data.data, data.length);