Oops, Tim says rl_completion_func_t doesn't exist in all versions of

readline.
(This used to be commit c4b44cfc3f15f9e85a36981867e534792ccb724e)

diff --git a/source3/lib/readline.c b/source3/lib/readline.c
index 543e4c3349cd14815df6565185861a0f1b2c2dcd..927c903255fbe1b41980598c24f3afe219a45096 100644 (file)
--- a/source3/lib/readline.c
+++ b/source3/lib/readline.c
@@ -73,13 +73,11 @@ char *smb_readline(char *prompt, void (*callback)(void),
                                                 completion_fn);
 
        if (completion_fn) {
-               /* The cast is here because the callback prototype has
-                  changed slightly between different versions of
-                  Readline.  The same function works in all of them
-                  to date, but we get compiler warnings without the
-                  cast. */
-               rl_attempted_completion_function =
-                       (rl_completion_func_t *) completion_fn;
+               /* The callback prototype has changed slightly between
+                  different versions of Readline, so the same
+                  function works in all of them to date, but we get
+                  compiler warnings in some. */
+               rl_attempted_completion_function = completion_fn;
        }
 
        if (callback) rl_event_hook = (Function *)callback;