Collecting some minor patches...
[jra/samba/.git] / source3 / utils / net_ads.c
index 5af492bbb04118f8073285a817848f7fa0973d20..9ee2f3c09356c81bdca672bea97c851b3736fdc1 100644 (file)
@@ -32,6 +32,8 @@ int net_ads_usage(int argc, const char **argv)
 "\n\tjoins the local machine to a ADS realm\n"\
 "\nnet ads leave"\
 "\n\tremoves the local machine from a ADS realm\n"\
+"\nnet ads testjoin"\
+"\n\ttests that an exiting join is OK\n"\
 "\nnet ads user"\
 "\n\tlist, add, or delete users in the realm\n"\
 "\nnet ads group"\
@@ -40,39 +42,84 @@ int net_ads_usage(int argc, const char **argv)
 "\n\tshows some info on the server\n"\
 "\nnet ads status"\
 "\n\tdump the machine account details to stdout\n"
-"\nnet ads password <username@realm> -Uadmin_username@realm%%admin_pass"\
-"\n\tchange a user's password using an admin account"
-"\n\t(note: use realm in UPPERCASE)\n"
-"\nnet ads chostpass"
-"\n\tchange the trust account password of this machine in the AD tree\n"
-"\nnet ads printer [info | publish | remove] <printername> <servername>"
-"\n\t lookup, add, or remove directory entry for a printer\n"
+"\nnet ads lookup"\
+"\n\tperform a CLDAP search on the server\n"
+"\nnet ads password <username@realm> <password> -Uadmin_username@realm%%admin_pass"\
+"\n\tchange a user's password using an admin account"\
+"\n\t(note: use realm in UPPERCASE, prompts if password is obmitted)\n"\
+"\nnet ads changetrustpw"\
+"\n\tchange the trust account password of this machine in the AD tree\n"\
+"\nnet ads printer [info | publish | remove] <printername> <servername>"\
+"\n\t lookup, add, or remove directory entry for a printer\n"\
+"\nnet ads search"\
+"\n\tperform a raw LDAP search and dump the results\n"
+"\nnet ads dn"\
+"\n\tperform a raw LDAP search and dump attributes of a particular DN\n"
                );
        return -1;
 }
 
 
+/*
+  this implements the CLDAP based netlogon lookup requests
+  for finding the domain controller of a ADS domain
+*/
+static int net_ads_lookup(int argc, const char **argv)
+{
+       ADS_STRUCT *ads;
+
+       ads = ads_init(NULL, opt_target_workgroup, opt_host);
+       if (ads) {
+               ads->auth.flags |= ADS_AUTH_NO_BIND;
+       }
+
+       ads_connect(ads);
+
+       if (!ads || !ads->config.realm) {
+               d_printf("Didn't find the cldap server!\n");
+               return -1;
+       }
+
+       return ads_cldap_netlogon(ads);
+}
+
+
+
 static int net_ads_info(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
 
-       ads = ads_init(NULL, NULL, opt_host, NULL, NULL);
+       ads = ads_init(NULL, opt_target_workgroup, opt_host);
+
+       if (ads) {
+               ads->auth.flags |= ADS_AUTH_NO_BIND;
+       }
+
        ads_connect(ads);
 
-       if (!ads) {
+       if (!ads || !ads->config.realm) {
                d_printf("Didn't find the ldap server!\n");
                return -1;
        }
 
-       d_printf("LDAP server: %s\n", ads->ldap_server);
-       d_printf("LDAP server name: %s\n", ads->ldap_server_name);
-       d_printf("Realm: %s\n", ads->realm);
-       d_printf("Bind Path: %s\n", ads->bind_path);
+       d_printf("LDAP server: %s\n", inet_ntoa(ads->ldap_ip));
+       d_printf("LDAP server name: %s\n", ads->config.ldap_server_name);
+       d_printf("Realm: %s\n", ads->config.realm);
+       d_printf("Bind Path: %s\n", ads->config.bind_path);
        d_printf("LDAP port: %d\n", ads->ldap_port);
+       d_printf("Server time: %s\n", http_timestring(ads->config.current_time));
+
+       d_printf("KDC server: %s\n", ads->auth.kdc_server );
+       d_printf("Server time offset: %d\n", ads->auth.time_offset );
 
        return 0;
 }
 
+static void use_in_memory_ccache(void) {
+       /* Use in-memory credentials cache so we do not interfere with
+        * existing credentials */
+       setenv(KRB5_ENV_CCNAME, "MEMORY:net_ads", 1);
+}
 
 static ADS_STRUCT *ads_startup(void)
 {
@@ -80,30 +127,51 @@ static ADS_STRUCT *ads_startup(void)
        ADS_STATUS status;
        BOOL need_password = False;
        BOOL second_time = False;
+       char *cp;
        
-       ads = ads_init(NULL, NULL, opt_host, NULL, NULL);
+       /* lp_realm() should be handled by a command line param, 
+          However, the join requires that realm be set in smb.conf
+          and compares our realm with the remote server's so this is
+          ok until someone needs more flexibility */
+          
+       ads = ads_init(lp_realm(), opt_target_workgroup, opt_host);
 
        if (!opt_user_name) {
                opt_user_name = "administrator";
        }
 
-       if (opt_user_specified)
+       if (opt_user_specified) {
                need_password = True;
+       }
 
 retry:
-       if (!opt_password && need_password) {
+       if (!opt_password && need_password && !opt_machine_pass) {
                char *prompt;
                asprintf(&prompt,"%s password: ", opt_user_name);
                opt_password = getpass(prompt);
                free(prompt);
        }
 
-       if (opt_password)
-               ads->password = strdup(opt_password);
+       if (opt_password) {
+               use_in_memory_ccache();
+               ads->auth.password = smb_xstrdup(opt_password);
+       }
+
+       ads->auth.user_name = smb_xstrdup(opt_user_name);
 
-       ads->user_name = strdup(opt_user_name);
+       /*
+        * If the username is of the form "name@realm", 
+        * extract the realm and convert to upper case.
+        * This is only used to establish the connection.
+        */
+       if ((cp = strchr(ads->auth.user_name, '@'))!=0) {
+               *cp++ = '\0';
+               ads->auth.realm = smb_xstrdup(cp);
+               strupper_m(ads->auth.realm);
+       }
 
        status = ads_connect(ads);
+
        if (!ADS_ERR_OK(status)) {
                if (!need_password && !second_time) {
                        need_password = True;
@@ -134,28 +202,61 @@ int net_ads_check(void)
        return 0;
 }
 
+/* 
+   determine the netbios workgroup name for a domain
+ */
+static int net_ads_workgroup(int argc, const char **argv)
+{
+       ADS_STRUCT *ads;
+       TALLOC_CTX *ctx;
+       const char *workgroup;
+
+       if (!(ads = ads_startup())) return -1;
+
+       if (!(ctx = talloc_init("net_ads_workgroup"))) {
+               return -1;
+       }
+
+       if (!ADS_ERR_OK(ads_workgroup_name(ads, ctx, &workgroup))) {
+               d_printf("Failed to find workgroup for realm '%s'\n", 
+                        ads->config.realm);
+               talloc_destroy(ctx);
+               return -1;
+       }
+
+       d_printf("Workgroup: %s\n", workgroup);
+
+       talloc_destroy(ctx);
+
+       return 0;
+}
+
+
 
-static void usergrp_display(char *field, void **values, void *data_area)
+static BOOL usergrp_display(char *field, void **values, void *data_area)
 {
        char **disp_fields = (char **) data_area;
 
        if (!field) { /* must be end of record */
                if (!strchr_m(disp_fields[0], '$')) {
                        if (disp_fields[1])
-                               printf("%-21.21s %-50.50s\n", 
+                               d_printf("%-21.21s %s\n", 
                                       disp_fields[0], disp_fields[1]);
                        else
-                               printf("%s\n", disp_fields[0]);
+                               d_printf("%s\n", disp_fields[0]);
                }
                SAFE_FREE(disp_fields[0]);
                SAFE_FREE(disp_fields[1]);
-               return;
+               return True;
        }
+       if (!values) /* must be new field, indicate string field */
+               return True;
        if (StrCaseCmp(field, "sAMAccountName") == 0) {
-               disp_fields[0] = strdup(((struct berval *) values[0])->bv_val);
+               disp_fields[0] = strdup((char *) values[0]);
        }
        if (StrCaseCmp(field, "description") == 0)
-               disp_fields[1] = strdup(((struct berval *) values[0])->bv_val);
+               disp_fields[1] = strdup((char *) values[0]);
+       return True;
 }
 
 static int net_ads_user_usage(int argc, const char **argv)
@@ -184,11 +285,10 @@ static int ads_user_add(int argc, const char **argv)
        
        if (ads_count_replies(ads, res)) {
                d_printf("ads_user_add: User %s already exists\n", argv[0]);
-               ads_msgfree(ads, res);
                goto done;
        }
 
-       status = ads_add_user_acct(ads, argv[0], opt_comment);
+       status = ads_add_user_acct(ads, argv[0], opt_container, opt_comment);
 
        if (!ADS_ERR_OK(status)) {
                d_printf("Could not add user %s: %s\n", argv[0],
@@ -204,8 +304,9 @@ static int ads_user_add(int argc, const char **argv)
        }
 
        /* try setting the password */
-       asprintf(&upn, "%s@%s", argv[0], ads->realm);
-       status = krb5_set_password(ads->kdc_server, upn, argv[1]);
+       asprintf(&upn, "%s@%s", argv[0], ads->config.realm);
+       status = ads_krb5_set_password(ads->auth.kdc_server, upn, argv[1], 
+                                      ads->auth.time_offset);
        safe_free(upn);
        if (ADS_ERR_OK(status)) {
                d_printf("User %s added\n", argv[0]);
@@ -239,12 +340,18 @@ static int ads_user_info(int argc, const char **argv)
        const char *attrs[] = {"memberOf", NULL};
        char *searchstring=NULL;
        char **grouplist;
+       char *escaped_user = escape_ldap_string_alloc(argv[0]);
 
        if (argc < 1) return net_ads_user_usage(argc, argv);
        
        if (!(ads = ads_startup())) return -1;
 
-       asprintf(&searchstring, "(sAMAccountName=%s)", argv[0]);
+       if (!escaped_user) {
+               d_printf("ads_user_info: failed to escape user %s\n", argv[0]);
+               return -1;
+       }
+
+       asprintf(&searchstring, "(sAMAccountName=%s)", escaped_user);
        rc = ads_search(ads, &res, searchstring, attrs);
        safe_free(searchstring);
 
@@ -260,7 +367,7 @@ static int ads_user_info(int argc, const char **argv)
                char **groupname;
                for (i=0;grouplist[i];i++) {
                        groupname = ldap_explode_dn(grouplist[i], 1);
-                       printf("%s\n", groupname[0]);
+                       d_printf("%s\n", groupname[0]);
                        ldap_value_free(groupname);
                }
                ldap_value_free(grouplist);
@@ -322,7 +429,7 @@ int net_ads_user(int argc, const char **argv)
                        d_printf("\nUser name             Comment"\
                                 "\n-----------------------------\n");
 
-               rc = ads_do_search_all_fn(ads, ads->bind_path, 
+               rc = ads_do_search_all_fn(ads, ads->config.bind_path, 
                                          LDAP_SCOPE_SUBTREE,
                                          "(objectclass=user)", 
                                          opt_long_list_entries ? longattrs :
@@ -364,7 +471,7 @@ static int ads_group_add(int argc, const char **argv)
                goto done;
        }
 
-       status = ads_add_group_acct(ads, argv[0], opt_comment);
+       status = ads_add_group_acct(ads, argv[0], opt_container, opt_comment);
 
        if (ADS_ERR_OK(status)) {
                d_printf("Group %s added\n", argv[0]);
@@ -429,7 +536,7 @@ int net_ads_group(int argc, const char **argv)
                if (opt_long_list_entries)
                        d_printf("\nGroup name            Comment"\
                                 "\n-----------------------------\n");
-               rc = ads_do_search_all_fn(ads, ads->bind_path, 
+               rc = ads_do_search_all_fn(ads, ads->config.bind_path, 
                                          LDAP_SCOPE_SUBTREE, 
                                          "(objectclass=group)", 
                                          opt_long_list_entries ? longattrs : 
@@ -446,19 +553,18 @@ static int net_ads_status(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       extern pstring global_myname;
        void *res;
 
        if (!(ads = ads_startup())) return -1;
 
-       rc = ads_find_machine_acct(ads, &res, global_myname);
+       rc = ads_find_machine_acct(ads, &res, global_myname());
        if (!ADS_ERR_OK(rc)) {
                d_printf("ads_find_machine_acct: %s\n", ads_errstr(rc));
                return -1;
        }
 
        if (ads_count_replies(ads, res) == 0) {
-               d_printf("No machine account for '%s' found\n", global_myname);
+               d_printf("No machine account for '%s' found\n", global_myname());
                return -1;
        }
 
@@ -471,7 +577,6 @@ static int net_ads_leave(int argc, const char **argv)
 {
        ADS_STRUCT *ads = NULL;
        ADS_STATUS rc;
-       extern pstring global_myname;
 
        if (!secrets_init()) {
                DEBUG(1,("Failed to initialise secrets database\n"));
@@ -479,38 +584,80 @@ static int net_ads_leave(int argc, const char **argv)
        }
 
        if (!opt_password) {
-               asprintf(&opt_user_name, "%s$", global_myname);
-               opt_password = secrets_fetch_machine_password();
+               net_use_machine_password();
        }
 
        if (!(ads = ads_startup())) {
                return -1;
        }
 
-       rc = ads_leave_realm(ads, global_myname);
+       rc = ads_leave_realm(ads, global_myname());
        if (!ADS_ERR_OK(rc)) {
            d_printf("Failed to delete host '%s' from the '%s' realm.\n", 
-                    global_myname, ads->realm);
+                    global_myname(), ads->config.realm);
            return -1;
        }
 
-       d_printf("Removed '%s' from realm '%s'\n", global_myname, ads->realm);
+       d_printf("Removed '%s' from realm '%s'\n", global_myname(), ads->config.realm);
+
+       return 0;
+}
+
+static int net_ads_join_ok(void)
+{
+       ADS_STRUCT *ads = NULL;
+
+       if (!secrets_init()) {
+               DEBUG(1,("Failed to initialise secrets database\n"));
+               return -1;
+       }
+
+       net_use_machine_password();
+
+       if (!(ads = ads_startup())) {
+               return -1;
+       }
+
+       ads_destroy(&ads);
+       return 0;
+}
+
+/*
+  check that an existing join is OK
+ */
+int net_ads_testjoin(int argc, const char **argv)
+{
+       use_in_memory_ccache();
+
+       /* Display success or failure */
+       if (net_ads_join_ok() != 0) {
+               fprintf(stderr,"Join to domain is not valid\n");
+               return -1;
+       }
 
+       printf("Join is OK\n");
        return 0;
 }
 
+/*
+  join a domain using ADS
+ */
 int net_ads_join(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
        char *password;
+       char *machine_account = NULL;
        char *tmp_password;
-       extern pstring global_myname;
        const char *org_unit = "Computers";
        char *dn;
        void *res;
        DOM_SID dom_sid;
        char *ou_str;
+       uint32 sec_channel_type = SEC_CHAN_WKSTA;
+       uint32 account_type = UF_WORKSTATION_TRUST_ACCOUNT;
+       const char *short_domain_name = NULL;
+       TALLOC_CTX *ctx = NULL;
 
        if (argc > 0) org_unit = argv[0];
 
@@ -524,14 +671,24 @@ int net_ads_join(int argc, const char **argv)
 
        if (!(ads = ads_startup())) return -1;
 
+       if (!*lp_realm()) {
+               d_printf("realm must be set in in smb.conf for ADS join to succeed.\n");
+               return -1;
+       }
+
+       if (strcmp(ads->config.realm, lp_realm()) != 0) {
+               d_printf("realm of remote server (%s) and realm in smb.conf (%s) DO NOT match.  Aborting join\n", ads->config.realm, lp_realm());
+               return -1;
+       }
+
        ou_str = ads_ou_string(org_unit);
-       asprintf(&dn, "%s,%s", ou_str, ads->bind_path);
+       asprintf(&dn, "%s,%s", ou_str, ads->config.bind_path);
        free(ou_str);
 
        rc = ads_search_dn(ads, &res, dn, NULL);
        ads_msgfree(ads, res);
 
-       if (rc.error_type == ADS_ERROR_LDAP && rc.rc == LDAP_NO_SUCH_OBJECT) {
+       if (rc.error_type == ADS_ERROR_LDAP && rc.err.rc == LDAP_NO_SUCH_OBJECT) {
                d_printf("ads_join_realm: organizational unit %s does not exist (dn:%s)\n", 
                         org_unit, dn);
                return -1;
@@ -543,44 +700,89 @@ int net_ads_join(int argc, const char **argv)
                return -1;
        }       
 
-       rc = ads_join_realm(ads, global_myname, org_unit);
+       rc = ads_join_realm(ads, global_myname(), account_type, org_unit);
        if (!ADS_ERR_OK(rc)) {
                d_printf("ads_join_realm: %s\n", ads_errstr(rc));
                return -1;
        }
 
-       rc = ads_set_machine_password(ads, global_myname, password);
+       rc = ads_domain_sid(ads, &dom_sid);
        if (!ADS_ERR_OK(rc)) {
-               d_printf("ads_set_machine_password: %s\n", ads_errstr(rc));
+               d_printf("ads_domain_sid: %s\n", ads_errstr(rc));       
+       return -1;
+       }
+
+       if (asprintf(&machine_account, "%s$", global_myname()) == -1) {
+               d_printf("asprintf failed\n");
                return -1;
        }
 
-       rc = ads_domain_sid(ads, &dom_sid);
+       rc = ads_set_machine_password(ads, machine_account, password);
        if (!ADS_ERR_OK(rc)) {
-               d_printf("ads_domain_sid: %s\n", ads_errstr(rc));
+               d_printf("ads_set_machine_password: %s\n", ads_errstr(rc));
                return -1;
        }
-
+       
+       /* make sure we get the right workgroup */
+       
+       if ( !(ctx = talloc_init("net ads join")) ) {
+               d_printf("talloc_init() failed!\n");
+               return -1;
+       }
+       
+       rc = ads_workgroup_name(ads, ctx, &short_domain_name);
+       if ( ADS_ERR_OK(rc) ) {
+               if ( !strequal(lp_workgroup(), short_domain_name) ) {
+                       d_printf("The workgroup in smb.conf does not match the short\n");
+                       d_printf("domain name obtained from the server.\n");
+                       d_printf("Using the name [%s] from the server.\n", short_domain_name);
+                       d_printf("You should set \"workgroup = %s\" in smb.conf.\n", short_domain_name);
+               }
+       }
+       else
+               short_domain_name = lp_workgroup();
+       
+       d_printf("Using short domain name -- %s\n", short_domain_name);
+       
+       /*  HACK ALRET!  Store the sid and password under bother the lp_workgroup() 
+           value from smb.conf and the string returned from the server.  The former is
+           neede to bootstrap winbindd's first connection to the DC to get the real 
+           short domain name   --jerry */
+           
        if (!secrets_store_domain_sid(lp_workgroup(), &dom_sid)) {
                DEBUG(1,("Failed to save domain sid\n"));
                return -1;
        }
 
-       if (!secrets_store_machine_password(password)) {
+       if (!secrets_store_machine_password(password, lp_workgroup(), sec_channel_type)) {
                DEBUG(1,("Failed to save machine password\n"));
                return -1;
        }
 
-       d_printf("Joined '%s' to realm '%s'\n", global_myname, ads->realm);
+       if (!secrets_store_domain_sid(short_domain_name, &dom_sid)) {
+               DEBUG(1,("Failed to save domain sid\n"));
+               return -1;
+       }
 
-       free(password);
+       if (!secrets_store_machine_password(password, short_domain_name, sec_channel_type)) {
+               DEBUG(1,("Failed to save machine password\n"));
+               return -1;
+       }
+       
+       d_printf("Joined '%s' to realm '%s'\n", global_myname(), ads->config.realm);
 
+       SAFE_FREE(password);
+       SAFE_FREE(machine_account);
+       if ( ctx )
+               talloc_destroy(ctx);
        return 0;
 }
 
 int net_ads_printer_usage(int argc, const char **argv)
 {
        d_printf(
+"\nnet ads printer search <printer>"
+"\n\tsearch for a printer in the directory"
 "\nnet ads printer info <printer> <server>"
 "\n\tlookup info in directory for printer on server"
 "\n\t(note: printer defaults to \"*\", server defaults to local)\n"
@@ -593,12 +795,40 @@ int net_ads_printer_usage(int argc, const char **argv)
        return -1;
 }
 
+static int net_ads_printer_search(int argc, const char **argv)
+{
+       ADS_STRUCT *ads;
+       ADS_STATUS rc;
+       void *res = NULL;
+
+       if (!(ads = ads_startup())) 
+               return -1;
+
+       rc = ads_find_printers(ads, &res);
+
+       if (!ADS_ERR_OK(rc)) {
+               d_printf("ads_find_printer: %s\n", ads_errstr(rc));
+               ads_msgfree(ads, res);
+               return -1;
+       }
+
+       if (ads_count_replies(ads, res) == 0) {
+               d_printf("No results found\n");
+               ads_msgfree(ads, res);
+               return -1;
+       }
+
+       ads_dump(ads, res);
+       ads_msgfree(ads, res);
+
+       return 0;
+}
+
 static int net_ads_printer_info(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       char *servername, *printername;
-       extern pstring global_myname;
+       const char *servername, *printername;
        void *res = NULL;
 
        if (!(ads = ads_startup())) return -1;
@@ -611,7 +841,7 @@ static int net_ads_printer_info(int argc, const char **argv)
        if (argc > 1)
                servername =  argv[1];
        else
-               servername = global_myname;
+               servername = global_myname();
 
        rc = ads_find_printer_on_server(ads, &res, printername, servername);
 
@@ -633,44 +863,73 @@ static int net_ads_printer_info(int argc, const char **argv)
        return 0;
 }
 
+void do_drv_upgrade_printer(int msg_type, pid_t src, void *buf, size_t len)
+{
+       return;
+}
+
 static int net_ads_printer_publish(int argc, const char **argv)
 {
         ADS_STRUCT *ads;
         ADS_STATUS rc;
-       char *uncname, *servername;
-       ADS_PRINTER_ENTRY prt;
-       extern pstring global_myname;
-
-       /* 
-          these const strings are only here as an example.  The attributes
-          they represent are not implemented yet
-       */
-       const char *bins[] = {"Tray 21", NULL};
-       const char *media[] = {"Letter", NULL};
-       const char *orients[] = {"PORTRAIT", NULL};
-       const char *ports[] = {"Samba", NULL};
+       const char *servername, *printername;
+       struct cli_state *cli;
+       struct in_addr          server_ip;
+       NTSTATUS nt_status;
+       TALLOC_CTX *mem_ctx = talloc_init("net_ads_printer_publish");
+       ADS_MODLIST mods = ads_init_mods(mem_ctx);
+       char *prt_dn, *srv_dn, **srv_cn;
+       void *res = NULL;
 
        if (!(ads = ads_startup())) return -1;
 
        if (argc < 1)
                return net_ads_printer_usage(argc, argv);
+       
+       printername = argv[0];
 
-       memset(&prt, 0, sizeof(ADS_PRINTER_ENTRY));
-
-       prt.printerName = argv[0];
-       asprintf(&servername, "%s.%s", global_myname, ads->realm);
-       prt.serverName = servername;
-       prt.shortServerName = global_myname;
-       prt.versionNumber = "4";
-       asprintf(&uncname, "\\\\%s\\%s", global_myname, argv[0]);
-       prt.uNCName=uncname;
-       prt.printBinNames = (char **) bins;
-       prt.printMediaSupported = (char **) media;
-       prt.printOrientationsSupported = (char **) orients;
-       prt.portName = (char **) ports;
-       prt.printSpooling = "PrintAfterSpooled";
-        rc = ads_add_printer(ads, &prt);
+       if (argc == 2)
+               servername = argv[1];
+       else
+               servername = global_myname();
+               
+       /* Get printer data from SPOOLSS */
+
+       resolve_name(servername, &server_ip, 0x20);
+
+       nt_status = cli_full_connection(&cli, global_myname(), servername, 
+                                       &server_ip, 0,
+                                       "IPC$", "IPC",  
+                                       opt_user_name, opt_workgroup,
+                                       opt_password ? opt_password : "", 
+                                       CLI_FULL_CONNECTION_USE_KERBEROS, 
+                                       Undefined, NULL);
+
+       if (NT_STATUS_IS_ERR(nt_status)) {
+               d_printf("Unable to open a connnection to %s to obtain data "
+                        "for %s\n", servername, printername);
+               return -1;
+       }
+
+       /* Publish on AD server */
+
+       ads_find_machine_acct(ads, &res, servername);
+
+       if (ads_count_replies(ads, res) == 0) {
+               d_printf("Could not find machine account for server %s\n", 
+                        servername);
+               return -1;
+       }
+
+       srv_dn = ldap_get_dn(ads->ld, res);
+       srv_cn = ldap_explode_dn(srv_dn, 1);
+
+       asprintf(&prt_dn, "cn=%s-%s,%s", srv_cn[0], printername, srv_dn);
+
+       cli_nt_session_open(cli, PI_SPOOLSS);
+       get_remote_printer_publishing_data(cli, mem_ctx, &mods, printername);
+
+        rc = ads_add_printer_entry(ads, prt_dn, mem_ctx, &mods);
         if (!ADS_ERR_OK(rc)) {
                 d_printf("ads_publish_printer: %s\n", ads_errstr(rc));
                 return -1;
@@ -685,8 +944,8 @@ static int net_ads_printer_remove(int argc, const char **argv)
 {
        ADS_STRUCT *ads;
        ADS_STATUS rc;
-       char *servername, *prt_dn;
-       extern pstring global_myname;
+       const char *servername;
+       char *prt_dn;
        void *res = NULL;
 
        if (!(ads = ads_startup())) return -1;
@@ -697,7 +956,7 @@ static int net_ads_printer_remove(int argc, const char **argv)
        if (argc > 1)
                servername = argv[1];
        else
-               servername = global_myname;
+               servername = global_myname();
 
        rc = ads_find_printer_on_server(ads, &res, argv[0], servername);
 
@@ -729,6 +988,7 @@ static int net_ads_printer_remove(int argc, const char **argv)
 static int net_ads_printer(int argc, const char **argv)
 {
        struct functable func[] = {
+               {"SEARCH", net_ads_printer_search},
                {"INFO", net_ads_printer_info},
                {"PUBLISH", net_ads_printer_publish},
                {"REMOVE", net_ads_printer_remove},
@@ -742,62 +1002,98 @@ static int net_ads_printer(int argc, const char **argv)
 static int net_ads_password(int argc, const char **argv)
 {
     ADS_STRUCT *ads;
-    char *auth_principal = opt_user_name;
-    char *auth_password = opt_password;
+    const char *auth_principal = opt_user_name;
+    const char *auth_password = opt_password;
     char *realm = NULL;
     char *new_password = NULL;
-    char *c;
-    char *prompt;
+    char *c, *prompt;
+    const char *user;
     ADS_STATUS ret;
 
-    
-    if ((argc != 1) || (opt_user_name == NULL) || 
-       (opt_password == NULL) || (strchr(opt_user_name, '@') == NULL) ||
-       (strchr(argv[0], '@') == NULL)) {
-       return net_ads_usage(argc, argv);
+    if (opt_user_name == NULL || opt_password == NULL) {
+           d_printf("You must supply an administrator username/password\n");
+           return -1;
     }
+
     
+    if (argc < 1) {
+           d_printf("ERROR: You must say which username to change password for\n");
+           return -1;
+    }
+
+    user = argv[0];
+    if (!strchr(user, '@')) {
+           asprintf(&c, "%s@%s", argv[0], lp_realm());
+           user = c;
+    }
+
+    use_in_memory_ccache();    
     c = strchr(auth_principal, '@');
-    realm = ++c;
+    if (c) {
+           realm = ++c;
+    } else {
+           realm = lp_realm();
+    }
 
     /* use the realm so we can eventually change passwords for users 
     in realms other than default */
-    if (!(ads = ads_init(realm, NULL, NULL, NULL, NULL))) return -1;
+    if (!(ads = ads_init(realm, NULL, NULL))) return -1;
 
-    asprintf(&prompt, "Enter new password for %s:", argv[0]);
+    /* we don't actually need a full connect, but it's the easy way to
+       fill in the KDC's addresss */
+    ads_connect(ads);
+    
+    if (!ads || !ads->config.realm) {
+           d_printf("Didn't find the kerberos server!\n");
+           return -1;
+    }
 
-    new_password = getpass(prompt);
+    if (argv[1]) {
+          new_password = (char *)argv[1];
+    } else {
+          asprintf(&prompt, "Enter new password for %s:", user);
+          new_password = getpass(prompt);
+          free(prompt);
+    }
 
-    ret = kerberos_set_password(ads->kdc_server, auth_principal, 
-                               auth_password, argv[0], new_password);
+    ret = kerberos_set_password(ads->auth.kdc_server, auth_principal, 
+                               auth_password, user, new_password, ads->auth.time_offset);
     if (!ADS_ERR_OK(ret)) {
        d_printf("Password change failed :-( ...\n");
        ads_destroy(&ads);
-       free(prompt);
        return -1;
     }
 
-    d_printf("Password change for %s completed.\n", argv[0]);
+    d_printf("Password change for %s completed.\n", user);
     ads_destroy(&ads);
-    free(prompt);
 
     return 0;
 }
 
 
-static int net_ads_change_localhost_pass(int argc, const char **argv)
+int net_ads_changetrustpw(int argc, const char **argv)
 {    
     ADS_STRUCT *ads;
-    extern pstring global_myname;
     char *host_principal;
     char *hostname;
     ADS_STATUS ret;
 
-    if (!(ads = ads_init_simple())) return -1;
+    if (!secrets_init()) {
+           DEBUG(1,("Failed to initialise secrets database\n"));
+           return -1;
+    }
+
+    net_use_machine_password();
+
+    use_in_memory_ccache();
 
-    hostname = strdup(global_myname);
-    strlower(hostname);
-    asprintf(&host_principal, "%s@%s", hostname, ads->realm);
+    if (!(ads = ads_startup())) {
+           return -1;
+    }
+
+    hostname = strdup(global_myname());
+    strlower_m(hostname);
+    asprintf(&host_principal, "%s@%s", hostname, ads->config.realm);
     SAFE_FREE(hostname);
     d_printf("Changing password for principal: HOST/%s\n", host_principal);
     
@@ -817,19 +1113,138 @@ static int net_ads_change_localhost_pass(int argc, const char **argv)
     return 0;
 }
 
+/*
+  help for net ads search
+*/
+static int net_ads_search_usage(int argc, const char **argv)
+{
+       d_printf(
+               "\nnet ads search <expression> <attributes...>\n"\
+               "\nperform a raw LDAP search on a ADS server and dump the results\n"\
+               "The expression is a standard LDAP search expression, and the\n"\
+               "attributes are a list of LDAP fields to show in the results\n\n"\
+               "Example: net ads search '(objectCategory=group)' sAMAccountName\n\n"
+               );
+       net_common_flags_usage(argc, argv);
+       return -1;
+}
+
+
+/*
+  general ADS search function. Useful in diagnosing problems in ADS
+*/
+static int net_ads_search(int argc, const char **argv)
+{
+       ADS_STRUCT *ads;
+       ADS_STATUS rc;
+       const char *ldap_exp;
+       const char **attrs;
+       void *res = NULL;
+
+       if (argc < 1) {
+               return net_ads_search_usage(argc, argv);
+       }
+
+       if (!(ads = ads_startup())) {
+               return -1;
+       }
+
+       ldap_exp = argv[0];
+       attrs = (argv + 1);
+
+       rc = ads_do_search_all(ads, ads->config.bind_path,
+                              LDAP_SCOPE_SUBTREE,
+                              ldap_exp, attrs, &res);
+       if (!ADS_ERR_OK(rc)) {
+               d_printf("search failed: %s\n", ads_errstr(rc));
+               return -1;
+       }       
+
+       d_printf("Got %d replies\n\n", ads_count_replies(ads, res));
+
+       /* dump the results */
+       ads_dump(ads, res);
+
+       ads_msgfree(ads, res);
+       ads_destroy(&ads);
+
+       return 0;
+}
+
+
+/*
+  help for net ads search
+*/
+static int net_ads_dn_usage(int argc, const char **argv)
+{
+       d_printf(
+               "\nnet ads dn <dn> <attributes...>\n"\
+               "\nperform a raw LDAP search on a ADS server and dump the results\n"\
+               "The DN standard LDAP DN, and the attributes are a list of LDAP fields \n"\
+               "to show in the results\n\n"\
+               "Example: net ads dn 'CN=administrator,CN=Users,DC=my,DC=domain' sAMAccountName\n\n"
+               );
+       net_common_flags_usage(argc, argv);
+       return -1;
+}
+
+
+/*
+  general ADS search function. Useful in diagnosing problems in ADS
+*/
+static int net_ads_dn(int argc, const char **argv)
+{
+       ADS_STRUCT *ads;
+       ADS_STATUS rc;
+       const char *dn;
+       const char **attrs;
+       void *res = NULL;
+
+       if (argc < 1) {
+               return net_ads_dn_usage(argc, argv);
+       }
+
+       if (!(ads = ads_startup())) {
+               return -1;
+       }
+
+       dn = argv[0];
+       attrs = (argv + 1);
+
+       rc = ads_do_search_all(ads, dn, 
+                              LDAP_SCOPE_BASE,
+                              "(objectclass=*)", attrs, &res);
+       if (!ADS_ERR_OK(rc)) {
+               d_printf("search failed: %s\n", ads_errstr(rc));
+               return -1;
+       }       
+
+       d_printf("Got %d replies\n\n", ads_count_replies(ads, res));
+
+       /* dump the results */
+       ads_dump(ads, res);
+
+       ads_msgfree(ads, res);
+       ads_destroy(&ads);
+
+       return 0;
+}
+
+
 int net_ads_help(int argc, const char **argv)
 {
        struct functable func[] = {
                {"USER", net_ads_user_usage},
                {"GROUP", net_ads_group_usage},
                {"PRINTER", net_ads_printer_usage},
+               {"SEARCH", net_ads_search_usage},
 #if 0
                {"INFO", net_ads_info},
                {"JOIN", net_ads_join},
                {"LEAVE", net_ads_leave},
                {"STATUS", net_ads_status},
                {"PASSWORD", net_ads_password},
-               {"CHOSTPASS", net_ads_change_localhost_pass},
+               {"CHANGETRUSTPW", net_ads_changetrustpw},
 #endif
                {NULL, NULL}
        };
@@ -842,13 +1257,18 @@ int net_ads(int argc, const char **argv)
        struct functable func[] = {
                {"INFO", net_ads_info},
                {"JOIN", net_ads_join},
+               {"TESTJOIN", net_ads_testjoin},
                {"LEAVE", net_ads_leave},
                {"STATUS", net_ads_status},
                {"USER", net_ads_user},
                {"GROUP", net_ads_group},
                {"PASSWORD", net_ads_password},
-               {"CHOSTPASS", net_ads_change_localhost_pass},
+               {"CHANGETRUSTPW", net_ads_changetrustpw},
                {"PRINTER", net_ads_printer},
+               {"SEARCH", net_ads_search},
+               {"DN", net_ads_dn},
+               {"WORKGROUP", net_ads_workgroup},
+               {"LOOKUP", net_ads_lookup},
                {"HELP", net_ads_help},
                {NULL, NULL}
        };
@@ -874,6 +1294,11 @@ int net_ads_help(int argc, const char **argv)
        return net_ads_noads();
 }
 
+int net_ads_changetrustpw(int argc, const char **argv)
+{
+       return net_ads_noads();
+}
+
 int net_ads_join(int argc, const char **argv)
 {
        return net_ads_noads();