increase log level for this failed setsockopt call. EINVAL is a normal error on Solar...
[jra/samba/.git] / source / lib / util_sock.c
index 80d4af8cdb63a6d20a1bd1968a5096bab57f452e..f252377b7ed88a03318c75c48e4c6c075a52f8bd 100644 (file)
 
 #include "includes.h"
 
-/* the following 3 client_*() functions are nasty ways of allowing
-   some generic functions to get info that really should be hidden in
-   particular modules */
-static int client_fd = -1;
-/* What to print out on a client disconnect error. */
-static char client_ip_string[INET6_ADDRSTRLEN];
-
 /****************************************************************************
  Return true if a string could be an IPv4 address.
 ****************************************************************************/
@@ -53,11 +46,27 @@ bool is_ipaddress(const char *str)
        int ret = -1;
 
 #if defined(HAVE_IPV6)
-       struct in6_addr dest6;
+       if (strchr_m(str, ':')) {
+               char addr[INET6_ADDRSTRLEN];
+               struct in6_addr dest6;
+               const char *sp = str;
+               char *p = strchr_m(str, '%');
 
-       ret = inet_pton(AF_INET6, str, &dest6);
-       if (ret > 0) {
-               return true;
+               /*
+                * Cope with link-local.
+                * This is IP:v6:addr%ifname.
+                */
+
+               if (p && (p > str) && (if_nametoindex(p+1) != 0)) {
+                       strlcpy(addr, str,
+                               MIN(PTR_DIFF(p,str)+1,
+                                       sizeof(addr)));
+                       sp = addr;
+               }
+               ret = inet_pton(AF_INET6, sp, &dest6);
+               if (ret > 0) {
+                       return true;
+               }
        }
 #endif
        return is_ipaddress_v4(str);
@@ -99,11 +108,15 @@ static bool interpret_string_addr_internal(struct addrinfo **ppres,
        hints.ai_socktype = SOCK_STREAM;
        hints.ai_flags = flags;
 
+       /* Linux man page on getaddinfo() says port will be
+          uninitialized when service string in NULL */
+
        ret = getaddrinfo(str, NULL,
                        &hints,
                        ppres);
+
        if (ret) {
-               DEBUG(3,("interpret_string_addr_interal: getaddrinfo failed "
+               DEBUG(3,("interpret_string_addr_internal: getaddrinfo failed "
                        "for name %s [%s]\n",
                        str,
                        gai_strerror(ret) ));
@@ -183,12 +196,11 @@ uint32 interpret_addr(const char *str)
  A convenient addition to interpret_addr().
 ******************************************************************/
 
-struct in_addr *interpret_addr2(const char *str)
+struct in_addr *interpret_addr2(struct in_addr *ip, const char *str)
 {
-       static struct in_addr ret;
        uint32 a = interpret_addr(str);
-       ret.s_addr = a;
-       return(&ret);
+       ip->s_addr = a;
+       return ip;
 }
 
 /*******************************************************************
@@ -200,9 +212,29 @@ bool interpret_string_addr(struct sockaddr_storage *pss,
                const char *str,
                int flags)
 {
+       char addr[INET6_ADDRSTRLEN];
        struct addrinfo *res = NULL;
+#if defined(HAVE_IPV6)
+       unsigned int scope_id = 0;
+
+       if (strchr_m(str, ':')) {
+               char *p = strchr_m(str, '%');
+
+               /*
+                * Cope with link-local.
+                * This is IP:v6:addr%ifname.
+                */
 
-       zero_addr(pss, AF_INET);
+               if (p && (p > str) && ((scope_id = if_nametoindex(p+1)) != 0)) {
+                       strlcpy(addr, str,
+                               MIN(PTR_DIFF(p,str)+1,
+                                       sizeof(addr)));
+                       str = addr;
+               }
+       }
+#endif
+
+       zero_addr(pss);
 
        if (!interpret_string_addr_internal(&res, str, flags|AI_ADDRCONFIG)) {
                return false;
@@ -212,6 +244,17 @@ bool interpret_string_addr(struct sockaddr_storage *pss,
        }
        /* Copy the first sockaddr. */
        memcpy(pss, res->ai_addr, res->ai_addrlen);
+
+#if defined(HAVE_IPV6)
+       if (pss->ss_family == AF_INET6 && scope_id) {
+               struct sockaddr_in6 *ps6 = (struct sockaddr_in6 *)pss;
+               if (IN6_IS_ADDR_LINKLOCAL(&ps6->sin6_addr) &&
+                               ps6->sin6_scope_id == 0) {
+                       ps6->sin6_scope_id = scope_id;
+               }
+       }
+#endif
+
        freeaddrinfo(res);
        return true;
 }
@@ -284,26 +327,18 @@ bool is_zero_addr(const struct sockaddr_storage *pss)
 
 void zero_ip_v4(struct in_addr *ip)
 {
-        static bool init;
-        static struct in_addr ipzero;
-
-        if (!init) {
-                ipzero = *interpret_addr2("0.0.0.0");
-                init = true;
-        }
-
-        *ip = ipzero;
+       memset(ip, '\0', sizeof(struct in_addr));
 }
 
 /*******************************************************************
- Set an address to INADDR_ANY, or IN6ADDR_ANY.
+ Set an address to INADDR_ANY.
 ******************************************************************/
 
-void zero_addr(struct sockaddr_storage *pss, int family)
+void zero_addr(struct sockaddr_storage *pss)
 {
        memset(pss, '\0', sizeof(*pss));
        /* Ensure we're at least a valid sockaddr-storage. */
-       pss->ss_family = family;
+       pss->ss_family = AF_INET;
 }
 
 /*******************************************************************
@@ -339,7 +374,7 @@ void in_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
  Convert an IPv6 struct in_addr to a struct sockaddr_storage.
 ********************************************************************/
 
-void in6_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
+ void in6_addr_to_sockaddr_storage(struct sockaddr_storage *ss,
                struct in6_addr ip)
 {
        struct sockaddr_in6 *sa = (struct sockaddr_in6 *)ss;
@@ -444,11 +479,34 @@ bool is_address_any(const struct sockaddr_storage *psa)
        return false;
 }
 
+/****************************************************************************
+ Get a port number in host byte order from a sockaddr_storage.
+****************************************************************************/
+
+uint16_t get_sockaddr_port(const struct sockaddr_storage *pss)
+{
+       uint16_t port = 0;
+
+       if (pss->ss_family != AF_INET) {
+#if defined(HAVE_IPV6)
+               /* IPv6 */
+               const struct sockaddr_in6 *sa6 =
+                       (const struct sockaddr_in6 *)pss;
+               port = ntohs(sa6->sin6_port);
+#endif
+       } else {
+               const struct sockaddr_in *sa =
+                       (const struct sockaddr_in *)pss;
+               port = ntohs(sa->sin_port);
+       }
+       return port;
+}
+
 /****************************************************************************
  Print out an IPv4 or IPv6 address from a struct sockaddr_storage.
 ****************************************************************************/
 
-char *print_sockaddr_len(char *dest,
+static char *print_sockaddr_len(char *dest,
                        size_t destlen,
                        const struct sockaddr_storage *psa,
                        socklen_t psalen)
@@ -456,7 +514,7 @@ char *print_sockaddr_len(char *dest,
        if (destlen > 0) {
                dest[0] = '\0';
        }
-       (void)getnameinfo((const struct sockaddr *)psa,
+       (void)sys_getnameinfo((const struct sockaddr *)psa,
                        psalen,
                        dest, destlen,
                        NULL, 0,
@@ -472,7 +530,8 @@ char *print_sockaddr(char *dest,
                        size_t destlen,
                        const struct sockaddr_storage *psa)
 {
-       return print_sockaddr_len(dest, destlen, psa, sizeof(*psa));
+       return print_sockaddr_len(dest, destlen, psa,
+                       sizeof(struct sockaddr_storage));
 }
 
 /****************************************************************************
@@ -486,81 +545,46 @@ char *print_canonical_sockaddr(TALLOC_CTX *ctx,
        char *dest = NULL;
        int ret;
 
-       ret = getnameinfo((const struct sockaddr *)pss,
+       /* Linux getnameinfo() man pages says port is unitialized if
+          service name is NULL. */
+
+       ret = sys_getnameinfo((const struct sockaddr *)pss,
                        sizeof(struct sockaddr_storage),
                        addr, sizeof(addr),
                        NULL, 0,
                        NI_NUMERICHOST);
-       if (ret) {
+       if (ret != 0) {
                return NULL;
        }
+
        if (pss->ss_family != AF_INET) {
 #if defined(HAVE_IPV6)
-               /* IPv6 */
-               const struct sockaddr_in6 *sa6 =
-                       (const struct sockaddr_in6 *)pss;
-               uint16_t port = ntohs(sa6->sin6_port);
-
-               if (port) {
-                       dest = talloc_asprintf(ctx,
-                                       "[%s]:%d",
-                                       addr,
-                                       (unsigned int)port);
-               } else {
-                       dest = talloc_asprintf(ctx,
-                                       "[%s]",
-                                       addr);
-               }
+               dest = talloc_asprintf(ctx, "[%s]", addr);
 #else
                return NULL;
 #endif
        } else {
-               const struct sockaddr_in *sa =
-                       (const struct sockaddr_in *)pss;
-               uint16_t port = ntohs(sa->sin_port);
-
-               if (port) {
-                       dest = talloc_asprintf(ctx,
-                                       "%s:%d",
-                                       addr,
-                                       (unsigned int)port);
-               } else {
-                       dest = talloc_asprintf(ctx,
-                                       "%s",
-                                       addr);
-               }
+               dest = talloc_asprintf(ctx, "%s", addr);
        }
+       
        return dest;
 }
 
 /****************************************************************************
- Set the global client_fd variable.
-****************************************************************************/
-
-void client_setfd(int fd)
-{
-       client_fd = fd;
-       safe_strcpy(client_ip_string,
-                       get_peer_addr(client_fd),
-                       sizeof(client_ip_string)-1);
-}
-
-/****************************************************************************
- Return a static string of an IP address (IPv4 or IPv6).
+ Return the string of an IP address (IPv4 or IPv6).
 ****************************************************************************/
 
-static const char *get_socket_addr(int fd)
+static const char *get_socket_addr(int fd, char *addr_buf, size_t addr_len)
 {
        struct sockaddr_storage sa;
        socklen_t length = sizeof(sa);
-       static char addr_buf[INET6_ADDRSTRLEN];
 
        /* Ok, returning a hard coded IPv4 address
         * is bogus, but it's just as bogus as a
         * zero IPv6 address. No good choice here.
         */
 
-       safe_strcpy(addr_buf, "0.0.0.0", sizeof(addr_buf)-1);
+       strlcpy(addr_buf, "0.0.0.0", addr_len);
 
        if (fd == -1) {
                return addr_buf;
@@ -572,9 +596,11 @@ static const char *get_socket_addr(int fd)
                return addr_buf;
        }
 
-       return print_sockaddr_len(addr_buf, sizeof(addr_buf), &sa, length);
+       return print_sockaddr_len(addr_buf, addr_len, &sa, length);
 }
 
+#if 0
+/* Not currently used. JRA. */
 /****************************************************************************
  Return the port number we've bound to on a socket.
 ****************************************************************************/
@@ -604,28 +630,62 @@ static int get_socket_port(int fd)
        }
        return -1;
 }
+#endif
 
-const char *client_name(void)
+void set_sockaddr_port(struct sockaddr_storage *psa, uint16 port)
 {
-       return get_peer_name(client_fd,false);
+#if defined(HAVE_IPV6)
+       if (psa->ss_family == AF_INET6) {
+               ((struct sockaddr_in6 *)psa)->sin6_port = htons(port);
+       }
+#endif
+       if (psa->ss_family == AF_INET) {
+               ((struct sockaddr_in *)psa)->sin_port = htons(port);
+       }
 }
 
-const char *client_addr(void)
+const char *client_name(int fd)
 {
-       return get_peer_addr(client_fd);
+       return get_peer_name(fd,false);
 }
 
-const char *client_socket_addr(void)
+const char *client_addr(int fd, char *addr, size_t addrlen)
 {
-       return get_socket_addr(client_fd);
+       return get_peer_addr(fd,addr,addrlen);
 }
 
-int client_socket_port(void)
+const char *client_socket_addr(int fd, char *addr, size_t addr_len)
 {
-       return get_socket_port(client_fd);
+       return get_socket_addr(fd, addr, addr_len);
 }
 
-int smb_read_error = 0;
+#if 0
+/* Not currently used. JRA. */
+int client_socket_port(int fd)
+{
+       return get_socket_port(fd);
+}
+#endif
+
+/****************************************************************************
+ Accessor functions to make thread-safe code easier later...
+****************************************************************************/
+
+void set_smb_read_error(enum smb_read_errors *pre,
+                       enum smb_read_errors newerr)
+{
+       if (pre) {
+               *pre = newerr;
+       }
+}
+
+void cond_set_smb_read_error(enum smb_read_errors *pre,
+                       enum smb_read_errors newerr)
+{
+       if (pre && *pre == SMB_READ_OK) {
+               *pre = newerr;
+       }
+}
 
 /****************************************************************************
  Determine if a file descriptor is in fact a socket.
@@ -730,9 +790,10 @@ static void print_socket_options(int s)
 
 void set_socket_options(int fd, const char *options)
 {
-       fstring tok;
+       TALLOC_CTX *ctx = talloc_stackframe();
+       char *tok;
 
-       while (next_token(&options,tok," \t,", sizeof(tok))) {
+       while (next_token_talloc(ctx, &options, &tok," \t,")) {
                int ret=0,i;
                int value = 1;
                char *p;
@@ -776,11 +837,15 @@ void set_socket_options(int fd, const char *options)
                }
 
                if (ret != 0) {
-                       DEBUG(0,("Failed to set socket option %s (Error %s)\n",
+                       /* be aware that some systems like Solaris return
+                        * EINVAL to a setsockopt() call when the client
+                        * sent a RST previously - no need to worry */
+                       DEBUG(2,("Failed to set socket option %s (Error %s)\n",
                                tok, strerror(errno) ));
                }
        }
 
+       TALLOC_FREE(ctx);
        print_socket_options(fd);
 }
 
@@ -833,23 +898,21 @@ ssize_t read_udp_v4_socket(int fd,
  time_out = timeout in milliseconds
 ****************************************************************************/
 
-ssize_t read_socket_with_timeout(int fd,
-                               char *buf,
-                               size_t mincnt,
-                               size_t maxcnt,
-                               unsigned int time_out)
+NTSTATUS read_socket_with_timeout(int fd, char *buf,
+                                 size_t mincnt, size_t maxcnt,
+                                 unsigned int time_out,
+                                 size_t *size_ret)
 {
        fd_set fds;
        int selrtn;
        ssize_t readret;
        size_t nread = 0;
        struct timeval timeout;
+       char addr[INET6_ADDRSTRLEN];
 
        /* just checking .... */
        if (maxcnt <= 0)
-               return(0);
-
-       smb_read_error = 0;
+               return NT_STATUS_OK;
 
        /* Blocking read */
        if (time_out == 0) {
@@ -863,29 +926,27 @@ ssize_t read_socket_with_timeout(int fd,
                        if (readret == 0) {
                                DEBUG(5,("read_socket_with_timeout: "
                                        "blocking read. EOF from client.\n"));
-                               smb_read_error = READ_EOF;
-                               return -1;
+                               return NT_STATUS_END_OF_FILE;
                        }
 
                        if (readret == -1) {
-                               if (fd == client_fd) {
+                               if (fd == get_client_fd()) {
                                        /* Try and give an error message
                                         * saying what client failed. */
                                        DEBUG(0,("read_socket_with_timeout: "
                                                "client %s read error = %s.\n",
-                                               client_ip_string,
+                                               get_peer_addr(fd,addr,sizeof(addr)),
                                                strerror(errno) ));
                                } else {
                                        DEBUG(0,("read_socket_with_timeout: "
                                                "read error = %s.\n",
                                                strerror(errno) ));
                                }
-                               smb_read_error = READ_ERROR;
-                               return -1;
+                               return map_nt_error_from_unix(errno);
                        }
                        nread += readret;
                }
-               return((ssize_t)nread);
+               goto done;
        }
 
        /* Most difficult - timeout read */
@@ -907,27 +968,26 @@ ssize_t read_socket_with_timeout(int fd,
                /* Check if error */
                if (selrtn == -1) {
                        /* something is wrong. Maybe the socket is dead? */
-                       if (fd == client_fd) {
+                       if (fd == get_client_fd()) {
                                /* Try and give an error message saying
                                 * what client failed. */
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                "read for client %s. select error = %s.\n",
-                               client_ip_string, strerror(errno) ));
+                               get_peer_addr(fd,addr,sizeof(addr)),
+                               strerror(errno) ));
                        } else {
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                "read. select error = %s.\n",
                                strerror(errno) ));
                        }
-                       smb_read_error = READ_ERROR;
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                /* Did we timeout ? */
                if (selrtn == 0) {
                        DEBUG(10,("read_socket_with_timeout: timeout read. "
                                "select timed out.\n"));
-                       smb_read_error = READ_TIMEOUT;
-                       return -1;
+                       return NT_STATUS_IO_TIMEOUT;
                }
 
                readret = sys_read(fd, buf+nread, maxcnt-nread);
@@ -936,77 +996,44 @@ ssize_t read_socket_with_timeout(int fd,
                        /* we got EOF on the file descriptor */
                        DEBUG(5,("read_socket_with_timeout: timeout read. "
                                "EOF from client.\n"));
-                       smb_read_error = READ_EOF;
-                       return -1;
+                       return NT_STATUS_END_OF_FILE;
                }
 
                if (readret == -1) {
                        /* the descriptor is probably dead */
-                       if (fd == client_fd) {
+                       if (fd == get_client_fd()) {
                                /* Try and give an error message
                                 * saying what client failed. */
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                        "read to client %s. read error = %s.\n",
-                                       client_ip_string, strerror(errno) ));
+                                       get_peer_addr(fd,addr,sizeof(addr)),
+                                       strerror(errno) ));
                        } else {
                                DEBUG(0,("read_socket_with_timeout: timeout "
                                        "read. read error = %s.\n",
                                        strerror(errno) ));
                        }
-                       smb_read_error = READ_ERROR;
-                       return -1;
+                       return map_nt_error_from_unix(errno);
                }
 
                nread += readret;
        }
 
+ done:
        /* Return the number we got */
-       return (ssize_t)nread;
+       if (size_ret) {
+               *size_ret = nread;
+       }
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
  Read data from the client, reading exactly N bytes.
 ****************************************************************************/
 
-ssize_t read_data(int fd,char *buffer,size_t N)
+NTSTATUS read_data(int fd, char *buffer, size_t N)
 {
-       ssize_t ret;
-       size_t total=0;
-
-       smb_read_error = 0;
-
-       while (total < N) {
-               ret = sys_read(fd,buffer + total,N - total);
-
-               if (ret == 0) {
-                       DEBUG(10,("read_data: read of %d returned 0. "
-                               "Error = %s\n",
-                               (int)(N - total), strerror(errno) ));
-                       smb_read_error = READ_EOF;
-                       return 0;
-               }
-
-               if (ret == -1) {
-                       if (fd == client_fd) {
-                               /* Try and give an error message saying
-                                * what client failed. */
-                               DEBUG(0,("read_data: read failure for %d "
-                                       "bytes to client %s. Error = %s\n",
-                                       (int)(N - total),
-                                       client_ip_string,
-                                       strerror(errno) ));
-                       } else {
-                               DEBUG(0,("read_data: read failure for %d. "
-                                       "Error = %s\n",
-                                       (int)(N - total),
-                                       strerror(errno) ));
-                       }
-                       smb_read_error = READ_ERROR;
-                       return -1;
-               }
-               total += ret;
-       }
-       return (ssize_t)total;
+       return read_socket_with_timeout(fd, buffer, N, N, 0, NULL);
 }
 
 /****************************************************************************
@@ -1017,17 +1044,19 @@ ssize_t write_data(int fd, const char *buffer, size_t N)
 {
        size_t total=0;
        ssize_t ret;
+       char addr[INET6_ADDRSTRLEN];
 
        while (total < N) {
                ret = sys_write(fd,buffer + total,N - total);
 
                if (ret == -1) {
-                       if (fd == client_fd) {
+                       if (fd == get_client_fd()) {
                                /* Try and give an error message saying
                                 * what client failed. */
                                DEBUG(0,("write_data: write failure in "
                                        "writing to client %s. Error %s\n",
-                                       client_ip_string, strerror(errno) ));
+                                       get_peer_addr(fd,addr,sizeof(addr)),
+                                       strerror(errno) ));
                        } else {
                                DEBUG(0,("write_data: write failure. "
                                        "Error = %s\n", strerror(errno) ));
@@ -1066,36 +1095,29 @@ bool send_keepalive(int client)
  Timeout is in milliseconds.
 ****************************************************************************/
 
-static ssize_t read_smb_length_return_keepalive(int fd,
-                                               char *inbuf,
-                                               unsigned int timeout)
+NTSTATUS read_smb_length_return_keepalive(int fd, char *inbuf,
+                                         unsigned int timeout,
+                                         size_t *len)
 {
-       ssize_t len=0;
        int msg_type;
-       bool ok = false;
+       NTSTATUS status;
 
-       while (!ok) {
-               if (timeout > 0) {
-                       ok = (read_socket_with_timeout(fd,inbuf,4,4,timeout)
-                                       == 4);
-               } else {
-                       ok = (read_data(fd,inbuf,4) == 4);
-               }
-               if (!ok) {
-                       return -1;
-               }
+       status = read_socket_with_timeout(fd, inbuf, 4, 4, timeout, NULL);
 
-               len = smb_len(inbuf);
-               msg_type = CVAL(inbuf,0);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
-               if (msg_type == SMBkeepalive) {
-                       DEBUG(5,("Got keepalive packet\n"));
-               }
+       *len = smb_len(inbuf);
+       msg_type = CVAL(inbuf,0);
+
+       if (msg_type == SMBkeepalive) {
+               DEBUG(5,("Got keepalive packet\n"));
        }
 
-       DEBUG(10,("got smb length of %lu\n",(unsigned long)len));
+       DEBUG(10,("got smb length of %lu\n",(unsigned long)(*len)));
 
-       return(len);
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1105,25 +1127,27 @@ static ssize_t read_smb_length_return_keepalive(int fd,
  Timeout is in milliseconds.
 ****************************************************************************/
 
-ssize_t read_smb_length(int fd, char *inbuf, unsigned int timeout)
+NTSTATUS read_smb_length(int fd, char *inbuf, unsigned int timeout,
+                        size_t *len)
 {
-       ssize_t len;
+       uint8_t msgtype = SMBkeepalive;
 
-       for(;;) {
-               len = read_smb_length_return_keepalive(fd, inbuf, timeout);
+       while (msgtype == SMBkeepalive) {
+               NTSTATUS status;
 
-               if(len < 0)
-                       return len;
+               status = read_smb_length_return_keepalive(fd, inbuf, timeout,
+                                                         len);
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
+               }
 
-               /* Ignore session keepalives. */
-               if(CVAL(inbuf,0) != SMBkeepalive)
-                       break;
+               msgtype = CVAL(inbuf, 0);
        }
 
        DEBUG(10,("read_smb_length: got smb length of %lu\n",
                  (unsigned long)len));
 
-       return len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1136,28 +1160,17 @@ ssize_t read_smb_length(int fd, char *inbuf, unsigned int timeout)
  Doesn't check the MAC on signed packets.
 ****************************************************************************/
 
-ssize_t receive_smb_raw(int fd,
-                       char *buffer,
-                       unsigned int timeout,
-                       size_t maxlen)
+NTSTATUS receive_smb_raw(int fd, char *buffer, unsigned int timeout,
+                        size_t maxlen, size_t *p_len)
 {
-       ssize_t len,ret;
-
-       smb_read_error = 0;
+       size_t len;
+       NTSTATUS status;
 
-       len = read_smb_length_return_keepalive(fd,buffer,timeout);
-       if (len < 0) {
-               DEBUG(10,("receive_smb_raw: length < 0!\n"));
+       status = read_smb_length_return_keepalive(fd,buffer,timeout,&len);
 
-               /*
-                * Correct fix. smb_read_error may have already been
-                * set. Only set it here if not already set. Global
-                * variables still suck :-). JRA.
-                */
-
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("receive_smb_raw: %s!\n", nt_errstr(status)));
+               return status;
        }
 
        /*
@@ -1169,16 +1182,7 @@ ssize_t receive_smb_raw(int fd,
                DEBUG(0,("Invalid packet length! (%lu bytes).\n",
                                        (unsigned long)len));
                if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
-
-                       /*
-                        * Correct fix. smb_read_error may have already been
-                        * set. Only set it here if not already set. Global
-                        * variables still suck :-). JRA.
-                        */
-
-                       if (smb_read_error == 0)
-                               smb_read_error = READ_ERROR;
-                       return -1;
+                       return NT_STATUS_INVALID_PARAMETER;
                }
        }
 
@@ -1187,21 +1191,11 @@ ssize_t receive_smb_raw(int fd,
                        len = MIN(len,maxlen);
                }
 
-               if (timeout > 0) {
-                       ret = read_socket_with_timeout(fd,
-                                       buffer+4,
-                                       len,
-                                       len,
-                                       timeout);
-               } else {
-                       ret = read_data(fd,buffer+4,len);
-               }
+               status = read_socket_with_timeout(
+                       fd, buffer+4, len, len, timeout, &len);
 
-               if (ret != len) {
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_ERROR;
-                       }
-                       return -1;
+               if (!NT_STATUS_IS_OK(status)) {
+                       return status;
                }
 
                /* not all of samba3 properly checks for packet-termination
@@ -1210,163 +1204,8 @@ ssize_t receive_smb_raw(int fd,
                SSVAL(buffer+4,len, 0);
        }
 
-       return len;
-}
-
-static ssize_t receive_smb_raw_talloc(TALLOC_CTX *mem_ctx, int fd,
-                                     char **buffer, unsigned int timeout)
-{
-       char lenbuf[4];
-       ssize_t len,ret;
-
-       smb_read_error = 0;
-
-       len = read_smb_length_return_keepalive(fd, lenbuf, timeout);
-       if (len < 0) {
-               DEBUG(10,("receive_smb_raw: length < 0!\n"));
-
-               /*
-                * Correct fix. smb_read_error may have already been
-                * set. Only set it here if not already set. Global
-                * variables still suck :-). JRA.
-                */
-
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
-       }
-
-       /*
-        * A WRITEX with CAP_LARGE_WRITEX can be 64k worth of data plus 65 bytes
-        * of header. Don't print the error if this fits.... JRA.
-        */
-
-       if (len > (BUFFER_SIZE + LARGE_WRITEX_HDR_SIZE)) {
-               DEBUG(0,("Invalid packet length! (%lu bytes).\n",
-                                       (unsigned long)len));
-               if (len > BUFFER_SIZE + (SAFETY_MARGIN/2)) {
-
-                       /*
-                        * Correct fix. smb_read_error may have already been
-                        * set. Only set it here if not already set. Global
-                        * variables still suck :-). JRA.
-                        */
-
-                       if (smb_read_error == 0)
-                               smb_read_error = READ_ERROR;
-                       return -1;
-               }
-       }
-
-       /*
-        * The +4 here can't wrap, we've checked the length above already.
-        */
-
-       *buffer = TALLOC_ARRAY(mem_ctx, char, len+4);
-
-       if (*buffer == NULL) {
-               DEBUG(0, ("Could not allocate inbuf of length %d\n",
-                         (int)len+4));
-               if (smb_read_error == 0)
-                       smb_read_error = READ_ERROR;
-               return -1;
-       }
-
-       memcpy(*buffer, lenbuf, sizeof(lenbuf));
-
-       if(len > 0) {
-               if (timeout > 0) {
-                       ret = read_socket_with_timeout(fd,(*buffer)+4, len,
-                                                      len, timeout);
-               } else {
-                       ret = read_data(fd, (*buffer)+4, len);
-               }
-
-               if (ret != len) {
-                       if (smb_read_error == 0) {
-                               smb_read_error = READ_ERROR;
-                       }
-                       return -1;
-               }
-       }
-
-       return len + 4;
-}
-
-/****************************************************************************
- Wrapper for receive_smb_raw().
- Checks the MAC on signed packets.
-****************************************************************************/
-
-bool receive_smb(int fd, char *buffer, unsigned int timeout)
-{
-       if (receive_smb_raw(fd, buffer, timeout, 0) < 0) {
-               return false;
-       }
-
-       /* Check the incoming SMB signature. */
-       if (!srv_check_sign_mac(buffer, true)) {
-               DEBUG(0, ("receive_smb: SMB Signature verification "
-                       "failed on incoming packet!\n"));
-               if (smb_read_error == 0) {
-                       smb_read_error = READ_BAD_SIG;
-               }
-               return false;
-       }
-
-       return true;
-}
-
-ssize_t receive_smb_talloc(TALLOC_CTX *mem_ctx, int fd, char **buffer,
-                          unsigned int timeout)
-{
-       ssize_t len;
-
-       len = receive_smb_raw_talloc(mem_ctx, fd, buffer, timeout);
-
-       if (len < 0) {
-               return -1;
-       }
-
-       /* Check the incoming SMB signature. */
-       if (!srv_check_sign_mac(*buffer, true)) {
-               DEBUG(0, ("receive_smb: SMB Signature verification failed on "
-                         "incoming packet!\n"));
-               if (smb_read_error == 0) {
-                       smb_read_error = READ_BAD_SIG;
-               }
-               return -1;
-       }
-
-       return len;
-}
-
-/****************************************************************************
- Send an smb to a fd.
-****************************************************************************/
-
-bool send_smb(int fd, char *buffer)
-{
-       size_t len;
-       size_t nwritten=0;
-       ssize_t ret;
-
-       /* Sign the outgoing packet if required. */
-       srv_calculate_sign_mac(buffer);
-
-       len = smb_len(buffer) + 4;
-
-       while (nwritten < len) {
-               ret = write_data(fd,buffer+nwritten,len - nwritten);
-               if (ret <= 0) {
-                       DEBUG(0,("Error writing %d bytes to client. %d. (%s)\n",
-                               (int)len,(int)ret, strerror(errno) ));
-                       return false;
-               }
-               nwritten += ret;
-       }
-
-       return true;
+       *p_len = len;
+       return NT_STATUS_OK;
 }
 
 /****************************************************************************
@@ -1381,12 +1220,14 @@ int open_socket_in(int type,
 {
        struct sockaddr_storage sock;
        int res;
+       socklen_t slen = sizeof(struct sockaddr_in);
 
        sock = *psock;
 
 #if defined(HAVE_IPV6)
        if (sock.ss_family == AF_INET6) {
                ((struct sockaddr_in6 *)&sock)->sin6_port = htons(port);
+               slen = sizeof(struct sockaddr_in6);
        }
 #endif
        if (sock.ss_family == AF_INET) {
@@ -1430,7 +1271,7 @@ int open_socket_in(int type,
        }
 
        /* now we've got a socket - we need to bind it */
-       if( bind( res, (struct sockaddr *)&sock, sizeof(sock) ) == -1 ) {
+       if (bind(res, (struct sockaddr *)&sock, slen) == -1 ) {
                if( DEBUGLVL(dlevel) && (port == SMB_PORT1 ||
                                port == SMB_PORT2 || port == NMB_PORT) ) {
                        char addr[INET6_ADDRSTRLEN];
@@ -1500,7 +1341,7 @@ int open_socket_out(int type,
        /* and connect it to the destination */
   connect_again:
 
-       ret = connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out));
+       ret = sys_connect(res, (struct sockaddr *)&sock_out);
 
        /* Some systems return EAGAIN when they mean EINPROGRESS */
        if (ret < 0 && (errno == EINPROGRESS || errno == EALREADY ||
@@ -1588,12 +1429,13 @@ bool open_any_socket_out(struct sockaddr_storage *addrs, int num_addrs,
        good_connect = false;
 
        for (i=0; i<num_addrs; i++) {
+               const struct sockaddr * a = 
+                   (const struct sockaddr *)&(addrs[i]);
 
                if (sockets[i] == -1)
                        continue;
 
-               if (connect(sockets[i], (struct sockaddr *)&(addrs[i]),
-                           sizeof(*addrs)) == 0) {
+               if (sys_connect(sockets[i], a) == 0) {
                        /* Rather unlikely as we are non-blocking, but it
                         * might actually happen. */
                        resulting_index = i;
@@ -1708,9 +1550,9 @@ int open_udp_socket(const char *host, int port)
        int type = SOCK_DGRAM;
        struct sockaddr_in sock_out;
        int res;
-       struct in_addr *addr;
+       struct in_addr addr;
 
-       addr = interpret_addr2(host);
+       (void)interpret_addr2(&addr, host);
 
        res = socket(PF_INET, type, 0);
        if (res == -1) {
@@ -1718,11 +1560,11 @@ int open_udp_socket(const char *host, int port)
        }
 
        memset((char *)&sock_out,'\0',sizeof(sock_out));
-       putip((char *)&sock_out.sin_addr,(char *)addr);
+       putip((char *)&sock_out.sin_addr,(char *)&addr);
        sock_out.sin_port = htons(port);
        sock_out.sin_family = PF_INET;
 
-       if (connect(res,(struct sockaddr *)&sock_out,sizeof(sock_out))) {
+       if (sys_connect(res,(struct sockaddr *)&sock_out)) {
                close(res);
                return -1;
        }
@@ -1736,14 +1578,15 @@ int open_udp_socket(const char *host, int port)
  ******************************************************************/
 
 static const char *get_peer_addr_internal(int fd,
+                               char *addr_buf,
+                               size_t addr_buf_len,
                                struct sockaddr_storage *pss,
                                socklen_t *plength)
 {
        struct sockaddr_storage ss;
        socklen_t length = sizeof(ss);
-       static char addr_buf[INET6_ADDRSTRLEN];
 
-       safe_strcpy(addr_buf,"0.0.0.0",sizeof(addr_buf)-1);
+       strlcpy(addr_buf,"0.0.0.0",addr_buf_len);
 
        if (fd == -1) {
                return addr_buf;
@@ -1763,13 +1606,12 @@ static const char *get_peer_addr_internal(int fd,
        }
 
        print_sockaddr_len(addr_buf,
-                       sizeof(addr_buf),
+                       addr_buf_len,
                        pss,
                        *plength);
        return addr_buf;
 }
 
-
 /*******************************************************************
  Matchname - determine if host name matches IP address. Used to
  confirm a hostname lookup to prevent spoof attacks.
@@ -1840,44 +1682,104 @@ static bool matchname(const char *remotehost,
        return false;
 }
 
+/*******************************************************************
+ Deal with the singleton cache.
+******************************************************************/
+
+struct name_addr_pair {
+       struct sockaddr_storage ss;
+       const char *name;
+};
+
+/*******************************************************************
+ Lookup a name/addr pair. Returns memory allocated from memcache.
+******************************************************************/
+
+static bool lookup_nc(struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+
+       ZERO_STRUCTP(nc);
+
+       if (!memcache_lookup(
+                       NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       &tmp)) {
+               return false;
+       }
+
+       memcpy(&nc->ss, tmp.data, sizeof(nc->ss));
+       nc->name = (const char *)tmp.data + sizeof(nc->ss);
+       return true;
+}
+
+/*******************************************************************
+ Save a name/addr pair.
+******************************************************************/
+
+static void store_nc(const struct name_addr_pair *nc)
+{
+       DATA_BLOB tmp;
+       size_t namelen = strlen(nc->name);
+
+       tmp = data_blob(NULL, sizeof(nc->ss) + namelen + 1);
+       if (!tmp.data) {
+               return;
+       }
+       memcpy(tmp.data, &nc->ss, sizeof(nc->ss));
+       memcpy(tmp.data+sizeof(nc->ss), nc->name, namelen+1);
+
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_peer_name"),
+                       tmp);
+       data_blob_free(&tmp);
+}
+
 /*******************************************************************
  Return the DNS name of the remote end of a socket.
 ******************************************************************/
 
 const char *get_peer_name(int fd, bool force_lookup)
 {
-       static fstring addr_buf;
-       static pstring name_buf;
+       struct name_addr_pair nc;
+       char addr_buf[INET6_ADDRSTRLEN];
        struct sockaddr_storage ss;
        socklen_t length = sizeof(ss);
        const char *p;
        int ret;
-       pstring tmp_name;
+       char name_buf[MAX_DNS_NAME_LENGTH];
+       char tmp_name[MAX_DNS_NAME_LENGTH];
 
        /* reverse lookups can be *very* expensive, and in many
           situations won't work because many networks don't link dhcp
           with dns. To avoid the delay we avoid the lookup if
           possible */
        if (!lp_hostname_lookups() && (force_lookup == false)) {
-               return get_peer_addr(fd);
+               length = sizeof(nc.ss);
+               nc.name = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf),
+                       &nc.ss, &length);
+               store_nc(&nc);
+               lookup_nc(&nc);
+               return nc.name ? nc.name : "UNKNOWN";
        }
 
-       p = get_peer_addr_internal(fd, &ss, &length);
+       lookup_nc(&nc);
+
+       memset(&ss, '\0', sizeof(ss));
+       p = get_peer_addr_internal(fd, addr_buf, sizeof(addr_buf), &ss, &length);
 
        /* it might be the same as the last one - save some DNS work */
-       if (strcmp(p, addr_buf) == 0) {
-               return name_buf;
+       if (addr_equal(&ss, &nc.ss)) {
+               return nc.name ? nc.name : "UNKNOWN";
        }
 
-       pstrcpy(name_buf,"UNKNOWN");
+       /* Not the same. We need to lookup. */
        if (fd == -1) {
-               return name_buf;
+               return "UNKNOWN";
        }
 
-       fstrcpy(addr_buf, p);
-
        /* Look up the remote host name. */
-       ret = getnameinfo((struct sockaddr *)&ss,
+       ret = sys_getnameinfo((struct sockaddr *)&ss,
                        length,
                        name_buf,
                        sizeof(name_buf),
@@ -1890,11 +1792,11 @@ const char *get_peer_name(int fd, bool force_lookup)
                        "for %s with error %s\n",
                        p,
                        gai_strerror(ret)));
-               pstrcpy(name_buf, p);
+               strlcpy(name_buf, p, sizeof(name_buf));
        } else {
                if (!matchname(name_buf, &ss, length)) {
                        DEBUG(0,("Matchname failed on %s %s\n",name_buf,p));
-                       pstrcpy(name_buf,"UNKNOWN");
+                       strlcpy(name_buf,"UNKNOWN",sizeof(name_buf));
                }
        }
 
@@ -1902,22 +1804,27 @@ const char *get_peer_name(int fd, bool force_lookup)
           use --enable-developer or the clobber_region() call will
           get you */
 
-       pstrcpy(tmp_name, name_buf );
+       strlcpy(tmp_name, name_buf, sizeof(tmp_name));
        alpha_strcpy(name_buf, tmp_name, "_-.", sizeof(name_buf));
        if (strstr(name_buf,"..")) {
-               pstrcpy(name_buf, "UNKNOWN");
+               strlcpy(name_buf, "UNKNOWN", sizeof(name_buf));
        }
 
-       return name_buf;
+       nc.name = name_buf;
+       nc.ss = ss;
+
+       store_nc(&nc);
+       lookup_nc(&nc);
+       return nc.name ? nc.name : "UNKNOWN";
 }
 
 /*******************************************************************
  Return the IP addr of the remote end of a socket as a string.
  ******************************************************************/
 
-const char *get_peer_addr(int fd)
+const char *get_peer_addr(int fd, char *addr, size_t addr_len)
 {
-       return get_peer_addr_internal(fd, NULL, NULL);
+       return get_peer_addr_internal(fd, addr, addr_len, NULL, NULL);
 }
 
 /*******************************************************************
@@ -1937,7 +1844,7 @@ int create_pipe_sock(const char *socket_dir,
        struct stat st;
        int sock;
        mode_t old_umask;
-       pstring path;
+       char *path = NULL;
 
        old_umask = umask(0);
 
@@ -1977,16 +1884,19 @@ int create_pipe_sock(const char *socket_dir,
        sock = socket(AF_UNIX, SOCK_STREAM, 0);
 
        if (sock == -1) {
-               perror("socket");
-                goto out_umask;
+               DEBUG(0, ("create_pipe_sock: socket error %s\n",
+                       strerror(errno) ));
+                goto out_close;
        }
 
-       pstr_sprintf(path, "%s/%s", socket_dir, socket_name);
+       if (asprintf(&path, "%s/%s", socket_dir, socket_name) == -1) {
+                goto out_close;
+       }
 
        unlink(path);
        memset(&sunaddr, 0, sizeof(sunaddr));
        sunaddr.sun_family = AF_UNIX;
-       safe_strcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path)-1);
+       strlcpy(sunaddr.sun_path, path, sizeof(sunaddr.sun_path));
 
        if (bind(sock, (struct sockaddr *)&sunaddr, sizeof(sunaddr)) == -1) {
                DEBUG(0, ("bind failed on pipe socket %s: %s\n", path,
@@ -2000,11 +1910,15 @@ int create_pipe_sock(const char *socket_dir,
                goto out_close;
        }
 
+       SAFE_FREE(path);
+
        umask(old_umask);
        return sock;
 
 out_close:
-       close(sock);
+       SAFE_FREE(path);
+       if (sock != -1)
+               close(sock);
 
 out_umask:
        umask(old_umask);
@@ -2020,54 +1934,71 @@ out_umask:
  Get my own canonical name, including domain.
 ****************************************************************************/
 
-bool get_mydnsfullname(fstring my_dnsname)
+const char *get_mydnsfullname(void)
 {
-       static fstring dnshostname;
+       struct addrinfo *res = NULL;
+       char my_hostname[HOST_NAME_MAX];
+       bool ret;
+       DATA_BLOB tmp;
 
-       if (!*dnshostname) {
-               struct addrinfo *res = NULL;
-               bool ret;
+       if (memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               SMB_ASSERT(tmp.length > 0);
+               return (const char *)tmp.data;
+       }
 
-               /* get my host name */
-               if (gethostname(dnshostname, sizeof(dnshostname)) == -1) {
-                       *dnshostname = '\0';
-                       DEBUG(0,("get_mydnsfullname: gethostname failed\n"));
-                       return false;
-               }
+       /* get my host name */
+       if (gethostname(my_hostname, sizeof(my_hostname)) == -1) {
+               DEBUG(0,("get_mydnsfullname: gethostname failed\n"));
+               return NULL;
+       }
 
-               /* Ensure null termination. */
-               dnshostname[sizeof(dnshostname)-1] = '\0';
+       /* Ensure null termination. */
+       my_hostname[sizeof(my_hostname)-1] = '\0';
 
-               ret = interpret_string_addr_internal(&res,
-                                       dnshostname,
-                                       AI_ADDRCONFIG|AI_CANONNAME);
+       ret = interpret_string_addr_internal(&res,
+                               my_hostname,
+                               AI_ADDRCONFIG|AI_CANONNAME);
 
-               if (!ret || res == NULL) {
-                       DEBUG(3,("get_mydnsfullname: getaddrinfo failed for "
-                               "name %s [%s]\n",
-                               dnshostname,
-                               gai_strerror(ret) ));
-                       return false;
-               }
+       if (!ret || res == NULL) {
+               DEBUG(3,("get_mydnsfullname: getaddrinfo failed for "
+                       "name %s [%s]\n",
+                       my_hostname,
+                       gai_strerror(ret) ));
+               return NULL;
+       }
 
-               /*
-                * Make sure that getaddrinfo() returns the "correct" host name.
-                */
+       /*
+        * Make sure that getaddrinfo() returns the "correct" host name.
+        */
 
-               if (res->ai_canonname == NULL) {
-                       DEBUG(3,("get_mydnsfullname: failed to get "
-                               "canonical name for %s\n",
-                               dnshostname));
-                       freeaddrinfo(res);
-                       return false;
-               }
+       if (res->ai_canonname == NULL) {
+               DEBUG(3,("get_mydnsfullname: failed to get "
+                       "canonical name for %s\n",
+                       my_hostname));
+               freeaddrinfo(res);
+               return NULL;
+       }
 
+       /* This copies the data, so we must do a lookup
+        * afterwards to find the value to return.
+        */
 
-               fstrcpy(dnshostname, res->ai_canonname);
-               freeaddrinfo(res);
+       memcache_add(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       data_blob_string_const(res->ai_canonname));
+
+       if (!memcache_lookup(NULL, SINGLETON_CACHE,
+                       data_blob_string_const("get_mydnsfullname"),
+                       &tmp)) {
+               tmp = data_blob_talloc(talloc_tos(), res->ai_canonname,
+                               strlen(res->ai_canonname) + 1);
        }
-       fstrcpy(my_dnsname, dnshostname);
-       return true;
+
+       freeaddrinfo(res);
+
+       return (const char *)tmp.data;
 }
 
 /************************************************************
@@ -2076,15 +2007,20 @@ bool get_mydnsfullname(fstring my_dnsname)
 
 bool is_myname_or_ipaddr(const char *s)
 {
-       fstring name, dnsname;
-       char *servername;
+       TALLOC_CTX *ctx = talloc_tos();
+       char *name = NULL;
+       const char *dnsname;
+       char *servername = NULL;
 
        if (!s) {
                return false;
        }
 
        /* Santize the string from '\\name' */
-       fstrcpy(name, s);
+       name = talloc_strdup(ctx, s);
+       if (!name) {
+               return false;
+       }
 
        servername = strrchr_m(name, '\\' );
        if (!servername) {
@@ -2114,10 +2050,9 @@ bool is_myname_or_ipaddr(const char *s)
        }
 
        /* Maybe it's my dns name */
-       if (get_mydnsfullname(dnsname)) {
-               if (strequal(servername, dnsname)) {
-                       return true;
-               }
+       dnsname = get_mydnsfullname();
+       if (dnsname && strequal(servername, dnsname)) {
+               return true;
        }
 
        /* Handle possible CNAME records - convert to an IP addr. */
@@ -2135,7 +2070,7 @@ bool is_myname_or_ipaddr(const char *s)
        /* Maybe its an IP address? */
        if (is_ipaddress(servername)) {
                struct sockaddr_storage ss;
-               struct iface_struct nics[MAX_INTERFACES];
+               struct iface_struct *nics;
                int i, n;
 
                if (!interpret_string_addr(&ss, servername, AI_NUMERICHOST)) {
@@ -2146,12 +2081,19 @@ bool is_myname_or_ipaddr(const char *s)
                        return false;
                }
 
+               nics = TALLOC_ARRAY(ctx, struct iface_struct,
+                                       MAX_INTERFACES);
+               if (!nics) {
+                       return false;
+               }
                n = get_interfaces(nics, MAX_INTERFACES);
                for (i=0; i<n; i++) {
                        if (addr_equal(&nics[i].ip, &ss)) {
+                               TALLOC_FREE(nics);
                                return true;
                        }
                }
+               TALLOC_FREE(nics);
        }
 
        /* No match */