Fix double free of apr pools from subvertpy.repos.Repos.fs.
authorJelmer Vernooij <jelmer@samba.org>
Mon, 19 Sep 2011 16:01:29 +0000 (18:01 +0200)
committerJelmer Vernooij <jelmer@samba.org>
Mon, 19 Sep 2011 16:01:29 +0000 (18:01 +0200)
NEWS
subvertpy/repos.c

diff --git a/NEWS b/NEWS
index 0b9d9fb..ee3b029 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -25,6 +25,9 @@
   * Fix memory leak in subvertpy.client.Client.list.
     (Wez Furlong)
 
+  * Fix double free of apr pools from subverty.repos.Repos.fs.
+    (Roland Mas, Jelmer Vernooij, #853960)
+
 0.8.5  2011-08-21 "boomerang arrow"
 
  BUG FIXES
index 430cad1..b82ea08 100644 (file)
@@ -123,7 +123,6 @@ typedef struct {
 typedef struct {
        PyObject_HEAD
        RepositoryObject *repos;
-       apr_pool_t *pool;
        svn_fs_t *fs;
 } FileSystemObject;
 
@@ -146,7 +145,6 @@ static PyObject *repos_fs(PyObject *self)
 
        ret->fs = fs;
        ret->repos = reposobj;
-       ret->pool = reposobj->pool;
        Py_INCREF(reposobj);
 
        return (PyObject *)ret;
@@ -246,7 +244,6 @@ static void fs_dealloc(PyObject *self)
 {
        FileSystemObject *fsobj = (FileSystemObject *)self;
        Py_DECREF(fsobj->repos);
-       apr_pool_destroy(fsobj->pool);
        PyObject_DEL(fsobj);
 }