RAW-OPLOCK: add BATCH22 and test the behavior of oplock break timeouts

metze

diff --git a/source/torture/raw/oplock.c b/source/torture/raw/oplock.c
index aab8f6fdfbae570cf3a66c465dcde2f6af051631..8a7489c84e83b0dfdd99bda4e3df17f79dd1e01f 100644 (file)
--- a/source/torture/raw/oplock.c
+++ b/source/torture/raw/oplock.c
@@ -32,6 +32,13 @@
                ret = false; \
        }} while (0)
 
+#define CHECK_RANGE(v, min, max) do { \
+       if ((v) < (min) || (v) > (max)) { \
+               torture_result(tctx, TORTURE_FAIL, "(%s): wrong value for %s got %d - should be between %d and %d\n", \
+                               __location__, #v, (int)v, (int)min, (int)max); \
+               ret = false; \
+       }} while (0)
+
 #define CHECK_STRMATCH(v, correct) do { \
        if (!v || strstr((v),(correct)) == NULL) { \
                torture_result(tctx, TORTURE_FAIL,  "(%s): wrong value for %s got '%s' - should be '%s'\n", \
@@ -92,6 +99,21 @@ static bool oplock_handler_ack_to_none(struct smbcli_transport *transport,
        return smbcli_oplock_ack(tree, fnum, OPLOCK_BREAK_TO_NONE);
 }
 
+/*
+  a handler function for oplock break requests. Let it timeout
+*/
+static bool oplock_handler_timeout(struct smbcli_transport *transport,
+                                  uint16_t tid, uint16_t fnum,
+                                  uint8_t level, void *private)
+{
+       break_info.fnum = fnum;
+       break_info.level = level;
+       break_info.count++;
+
+       printf("Let oplock break timeout\n");
+       return true;
+}
+
 static void oplock_handler_close_recv(struct smbcli_request *req)
 {
        NTSTATUS status;
@@ -2273,6 +2295,101 @@ done:
        return ret;
 }
 
+static bool test_raw_oplock_batch22(struct torture_context *tctx, struct smbcli_state *cli1, struct smbcli_state *cli2)
+{
+       const char *fname = BASEDIR "\\test_batch22.dat";
+       NTSTATUS status;
+       bool ret = true;
+       union smb_open io;
+       union smb_unlink unl;
+       uint16_t fnum=0, fnum2=0;
+       char c = 0;
+       struct timeval tv;
+       int timeout = torture_setting_int(tctx, "oplocktimeout", 30);
+       int te;
+       ssize_t wr;
+
+       if (torture_setting_bool(tctx, "samba3", false)) {
+               torture_skip(tctx, "BACHT22 disabled against samba3\n");
+       }
+
+       if (!torture_setup_dir(cli1, BASEDIR)) {
+               return false;
+       }
+
+       /* cleanup */
+       smbcli_unlink(cli1->tree, fname);
+
+       smbcli_oplock_handler(cli1->transport, oplock_handler_ack_to_levelII, cli1->tree);
+
+       /*
+         base ntcreatex parms
+       */
+       io.generic.level = RAW_OPEN_NTCREATEX;
+       io.ntcreatex.in.root_fid = 0;
+       io.ntcreatex.in.access_mask = SEC_RIGHTS_FILE_ALL;
+       io.ntcreatex.in.alloc_size = 0;
+       io.ntcreatex.in.file_attr = FILE_ATTRIBUTE_NORMAL;
+       io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_NONE;
+       io.ntcreatex.in.open_disposition = NTCREATEX_DISP_OPEN_IF;
+       io.ntcreatex.in.create_options = 0;
+       io.ntcreatex.in.impersonation = NTCREATEX_IMPERSONATION_ANONYMOUS;
+       io.ntcreatex.in.security_flags = 0;
+       io.ntcreatex.in.fname = fname;
+
+       /*
+         with a batch oplock we get a break
+       */
+       torture_comment(tctx, "open with batch oplock\n");
+       ZERO_STRUCT(break_info);
+       io.ntcreatex.in.flags = NTCREATEX_FLAGS_EXTENDED |
+               NTCREATEX_FLAGS_REQUEST_OPLOCK |
+               NTCREATEX_FLAGS_REQUEST_BATCH_OPLOCK;
+       io.ntcreatex.in.share_access = NTCREATEX_SHARE_ACCESS_READ|
+               NTCREATEX_SHARE_ACCESS_WRITE|
+               NTCREATEX_SHARE_ACCESS_DELETE;
+       status = smb_raw_open(cli1->tree, tctx, &io);
+       CHECK_STATUS(tctx, status, NT_STATUS_OK);
+       fnum = io.ntcreatex.out.file.fnum;
+       CHECK_VAL(io.ntcreatex.out.oplock_level, BATCH_OPLOCK_RETURN);
+
+       torture_comment(tctx, "a 2nd open shoud not succeed after the oplock break timeout\n");
+       tv = timeval_current();
+       smbcli_oplock_handler(cli1->transport, oplock_handler_timeout, cli1->tree);
+       status = smb_raw_open(cli1->tree, tctx, &io);
+       CHECK_STATUS(tctx, status, NT_STATUS_SHARING_VIOLATION);
+       te = (int)timeval_elapsed(&tv);
+       CHECK_RANGE(te, timeout - 1, timeout + 15);
+
+       CHECK_VAL(break_info.count, 1);
+       CHECK_VAL(break_info.fnum, fnum);
+       CHECK_VAL(break_info.level, OPLOCK_BREAK_TO_LEVEL_II);
+       CHECK_VAL(break_info.failures, 0);
+       ZERO_STRUCT(break_info);
+
+       torture_comment(tctx, "a 2nd open shoud succeed after the oplock release without break\n");
+       tv = timeval_current();
+       smbcli_oplock_handler(cli1->transport, oplock_handler_ack_to_levelII, cli1->tree);
+       status = smb_raw_open(cli1->tree, tctx, &io);
+       CHECK_STATUS(tctx, status, NT_STATUS_OK);
+       CHECK_VAL(io.ntcreatex.out.oplock_level, LEVEL_II_OPLOCK_RETURN);
+       te = (int)timeval_elapsed(&tv);
+       /* it should come in without delay */
+       CHECK_RANGE(te+1, 0, timeout);
+       fnum2 = io.ntcreatex.out.file.fnum;
+
+       CHECK_VAL(break_info.count, 0);
+
+       smbcli_close(cli1->tree, fnum);
+       smbcli_close(cli1->tree, fnum2);
+
+done:
+       smb_raw_exit(cli1->session);
+       smb_raw_exit(cli2->session);
+       smbcli_deltree(cli1->tree, BASEDIR);
+       return ret;
+}
+
 /* 
    basic testing of oplocks
 */
@@ -2307,6 +2424,7 @@ struct torture_suite *torture_raw_oplock(TALLOC_CTX *mem_ctx)
        torture_suite_add_2smb_test(suite, "BATCH19", test_raw_oplock_batch19);
        torture_suite_add_2smb_test(suite, "BATCH20", test_raw_oplock_batch20);
        torture_suite_add_2smb_test(suite, "BATCH21", test_raw_oplock_batch21);
+       torture_suite_add_2smb_test(suite, "BATCH22", test_raw_oplock_batch22);
 
        return suite;
 }