From: Jelmer Vernooij <jelmer@samba.org>
Date: Tue, 9 Mar 2010 13:15:31 +0000 (+0100)
Subject: Fix Repository.__setitem__.
X-Git-Tag: rc-walker-ack-v4~17
X-Git-Url: http://git.samba.org/samba.git/?p=jelmer%2Fdulwich-libgit2.git;a=commitdiff_plain;h=5ab685cb2bb2dd0f1b0fff1b35aea1ca37201e86

Fix Repository.__setitem__.
---

diff --git a/dulwich/repo.py b/dulwich/repo.py
index 520fe57..ef3e9ff 100644
--- a/dulwich/repo.py
+++ b/dulwich/repo.py
@@ -792,7 +792,8 @@ class BaseRepo(object):
                 self.refs[name] = value
             else:
                 raise TypeError(value)
-        raise ValueError(name)
+        else:
+            raise ValueError(name)
 
     def __delitem__(self, name):
         if name.startswith("refs") or name == "HEAD":
diff --git a/dulwich/tests/test_repository.py b/dulwich/tests/test_repository.py
index 2634407..14871c7 100644
--- a/dulwich/tests/test_repository.py
+++ b/dulwich/tests/test_repository.py
@@ -72,6 +72,12 @@ class RepositoryTests(unittest.TestCase):
         r = self._repo = open_repo('a.git')
         self.assertEqual(r.ref('refs/heads/master'),
                          'a90fa2d900a17e99b433217e988c4eb4a2e9a097')
+
+    def test_setitem(self):
+        r = self._repo = open_repo('a.git')
+        r["refs/tags/foo"] = 'a90fa2d900a17e99b433217e988c4eb4a2e9a097'
+        self.assertEquals('a90fa2d900a17e99b433217e988c4eb4a2e9a097',
+                          r["refs/tags/foo"].id)
   
     def test_get_refs(self):
         r = self._repo = open_repo('a.git')
@@ -235,6 +241,7 @@ THREES = "3" * 40
 FOURS = "4" * 40
 
 class PackedRefsFileTests(unittest.TestCase):
+
     def test_split_ref_line_errors(self):
         self.assertRaises(errors.PackedRefsException, _split_ref_line,
                           'singlefield')
@@ -283,6 +290,7 @@ class PackedRefsFileTests(unittest.TestCase):
 
 
 class RefsContainerTests(unittest.TestCase):
+
     def setUp(self):
         self._repo = open_repo('refs.git')
         self._refs = self._repo.refs