jarrpa/samba-autobuild/.git
2 years agoctdb: Add new helper ctdb_etcd_lock etcd-commit master
Jose A. Rivera [Mon, 25 Jul 2016 19:58:16 +0000 (14:58 -0500)]
ctdb: Add new helper ctdb_etcd_lock

This introduces a mutex helper called ctdb_etcd_lock, which allows CTDB to
use an existing etcd cluster to provide the functionality of a recovery lock
using the API outlined in ctdb/doc/cluster_mutex_helper.txt.

Signed-off-by: Jose A. Rivera <jarrpa@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
2 years agoctdb-recovery: Start recovery helper with ctdb_vfork_exec
Amitay Isaacs [Wed, 30 Nov 2016 01:23:04 +0000 (12:23 +1100)]
ctdb-recovery: Start recovery helper with ctdb_vfork_exec

The recovery helper does it's own logging, so there is no need to
pass logfd.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
Autobuild-User(master): Martin Schwenke <martins@samba.org>
Autobuild-Date(master): Mon Dec  5 11:59:42 CET 2016 on sn-devel-144

2 years agoctdb-locking: Start locking helper using ctdb_vfork_exec
Amitay Isaacs [Wed, 30 Nov 2016 01:22:02 +0000 (12:22 +1100)]
ctdb-locking: Start locking helper using ctdb_vfork_exec

This avoids the extra argument of logfd to ctdb_lock_helper.  The log
messages from lock helper are captured by ctdbd.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Add ctdb_vfork_exec()
Amitay Isaacs [Wed, 30 Nov 2016 01:15:11 +0000 (12:15 +1100)]
ctdb-daemon: Add ctdb_vfork_exec()

This will replace ctdb_vfork_with_logging().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Log to stderr when running in interactive mode
Amitay Isaacs [Tue, 29 Nov 2016 06:52:00 +0000 (17:52 +1100)]
ctdb-daemon: Log to stderr when running in interactive mode

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Initialize logging in recovery daemon
Amitay Isaacs [Tue, 29 Nov 2016 05:49:41 +0000 (16:49 +1100)]
ctdb-daemon: Initialize logging in recovery daemon

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-recoverd: Log a message when terminating
Amitay Isaacs [Fri, 25 Nov 2016 03:57:30 +0000 (14:57 +1100)]
ctdb-recoverd: Log a message when terminating

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-logging: Get rid of debug_extra
Amitay Isaacs [Tue, 29 Nov 2016 06:59:32 +0000 (17:59 +1100)]
ctdb-logging: Get rid of debug_extra

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Remove setting of debug_extra
Amitay Isaacs [Fri, 25 Nov 2016 03:50:01 +0000 (14:50 +1100)]
ctdb-daemon: Remove setting of debug_extra

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Remove setting of debug_extra from switch_from_server_to_client()
Amitay Isaacs [Fri, 25 Nov 2016 03:44:10 +0000 (14:44 +1100)]
ctdb-daemon: Remove setting of debug_extra from switch_from_server_to_client()

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Remove setting of debug_extra via ctdb_set_child_info()
Amitay Isaacs [Fri, 25 Nov 2016 03:37:17 +0000 (14:37 +1100)]
ctdb-daemon: Remove setting of debug_extra via ctdb_set_child_info()

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Don't depend on debug_extra in exit handler
Amitay Isaacs [Fri, 25 Nov 2016 03:54:07 +0000 (14:54 +1100)]
ctdb-daemon: Don't depend on debug_extra in exit handler

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Fix debug messages
Amitay Isaacs [Wed, 30 Nov 2016 06:04:54 +0000 (17:04 +1100)]
ctdb-daemon: Fix debug messages

- Use fprintf() before logging is initialized
- replace DEBUG_ALERT with DEBUG_ERR

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-daemon: Consolidate initialization of logging and debug level
Amitay Isaacs [Wed, 30 Nov 2016 05:46:19 +0000 (16:46 +1100)]
ctdb-daemon: Consolidate initialization of logging and debug level

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-logging: Remove duplicate logging code
Amitay Isaacs [Tue, 29 Nov 2016 05:36:57 +0000 (16:36 +1100)]
ctdb-logging: Remove duplicate logging code

ctdb_logging_init() now uses logging_init().

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-logging: Refactor logging code
Amitay Isaacs [Tue, 29 Nov 2016 05:17:23 +0000 (16:17 +1100)]
ctdb-logging: Refactor logging code

This extracts the code from following files:
  - server/ctdb_logging.c
  - server/ctdb_logging_file.c
  - server/ctdb_logging_syslog.c

This is in preparation for each daemon (and some processes) doing
their own loging instead of relying on CTDB.

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agoctdb-logging: Use Samba's debug levels
Martin Schwenke [Wed, 23 Nov 2016 08:03:23 +0000 (19:03 +1100)]
ctdb-logging: Use Samba's debug levels

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-scripts: Update CTDB_SCRIPT_DEBUGLEVEL to be symbolic
Martin Schwenke [Wed, 23 Nov 2016 10:36:36 +0000 (21:36 +1100)]
ctdb-scripts: Update CTDB_SCRIPT_DEBUGLEVEL to be symbolic

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-tests: Use symbolic debug levels in tool tests
Martin Schwenke [Wed, 23 Nov 2016 10:38:14 +0000 (21:38 +1100)]
ctdb-tests: Use symbolic debug levels in tool tests

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-tests: Use symbolic debug levels in eventscript tests
Martin Schwenke [Wed, 23 Nov 2016 10:37:45 +0000 (21:37 +1100)]
ctdb-tests: Use symbolic debug levels in eventscript tests

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-tests: Use symbolic debug level for local daemons
Martin Schwenke [Wed, 23 Nov 2016 06:01:54 +0000 (17:01 +1100)]
ctdb-tests: Use symbolic debug level for local daemons

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-tests: Use symbolic debug levels in takeover tests
Martin Schwenke [Wed, 23 Nov 2016 09:40:50 +0000 (20:40 +1100)]
ctdb-tests: Use symbolic debug levels in takeover tests

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-tests: Support symbolic debug level in takeover tests
Martin Schwenke [Wed, 23 Nov 2016 08:16:56 +0000 (19:16 +1100)]
ctdb-tests: Support symbolic debug level in takeover tests

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-doc: Don't advertise numeric debug levels
Martin Schwenke [Wed, 23 Nov 2016 05:51:53 +0000 (16:51 +1100)]
ctdb-doc: Don't advertise numeric debug levels

The plan is to switch to Samba's (incompatible) debug levels, so just
expect CTDB users to use the symbolic name for the debug level.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-logging: Drop enum debug_level
Martin Schwenke [Fri, 25 Nov 2016 02:23:11 +0000 (13:23 +1100)]
ctdb-logging: Drop enum debug_level

We are switching to Samba-style integer debug levels.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
2 years agoctdb-daemon: Remove tevent debug logging
Amitay Isaacs [Mon, 24 Oct 2016 05:53:12 +0000 (16:53 +1100)]
ctdb-daemon: Remove tevent debug logging

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Martin Schwenke <martin@meltin.net>
2 years agodebug: Add minimalist D_* macros
Martin Schwenke [Thu, 24 Nov 2016 03:48:04 +0000 (14:48 +1100)]
debug: Add minimalist D_* macros

These don't include the function name or any other header.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Mon Dec  5 05:58:48 CET 2016 on sn-devel-144

2 years agoidmap_hash: stdio.h comes with replace.h
Volker Lendecke [Tue, 22 Nov 2016 00:31:19 +0000 (01:31 +0100)]
idmap_hash: stdio.h comes with replace.h

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Sun Dec  4 20:20:19 CET 2016 on sn-devel-144

2 years agoidmap_hash: Make lw_map_file static
Volker Lendecke [Tue, 22 Nov 2016 00:27:40 +0000 (01:27 +0100)]
idmap_hash: Make lw_map_file static

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2 years agowinbind: lookup_usergroups_cached doesn't use the "domain" parameter
Volker Lendecke [Fri, 4 Nov 2016 14:33:11 +0000 (15:33 +0100)]
winbind: lookup_usergroups_cached doesn't use the "domain" parameter

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
2 years agos3:waf: Remove unneeded CHARSET3 dependency
Andreas Schneider [Tue, 22 Nov 2016 16:35:31 +0000 (17:35 +0100)]
s3:waf: Remove unneeded CHARSET3 dependency

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Make PARAM and SMBREGISTRY a subsystem of smbconf only
Andreas Schneider [Tue, 22 Nov 2016 12:47:32 +0000 (13:47 +0100)]
s3:waf: Make PARAM and SMBREGISTRY a subsystem of smbconf only

This is the only way to resolve cirular dependencies with these
libraries.  I've tried several ways but this is the only way to do it
correctly. In future we should try to seperate them by passing down
information or making a more lightweight loadparm mechanism.

+---------+                       +-------------+
|         |                       |             |
|  param  <---------+    +--------+ smbregistry |
|         |         |    |        |             |
+----+----+         |    |        +------^------+
     |          +---+----v--+            |
     |          |           |            |
     +---------->  smbconf  +------------+
                |           |
                +-----------+

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos4:waf: Remove unneded dependency to s3 param
Andreas Schneider [Tue, 22 Nov 2016 12:45:50 +0000 (13:45 +0100)]
s4:waf: Remove unneded dependency to s3 param

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf samba3util requires CHARSET3
Andreas Schneider [Tue, 22 Nov 2016 10:50:04 +0000 (11:50 +0100)]
s3:waf samba3util requires CHARSET3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Move cbuf functions to samba3-util
Andreas Schneider [Tue, 22 Nov 2016 10:18:40 +0000 (11:18 +0100)]
s3:waf: Move cbuf functions to samba3-util

This is used more commonly in the meantime and this way we avoid linking
to smbconf.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Move popt_samba3 up in the stack
Andreas Schneider [Tue, 22 Nov 2016 10:09:42 +0000 (11:09 +0100)]
s3:waf: Move popt_samba3 up in the stack

Only daemons and client directly need to link against it.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat vlp
Andreas Schneider [Tue, 22 Nov 2016 10:04:59 +0000 (11:04 +0100)]
s3:waf: Reformat vlp

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat rpc_open_tcp
Andreas Schneider [Tue, 22 Nov 2016 10:04:47 +0000 (11:04 +0100)]
s3:waf: Reformat rpc_open_tcp

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat versiontest
Andreas Schneider [Tue, 22 Nov 2016 10:04:30 +0000 (11:04 +0100)]
s3:waf: Reformat versiontest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat vfstest
Andreas Schneider [Tue, 22 Nov 2016 10:04:14 +0000 (11:04 +0100)]
s3:waf: Reformat vfstest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat pdbtest
Andreas Schneider [Tue, 22 Nov 2016 10:03:50 +0000 (11:03 +0100)]
s3:waf: Reformat pdbtest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat msg_source
Andreas Schneider [Tue, 22 Nov 2016 10:03:22 +0000 (11:03 +0100)]
s3:waf: Reformat msg_source

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat msg_sink
Andreas Schneider [Tue, 22 Nov 2016 10:03:02 +0000 (11:03 +0100)]
s3:waf: Reformat msg_sink

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat msgtest
Andreas Schneider [Tue, 22 Nov 2016 10:02:48 +0000 (11:02 +0100)]
s3:waf: Reformat msgtest

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbconftort
Andreas Schneider [Tue, 22 Nov 2016 10:02:27 +0000 (11:02 +0100)]
s3:waf: Reformat smbconftort

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbtorture3
Andreas Schneider [Tue, 22 Nov 2016 10:01:52 +0000 (11:01 +0100)]
s3:waf: Reformat smbtorture3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbstatus
Andreas Schneider [Tue, 22 Nov 2016 10:01:14 +0000 (11:01 +0100)]
s3:waf: Reformat smbstatus

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat locktest2
Andreas Schneider [Tue, 22 Nov 2016 10:00:57 +0000 (11:00 +0100)]
s3:waf: Reformat locktest2

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbspool_krb5_wrapper
Andreas Schneider [Tue, 22 Nov 2016 10:00:37 +0000 (11:00 +0100)]
s3:waf: Reformat smbspool_krb5_wrapper

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbspool
Andreas Schneider [Tue, 22 Nov 2016 10:00:20 +0000 (11:00 +0100)]
s3:waf: Reformat smbspool

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbclient
Andreas Schneider [Tue, 22 Nov 2016 10:00:00 +0000 (11:00 +0100)]
s3:waf: Reformat smbclient

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat cli_spoolss
Andreas Schneider [Tue, 22 Nov 2016 09:59:14 +0000 (10:59 +0100)]
s3:waf: Reformat cli_spoolss

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat libcli_netlogon3
Andreas Schneider [Tue, 22 Nov 2016 09:58:28 +0000 (10:58 +0100)]
s3:waf: Reformat libcli_netlogon3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat errors3
Andreas Schneider [Tue, 22 Nov 2016 09:57:22 +0000 (10:57 +0100)]
s3:waf: Reformat errors3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat CHARSET3
Andreas Schneider [Tue, 22 Nov 2016 09:56:57 +0000 (10:56 +0100)]
s3:waf: Reformat CHARSET3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat samba3-util
Andreas Schneider [Tue, 22 Nov 2016 09:56:00 +0000 (10:56 +0100)]
s3:waf: Reformat samba3-util

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat trusts_util
Andreas Schneider [Tue, 22 Nov 2016 09:55:24 +0000 (10:55 +0100)]
s3:waf: Reformat trusts_util

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat DCUTIL
Andreas Schneider [Tue, 22 Nov 2016 09:54:41 +0000 (10:54 +0100)]
s3:waf: Reformat DCUTIL

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat SLCACHE
Andreas Schneider [Tue, 22 Nov 2016 09:54:14 +0000 (10:54 +0100)]
s3:waf: Reformat SLCACHE

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat PASSCHANGE
Andreas Schneider [Tue, 22 Nov 2016 09:53:39 +0000 (10:53 +0100)]
s3:waf: Reformat PASSCHANGE

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat PLAINTEXT_AUTH
Andreas Schneider [Tue, 22 Nov 2016 09:53:15 +0000 (10:53 +0100)]
s3:waf: Reformat PLAINTEXT_AUTH

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat SERVICES
Andreas Schneider [Tue, 22 Nov 2016 09:52:35 +0000 (10:52 +0100)]
s3:waf: Reformat SERVICES

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat LIBNMB
Andreas Schneider [Tue, 22 Nov 2016 09:51:49 +0000 (10:51 +0100)]
s3:waf: Reformat LIBNMB

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat LIBNET_SAMSYNC
Andreas Schneider [Tue, 22 Nov 2016 09:51:12 +0000 (10:51 +0100)]
s3:waf: Reformat LIBNET_SAMSYNC

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat LIBNET_DSSYNC
Andreas Schneider [Tue, 22 Nov 2016 09:50:39 +0000 (10:50 +0100)]
s3:waf: Reformat LIBNET_DSSYNC

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat PRINTING
Andreas Schneider [Tue, 22 Nov 2016 09:49:59 +0000 (10:49 +0100)]
s3:waf: Reformat PRINTING

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat printing_migrate
Andreas Schneider [Tue, 22 Nov 2016 09:49:25 +0000 (10:49 +0100)]
s3:waf: Reformat printing_migrate

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat PRINTBACKEND
Andreas Schneider [Tue, 22 Nov 2016 09:48:35 +0000 (10:48 +0100)]
s3:waf: Reformat PRINTBACKEND

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat PRINTBASE
Andreas Schneider [Tue, 22 Nov 2016 09:47:54 +0000 (10:47 +0100)]
s3:waf: Reformat PRINTBASE

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat LOCKING
Andreas Schneider [Tue, 22 Nov 2016 09:47:18 +0000 (10:47 +0100)]
s3:waf: Reformat LOCKING

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbd_base
Andreas Schneider [Tue, 22 Nov 2016 09:46:49 +0000 (10:46 +0100)]
s3:waf: Reformat smbd_base

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbconf
Andreas Schneider [Tue, 22 Nov 2016 09:45:36 +0000 (10:45 +0100)]
s3:waf: Reformat smbconf

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat ads
Andreas Schneider [Tue, 22 Nov 2016 09:44:41 +0000 (10:44 +0100)]
s3:waf: Reformat ads

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat secrets3
Andreas Schneider [Tue, 22 Nov 2016 09:43:28 +0000 (10:43 +0100)]
s3:waf: Reformat secrets3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat libsmb
Andreas Schneider [Tue, 22 Nov 2016 09:39:40 +0000 (10:39 +0100)]
s3:waf: Reformat libsmb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat samba3core
Andreas Schneider [Tue, 22 Nov 2016 09:38:43 +0000 (10:38 +0100)]
s3:waf: Reformat samba3core

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat messages_dgm
Andreas Schneider [Tue, 22 Nov 2016 09:37:47 +0000 (10:37 +0100)]
s3:waf: Reformat messages_dgm

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat TDB_LIB
Andreas Schneider [Tue, 22 Nov 2016 09:37:11 +0000 (10:37 +0100)]
s3:waf: Reformat TDB_LIB

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat samba3-util
Andreas Schneider [Tue, 22 Nov 2016 09:36:25 +0000 (10:36 +0100)]
s3:waf: Reformat samba3-util

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat REG_FULL
Andreas Schneider [Tue, 22 Nov 2016 09:35:12 +0000 (10:35 +0100)]
s3:waf: Reformat REG_FULL

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat REG_SMBCONF
Andreas Schneider [Tue, 22 Nov 2016 09:34:33 +0000 (10:34 +0100)]
s3:waf: Reformat REG_SMBCONF

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbregistry
Andreas Schneider [Tue, 22 Nov 2016 09:33:30 +0000 (10:33 +0100)]
s3:waf: Reformat smbregistry

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat param
Andreas Schneider [Tue, 22 Nov 2016 09:32:10 +0000 (10:32 +0100)]
s3:waf: Reformat param

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat smbldaphelper
Andreas Schneider [Tue, 22 Nov 2016 09:30:53 +0000 (10:30 +0100)]
s3:waf: Reformat smbldaphelper

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat pdb
Andreas Schneider [Tue, 22 Nov 2016 09:30:21 +0000 (10:30 +0100)]
s3:waf: Reformat pdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat samba-passdb
Andreas Schneider [Tue, 22 Nov 2016 09:28:58 +0000 (10:28 +0100)]
s3:waf: Reformat samba-passdb

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat TLDAP
Andreas Schneider [Tue, 22 Nov 2016 09:27:33 +0000 (10:27 +0100)]
s3:waf: Reformat TLDAP

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat GROUPDB
Andreas Schneider [Tue, 22 Nov 2016 09:26:39 +0000 (10:26 +0100)]
s3:waf: Reformat GROUPDB

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat AVAHI
Andreas Schneider [Tue, 22 Nov 2016 09:26:08 +0000 (10:26 +0100)]
s3:waf: Reformat AVAHI

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat gpo
Andreas Schneider [Tue, 22 Nov 2016 09:25:07 +0000 (10:25 +0100)]
s3:waf: Reformat gpo

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agos3:waf: Reformat msrpc3
Andreas Schneider [Tue, 22 Nov 2016 09:24:14 +0000 (10:24 +0100)]
s3:waf: Reformat msrpc3

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2 years agolibsocket: Make sure ifr.ifr_name is null-terminated
Andreas Schneider [Wed, 22 Jun 2016 09:26:06 +0000 (11:26 +0200)]
libsocket: Make sure ifr.ifr_name is null-terminated

Found by Coverity

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Sat Dec  3 03:40:53 CET 2016 on sn-devel-144

2 years agomanpages/vfs_fruit: add warning to fruit:resoure=stream
Ralph Boehme [Thu, 10 Nov 2016 08:07:41 +0000 (09:07 +0100)]
manpages/vfs_fruit: add warning to fruit:resoure=stream

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12412

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agoWHATSNEW: document fruit:resource option spelling issue
Ralph Boehme [Thu, 10 Nov 2016 13:01:16 +0000 (14:01 +0100)]
WHATSNEW: document fruit:resource option spelling issue

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agovfs_fruit: fix fruit:resource option spelling
Ralph Boehme [Tue, 8 Nov 2016 11:35:12 +0000 (12:35 +0100)]
vfs_fruit: fix fruit:resource option spelling

Fix all occurences of bad spelling of "resource" as "res*s*ource" (two
s).

One of the places where this was wrong was when parsing parametric
options in the VFS connect() function in the module. As a result any
setting of

  fruit:resource=something

in smb.conf was silently ignored and the default ("file") was active.

In Samba 4.6 we accept both the wrong and the correct spelling, in Samba
4.7 the bad spelling will be removed.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12412

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agoutil: Initialize pointer
Andreas Schneider [Wed, 22 Jun 2016 07:36:00 +0000 (09:36 +0200)]
util: Initialize pointer

Coverity warns about so this will silence it.
Reviewed-by: Jeremy Allison <jra@samba.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
2 years agologon script: clarify usage for different Samba roles
Alexander Bokovoy [Thu, 10 Nov 2016 09:07:42 +0000 (11:07 +0200)]
logon script: clarify usage for different Samba roles

'logon script' is only used when Samba runs as a logon server in the
classical domain controller role. And even there 'ldapsam' passdb
backend will override it.

For Samba AD setup 'logon script' is not used at all.

Signed-off-by: Alexander Bokovoy <ab@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
2 years agos3:libsmb: restructure cli_full_connection_creds* flow
Stefan Metzmacher [Fri, 4 Nov 2016 10:34:02 +0000 (11:34 +0100)]
s3:libsmb: restructure cli_full_connection_creds* flow

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Dec  2 17:32:26 CET 2016 on sn-devel-144

2 years agos3:libnet_join: make use of cli_full_connection_creds()
Stefan Metzmacher [Thu, 1 Dec 2016 15:37:43 +0000 (16:37 +0100)]
s3:libnet_join: make use of cli_full_connection_creds()

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
2 years agos3:libsmb: change cli_full_connection_send/recv into cli_full_connection_creds_send...
Stefan Metzmacher [Wed, 26 Oct 2016 11:48:58 +0000 (13:48 +0200)]
s3:libsmb: change cli_full_connection_send/recv into cli_full_connection_creds_send/recv

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>