From ff9fc4e4e0dd4e6a7563449de07934a0056f088b Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Fri, 25 Sep 2009 17:37:21 -0700 Subject: [PATCH 1/1] s4:dsdb Fix crash from LDAP login of DOM\\ The issue here is that when we resolve DOM\\ into an NT4 name, we would not initilise the nt4_account output. Andrew Bartlett --- source4/dsdb/samdb/cracknames.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/source4/dsdb/samdb/cracknames.c b/source4/dsdb/samdb/cracknames.c index 723f51356a5..8f7f481e2db 100644 --- a/source4/dsdb/samdb/cracknames.c +++ b/source4/dsdb/samdb/cracknames.c @@ -1288,11 +1288,9 @@ NTSTATUS crack_name_to_nt4_name(TALLOC_CTX *mem_ctx, } p[0] = '\0'; - if (p[1]) { - *nt4_account = talloc_strdup(mem_ctx, &p[1]); - if (*nt4_account == NULL) { - return NT_STATUS_NO_MEMORY; - } + *nt4_account = talloc_strdup(mem_ctx, &p[1]); + if (*nt4_account == NULL) { + return NT_STATUS_NO_MEMORY; } return NT_STATUS_OK; -- 2.34.1