15 years agoAdd workaround for docs build and dependency on parameters.all.xml samba-3.0.32
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:08:28 +0000 (16:08 -0500)]
Add workaround for docs build and dependency on parameters.all.xml

15 years agoUpdating release notes for 3.0.32.
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:07:08 +0000 (16:07 -0500)]
Updating release notes for 3.0.32.

15 years agoSet version to 3.0.32.
Gerald (Jerry) Carter [Mon, 25 Aug 2008 21:05:12 +0000 (16:05 -0500)]
Set version to 3.0.32.

15 years agoDon't re-initialize a token when we already have one. This fixes the build farm failu...
Jeremy Allison [Fri, 22 Aug 2008 20:54:22 +0000 (13:54 -0700)]
Don't re-initialize a token when we already have one. This fixes the build farm failures when winbindd connects as guest.
This one took a *lot* of tracking down :-).

15 years agonss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT
Gerald (Jerry) Carter [Wed, 20 Aug 2008 18:00:40 +0000 (13:00 -0500)]
nss_winbind: When returning NSS_UNAVAIL, squash errno to ENOENT

According to the GNU libc nss guide, we should always set
errno to ENOENT when returning NSS_UNAVAIL.

At least the MQ Series message queing service that runs
on WebSphere will fail if you return any other errno in this case.
(cherry picked from commit ee26664602445fa7798e2061f6bcbef0756d6528)

15 years agoFix bug 5697 nmbd spins in reload_interfaces when only loopback exists.
Jeremy Allison [Wed, 20 Aug 2008 01:13:25 +0000 (18:13 -0700)]
Fix bug 5697 nmbd spins in reload_interfaces when only loopback exists.
Reported by Ted Percival <>.

15 years agonet: Fix IPC connections with interactive password prompt.
Michael Adam [Mon, 4 Aug 2008 11:31:26 +0000 (13:31 +0200)]
net: Fix IPC connections with interactive password prompt.

This fixes a regression introduced with 52f916c6.
Some net subcommands didn't work when the username, but not the
corresponding password was given on the command line.

15 years agoman pages: Fix typos in man smbclient.
Karolin Seeger [Tue, 29 Jul 2008 10:03:08 +0000 (12:03 +0200)]
man pages: Fix typos in man smbclient.

(cherry picked from commit db843d2faafb3487e3c7df4a3a52d6c71f369e1d)
(cherry picked from commit 3a3640a85daa1a85415c949f9c2b804b4f067dd7)

15 years agoBack-port of Volkers fix.
Jeremy Allison [Fri, 25 Jul 2008 18:46:34 +0000 (11:46 -0700)]
Back-port of Volkers fix.

    Fix a race condition in winbind leading to a crash

    When SIGCHLD handling is delayed for some reason, sending a request to a child
    can fail early because the child has died already. In this case
    async_main_request_sent() directly called the continuation function without
    properly removing the malfunctioning child process and the requests in the
    queue. The next request would then crash in the DLIST_ADD_END() in
    async_request() because the request pending for the child had been
    talloc_free()'ed and yet still was referenced in the list.

    This one is *old*...



15 years agoman pages: "printcap name" is a global parameter, not a share specific one.
Karolin Seeger [Tue, 22 Jul 2008 09:27:16 +0000 (11:27 +0200)]
man pages: "printcap name" is a global parameter, not a share specific one.

(cherry picked from commit 9cde2525560536e16e2dbf991dbeb446260dd0df)
(cherry picked from commit 76061eee93fd67b96916a088c64a038e47a48814)
(cherry picked from commit 32dab019adaa3a0999af7baf6bcb8b2865e386c3)

15 years agoFix link for Using Samba
Alexander Bokovoy [Sat, 19 Jul 2008 20:11:50 +0000 (00:11 +0400)]
Fix link for Using Samba

15 years agoIn the "log file = " case, don't overwrite the
Jim McDonough [Thu, 17 Jul 2008 19:54:13 +0000 (15:54 -0400)]
In the "log file = " case, don't overwrite the

log.wb-<domain> logfile name on smb.conf reload.

15 years agoAllow %u parameters for print job username - use advanced sub
Bo Yang [Wed, 16 Jul 2008 15:11:55 +0000 (11:11 -0400)]
Allow %u parameters for print job username - use advanced sub

15 years agoman pages: Fix typos and add improvements.
Christoph Zauner [Fri, 11 Jul 2008 13:50:25 +0000 (15:50 +0200)]
man pages: Fix typos and add improvements.
(cherry picked from commit 060ff6d8d4e61f3ce89f980182413852cc5719be)
(cherry picked from commit dab5cf616ce044040dd598fec3da9d3c97e51f6d)
(cherry picked from commit 253405062237edfa78dc669a275af7ce9db849c4)

15 years agodocs: fix the specified default of "password server" - it is *, not "".
Michael Adam [Thu, 10 Jul 2008 21:49:58 +0000 (23:49 +0200)]
docs: fix the specified default of "password server" - it is *, not "".

(cherry picked from commit d7f759d302612ef9eb0bba022f3b3e1dd433f843)

15 years agoUpdating release notes for 3.0.31 samba-3.0.31
Gerald W. Carter [Thu, 10 Jul 2008 19:17:14 +0000 (14:17 -0500)]
Updating release notes for 3.0.31

15 years agoFix from Volker. Fix a segfault in base64_encode_data_blob
Jeremy Allison [Thu, 10 Jul 2008 17:05:00 +0000 (10:05 -0700)]
Fix from Volker. Fix a segfault in base64_encode_data_blob
 We did not allocate enough memory for the \0 and a = at the end.

15 years agoSetting version to 3.0.31
Gerald W. Carter [Thu, 10 Jul 2008 16:57:09 +0000 (11:57 -0500)]
Setting version to 3.0.31

15 years agoman pages: Add missing whitespace.
Karolin Seeger [Thu, 10 Jul 2008 09:23:59 +0000 (11:23 +0200)]
man pages: Add missing whitespace.

(cherry picked from commit 5ba418d8bd7bd9a678853b23b0928da4f8693bcf)
(cherry picked from commit 5e220de387abc34926fd7a2be03fc4e4f35f0f7f)
(cherry picked from commit 9a4a8cc875eeccc4b8a23117724073f6b5581f4c)

15 years agoRevert "tdbtool: fix off-by-one error in argument length. (bug #2344)"
Michael Adam [Wed, 9 Jul 2008 11:02:54 +0000 (13:02 +0200)]
Revert "tdbtool: fix off-by-one error in argument length. (bug #2344)"

This reverts commit dd781951fb9acc556f1bd6760b72151a7c359a9f.

This fix is not valid:

1. convert_string() is not only used for key strings but also for data.

2. Some databases use string_tdb_data() i.e. non-null-terminated strings
   as keynames and others (like the one I was using), use
   string_term_tdb_data(), i.e. zero-terminated key strings.

After discussion with Metze, the easiest (and proper way) to
handle this is to specify key names as "keyname\0" for databases
which use string_term_tdb_data().

Sorry for the noise...


15 years agotdbtool: fix off-by-one error in argument length. (bug #2344)
Michael Adam [Tue, 8 Jul 2008 14:13:24 +0000 (16:13 +0200)]
tdbtool: fix off-by-one error in argument length. (bug #2344)

This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)


15 years agoAllow authentication and memory credential refresh after password change from gdm...
Jeremy Allison [Mon, 7 Jul 2008 18:18:30 +0000 (11:18 -0700)]
Allow authentication and memory credential refresh after password change from gdm/xdm. Patch from boyang <>.

15 years agoPatch from SATOH Fumiyasu <> for bug #5202. Re-activate "acl...
Jeremy Allison [Thu, 3 Jul 2008 17:28:36 +0000 (10:28 -0700)]
Patch from SATOH Fumiyasu <> for bug #5202. Re-activate "acl group control"
parameter and make it only apply to owning group. Also added man page fix.

15 years agoCanonicalize servername in the printer functions to remove leading '\\' characters...
Jeremy Allison [Wed, 2 Jul 2008 23:10:50 +0000 (16:10 -0700)]
Canonicalize servername in the printer functions to remove leading '\\' characters. Ensure we always return consistent names.

15 years agoFix bug #5578, reported by Bad (non-Samba) use of strlcat gives...
Jeremy Allison [Wed, 2 Jul 2008 18:58:07 +0000 (11:58 -0700)]
Fix bug #5578, reported by Bad (non-Samba) use of strlcat gives error.

15 years agoEnsure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Jeremy Allison [Wed, 2 Jul 2008 17:50:50 +0000 (10:50 -0700)]
Ensure consistent use of pdb_get_nt_passwd instead of pdb_get_lanman_passwd.
Reported by hongbing Zhang <>.

15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Mon, 30 Jun 2008 16:16:15 +0000 (09:16 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoReturn NULL in sitename_fetch() if gencache_init() fails. Not false
Gerald W. Carter [Sat, 28 Jun 2008 13:35:07 +0000 (09:35 -0400)]
Return NULL in sitename_fetch() if gencache_init() fails.  Not false
(cherry picked from commit 9e9bab2dd859c7bb8082b4c932f1a95adf1895c6)

15 years agoFix usage message for net rpc trustdom add.
Jeremy Allison [Fri, 27 Jun 2008 22:30:52 +0000 (15:30 -0700)]
Fix usage message for net rpc trustdom add.

15 years agoFix gcc -O3 warnings.
Jeremy Allison [Fri, 27 Jun 2008 04:16:43 +0000 (21:16 -0700)]
Fix gcc -O3 warnings.

15 years agoFix "variable might be used uninitialized" message.
Jeremy Allison [Thu, 26 Jun 2008 19:56:26 +0000 (12:56 -0700)]
Fix "variable might be used uninitialized" message.

15 years agoPart of fix for #5551. Split out the group enumeration functions to a BUILTIN and...
Jeremy Allison [Wed, 25 Jun 2008 22:09:42 +0000 (15:09 -0700)]
Part of fix for #5551. Split out the group enumeration functions to a BUILTIN and a Domain
specific version. Stops the domain groups appearing twice.

15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Wed, 25 Jun 2008 21:57:46 +0000 (14:57 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoFinal (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate...
Jeremy Allison [Wed, 25 Jun 2008 19:43:18 +0000 (12:43 -0700)]
Final (hopefully :-) part of fix for bug #5551. Allow passdb backend to enumerate domain groups.

15 years agoFix for bug #5551, smbd recursing back into winbindd from a winbindd call.
Jeremy Allison [Wed, 25 Jun 2008 01:02:46 +0000 (18:02 -0700)]
Fix for bug #5551, smbd recursing back into winbindd from a winbindd call.

15 years agoFix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account...
Jeremy Allison [Tue, 24 Jun 2008 23:41:18 +0000 (16:41 -0700)]
Fix bug #5555. Don't return NT_STATUS_PASSWORD_MUST_CHANGE error on machine account logon.

15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Tue, 24 Jun 2008 01:57:00 +0000 (18:57 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoSamba3 HOWTO: Remove trailing whitespaces.
Karolin Seeger [Mon, 23 Jun 2008 08:15:53 +0000 (10:15 +0200)]
Samba3 HOWTO: Remove trailing whitespaces.

(cherry picked from commit c7a9c903acbba9c70211e6f3c25964533bbc1622)
(cherry picked from commit 62e485eebd8a40b5692caa79bb3ed6108f0b835b)

15 years agoman pages: Correct version in man winbindd again.
Karolin Seeger [Mon, 23 Jun 2008 08:28:09 +0000 (10:28 +0200)]
man pages: Correct version in man winbindd again.

(cherry picked from commit ef44968276bfde2fdd3370e2558fb469357414be)
(cherry picked from commit 9fd1d784cf6044c5c03cf7ab0f2373e08df64295)

15 years agoFixed publishing date info.
John H Terpstra [Wed, 28 May 2008 16:02:26 +0000 (11:02 -0500)]
Fixed publishing date info.
(cherry picked from commit b96c9d54cfd29ec87d59655839a4136977a98032)
(cherry picked from commit e4d03d3aede0cd611283a041eafdcd1e836aad33)

15 years agoAdded TDB File documentation requested by some users.
John H Terpstra [Wed, 28 May 2008 16:00:49 +0000 (11:00 -0500)]
Added TDB File documentation requested by some users.
(cherry picked from commit 5035311af639336fdc51fa9829e984ff281216f9)
(cherry picked from commit a7531f4964ac8f861a41e9fa446e5a3aa69eaaa2)

15 years agoClarification that hosts resolution is done by winbind only on IRIX, all other system...
John H Terpstra [Mon, 19 May 2008 18:02:08 +0000 (13:02 -0500)]
Clarification that hosts resolution is done by winbind only on IRIX, all other systems use
(cherry picked from commit 3a8ea6be389bedbcdb5668664d862768c026f669)
(cherry picked from commit 8522db2075f8c9e869c6224f2852ce355bba987d)

15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Sun, 22 Jun 2008 01:37:22 +0000 (18:37 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoFix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Jeremy Allison [Fri, 20 Jun 2008 20:23:31 +0000 (13:23 -0700)]
Fix bug #5531 - fix conversion of ns units when converting from nttime to timespec.
Fix from

15 years agoFix bug #5533. Winbindd fails to cope correctly with a workgroup name containing...
Jeremy Allison [Fri, 20 Jun 2008 19:50:02 +0000 (12:50 -0700)]
Fix bug #5533. Winbindd fails to cope correctly with a workgroup name containing a '.'.

15 years agoFixing net help info.
John H Terpstra [Thu, 19 Jun 2008 21:11:10 +0000 (16:11 -0500)]
Fixing net help info.

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Thu, 19 Jun 2008 16:11:59 +0000 (11:11 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoENODATA is not defined in freeBSD 4.6.2
Herb Lewis [Wed, 18 Jun 2008 21:29:17 +0000 (14:29 -0700)]
ENODATA is not defined in freeBSD 4.6.2

15 years agoman pages: Move 'smbsh' man page to the examples directory.
Karolin Seeger [Tue, 17 Jun 2008 11:18:17 +0000 (13:18 +0200)]
man pages: Move 'smbsh' man page to the examples directory.

smbsh.c is located in the examples directory. It does not make sense
to install a man page without installing the tool itself.

This fixes bug #4724.

(cherry picked from commit 797ed744b15c94fa4831d9796b40bb0ab5df55b7)
(cherry picked from commit 23981be7a009dc9e056ba2e12c5df6e3a13ab193)

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Fri, 13 Jun 2008 20:51:05 +0000 (15:51 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoWe should use set_domain_offline(domain) function instead of just set staus to offlin...
Jeremy Allison [Fri, 13 Jun 2008 16:43:34 +0000 (09:43 -0700)]
We should use set_domain_offline(domain) function instead of just set staus to offline. Otherwise,
domain will never goes online again.
From Bo Yang <>

15 years agoAIX build fix from William Jojo -- thanks
Volker Lendecke [Thu, 12 Jun 2008 11:25:53 +0000 (13:25 +0200)]
AIX build fix from William Jojo -- thanks

15 years agoAdd -brtl to the AIX linker flags, use bexpfull instead of bexpall
Volker Lendecke [Thu, 12 Jun 2008 10:35:28 +0000 (12:35 +0200)]
Add -brtl to the AIX linker flags, use bexpfull instead of bexpall

Thanks to William Jojo

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Wed, 11 Jun 2008 15:36:27 +0000 (10:36 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agopam_winbind: Update cached creds during password change.
Günther Deschner [Wed, 11 Jun 2008 07:52:56 +0000 (09:52 +0200)]
pam_winbind: Update cached creds during password change.

Fix is from Bo Yang @ Novell.


15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Tue, 10 Jun 2008 18:31:57 +0000 (13:31 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoman pages: Don't refer to numbered chapter of the HOWTO collection.
Karolin Seeger [Tue, 10 Jun 2008 13:30:19 +0000 (15:30 +0200)]
man pages: Don't refer to numbered chapter of the HOWTO collection.

This fixes bug #5527.
Thanks to the Debian package maintainers for reporting!

(cherry picked from commit b6696f4fbfc6aaffceef71c6099b8eaea58c1172)

15 years agoman pages: Fix broken smb.conf section about the 'get quota command'.
Karolin Seeger [Tue, 10 Jun 2008 08:54:21 +0000 (10:54 +0200)]
man pages: Fix broken smb.conf section about the 'get quota command'.

This fixes bug #5422.
Thanks to the Debian package maintainers for reporting!

(cherry picked from commit 04e2470e2eeef34362f2893ec062ae16f74c28ed)

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Tue, 10 Jun 2008 03:46:49 +0000 (22:46 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoDon't reset password last set time just because the expired flag
Jim McDonough [Mon, 9 Jun 2008 15:36:39 +0000 (11:36 -0400)]
Don't reset password last set time just because the expired flag
is set to 0.  If the account wasn't expired but autolocked,
using "net user /dom <username> /active:y" would clear this,
incorrectly setting the current time as the new "password last set"

15 years agoman pages: Fix synonyms.
Karolin Seeger [Mon, 9 Jun 2008 13:05:26 +0000 (15:05 +0200)]
man pages: Fix synonyms.

(cherry picked from commit d1ae27ddbe9c30996d2c593a37e65581c3ff482c)

15 years agoBugfix noticed by Herb. On using the again: tag as a
Jeremy Allison [Sun, 8 Jun 2008 21:17:47 +0000 (14:17 -0700)]
Bugfix noticed by Herb. On using the again: tag as a
goto target we were not reinitializing the array counts.

From Herb:

This is in the file nsswitch/winbindd_cm.c (samba-3.0.30) line 1236

We have a label again: where we keep trying to find the name of the DC
from the list of IPs returned by get_dcs. If we fail to figure out the
name we do a goto again at the end of the function. The problem is we
don't reset the num_dcs, num_addrs, etc and free the memory in the
various arrays. This seems wrong to me. I have a winbindd core where
I have 9 IPs returned for the DCs but at the time of the crash num_dcs
is 87 and if I look through the array dcs it keeps repeating entries
from the same group of 9

Jerry, Volker and Guenther please check.


15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Fri, 6 Jun 2008 22:02:56 +0000 (15:02 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Fri, 6 Jun 2008 19:13:38 +0000 (14:13 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agopam_winbind: fix pam_sm_chauthtok for storing modified cached creds.
Günther Deschner [Fri, 6 Jun 2008 13:59:52 +0000 (15:59 +0200)]
pam_winbind: fix pam_sm_chauthtok for storing modified cached creds.

Thanks to Bo Yang for pointing this out.


15 years agoMore correct fix (hopefully :-) for any memory leaks.
Jeremy Allison [Thu, 5 Jun 2008 21:34:35 +0000 (14:34 -0700)]
More correct fix (hopefully :-) for any memory leaks.
Jerry promised to check :-). Vl also please review.

15 years agonet: fix joining w2k domains in "security = ads".
Günther Deschner [Thu, 5 Jun 2008 14:26:10 +0000 (16:26 +0200)]
net: fix joining w2k domains in "security = ads".

This repairs the join verification code which needs to try an anonymous
connection (as an authenticated connection will always fail with


15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Thu, 5 Jun 2008 15:54:32 +0000 (10:54 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoSamba3-HOWTO: Add improvements/fixes.
Karolin Seeger [Thu, 5 Jun 2008 13:18:41 +0000 (15:18 +0200)]
Samba3-HOWTO: Add improvements/fixes.

These improvements/fixes were reported by
Pete Boyd <> in bug #4203.

(cherry picked from commit 497196e713b05901f02a46755bce6a63734dcf4c)

15 years agonet: for robustness reasons, fallback to level 24 pwd set while joining.
Günther Deschner [Wed, 4 Jun 2008 18:02:13 +0000 (20:02 +0200)]
net: for robustness reasons, fallback to level 24 pwd set while joining.

DCERPC_FAULT_INVALID_TAG is returned by older windows releases, in that case it
is wise to do what we did prior to 3.0.28.


15 years agoFix by Bo Yang <> for bug with winbindd trusted domain chil
Jeremy Allison [Tue, 3 Jun 2008 19:17:34 +0000 (12:17 -0700)]
Fix by Bo Yang <> for bug with winbindd trusted domain chil
not keeping primary domain online status up to date.

15 years agoFix usage message for 'net idmap dump'.
Karolin Seeger [Tue, 25 Mar 2008 11:00:42 +0000 (12:00 +0100)]
Fix usage message for 'net idmap dump'.

(cherry picked from commit c967b62dd3c924419fa4a72aa2143d6bef959d18)

15 years agoFix bug reported by David Eisner <>. When allocating cli
Jeremy Allison [Tue, 3 Jun 2008 01:36:31 +0000 (18:36 -0700)]
Fix bug reported by David Eisner <>. When allocating cli
buffers for large read/write - make sure we take account of the large
read/write SMB headers as well as the buffer space.

15 years agoDon't let winbind getgroups crash when we have no gids in the token.
Günther Deschner [Fri, 28 Mar 2008 23:47:42 +0000 (00:47 +0100)]
Don't let winbind getgroups crash when we have no gids in the token.


15 years agoFix location of smbldap-tools
Volker Lendecke [Mon, 2 Jun 2008 08:42:27 +0000 (10:42 +0200)]
Fix location of smbldap-tools

Thanks to Miguel Medalha <> for pointing this out

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Sat, 31 May 2008 15:14:41 +0000 (10:14 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoFix use of smbconfoption in samba.entities.
Alexander Bokovoy [Sat, 31 May 2008 07:07:44 +0000 (11:07 +0400)]
Fix use of smbconfoption in samba.entities.
During documentation migration to git my fixes to samba.entities got lost.
Update them now from latest working version (from samba-web).

15 years agoMerge branch 'v3-0-test' of ssh:// into v3-0-test
Jeremy Allison [Sat, 31 May 2008 06:13:23 +0000 (23:13 -0700)]
Merge branch 'v3-0-test' of ssh:// into v3-0-test

15 years agoSplit the winbindd_passdb backend into a 'builtin' and a 'sam'
Jeremy Allison [Sat, 31 May 2008 06:11:31 +0000 (23:11 -0700)]
Split the winbindd_passdb backend into a 'builtin' and a 'sam'
backend. This allows winbindd when running on a Samba PDC to
correctly answer wbinfo -u lists and other queries. I will
forward port this to 3.2 and 3.3 over the weekend. Passes
running under valgrind.

15 years agominor memory leak fix from Chere Zhou <>.
Jeremy Allison [Sat, 31 May 2008 01:02:00 +0000 (18:02 -0700)]
minor memory leak fix from Chere Zhou <>.

15 years agoFix valgrind bug in debug statement. Don't reference uninitialized memory.
Jeremy Allison [Sat, 31 May 2008 00:37:34 +0000 (17:37 -0700)]
Fix valgrind bug in debug statement. Don't reference uninitialized memory.

15 years agoFix bug #5504. winbindd children and parent were handing SIGTERM in the same way...
Jeremy Allison [Sat, 31 May 2008 00:23:59 +0000 (17:23 -0700)]
Fix bug #5504. winbindd children and parent were handing SIGTERM in the same way - deleting the socket !

15 years agoFrom Michael R Sweet <>.
Jeremy Allison [Fri, 30 May 2008 17:03:57 +0000 (10:03 -0700)]
From Michael R Sweet <>.


Noticed that smbspool.c still has my Easy Software Products copyright
on it.  The following patch fixes it to match the other code I've
contributed over the years...


15 years agoFix joining NT4 domains.
Günther Deschner [Fri, 30 May 2008 13:59:49 +0000 (15:59 +0200)]
Fix joining NT4 domains.

The negotiated netlogon flags also need to be returned in case we received
NT_STATUS_ACCESS_DENIED from a netauth2 request.


15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Thu, 29 May 2008 20:45:58 +0000 (15:45 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoFix winbindd on a PDC by reverting : 83b04c60fac76ccd2d5aecb14f8896a07d488b1f..6e6651...
Jeremy Allison [Thu, 29 May 2008 17:38:59 +0000 (10:38 -0700)]
Fix winbindd on a PDC by reverting : 83b04c60fac76ccd2d5aecb14f8896a07d488b1f..6e66512d5beb256a44c6703cdb8c7fa7e0fd8537.
We still need to address, but this
will come later.

15 years agoFix documentation networkless build. We did override build/catalog.xml but didn't...
Alexander Bokovoy [Thu, 29 May 2008 09:13:59 +0000 (13:13 +0400)]
Fix documentation networkless build. We did override build/catalog.xml but didn't define BUILDDIR for it

15 years agoUpdating release notes for 3.0.30 security release.
Gerald W. Carter [Wed, 28 May 2008 12:40:51 +0000 (07:40 -0500)]
Updating release notes for 3.0.30 security release.

15 years agoSecurity: Patche for CVE-2008-1105.
Gerald W. Carter [Wed, 28 May 2008 12:30:19 +0000 (07:30 -0500)]
Security: Patche for CVE-2008-1105.

    -- Summary --
    Specifically crafted SMB responses can result
    in a heap overflow in the Samba client code.
    Because the server process, smbd, can itself
    act as a client during operations such as
    printer notification and domain authentication,
    this issue affects both Samba client and server

Ensure that we specify the buffer size used to store incoming SMB
packets.  This bug was originally introduced in Samba 2.2.4.  Patch from
Jeremy Allison.

15 years agoRelease scripts: Copy the support release scripts from the v3-3-tree
Gerald W. Carter [Tue, 27 May 2008 21:30:54 +0000 (16:30 -0500)]
Release scripts: Copy the support release scripts from the v3-3-tree
(cherry picked from commit 8555ceeca7ac50f18589c07d2deb45c1d6fe8010)

15 years agoFix Bug #5285. (libcap header mismatch)
Günther Deschner [Wed, 28 May 2008 11:20:16 +0000 (13:20 +0200)]
Fix Bug #5285. (libcap header mismatch)

Can someone with gpfs available test this ? The only codepath using this
function is the modules/gpfs.c module. The fix resolves at least the build
issues Samba has with recent kernel / libcap versions by using the portable
cap_get_proc()/cap_set_proc() interface (instead of using capget/capset).


15 years agoMemory leak fixes from Chere Zhou <>.
Jeremy Allison [Tue, 27 May 2008 19:28:21 +0000 (12:28 -0700)]
Memory leak fixes from Chere Zhou <>.

15 years agoMerge branch 'v3-0-test' of git:// into 3.0-test
Jim McDonough [Tue, 27 May 2008 09:32:20 +0000 (05:32 -0400)]
Merge branch 'v3-0-test' of git:// into 3.0-test

15 years agoSet version in v3-0-test to 3.0.30-GIT
Gerald Carter [Fri, 23 May 2008 18:15:02 +0000 (13:15 -0500)]
Set version in v3-0-test to 3.0.30-GIT

15 years agospnego SPN fix when contacting trusted domains
Steven Danneman [Wed, 7 May 2008 20:34:26 +0000 (13:34 -0700)]
spnego SPN fix when contacting trusted domains

cli_session_setup_spnego() was not taking into consideration the situation
where we're connecting to a trusted domain, specifically one (like W2K8)
which doesn't return a SPN in the NegTokenInit.

This caused two problems:

1) When guessing the SPN using kerberos_get_default_realm_from_ccache() we
were always using our default realm, not the realm of the domain we're
connecting to.

2) When falling back on NTLMSSP for authentication we were passing the name
of the domain we're connecting to for use in our credentials when we should be
passing our own workgroup name.

The fix for both was to split the single "domain" parameter into
"user_domain" and "dest_realm" parameters.  We use the "user_domain"
parameter to pass into the NTLM call, and we used "dest_realm" to create an SPN
if none was returned in the NegTokenInit2 packet.  If no "dest_realm" is
provided we assume we're connecting to our own domain and use the credentials
cache to build the SPN.

Since we have a reasonable guess at the SPN, I removed the check that defaults
us directly to NTLM when negHint is empty.

15 years agoUse machine account and machine password from our domain when
Steven Danneman [Thu, 8 May 2008 20:34:49 +0000 (13:34 -0700)]
Use machine account and machine password from our domain when
contacting trusted domains.

15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Fri, 23 May 2008 13:30:23 +0000 (08:30 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoman pages: Remove ldb man pages.
Karolin Seeger [Thu, 22 May 2008 09:00:19 +0000 (11:00 +0200)]
man pages: Remove ldb man pages.

Ldb-tools will be available starting with 3.2.


15 years agoMerge branch 'v3-0-test' of git:// into v3-0-test
John H Terpstra [Wed, 21 May 2008 20:39:14 +0000 (15:39 -0500)]
Merge branch 'v3-0-test' of git:// into v3-0-test

15 years agoMake 3.0.x in sync with 3.2 here. samba-3.0.29
Jeremy Allison [Wed, 21 May 2008 20:06:46 +0000 (13:06 -0700)]
Make 3.0.x in sync with 3.2 here.