13 years agor13327: Update install.html location & fix typo.
John Terpstra [Sat, 4 Feb 2006 05:42:29 +0000 (05:42 +0000)]
r13327: Update install.html location & fix typo.
(This used to be commit 77fb6998510ceab502548ea3b20541136b37b952)

13 years agor13326: fix bad path in RHEL spec file; going to have to rebuild Fedora packages
Gerald Carter [Sat, 4 Feb 2006 04:05:25 +0000 (04:05 +0000)]
r13326: fix bad path in RHEL spec file; going to have to rebuild Fedora packages
(This used to be commit 18800eab03b7b1c3cf6734b71f462f2fd7b8f24a)

13 years agor13322: Fix warning time_t != int.
Jeremy Allison [Fri, 3 Feb 2006 23:31:56 +0000 (23:31 +0000)]
r13322: Fix warning time_t != int.
(This used to be commit 6196446a03abeb4100bac1721977488ae5843f42)

13 years agor13318: remove an unused file
Gerald Carter [Fri, 3 Feb 2006 22:42:49 +0000 (22:42 +0000)]
r13318: remove an unused file
(This used to be commit 5d373133cbed8fa40e3a9dcd08d27c35ddff96af)

13 years agor13316: Let the carnage begin....
Gerald Carter [Fri, 3 Feb 2006 22:19:41 +0000 (22:19 +0000)]
r13316: Let the carnage begin....
Sync with trunk as off r13315
(This used to be commit 17e63ac4ed8325c0d44fe62b2442449f3298559f)

13 years agor13314: This code has been causing problems since 1.9.x I think.
Jeremy Allison [Fri, 3 Feb 2006 22:10:37 +0000 (22:10 +0000)]
r13314: This code has been causing problems since 1.9.x I think.
Remove check_for_pipe() - Volker was completely correct.
If it gets re-added it will be in a old open call path, not
in the generic code path.
(This used to be commit 50c894a6e949d4d3579926650674f381a821a671)

13 years agor13310: first round of server affinity patches for winbindd & net ads join
Gerald Carter [Fri, 3 Feb 2006 21:19:24 +0000 (21:19 +0000)]
r13310: first round of server affinity patches for winbindd & net ads join
(This used to be commit 6c3480f9aecc061660ad5c06347b8f1d3e11a330)

13 years agor13309: If the sid in the winbind name2sid cache is not valid (NT_STATUS_NONE_MAPPED),
Volker Lendecke [Fri, 3 Feb 2006 19:24:52 +0000 (19:24 +0000)]
r13309: If the sid in the winbind name2sid cache is not valid (NT_STATUS_NONE_MAPPED),
we have S-0-0 as a SID in the cache. This leads to ugly level 0 messages from
string_to_sid. Avoid them.

(This used to be commit d62da3e9875592af91469bf75ca32be77a40ea59)

13 years agor13306: Do not call netbios_setup() if this file is sourced by sh or bash.
Lars Müller [Fri, 3 Feb 2006 15:39:07 +0000 (15:39 +0000)]
r13306: Do not call netbios_setup() if this file is sourced by sh or bash.
(This used to be commit 72c6432ae8b8bf2330fc1a8019d332ab95b57e4e)

13 years agor13299: From testing W2K3 and W2K the delete on close bit seems to be always
Jeremy Allison [Fri, 3 Feb 2006 02:16:35 +0000 (02:16 +0000)]
r13299: From testing W2K3 and W2K the delete on close bit seems to be always
honored (ie. the file gets deleted) for derectories when set at open
time - even though it doesn't show in the qfileinfo call. This is not
true of files.... (if anyone from the EU is listening, it's stuff like
this that makes CIFS non-documentable :-).
(This used to be commit e2fc8a196a06f76aa47fabc30872c701a2f7ccec)

13 years agor13296: Align trunk with branches/SAMBA_3_0.
Lars Müller [Thu, 2 Feb 2006 21:34:40 +0000 (21:34 +0000)]
r13296: Align trunk with branches/SAMBA_3_0.

Add missing '\' in branches/SAMBA_3_0.
(This used to be commit a60aed7a38ab5d4401db207d52925e59f1e445f3)

13 years agor13294: Fix basic delete on close tests - don't forget to tell
Jeremy Allison [Thu, 2 Feb 2006 21:29:49 +0000 (21:29 +0000)]
r13294: Fix basic delete on close tests - don't forget to tell
the data struct how big the token is... :-).
(This used to be commit f259de8b69f94ae8b5f4553180f245234bffd397)

13 years agor13293: Rather a big patch I'm afraid, but this should fix bug #3347
Jeremy Allison [Thu, 2 Feb 2006 20:44:50 +0000 (20:44 +0000)]
r13293: Rather a big patch I'm afraid, but this should fix bug #3347
by saving the UNIX token used to set a delete on close flag,
and using it when doing the delete. still
needs updating to cope with this change.
Samba4 torture tests to follow.
(This used to be commit 23f16cbc2e8cde97c486831e26bcafd4ab4a9654)

13 years agor13291: NT checks the minimum password age dynamically. That means we have to ignore
Volker Lendecke [Thu, 2 Feb 2006 16:38:37 +0000 (16:38 +0000)]
r13291: NT checks the minimum password age dynamically. That means we have to ignore
the sambapwdmustchange field if we can access the corresponding account
policy and calculate it dynamically based on the pwdlastset field.

(This used to be commit b02b1d3ef3bceec1957d025c642e306a65310d22)

13 years agor13290: Adding Account Policy LDAP attributes for eDirectory schema.
Günther Deschner [Thu, 2 Feb 2006 16:25:58 +0000 (16:25 +0000)]
r13290: Adding Account Policy LDAP attributes for eDirectory schema.

(This used to be commit de012e33a75e0aa72fbfe2cf1258689e0d7680e2)

13 years agor13288: readding readme file
Gerald Carter [Wed, 1 Feb 2006 20:31:28 +0000 (20:31 +0000)]
r13288: readding readme file
(This used to be commit f1ab089b19fa631d38b81230466b0e2b7aa49a8d)

13 years agor13287: removning readme file
Gerald Carter [Wed, 1 Feb 2006 20:30:46 +0000 (20:30 +0000)]
r13287: removning readme file
(This used to be commit c20ad9d8c03a15afc670dc74921e9e9530174ff6)

13 years agor13286: changing target file in another branch
Gerald Carter [Wed, 1 Feb 2006 20:29:41 +0000 (20:29 +0000)]
r13286: changing target file in another branch
(This used to be commit 91384c703cadce9ae262503958dba42389b34321)

13 years agor13274: Fix for bug #3467. Not a show stopper.
Jeremy Allison [Wed, 1 Feb 2006 04:14:07 +0000 (04:14 +0000)]
r13274: Fix for bug #3467. Not a show stopper.
jason qian <> was a *fantastic*
help in tracking this down.
(This used to be commit 9f4a9c70fa232047868e5d8a3f132a2dd6bfee82)

13 years agor13262: Arrgggg. Fix smbstatus and swat status to ignore
Jeremy Allison [Tue, 31 Jan 2006 21:54:24 +0000 (21:54 +0000)]
r13262: Arrgggg. Fix smbstatus and swat status to ignore
bloody placeholder share mode entries (I hate
these - I've had to add this filter code now to too
many places :-).
(This used to be commit 815340e1a413f98c1c36aacc1c34041e9160d0e3)

13 years agor13260: Fix stupid bug Volker found for big-endian machines.
Jeremy Allison [Tue, 31 Jan 2006 18:34:51 +0000 (18:34 +0000)]
r13260: Fix stupid bug Volker found for big-endian machines.
(This used to be commit 31903cf25d4075b8518e370b7618de41510f7995)

13 years agor13257: Fix python build with older python versions (e.g. 2.2.1) like in United ...
Lars Müller [Tue, 31 Jan 2006 10:39:45 +0000 (10:39 +0000)]
r13257: Fix python build with older python versions (e.g. 2.2.1) like in United         Linux 1 (UL) aka SuSE Linux Enterprise Server (SLES) 8.
(This used to be commit 4602cb5f53f05404f10c69b01dd8fd5ac492c5c5)

13 years agor13238: Fix from Qiao Yang <> to ensure we
Jeremy Allison [Mon, 30 Jan 2006 20:20:17 +0000 (20:20 +0000)]
r13238: Fix from Qiao Yang <> to ensure we
always update the failed time when we are adding a failed
(This used to be commit 6f5af1dd413d07430ead9382422dda14acf3464d)

13 years agor13235: fixing RedHat 7.x packaging
Gerald Carter [Mon, 30 Jan 2006 19:23:32 +0000 (19:23 +0000)]
r13235: fixing RedHat 7.x packaging
(This used to be commit dcdae7f483f642605e158b405939178587971bec)

13 years agor13233: build fixes for smbmnt; remove unused variable; ready to ship 3.0.21b now
Gerald Carter [Mon, 30 Jan 2006 18:38:18 +0000 (18:38 +0000)]
r13233: build fixes for smbmnt; remove unused variable; ready to ship 3.0.21b now
(This used to be commit 51fe6bd845f33139654f641947cffeaaf8e88124)

13 years agor13232: defensive programming in an attempt to prevent crashes due to a PDC rebooting
Gerald Carter [Mon, 30 Jan 2006 17:47:24 +0000 (17:47 +0000)]
r13232: defensive programming in an attempt to prevent crashes due to a PDC rebooting
(This used to be commit 994794383361cfe5d58098ae494489fb0164e1df)

13 years agor13231: apparently strncat() is converted to strcat() on RH7.3 and similar systems...
Gerald Carter [Mon, 30 Jan 2006 17:42:42 +0000 (17:42 +0000)]
r13231: apparently strncat() is converted to strcat() on RH7.3 and similar systems.  Fix the build on those boxes
(This used to be commit 0b8ed8136b5c5b9b7bb5615dc8dc27eec7c49506)

13 years agor13229: * fix bad comparison caught by the AIX compiler in wbinfo code
Gerald Carter [Mon, 30 Jan 2006 13:32:41 +0000 (13:32 +0000)]
r13229: * fix bad comparison caught by the AIX compiler in wbinfo code
* update output from to include the SAMBA_VENDOR_PATCH
(This used to be commit 485f0370942880a71095da5096e414b28193b150)

13 years agor13224: better to cast the return too
Simo Sorce [Sun, 29 Jan 2006 18:43:52 +0000 (18:43 +0000)]
r13224: better to cast the return too
(This used to be commit c068df483f44a23ad813acd10d583be863128382)

13 years agor13222: Never assume mode_t is of type int.
Simo Sorce [Sun, 29 Jan 2006 18:22:39 +0000 (18:22 +0000)]
r13222: Never assume mode_t is of type int.
We were trashing the stack on machines that define mode_t as uint16_t
(This used to be commit 6c15af31bcee1e82578b61cae10423b37c285f10)

13 years agor13216: r12422@cabra: derrell | 2006-01-28 23:57:35 -0500
Derrell Lipman [Sun, 29 Jan 2006 04:57:42 +0000 (04:57 +0000)]
r13216:  r12422@cabra:  derrell | 2006-01-28 23:57:35 -0500
 Fix cli_setpathinfo() to actually do what it's supposed to.

 Also, get rid of some apparently drug-induced code to deal with create time
 which isn't being manipulated anyway.
(This used to be commit aa25dc1248b15e8e1b39cf8a98496e5aba475c4a)

13 years agor13214: r12420@cabra: derrell | 2006-01-28 19:10:58 -0500
Derrell Lipman [Sun, 29 Jan 2006 00:11:34 +0000 (00:11 +0000)]
r13214:  r12420@cabra:  derrell | 2006-01-28 19:10:58 -0500
 This should fix bug #3446.

 - The authentication domain provided an an SMB URL was being ignored.  This
   patch fixes that.

 - There were a number of places where string copies were not being confirmed to
   be properly null-terminated.  Now, all string copies in libsmbclient.c are
   properly null-terminated.
(This used to be commit 5fbc2fbb461f02ad6c889de2ce9929c605a44e24)

13 years agor13212: r12414@cabra: derrell | 2006-01-28 17:52:17 -0500
Derrell Lipman [Sat, 28 Jan 2006 22:53:04 +0000 (22:53 +0000)]
r13212:  r12414@cabra:  derrell | 2006-01-28 17:52:17 -0500
 lp_load() could not be called multiple times to modify parameter settings based
 on reading from multiple configuration settings.  Each time, it initialized all
 of the settings back to their defaults before reading the specified
 configuration file.

 This patch adds a parameter to lp_load() specifying whether the settings should
 be initialized.  It does, however, still force the settings to be initialized
 the first time, even if the request was to not initialize them.  (Not doing so
 could wreak havoc due to uninitialized values.)
(This used to be commit f2a24de769d1b2266e576597c57a8e3b1e2a2b51)

13 years agor13211: Fix remote password changing if password must change is set
Volker Lendecke [Sat, 28 Jan 2006 22:49:25 +0000 (22:49 +0000)]
r13211: Fix remote password changing if password must change is set

The problem was that the ntlmssp bind silently failed in that case, we have to
do it anonymously. Or does anybody have a better idea?

Give a better error message if something else is wrong with the account.

(This used to be commit 0e24c701ce3755d71de7fdccb9f4564b381bf996)

13 years agor13209: Make smbpasswd -a work again if passdb did not exist.
Volker Lendecke [Sat, 28 Jan 2006 17:08:24 +0000 (17:08 +0000)]
r13209: Make smbpasswd -a work again if passdb did not exist.

(This used to be commit e747ea7250b3ff19aee49072a2cf95840ff50b85)

13 years agor13202: Fix the build for --with-aio-support. Sorry.
Volker Lendecke [Sat, 28 Jan 2006 11:30:43 +0000 (11:30 +0000)]
r13202: Fix the build for --with-aio-support. Sorry.

Jeremy, decides whether aio support works quite early in the
sequence of checks. Wouldn't it be better to only use aio support if really
all necessary functions actually are around?

(This used to be commit 246b5b43566f15732091ec9a775b864399f9418d)

13 years agor13198: Fix issues exposed by Jerry's testing on 64-bit Solaris
Jeremy Allison [Fri, 27 Jan 2006 23:30:30 +0000 (23:30 +0000)]
r13198: Fix issues exposed by Jerry's testing on 64-bit Solaris
(I hope). Separate 3.0.21b patch sent to Jerry.
(This used to be commit 837e7ea7e40cedc6b01e023445feb4a90c4bf8b9)

13 years agor13197: Add -k switch to dump the data of a single key.
Lars Müller [Fri, 27 Jan 2006 21:49:01 +0000 (21:49 +0000)]
r13197: Add -k switch to dump the data of a single key.
(This used to be commit 23503ff45f2a377728bc5ebb1e6db2755bb5ca2b)

13 years agor13194: Don't do extra memcpy's unless we're asked to.
Jeremy Allison [Fri, 27 Jan 2006 19:59:48 +0000 (19:59 +0000)]
r13194: Don't do extra memcpy's unless we're asked to.
(This used to be commit f93e1e75563679dc07958168b283dfc0eb2de5b0)

13 years agor13192: Fix up alignment issues when printing share mode
Jeremy Allison [Fri, 27 Jan 2006 19:54:39 +0000 (19:54 +0000)]
r13192: Fix up alignment issues when printing share mode
entries. Add paranioa to debug so we know when an
entry is unused.
(This used to be commit fa5fab313e3728ff49c00ca1097242039506f83e)

13 years agor13190: Fix #3458 from Andriy Gapon <>. Don't
Jeremy Allison [Fri, 27 Jan 2006 19:24:37 +0000 (19:24 +0000)]
r13190: Fix #3458 from Andriy Gapon <>. Don't
access free'd memory.
Jerry please pick up for 3.0.21b !
(This used to be commit c0ba64297a00d75cd537693425c6b544e70578c1)

13 years agor13187: IBM Tivoli Directory Server schema updates from John Janosik
Jim McDonough [Fri, 27 Jan 2006 15:14:55 +0000 (15:14 +0000)]
r13187: IBM Tivoli Directory Server schema updates from John Janosik
(This used to be commit d45cc5e4f38bd1aa69d5c3ae8d19e2ea98976fac)

13 years agor13176: Fix show-stopper bug for 3.0.21b where 4 leg NTLMSSP SPNEGO
Jeremy Allison [Fri, 27 Jan 2006 02:35:08 +0000 (02:35 +0000)]
r13176: Fix show-stopper bug for 3.0.21b where 4 leg NTLMSSP SPNEGO
auth was not generating the correct auth header on the 4th
packet. This may fix a lot of Windows client complaints and
is essential for release.
(This used to be commit 48dd8c732b890e3fd3d8e80ace765487601cfb26)

13 years agor13175: Actually make adding a new user into an empty pdbtdb
Jeremy Allison [Fri, 27 Jan 2006 00:09:03 +0000 (00:09 +0000)]
r13175: Actually make adding a new user into an empty pdbtdb
file create the file.
(This used to be commit 31b3201f537220ec82d6fecbb4c457bfe3dbb9c9)

13 years agor13172: Fix incorrect error message when new tdb not created correctly.
Jeremy Allison [Thu, 26 Jan 2006 23:55:26 +0000 (23:55 +0000)]
r13172: Fix incorrect error message when new tdb not created correctly.
(This used to be commit e5f19ad5ac1b728de4ca5a6c37c0d79b0752f536)

13 years agor13162: Allow to set the flags for a ds_enum_domain_trusts query in rpcclient.
Günther Deschner [Thu, 26 Jan 2006 12:04:43 +0000 (12:04 +0000)]
r13162: Allow to set the flags for a ds_enum_domain_trusts query in rpcclient.

(This used to be commit e52b77b0a4e29387d2333a340868e839683df729)

13 years agor13148: Fix bug: #3413
Simo Sorce [Thu, 26 Jan 2006 00:14:25 +0000 (00:14 +0000)]
r13148: Fix bug: #3413
Check that ldap admin dn is defined in smb.conf before
setting the ldap password in secrets.tdb

Based on patch by William Jojo <>

(This used to be commit c2c004a620ecbd895786dc6f16fb6a616f354a0a)

13 years agor13147: Raise creds_server_step fail log messages to debug level 2.
Jeremy Allison [Wed, 25 Jan 2006 23:00:07 +0000 (23:00 +0000)]
r13147: Raise creds_server_step fail log messages to debug level 2.
These can happen in normal operation (I think - not 100%
sure) and don't want to alarm admins. Jerry please add this
to 3.0.21b.
(This used to be commit 47178b1b5ad06905f345a0f6b6267701d8aefddb)

13 years agor13140: Fix swat - make sure it can list running services (ensure loopback_ip)
Jeremy Allison [Wed, 25 Jan 2006 21:58:06 +0000 (21:58 +0000)]
r13140: Fix swat - make sure it can list running services (ensure loopback_ip)
is defined. Jerry - this needs to be in 3.0.21b.
(This used to be commit 417ef5bffaefee698cbea4b06aff691f01ac56d1)

13 years agor13138: old fix I forgot to commit
Simo Sorce [Wed, 25 Jan 2006 21:29:36 +0000 (21:29 +0000)]
r13138: old fix I forgot to commit
need to access info when using the ldap backend
(This used to be commit 80c0625667f28253e9b6f1ac1a5c88aa8261f9b0)

13 years agor13137: make cleare where long ifdefs ends
Simo Sorce [Wed, 25 Jan 2006 21:25:25 +0000 (21:25 +0000)]
r13137: make cleare where long ifdefs ends
(This used to be commit 58e48fef450f71ac15219f73897801c5a66a2c44)

13 years agor13136: Fix handling user sid and user gid
Simo Sorce [Wed, 25 Jan 2006 21:24:51 +0000 (21:24 +0000)]
r13136: Fix handling user sid and user gid
(This used to be commit 65d5abda68fa0cacbff489ea1e4bfeffd58c83cb)

13 years agor13133: patch from Makr Proehl <> for dumping server...
Gerald Carter [Wed, 25 Jan 2006 15:43:15 +0000 (15:43 +0000)]
r13133: patch from Makr Proehl <> for dumping server role when calling 'testparm -s' (BUG 1336)
(This used to be commit a4c6eceaaeeeaa6f0af2ae0689631710d36dbd59)

13 years agor13132: Old fix from Lars
Simo Sorce [Wed, 25 Jan 2006 15:12:18 +0000 (15:12 +0000)]
r13132: Old fix from Lars
(This used to be commit 4488e1debb00f6e3b53c71826a91bae001250902)

13 years agor13127: more spec file fixes for RHEL
Gerald Carter [Wed, 25 Jan 2006 05:27:23 +0000 (05:27 +0000)]
r13127: more spec file fixes for RHEL
(This used to be commit 8217809d86567fb4f8eb57a4d634b21c3a4c67e5)

13 years agor13125: Very well spotted crash bug fix for #3343 from
Jeremy Allison [Wed, 25 Jan 2006 05:04:08 +0000 (05:04 +0000)]
r13125: Very well spotted crash bug fix for #3343 from
SATOH Fumiyasu <>
Jerry please pick this up for 3.0.21b.
(This used to be commit 3f5860b8fb37e854ccf5d9a80848ef759154f88c)

13 years agor13124: working on RHEL/Fedora packaging for 64-bit platforms and general cleanup
Gerald Carter [Wed, 25 Jan 2006 04:56:32 +0000 (04:56 +0000)]
r13124: working on RHEL/Fedora packaging for 64-bit platforms and general cleanup
(This used to be commit 4a8e457846a49647c751ae09365539acb5c02ce2)

13 years agor13119: Fix for #1779 from William Jojo <>
Jeremy Allison [Tue, 24 Jan 2006 20:15:08 +0000 (20:15 +0000)]
r13119: Fix for #1779 from William Jojo <>
(This used to be commit 103cac7dd314117b15e27fd263a64beeb36ed6e6)

13 years agor13110: remove an invalid debug message about call get_share_mode_lock() with a NULL...
Gerald Carter [Tue, 24 Jan 2006 17:27:30 +0000 (17:27 +0000)]
r13110: remove an invalid debug message about call get_share_mode_lock() with a NULL service path and fname (we do it all the time internally)
(This used to be commit e1f75ea63780f4a1661f19554d18bbd73b069c1b)

13 years agor13095: Fix warnings assigning int to a size_t.
Jeremy Allison [Mon, 23 Jan 2006 23:19:31 +0000 (23:19 +0000)]
r13095: Fix warnings assigning int to a size_t.
(This used to be commit 1ca4abffd04bcc46b61acdc12444f3e2aad0afed)

13 years agor13093: adding vendor patch level string as announced on samba-technical ml
Gerald Carter [Mon, 23 Jan 2006 22:02:52 +0000 (22:02 +0000)]
r13093: adding vendor patch level string as announced on samba-technical ml
(This used to be commit d40f06018b9197c35a10cc9ab284dd596244f47b)

13 years agor13091: Fix gcc warning about using '0' with %s.
Jeremy Allison [Mon, 23 Jan 2006 21:57:58 +0000 (21:57 +0000)]
r13091: Fix gcc warning about using '0' with %s.
(This used to be commit 5f5f87584fec7fdeefeb54de0cb72ae5b1ac9dd4)

13 years agor13089: quick fix to work around building on SOlaris when --enable...
Gerald Carter [Mon, 23 Jan 2006 21:57:36 +0000 (21:57 +0000)]
r13089: quick fix to work around building on SOlaris when --enable-developer is specified
(This used to be commit 1c7787e4a11c530cec93fa210c97fbe4b38f333a)

13 years agor13086: hooking max connections into 'add share' as well (although the WinXP UI doesn...
Gerald Carter [Mon, 23 Jan 2006 14:47:55 +0000 (14:47 +0000)]
r13086: hooking max connections into 'add share' as well (although the WinXP UI doesn't give you a way to set the value on add
(This used to be commit e6afdf1df568921c82ce85fdce9456674c3a9a75)

13 years agor13085: hook the max connections spin box in the share properties MMC plugin
Gerald Carter [Mon, 23 Jan 2006 14:34:26 +0000 (14:34 +0000)]
r13085: hook the max connections spin box in the share properties MMC plugin
dialog to the 'max connections' smb.conf parameter.  Also added the max
uses int from the SHARE_INFO_2 structure to the 'modify share command'
(This used to be commit af68748baae6d2e5ef850c16622d5424fd303ee7)

13 years agor13083: patch suggested by Adam Nielsen for better smbstatus formatting
Gerald Carter [Mon, 23 Jan 2006 14:26:48 +0000 (14:26 +0000)]
r13083: patch suggested by Adam Nielsen for better smbstatus formatting
(This used to be commit ef69cf96145516ddca44fdb4faddfead26591345)

13 years agor13082: revert an accidentally commited patch (still in progress)
Gerald Carter [Mon, 23 Jan 2006 14:04:40 +0000 (14:04 +0000)]
r13082: revert an accidentally commited patch (still in progress)
(This used to be commit e43775fb3156bf29e4e412f01ad2d731aa866323)

13 years agor13081: correct fix for the segv in nmbd caused by a double free on namerec.
Gerald Carter [Mon, 23 Jan 2006 14:02:17 +0000 (14:02 +0000)]
r13081: correct fix for the segv in nmbd caused by a double free on namerec.
(This used to be commit c908dbc4b260bac72cbc6d25f4728359a6ec8259)

13 years agor13072: Fix segfault in vfstest and smbtorture.
Deryck Hodge [Mon, 23 Jan 2006 00:19:45 +0000 (00:19 +0000)]
r13072: Fix segfault in vfstest and smbtorture.

(This used to be commit 0fdb062f35b4c4b19bf4122d48a0b4edacfe74ca)

13 years agor13058: Add %w macro for the winbind seperator which allows us for example
Lars Müller [Fri, 20 Jan 2006 20:22:23 +0000 (20:22 +0000)]
r13058: Add %w macro for the winbind seperator which allows us for example
        valid users = %S, %D%w%S
(This used to be commit 6ff25eb8402ed006ac5e081f64bd9e074fe22295)

13 years agor13048: trying to fix the confusion over packaging platforms
Gerald Carter [Fri, 20 Jan 2006 01:11:26 +0000 (01:11 +0000)]
r13048: trying to fix the confusion over packaging platforms
(This used to be commit b99ef469d1057a8e856f3818f5fd0f25db70d4ee)

13 years agor13047: specfile updates from John T.
Gerald Carter [Fri, 20 Jan 2006 01:09:44 +0000 (01:09 +0000)]
r13047: specfile updates from John T.
(This used to be commit bec01ad3d689766df499ee489d4f4c2f8ba57fdd)

13 years agor13042: Fix for bug #3248 Stefan Burkei <>.
Jeremy Allison [Thu, 19 Jan 2006 22:26:26 +0000 (22:26 +0000)]
r13042: Fix for bug #3248 Stefan Burkei <>.
When doing auth_crap authentication use the client
given workstation name not our own.
(This used to be commit a2bb2e3e819c56b710885fc8206632e22a6ec0ce)

13 years agor13028: Fix for #3419 - vfs_full_audit *never* worked
Jeremy Allison [Thu, 19 Jan 2006 00:34:48 +0000 (00:34 +0000)]
r13028: Fix for #3419 - vfs_full_audit *never* worked
correctly. Static variables were used !
(This used to be commit 2ab5aeca895476869f0b50e513a77c9f2558fc56)

13 years agor13027: Support file change notifications from FAM.
James Peach [Thu, 19 Jan 2006 00:30:16 +0000 (00:30 +0000)]
r13027: Support file change notifications from FAM.
(This used to be commit 652b511ff24ce41c7745a0e00363e619e5027828)

13 years agor13024: Add is_null_sid.
Günther Deschner [Thu, 19 Jan 2006 00:03:07 +0000 (00:03 +0000)]
r13024: Add is_null_sid.

(This used to be commit 3a6e41a0cb2872a656ea79c8d4fc4b8bce436492)

13 years agor13023: Ensure we notice if we exit due to guest user setup fail.
Jeremy Allison [Wed, 18 Jan 2006 23:42:29 +0000 (23:42 +0000)]
r13023: Ensure we notice if we exit due to guest user setup fail.
(This used to be commit f8d09d111ccd8c2805245662e01cd99dba1d9292)

13 years agor13020: Prevent cli_krb5_get_ticket of getting into an infite loop. This whole
Günther Deschner [Wed, 18 Jan 2006 22:40:00 +0000 (22:40 +0000)]
r13020: Prevent cli_krb5_get_ticket of getting into an infite loop. This whole
area of code needs to be reworked later on.

(This used to be commit 088abfcdd1d6b28409d4b2917bc2aeb5d371f675)

13 years agor13015: Make logic much clearer. From jpeach.
Jeremy Allison [Wed, 18 Jan 2006 20:45:44 +0000 (20:45 +0000)]
r13015: Make logic much clearer. From jpeach.
(This used to be commit d9b6bdd84a16c8af44049748a0fc47844f597919)

13 years agor13012: Fix #3421 - it turns out krb5_kt_get_entry() on MIT
Jeremy Allison [Wed, 18 Jan 2006 19:25:18 +0000 (19:25 +0000)]
r13012: Fix #3421 - it turns out krb5_kt_get_entry() on MIT
does an implicit open/read/close and blows away an
open keytab handle - so make sure we use a new
Wonderful analysis from Luke <>
helped fix this.
(This used to be commit 9d2f2385ad68cbe11bdfb82b5f2d016626f6e679)

13 years agor12994: Fix cut&paste error, thanks to Björn Jachke <>
Volker Lendecke [Wed, 18 Jan 2006 10:25:04 +0000 (10:25 +0000)]
r12994: Fix cut&paste error, thanks to Björn Jachke <>
(This used to be commit 8176f5a2821e897d8ff0b127450c918a2d82b70a)

13 years agor12993: Ouch...
Volker Lendecke [Wed, 18 Jan 2006 10:05:55 +0000 (10:05 +0000)]
r12993: Ouch...
(This used to be commit de0347cd706c36a593dba9e46c9106b8215fe656)

13 years agor12991: some fixes for BUG 3331 - solaris packaging
Gerald Carter [Wed, 18 Jan 2006 04:56:28 +0000 (04:56 +0000)]
r12991: some fixes for BUG 3331 - solaris packaging
(This used to be commit b334052108f58cc71898ec0b4b745da1f9d53bec)

13 years agor12990: BUG 3329: patch from David May <> for Solaris shell...
Gerald Carter [Wed, 18 Jan 2006 04:44:59 +0000 (04:44 +0000)]
r12990: BUG 3329: patch from David May <> for Solaris shell script portability issues in 'make test'
(This used to be commit 19339a9510467b4b2cf3889bc6a08563cdc940f4)

13 years agor12986: Use d_fprintf(stderr, ...) for any error message in net.
Lars Müller [Tue, 17 Jan 2006 21:22:00 +0000 (21:22 +0000)]
r12986: Use d_fprintf(stderr, ...) for any error message in net.

All 'usage' messages are still printed to stdout.

Fix some compiler warnings for system() calls where we didn't used the
return code.  Add appropriate error messages and return with the error
code we got from system() or NT_STATUS_UNSUCCESSFUL.
(This used to be commit f650e3bdafc4c6bcd7eb4bcf8b6b885b979919eb)

13 years agor12967: BUG 1061: don't corrupt the file name when reading an lmhosts file (-H) in...
Gerald Carter [Mon, 16 Jan 2006 18:03:56 +0000 (18:03 +0000)]
r12967: BUG 1061: don't corrupt the file name when reading an lmhosts file (-H) in nmbd.  Patch from    Andrew Esh <>
(This used to be commit 14160c496112e06e4ea0d0a5aa5bad2b58e90601)

13 years agor12964: Rewind rem_backend in the case we have to workaround the idmap_ prefix.
Lars Müller [Mon, 16 Jan 2006 17:21:47 +0000 (17:21 +0000)]
r12964: Rewind rem_backend in the case we have to workaround the idmap_ prefix.
Else SAFE_FREE seg faults.  Thanks to Günther for pointing me at this.

I've implemented in in this was as we should announce to remove the
idmap_ strip stuff after some time at all.
(This used to be commit 6a5bf399a59b4f07a1560d534629cb14e20b5d3f)

13 years agor12956: Fix for bug #3035 from SATOH Fumiyasu <>
Jeremy Allison [Mon, 16 Jan 2006 05:47:39 +0000 (05:47 +0000)]
r12956: Fix for bug #3035 from SATOH Fumiyasu <>

On a Windows share, a file with read-only dosmode can be opened with
DELETE_ACCESS. But on a Samba share (delete readonly = no), it
fails with NT_STATUS_CANNOT_DELETE error.

This semantic causes a problem that a user can not
rename a file with read-only dosmode on a Samba share
from a Windows command prompt (i.e. cmd.exe, but can rename
from Windows Explorer).

(This used to be commit dd185c7aa8de156dab58b065bf73905b2a29f40d)

13 years agor12953: Support the TCP_FASTACK socket option if it is available. Note that this...
James Peach [Sun, 15 Jan 2006 23:13:47 +0000 (23:13 +0000)]
r12953: Support the TCP_FASTACK socket option if it is available. Note that this will
not acutally help, but it is good to be complete.
(This used to be commit 2163e4b6b453ebf1fefc64e74890300108bbf8f6)

13 years agor12951: Tell the MIPSPro compiler to push DEBUG calls out of line.
James Peach [Sun, 15 Jan 2006 23:09:17 +0000 (23:09 +0000)]
r12951: Tell the MIPSPro compiler to push DEBUG calls out of line.
(This used to be commit a346059912c05d2b4a27892571d6e89f44907d5c)

13 years agor12946: fix a segfault in nmbd when 'wins support = yes' caused by double free
Gerald Carter [Sun, 15 Jan 2006 12:30:36 +0000 (12:30 +0000)]
r12946: fix a segfault in nmbd when 'wins support = yes' caused by double free
(This used to be commit c11372f4ec49634e2ae2e6b9ddf4d2b72976f9c5)

13 years agor12938: Fix for #3408 (change password fails) from William Jojo <>.
Jeremy Allison [Sat, 14 Jan 2006 20:25:51 +0000 (20:25 +0000)]
r12938: Fix for #3408 (change password fails) from William Jojo <>.
(This used to be commit 5fc0ef80876a666c285585f8b55e1909e8f2e0bf)

13 years agor12936: Fix bug #3264.
Lars Müller [Sat, 14 Jan 2006 15:25:33 +0000 (15:25 +0000)]
r12936: Fix bug #3264.

If we detect a leading 'idmap_' for the idmap backend setting we strip
this and inform about the deprecated config with DEBUG 0.

I'm not sure if we should set a TTL of one year or five additional
releases from now for this code.

This is required for the changes Günther made as the first step to solve
bug #3264.  With this fix we can even run with an old config.  This is
very important as we else will break existing configurations with an
(This used to be commit 34c7d8c0694369760340843318f873e26546cb2e)

13 years agor12935: After discussion with Volker fix bug #3397 using a variant of the patch by...
Alexander Bokovoy [Sat, 14 Jan 2006 12:37:25 +0000 (12:37 +0000)]
r12935: After discussion with Volker fix bug #3397 using a variant of the patch by Alex Deiter (
Introduces level 9 of getuserinfo and allows to successfully install MS SMS2003
on a member of a Samba domain. Also added support for this level in rpcclient.

The code for infolevel 9 is modelled upon Samba-TNG by Alex Deiter.

Jerry, we need this in 3.0.21b.
(This used to be commit 93461646ce2ad6e2f8b11d40ce98722d56a83b43)

13 years agor12922: Fix typo.
Jeremy Allison [Fri, 13 Jan 2006 23:54:12 +0000 (23:54 +0000)]
r12922: Fix typo.
(This used to be commit 1c32b352da270370e65d25939fdc56c2a415190f)

13 years agor12920: Fix for #3401 from Andrew Bartlett. Original fix from
Jeremy Allison [Fri, 13 Jan 2006 23:23:09 +0000 (23:23 +0000)]
r12920: Fix for #3401 from Andrew Bartlett. Original fix from
Yau Lam Yiu <>.
(This used to be commit 4776101107923e425a153fe0457dbf61f4c99935)

13 years agor12916: use rpcstr_pull() instead of unistr_to_ascii() when validating share names
Gerald Carter [Fri, 13 Jan 2006 21:22:25 +0000 (21:22 +0000)]
r12916: use rpcstr_pull() instead of unistr_to_ascii() when validating share names
(This used to be commit c08bc30698eac2f3f5dd8257b4fd7c3e23e6de39)

13 years agor12915: protect against changing the SCM security descriptor
Gerald Carter [Fri, 13 Jan 2006 20:26:59 +0000 (20:26 +0000)]
r12915: protect against changing the SCM security descriptor
(This used to be commit 5842da99681c15437c11e9925dec24c8c0e3708a)

13 years agor12914: adding query/set ops for security descriptors on services.
Gerald Carter [Fri, 13 Jan 2006 20:24:50 +0000 (20:24 +0000)]
r12914: adding query/set ops for security descriptors on services.
(This used to be commit cefd2d7cb6140b068d66e2383e9acfa4c3c4b4c7)

13 years agor12913: missed merge to fix BUG 3391; ensure we can lookup account policies
Gerald Carter [Fri, 13 Jan 2006 19:38:09 +0000 (19:38 +0000)]
r12913: missed merge to fix BUG 3391; ensure we can lookup account policies
(This used to be commit 77575c64e4e961f37ccf5b2dd17e41c74678ea45)