ira/wip.git
11 years agos4:kdc: setup the local and remote tsocket_address at accept time
Stefan Metzmacher [Wed, 4 Nov 2009 18:22:53 +0000 (19:22 +0100)]
s4:kdc: setup the local and remote tsocket_address at accept time

metze

11 years agos4:kdc: convert UDP based communication to tdgram_context
Stefan Metzmacher [Wed, 4 Nov 2009 18:22:53 +0000 (19:22 +0100)]
s4:kdc: convert UDP based communication to tdgram_context

metze

11 years agoActually explain the twisty paths of tortured logic behind
Jeremy Allison [Fri, 18 Dec 2009 22:28:22 +0000 (14:28 -0800)]
Actually explain the twisty paths of tortured logic behind
reply_doserror(), reply_nterror(), and reply_nterror(NT_STATUS_DOS()).

Fix the call in rely_openerror() to actually force a DOS error
for "too many open files".

Jeremy.

11 years agoreply_doserror() doesn't force DOS errors on the wire.
Jeremy Allison [Fri, 18 Dec 2009 22:25:39 +0000 (14:25 -0800)]
reply_doserror() doesn't force DOS errors on the wire.

Start migrating uses of reply_doserror() to reply_nterror() with the
correct mapping. Eventually we'll get to the point where we can
change reply_doserror() to force a DOS error code on the wire,
and can change calls to reply_nterror(req, NT_STATUS_DOS()) - which *does*
force DOS errors on the wire - to reply_doserror(). Which might
actually make the server code look like it's making sense.

Jeremy.

11 years agoreply_force_nterror() is not used anywhere. Remove it.
Jeremy Allison [Fri, 18 Dec 2009 22:25:07 +0000 (14:25 -0800)]
reply_force_nterror() is not used anywhere. Remove it.
Jeremy.

11 years agos4 torture: Add test to show archive bit behavior with directories
Zachary Loafman [Thu, 17 Dec 2009 22:32:58 +0000 (22:32 +0000)]
s4 torture: Add test to show archive bit behavior with directories

Signed-off-by: Tim Prouty <tprouty@samba.org>
11 years agos4 torture: Fix RAW-STREAMS-DELETE to pass against samba3
Tim Prouty [Fri, 18 Dec 2009 17:35:57 +0000 (09:35 -0800)]
s4 torture: Fix RAW-STREAMS-DELETE to pass against samba3

11 years agoAdded freeing a successful req so it doesnt croud the ldb context
Nadezhda Ivanova [Fri, 18 Dec 2009 15:57:08 +0000 (17:57 +0200)]
Added freeing a successful req so it doesnt croud the ldb context

11 years agoAdded oid for AS_SYSTEM control, used to bypass access checks for system operations.
Nadezhda Ivanova [Fri, 18 Dec 2009 13:40:11 +0000 (15:40 +0200)]
Added oid for AS_SYSTEM control, used to bypass access checks for system operations.

11 years agos3-docs: mention pam_winbind.conf(5) manpage in pam_winbind(8) manpage.
Günther Deschner [Fri, 18 Dec 2009 12:56:43 +0000 (13:56 +0100)]
s3-docs: mention pam_winbind.conf(5) manpage in pam_winbind(8) manpage.

Guenther

11 years agos3-docs: add new pam_winbind.conf(5) manpage.
Günther Deschner [Fri, 18 Dec 2009 12:56:01 +0000 (13:56 +0100)]
s3-docs: add new pam_winbind.conf(5) manpage.

Guenther

11 years agos4-dsdb: stop warnings about unknown struct GUID in prototypes
Andrew Tridgell [Fri, 18 Dec 2009 03:57:57 +0000 (14:57 +1100)]
s4-dsdb: stop warnings about unknown struct GUID in prototypes

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-ldb: fixed a valgrind error in ldbtest
Andrew Tridgell [Fri, 18 Dec 2009 02:07:48 +0000 (13:07 +1100)]
s4-ldb: fixed a valgrind error in ldbtest

we were using msg->dn after the ldb it contained had been freed

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: greatly simplify the subtree_delete module
Andrew Tridgell [Thu, 17 Dec 2009 12:01:13 +0000 (23:01 +1100)]
s4-dsdb: greatly simplify the subtree_delete module

We can use dsdb_module_search() to make this much simpler

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: declare ldb_dn_update_components()
Andrew Tridgell [Thu, 17 Dec 2009 12:04:00 +0000 (23:04 +1100)]
s4-dsdb: declare ldb_dn_update_components()

11 years agos4-dsdb: added ldb_dn_update_components()
Andrew Tridgell [Thu, 17 Dec 2009 12:03:41 +0000 (23:03 +1100)]
s4-dsdb: added ldb_dn_update_components()

This is used to udpate just the DN components of a ldb_dn, leaving the
other extended fields alone. It is needed to prevent linked attribute
updates from removing other extended components.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: fixed the sort in dsdb_find_nc_root()
Andrew Tridgell [Thu, 17 Dec 2009 12:50:05 +0000 (23:50 +1100)]
s4-dsdb: fixed the sort in dsdb_find_nc_root()

11 years agos4-ldb: display msDS-OptionalFeatureGUID as a GUID
Andrew Tridgell [Fri, 18 Dec 2009 00:43:21 +0000 (11:43 +1100)]
s4-ldb: display msDS-OptionalFeatureGUID as a GUID

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-scripts: add a enablerecyclebin script
Andrew Tridgell [Fri, 18 Dec 2009 00:44:20 +0000 (11:44 +1100)]
s4-scripts: add a enablerecyclebin script

This can be used to enable the recyclebin on a windows box. Once we
properly implement this feature in samba we will use this to enable
the feature on ourselves as well.

11 years agos4-ldb: canonicalise the message on ldb_add
Andrew Tridgell [Thu, 17 Dec 2009 03:20:35 +0000 (14:20 +1100)]
s4-ldb: canonicalise the message on ldb_add

This canonicalise avoids a problem with an add that has multiple
elements with the same el->name. That is allowed by MS servers, and by
ldb, but it breaks things like the tdb backend and the repl_meta_data
RPMD handling.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: Add a test for adding, deleting, and appending a posixAccount objectClass...
Brendan Powers [Tue, 15 Dec 2009 01:51:10 +0000 (20:51 -0500)]
s4-dsdb: Add a test for adding, deleting, and appending a posixAccount objectClass to a user

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-dsdb: fix handling of AUX classes in objectclass_sort
Brendan Powers [Tue, 15 Dec 2009 01:47:18 +0000 (20:47 -0500)]
s4-dsdb: fix handling of AUX classes in objectclass_sort

This is done by sorting the classes by subClass_order, which will
check if the last structural class is valid to add (in
objectclass_do_add instead checking the last class in the list).

They were being sorted by building a class tree, and adding the
classes to the list in that order. However, AUX classes usually don't
fit into that tree, so LDB_ERR_OBJECT_CLASS_VIOLATION was returned. I
have changed the behavior to sort the classes by subClass_order
instead.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-dsdb: return an error if samAccountName is not specified when creating a user.
Brendan Powers [Tue, 15 Dec 2009 01:40:26 +0000 (20:40 -0500)]
s4-dsdb: return an error if samAccountName is not specified when creating a user.

Makes sure samAccountName has been specified before adding a
user. This happened while I was trying to add a user with the
posixAccount objectclass. I forgot to specify the user objectClass,
and samba segfaulted. It now returns LDB_ERR_CONSTRAINT_VIOLATION.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-dsdb: Move get_last_structural class from descriptor.c to util.c
Brendan Powers [Tue, 15 Dec 2009 01:36:44 +0000 (20:36 -0500)]
s4-dsdb: Move get_last_structural class from descriptor.c to util.c

It can now also be used by objectclass.c

get_last_structural_class now ignores AUX classes, because they are
not structural

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4-dsdb: Add a check to prevent acl_modify from debuging a NULL message
Brendan Powers [Tue, 15 Dec 2009 01:32:28 +0000 (20:32 -0500)]
s4-dsdb: Add a check to prevent acl_modify from debuging a NULL message

Check to see if there were any messages passed to acl_modify before
debugging the first one. I think I caused this by some malformed
LDIF.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agoReturn NULL in strlower_talloc if src is NULL
Brendan Powers [Tue, 15 Dec 2009 01:28:48 +0000 (20:28 -0500)]
Return NULL in strlower_talloc if src is NULL

Prevents strlower_talloc from segfaulting if you pass it a NULL string.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4:provision Give a more useful error message in guess_names
Andrew Bartlett [Tue, 15 Dec 2009 05:41:37 +0000 (16:41 +1100)]
s4:provision Give a more useful error message in guess_names

The problem here is that as we start to get 'real users' they still
decide to do silly things, like load empty but existing smb.conf
files.  Let's give them a better chance to discover what they did
wrong.

Andrew Bartlett

11 years agoAlways map EMFILE to ERRDOS, ERRnofids, *NOT* NT_STATUS_TOO_MANY_OPENED_FILES.
Jeremy Allison [Fri, 18 Dec 2009 02:31:44 +0000 (18:31 -0800)]
Always map EMFILE to ERRDOS, ERRnofids, *NOT* NT_STATUS_TOO_MANY_OPENED_FILES.
This is what W2KR3 does for NTCreateX and openX calls. May be the correct fix
for bug 6837 - "Too many open files" when trying to access large number of files.
Jeremy.

11 years agoVector correctly through reply_openerror() (which uses the same logic).
Jeremy Allison [Fri, 18 Dec 2009 02:31:26 +0000 (18:31 -0800)]
Vector correctly through reply_openerror() (which uses the same logic).
Jeremy.

11 years agos4 torture: RAW-STREAMS-NAMES Make sure the create time of the streams are different...
Tim Prouty [Thu, 17 Dec 2009 21:42:24 +0000 (13:42 -0800)]
s4 torture: RAW-STREAMS-NAMES Make sure the create time of the streams are different from the base file

11 years agos4 torture: Add RAW-STREAMS-RENAME3 to show error when trying to overwrite a stream...
Tim Prouty [Thu, 17 Dec 2009 18:39:51 +0000 (10:39 -0800)]
s4 torture: Add RAW-STREAMS-RENAME3 to show error when trying to overwrite a stream with an open handle

A normal file overwrite in this case would return NT_STATUS_ACCESS_DENIED,
but if a stream is the target NT_STATUS_INVALID_PARAMETER is returned.

11 years agos4 torture: Parameterize streams delete behavior rather than commenting out the check.
Tim Prouty [Wed, 16 Dec 2009 22:31:54 +0000 (14:31 -0800)]
s4 torture: Parameterize streams delete behavior rather than commenting out the check.

11 years agos4 torture: RAW-STREAMS-CREATEDISP Use a normal deny mode
Tim Prouty [Thu, 17 Dec 2009 21:35:01 +0000 (13:35 -0800)]
s4 torture: RAW-STREAMS-CREATEDISP Use a normal deny mode

11 years agos4 torture: close handle instead of using exit
Tim Prouty [Wed, 16 Dec 2009 01:17:48 +0000 (17:17 -0800)]
s4 torture: close handle instead of using exit

11 years agoUpdate default with correct value. Add a note about Win7 behavior
Jeremy Allison [Fri, 18 Dec 2009 00:50:35 +0000 (16:50 -0800)]
Update default with correct value. Add a note about Win7 behavior
here.
Jeremy.

11 years agoFix bug #6939 - mangling method = hash breaks long filenames.
Jeremy Allison [Fri, 18 Dec 2009 00:14:30 +0000 (16:14 -0800)]
Fix bug #6939 - mangling method = hash breaks long filenames.

We were returning the wrong sense of the bool. must_mangle()
has to return !NT_STATUS_IS_OK, not NT_STATUS_IS_OK.

Jeremy.

11 years agos4:"samdb_set_password" - remove delete instructions
Matthias Dieter Wallnöfer [Thu, 17 Dec 2009 18:41:11 +0000 (19:41 +0100)]
s4:"samdb_set_password" - remove delete instructions

They won't work when the LDB change is done using "samdb_replace"
(consider "samr_password.c" functions).

I think this has been a relict which has been useful before the "password_hash"
module existed. Basically it itself does now the updates.

11 years agos4-smbtorture: skip GetAliasMembership against s4.
Günther Deschner [Thu, 17 Dec 2009 17:02:53 +0000 (18:02 +0100)]
s4-smbtorture: skip GetAliasMembership against s4.

It returns NT_STATUS_INTERNAL_DB_CORRUPTION for unknown sids and I could not
figure out why.

Guenther

11 years agoFixed incorrect checking of PRINCIPAL_SELF permissions.
Nadezhda Ivanova [Thu, 17 Dec 2009 15:25:11 +0000 (17:25 +0200)]
Fixed incorrect checking of PRINCIPAL_SELF permissions.

If an ace has the PRINCIPAL_SELF as trustee, this sid has to be replaced with
the onjectSid of the object being checked. PRINCIPAL_SELF is the way to grant rights
to an account over itself.

11 years agos4-smbtorture: add a samr_GetAliasMembership test to RPC-SAMR.
Günther Deschner [Thu, 17 Dec 2009 14:34:22 +0000 (15:34 +0100)]
s4-smbtorture: add a samr_GetAliasMembership test to RPC-SAMR.

Guenther

11 years agotdbtool: avoid using c++ reserved words.
Günther Deschner [Wed, 16 Dec 2009 23:13:23 +0000 (00:13 +0100)]
tdbtool: avoid using c++ reserved words.

Guenther

11 years agos3: Run RPC-SAMBA3-GETALIASMEMBERSHIP-0 in make test
Volker Lendecke [Thu, 17 Dec 2009 10:58:43 +0000 (11:58 +0100)]
s3: Run RPC-SAMBA3-GETALIASMEMBERSHIP-0 in make test

11 years agos4:dsdb/common/util - make NTTIME attribute wrappers use a "const" message
Matthias Dieter Wallnöfer [Thu, 17 Dec 2009 11:43:10 +0000 (12:43 +0100)]
s4:dsdb/common/util - make NTTIME attribute wrappers use a "const" message

There is no reason to have the message non-const here.

11 years agos3: Fix bug 6992, make test for getgrouplist cacheable
Jonas Gorski [Thu, 17 Dec 2009 10:32:21 +0000 (11:32 +0100)]
s3: Fix bug 6992, make test for getgrouplist cacheable

11 years agos4-smbtorture: fix smbtorture after setprinter IDL fixes.
Günther Deschner [Wed, 16 Dec 2009 09:33:41 +0000 (10:33 +0100)]
s4-smbtorture: fix smbtorture after setprinter IDL fixes.

Guenther

11 years agos3-spoolss: fix rpcclient after setprinter IDL fixes.
Günther Deschner [Wed, 16 Dec 2009 09:33:13 +0000 (10:33 +0100)]
s3-spoolss: fix rpcclient after setprinter IDL fixes.

Guenther

11 years agospoolss: more mork on SetPrinterInfo() levels.
Günther Deschner [Wed, 16 Dec 2009 09:32:35 +0000 (10:32 +0100)]
spoolss: more mork on SetPrinterInfo() levels.

Guenther

11 years agos4-ntvfs: check if pvfs is NULL in pvfs_logoff
brendan powers [Thu, 17 Dec 2009 00:01:32 +0000 (19:01 -0500)]
s4-ntvfs: check if pvfs is NULL in pvfs_logoff

pvfs can be NULL if the directory a share points to does not exist. In
this case, there would be no open files, so it is safe to just return
from the function.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4:gensec: allow clearing local and remote address by passing NULL
Stefan Metzmacher [Wed, 16 Dec 2009 19:34:15 +0000 (20:34 +0100)]
s4:gensec: allow clearing local and remote address by passing NULL

metze

11 years agos4-gensec: Remove obsolete socket_address vars and fns.
Andreas Schneider [Wed, 16 Dec 2009 17:07:07 +0000 (18:07 +0100)]
s4-gensec: Remove obsolete socket_address vars and fns.

11 years agos4-gensec: Replace gensec_get_peer_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:41:21 +0000 (16:41 +0100)]
s4-gensec: Replace gensec_get_peer_addr with new tsocket based fn.

11 years agos4-gensec: Replace gensec_set_peer_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:12:13 +0000 (16:12 +0100)]
s4-gensec: Replace gensec_set_peer_addr with new tsocket based fn.

11 years agos4-gensec: Replace gensec_get_my_addr with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 15:06:55 +0000 (16:06 +0100)]
s4-gensec: Replace gensec_get_my_addr with new tsocket based fn.

11 years agos4-gensec: Replace gensec_set_my_addr() with new tsocket based fn.
Andreas Schneider [Wed, 16 Dec 2009 14:52:30 +0000 (15:52 +0100)]
s4-gensec: Replace gensec_set_my_addr() with new tsocket based fn.

11 years agos4-gensec: Added remote and local setter/getter using tsocket.
Andreas Schneider [Wed, 16 Dec 2009 12:27:20 +0000 (13:27 +0100)]
s4-gensec: Added remote and local setter/getter using tsocket.

11 years agoFinal part of the fix for 6837 - "Too many open files" when trying to access large...
Jeremy Allison [Wed, 16 Dec 2009 18:19:19 +0000 (10:19 -0800)]
Final part of the fix for 6837 - "Too many open files" when trying to access large number of files

Win7 needs a min of 16k file handles to work against a
server.

Jeremy.

11 years agoAdd helpful debug of DACL for errors on ACL access.
Jeremy Allison [Wed, 16 Dec 2009 18:09:11 +0000 (10:09 -0800)]
Add helpful debug of DACL for errors on ACL access.
Jeremy.

11 years agospoolss: add spoolss_DriverInfo7.
Günther Deschner [Wed, 16 Dec 2009 09:39:00 +0000 (10:39 +0100)]
spoolss: add spoolss_DriverInfo7.

Guenther

11 years agos3-pdbedit: allow to call "pdbedit -N description -u user" without specifiyng "-r".
Günther Deschner [Wed, 16 Dec 2009 14:59:04 +0000 (15:59 +0100)]
s3-pdbedit: allow to call "pdbedit -N description -u user" without specifiyng "-r".

Guenther

11 years agos4-dsdb: also mark the relax control non-critical when done
Andrew Tridgell [Wed, 16 Dec 2009 09:45:40 +0000 (20:45 +1100)]
s4-dsdb: also mark the relax control non-critical when done

11 years agos4-dsdb: it is a better pattern to mark a control as done than remove it
Andrew Tridgell [Wed, 16 Dec 2009 09:45:02 +0000 (20:45 +1100)]
s4-dsdb: it is a better pattern to mark a control as done than remove it

removing a control means it can't be seen by any other modules, which
is usually not what is wanted. Better to just mark it non-critical,
which means anyone else who wants to look at it can, but if nobody
does its not an error.

11 years agos4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor
Andrew Tridgell [Wed, 16 Dec 2009 09:39:55 +0000 (20:39 +1100)]
s4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor

11 years agos4-dsdb: don't actually remove the sd_flags control, just mark it non-critical
Andrew Tridgell [Wed, 16 Dec 2009 09:39:18 +0000 (20:39 +1100)]
s4-dsdb: don't actually remove the sd_flags control, just mark it non-critical

For controls that need to be seen by more than one module, it is best
to just mark them non-critical when handled, instead of removing
them. Otherwise lower modules can't see them.

In this case we want the operational module to see the SD_FLAGS
control

11 years agos4-ldb: show the OID of any unhandled critical controls
Andrew Tridgell [Wed, 16 Dec 2009 06:13:19 +0000 (17:13 +1100)]
s4-ldb: show the OID of any unhandled critical controls

It isn't very useful just saying that a control is not supported,
without saying which one is the problem

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-ldb: fixed a transaction error on prepare_commit
Andrew Tridgell [Wed, 16 Dec 2009 06:12:28 +0000 (17:12 +1100)]
s4-ldb: fixed a transaction error on prepare_commit

when a prepare commit fails, we need to give a cancel to all modules,
not a commit!

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-ldb: added --show-deactivated-link command line option
Andrew Tridgell [Wed, 16 Dec 2009 03:58:35 +0000 (14:58 +1100)]
s4-ldb: added --show-deactivated-link command line option

this adds the SHOW_DEACTIVATED_LINK control

11 years agoldap: give a debug error when we don't know a control
Andrew Tridgell [Wed, 16 Dec 2009 03:57:32 +0000 (14:57 +1100)]
ldap: give a debug error when we don't know a control

This interface should really have a proper error interface, but at
least a DEBUG() gives the user a chance of finding the error

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added dsdb_get_deleted_objects_dn()
Andrew Tridgell [Wed, 16 Dec 2009 02:41:21 +0000 (13:41 +1100)]
s4-dsdb: added dsdb_get_deleted_objects_dn()

This is based on the code from Eduardo Lima <eduardoll@gmail.com>, but
uses the new helper functions added in the last couple of commits

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added dsdb_find_nc_root()
Andrew Tridgell [Wed, 16 Dec 2009 02:36:17 +0000 (13:36 +1100)]
s4-dsdb: added dsdb_find_nc_root()

This is based on the function of the same name from Eduardo Lima
<eduardoll@gmail.com>, but using ldb_dn_compare, to give us
comparisons consistent with what the rest of the code uses.

We will use this function in combination with dsdb_wellknown_dn() to
find the Deleted Objects container for any object.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added dsdb_wellknown_dn()
Andrew Tridgell [Wed, 16 Dec 2009 02:18:44 +0000 (13:18 +1100)]
s4-dsdb: added dsdb_wellknown_dn()

This finds a wellknown object given its GUID

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agolibds: added GUIDs for wellknown AD objects
Andrew Tridgell [Wed, 16 Dec 2009 02:18:10 +0000 (13:18 +1100)]
libds: added GUIDs for wellknown AD objects

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added a dsdb_module_rename() call
Andrew Tridgell [Wed, 16 Dec 2009 01:01:16 +0000 (12:01 +1100)]
s4-dsdb: added a dsdb_module_rename() call

This will be used by the replmd_delete() code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added dsdb_module_modify()
Andrew Tridgell [Wed, 16 Dec 2009 00:32:57 +0000 (11:32 +1100)]
s4-dsdb: added dsdb_module_modify()

This is used to do a sync modify in a module

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: fixed dsdb_module_dn_by_guid()
Andrew Tridgell [Wed, 16 Dec 2009 00:31:30 +0000 (11:31 +1100)]
s4-dsdb: fixed dsdb_module_dn_by_guid()

needs to ask for the DN in storage format, plus fix compilation errors

11 years agos4-dsdb: dsdb_flags should be unsigned
Andrew Tridgell [Wed, 16 Dec 2009 00:30:03 +0000 (11:30 +1100)]
s4-dsdb: dsdb_flags should be unsigned

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls
Andrew Tridgell [Wed, 16 Dec 2009 00:28:50 +0000 (11:28 +1100)]
s4-dsdb: rename dsdb_module_search_handle_flags to dsdb_request_add_controls

This function will be used for non-search controls, like relax

11 years agos4-dsdb: added dsdb_module_dn_by_guid()
Andrew Tridgell [Tue, 15 Dec 2009 23:27:32 +0000 (10:27 +1100)]
s4-dsdb: added dsdb_module_dn_by_guid()

This finds a DN given a GUID, searching below the current module in
the module stack.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: use dsdb_dn_is_deleted_val()
Andrew Tridgell [Tue, 15 Dec 2009 00:01:18 +0000 (11:01 +1100)]
s4-dsdb: use dsdb_dn_is_deleted_val()

This also moves the check to before we parse the DN, which saves some
unnecessary work

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-dsdb: added dsdb_dn_is_deleted_val()
Andrew Tridgell [Tue, 15 Dec 2009 00:00:30 +0000 (11:00 +1100)]
s4-dsdb: added dsdb_dn_is_deleted_val()

This is used to determine if a extedned DN has the 'DELETED=1'
component

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

11 years agos4-ntvfs: try to fix bug 6989
Andrew Tridgell [Tue, 15 Dec 2009 22:32:10 +0000 (09:32 +1100)]
s4-ntvfs: try to fix bug 6989

bug 6989 is a rare crash that has occurred in production. My best
guess as to the cause is the talloc_free() not being specific enough
as to which parent needs to be freed.

11 years agos4:drsuapi/getncchanges.c - Update the list of operational attributes
Matthias Dieter Wallnöfer [Wed, 16 Dec 2009 08:45:22 +0000 (09:45 +0100)]
s4:drsuapi/getncchanges.c - Update the list of operational attributes

- Reorder them as specified in "operational.c"
- Add also the lan manager hash password attribute

11 years agoEnsure dos_mode can return FILE_ATTRIBUTE_NORMAL, then filter the returned attributes...
Jeremy Allison [Wed, 16 Dec 2009 02:03:47 +0000 (18:03 -0800)]
Ensure dos_mode can return FILE_ATTRIBUTE_NORMAL, then filter the returned attributes by protocol level.

This makes us consistant in returning DOS attrs across all replies. Tested on OS/2 by Günter Kukkukk.
Jeremy.

11 years agos4-smbtorture: run GetPrinterDriver2 tests against each printer's driver.
Günther Deschner [Tue, 15 Dec 2009 21:26:39 +0000 (22:26 +0100)]
s4-smbtorture: run GetPrinterDriver2 tests against each printer's driver.

Guenther

11 years agos4:prog_guide4.txt: remove obsolete comments
Stefan Metzmacher [Tue, 15 Dec 2009 15:52:00 +0000 (16:52 +0100)]
s4:prog_guide4.txt: remove obsolete comments

metze

11 years agos4: Fixed the programming guide to reflect the current tree.
Andreas Schneider [Tue, 15 Dec 2009 15:46:03 +0000 (16:46 +0100)]
s4: Fixed the programming guide to reflect the current tree.

11 years agos4-kdc: Migrate to tsocket_address.
Andreas Schneider [Tue, 15 Dec 2009 11:58:40 +0000 (12:58 +0100)]
s4-kdc: Migrate to tsocket_address.

11 years agotsocket: Fixed tsocket_guide.txt asciidoc syntax.
Andreas Schneider [Tue, 15 Dec 2009 11:58:18 +0000 (12:58 +0100)]
tsocket: Fixed tsocket_guide.txt asciidoc syntax.

11 years agotsocket: Fixed documentation for tsocket_address_bsd_sockaddr().
Andreas Schneider [Tue, 15 Dec 2009 11:57:35 +0000 (12:57 +0100)]
tsocket: Fixed documentation for tsocket_address_bsd_sockaddr().

11 years agotsocket: Fixed typo in LGPL header.
Andreas Schneider [Tue, 15 Dec 2009 11:56:44 +0000 (12:56 +0100)]
tsocket: Fixed typo in LGPL header.

11 years agotsocket: add tsocket_address_bsd_sockaddr() and tsocket_address_bsd_from_sockaddr()
Stefan Metzmacher [Wed, 4 Nov 2009 18:03:41 +0000 (19:03 +0100)]
tsocket: add tsocket_address_bsd_sockaddr() and tsocket_address_bsd_from_sockaddr()

metze

11 years agosmbtorture4: Add rpc-samba3-getaliasmembership-0
Volker Lendecke [Tue, 15 Dec 2009 16:49:24 +0000 (17:49 +0100)]
smbtorture4: Add rpc-samba3-getaliasmembership-0

11 years agos3: Fix _samr_GetAliasMembership for results with 0 rids
Volker Lendecke [Tue, 15 Dec 2009 13:01:43 +0000 (14:01 +0100)]
s3: Fix _samr_GetAliasMembership for results with 0 rids

11 years agoRemoved ldb_modify_ctrl from ldb, implemented as a static in ldap_backend.
Nadezhda Ivanova [Tue, 15 Dec 2009 18:29:20 +0000 (20:29 +0200)]
Removed ldb_modify_ctrl from ldb, implemented as a static in ldap_backend.

11 years agos4 torture: Add new RAW-SEARCH test to explore strange max count behavior
Aravind Srinivasan [Tue, 15 Dec 2009 17:49:08 +0000 (09:49 -0800)]
s4 torture: Add new RAW-SEARCH test to explore strange max count behavior

Signed-off-by: Tim Prouty <tprouty@samba.org>
11 years agos4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the...
Aravind Srinivasan [Tue, 15 Dec 2009 17:22:07 +0000 (09:22 -0800)]
s4 torture: Update RAW-QFILEINFO to only test info levels that are supported by the server

Signed-off-by: Tim Prouty <tprouty@samba.org>
11 years agos4 torture: Convert RAW-OPEN to suite form
Zach Loafman [Mon, 14 Dec 2009 18:31:02 +0000 (10:31 -0800)]
s4 torture: Convert RAW-OPEN to suite form

11 years agos4 torture: Add SHARE_DELETE to create_directory_handle
Tim Prouty [Tue, 15 Dec 2009 01:00:43 +0000 (17:00 -0800)]
s4 torture: Add SHARE_DELETE to create_directory_handle

Tests explicitly checking share modes should open the dir/file
with the share mode they want to test.

11 years agoFix release script to work with recent git versions
Simo Sorce [Tue, 15 Dec 2009 14:17:25 +0000 (09:17 -0500)]
Fix release script to work with recent git versions

11 years agos4:tls: fix the build on Solaris
Brian Lu [Tue, 15 Dec 2009 11:56:23 +0000 (12:56 +0100)]
s4:tls: fix the build on Solaris

Signed-off-by: Stefan Metzmacher <metze@samba.org>
11 years agoFixed a problem with duplicate values of allowedAttributesEffective.
Nadezhda Ivanova [Tue, 15 Dec 2009 10:02:20 +0000 (12:02 +0200)]
Fixed a problem with duplicate values of allowedAttributesEffective.