Björn Jacke [Mon, 12 Oct 2009 20:37:34 +0000 (22:37 +0200)]
ѕ3: fix domain trust documentation confusion
fix some trusted/trusting mixups, make documentation more precise
and man page more verbose.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 17:21:55 +0000 (19:21 +0200)]
s4:provision.py - simplify the "realm" variable handling a bit
(Remove unneeded "upper"s)
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 15:32:24 +0000 (17:32 +0200)]
s4:objectclass ldb module - Check for empty messages
I think the check for empty messages fits best here.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 14:28:34 +0000 (16:28 +0200)]
s4:wbclient.h - add compatibility constants
This is the result of a discussion on samba-technical on how to deal best with
existing programs which don't support my changes in the interface yet. Metze
pointed out this "defines" as a possibility and simo and I agreed.
Matthias Dieter Wallnöfer [Mon, 12 Oct 2009 14:19:04 +0000 (16:19 +0200)]
Revert "s4:ldb - add a check which has to be done on beginning of a "modify" operation"
This reverts commit
f9990e9b391f330a8e6c5c158ee4e4eaa50f6176.
abartlet claims that this behaviour is too AD specific to put here. Btw I had
also some doubts if this is clean enough. I put it only here to make "ldap.py"
pass.
I'll try to find a new solution soon.
Günther Deschner [Mon, 12 Oct 2009 12:28:53 +0000 (14:28 +0200)]
s3-docs: remove xml artefact from net.8.xml.
Guenther
Andrew Bartlett [Mon, 12 Oct 2009 09:11:03 +0000 (20:11 +1100)]
s4:ldb Allow a NULL module list
Karolin Seeger [Mon, 12 Oct 2009 10:52:29 +0000 (12:52 +0200)]
s3/proto.h: Add lp_ldap_ref_follow prototype.
Fix build of smbldap.
Karolin
Jan Engelhardt [Mon, 12 Oct 2009 09:34:58 +0000 (11:34 +0200)]
s3/smbldap: add option to disable following LDAP refs
Fix bug #6717.
Andrew Bartlett [Fri, 9 Oct 2009 22:35:39 +0000 (09:35 +1100)]
Allow (and ignore) distinguishedName on special records
They are not stored, so we can ignore them (makes copying records much
easier)
Andrew Bartlett
Andrew Bartlett [Mon, 12 Oct 2009 02:17:09 +0000 (13:17 +1100)]
s4:schema Add some error checking to the schema load
Andrew Bartlett [Mon, 12 Oct 2009 02:10:00 +0000 (13:10 +1100)]
s4:dsdb Make dsdb_read_prefixes_from_ldb static
Andrew Bartlett [Fri, 9 Oct 2009 22:14:37 +0000 (09:14 +1100)]
s4:ldb Reload the 'ltdb_cache' when @OPTIONS changes
(Otherwise setting the check base on search option is not applied
until after a reload).
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:12:54 +0000 (09:12 +1100)]
s4:ldb Allow a module string of ""
(We may have no modules set)
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:10:03 +0000 (09:10 +1100)]
s4:dsdb Search for the schema with dsdb_module_search(), in schema_fsmo
This avoids using an ldb_search(), which would run from the top of the
module stack. This will help us load the schema before the partitions
are initialised.
Andrew Bartlett
Andrew Bartlett [Fri, 9 Oct 2009 22:06:07 +0000 (09:06 +1100)]
s4:dsdb Add new functions to help modules do an ldb_search()
These take an ldb_module argument, and avoid doing the search from the
top of the stack again.
(This will help when modules are initialised before being added to the
partition set)
Andrew Bartlett
Andrew Bartlett [Mon, 12 Oct 2009 05:44:19 +0000 (16:44 +1100)]
s4:provision Remove all references to samba4LocalDomain
This was a bad idea all along, as Simo said at the time. With the
full MS schema and enforcement of it, it is an even worse idea.
This fixes the provision of the member server in 'make test'
Andrew Bartlett
Andrew Bartlett [Tue, 6 Oct 2009 03:12:04 +0000 (14:12 +1100)]
s4:provision Clarify that we set, rather than modify, objectGUID values
Andrew Tridgell [Mon, 12 Oct 2009 05:14:02 +0000 (16:14 +1100)]
s4-selftest: don't run benchmarks on the build farm hosts
Andrew Tridgell [Mon, 12 Oct 2009 05:11:53 +0000 (16:11 +1100)]
torture: fixed socket leak in BENCH-TCON test
The BENCH-TCON test was leaving the socket open. A smbclie_tdis()
closes the tree connection, but does not close the socket.
This caused the build farm to run out of file descriptors
Andrew Tridgell [Mon, 12 Oct 2009 02:31:34 +0000 (13:31 +1100)]
scripts: handle non-C files in minimal_includes.pl
Andrew Tridgell [Mon, 12 Oct 2009 02:30:52 +0000 (13:30 +1100)]
s4-drs: make DsBind a bit less verbose
Simo Sorce [Sun, 11 Oct 2009 13:42:59 +0000 (09:42 -0400)]
Fix builds with external tdb
Make sure we do not reference our internal tdb directly.
Let configure define what tdb.h file to use so that builds that use an
extrenal tdb do not include 2 different versions of the tdb header.
Matt Kraai [Thu, 17 Sep 2009 14:07:42 +0000 (07:07 -0700)]
Use the method used by build_env.sh to discover the user name.
so try USERNAME, then LOGNAME, then whoami, then id -un to find out who we
are.
Steven Danneman [Fri, 9 Oct 2009 21:01:33 +0000 (14:01 -0700)]
s4/torture: fix build break "implicit declaration of function 'isprint'"
Volker Lendecke [Fri, 9 Oct 2009 20:58:14 +0000 (22:58 +0200)]
s3: Fix a memleak reported by dmarkey
Simo Sorce [Fri, 9 Oct 2009 17:14:08 +0000 (13:14 -0400)]
Fix builds with external talloc
Make sure we do not reference our internal talloc directly.
Let configure define what talloc.h file to use so that builds that use an
extrenal talloc do not include 2 different versions of the talloc header.
John H Terpstra [Fri, 9 Oct 2009 12:00:11 +0000 (07:00 -0500)]
Change recommended bu PC Oota.
Karolin Seeger [Fri, 9 Oct 2009 09:27:06 +0000 (11:27 +0200)]
asn1_tests: Fix typo in comment.
Karolin
Jeremy Allison [Thu, 8 Oct 2009 22:36:36 +0000 (15:36 -0700)]
Cope with old CIFSFS clients that use SMBunlink to remove
symlinks instead of trans2:posix_unlink.
Jeremy.
Jeremy Allison [Thu, 8 Oct 2009 22:36:24 +0000 (15:36 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
Björn Jacke [Thu, 8 Oct 2009 22:21:34 +0000 (00:21 +0200)]
s3: make linking of libwbclient --as-needed safe
Partly fixes #6791. Thanks to Buchan Milne!
Jeremy Allison [Thu, 8 Oct 2009 17:01:51 +0000 (10:01 -0700)]
Merge branch 'master' of ssh://jra@git.samba.org/data/git/samba
John H Terpstra [Thu, 8 Oct 2009 13:27:21 +0000 (08:27 -0500)]
Fix typos. Thank-you PC Oota.
Volker Lendecke [Thu, 8 Oct 2009 12:02:39 +0000 (14:02 +0200)]
s3: Fix shadow copy display on Windows 7
Windows 7 is a bit more picky on our NT_STATUS_BUFFER_TOO_SMALL. Announce the
right buffer size, the same amount we later check for.
Matthias Dieter Wallnöfer [Thu, 8 Oct 2009 08:57:51 +0000 (10:57 +0200)]
winbind: adapt the new reject constants also there
Please note: in the past the value "0" was misinterpreted as other error. This
isn't true. "0" means no error.
Therefore a solution for this one has to found.
Günther Deschner [Thu, 8 Oct 2009 08:35:02 +0000 (10:35 +0200)]
s3-winbindd: NDR_WBINT_CHECKMACHINEACCOUNT should not be cacheable.
Guenther
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 20:44:00 +0000 (22:44 +0200)]
s3/s4 - Adapt the IDL changes on various locations
Matthias Dieter Wallnöfer [Fri, 25 Sep 2009 20:41:14 +0000 (22:41 +0200)]
s3/s4:samr.idl - Corrects the "userPwdChangeFailureInformation" structure
This I've done according to WSPP doc MS-SAMR 2.2.7.23.
Jeremy Allison [Wed, 7 Oct 2009 23:52:29 +0000 (16:52 -0700)]
Exteded RAW-RENAME test to catch regressions in bug 6781.
Jeremy.
Jeremy Allison [Wed, 7 Oct 2009 22:43:43 +0000 (15:43 -0700)]
Oops. Don't break the build..
Jeremy.
Jeremy Allison [Wed, 7 Oct 2009 22:39:38 +0000 (15:39 -0700)]
Make the logic a lot clearer and fix the comment to match.
Jeremy
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:28:38 +0000 (09:28 +0200)]
s4:ldb - SQLite: port some constraints from the TDB backend also to the SQLITE one
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 10:38:00 +0000 (12:38 +0200)]
s4:subtree_delete - Make the initialisation of the child counter more clear
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 15:18:04 +0000 (17:18 +0200)]
s4:ldap.py - Further enhancements
- Enhance test for "distinguishedName"
- Add a test for single-valued attributes
- Add a test for multi-valued attributes
- Add a test for empty messages
- Add a test for empty attributes
Matthias Dieter Wallnöfer [Wed, 7 Oct 2009 21:49:29 +0000 (23:49 +0200)]
s4:ldb - add a check which has to be done on beginning of a "modify" operation
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 19:53:05 +0000 (21:53 +0200)]
s4:ldap server - remove unused error handlings
Those error cases should be handled by LDB itself to be available on all
connection methods and not only over LDAP.
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 07:30:53 +0000 (09:30 +0200)]
s4:ldb_tdb - Rework/Various
- Unify the error handling method with "done" mark in all longer functions
- Fix up result codes to match more the real MS AD
- Some cosmetic fixups
Jeremy Allison [Wed, 7 Oct 2009 22:14:50 +0000 (15:14 -0700)]
Correct fix for bug 6781 - Cannot rename subfolders in Explorer view with recent versions of Samba.
Without this fix, renaming a directory ./a to ./b, whilst a directory ./aa was already open
would fail.
Jeremy.
Aravind Srinivasan [Wed, 7 Oct 2009 03:16:38 +0000 (20:16 -0700)]
s4/torture: Ported SMBv1 RAW-OPEN tests to SMB2-CREATE
Four tests were ported from raw/open.c
One new tests added LEADING-SLASH, which tests that a server provides
the proper error when a relative path is given to a CREATE PDU
with a leading "/".
Aravind Srinivasan [Wed, 7 Oct 2009 03:12:09 +0000 (20:12 -0700)]
s4/torture: convert all printf to torture_comments
Aravind Srinivasan [Wed, 7 Oct 2009 03:25:15 +0000 (20:25 -0700)]
s4/torture: Ported SMBv1 RAW-STREAMS tests to SMB2-STREAMS
Kai Blin [Wed, 7 Oct 2009 13:45:17 +0000 (15:45 +0200)]
AD-Bench: A first go at an Active Directory benchmark.
Günther Deschner [Tue, 6 Oct 2009 15:46:25 +0000 (17:46 +0200)]
s3-winbindd: libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:43:53 +0000 (10:43 +0200)]
wbinfo: allow to check trusts via "wbinfo -t --domain DOMAINNAME".
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:45:24 +0000 (17:45 +0200)]
libwbclient: implement secure channel verification for specific domains in wbcCheckTrustCredentials().
Guenther
Günther Deschner [Tue, 6 Oct 2009 15:50:15 +0000 (17:50 +0200)]
s3-netlogon: pure cosmetic indent fixes in _netr_LogonControl2Ex().
Guenther
Günther Deschner [Wed, 7 Oct 2009 08:34:15 +0000 (10:34 +0200)]
s3: re-run make samba3-idl.
Guenther
Andrew Tridgell [Wed, 7 Oct 2009 05:21:28 +0000 (16:21 +1100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Andrew Tridgell [Wed, 7 Oct 2009 05:20:16 +0000 (16:20 +1100)]
s4-drs: fixed a memory error introduced yesterday
ids is retrurned via _ids, so it needs to be on the passed in mem_ctx
Steven Danneman [Sat, 3 Oct 2009 00:02:20 +0000 (17:02 -0700)]
s4/torture: Add server target of OneFS
I've added a "--target=onefs" which lists expected deviation in the
OneFS SMB server implementation compared to a Windows machine.
I've added this in a generic way using a list of module specific
parameters. This list currently only contains the absence of
SACL support but will be added to as additional server differences
are defined.
I'd liked to use this abstraction for defining the differences between
a WinXP and Win7 server as well.
Aravind Srinivasan [Tue, 6 Oct 2009 23:57:34 +0000 (16:57 -0700)]
s4/torture: Add SMB sharemode/access mask tests
Test several thousand permutations of create mask and sharemodes on file
and directory opens.
These tests use a checked-in results table derived from a WinXP server to
verify correct server behavior.
CREATEX_ACCESS
CREATEX_SHAREMODES_FILE
CREATEX_SHAREMODES_DIR
MAXIMUM_ALLOWED
Aravind Srinivasan [Tue, 6 Oct 2009 23:43:43 +0000 (16:43 -0700)]
s4/torture: change comments to torture_failures
This allows the frameworks that wrap smbtorture to detect errors
better.
Jeremy Allison [Wed, 7 Oct 2009 00:18:15 +0000 (17:18 -0700)]
Test creating and deleting a bad symlink using the POSIX calls. Ensure
we don't regress on bug 6769.
Jeremy.
Andrew Tridgell [Tue, 6 Oct 2009 23:55:35 +0000 (10:55 +1100)]
torture: disable the ValidatePassword test
This test causes problems on non-sealed connections against windows
Andrew Tridgell [Tue, 6 Oct 2009 23:05:26 +0000 (10:05 +1100)]
s4-torture: removed an accidental commit of a local test hack
Sorry about that ....
Andrew Tridgell [Tue, 6 Oct 2009 19:39:03 +0000 (06:39 +1100)]
tdr: teach TDR about uint1632 enums
TDB doesn't have NDR64, but it needs to know how to map the new types
from pidl
Andrew Tridgell [Tue, 6 Oct 2009 09:49:14 +0000 (20:49 +1100)]
pidl: update PIDL tests for uint1632 enums
Andrew Tridgell [Tue, 6 Oct 2009 09:47:42 +0000 (20:47 +1100)]
idl: recompile IDL for uint1632 change
Andrew Tridgell [Tue, 6 Oct 2009 09:47:09 +0000 (20:47 +1100)]
pidl: get the alignment right for uint1632 enums (NDR64)
The default enum in NDR63 is 32 bits, not 16 bits. We need a uint1632
type to get the alignment right.
Volker Lendecke [Tue, 6 Oct 2009 19:31:02 +0000 (21:31 +0200)]
s3:winbind: Make query_user_list in winbindd_rpc a bit more readable
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:27:17 +0000 (19:27 +0200)]
s4:various LDB modules - "build_request" functions - propagate result codes back
It's very useful to know the exact result code when something fails and not
only a generic (by the module) created one.
Sure, there are some exception cases with specific results (special message
constellations, attributes, values...) which shouldn't be changed at all
(examples of them are in the "ldap.py" test). Therefore I looked very
carefully to not change them.
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:26:15 +0000 (19:26 +0200)]
s4:rootdse module - intendation fixup
Matthias Dieter Wallnöfer [Tue, 6 Oct 2009 17:24:28 +0000 (19:24 +0200)]
s4:acl module - intendation fix and comment enhancement
Abhidnya P Chirmule [Tue, 6 Oct 2009 15:14:56 +0000 (17:14 +0200)]
s3: Add access_mask to the flock VFS call
Günther Deschner [Mon, 5 Oct 2009 15:05:38 +0000 (17:05 +0200)]
s3-winbindd: make sure to reset connections when machine account password change chain was broken.
Guenther
Günther Deschner [Mon, 5 Oct 2009 15:04:52 +0000 (17:04 +0200)]
s3-netlogon: setup NETLOGON credential chain in rpccli_netlogon_set_trust_password() only when needed.
Guenther
Ronnie Sahlberg [Sun, 4 Oct 2009 05:57:57 +0000 (16:57 +1100)]
add trailer alignment to structures
ronnie sahlberg [Tue, 6 Oct 2009 06:49:59 +0000 (17:49 +1100)]
PIDL fix for using external types with wireshark backend
List,
Please review this patch to pidl.
Basically, we need to process the wireshark conformance file BEFORE
we process the idl file since this file may define external types
and set the alignment for them (using the TYPE directive).
Otherwise pidl will default all external types to use 4byte alignment
which breaks (much more often) on NDR64
regards
ronnie sahlberg
From
8f86903fc353d0906bd82e72ce19c5af09beb001 Mon Sep 17 00:00:00 2001
From: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Date: Mon, 5 Oct 2009 15:22:43 +1100
Subject: [PATCH] In the PIDL wireshark backend, we define external types in the conformance
file using the TYPE directive.
If we declare external types here, we must parse this file before we process
the IDL file, or else these external types will all default to 4byte padding
(pidl assumes all unknown types are 4byte aligned).
Make sure we read the conformance file and create these new types before
we parse the idl file.
Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Andrew Tridgell [Tue, 6 Oct 2009 08:05:15 +0000 (19:05 +1100)]
s4-provision: match win2003 functional level
We are now defaulting to win2003 functional level, and see to report
the right revisions of our db and schema
Andrew Tridgell [Tue, 6 Oct 2009 07:59:47 +0000 (18:59 +1100)]
s4-drs: added some debug lines to DsAddEntry()
Andrew Tridgell [Tue, 6 Oct 2009 07:59:30 +0000 (18:59 +1100)]
s4-drs: take advantage of system session auth in dsbind
Now that the bind opens samdb with the right credentials, we no longer
need the re-open in updaterefs and getncchanges
Andrew Tridgell [Tue, 6 Oct 2009 07:58:41 +0000 (18:58 +1100)]
s4-drs: fixed error message for drs_security_level_check
Andrew Tridgell [Tue, 6 Oct 2009 07:58:13 +0000 (18:58 +1100)]
s4-drs: open samdb with system credentials when authorised
When a DC connects to DRS, open the samdb with system session
credentials, so that we don't have to re-open it each time on other
calls.
Andrew Tridgell [Tue, 6 Oct 2009 07:57:06 +0000 (18:57 +1100)]
s4-ldb: fixed error on single value error
When you try to add a 2nd value to a single valued attribute you get
LDB_ERR_ATTRIBUTE_OR_VALUE_EXISTS. w2k8-r2 join to s4 relies on this
error, doing a replace after it sees the error
Andrew Tridgell [Tue, 6 Oct 2009 07:55:14 +0000 (18:55 +1100)]
s4-repl: added RELAX control and fix transactions
Added the RELAX control to dsdb_origin_objects_commit(), as it needs
to modify system objects. This patch also fixes the use of ldb
transactions in that function, and fixes a memory leak.
Andrew Bartlett [Mon, 5 Oct 2009 23:59:36 +0000 (10:59 +1100)]
s4:drs-development Scripts to assist testing of DRS replication with AD
These scripts, originally by tridge, allow developers to easily
reproduce the same domain join senerio time after time.
They need documentation, and the template named.conf and zone files
for hosting an AD domain are not provided. However, I hope to have
the provision script provide these shortly.
They assume a local 'bind' set up to read PREFIX/private/named.conf
(as per the provision instructions).
Ensure you edit the 'vars' file to match your local setup.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Oct 2009 02:01:33 +0000 (12:01 +1000)]
s4:param Remove duplicate argument to python provision
Andrew Bartlett [Fri, 2 Oct 2009 02:01:00 +0000 (12:01 +1000)]
s4:provision Remove unused parameters from provision scripts
Andrew Tridgell [Mon, 5 Oct 2009 22:18:53 +0000 (09:18 +1100)]
s4-seftest: skip hold.oplock for SMB2 as well
This test is not designed to be run automatically. It deliberately
blocks forever.
Volker Lendecke [Mon, 5 Oct 2009 20:14:06 +0000 (22:14 +0200)]
Revert "s3: Attempt to fix machine password change"
This reverts commit
20a8ea91e10af167067cc794a251265aaf489e75.
Ooops, this should not have been committed.
Volker Lendecke [Mon, 5 Oct 2009 20:09:01 +0000 (22:09 +0200)]
s3:winbind: Slightly simplify the logic of nss_init(), make it static
Volker Lendecke [Mon, 5 Oct 2009 20:00:16 +0000 (22:00 +0200)]
s3:winbind: Fix typos
Volker Lendecke [Sun, 4 Oct 2009 13:47:33 +0000 (15:47 +0200)]
s3: Attempt to fix machine password change
Jeremy Allison [Mon, 5 Oct 2009 17:27:48 +0000 (10:27 -0700)]
Fix bug 6776 - Running overlapping Byte Lock test will core dump Samba daemon.
Re-write core of POSIX locking logic.
Jeremy.
Günther Deschner [Mon, 5 Oct 2009 13:10:35 +0000 (15:10 +0200)]
libndr: add int3264 ndr prototype.
Guenther
Günther Deschner [Mon, 5 Oct 2009 11:01:53 +0000 (13:01 +0200)]
s3-net: print error when "net rpc changetrustpw" has failed.
Guenther
Volker Lendecke [Sun, 4 Oct 2009 13:19:19 +0000 (15:19 +0200)]
s3: Remove a scary error message -- talloc_move can not fail :-)
Signed-off-by: Günther Deschner <gd@samba.org>
Volker Lendecke [Sun, 4 Oct 2009 13:13:44 +0000 (15:13 +0200)]
s3: Fix nonempty blank lines
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Thu, 1 Oct 2009 23:25:13 +0000 (01:25 +0200)]
lib/tdr: get rid of build warning when using TDR_ALLOC macro.
Guenther