Jeremy Allison [Thu, 6 Nov 2008 08:50:56 +0000 (00:50 -0800)]
Fix crash in module, get more of the NULL acl test right.
Jeremy.
Jeremy Allison [Thu, 6 Nov 2008 03:11:40 +0000 (19:11 -0800)]
Add reference to bug #4308 to remind me to add regression test to smbtorture.
Jeremy.
Günther Deschner [Wed, 5 Nov 2008 14:10:52 +0000 (15:10 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Wed, 5 Nov 2008 01:03:16 +0000 (02:03 +0100)]
s3-samr-idl: fix samr_QueryUserInfo2.
Guenther
Günther Deschner [Wed, 5 Nov 2008 01:02:50 +0000 (02:02 +0100)]
s3-samr-idl: fix samr_ValidatePassword.
Guenther
Volker Lendecke [Wed, 5 Nov 2008 09:48:43 +0000 (10:48 +0100)]
Fix the build
Volker Lendecke [Tue, 4 Nov 2008 20:51:17 +0000 (21:51 +0100)]
Fix a const warning
Volker Lendecke [Tue, 4 Nov 2008 17:05:17 +0000 (18:05 +0100)]
Convert blocking.c to store a smb_request instead of just inbuf
Volker Lendecke [Tue, 4 Nov 2008 15:57:31 +0000 (16:57 +0100)]
Simplify logic of cancel_pending_lock_requests_by_fid()
The only caller of this function is locking_close_file(). This checks itself if
brl_lock != NULL. The additional check is not necessary here.
Volker Lendecke [Tue, 4 Nov 2008 13:35:44 +0000 (14:35 +0100)]
Slightly simplify logic in process_lockingX()
The "else" is pointless here, we did a "return True" in the if branch.
Volker Lendecke [Tue, 4 Nov 2008 13:33:20 +0000 (14:33 +0100)]
Slightly simplify logic in remove_pending_lock_requests_by_mid()
Use "continue" for (SVAL(blr->inbuf,smb_mid) != mid)
Volker Lendecke [Tue, 4 Nov 2008 13:29:33 +0000 (14:29 +0100)]
Slightly simplify logic in cancel_pending_lock_requests_by_fid()
Use a "continue" for (blr->fsp->fnum != fsp->fnum)
Volker Lendecke [Tue, 4 Nov 2008 12:25:07 +0000 (13:25 +0100)]
Convert blocking.c to use talloc
Volker Lendecke [Mon, 3 Nov 2008 20:56:02 +0000 (21:56 +0100)]
Rewrite aio.c to keep the whole smb_request structure, not just the inbuf
Volker Lendecke [Mon, 3 Nov 2008 20:55:05 +0000 (21:55 +0100)]
Make "inbuf" a talloc child of "smb_request" for normal smb requests
This is necessary if we want to keep the whole smb_request for deferred ops.
The explicit settings of req->inbuf will be removed once all those deferring
operations are converted to store the whole request and not just the inbuf.
Volker Lendecke [Mon, 3 Nov 2008 19:16:09 +0000 (20:16 +0100)]
Add construct_reply_common_req wrapper
The goal is to remove the remaining direct calls to construct_reply_common.
Volker Lendecke [Mon, 3 Nov 2008 19:07:11 +0000 (20:07 +0100)]
Fix nonempty blank lines
Volker Lendecke [Mon, 3 Nov 2008 18:59:11 +0000 (19:59 +0100)]
Use talloc for struct aio_extra
Joe Smith [Tue, 4 Nov 2008 19:31:04 +0000 (20:31 +0100)]
Fixed typo in source/utils/net_rap.c
Günther Deschner [Tue, 4 Nov 2008 13:34:23 +0000 (14:34 +0100)]
s3-libnet_samsync: print new line in display output.
Guenther
Günther Deschner [Tue, 4 Nov 2008 18:37:55 +0000 (19:37 +0100)]
s4-smbtorture: fix some obvious copy-paste errors.
Guenther
Volker Lendecke [Tue, 4 Nov 2008 09:51:08 +0000 (10:51 +0100)]
Ignore 3.0 style invalid group mappings during upgrade to ldb
Jeremy Allison [Tue, 4 Nov 2008 09:34:08 +0000 (01:34 -0800)]
Pass all of RAW-ACLS except for inheritence. Working on that next.
Jeremy.
Volker Lendecke [Mon, 3 Nov 2008 14:25:02 +0000 (15:25 +0100)]
Trigger (and fix) a bug in Samba3 making smbd an infinite data source
A deferred open directly followed by a ulogoffX makes smbd3 send an infinite
stream of ERRinvuid replies :-(
Jeremy Allison [Tue, 4 Nov 2008 07:54:05 +0000 (23:54 -0800)]
Be more verbose about a directory ACL error.
Jeremy.
Jeremy Allison [Tue, 4 Nov 2008 07:18:43 +0000 (23:18 -0800)]
Pass the directory versions of the RAW-ACL (still not inheritance). Refactor some common code between open_file_ntcreate() and open_directory().
Jeremy.
Jeremy Allison [Tue, 4 Nov 2008 06:42:53 +0000 (22:42 -0800)]
Pass all the non-inherited S4 RAW-ACL tests.
Jeremy.
Andrew Bartlett [Tue, 4 Nov 2008 04:48:10 +0000 (15:48 +1100)]
Use ldb_dn_from_ldb_val() to create a DN in the SAMR server
The previous code incorrectly cast an ldb_val into a char *.
Andrew Bartlett
Andrew Bartlett [Tue, 28 Oct 2008 10:07:52 +0000 (21:07 +1100)]
Re-add support for supporting the PAC over domain trusts.
(This was not entered in lorikeet-heimdal.diff, so missed by metze's import).
Andrew Bartlett
Andrew Bartlett [Mon, 27 Oct 2008 08:48:19 +0000 (19:48 +1100)]
Give a better error when ldb_dn_from_ldb_val fails
Andrew Bartlett [Mon, 27 Oct 2008 02:32:23 +0000 (13:32 +1100)]
Use ldb_dn_from_ldb_val to avoid possible over-run of the value.
The ldb_val is length-limited, and while normally NULL terminated,
this avoids the chance that this particular value might not be, as
well as avoiding a cast.
Andrew Bartlett
Andrew Bartlett [Mon, 27 Oct 2008 02:11:28 +0000 (13:11 +1100)]
Fix use of wrong union arm in linked_attributes module
This bug occours frequenetly in ldb users because the union so happens
to be layed out that this works. However, it is still incorrect
usage...
Andrew Bartlett
Günther Deschner [Tue, 4 Nov 2008 01:46:41 +0000 (02:46 +0100)]
s3-build: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 30 Oct 2008 08:29:17 +0000 (09:29 +0100)]
netlogon: fix IDL for netr_DatabaseRedo.
Guenther
Tim Prouty [Mon, 3 Nov 2008 20:36:34 +0000 (12:36 -0800)]
s3: fix a few "shadows a global declaration" warnings
Stefan Metzmacher [Mon, 3 Nov 2008 16:31:32 +0000 (17:31 +0100)]
s3: proto.h: add missing sys_[g|s]et_quota_vfs() prototypes
metze
Stefan Metzmacher [Mon, 3 Nov 2008 13:29:49 +0000 (14:29 +0100)]
s4:torture: PROVISION isn't used by all tests
We should not pollute all torture object files with
EXT_LIB_PYTHON_CFLAGS
metze
Stefan Metzmacher [Mon, 3 Nov 2008 13:27:54 +0000 (14:27 +0100)]
s4:torture: fix names of defines
metze
Volker Lendecke [Mon, 3 Nov 2008 16:56:55 +0000 (17:56 +0100)]
Fix nonempty blank lines
Volker Lendecke [Mon, 3 Nov 2008 16:49:38 +0000 (17:49 +0100)]
Make a comment match its function definition
Jelmer Vernooij [Sun, 2 Nov 2008 23:15:27 +0000 (00:15 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sun, 2 Nov 2008 23:14:26 +0000 (00:14 +0100)]
Fix memory leak.
Jelmer Vernooij [Sun, 2 Nov 2008 22:58:49 +0000 (23:58 +0100)]
Fix the build.
Volker Lendecke [Sun, 2 Nov 2008 21:33:20 +0000 (22:33 +0100)]
Remove some inbuf references by adding "cmd" to smb_request
Volker Lendecke [Sun, 2 Nov 2008 21:20:48 +0000 (22:20 +0100)]
Remove the inbuf reference from map_checkpath_error()
Volker Lendecke [Sun, 2 Nov 2008 21:09:51 +0000 (22:09 +0100)]
Remove a direct inbuf reference in reply_negprot
Michael Adam [Thu, 30 Oct 2008 15:38:07 +0000 (16:38 +0100)]
[s3]winbindd: speed up fill_grent_mem (i.e. winbindd_getgrent) a lot.
With large groups, getgrent ran into timeouts because after each
single user that was added to the expanded group list, the list
was sorted and made unique.
Now the list is sorted just once after all members have been added.
Michael
Volker Lendecke [Sun, 2 Nov 2008 20:52:16 +0000 (21:52 +0100)]
Make a [un]become_root wrap a bit tighter
Sooner or later this would bite us.
Volker Lendecke [Sun, 2 Nov 2008 20:24:28 +0000 (21:24 +0100)]
Pass smb_request to send_trans_reply to match with send_[nt]trans[2]_reply
Jelmer Vernooij [Sun, 2 Nov 2008 18:33:34 +0000 (19:33 +0100)]
Remove global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 18:32:50 +0000 (19:32 +0100)]
Remove last instance of global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 18:28:17 +0000 (19:28 +0100)]
Remove use of global_loadparm for disabled gensec backends.
Jelmer Vernooij [Sun, 2 Nov 2008 17:28:06 +0000 (18:28 +0100)]
Remove global_loadparm stub in Samba 3 as it's no longer used.
Jelmer Vernooij [Sun, 2 Nov 2008 17:27:24 +0000 (18:27 +0100)]
Remove another use of global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 17:14:53 +0000 (18:14 +0100)]
Use standard heimdal function for finding interfaces - libreplace provides support for the underlying functions now.
Jelmer Vernooij [Sun, 2 Nov 2008 17:13:19 +0000 (18:13 +0100)]
Remove unused include of param/param.h.
Volker Lendecke [Sun, 2 Nov 2008 16:38:41 +0000 (17:38 +0100)]
Use "vwv" in trans parsing
Jelmer Vernooij [Sun, 2 Nov 2008 16:39:41 +0000 (17:39 +0100)]
Samba3: Remove more configure tests already done by libreplace.
Jelmer Vernooij [Sun, 2 Nov 2008 16:29:39 +0000 (17:29 +0100)]
Remove MIN, MAX, slprintf, vslprintf defines already provided by libreplace.
Jelmer Vernooij [Sun, 2 Nov 2008 16:21:46 +0000 (17:21 +0100)]
Use environment variable rather than loadparm parameter when testing
nonblocking sockets.
Jelmer Vernooij [Sun, 2 Nov 2008 16:11:20 +0000 (17:11 +0100)]
Remove use of global_loadparm when comparing nt status error - use
global variable instead.
Jelmer Vernooij [Sun, 2 Nov 2008 16:04:22 +0000 (17:04 +0100)]
Remove use of global_loadparm during initialization of gensec.
Volker Lendecke [Sun, 2 Nov 2008 11:20:47 +0000 (12:20 +0100)]
Remove a bunch of direct inbuf references by adding "vwv" to smb_request
Jelmer Vernooij [Sun, 2 Nov 2008 15:50:11 +0000 (16:50 +0100)]
Remove use of global loadparm in python modules.
Jelmer Vernooij [Sun, 2 Nov 2008 15:48:48 +0000 (16:48 +0100)]
Add utility function for getting the default loadparm context from a python module.
Jelmer Vernooij [Sun, 2 Nov 2008 15:46:32 +0000 (16:46 +0100)]
Move check of SMB_CONF_PATH to loadparm code.
Jelmer Vernooij [Sun, 2 Nov 2008 15:38:27 +0000 (16:38 +0100)]
Add *test4 rules to merged build Makefile, to allow running the Samba 4 tests against Samba 4. (doesn't work yet).
Jelmer Vernooij [Sun, 2 Nov 2008 15:20:00 +0000 (16:20 +0100)]
Remove use of global_loadparm for SMB2 client connections.
Jelmer Vernooij [Sun, 2 Nov 2008 15:07:28 +0000 (16:07 +0100)]
Remove another use of global_loadparm.
Eventually, we should move some of these parameters into a separate
struct (perhaps into smb_transport_options?), to avoid the long lists of
parameters.
Volker Lendecke [Sun, 2 Nov 2008 09:28:00 +0000 (10:28 +0100)]
Fix bug 5860: safe_strcpy gives a nasty error message for overlong strings
Thanks to Robert Dahlem <Robert.Dahlem@gmx.net> for reporting this!
Volker Lendecke [Sun, 2 Nov 2008 08:40:30 +0000 (09:40 +0100)]
Remove an unused variable
Volker Lendecke [Sun, 2 Nov 2008 00:27:41 +0000 (01:27 +0100)]
Rename "inbuf" to "base_ptr" in srvstr_get_path_*
Volker Lendecke [Sun, 2 Nov 2008 00:21:53 +0000 (01:21 +0100)]
Remove some direct inbuf references by adding smbreq_bufrem
Volker Lendecke [Sun, 2 Nov 2008 00:07:46 +0000 (01:07 +0100)]
Simplify params of srvstr_pull_buf_talloc()
Now that "req" is available everywhere, use it. Rename srvstr_pull_buf_talloc()
to srvstr_pull_req()
Volker Lendecke [Sat, 1 Nov 2008 23:59:03 +0000 (00:59 +0100)]
Add srvstr_get_path_req[_wcard]
Jelmer Vernooij [Sun, 2 Nov 2008 04:50:08 +0000 (05:50 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Jelmer Vernooij [Sun, 2 Nov 2008 04:49:36 +0000 (05:49 +0100)]
Fix the build.
Jelmer Vernooij [Sun, 2 Nov 2008 03:50:32 +0000 (04:50 +0100)]
Rename class to "cls" since the first is a keyword name in C++. Thanks,
Brad.
Jelmer Vernooij [Sun, 2 Nov 2008 01:50:22 +0000 (02:50 +0100)]
Fix build for make everything.
Jelmer Vernooij [Sun, 2 Nov 2008 01:30:21 +0000 (02:30 +0100)]
Fix the build.
Jelmer Vernooij [Sun, 2 Nov 2008 01:05:48 +0000 (02:05 +0100)]
Add gensec_settings structure. This wraps loadparm_context for now, but
should in the future only contain some settings required for gensec.
Jelmer Vernooij [Sun, 2 Nov 2008 00:15:42 +0000 (01:15 +0100)]
Use a separate global for nonblocking socket testing rather than global_loadparm.
Jelmer Vernooij [Sun, 2 Nov 2008 00:03:46 +0000 (01:03 +0100)]
Remove two debug parameters, not used anywhere.
Andrew, I was pretty sure these could be removed but if not, please let
me know.
Jelmer Vernooij [Sun, 2 Nov 2008 00:03:26 +0000 (01:03 +0100)]
Remove another use of global_loadparm.
Jelmer Vernooij [Sat, 1 Nov 2008 23:35:04 +0000 (00:35 +0100)]
Use global iconv convenience rather than global loadparm.
Jelmer Vernooij [Sat, 1 Nov 2008 23:26:04 +0000 (00:26 +0100)]
Remove another use of global_loadparm.
Jelmer Vernooij [Sat, 1 Nov 2008 22:26:36 +0000 (23:26 +0100)]
Remove another use of global_loadparm.
Volker Lendecke [Sat, 1 Nov 2008 22:30:07 +0000 (23:30 +0100)]
The non-talloc versions of srvstr_pull are not longer needed
Volker Lendecke [Sat, 1 Nov 2008 19:02:07 +0000 (20:02 +0100)]
Kill some fstrings
Jelmer Vernooij [Sat, 1 Nov 2008 22:09:18 +0000 (23:09 +0100)]
Remove another use of global_loadparm.
Jelmer Vernooij [Sat, 1 Nov 2008 21:42:09 +0000 (22:42 +0100)]
Move calls to lp_* higher up in the call stack.
Jelmer Vernooij [Sat, 1 Nov 2008 21:13:47 +0000 (22:13 +0100)]
Move lp_*() calls a bit higher up the calls tack.
Jelmer Vernooij [Sat, 1 Nov 2008 19:58:41 +0000 (20:58 +0100)]
Remove unused argument iconv_convenience.
Jelmer Vernooij [Sat, 1 Nov 2008 19:56:27 +0000 (20:56 +0100)]
Remove convert_string_talloc_descriptor, add iconv_talloc().
Jelmer Vernooij [Sat, 1 Nov 2008 19:46:04 +0000 (20:46 +0100)]
Remove IS_DOT and IS_DOTDOT macros, already provided by libreplace or
the system.
Jelmer Vernooij [Sat, 1 Nov 2008 19:44:12 +0000 (20:44 +0100)]
Move ABS() to libutil.
Volker Lendecke [Sat, 1 Nov 2008 16:35:48 +0000 (17:35 +0100)]
Remove a bunch of direct inbuf references by adding "buf" to smb_request
Volker Lendecke [Sat, 1 Nov 2008 16:30:37 +0000 (17:30 +0100)]
In reply_copy, don't write to inbuf when splitting directory and mask
Volker Lendecke [Sat, 1 Nov 2008 16:28:25 +0000 (17:28 +0100)]
In reply_search(), don't write to inbuf when splitting directory and mask
Volker Lendecke [Sat, 1 Nov 2008 16:22:15 +0000 (17:22 +0100)]
Apply some const to get_lock_*()