ira/wip.git
11 years agospoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.
Günther Deschner [Wed, 2 Dec 2009 20:26:10 +0000 (21:26 +0100)]
spoolss: hand-marshall the spoolss_StringArray2 struct for spoolss_EnumPrinterKey.

This call is just driving me nuts :-)

Guenther

11 years agos4-drs: fixed UDV and overlapping sync calls in DRS
Andrew Tridgell [Wed, 2 Dec 2009 22:19:55 +0000 (09:19 +1100)]
s4-drs: fixed UDV and overlapping sync calls in DRS

When windows abandons a DRS sync, it will sometimes re-use the same bind handle for
a new sync. This means we need to check the DN of the sync and blank the getnc_state
if the DN has changed.

This also fixes the UDV to use the highest uSN for the partition, not for
the whole SAM.

11 years agos4-drs: fixed updating of uSNChanged in replmd_modify
Andrew Tridgell [Wed, 2 Dec 2009 06:14:40 +0000 (17:14 +1100)]
s4-drs: fixed updating of uSNChanged in replmd_modify

Updating of uSNChanged broke in a recent change

11 years agos3:build: remove redundant qnx block size definition
Björn Jacke [Wed, 2 Dec 2009 23:12:53 +0000 (00:12 +0100)]
s3:build: remove redundant qnx block size definition

11 years agoRestructure the ACL code some more, get the internal semantics
Jeremy Allison [Wed, 2 Dec 2009 23:02:28 +0000 (15:02 -0800)]
Restructure the ACL code some more, get the internal semantics
right. The previous bugs were due to the fact that get_nt_acl_internal()
could return an NTSTATUS error if there was no stored ACL blob, but
otherwise would return the underlying ACL from the filysystem. Fix
this so it always returns a valid acl if it can, and if it does not
its an error to be reported back to the client. This then changes
the inherit acl code. Previously we were trying to match Windows
by setting a minimal ACL on a new file that didn't inherit anything
from a parent directory. This is silly - the returned ACL wouldn't
match the underlying UNIX permissions. The current code will correctly
inherit from a parent if a parent has any inheritable ACE entries
that apply to the new object, but will return a mapping from the
underlying UNIX permissions if the parent has no inheritable entries.
This makes much more sense for new files/directories.
Jeremy.

11 years agos3:build: fix shared library build on QNX
Björn Jacke [Wed, 2 Dec 2009 23:02:44 +0000 (00:02 +0100)]
s3:build: fix shared library build on QNX

Fixes #6860. Thanks to Matt Kraai!

11 years agoEnsure check_parent_acl_common() only looks at stored
Jeremy Allison [Wed, 2 Dec 2009 20:29:16 +0000 (12:29 -0800)]
Ensure check_parent_acl_common() only looks at stored
blobs - returns NT_STATUS_OK if there aren't any.
Jeremy.

11 years agos3: prefer posix_fallocate for doing "strict allocate"
Björn Jacke [Wed, 2 Dec 2009 14:13:37 +0000 (15:13 +0100)]
s3: prefer posix_fallocate for doing "strict allocate"

posix_fallocate is more efficient than manual zero'ing the file. When
preallocation in kernel space is supported it's extremely fast. Support for
preallocation at fs layer via posix_fallocate and fallocate at kernel site
can be found in Linux kernel 2.6.23/glibc 2.10 with ext4, XFS and OCFS2. Other
systems that I know of which support fast preallocation in kernel space are
AIX 6.1 with JFS2 and recent Solaris versions with ZFS maybe UFS2, too.

People who have a system with preallocation in kernel space might want to set
"strict allocate = yes". This reduces file fragentation and it's also safer for
setups with quota being turned on.

As of today most systems still don't have preallocation in kernel space, and
that's why "strict allocate = no" will stay the default for now.

11 years agoEnsure get_nt_acl_internal() only looks at the ACL blobs, not
Jeremy Allison [Wed, 2 Dec 2009 20:09:48 +0000 (12:09 -0800)]
Ensure get_nt_acl_internal() only looks at the ACL blobs, not
reads off the underlying filesystem. Ensure that vfs_acl_tdb.c
returns NT_STATUS_NOT_FOUND, not NT_STATUS_OBJECT_NAME_NOT_FOUND
when it can't find a blob matching the file.
Jeremy.

11 years agoFix bug #6837 - "Too many open files" when trying to access large number of files
Jeremy Allison [Wed, 2 Dec 2009 18:01:14 +0000 (10:01 -0800)]
Fix bug #6837 - "Too many open files" when trying to access large number of files
from Windows 7. Original patch by me fixed up with the correct open files number
by jmaggard10@hotmail.com.
Jeremy.

11 years agosamba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.
Günther Deschner [Wed, 2 Dec 2009 13:25:31 +0000 (14:25 +0100)]
samba-spoolss: use spoolss_StringArray2 in spoolss_EnumPrinterKey.

This should finally resolve the endian issues we were seeing on sparc and is
much cleaner for spoolss clients and servers.

Guenther

11 years agospoolss: add spoolss_StringArray2.
Günther Deschner [Wed, 2 Dec 2009 13:22:52 +0000 (14:22 +0100)]
spoolss: add spoolss_StringArray2.

The difference to spoolss_StringArray is that in spoolss_StringArray2 the string
array is put into a subcontext of _ndr_size.

Guenther

11 years agos3-spoolss: move MAXDEVICENAME to spoolss idl.
Günther Deschner [Tue, 1 Dec 2009 01:38:19 +0000 (02:38 +0100)]
s3-spoolss: move MAXDEVICENAME to spoolss idl.

Guenther

11 years agos3: Cope with older external libtdb
Volker Lendecke [Mon, 30 Nov 2009 23:01:36 +0000 (00:01 +0100)]
s3: Cope with older external libtdb

11 years agoRevert "s3-build: taise tdb version when building against system libtdb library."
Günther Deschner [Tue, 1 Dec 2009 23:22:18 +0000 (00:22 +0100)]
Revert "s3-build: taise tdb version when building against system libtdb library."

This reverts commit ea20678c55fee9f4586630cdb5fe7f35457d309a.

Just one new error code does probably not justify raising the required tdb version.

Guenther

11 years agoEnsure we don't see the xattr used to store NT security (visible when xattr_tdb
Jeremy Allison [Tue, 1 Dec 2009 22:08:16 +0000 (14:08 -0800)]
Ensure we don't see the xattr used to store NT security (visible when xattr_tdb
is used). Allows make test to pass with acl_xattr.so prepended to the vfs modules.
Jeremy.

11 years agos3: Fix smbd to correctly return INVALID_LEVEL on set_file_end_of_file_info for paths
Tim Prouty [Tue, 1 Dec 2009 18:47:08 +0000 (10:47 -0800)]
s3: Fix smbd to correctly return INVALID_LEVEL on set_file_end_of_file_info for paths

This allows smbd to pass the freshly updated RAW-SFILEINFO-END-OF-FILE
torture test.

11 years agos4 torture: Change oplock to use passthrough for exclusive3/batch11
Tim Prouty [Tue, 1 Dec 2009 00:43:00 +0000 (16:43 -0800)]
s4 torture: Change oplock to use passthrough for exclusive3/batch11

In light of the INVALID_LEVEL that is seen for RAW_SFILEINFO_END_OF_FILE_INFO
requests on a path, I'm changing these back to using the passthrough
RAW_SFILEINFO_END_OF_FILE_INFORMATION to test the oplock break behavior as
originally intended

11 years agos4 torture: Update RAW-SFILEINFO-END-OF-FILE to test some additional corner cases
Tim Prouty [Mon, 30 Nov 2009 19:59:19 +0000 (11:59 -0800)]
s4 torture: Update RAW-SFILEINFO-END-OF-FILE to test some additional corner cases

It turns out setting the end-of-file with Trans2SetPathInfo using the
snia spec's info level will attempt to open the file, enforcing share
modes, but then subsequentlys fail the setpathinfo with a dos error of
INVALID_LEVEL.  Doing a Trans2SetFileInfo with either end-of-file info
level succeeds as expected.

11 years agoRevert "s4 torture: Allow onefs to be checked like samba3 and samba4"
Tim Prouty [Wed, 25 Nov 2009 22:26:18 +0000 (14:26 -0800)]
Revert "s4 torture: Allow onefs to be checked like samba3 and samba4"

This reverts commit 98f595036e196dd61340fef0faf63ca762a25307.

No longer necessary

11 years agos4 torture: Change RAW-SFILEINFO-END-OF-FILE to check for share modes by default
Tim Prouty [Wed, 25 Nov 2009 22:40:54 +0000 (14:40 -0800)]
s4 torture: Change RAW-SFILEINFO-END-OF-FILE to check for share modes by default

Since the windows behavior appears to be a bug, only check for
the windows-style share mode bug if target=<windows variant> is
specified

11 years agos4 torture: Move target macros to a common header instead of redefining them in multi...
Tim Prouty [Wed, 25 Nov 2009 22:38:55 +0000 (14:38 -0800)]
s4 torture: Move target macros to a common header instead of redefining them in multiple files

11 years agos3:build: fix detection of CTDB headers on systems without system-libtalloc
Michael Adam [Tue, 1 Dec 2009 14:22:20 +0000 (15:22 +0100)]
s3:build: fix detection of CTDB headers on systems without system-libtalloc

Michael

11 years agos3:build: fix the build when no external talloc and tdb are installed.
Michael Adam [Tue, 1 Dec 2009 13:55:02 +0000 (14:55 +0100)]
s3:build: fix the build when no external talloc and tdb are installed.

The check for the external libs and the addition of the include paths
to the CPPFLAGS was too late in configure.

This patch moves the whole subsystem/library section up right below
the detection of "BLDSHARED".
And it updates not only SAMBA_CPPFLAGS but also SAMBA_CONFIGURE_CPPFLAGS
so that many tests that use these flags can now succeed.

Michael

11 years agos4:torture/raw/lock - Fix "discard const" warnings by introducing "discard_const_p"s
Matthias Dieter Wallnöfer [Fri, 20 Nov 2009 10:35:13 +0000 (11:35 +0100)]
s4:torture/raw/lock - Fix "discard const" warnings by introducing "discard_const_p"s

11 years agos4:torture/nbt/wins - Add more casts
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:36:00 +0000 (22:36 +0200)]
s4:torture/nbt/wins - Add more casts

11 years agos4:torture/nbench/nbench - Add a cast before "str_list_make_shell"
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:35:21 +0000 (22:35 +0200)]
s4:torture/nbench/nbench - Add a cast before "str_list_make_shell"

11 years agos4:torture/ldap/ldap_sort - Add some casts to suppress warnings
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:34:00 +0000 (22:34 +0200)]
s4:torture/ldap/ldap_sort - Add some casts to suppress warnings

11 years agos4:schema - Make some more (result) variables const and fix up warnings with "discard...
Matthias Dieter Wallnöfer [Sat, 17 Oct 2009 20:25:12 +0000 (22:25 +0200)]
s4:schema - Make some more (result) variables const and fix up warnings with "discard_const_p"

11 years agoutil/util_strlist - add a call "const_str_list" for making "unconst" lists "const"
Matthias Dieter Wallnöfer [Wed, 25 Nov 2009 08:15:39 +0000 (09:15 +0100)]
util/util_strlist - add a call "const_str_list" for making "unconst" lists "const"

11 years agos4:kdc - Merged kdc_tcp_accept() and kpasswdd_tcp_accept().
Endi S. Dewata [Tue, 24 Nov 2009 07:00:45 +0000 (01:00 -0600)]
s4:kdc - Merged kdc_tcp_accept() and kpasswdd_tcp_accept().

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4:kdc - Merged kdc_add_kdc_socket() and kdc_add_kpasswd_socket().
Endi S. Dewata [Tue, 24 Nov 2009 04:28:11 +0000 (22:28 -0600)]
s4:kdc - Merged kdc_add_kdc_socket() and kdc_add_kpasswd_socket().

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4 - Create default modules directory.
Endi S. Dewata [Fri, 20 Nov 2009 20:57:11 +0000 (14:57 -0600)]
s4 - Create default modules directory.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4:kdc - Disable KDC port when it's set to 0.
Endi S. Dewata [Fri, 20 Nov 2009 14:47:40 +0000 (08:47 -0600)]
s4:kdc - Disable KDC port when it's set to 0.

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agoMerge commit 'origin/master' into abartlet-devel
Andrew Bartlett [Tue, 1 Dec 2009 05:12:53 +0000 (16:12 +1100)]
Merge commit 'origin/master' into abartlet-devel

11 years agoOn our way to Samba4 alpha10!
Andrew Bartlett [Tue, 1 Dec 2009 05:06:59 +0000 (16:06 +1100)]
On our way to Samba4 alpha10!

11 years agoFix build of Samba4 from tarball generated by mkrelease.sh samba-4.0.0alpha9
Andrew Bartlett [Tue, 1 Dec 2009 03:43:55 +0000 (14:43 +1100)]
Fix build of Samba4 from tarball generated by mkrelease.sh

Revert "Remove RFC's from the release tarballs to make the lives of the Debian"

This reverts commit eda7f35bc891ca4a7505ec054a2b4591c6edfb38.

These files are essential to the Samba4 build.

Andrew Bartlett

11 years agoImprove upgrade instructions
Andrew Bartlett [Tue, 1 Dec 2009 02:03:17 +0000 (13:03 +1100)]
Improve upgrade instructions

11 years agos4-ldb: the '1' form of extended_dn search is easier to read
Andrew Tridgell [Mon, 30 Nov 2009 11:49:39 +0000 (22:49 +1100)]
s4-ldb: the '1' form of extended_dn search is easier to read

The '1' form gives GUIDs and SIDs in the ascii form as normally used
for display.

11 years agoThis is alpha9
Andrew Bartlett [Tue, 1 Dec 2009 01:27:09 +0000 (12:27 +1100)]
This is alpha9

11 years agos4:setup Adjust upgradeprovision blackbox test now we don't have --targetdir
Andrew Bartlett [Mon, 30 Nov 2009 22:04:21 +0000 (09:04 +1100)]
s4:setup Adjust upgradeprovision blackbox test now we don't have --targetdir

11 years agos4: Remove targetdir as it can cause some trouble and can be replaced by an adapted...
Matthieu Patou [Sun, 29 Nov 2009 16:44:08 +0000 (19:44 +0300)]
s4: Remove targetdir as it can cause some trouble and can be replaced by an adapted -s smb.conf

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4: Handle the case in secrets.ldb without name attribute
Matthieu Patou [Sun, 29 Nov 2009 13:26:31 +0000 (16:26 +0300)]
s4: Handle the case in secrets.ldb without name attribute

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4: don't forget to update defaultSecurityDescriptor
Matthieu Patou [Sat, 28 Nov 2009 23:28:26 +0000 (02:28 +0300)]
s4: don't forget to update defaultSecurityDescriptor

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4: load the domain level of the current provision and create a provision with the...
Matthieu Patou [Fri, 27 Nov 2009 17:50:04 +0000 (20:50 +0300)]
s4: load the domain level of the current provision and create a provision with the same domain level

Signed-off-by: Andrew Bartlett <abartlet@samba.org>
11 years agos4:ldap.py Add test of namingContext behaviour after tridge found a bug
Andrew Bartlett [Mon, 30 Nov 2009 07:39:58 +0000 (18:39 +1100)]
s4:ldap.py Add test of namingContext behaviour after tridge found a bug

Tridge found that the partitions.c module was being initialised twice,
and setting the partitions into the rootDSE twice.

Andrew Bartlett

11 years agos4:WHATSNEW Nadezhda's acl module handles modifies
Andrew Bartlett [Mon, 30 Nov 2009 03:46:03 +0000 (14:46 +1100)]
s4:WHATSNEW Nadezhda's acl module handles modifies

11 years agoFix DEBUG 0 -> DEBUG 10 (left over code).
Jeremy Allison [Tue, 1 Dec 2009 00:56:35 +0000 (16:56 -0800)]
Fix DEBUG 0 -> DEBUG 10 (left over code).
Fix opendir status return if access denied.
Jeremy.

11 years agoFix bug 6938 : No hook exists to check creation rights when using acl_xattr module
Jeremy Allison [Tue, 1 Dec 2009 00:50:34 +0000 (16:50 -0800)]
Fix bug 6938 : No hook exists to check creation rights when using acl_xattr module
Fix ACL modules to test for permissions on open/mkdir/opendir.
Ensure that underlying ACLs are returned for directories/files with
no Windows xattr or tdb acls stored.
Jeremy.

11 years agos3-build: taise tdb version when building against system libtdb library.
Günther Deschner [Tue, 1 Dec 2009 00:22:44 +0000 (01:22 +0100)]
s3-build: taise tdb version when building against system libtdb library.

Try to fix the build on "buildsamba02". At least fixes the build on fedora12
with libtdb-devel-1.1.5-2.fc12.x86_64 installed.

Volker, please check.

Guenther

11 years agos3:add split_tokens, a cmdline tool to test next_token_talloc()
Michael Adam [Mon, 30 Nov 2009 23:53:03 +0000 (00:53 +0100)]
s3:add split_tokens, a cmdline tool to test next_token_talloc()

Michael

11 years agos3:fix linking of the t_str* test programs
Michael Adam [Fri, 20 Nov 2009 17:25:27 +0000 (18:25 +0100)]
s3:fix linking of the t_str* test programs

Michael

11 years agos3:fix linking of libbigballofmud (on my box at least)
Michael Adam [Fri, 20 Nov 2009 17:24:53 +0000 (18:24 +0100)]
s3:fix linking of libbigballofmud (on my box at least)

Michael

11 years agos3:torture: make t_stringoverflow.c compile at least (pstring is long gone)
Michael Adam [Fri, 20 Nov 2009 16:48:18 +0000 (17:48 +0100)]
s3:torture: make t_stringoverflow.c compile at least (pstring is long gone)

I don't know whether these t_* programs are used at all any more, but this
one was using pstrcpy...

Michael

11 years agoRestructure the connect function code to always call
Jeremy Allison [Mon, 30 Nov 2009 23:53:04 +0000 (15:53 -0800)]
Restructure the connect function code to always call
down to NEXT-> before initializing. This allows us to
do cleanup (by calling DISCONNECT) if initialization
fails. Also fix vfs_acl_xattr which was failing to
call the NEXT connect function.
Jeremy.

11 years agodrsuapi: fix build warning of NDR size calculation of drsuapi_DsReplicaObjectIdentifi...
Günther Deschner [Mon, 30 Nov 2009 23:24:16 +0000 (00:24 +0100)]
drsuapi: fix build warning of NDR size calculation of drsuapi_DsReplicaObjectIdentifier3Binary.

The generated size actually does not include the size of the binary itself.

Guenther

11 years agos3-spoolss: fix fstrings in convert_devicemode() function.
Günther Deschner [Mon, 30 Nov 2009 17:10:59 +0000 (18:10 +0100)]
s3-spoolss: fix fstrings in convert_devicemode() function.

Guenther

11 years agoFix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgets
Volker Lendecke [Mon, 30 Nov 2009 20:48:33 +0000 (21:48 +0100)]
Fix bug 6546: Avoid accessing buf[-1] if NUL byte comes from fgets

11 years agos3:docs: Fix typo in man mount.cifs.
Karolin Seeger [Mon, 30 Nov 2009 13:53:23 +0000 (14:53 +0100)]
s3:docs: Fix typo in man mount.cifs.

Fix bug #6844 (wrong credential file format in mount.cifs manpage).
Thanks to the Debian Samba package maintainers for reporting!

Karolin

11 years agos3:docs: Document "aio write behind".
Karolin Seeger [Mon, 30 Nov 2009 12:34:34 +0000 (13:34 +0100)]
s3:docs: Document "aio write behind".

Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).

Karolin

11 years agos3:docs: Document "ldap page size".
Karolin Seeger [Mon, 30 Nov 2009 11:29:27 +0000 (12:29 +0100)]
s3:docs: Document "ldap page size".

Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).

Karolin

11 years agos3: Fix crash in free_file_list().
Bo Yang [Mon, 30 Nov 2009 09:30:25 +0000 (17:30 +0800)]
s3: Fix crash in free_file_list().

Signed-off-by: Bo Yang <boyang@samba.org>
11 years agos3:docs: Document "enable core files".
Karolin Seeger [Mon, 30 Nov 2009 10:40:06 +0000 (11:40 +0100)]
s3:docs: Document "enable core files".

Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).

Karolin

11 years agos4-drs: Test situations for runtime constructed parentGUID
Fernando J V da Silva [Fri, 27 Nov 2009 14:25:18 +0000 (12:25 -0200)]
s4-drs: Test situations for runtime constructed parentGUID

Includes the following verifications for the constructed parentGUID:
- Checks if it returns nothing when there is no parent object
- Ensures that attributes mentioned after the parentGUID
are returned correctly (this avoid a bug pointed out by Tridge
during sync constructed parentGUID development)

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4-drs: Using dsdb_msg_add_guid() utility function
Fernando J V da Silva [Wed, 25 Nov 2009 20:01:55 +0000 (17:01 -0300)]
s4-drs: Using dsdb_msg_add_guid() utility function

Uses the dsdb_msg_add_guid() to add any kind of GUID attribute
to a ldb_message in several places of samba4 code.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos3:docs: Document "cache directory" and "state directory".
Karolin Seeger [Mon, 30 Nov 2009 10:04:50 +0000 (11:04 +0100)]
s3:docs: Document "cache directory" and "state directory".

Part of a fix for bug #6890 (Some smb.conf parameters are undocumented).

Karolin

11 years agos3: Fix bug 6288
Volker Lendecke [Sun, 29 Nov 2009 22:31:45 +0000 (23:31 +0100)]
s3: Fix bug 6288

11 years agos4-drs: add deletion of old connections
Crístian Deives [Mon, 30 Nov 2009 09:12:24 +0000 (20:12 +1100)]
s4-drs: add deletion of old connections

the nTDSConnection objects that are not needed anymore will be deleted.
the function kccsrv_delete_connection wasn't tested yet.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4-ldb: changed ldb_msg_add_dn() to ldb_msg_add_linearized_dn()
Crístian Deives [Mon, 23 Nov 2009 17:47:51 +0000 (15:47 -0200)]
s4-ldb: changed ldb_msg_add_dn() to ldb_msg_add_linearized_dn()

this makes the usage clearer

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4-drs: Create connection obejct (nTDSConnection)
Crístian Deives [Mon, 30 Nov 2009 09:11:27 +0000 (20:11 +1100)]
s4-drs: Create connection obejct (nTDSConnection)

create nTDSConnection objects to match the list of servers

Signed-off-by: Andrew Tridgell <tridge@samba.org>
11 years agos4-ldb: check for -ve value for page size
Andrew Tridgell [Mon, 30 Nov 2009 06:47:56 +0000 (17:47 +1100)]
s4-ldb: check for -ve value for page size

This comes from a tip from Howard Chu. Apparently some clients
will send a -ve page size value.

11 years agos4-dsdb: don't call ldb_next_init() twice in objectclass module
Andrew Tridgell [Mon, 30 Nov 2009 05:48:31 +0000 (16:48 +1100)]
s4-dsdb: don't call ldb_next_init() twice in objectclass module

11 years agos3: Fix a "not handled in switch" warning
Volker Lendecke [Sun, 29 Nov 2009 22:42:44 +0000 (23:42 +0100)]
s3: Fix a "not handled in switch" warning

11 years agos3: Fix an uninitialized variable reference
Volker Lendecke [Sun, 29 Nov 2009 21:57:19 +0000 (22:57 +0100)]
s3: Fix an uninitialized variable reference

11 years agos3: Fix some nonempty blank lines
Volker Lendecke [Sun, 29 Nov 2009 21:23:22 +0000 (22:23 +0100)]
s3: Fix some nonempty blank lines

11 years agos3: Add a regression test for bug 6898
Volker Lendecke [Sun, 29 Nov 2009 15:05:36 +0000 (16:05 +0100)]
s3: Add a regression test for bug 6898

11 years agos3: Factor out torture_setup_unix_extensions
Volker Lendecke [Sun, 29 Nov 2009 15:04:21 +0000 (16:04 +0100)]
s3: Factor out torture_setup_unix_extensions

11 years agolib/registry/util.c - Reorder the registry datatypes of the conversion functions
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:55:20 +0000 (14:55 +0100)]
lib/registry/util.c - Reorder the registry datatypes of the conversion functions

This is absolutely cosmetic and makes the code easier to comprehend.

11 years agoRevert "s4:registry/util - Don't include the trailing '\0' in the internal data forma...
Matthias Dieter Wallnöfer [Sun, 29 Nov 2009 13:42:31 +0000 (14:42 +0100)]
Revert "s4:registry/util - Don't include the trailing '\0' in the internal data format but add it on the back-conversion to a string"

This reverts commit 7d400715e9af2056690c03a1a2f45c7f343fa313.

"convert_string_talloc_convenience" does always add the NULL termination. Didn't
know that. Thanks Jelmer for pointing out!

11 years agos3: Restore "fake directory create times" as a share parameter
Volker Lendecke [Fri, 27 Nov 2009 14:44:50 +0000 (15:44 +0100)]
s3: Restore "fake directory create times" as a share parameter

11 years agos3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)
Volker Lendecke [Fri, 27 Nov 2009 14:10:23 +0000 (15:10 +0100)]
s3: "copy_reg" only looks at mode, uid, gid, atime and mtime (no birthtime)

11 years agos3: Pass up fake_dir_create_times from atalk_build_paths
Volker Lendecke [Fri, 27 Nov 2009 13:58:46 +0000 (14:58 +0100)]
s3: Pass up fake_dir_create_times from atalk_build_paths

The callers only look at the mode

11 years agos3: Move directory_exist_stat to testparm.c, it only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:19:30 +0000 (13:19 +0100)]
s3: Move directory_exist_stat to testparm.c, it only looks at the mode

11 years agos3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look...
Volker Lendecke [Fri, 27 Nov 2009 12:17:05 +0000 (13:17 +0100)]
s3: Pass fake_dir_create_times down to file_exist_stat, none of the callers look at the mtime

11 years agos3: "startsmbfilepwent" only looks at the inode -- is that enough?
Volker Lendecke [Fri, 27 Nov 2009 12:12:40 +0000 (13:12 +0100)]
s3: "startsmbfilepwent" only looks at the inode -- is that enough?

11 years agos3: "get_file_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:11:17 +0000 (13:11 +0100)]
s3: "get_file_size" only looks at the size

11 years agos3: "socket_exist" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:10:48 +0000 (13:10 +0100)]
s3: "socket_exist" only looks at the mode

11 years agos3: "sys_path_to_bdev" only looks at the devicenumber
Volker Lendecke [Fri, 27 Nov 2009 12:08:51 +0000 (13:08 +0100)]
s3: "sys_path_to_bdev" only looks at the devicenumber

11 years agos3: "check_log_size" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:07:54 +0000 (13:07 +0100)]
s3: "check_log_size" only looks at the size

11 years agos3: "regf_hbin_allocate" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:07:12 +0000 (13:07 +0100)]
s3: "regf_hbin_allocate" only looks at the size

11 years agos3: "read_block" only looks at the size
Volker Lendecke [Fri, 27 Nov 2009 12:06:44 +0000 (13:06 +0100)]
s3: "read_block" only looks at the size

11 years agos3: "write_block" does not use the sbuf at all
Volker Lendecke [Fri, 27 Nov 2009 12:06:14 +0000 (13:06 +0100)]
s3: "write_block" does not use the sbuf at all

11 years agos3: "net_conf_addshare" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:05:16 +0000 (13:05 +0100)]
s3: "net_conf_addshare" only looks at the mode

11 years agos3: "net_usershare_add" only looks at the mode, device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:04:38 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the mode, device and inode

11 years agos3: "net_usershare_add" only looks at the device and inode
Volker Lendecke [Fri, 27 Nov 2009 12:04:18 +0000 (13:04 +0100)]
s3: "net_usershare_add" only looks at the device and inode

11 years agos3: "net_usershare_add" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:03:09 +0000 (13:03 +0100)]
s3: "net_usershare_add" only looks at the mode and uid

11 years agos3: "count_num_usershares" only looks at the mode
Volker Lendecke [Fri, 27 Nov 2009 12:02:26 +0000 (13:02 +0100)]
s3: "count_num_usershares" only looks at the mode

11 years agos3: "info_fn" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:01:46 +0000 (13:01 +0100)]
s3: "info_fn" only looks at the mode and uid

11 years agos3: "get_share_list" only looks at the mode and uid
Volker Lendecke [Fri, 27 Nov 2009 12:00:51 +0000 (13:00 +0100)]
s3: "get_share_list" only looks at the mode and uid

11 years agos3: "cgi_download" only looks at the mode and size
Volker Lendecke [Fri, 27 Nov 2009 12:00:10 +0000 (13:00 +0100)]
s3: "cgi_download" only looks at the mode and size