20 years agoFix debug
Andrew Bartlett [Mon, 26 Nov 2001 07:23:51 +0000 (07:23 +0000)]
Fix debug
(This used to be commit 44224ae156394dac1055c68764c84f758cea6540)

20 years agobasic ADS HOWTO
Andrew Tridgell [Mon, 26 Nov 2001 06:52:33 +0000 (06:52 +0000)]
(This used to be commit 9ee13fecb1b623e760789d1df7178b085f820700)

20 years agoA number of things to clean up the auth subsytem a bit...
Andrew Bartlett [Mon, 26 Nov 2001 06:47:04 +0000 (06:47 +0000)]
A number of things to clean up the auth subsytem a bit...

We now default encrypt passwords = yes

We now check plaintext passwords (however aquired) with the 'sam' backend
rather than unix, if encrypt passwords = yes.

(this kills off the 'local' backed.  The sam backend may be renamed in its

The new 'samstrict' wrapper backend checks that the user's domain is one of
our netbios aliases - this ensures that we don't get fallback crazies with
security = domain.

Similarly, the code in the 'ntdomain' and 'smbserver' backends now checks
that the user was not local before contacting the DC.

The default ordering has changed, we now check the local stuff first - but
becouse of the changes above, we will really only ever contact one
auth source.

Andrew Bartlett
(This used to be commit e89b47f65e7eaf5eb288a3d6ba2d3d115c628e7e)

20 years agoadd SEC_ADS auth method
Andrew Tridgell [Mon, 26 Nov 2001 06:21:24 +0000 (06:21 +0000)]
add SEC_ADS auth method
(This used to be commit b175c42080b15f27589cb6b6d61af5cbbedf5d02)

20 years agoupdated server_role for ADS
Andrew Tridgell [Mon, 26 Nov 2001 06:18:09 +0000 (06:18 +0000)]
updated server_role for ADS
(This used to be commit 48df0d2b5dee3c010c88587352554220f8b92b0f)

20 years agoprevent proto from picking up this as a defintion for 'main()' becoue it conflicts...
Andrew Bartlett [Mon, 26 Nov 2001 05:59:43 +0000 (05:59 +0000)]
prevent proto from picking up this as a defintion for 'main()' becoue it conflicts with nmbd's definition.
(This used to be commit 70e9c2efaada4be609ff053d216d554cb036df4e)

20 years agoMore compiler warnings fixed. Some minor reformatting.
Tim Potter [Mon, 26 Nov 2001 04:53:08 +0000 (04:53 +0000)]
More compiler warnings fixed.  Some minor reformatting.
(This used to be commit 8227f6909cca67fcc1a8455f4b386df7778ef2e7)

20 years agowe can safely give NO_SUCH_USER if the ticket decodes but the local
Andrew Tridgell [Mon, 26 Nov 2001 04:37:24 +0000 (04:37 +0000)]
we can safely give NO_SUCH_USER if the ticket decodes but the local
account doesn't exist
(This used to be commit 477b6d27fd7281418739bc8ba0b984a53430ecda)

20 years agoAnother merge from appliance-head: in [ug]id_to_sid don't call the
Tim Potter [Mon, 26 Nov 2001 04:27:51 +0000 (04:27 +0000)]
Another merge from appliance-head: in [ug]id_to_sid don't call the
winbind function if the id is obviously going to be local.  Cleanup
of winbind [ug]id parameter handling.
(This used to be commit 4ab9ca31a02b3388aa89a00e0390ea9e4c76283a)

20 years agochallange -> challenge
Tim Potter [Mon, 26 Nov 2001 04:05:28 +0000 (04:05 +0000)]
challange -> challenge
(This used to be commit d6318add27f6bca5be00cbedf2226b642341297a)

20 years agoMerge from appliance-head: when creating a default security descriptor
Tim Potter [Mon, 26 Nov 2001 03:39:16 +0000 (03:39 +0000)]
Merge from appliance-head: when creating a default security descriptor
for a printer, save it in ntprinters.tdb instead of recreating it
every time it is required.  This can save at least one winbind lookup
per secdesc creation.  Opening a port monitor and viewing the security
tab in the properties dialog required the security descriptor to be
returned 25 times!
(This used to be commit f85c976acc08a16bce6cb4053708485ccdea0d77)

20 years agoGot medieval on another pointless extern. Removed extern struct ipzero
Tim Potter [Mon, 26 Nov 2001 03:11:44 +0000 (03:11 +0000)]
Got medieval on another pointless extern.  Removed extern struct ipzero
and replaced with two functions:

void zero_ip(struct in_adder *ip);
BOOL is_zero_ip(struct in_addr ip);
(This used to be commit 778f5f77a66cda76348a7c6f64cd63afe2bfe077)

20 years agoFix up the build farm again.
Andrew Bartlett [Mon, 26 Nov 2001 02:10:59 +0000 (02:10 +0000)]
Fix up the build farm again.

This should get us 'green' for once...

Andrew Bartlett
(This used to be commit 042b9e3a6332473dc88c36dd7f99428644324ac4)

20 years agodyn_CONFIGFILE fixups.
Tim Potter [Mon, 26 Nov 2001 02:01:00 +0000 (02:01 +0000)]
dyn_CONFIGFILE fixups.
(This used to be commit 7d10fa208248e201946876168743025866e011fc)

20 years agoFixed compiler warnings and dyn_CONFIGFILE related breakage.
Tim Potter [Mon, 26 Nov 2001 01:59:33 +0000 (01:59 +0000)]
Fixed compiler warnings and dyn_CONFIGFILE related breakage.
(This used to be commit bf491d2aa2e99156b4e80bc9d89ab34cfb3c4cf4)

20 years agoAnd delete domain_client_validate.c...
Andrew Bartlett [Mon, 26 Nov 2001 01:37:44 +0000 (01:37 +0000)]
And delete domain_client_validate.c...

Andrew Bartlett
(This used to be commit 6caca4301ba88d026ce1989cefd3e9eeb65df376)

20 years agoThis compleats the of the authenticaion subystem into the new 'auth'
Andrew Bartlett [Mon, 26 Nov 2001 01:37:01 +0000 (01:37 +0000)]
This compleats the of the authenticaion subystem into the new 'auth'

(The insertion of these files was done with some CVS backend magic, hence the
lack of a commit message).

This also moves libsmb/domain_client_validate.c back into auth_domain.c,
becouse we no longer share it with winbind.

Andrew Bartlett
(This used to be commit 782835470cb68da2188a57007d6f55c17b094d08)

20 years agoRemoved bogus SAFE_FREE() call of talloced return data from
Tim Potter [Mon, 26 Nov 2001 01:20:57 +0000 (01:20 +0000)]
Removed bogus SAFE_FREE() call of talloced return data from
(This used to be commit dd2048c418da7a08bc71305491953731fc427f5a)

20 years agoIgnore *.po files.
Tim Potter [Mon, 26 Nov 2001 01:17:03 +0000 (01:17 +0000)]
Ignore *.po files.
(This used to be commit 091f01f34ab0ff7d394811af0d027ea3bad56d0e)

20 years agoFixed some indentation.
Tim Potter [Mon, 26 Nov 2001 00:58:43 +0000 (00:58 +0000)]
Fixed some indentation.
(This used to be commit 1dd462844a9b90b498ee79ca33e4048980e2af5f)

20 years agouse DEBUG() not d_printf() in libraries
Andrew Tridgell [Mon, 26 Nov 2001 00:45:51 +0000 (00:45 +0000)]
use DEBUG() not d_printf() in libraries
(This used to be commit 5100ae4ae032545edaf525de1dfbe5dc9dafecfc)

20 years agofixed spnego, non-kerberos negprot
Andrew Tridgell [Mon, 26 Nov 2001 00:43:37 +0000 (00:43 +0000)]
fixed spnego, non-kerberos negprot
(This used to be commit 2e916222a915c27f919a9841bde5ba0967af2190)

20 years agoAllow lookup of users with spaces in their name.
Tim Potter [Mon, 26 Nov 2001 00:19:23 +0000 (00:19 +0000)]
Allow lookup of users with spaces in their name.
(This used to be commit 751ea8cfb931e1de6df447ed05e051262cdeb304)

20 years agoFixed compiler warning.
Tim Potter [Sun, 25 Nov 2001 23:33:15 +0000 (23:33 +0000)]
Fixed compiler warning.

Why do people keep adding stuff to includes.h (OK I am guilty of this too)?
It's getting really huge and full of random junk.  )-:

I've noticed TNG have started to split stuff up in to individual header
files included as needed.
(This used to be commit 36630f3984cb2bc4e60d910889e0396891cbc088)

20 years agoadded 'security=ADS'
Andrew Tridgell [Sun, 25 Nov 2001 23:05:13 +0000 (23:05 +0000)]
added 'security=ADS'
(This used to be commit 5a735a88e472a48cd4329832998dc31c1e230ecb)

20 years agoMinor typos
Volker Lendecke [Sun, 25 Nov 2001 18:54:04 +0000 (18:54 +0000)]
Minor typos
(This used to be commit 1c9d951f86609b08e5660b0fc966c5e5058a3ce2)

20 years agoDon't close tdb twice.
Volker Lendecke [Sun, 25 Nov 2001 18:49:20 +0000 (18:49 +0000)]
Don't close tdb twice.
(This used to be commit 6dda341bc80dc7c4d044df134fc153f646a6a4e9)

20 years agoportability fixes
Andrew Tridgell [Sun, 25 Nov 2001 13:36:02 +0000 (13:36 +0000)]
portability fixes
(This used to be commit 09127d85dc91037c9d0280b57d48d23e93a39f8b)

20 years agofixed typo
Andrew Tridgell [Sun, 25 Nov 2001 13:32:28 +0000 (13:32 +0000)]
fixed typo
(This used to be commit b14ae495028da4d2b995cefa786746d2c649460c)

20 years agoadd popt build dependency
Andrew Tridgell [Sun, 25 Nov 2001 12:56:04 +0000 (12:56 +0000)]
add popt build dependency
(This used to be commit 0c1f90402bf6aa403719cef59afd127ae42b0865)

20 years agomove popt out of proto objs
Andrew Tridgell [Sun, 25 Nov 2001 12:46:14 +0000 (12:46 +0000)]
move popt out of proto objs
(This used to be commit db0bee1c68d8d9af3febb841c86cd3d4ade87c7b)

20 years agoadded HAVE_LDAP_H check
Andrew Tridgell [Sun, 25 Nov 2001 12:40:23 +0000 (12:40 +0000)]
added HAVE_LDAP_H check
(This used to be commit a1304be045d9cfd7bb793bb55ff49e158440a90e)

20 years agocheck for liblber separately
Andrew Tridgell [Sun, 25 Nov 2001 12:26:40 +0000 (12:26 +0000)]
check for liblber separately
(This used to be commit d7216424d94ee89e1760596c8f87d1883f369771)

20 years ago#ifdefed DMF fix so not compiled by default. We need to look at this...
Jeremy Allison [Sun, 25 Nov 2001 08:26:37 +0000 (08:26 +0000)]
#ifdefed DMF fix so not compiled by default. We need to look at this...
(This used to be commit 97dca242a91c68048e510f42be53421b533183be)

20 years agoUse "password server" for searching for BDC's also as Tim suggested.
Jeremy Allison [Sun, 25 Nov 2001 06:38:17 +0000 (06:38 +0000)]
Use "password server" for searching for BDC's also as Tim suggested.
(This used to be commit 4aca67761fbe601e27f8f768c28a11241f088bba)

20 years agoAdd the PDC end of the smbtorture test for creating an NT_STATUS -> DOS error
Andrew Bartlett [Sun, 25 Nov 2001 03:01:14 +0000 (03:01 +0000)]
Add the PDC end of the smbtorture test for creating an NT_STATUS -> DOS error

This little authentication module is #ifdef DEVELOPER, becouse it really is of
no use execept as a development tool

invoke by setting:

auth methods = guest sam name_to_ntstatus

in the smb.conf file (the SAM and guest elements are required for the member
server to authenticate itself).

Andrew Bartlett
(This used to be commit 9807e66f34c1088399657060977e384c5a7f0664)

20 years agooops, I forgot to include the header file
Andrew Bartlett [Sun, 25 Nov 2001 02:58:15 +0000 (02:58 +0000)]
oops, I forgot to include the header file
(This used to be commit c28956d8601c103c3f8dab4253de80e6a00a02d7)

20 years agoAdd a new torture test to extract a NT->DOS error map from an NT member of a
Andrew Bartlett [Sun, 25 Nov 2001 02:35:37 +0000 (02:35 +0000)]
Add a new torture test to extract a NT->DOS error map from an NT member of a
samba domain.

The PDC must be running a special authenticaion module that spits out NT errors
based on username.

Andrew Bartlett
(This used to be commit adc7a6048c13342b79b6228beafb5142c50f318d)

20 years agoUnless the error is exactly NT_STATUS_OK, we might not have a server info, so
Andrew Bartlett [Sun, 25 Nov 2001 02:30:30 +0000 (02:30 +0000)]
Unless the error is exactly NT_STATUS_OK, we might not have a server info, so
we need to bail here.
(This used to be commit ea0331354e5968aa0a25c0b12379a56c72d7946b)

20 years agoI think this is a fix for the "out of space" errors with oplocks=no.
Jeremy Allison [Sun, 25 Nov 2001 02:23:22 +0000 (02:23 +0000)]
I think this is a fix for the "out of space" errors with oplocks=no.
(This used to be commit 84b62d3c8ebd78cd578ac36168631b3bbcafdd8c)

20 years agoFix ./configure --enable-developer warnings (shadow of global)
Andrew Bartlett [Sun, 25 Nov 2001 02:08:43 +0000 (02:08 +0000)]
Fix ./configure --enable-developer warnings (shadow of global)
(This used to be commit 3f1cfb62e85343a45817651f111f01051fc66b18)

20 years agobetter help
Andrew Tridgell [Sun, 25 Nov 2001 01:42:29 +0000 (01:42 +0000)]
better help
(This used to be commit b390d6eef95ee6094eb193006bc2f23c40291026)

20 years agouse generate_random_str()
Andrew Tridgell [Sun, 25 Nov 2001 01:36:02 +0000 (01:36 +0000)]
use generate_random_str()
(This used to be commit 720c50a7514febdd7cfd6ce40b7b5a0c5cc0abf8)

20 years agoadded "net ads user" and "net ads group" commands
Andrew Tridgell [Sun, 25 Nov 2001 01:31:07 +0000 (01:31 +0000)]
added "net ads user" and "net ads group" commands
(This used to be commit f482583139eedb75a23c7a720dca4e8fb7070fd5)

20 years agoadded "net ads status" command
Andrew Tridgell [Sun, 25 Nov 2001 01:06:56 +0000 (01:06 +0000)]
added "net ads status" command
(This used to be commit ae0eabd04c97320c2cf3c4575263c53cf61d03ea)

20 years agomade a "net ads" command, currently with "net ads join" and "net ads leave"
Andrew Tridgell [Sun, 25 Nov 2001 00:18:11 +0000 (00:18 +0000)]
made a "net ads" command, currently with "net ads join" and "net ads leave"
(This used to be commit 2f8fa175b189c2d11676245b01d3201c0a4f0826)

20 years agostop popt from doing its own intl stuff
Andrew Tridgell [Sun, 25 Nov 2001 00:10:28 +0000 (00:10 +0000)]
stop popt from doing its own intl stuff
(This used to be commit 1a5ef2425747c2e0c7cf28fc7712563039086100)

20 years agobetter auto-selection of realm and ldap server
Andrew Tridgell [Sun, 25 Nov 2001 00:08:48 +0000 (00:08 +0000)]
better auto-selection of realm and ldap server
(This used to be commit 69d256af4612f5c1277202eb8a7ef37eb6bb55f4)

20 years agoadded "net join" command
Andrew Tridgell [Sat, 24 Nov 2001 14:16:41 +0000 (14:16 +0000)]
added "net join" command

this completes the first stage of the smbd ADS support
(This used to be commit 058a5aee901e6609969ef7e1d482a720a84a4a12)

20 years agoremoved unused function
Andrew Tridgell [Sat, 24 Nov 2001 13:58:40 +0000 (13:58 +0000)]
removed unused function
(This used to be commit ad7afbfdea600a62fa1550bd354996ad38807533)

20 years agorewrote net.c
Andrew Tridgell [Sat, 24 Nov 2001 13:26:01 +0000 (13:26 +0000)]
rewrote net.c

The rewrite fixes a number of things:

- much better command line parsing
- fixed usage of static and const
- better finding of hosts
- clean internal separation of sub-functions
- expandable design
(This used to be commit 0f88d9c50e419504b9ceca5eadbe30ee04fa42dc)

20 years agoAnd add the winbind module I missed in the last run.
Andrew Bartlett [Sat, 24 Nov 2001 12:16:27 +0000 (12:16 +0000)]
And add the winbind module I missed in the last run.

(large change to modularise the auth subsystem)

Andrew Bartlett
(This used to be commit 324c4676280641fee0647221dba1e826e03ba9ab)

20 years agoThis is another rather major change to the samba authenticaion
Andrew Bartlett [Sat, 24 Nov 2001 12:12:38 +0000 (12:12 +0000)]
This is another rather major change to the samba authenticaion

The particular aim is to modularized the interface - so that we
can have arbitrary password back-ends.

This code adds one such back-end, a 'winbind' module to authenticate
against the winbind_auth_crap functionality.  While fully-functional
this code is mainly useful as a demonstration, because we don't get
back the info3 as we would for direct ntdomain authentication.

This commit introduced the new 'auth methods' parameter, in the
spirit of the 'auth order' discussed on the lists.  It is renamed
because not all the methods may be consulted, even if previous
methods fail - they may not have a suitable challenge for example.

Also, we have a 'local' authentication method, for old-style
'unix if plaintext, sam if encrypted' authentication and a
'guest' module to handle guest logins in a single place.

While this current design is not ideal, I feel that it does
provide a better infrastructure than the current design, and can
be built upon.

The following parameters have changed:
 - use rhosts =

  This has been replaced by the 'rhosts' authentication method,
 and can be specified like 'auth methods = guest rhosts'

 - hosts equiv =

  This needs both this parameter and an 'auth methods' entry
  to be effective.  (auth methods = guest hostsequiv ....)

 - plaintext to smbpasswd =

  This is replaced by specifying 'sam' rather than 'local'
  in the auth methods.

The security = parameter is unchanged, and now provides defaults
for the 'auth methods' parameter.

The available auth methods are:

sam (passdb direct hash access)
unix (PAM, crypt() etc)
local (the combination of the above, based on encryption)
smbserver (old security=server)
ntdomain (old security=domain)
winbind (use winbind to cache DC connections)

Assistance in testing, or the production of new and interesting
authentication modules is always appreciated.

Andrew Bartlett
(This used to be commit 8d31eae52a9757739711dbb82035a4dfe6b40c99)

20 years agoKill off that crazy copy_sam_passwd(). You simply can't do that if the
Andrew Bartlett [Sat, 24 Nov 2001 00:36:37 +0000 (00:36 +0000)]
Kill off that crazy copy_sam_passwd().  You simply can't do that if the
structre contains pointers (well not if you intend of free those pointers
at some stage)

There is no reason (given the new passdb interface) that you can't modify a
SAM_ACCOUNT in any case.

Andrew Bartlett
(This used to be commit e8e73f7f0fcd86c8c2bfe3fc0b44ea2fd6570cc5)

20 years agoadded lsaenumprivsaccount and lsalookupprivvalue to rpcclient
Jean-François Micouleau [Sat, 24 Nov 2001 00:13:41 +0000 (00:13 +0000)]
added lsaenumprivsaccount and lsalookupprivvalue to rpcclient

and more to come ...

(This used to be commit 1748d5a2af1f2dcf718d6f162ed483b001542494)

20 years agoSorry. I broke the build, missed on open_directory call.
Jeremy Allison [Fri, 23 Nov 2001 19:07:35 +0000 (19:07 +0000)]
Sorry. I broke the build, missed on open_directory call.
(This used to be commit fe288b14cc7f2bc6b8427438da672e7dd7812027)

20 years agoreturn NO_MORE_ENTRIES in lsa_enum_trust_dom. UserManager is happier :-)
Jean-François Micouleau [Fri, 23 Nov 2001 15:17:30 +0000 (15:17 +0000)]
return NO_MORE_ENTRIES in lsa_enum_trust_dom. UserManager is happier :-)

(This used to be commit 75ee50bbef531a1487c1f8b76b8e70627fbdbdf1)

20 years agoChanged how the privileges are stored in the group mapping code. It's now
Jean-François Micouleau [Fri, 23 Nov 2001 15:11:22 +0000 (15:11 +0000)]
Changed how the privileges are stored in the group mapping code. It's now
an array of uint32. That's not perfect but that's better.

Added more privileges too.

Changed the local_lookup_rid/name functions in passdb.c to check if the
group is mapped. Makes the LSA rpc calls return correct groups

Corrected the return code in the LSA server code enum_sids.

Only enumerate well known aliases if they are mapped to real unix groups.
Won't confuse user seeing groups not available.

Added a short/long view to smbgroupedit.

now decoding rpc calls to add/remove privileges to sid.

(This used to be commit f29774e58973f421bfa163c45bfae201a140f28c)

20 years agoFixed delete on close bug. Added core dump code to winbindd.
Jeremy Allison [Fri, 23 Nov 2001 11:18:20 +0000 (11:18 +0000)]
Fixed delete on close bug. Added core dump code to winbindd.
(This used to be commit a58d0f91f9ee7354c01a9c20cfe178d5dc02142d)

20 years agoSet type to NOTUSED if lookup fail.
Jeremy Allison [Fri, 23 Nov 2001 09:04:09 +0000 (09:04 +0000)]
Set type to NOTUSED if lookup fail.
(This used to be commit 20a4167599ce211f239d0f324e7e73a1c2d8a5a6)

20 years agoUpdate some of the error mapping, based on on-the-wire observations of an NT4 server.
Andrew Bartlett [Fri, 23 Nov 2001 07:08:20 +0000 (07:08 +0000)]
Update some of the error mapping, based on on-the-wire observations of an NT4 server.

This lets our Win9X clients give sane error messages when you get passwords wrong
and the like.

Andrew Bartlett
(This used to be commit f199e9518226ed57a011113bdf06c85265e49674)

20 years agoFinally worked out why a enumerate trusted domains was returning a
Tim Potter [Fri, 23 Nov 2001 05:50:05 +0000 (05:50 +0000)]
Finally worked out why a enumerate trusted domains was returning a
NT_STATUS_UNABLE_TO_FREE_VM error.  This error code was mis-defined
as 0x8000001a instead of 0xc000001a.  The former is actually a
NT_STATUS_NO_MORE_ENTRIES warning which is what we see in the status

Removed the & 0xffffff from the loop in get_nt_error_msg() as all the
error constants now have the correct high bits set.
(This used to be commit 80dca2c9e46753d87e673d712c96c76ffde0b276)

20 years agoAdded constants and error message for dos error code 1326 (logon failure).
Tim Potter [Fri, 23 Nov 2001 05:37:40 +0000 (05:37 +0000)]
Added constants and error message for dos error code 1326 (logon failure).
(This used to be commit 6ce1eec09de64f19d969a67fc236abd4ae277926)

20 years agoReference about SIDs from tpot.
Martin Pool [Fri, 23 Nov 2001 05:34:41 +0000 (05:34 +0000)]
Reference about SIDs from tpot.
(This used to be commit 53963eae7d5930246c6c0c0b947f425d50d382c3)

20 years agoMore better now.
Martin Pool [Fri, 23 Nov 2001 04:53:56 +0000 (04:53 +0000)]
More better now.
(This used to be commit a875b3a6e7a9501a31fe15fb9b04394a95484e77)

20 years agoGot rid of that stupid parse_domain_user() warning when compiling
Tim Potter [Fri, 23 Nov 2001 04:37:41 +0000 (04:37 +0000)]
Got rid of that stupid parse_domain_user() warning when compiling
(This used to be commit 72060a6f5af505d597f372d550d7f3fe559e5550)

20 years agoQuieten gcc const warning.
Martin Pool [Fri, 23 Nov 2001 04:24:26 +0000 (04:24 +0000)]
Quieten gcc const warning.

(This used to be commit 6ddd8e7bf69d8aee4148cbcf72de55c903d5f0a1)

20 years agoFinish 1.45 by removing redundant sid->string conversion in
Martin Pool [Fri, 23 Nov 2001 03:54:07 +0000 (03:54 +0000)]
Finish 1.45 by removing redundant sid->string conversion in
winbindd_lookup_sid_by_name.  Also if the lookup fails then clobber
the output parameters rather than leaving them looking potentially

Add doxygen.
(This used to be commit 61dba52a549039255e46393be1618d3eb54b79dd)

20 years agoI think you were passing the name of the SID, rather than the DOM_SID
Martin Pool [Fri, 23 Nov 2001 03:33:22 +0000 (03:33 +0000)]
I think you were passing the name of the SID, rather than the DOM_SID
pointer itself.  (Whatever that is.... ;-)
(This used to be commit 1393c7c4ede1d6d624c3f5d0bfa4c18b0c6dc27f)

20 years agoFixed bug in canned results list for checking the error code of wbinfo.
Tim Potter [Fri, 23 Nov 2001 03:24:36 +0000 (03:24 +0000)]
Fixed bug in canned results list for checking the error code of wbinfo.

Made test names more verbose.
(This used to be commit 87955fcf303d82d38ae543e7986c59fd086dc2db)

20 years agoDon't initialise static pointers to NULL.
Tim Potter [Fri, 23 Nov 2001 01:00:54 +0000 (01:00 +0000)]
Don't initialise static pointers to NULL.
(This used to be commit 039ea0a0b94be2d70164616f448c0e29fed071cf)

20 years agoRemoved TimeInit() call from every client program (except for one place
Tim Potter [Fri, 23 Nov 2001 00:52:29 +0000 (00:52 +0000)]
Removed TimeInit() call from every client program (except for one place
in smbd/process.c where the timezone is reinitialised.  Was replaced with
check for a static is_initialised boolean.
(This used to be commit 8fc772c9e5770cd3a8857670214dcff033ebae32)

20 years agoFixed check machine account function.
Tim Potter [Fri, 23 Nov 2001 00:14:04 +0000 (00:14 +0000)]
Fixed check machine account function.
(This used to be commit 8f01a8b07883d18f44da665cbc8e5fba04d3bc91)

20 years agoIgnore *.po files.
Tim Potter [Fri, 23 Nov 2001 00:08:12 +0000 (00:08 +0000)]
Ignore *.po files.
(This used to be commit 5d343b40650464ae70037fd6e3fd96a9865fa611)

20 years agoRename $pwd to $test_root to avoid future confusion.
Martin Pool [Thu, 22 Nov 2001 23:59:48 +0000 (23:59 +0000)]
Rename $pwd to $test_root to avoid future confusion.
(This used to be commit fa7367a9731bc139ff4611f2781f3ca9bc7f89a7)

20 years agoadded lsa_enum_sids to rpcclient
Jean-François Micouleau [Thu, 22 Nov 2001 23:50:16 +0000 (23:50 +0000)]
added lsa_enum_sids to rpcclient
fixed lsa_enum_rpivs server code. This time it works as W2K.
fixed smbgroupedit to compile and work.

(This used to be commit 646651018a2736833e49e76f6ca735a4647d9746)

20 years agoRemoved unused variable.
Tim Potter [Thu, 22 Nov 2001 23:38:37 +0000 (23:38 +0000)]
Removed unused variable.
(This used to be commit d1dee2d0323fe6fc498e50201535b1718a88abaf)

20 years agoOops - opening wrong pipe name in cli_lsa_initialise() helper function.
Tim Potter [Thu, 22 Nov 2001 22:45:52 +0000 (22:45 +0000)]
Oops - opening wrong pipe name in cli_lsa_initialise() helper function.
(This used to be commit d2034bc5f7dc9b5b9d5e4f17ee8e468307dcb2d5)

20 years agofixing enum_privs and get_dispname server code.
Jean-François Micouleau [Thu, 22 Nov 2001 17:19:59 +0000 (17:19 +0000)]
fixing enum_privs and get_dispname server code.
That works as expected now.

(This used to be commit f2766932d693fc601b2c3e7853e61f751435ec3c)

20 years agoadd another command to rpcclient: getdispname. Show the full description
Jean-François Micouleau [Thu, 22 Nov 2001 16:54:48 +0000 (16:54 +0000)]
add another command to rpcclient: getdispname. Show the full description
of a privilege.

(This used to be commit 84035ae72f422edadd9fa7e493c3d8176bb6a53d)

20 years agoadd a command to rpcclient: enumprivs
Jean-François Micouleau [Thu, 22 Nov 2001 16:12:43 +0000 (16:12 +0000)]
add a command to rpcclient: enumprivs

(This used to be commit fa63cb78e326040f68d858d593ba98e06c26c92e)

20 years agoGot positive and negative name caching working correctly with lookupname/lookupsid.
Jeremy Allison [Thu, 22 Nov 2001 08:31:50 +0000 (08:31 +0000)]
Got positive and negative name caching working correctly with lookupname/lookupsid.
There was a bug in cli_lsa_lookup_name/lookup_sid where NT_STATUS_NONE_MAPPED was
being mapped to NT_STATUS_OK, and also the *wrong* number of entries mapped
was being returned. The correct field is mapped_count, *NOT* num_entries.
(This used to be commit 9f8c644abc455510c06dbd5dbac49c6270746560)

20 years agoFixed +ve caching. Still problems with -ve caching.
Jeremy Allison [Thu, 22 Nov 2001 07:48:57 +0000 (07:48 +0000)]
Fixed +ve caching. Still problems with -ve caching.
(This used to be commit 7883a2288a6e3198e10ab4e02ed4585e7bb313f6)

20 years agoFixed caching of lookupname/lookupsid. Error in check of success !
Jeremy Allison [Thu, 22 Nov 2001 07:32:48 +0000 (07:32 +0000)]
Fixed caching of lookupname/lookupsid. Error in check of success !
(This used to be commit d039d4fa507a7284e7e1cada0026c63863fe0a2d)

20 years agoAdded debugs to track down sequence lookup problems.
Jeremy Allison [Thu, 22 Nov 2001 07:24:07 +0000 (07:24 +0000)]
Added debugs to track down sequence lookup problems.
(This used to be commit d3f5d5a4aca0d5bc8c4db7dfa8b766b7cda808eb)

20 years agoremove unused variables
Gerald Carter [Thu, 22 Nov 2001 06:44:05 +0000 (06:44 +0000)]
remove unused variables
(This used to be commit 90ed3d47e16a511161532f75b98db3f4b10ba685)

20 years agomerge oops fix from 2.2
Gerald Carter [Thu, 22 Nov 2001 06:23:49 +0000 (06:23 +0000)]
merge oops fix from 2.2
(This used to be commit 48f2da440f973047faa7ecf031be66bc30d4a985)

20 years agosync up with 2.2
Gerald Carter [Thu, 22 Nov 2001 06:12:54 +0000 (06:12 +0000)]
sync up with 2.2
(This used to be commit 0c0f3223731cfb46a0e3b8e289c13c8f908e0cf2)

20 years agomerge from 2.2
Gerald Carter [Thu, 22 Nov 2001 05:56:09 +0000 (05:56 +0000)]
merge from 2.2
(This used to be commit 96b3a65a73d403a41bf1b3aba79bd743698344ac)

20 years ago--with-msdfs wsa removed
Gerald Carter [Thu, 22 Nov 2001 05:29:33 +0000 (05:29 +0000)]
--with-msdfs wsa removed
(This used to be commit f1143cd02c24f7c56b2e4ec70f77f22dbc01b113)

20 years agoWITH_MSDFS is not define anywhere. It's built by default.
Gerald Carter [Thu, 22 Nov 2001 05:29:04 +0000 (05:29 +0000)]
WITH_MSDFS is not define anywhere.  It's built by default.
(This used to be commit b51e5b07d9f7719180b28215236efc3fa09d8bea)

20 years agoMade a libsmbclient doxygen group and moved all the libsmbclient groups
Tim Potter [Thu, 22 Nov 2001 04:29:10 +0000 (04:29 +0000)]
Made a libsmbclient doxygen group and moved all the libsmbclient groups
under it.
(This used to be commit 43c496598f8e1aedc9c80222e60bb8e7b3027e03)

20 years agosamr_querydom_info level 1: found the meaning of the unknow fields. And
Jean-François Micouleau [Wed, 21 Nov 2001 23:25:30 +0000 (23:25 +0000)]
samr_querydom_info level 1: found the meaning of the unknow fields. And
discovered that our reply is short by 4 bytes since day 1 of this code.

Added a decode function to rpcclient too.

splitted the STRING2 fields filling while trying to understand the win9x
userlist bug. (didn't fix the bug, but the reply looks closer to NT).

(This used to be commit bfbe7f377e5fcb09e87bfc866196dfc51a8fe64d)

20 years agoW2K doesn't seem to respond to *#0 names in node status. Ensure name
Jeremy Allison [Wed, 21 Nov 2001 23:00:59 +0000 (23:00 +0000)]
W2K doesn't seem to respond to *#0 names in node status. Ensure name
lookup uses password server parameter when looking for PDCs.
(This used to be commit 54c968913d6553c6d834b068234ab176917075eb)

20 years agoMore spelling fixes, comment reformatting.
Tim Potter [Wed, 21 Nov 2001 21:10:13 +0000 (21:10 +0000)]
More spelling fixes, comment reformatting.
(This used to be commit edb556b47446f75dc4987eee15276661eb6cec8d)

20 years agoSpelling fix, reformatted comment.
Tim Potter [Wed, 21 Nov 2001 20:14:25 +0000 (20:14 +0000)]
Spelling fix, reformatted comment.
(This used to be commit 096868bd35b374f97e570676fc23c006b6c7a1d3)

20 years agoOne more patch from Tom Jansen. Hope I didn't break the tree :-)
Richard Sharpe [Wed, 21 Nov 2001 11:04:49 +0000 (11:04 +0000)]
One more patch from Tom Jansen. Hope I didn't break the tree :-)
(This used to be commit 6d7c0f0bb4cbfdcd9a83416345432e07556f6cfc)

20 years agoAdded transparent +ve caching for lookupname/lookupsid. -ve caching can
Jeremy Allison [Wed, 21 Nov 2001 09:59:15 +0000 (09:59 +0000)]
Added transparent +ve caching for lookupname/lookupsid. -ve caching can
be easily added (a one liner) once we know the correct error codes returned
by a W2K DC.
All other winbindd calls should go through a similar transparent caching layer
(and will soon).
(This used to be commit b16bb21d371772816a4331f5011c151be0e083d5)

20 years agoPreparing to implement +ve and -ve caching for lookupname/lookupsid calls.
Jeremy Allison [Wed, 21 Nov 2001 08:36:43 +0000 (08:36 +0000)]
Preparing to implement +ve and -ve caching for lookupname/lookupsid calls.
(This used to be commit 1f6cc536b2db0c36feee45cfd6ac1ad5ee8fb05a)

20 years agoFix up the build again...
Andrew Bartlett [Wed, 21 Nov 2001 05:19:13 +0000 (05:19 +0000)]
Fix up the build again...

Andrew Bartlett
(This used to be commit a34c07377b1de61e145f699047474a82962ccd5b)