ira/wip.git
14 years agopycredentials: Fix memory leak.
Jelmer Vernooij [Wed, 17 Jun 2009 17:00:31 +0000 (19:00 +0200)]
pycredentials: Fix memory leak.

14 years agopyldb: Fix two memory leaks of attribute lists.
Jelmer Vernooij [Wed, 17 Jun 2009 16:36:16 +0000 (18:36 +0200)]
pyldb: Fix two memory leaks of attribute lists.

14 years agopyldb: Fix segfault, freeing memory too early in search.
Jelmer Vernooij [Wed, 17 Jun 2009 16:26:40 +0000 (18:26 +0200)]
pyldb: Fix segfault, freeing memory too early in search.

14 years agopyldb: Support getting the parent of special DNs without segfaulting.
Jelmer Vernooij [Wed, 17 Jun 2009 16:25:21 +0000 (18:25 +0200)]
pyldb: Support getting the parent of special DNs without segfaulting.

Found by: Андрей Григорьев <andrew@ei-grad.ru>

14 years agofix release scripts to always git clean
Simo Sorce [Wed, 17 Jun 2009 18:14:31 +0000 (14:14 -0400)]
fix release scripts to always git clean

This makes sure we do not include foreign object files or other
build byproducts by mistake.

14 years agos3-net: Fix Bug #6328: support "net sam rights grant/revoke" with multiple rights.
David Markey [Wed, 17 Jun 2009 16:29:20 +0000 (18:29 +0200)]
s3-net: Fix Bug #6328: support "net sam rights grant/revoke" with multiple rights.

David

Signed-off-by: Günther Deschner <gd@samba.org>
14 years agos3/packaging: pam_winbind has been moved to section 8.
Karolin Seeger [Wed, 17 Jun 2009 13:19:20 +0000 (15:19 +0200)]
s3/packaging: pam_winbind has been moved to section 8.

Karolin

14 years agos3/packaging: source -> source3
Karolin Seeger [Wed, 17 Jun 2009 13:18:16 +0000 (15:18 +0200)]
s3/packaging: source -> source3

Karolin

14 years agos3/i18n: Add Russian to the list.
Karolin Seeger [Wed, 17 Jun 2009 12:37:28 +0000 (14:37 +0200)]
s3/i18n: Add Russian to the list.

Karolin

14 years agos3/i18n: Add Russian translation for SWAT messages.
Karolin Seeger [Wed, 17 Jun 2009 12:31:29 +0000 (14:31 +0200)]
s3/i18n: Add Russian translation for SWAT messages.

Thanks to Yuri Kozlov <kozlov.y [at] gmail.com>!

This is part of a fix for bug #4755.

14 years agos3-net: Fix Bug #6328: allow multiple rights in "net sam rights grant".
Günther Deschner [Wed, 17 Jun 2009 10:31:49 +0000 (12:31 +0200)]
s3-net: Fix Bug #6328: allow multiple rights in "net sam rights grant".

Guenther

14 years agos3/i18n: Update German SWAT translations.
Karolin Seeger [Wed, 17 Jun 2009 10:15:59 +0000 (12:15 +0200)]
s3/i18n: Update German SWAT translations.

This is part of a fix for bug #4755.
Patch was provided (mainly) by Helge Kreutzmann <debian [at] helgefjell.de>.
Thanks!

Karolin

14 years agos3/libsmb: Fix typo in error message.
Karolin Seeger [Wed, 17 Jun 2009 08:23:21 +0000 (10:23 +0200)]
s3/libsmb: Fix typo in error message.

Thanks to Herb Lewis <hlewis [at] panasas.com> for noticing!

Karolin

14 years agoRemove msdfs pathname processing from default create file.
Jeremy Allison [Wed, 17 Jun 2009 00:42:41 +0000 (17:42 -0700)]
Remove msdfs pathname processing from default create file.
No longer needed.
Jeremy

14 years agoFix msdfs after the change to smb_filename struct. We must *always*
Jeremy Allison [Wed, 17 Jun 2009 00:23:54 +0000 (17:23 -0700)]
Fix msdfs after the change to smb_filename struct. We must *always*
pull the pathname, then call resolve_dfspath(), before unix_convert().
Jeremy.

14 years agos4-smbtorture: add test for NetUserSetInfo level 0 (user rename).
Günther Deschner [Tue, 16 Jun 2009 23:30:22 +0000 (01:30 +0200)]
s4-smbtorture: add test for NetUserSetInfo level 0 (user rename).

Guenther

14 years agos4-smbtorture: use torture_comment in RPC-SAMR-USERS-PRIVILEGES test.
Günther Deschner [Tue, 16 Jun 2009 23:20:03 +0000 (01:20 +0200)]
s4-smbtorture: use torture_comment in RPC-SAMR-USERS-PRIVILEGES test.

Guenther

14 years agos4-smbtorture: use TORTURE_TEST_USER define in libnetapi user test.
Günther Deschner [Tue, 16 Jun 2009 23:06:14 +0000 (01:06 +0200)]
s4-smbtorture: use TORTURE_TEST_USER define in libnetapi user test.

Guenther

14 years ago_lsa_EnumAccountRights and _lsa_EnumPrivsAccount can return an
Jeremy Allison [Tue, 16 Jun 2009 20:17:24 +0000 (13:17 -0700)]
_lsa_EnumAccountRights and _lsa_EnumPrivsAccount can return an
empty set of privilages if the SID doesn't have any.
(From [MS-LSAD.pdf])
Jeremy.

14 years agos3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.
Günther Deschner [Tue, 16 Jun 2009 13:00:20 +0000 (15:00 +0200)]
s3-netapi: Fix Bug #6451: net/libnetapi user rename using wrong access bits.

Guenther

14 years agos3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.
Günther Deschner [Wed, 13 May 2009 21:57:26 +0000 (23:57 +0200)]
s3-netapi: Fix Bug #6305. Correctly prompt for a password when a username was given.

When no callback or wrapping has managed to get a password, prompt in the
netapi connection manager for a password.

Guenther

14 years agos3-docs: fix typo in pam_winbind.8.
Günther Deschner [Tue, 16 Jun 2009 09:49:36 +0000 (11:49 +0200)]
s3-docs: fix typo in pam_winbind.8.

Guenther

14 years agos3-netapi: add NetGetJoinInformation example code.
Günther Deschner [Mon, 15 Jun 2009 15:25:08 +0000 (17:25 +0200)]
s3-netapi: add NetGetJoinInformation example code.

Guenther

14 years agopython: Provide way to iterate over available shares.
Jelmer Vernooij [Tue, 16 Jun 2009 00:24:43 +0000 (02:24 +0200)]
python: Provide way to iterate over available shares.

14 years agopython: Add API for accessing available shares.
Jelmer Vernooij [Tue, 16 Jun 2009 00:05:18 +0000 (02:05 +0200)]
python: Add API for accessing available shares.

14 years agos3 onefs: Fix reading over the end of the array, because the incorrect array was...
Tim Prouty [Mon, 15 Jun 2009 20:16:07 +0000 (20:16 +0000)]
s3 onefs: Fix reading over the end of the array, because the incorrect array was being read.

14 years agos3 onefs: Change onefs modules to use the new createfile api
Tim Prouty [Mon, 15 Jun 2009 19:13:31 +0000 (12:13 -0700)]
s3 onefs: Change onefs modules to use the new createfile api

14 years agoAdd exports file and abi checker for tevent
Simo Sorce [Sun, 7 Jun 2009 18:10:15 +0000 (14:10 -0400)]
Add exports file and abi checker for tevent

This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on tevent.h contents and the gcc -aux-info option

14 years agoAdd exports file and abi checker for talloc talloc-1.3.1
Simo Sorce [Sun, 7 Jun 2009 18:20:36 +0000 (14:20 -0400)]
Add exports file and abi checker for talloc

This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on talloc.h contents and the gcc -aux-info option

14 years agoAdd exports file and abi checker for tdb tdb-1.1.5
Simo Sorce [Mon, 15 Jun 2009 20:19:19 +0000 (16:19 -0400)]
Add exports file and abi checker for tdb

This is a first attempt at exporting symbols only for public functions
We also provide a rudimentary ABI checker that tries to check that
function signatures are not changed by mistake.
Given our use of macros this is not an API checker.
It's all based on tdb.h contents and the gcc -aux-info option

14 years agoAdd new replace check for --version-script
Simo Sorce [Mon, 15 Jun 2009 20:20:06 +0000 (16:20 -0400)]
Add new replace check for --version-script

Allows us to pass an export files on Linux and Solaris so that we can expose
only symbols that are actually supposed to be global, and keep as local anything
else.

14 years agoAdd option to --disable-python on build
Simo Sorce [Mon, 15 Jun 2009 19:08:25 +0000 (15:08 -0400)]
Add option to --disable-python on build

14 years agoFix the posixtimedlock test
Volker Lendecke [Mon, 15 Jun 2009 13:43:19 +0000 (15:43 +0200)]
Fix the posixtimedlock test

The previous version depended on the fact that smb_raw_lock_send just queued
stuff. This changed with ebf5523b6e2ae0.

14 years agoFix the section of the pam_winbind manpage.
Andreas Schneider [Mon, 15 Jun 2009 10:22:58 +0000 (12:22 +0200)]
Fix the section of the pam_winbind manpage.

Signed-off-by: Andreas Schneider <mail@cynapses.org>
14 years agoMove pam_winbind to the right manpage section (8).
Andreas Schneider [Mon, 15 Jun 2009 10:21:07 +0000 (12:21 +0200)]
Move pam_winbind to the right manpage section (8).

Signed-off-by: Andreas Schneider <mail@cynapses.org>
14 years agoDcoument the PAM data exports in the pam_winbind manpage.
Andreas Schneider [Mon, 15 Jun 2009 10:16:49 +0000 (12:16 +0200)]
Dcoument the PAM data exports in the pam_winbind manpage.

Signed-off-by: Andreas Schneider <mail@cynapses.org>
14 years agoDocument the try_first_pass option in the pam_winbind manpage.
Andreas Schneider [Mon, 15 Jun 2009 10:16:15 +0000 (12:16 +0200)]
Document the try_first_pass option in the pam_winbind manpage.

Signed-off-by: Andreas Schneider <mail@cynapses.org>
14 years agoAdd a synopsis section to the pam_winbind manpage.
Andreas Schneider [Mon, 15 Jun 2009 10:15:26 +0000 (12:15 +0200)]
Add a synopsis section to the pam_winbind manpage.

Signed-off-by: Andreas Schneider <mail@cynapses.org>
14 years agos3/libsmb: Fix debug message.
Karolin Seeger [Mon, 15 Jun 2009 06:33:22 +0000 (08:33 +0200)]
s3/libsmb: Fix debug message.

This fixes bug #6472.

Karolin

Signed-off-by: Volker Lendecke <vl@samba.org>
14 years agoDo a correct TALLOC_FREE in an error case
Volker Lendecke [Mon, 15 Jun 2009 05:45:47 +0000 (07:45 +0200)]
Do a correct TALLOC_FREE in an error case

14 years agoFix a = vs == error in writev_handler
Volker Lendecke [Mon, 15 Jun 2009 05:45:11 +0000 (07:45 +0200)]
Fix a = vs == error in writev_handler

14 years agoRemove "winbindd_request" and "winbindd_response" from winbindd_cli_state
Volker Lendecke [Sun, 14 Jun 2009 10:58:19 +0000 (12:58 +0200)]
Remove "winbindd_request" and "winbindd_response" from winbindd_cli_state

This shrinks the memory footprint of an idle client by 5592 bytes to 60 bytes
on my 32-bit box.

14 years agoMake winbindd_cli_state->response a pointer instead of a struct member
Volker Lendecke [Sun, 14 Jun 2009 10:41:46 +0000 (12:41 +0200)]
Make winbindd_cli_state->response a pointer instead of a struct member

Same comment as in baa6084378e530b: This is just a preparatory checkin.

Volker

14 years agoRemove an unused struct member in winbindd_cli_state
Volker Lendecke [Sun, 14 Jun 2009 20:21:02 +0000 (22:21 +0200)]
Remove an unused struct member in winbindd_cli_state

14 years agoFix an error message: We get the errno in "err"
Volker Lendecke [Sun, 14 Jun 2009 18:54:57 +0000 (20:54 +0200)]
Fix an error message: We get the errno in "err"

14 years agowinbind: replace process_loop() by tevent_loop_once()
Volker Lendecke [Mon, 25 May 2009 20:40:09 +0000 (22:40 +0200)]
winbind: replace process_loop() by tevent_loop_once()

14 years agoMake rescan_trusted_domains a timed event
Volker Lendecke [Mon, 25 May 2009 20:34:48 +0000 (22:34 +0200)]
Make rescan_trusted_domains a timed event

14 years agoDo not store the listening fde
Volker Lendecke [Mon, 25 May 2009 18:31:59 +0000 (20:31 +0200)]
Do not store the listening fde

14 years agoAvoid scanning the client list when a client exits
Volker Lendecke [Mon, 25 May 2009 18:28:38 +0000 (20:28 +0200)]
Avoid scanning the client list when a client exits

14 years agoDo not use "finished" in winbind child
Volker Lendecke [Mon, 25 May 2009 18:17:23 +0000 (20:17 +0200)]
Do not use "finished" in winbind child

14 years agoRemove unused init_child_connection()
Volker Lendecke [Sat, 16 May 2009 12:21:39 +0000 (14:21 +0200)]
Remove unused init_child_connection()

14 years agoConvert winbindd_domain_info to wb_domain_request_send
Volker Lendecke [Sat, 16 May 2009 12:20:30 +0000 (14:20 +0200)]
Convert winbindd_domain_info to wb_domain_request_send

14 years agoAdd winbindd_dual_ping to all children
Volker Lendecke [Sat, 16 May 2009 11:43:03 +0000 (13:43 +0200)]
Add winbindd_dual_ping to all children

14 years agoConvert async_domain_request to wb_domain_request_send
Volker Lendecke [Sat, 16 May 2009 11:25:52 +0000 (13:25 +0200)]
Convert async_domain_request to wb_domain_request_send

14 years agoAdd async wb_ping
Volker Lendecke [Sat, 16 May 2009 10:00:34 +0000 (12:00 +0200)]
Add async wb_ping

14 years agoAdd an async wb request loop
Volker Lendecke [Sat, 16 May 2009 10:00:07 +0000 (12:00 +0200)]
Add an async wb request loop

14 years agoAdd wb_domain_request_send/recv
Volker Lendecke [Sat, 13 Jun 2009 10:13:07 +0000 (12:13 +0200)]
Add wb_domain_request_send/recv

14 years agoRemove some unused code
Volker Lendecke [Sun, 10 May 2009 17:17:37 +0000 (19:17 +0200)]
Remove some unused code

14 years agoConvert the winbind parent->child communication to wb_reqtrans
Volker Lendecke [Sun, 10 May 2009 08:49:53 +0000 (10:49 +0200)]
Convert the winbind parent->child communication to wb_reqtrans

14 years agoConvert the main winbind client communication to wb_reqtrans.c
Volker Lendecke [Sat, 9 May 2009 18:04:27 +0000 (20:04 +0200)]
Convert the main winbind client communication to wb_reqtrans.c

14 years agoMake winbindd_cli_state->request a pointer instead of a struct member
Volker Lendecke [Thu, 7 May 2009 20:46:27 +0000 (22:46 +0200)]
Make winbindd_cli_state->request a pointer instead of a struct member

In itself, this is pretty pointless. But in the next steps I'll convert the
winbind internal communication to wb_reqtrans which allocates the request
properly. This minimizes the later diff.

Volker

14 years agosmbtorture: Output subunit by default.
Jelmer Vernooij [Sat, 13 Jun 2009 14:14:39 +0000 (16:14 +0200)]
smbtorture: Output subunit by default.

14 years agosmbtorture: Remove unused 'quiet' output format.
Jelmer Vernooij [Sat, 13 Jun 2009 14:13:32 +0000 (16:13 +0200)]
smbtorture: Remove unused 'quiet' output format.

14 years agolibwbclient: Add debugging hooks.
Kai Blin [Mon, 1 Jun 2009 21:33:27 +0000 (23:33 +0200)]
libwbclient: Add debugging hooks.

14 years agos3: Plumb smb_filename through SMB_VFS_CREATE_FILE
Tim Prouty [Fri, 12 Jun 2009 19:54:11 +0000 (12:54 -0700)]
s3: Plumb smb_filename through SMB_VFS_CREATE_FILE

14 years agos3: Add smb_filename utility functions and fix a bug in copy_smb_filename
Tim Prouty [Fri, 12 Jun 2009 19:41:19 +0000 (12:41 -0700)]
s3: Add smb_filename utility functions and fix a bug in copy_smb_filename

14 years agoCheck for error in transfer_file return also.
Jeremy Allison [Fri, 12 Jun 2009 20:55:18 +0000 (13:55 -0700)]
Check for error in transfer_file return also.
Jeremy.

14 years agoFix bug 6440
Volker Lendecke [Sat, 6 Jun 2009 21:27:31 +0000 (23:27 +0200)]
Fix bug 6440

Don't ignore the close error of the output file in check_magic()

14 years agoSimplify close_normal_file()
Volker Lendecke [Sat, 6 Jun 2009 21:20:44 +0000 (23:20 +0200)]
Simplify close_normal_file()

14 years agoexamples:s2→s3-ldif-convert-script: fix objectclass recognition
Björn Jacke [Fri, 12 Jun 2009 16:39:31 +0000 (18:39 +0200)]
examples:s2→s3-ldif-convert-script: fix objectclass recognition

objectclasses are case insensitive. we used to convert only LDAP objects with
the typical UpperLower case for sambaAccount and sambaGroupMapping and ignored
any other case writings

14 years agosubunit: non-zero exit code if one or more testsuites failed.
Jelmer Vernooij [Fri, 12 Jun 2009 15:53:46 +0000 (17:53 +0200)]
subunit: non-zero exit code if one or more testsuites failed.

14 years agoselftest: Fix references to filenames with knownfailures and slow tests.
Jelmer Vernooij [Fri, 12 Jun 2009 15:45:15 +0000 (17:45 +0200)]
selftest: Fix references to filenames with knownfailures and slow tests.

14 years agoselftest: Document the fact that test runner and formatter are now
Jelmer Vernooij [Fri, 12 Jun 2009 13:54:50 +0000 (15:54 +0200)]
selftest: Document the fact that test runner and formatter are now
separate tools.

14 years agoFix wb_req_more(): Return 0 when done, read_pkt_send needs that
Volker Lendecke [Fri, 12 Jun 2009 15:27:58 +0000 (17:27 +0200)]
Fix wb_req_more(): Return 0 when done, read_pkt_send needs that

14 years agosubunit: Pass canonical names of test results to formatters and filters.
Jelmer Vernooij [Fri, 12 Jun 2009 13:05:59 +0000 (15:05 +0200)]
subunit: Pass canonical names of test results to formatters and filters.

14 years agoActivate tldap tracing in pdb_ads
Volker Lendecke [Fri, 12 Jun 2009 13:02:01 +0000 (15:02 +0200)]
Activate tldap tracing in pdb_ads

14 years agoAdd basic tracing of tldap messages
Volker Lendecke [Fri, 12 Jun 2009 12:52:35 +0000 (14:52 +0200)]
Add basic tracing of tldap messages

14 years agoAdd debugging facility to tldap, analogous to tevent
Volker Lendecke [Fri, 12 Jun 2009 12:50:46 +0000 (14:50 +0200)]
Add debugging facility to tldap, analogous to tevent

14 years agoselftest: Add option to strip output of succeeded tests, and use it on
Jelmer Vernooij [Fri, 12 Jun 2009 12:34:24 +0000 (14:34 +0200)]
selftest: Add option to strip output of succeeded tests, and use it on
the buildfarm.

The matches the behaviour we had earlier in the previous output format.

14 years agoselftest: Remove existing buildfarm output format.
Jelmer Vernooij [Fri, 12 Jun 2009 12:21:15 +0000 (14:21 +0200)]
selftest: Remove existing buildfarm output format.

14 years agoselftest: Output subunit on the buildfarm.
Jelmer Vernooij [Fri, 12 Jun 2009 12:21:03 +0000 (14:21 +0200)]
selftest: Output subunit on the buildfarm.

14 years agopackaging/Debian: Remove outdated Debian package sources and instead refer to
Jelmer Vernooij [Fri, 12 Jun 2009 00:55:26 +0000 (02:55 +0200)]
packaging/Debian: Remove outdated Debian package sources and instead refer to
Debian.org and SerNet packages.

14 years agoad-schema/license.txt: Fix typo.
Jelmer Vernooij [Thu, 11 Jun 2009 23:00:30 +0000 (01:00 +0200)]
ad-schema/license.txt: Fix typo.

14 years agoformat-subunit: Remove subunit output module.
Jelmer Vernooij [Thu, 11 Jun 2009 22:53:27 +0000 (00:53 +0200)]
format-subunit: Remove subunit output module.

We can still use "cat" to obtain a subunit stream from a subunit stream. :-)

14 years agos3: Call va_end() after all va_start()/va_copy() calls.
Andrew Kroeger [Thu, 11 Jun 2009 07:15:28 +0000 (02:15 -0500)]
s3: Call va_end() after all va_start()/va_copy() calls.

There are error paths in S3 where va_end() is not properly called after
va_start() or va_copy() have been called.

These issues were noted while performing an inspection for S4 bug #6129.  Thanks
to Erik Hovland <erik@hovland.org> for the original bug report.

14 years agoRevert "avoid crashes in ndr_print_*() calls"
Andrew Tridgell [Fri, 12 Jun 2009 05:37:48 +0000 (15:37 +1000)]
Revert "avoid crashes in ndr_print_*() calls"

This reverts commit f5a47dc4bf2793ab328c8b0e35adace497819e7d.

This change broke Samba3. We'll need to do it the long way.

14 years agotwo more NT status codes that we get on DRS with w2k8-R2
Andrew Tridgell [Fri, 12 Jun 2009 02:22:53 +0000 (12:22 +1000)]
two more NT status codes that we get on DRS with w2k8-R2

14 years agoavoid crashes in ndr_print_*() calls
Andrew Tridgell [Fri, 12 Jun 2009 02:22:25 +0000 (12:22 +1000)]
avoid crashes in ndr_print_*() calls

This is a hackish fix, but it will do for now

14 years agoalways enable RPC debugging with a debug level >= 100.
Andrew Tridgell [Thu, 11 Jun 2009 05:21:29 +0000 (15:21 +1000)]
always enable RPC debugging with a debug level >= 100.

This helps with tools where setting the binding string is not
possible, such as net

14 years agos3-docs: Fix Bug #4280. Shutdown scripts are called as root for privileged users.
Günther Deschner [Thu, 11 Jun 2009 22:46:38 +0000 (00:46 +0200)]
s3-docs: Fix Bug #4280. Shutdown scripts are called as root for privileged users.

GUenther

14 years agoselftest/buildfarm: Don't assume that a reason being specified is an indication of...
Jelmer Vernooij [Thu, 11 Jun 2009 22:19:02 +0000 (00:19 +0200)]
selftest/buildfarm: Don't assume that a reason being specified is an indication of failure.

14 years agosubunit-filter: Print names of skipped testsuites.
Jelmer Vernooij [Thu, 11 Jun 2009 22:08:19 +0000 (00:08 +0200)]
subunit-filter: Print names of skipped testsuites.

14 years agoAdd supportedCapabilities to our rootDSE
Andrew Bartlett [Thu, 11 Jun 2009 11:04:42 +0000 (21:04 +1000)]
Add supportedCapabilities to our rootDSE

This makes AD client tools happier, as they know they are talking to
an AD server.

per Bug 6229 by Matthieu Patou <mat@matws.net>

Andrew Bartlett

14 years agos4:heimdal: import lorikeet-heimdal-200906080040 (commit 904d0124b46eed7a8ad6e5b73e89...
Andrew Bartlett [Mon, 8 Jun 2009 09:06:16 +0000 (19:06 +1000)]
s4:heimdal: import lorikeet-heimdal-200906080040 (commit 904d0124b46eed7a8ad6e5b73e892ff34b6865ba)

Also including the supporting changes required to pass make test

A number of heimdal functions and constants have changed since we last
imported a tree (for the better, but inconvenient for us).

Andrew Bartlett

14 years agoFix bug #6297 - owner of sticky directory cannot delete files created by others.
Jeremy Allison [Thu, 11 Jun 2009 19:51:45 +0000 (12:51 -0700)]
Fix bug #6297 - owner of sticky directory cannot delete files created by others.
The reason we couldn't delete was we were erroring out early
if requestor was not the owner of the file we wanted to delete,
instead of checking if the requestor owned the directory as well.
If either of these is true, we must go on and check the ACL.
Karolin, this is a must for 3.4.0 and also 3.3.next. I'll update
the bug report with patches for 3.4.0 and 3.3.next and ask vl
to review.
Jeremy.

14 years agos3 passdb ads: add missing character
Tim Prouty [Thu, 11 Jun 2009 17:30:29 +0000 (10:30 -0700)]
s3 passdb ads: add missing character

14 years agos3: Prepare the rename path for passing smb_filename to SMB_VFS_CREATE_FILE
Tim Prouty [Thu, 11 Jun 2009 02:49:31 +0000 (19:49 -0700)]
s3: Prepare the rename path for passing smb_filename to SMB_VFS_CREATE_FILE

14 years agos3: Prepare the do_unlink path for passing smb_filname to SMB_VFS_CREATE_FILE
Tim Prouty [Wed, 10 Jun 2009 23:08:34 +0000 (16:08 -0700)]
s3: Prepare the do_unlink path for passing smb_filname to SMB_VFS_CREATE_FILE

14 years agos3: refactor utility function to handle splitting the directory from the mask
Tim Prouty [Wed, 10 Jun 2009 23:02:00 +0000 (16:02 -0700)]
s3: refactor utility function to handle splitting the directory from the mask

14 years agoselftest: Fix exit code for format-subunit.pl.
Jelmer Vernooij [Thu, 11 Jun 2009 17:59:26 +0000 (19:59 +0200)]
selftest: Fix exit code for format-subunit.pl.