Michael Adam [Fri, 3 Jul 2009 14:42:20 +0000 (16:42 +0200)]
s3:registry: add db_context argument to regdb_delete_values()
Michael
Michael Adam [Fri, 3 Jul 2009 14:40:43 +0000 (16:40 +0200)]
s3:registry: add db_context argument to regdb_delete_key_with_prefix()
Michael
Michael Adam [Wed, 8 Jul 2009 14:16:18 +0000 (16:16 +0200)]
s3:registry: don't store differently cased entries for the same keys.
This happened for instance during registry initialization, when
entries for HKLM\Software and HKLM\SOFTWARE were created.
Searching these entries was case insensitive though.
But the entries ended up in the subkey-lists anyways.
This is solved by making the subkeys_hash in the regsubkey_container
structs case insensitive (using the new _bystring_upper() wrappers).
Michael
Michael Adam [Wed, 15 Jul 2009 07:58:02 +0000 (09:58 +0200)]
s3:dbwrap_util: add my C
Michael
Michael Adam [Wed, 8 Jul 2009 14:13:07 +0000 (16:13 +0200)]
s3:dbwrap: add dbwrap_fetch_bystring_upper().
To fetch a key whose name is stored but not given in upper case.
Michael
Michael Adam [Wed, 8 Jul 2009 14:08:41 +0000 (16:08 +0200)]
s3:dbwrap: add dbwrap_store_bystring_upper().
This stores a key under the uppercase version of the given keyname.
Michael
Michael Adam [Wed, 8 Jul 2009 14:02:19 +0000 (16:02 +0200)]
s3:dbwrap: add dbwrap_delete_bystring_upper()
To delete a key whose name is not given in but stored in uppercase.
Michael
Michael Adam [Wed, 15 Jul 2009 12:00:42 +0000 (14:00 +0200)]
s3:dbwrap: add a wrapper dbwrap_trans_do()
This function wraps the action() callback into a db
transaction and the transaction is either committed
or cancelled, depending on the return value of
the action function.
Michael
Stefan Metzmacher [Wed, 15 Jul 2009 10:14:32 +0000 (12:14 +0200)]
torture/smb2: add missing new line to the new SMB2-DIR.FILE-INDEX test
Without this the subunit formated output would be invalid and make test
reports: "UNEXPECTED(error): samba4.smb2.dir (dc).FILE-INDEX"
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:23:57 +0000 (09:23 +0200)]
s3:smbd: add support for SMB2 SetInfo File*Information
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:08:20 +0000 (12:08 +0200)]
s3:smbd: implement SMB2 GetInfo with Fs*Information
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:23:36 +0000 (09:23 +0200)]
s3:smbd: return NT_STATUS_INVALID_INFO_CLASS in SMB2 GetInfo
metze
Stefan Metzmacher [Tue, 14 Jul 2009 07:47:46 +0000 (09:47 +0200)]
s3:smbd: check quota access against sec_initial_uid() instead of 0
And return an NTSTATUS mapped from errno. Instead of hardcoded values.
metze
Stefan Metzmacher [Tue, 14 Jul 2009 07:49:25 +0000 (09:49 +0200)]
s3:lib: map ENOSYS to NT_STATUS_NOT_SUPPORTED instead of NT_STATUS_ACCESS_DENIED
Jeremy: please check and decide if we want to backport this.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 09:54:07 +0000 (11:54 +0200)]
s3:make test: smbtorture from s3 needs to take the config file path via the SMB_CONF_PATH envvar
metze
Stefan Metzmacher [Tue, 14 Jul 2009 11:32:23 +0000 (13:32 +0200)]
SMB2-GETINFO: test SMB2_ALL_EAS
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:25:40 +0000 (12:25 +0200)]
s4:libcli/smb2: add smb2_transport_credits_set_charge() to change the CreditsCharge value for the next request
metze
Stefan Metzmacher [Wed, 8 Jul 2009 08:09:54 +0000 (10:09 +0200)]
SMB2-CONNECT: unlink the test file at startup
This is needed to get reproducable results...
metze
Volker Lendecke [Tue, 14 Jul 2009 16:31:28 +0000 (18:31 +0200)]
Consolidate gencache also every 100 writes in a single process
Volker Lendecke [Tue, 14 Jul 2009 09:33:04 +0000 (11:33 +0200)]
Consolidate string and data_blob routines in gencache
Volker Lendecke [Mon, 13 Jul 2009 15:04:29 +0000 (17:04 +0200)]
Make gencache more stable
This provides a compromise between stability and performance: gencache is a
persistent database these days that for performance reasons can not use tdb
transactions for all writes. This patch splits up gencache into gencache.tdb
and gencache_notrans.tdb. gencache_notrans is used with CLEAR_IF_FIRST, writes
to it don't use transactions. By default every 5 minutes and when a program
exits, all entries from _notrans.tdb are transferred to gencache.tdb in one
transaction.
Volker Lendecke [Mon, 13 Jul 2009 15:03:52 +0000 (17:03 +0200)]
Add tdb_data_cmp
Volker Lendecke [Fri, 10 Jul 2009 10:24:56 +0000 (12:24 +0200)]
Remove gencache_init/shutdown
gencache_get/set/del/iterate call gencache_init() internally anyway. And we've
been very lazy calling gencache_shutdown, so this seems not really required.
Volker Lendecke [Fri, 10 Jul 2009 10:12:30 +0000 (12:12 +0200)]
Fix some nonempty blank lines
Volker Lendecke [Fri, 10 Jul 2009 10:03:35 +0000 (12:03 +0200)]
Remove gencache_[un]lock_key
Volker Lendecke [Fri, 10 Jul 2009 09:00:24 +0000 (11:00 +0200)]
TDB_CONTEXT -> "struct tdb_context"
Volker Lendecke [Fri, 10 Jul 2009 08:54:33 +0000 (10:54 +0200)]
Replace ASSERTs in gencache with "return false"
It's a bit strong to panic here I think.
Stefan Metzmacher [Wed, 15 Jul 2009 08:49:41 +0000 (10:49 +0200)]
torture/smb2: fix crash bugs in the new SMB2-DIR tests
metze
Jeremy Allison [Tue, 14 Jul 2009 23:54:01 +0000 (16:54 -0700)]
Change to talloc_zero_size instead of extra memset.
Jeremy.
Jeremy Allison [Tue, 14 Jul 2009 23:42:21 +0000 (16:42 -0700)]
When tallocing a memory block for the state in a tevent_req struct,
ensure it's zeroed out. Vl & Metze please check.
Jeremy.
Günther Deschner [Tue, 14 Jul 2009 23:22:32 +0000 (01:22 +0200)]
s4-selftest: ok, s4 cant print. add RPC-SPOOLSS-PRINTER to knownfail for now.
Guenther
Aravind [Tue, 7 Jul 2009 14:11:56 +0000 (07:11 -0700)]
torture/smb2: Adding SMB2 Directory enumeration torture tests.
* Most of the tests were ported from SMB torture tests.
* Added one new tests which checks the behavior of the file_index field
present in SMB2_FIND struct.
* Added one new test to check the enumeration of directories containing
lots of files (~2000 files) with name lengths varying from 1 to 200 char.
Günther Deschner [Tue, 14 Jul 2009 21:36:41 +0000 (23:36 +0200)]
s3-passdb: fix wbc build warning.
Guenther
Volker Lendecke [Tue, 14 Jul 2009 21:12:59 +0000 (23:12 +0200)]
Fix bug 5886
Ok, that's a very long-standing one. I finally got around to install a recent
OpenLDAP and test the different variants of setting a NULL password etc.
Thanks all for your patience!
Volker
Günther Deschner [Fri, 3 Jul 2009 07:56:28 +0000 (09:56 +0200)]
s4-smbtorture: add RPC-SPOOLSS-PRINTER test.
Guenther
Günther Deschner [Thu, 2 Jul 2009 17:38:12 +0000 (19:38 +0200)]
s4-smbtorture: add some tests to check spoolss_SetPrinter behavior.
Guenther
Günther Deschner [Tue, 14 Jul 2009 12:33:08 +0000 (14:33 +0200)]
s4-smbtorture: restructure test_OpenPrinter_server in RPC-SPOOLSS a bit.
Guenther
Björn Jacke [Tue, 14 Jul 2009 20:23:39 +0000 (22:23 +0200)]
s3: allow setting the TCP_QUICKACK socket option
Volker Lendecke [Tue, 14 Jul 2009 19:28:13 +0000 (21:28 +0200)]
Attempt to fix the build
Volker Lendecke [Tue, 14 Jul 2009 16:34:36 +0000 (18:34 +0200)]
Create a talloc_stackframe for each file in wildcard unlink
There might be *many* files to delete
Volker Lendecke [Tue, 14 Jul 2009 16:34:07 +0000 (18:34 +0200)]
Create a correct talloc hierarchy in make_sec_acl()
Volker Lendecke [Tue, 14 Jul 2009 16:33:01 +0000 (18:33 +0200)]
TALLOC_FREE(sd) in check_open_rights upon an error
Jeremy Allison [Tue, 14 Jul 2009 18:25:45 +0000 (11:25 -0700)]
Revert this commit :
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and
non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
For now. This is a feature request and I think we need
to design it a little differently so as not to touch
core change_to_user() code.
Jeremy.
Bo Yang [Wed, 15 Jul 2009 09:03:04 +0000 (17:03 +0800)]
s3: fix build of pdbedit and net_sam. Guenther, please check. Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:37:04 +0000 (15:37 +0800)]
s3: Fix double free in net usershare.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:36:02 +0000 (15:36 +0800)]
S3: Small fix to get rid of annoying log message.
Signed-off-by: Bo Yang <boyang@samba.org>
Bo Yang [Wed, 15 Jul 2009 07:34:10 +0000 (15:34 +0800)]
s3: Make smbd aware of permission change of usershare. Since usershare are relatively volatile and non-previledge users must disconnect from smbd and reconnect to it to make share permission in effect.
Björn Jacke [Tue, 14 Jul 2009 15:55:50 +0000 (17:55 +0200)]
s3: make
d9c0d58236 better readble and reduce indentation
Björn Jacke [Tue, 14 Jul 2009 15:40:21 +0000 (17:40 +0200)]
s3: don't make same innetgr check twice
Sumit Bose [Fri, 10 Jul 2009 20:44:27 +0000 (22:44 +0200)]
remove all '\n' from ldb_debug
Günther Deschner [Mon, 13 Jul 2009 21:53:49 +0000 (23:53 +0200)]
s3-account_policy: add pdb_policy_type enum.
Guenther
Günther Deschner [Mon, 13 Jul 2009 21:42:57 +0000 (23:42 +0200)]
s3-account_policy: remove trailing whitespace.
Guenther
Günther Deschner [Mon, 13 Jul 2009 21:38:16 +0000 (23:38 +0200)]
s3: re-run make idl.
Guenther
Günther Deschner [Mon, 13 Jul 2009 20:46:51 +0000 (22:46 +0200)]
samr: add missing samr_ValidationStatus codes.
Guenther
Christian Ambach [Thu, 9 Jul 2009 12:45:23 +0000 (14:45 +0200)]
reject ACLs with DESC_DACL_PROTECTED on GPFS
as GPFS does not support the ACE4_FLAG_NO_PROPAGATE NFSv4 flag (which would be the mapping for the DESC_DACL_PROTECTED flag), the status of this flag is currently silently ignored by Samba. That means that if you deselect the "Allow inheritable permissions..." checkbox in Windows' ACL dialog and then apply the ACL, the flag will be back immediately.
To make sure that automatic migration with e.g. robocopy does not lead to ACLs silently (and unintentionally) changed, this patch adds an explicit check for this flag and if set, it will return NT_STATUS_NOT_SUPPORTED so errors are shown up on the Windows side and the Administrator is aware of the ACLs not being settable like intended
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Jeremy Allison [Tue, 14 Jul 2009 01:43:10 +0000 (18:43 -0700)]
Make cli_posix_lock/unlock asynchronous.
Jeremy.
Jeremy Allison [Tue, 14 Jul 2009 00:17:37 +0000 (17:17 -0700)]
Fix set_posix_lock check which had been reversed in the recent
changes.
Jeremy.
Günther Deschner [Mon, 13 Jul 2009 19:56:31 +0000 (21:56 +0200)]
s3-pdb_ads: set correct pdb field with the value from 'accountExpires' attribute.
Guenther
Stefan Metzmacher [Mon, 13 Jul 2009 11:24:19 +0000 (13:24 +0200)]
s3:net: Fix Bug #6222. Default to DRSUAPI replication for net rpc vampire keytab
metze
Signed-off-by: Günther Deschner <gd@samba.org>
Günther Deschner [Mon, 29 Jun 2009 18:34:03 +0000 (20:34 +0200)]
s3-rpc_server: pass down full unix token to map_max_allowed_access().
Also use unix_token->uid instead of geteuid() when checking for mapping of the
SEC_FLAG_MAXIMUM_ALLOWED flag.
Guenther
Günther Deschner [Fri, 12 Jun 2009 13:20:48 +0000 (15:20 +0200)]
libds: merge the UF<->ACB flag mapping functions.
Guenther
Günther Deschner [Fri, 12 Jun 2009 12:27:19 +0000 (14:27 +0200)]
libds: share UF_ flags between samba3 and 4.
Guenther
Stefan Metzmacher [Mon, 13 Jul 2009 11:14:39 +0000 (13:14 +0200)]
s3:smbd: close_file() handles named pipes just fine, no reason to return NOT_SUPPORTED
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:05:34 +0000 (12:05 +0200)]
s3:smbd: make smbd_do_qfsinfo() non static for use in SMB2 GetInfo
metze
Stefan Metzmacher [Mon, 13 Jul 2009 09:54:20 +0000 (11:54 +0200)]
s3:smbd: split out smbd_do_qfsinfo() from call_trans2qfsinfo()
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:01:56 +0000 (09:01 +0200)]
s3:smbd: make smbd_do_setfilepathinfo() non static for use in SMB2 SetInfo
metze
Stefan Metzmacher [Mon, 13 Jul 2009 06:59:32 +0000 (08:59 +0200)]
s3:smbd: split out smbd_do_setfilepathinfo() from call_trans2setfilepathinfo()
metze
Stefan Metzmacher [Fri, 10 Jul 2009 18:39:08 +0000 (20:39 +0200)]
s3:smbd: start SMB2 GetInfo support for File*Information levels
TODO: the EA levels are not fully supported.
metze
Stefan Metzmacher [Sun, 12 Jul 2009 14:40:58 +0000 (16:40 +0200)]
s3:smbd: add support for marshalling SMB2 FileFullEaInformation
metze
Stefan Metzmacher [Sun, 12 Jul 2009 15:08:18 +0000 (17:08 +0200)]
s3:smbd: add support for marshalling SMB2 FileAllInformation
metze
Stefan Metzmacher [Sun, 12 Jul 2009 15:06:05 +0000 (17:06 +0200)]
s3:smbd: filter out SMB2 specific private query info levels for SMB1
metze
Stefan Metzmacher [Fri, 10 Jul 2009 18:02:44 +0000 (20:02 +0200)]
s3:smbd: make smbd_do_qfilepathinfo() non static for use in SMB2
metze
Stefan Metzmacher [Sun, 12 Jul 2009 14:37:49 +0000 (16:37 +0200)]
s3:smbd: split calculation and mashalling of file index and access_mask
metze
Stefan Metzmacher [Fri, 10 Jul 2009 17:04:58 +0000 (19:04 +0200)]
s3:smbd: split out smbd_do_qfilepathinfo() from call_trans2qfilepathinfo()
This prepares SMB2 GetInfo.
metze
Stefan Metzmacher [Fri, 10 Jul 2009 16:51:59 +0000 (18:51 +0200)]
s3:smbd: add missing return after reply_nterror()
metze
Jeremy Allison [Sat, 11 Jul 2009 01:23:00 +0000 (18:23 -0700)]
Remove reply_unixerror() - no longer needed. Should make Metze's refactoring a lot easier.
Jeremy.
Jeremy Allison [Fri, 10 Jul 2009 22:50:40 +0000 (15:50 -0700)]
Add hash values to the xattr ACLS to determine when
an underlying POSIX ACL is changed out from under us.
Passes RAW-ACL test up to "invalid owner" problem when
trying to create a file owned by Everyone. Now needs
porting to modules/vfs_acl_tdb.c
Jeremy.
Volker Lendecke [Thu, 9 Jul 2009 13:58:10 +0000 (15:58 +0200)]
Return 0 domains from enum_trusteddoms
Volker Lendecke [Sun, 5 Jul 2009 12:39:16 +0000 (14:39 +0200)]
Quieten events and tldap debug messages
Tim Prouty [Fri, 10 Jul 2009 19:03:51 +0000 (12:03 -0700)]
s3 smb2: Remove unused variable
Volker Lendecke [Fri, 10 Jul 2009 15:36:18 +0000 (17:36 +0200)]
Fix&Run local-gencache
Volker Lendecke [Fri, 10 Jul 2009 15:29:22 +0000 (17:29 +0200)]
Fix our base64 implementation for blobs of length 4....
The additional length check bit us exactly at 4, removing it. The
torture test survives valgrind up to 2000 bytes :-)
Stefan Metzmacher [Wed, 8 Jul 2009 11:13:32 +0000 (13:13 +0200)]
s3:smbd: add support for SMB2 Lock
metze
Stefan Metzmacher [Tue, 7 Jul 2009 16:09:16 +0000 (18:09 +0200)]
s3:smbd: make smbd_do_locking() non static
metze
Stefan Metzmacher [Tue, 7 Jul 2009 15:24:25 +0000 (17:24 +0200)]
s3:smbd: abstract the main locking logic from the LockingAndX parsing
This prepares SMB2 Lock support.
metze
Stefan Metzmacher [Thu, 9 Jul 2009 09:34:14 +0000 (11:34 +0200)]
s3:smbd: pass down the client pid to smbd_smb2_lock_send()
metze
Stefan Metzmacher [Thu, 9 Jul 2009 09:33:58 +0000 (11:33 +0200)]
s3:smbd: fix parsing of SMB2 Lock requests with lock_count > 1
We should not reuse the variable 'i'.
metze
Stefan Metzmacher [Wed, 8 Jul 2009 15:02:00 +0000 (17:02 +0200)]
s3:smbd: fix parsing of invalid SMB2 requests.
Because of 0 - 2 => 0xFFFFFFFE, we got EMSGSIZE
from the tstream layer. And terminate the transport
connection. Instead we should let the caller deal with
the invalid parameter, when checking the body size.
So the caller always gets at least a 2 byte body.
metze
Volker Lendecke [Fri, 10 Jul 2009 09:59:00 +0000 (11:59 +0200)]
Attempt to fix the build -- jlayton, please check!
Jeff Layton [Fri, 10 Jul 2009 01:04:08 +0000 (21:04 -0400)]
cifs.upcall: use pid value from kernel to determine KRB5CCNAME to use
If the kernel sends the upcall a pid of the requesting process, we can
open that process' /proc/<pid>/environ file and scrape the KRB5CCNAME
value out of it.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Tim Prouty [Thu, 9 Jul 2009 22:56:36 +0000 (15:56 -0700)]
s3: Fix two arguments that broke when plumbing smb_filneame through dos_mode()
Volker Lendecke [Thu, 9 Jul 2009 20:03:52 +0000 (22:03 +0200)]
Make escape_ldap_string take a talloc context
Andrew Bartlett [Thu, 9 Jul 2009 04:53:26 +0000 (14:53 +1000)]
s4:dsdb Allow unicodePwd to be set when adding a user
Windows 7 sets it's join password using the unicodePwd attribute (as a
quoted, utf16 string), and does so during the LDAPAdd of the object.
Previously, this code only handled unicodePwd for modifies.
Andrew Bartlett
Andrew Bartlett [Thu, 9 Jul 2009 00:08:02 +0000 (10:08 +1000)]
Add const
Tim Prouty [Thu, 9 Jul 2009 03:15:02 +0000 (20:15 -0700)]
s3: Repace a char * with an smb_filename struct in reply_rmdir
Tim Prouty [Wed, 8 Jul 2009 23:53:01 +0000 (16:53 -0700)]
s3: Prepare open.c to switch fsp_name to an smb_filename struct
Tim Prouty [Thu, 9 Jul 2009 00:53:05 +0000 (17:53 -0700)]
s3 plumb smb_filename through smb_set_file_allocation_info()
Tim Prouty [Wed, 8 Jul 2009 23:22:44 +0000 (16:22 -0700)]
s3: Change the share_mode_lock struct to store a base_name and stream_name
Tim Prouty [Wed, 8 Jul 2009 21:27:06 +0000 (14:27 -0700)]
s3: Make some arguments to (parse|unparse)_share_modes() const
Tim Prouty [Wed, 8 Jul 2009 21:08:04 +0000 (14:08 -0700)]
s3: Remove is_ntfs_stream_name() and split_ntfs_stream_name()
Actually I moved split_ntfs_stream_name into torture.c which is the one
consumer of it. This could probably be changed at some point.