20 years agoAdding Michael Sweet's LSB packaging.
Jeremy Allison [Tue, 3 Jul 2001 01:01:12 +0000 (01:01 +0000)]
Adding Michael Sweet's LSB packaging.
(This used to be commit 90985da62f733bed550ef326359bdbb8631ea554)

20 years ago- sorry, forgot to check a pointer
Simo Sorce [Tue, 3 Jul 2001 00:54:55 +0000 (00:54 +0000)]
- sorry, forgot to check a pointer
(This used to be commit 4e0299d4c091bc4a63740f12588675507601e8cd)

20 years agoApplied Michael Sweet's patch, with one minor signal change.
Jeremy Allison [Tue, 3 Jul 2001 00:52:56 +0000 (00:52 +0000)]
Applied Michael Sweet's patch, with one minor signal change.
(This used to be commit 8d1dab74c26d25938de14b34b383890731e9ebd0)

20 years ago- sorry, forgot to test a pointer
Simo Sorce [Tue, 3 Jul 2001 00:23:38 +0000 (00:23 +0000)]
- sorry, forgot to test a pointer
(This used to be commit 1aef52245229741bc24c3e8147fa86eaa20fe9b2)

20 years agoMade talloc_realloc() semantics match realloc(). JF was complaining :-).
Jeremy Allison [Mon, 2 Jul 2001 22:17:58 +0000 (22:17 +0000)]
Made talloc_realloc() semantics match realloc(). JF was complaining :-).
realloc(NULL) == malloc. realloc(p,0) == free() - a no-op in talloc.
(This used to be commit 1ab31e5db53bc839d2785cce4d3c739c8004bbf6)

20 years agoMissing prs_align() was causing Win9x nexus tools to fail. security_info_sent
Jeremy Allison [Mon, 2 Jul 2001 21:56:20 +0000 (21:56 +0000)]
Missing prs_align() was causing Win9x nexus tools to fail. security_info_sent
was being miss-parsed.
(This used to be commit 1685e41da04f1fbbab036e194ce1b1e7ba9fef86)

20 years agoFixed auto-alloc of dispinfo code when unmarshalling.
Jeremy Allison [Mon, 2 Jul 2001 21:23:13 +0000 (21:23 +0000)]
Fixed auto-alloc of dispinfo code when unmarshalling.
(This used to be commit d4872c94c2e6b63be0fb12e5dd2d0459fda54959)

20 years agoFixed extra file_free calls - my fault :-(.
Jeremy Allison [Mon, 2 Jul 2001 18:37:39 +0000 (18:37 +0000)]
Fixed extra file_free calls - my fault :-(.
(This used to be commit 2f8b84bda040edc87a7af29c3a281cf335e392cb)

20 years agoVery minor cleanup. I was looking for another problem and found some bits
Christopher R. Hertel [Mon, 2 Jul 2001 16:25:00 +0000 (16:25 +0000)]
Very minor cleanup.  I was looking for another problem and found some bits
of code that were unclear.

Chris -)-----
(This used to be commit c2977be3408645499915d728538ba2c65b97614f)

20 years agoThis fix from Eelco Vriezekolk <> is for a SIG11 bug where we
Andrew Bartlett [Mon, 2 Jul 2001 13:43:46 +0000 (13:43 +0000)]
This fix from Eelco Vriezekolk <> is for a SIG11 bug where we
would always file_free(fsp) twice, once in close_file and once afterwoulds.

The bug was reported in SAMBA_2_2, but a code inspection shows it to be in HEAD
as well.  (Unfortunetly I don't have the facilites to actualy check this, but
the change is quite simple, makes sence and compiles).

Andrew Bartlett
(This used to be commit 5d3f622375842961a79536d36ee6f6ad508b91f1)

20 years agoFix the torture test, we had the wrong file-name in the tests
Andrew Bartlett [Mon, 2 Jul 2001 09:10:32 +0000 (09:10 +0000)]
Fix the torture test, we had the wrong file-name in the tests

Andrew Bartlett
(This used to be commit d04ea88b5d4b010d77dec45104dcf6a2b5a071f2)

20 years agoRe-ran configure.
Tim Potter [Mon, 2 Jul 2001 09:10:15 +0000 (09:10 +0000)]
Re-ran configure.
(This used to be commit 33f668b137054f3eb768036398693a3b754158c3)

20 years agoOnly build the pam_winbind module if --with-pam used.
Tim Potter [Mon, 2 Jul 2001 08:58:57 +0000 (08:58 +0000)]
Only build the pam_winbind module if --with-pam used.

Replaced extra shell variable with_pam_for_crypto with a check against
(This used to be commit 9db0332954e8b37fa5162b26d78de42a7fa533ae)

20 years agoWe need strict locking to pass LOCK4
Andrew Bartlett [Mon, 2 Jul 2001 07:20:00 +0000 (07:20 +0000)]
We need strict locking to pass LOCK4

Andrew Bartlett
(This used to be commit 584a14a2163a22d6a532c926040f4f9bcc34463d)

20 years agoStart of smbtorture based testing. Not all of smbtorture's facilites
Andrew Bartlett [Mon, 2 Jul 2001 07:18:49 +0000 (07:18 +0000)]
Start of smbtorture based testing.  Not all of smbtorture's facilites
are used, but these ones should pass.

Andrew Bartlett
(This used to be commit eee251f71071034b6d1a74d192cdabe8e24dc08b)

20 years agoNot all OSs have setbuffer, so we better check for it.
Andrew Bartlett [Mon, 2 Jul 2001 04:47:55 +0000 (04:47 +0000)]
Not all OSs have setbuffer, so we better check for it.

Andrew Bartlett
(This used to be commit aa5708de69a71e6b41a12f63550fae94f2481742)

20 years agoMake smbtorture return status values for use in the build_farm tests.
Andrew Bartlett [Mon, 2 Jul 2001 03:21:17 +0000 (03:21 +0000)]
Make smbtorture return status values for use in the build_farm tests.

This should not have changed behaviour, and it has been tested.

Andrew Bartlett
(This used to be commit a73aefef09804bf95eec1449f75adc5ff5e032d0)

20 years agoFixed the nastiest locking bug to track down.... smb_pids are sent in the
Jeremy Allison [Mon, 2 Jul 2001 02:42:41 +0000 (02:42 +0000)]
Fixed the nastiest locking bug to track down.... smb_pids are sent in the
lockingX calls - use that instead of smb_pid in the packet.
(This used to be commit a3925cb9c6303ce24e5fecad6c8f3a0ba78b9ee0)

20 years agoInsure caught the fact that PTRDIFFs were being done between two unrelated
Jeremy Allison [Mon, 2 Jul 2001 00:33:15 +0000 (00:33 +0000)]
Insure caught the fact that PTRDIFFs were being done between two unrelated
(This used to be commit 15c64199cb29e2fca6ee7353673dbb3f962e0e24)

20 years ago"netbios aliases" and "interfaces" options change from P_STRING to P_LIST
Simo Sorce [Sun, 1 Jul 2001 23:24:08 +0000 (23:24 +0000)]
"netbios aliases" and "interfaces" options change from P_STRING to P_LIST
(This used to be commit db36ed1d80fcbee16d0a0b5f226e56961f3bf1ec)

20 years agoFix for building --with-profile for new vfscalls.
Jeremy Allison [Sun, 1 Jul 2001 20:01:32 +0000 (20:01 +0000)]
Fix for building --with-profile for new vfscalls.
(This used to be commit 33dc250ebb389f331cecf47101cf13c630be3a11)

20 years agocli_read() was reading too many bytes.
Andrew Tridgell [Sun, 1 Jul 2001 13:18:35 +0000 (13:18 +0000)]
cli_read() was reading too many bytes.
(This used to be commit ba79d2a030b9ae087f0cc4248baa6cf6bee112fb)

20 years ago- fix bug in reply_nt- fix bug in reply_nt1
Simo Sorce [Sun, 1 Jul 2001 10:39:37 +0000 (10:39 +0000)]
- fix bug in reply_nt- fix bug in reply_nt1
(This used to be commit 200110a3b4caeb0d8be87f02476af29165e35ada)

20 years agoMake sure we compile with gcc by default.
Richard Sharpe [Sat, 30 Jun 2001 11:08:06 +0000 (11:08 +0000)]
Make sure we compile with gcc by default.
(This used to be commit 93c45024cdbbf51322106e2a5961db8c09618833)

20 years agoAdd a static linking target to the examples Makefile so I can test out static linking ...
Richard Sharpe [Sat, 30 Jun 2001 04:01:51 +0000 (04:01 +0000)]
Add a static linking target to the examples Makefile so I can test out static linking ...
(This used to be commit 9627bace72eb3be322f8895b055a31768e551136)

20 years agoEnsure we return correct error on trying to unlock a region not locked.
Jeremy Allison [Sat, 30 Jun 2001 03:11:44 +0000 (03:11 +0000)]
Ensure we return correct error on trying to unlock a region not locked.
(This used to be commit 015a077acc49e59179dc10256fd32166ee4623e2)

20 years agoFix another small problem with ... not doing the correct
Richard Sharpe [Sat, 30 Jun 2001 03:01:09 +0000 (03:01 +0000)]
Fix another small problem with ... not doing the correct
check for whether or not we should build a shared library.
(This used to be commit 09837044a2aa47a61d635316afa38645855db512)

20 years agoThis should return the build to normallity.
Andrew Bartlett [Sat, 30 Jun 2001 02:45:16 +0000 (02:45 +0000)]
This should return the build to normallity.

When you update an #ifdef'ed function, also update its matching null function
or all hell breaks loose on the build farm!

Andrew Bartlett
(This used to be commit 58b981a56f99bce0e98c9e1752c99a69e3cb2a25)

20 years agoFixed the first locking error (test #8 found by locktest code from
Jeremy Allison [Sat, 30 Jun 2001 01:59:48 +0000 (01:59 +0000)]
Fixed the first locking error (test #8 found by locktest code from
Clarion locktest.
(This used to be commit 5c42845b5bb6fafd0ebf93fbdd23d9bf861da865)

20 years agoModified to work properly. Define BLDSHARED as a variable in the makefile...
Richard Sharpe [Sat, 30 Jun 2001 01:40:51 +0000 (01:40 +0000)]
Modified to work properly. Define BLDSHARED as a variable in the makefile now.
(This used to be commit 332f646fdc25ae4fe3797ad6c85d4637f0dba0e3)

20 years agoThese changes cause the libsmbclient stuff to always build a non-shared library and...
Richard Sharpe [Fri, 29 Jun 2001 23:30:01 +0000 (23:30 +0000)]
These changes cause the libsmbclient stuff to always build a non-shared library and to build a shared library only for the four OSes that we currently like.

I will probably add HP/UX and AIX support based on the CUPS stuff soon ...
(This used to be commit 9585529455ae4a3e9b4dafc5f16286fabb052809)

20 years agoAdded LsaGetConnectedCredentials patch from Manoj Naik <>.
Jeremy Allison [Fri, 29 Jun 2001 23:12:55 +0000 (23:12 +0000)]
Added LsaGetConnectedCredentials patch from Manoj Naik <>.
(This used to be commit 7079300da6dbd950e55dc5871851250d5a3717ff)

20 years agoEnsured all the system calls in msdfs.c go through the vfs layer.
Jeremy Allison [Fri, 29 Jun 2001 22:32:24 +0000 (22:32 +0000)]
Ensured all the system calls in msdfs.c go through the vfs layer.
Added vfs calls to symlink() and readlink() with appropriate configure
(This used to be commit c24e6b41ea60ab4bac2fcd19da947851d6df3c7c)

20 years agoFrom JF....
Jeremy Allison [Fri, 29 Jun 2001 18:41:31 +0000 (18:41 +0000)]
From JF....

hi jeremy,

can you commit the following patch against HEAD. I can't do it right now

Thanks Tim for me. He changed the SAM_DISPINFO_1 array without checking if
he didn't break the server code. And he did.

So on my way I cleaned info_1, 2, .. 5

it may break winbind. I leave to tim the pleasure to fix it ;-)


I added some talloc changes and checks for alloc fails.

(This used to be commit 001e9b7b540f04c80ba65c879aaa41acddc86f3e)

20 years agoExperimental support for joining a domain without creating an account in
Tim Potter [Fri, 29 Jun 2001 08:04:12 +0000 (08:04 +0000)]
Experimental support for joining a domain without creating an account in
server manager first.  Just use the -U parameter to smbpasswd when joining
the domain:

smbpasswd -r PDC -j DOMAIN -U administrator%password

Should also work with domain users with the 'add workstation to domain'
user right.
(This used to be commit 937b96feaa276f8dd626f2d640f03dc4c55f48c6)

20 years agoRemoved another silly static array.
Tim Potter [Fri, 29 Jun 2001 07:55:41 +0000 (07:55 +0000)]
Removed another silly static array.
(This used to be commit 008628fb8ac9f92d984218f37fffdfa3cb9e3d62)

20 years agoWin9x weirdness. When setting the named pipe handle state on a Unicode
Tim Potter [Fri, 29 Jun 2001 01:58:48 +0000 (01:58 +0000)]
Win9x weirdness.  When setting the named pipe handle state on a Unicode
server, Win9x only sends \PIPE instead of \PIPE\.  Looks suspiciously like
an off-by one bug in the Win9x dce/rpc pipe code.
(This used to be commit b4a9079833c261705e18fdcaab752cb5292a078f)

20 years agoReplaced memcpy() with memmove() to make safe_strcpy() safe for overlapping
Tim Potter [Fri, 29 Jun 2001 01:15:28 +0000 (01:15 +0000)]
Replaced memcpy() with memmove() to make safe_strcpy() safe for overlapping
source and destination.
(This used to be commit 30411d4004ce7062e73506d228ef402b99226eee)

20 years agoUse a logical cli_read(), removed the cli_read_one() hack.
Jeremy Allison [Fri, 29 Jun 2001 00:22:22 +0000 (00:22 +0000)]
Use a logical cli_read(), removed the cli_read_one() hack.
(This used to be commit 2999eab5abe86bf08e693800c01ad544f04e4d6c)

20 years agoparam/loadparm.c: Fix for bad volume label, found by TAKAHASHI Motonobu
Jeremy Allison [Thu, 28 Jun 2001 23:21:43 +0000 (23:21 +0000)]
param/loadparm.c: Fix for bad volume label, found by TAKAHASHI Motonobu
Samba Users Group Japan. Ensure same as in 2.2.x codebase.
(This used to be commit 5a5d33b9464fe6289e55dbfd229d2859914b9293)

20 years agoAdded info to some of the debug messages to get a better handle on a problem
Christopher R. Hertel [Thu, 28 Jun 2001 20:49:47 +0000 (20:49 +0000)]
Added info to some of the debug messages to get a better handle on a problem
people are reporting regarding multiple responses to queries on <1D> names.

There should only ever be one LMB but some users are seeing multiple replies
to queries for the LMB name.  This is probably due to nodes on the LAN that
have NetBIOS over NetBEUI and/or IPX enabled.  Previously, the debug message
did not include the IP address associated with the name.  It *did* include
the source address of the packet, but in the examples I've seen all of these
were the same, eg:

[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (2) responses received for a query on subnet for name NT.CIS.KSU.EDU<1d>. This response was from IP
 [2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (3) responses received for a query on subnet for name NT.CIS.KSU.EDU<1d>. This response was from IP
 [2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (4) responses received for a query on subnet for name NT.CIS.KSU.EDU<1d>. This response was from IP
[2000/06/22 11:58:25, 0] nmbd/nmbd_namequery.c:query_name_response(93)
query_name_response: Multiple (5) responses received for a query on subnet for name NT.CIS.KSU.EDU<1d>. This response was from IP

Note that all of the above are reported as having come from
This should never happen.  If is a WINS server it should
send a Negative Name Query Response for a <1D> name query (wierd but true).

So, are all of the above coming from different systems, all of which
think are the LMB?  Are they all coming from one system that is, for some
strange reason, replying five times to the same query?

Anyway, I needed more info so I've changed the debug messages.

Chris -)-----
(This used to be commit 8f2f09af0a0a80cacef933ed500884e2c0b3f2fb)

20 years agoProperly instrument print_job_start()/print_job_end() so every fail case
Jeremy Allison [Thu, 28 Jun 2001 19:23:43 +0000 (19:23 +0000)]
Properly instrument print_job_start()/print_job_end() so every fail case
logs a debug. We need this to track fail cases.
(This used to be commit fe5cac150d7491a7dfdaf2a54998178bbfe5a303)

20 years agofixed guest account for build farm boxes
Andrew Tridgell [Thu, 28 Jun 2001 05:57:56 +0000 (05:57 +0000)]
fixed guest account for build farm boxes
(This used to be commit 0d112d7960353b33e9c5015c39a107a47e6f690d)

20 years agotemporarily made smbclient a non-error target so that builds will succeed when it...
Andrew Tridgell [Thu, 28 Jun 2001 03:03:11 +0000 (03:03 +0000)]
temporarily made smbclient a non-error target so that builds will succeed when it fails. This will give richard a chance to fix problems without breaking the tree
(This used to be commit 83d0dc4b53231b05588b7341540c0e4ba1f430b1)

20 years agoSyncup between 2.2 and HEAD.
Jeremy Allison [Wed, 27 Jun 2001 17:26:29 +0000 (17:26 +0000)]
Syncup between 2.2 and HEAD.
(This used to be commit 39d4131a4571c9c7a96bdc2f6cd6be80a6c330af)

20 years agoJigger around with the tests a bit more
Andrew Bartlett [Wed, 27 Jun 2001 13:58:58 +0000 (13:58 +0000)]
Jigger around with the tests a bit more

We now test security=share, security=user, security=server for both the
positive and negitive case (good/bad pw) and check that guest shares work for
share level security.

The server level security stuff seems to test positive without actualy
contating a server (another LIBSMB_PROG based smbd) - I will need to look into that...

Andrew Bartlett
(This used to be commit 19fdc553d6ab06e53c21425468f86da56f4d9153)

20 years agoon sco2 socketpair_tcp needs a bind
Andrew Tridgell [Wed, 27 Jun 2001 13:58:44 +0000 (13:58 +0000)]
on sco2 socketpair_tcp needs a bind
(This used to be commit d8e5409ebb883844d9a1abc9840af1809957a444)

20 years agohandle EISCONN in socketpair_tcp
Andrew Tridgell [Wed, 27 Jun 2001 10:44:14 +0000 (10:44 +0000)]
handle EISCONN in socketpair_tcp

this should get the auto-tests working on IRIX
(This used to be commit 87f90d48d857828a6ed12bdc58d0d881be45dfce)

20 years agoAdd the generic funcions file for the basicsmb tests
Andrew Bartlett [Wed, 27 Jun 2001 07:59:09 +0000 (07:59 +0000)]
Add the generic funcions file for the basicsmb tests

Andrew Bartlett
(This used to be commit b28baf71a7d947cfe8bda546f4e70194da0781da)

20 years agoAdded some missing entries to usage().
Tim Potter [Wed, 27 Jun 2001 04:43:55 +0000 (04:43 +0000)]
Added some missing entries to usage().

Added -d option to set debug level.
(This used to be commit 9874df0c2242ee46182744eabae14829c3b5f21e)

20 years agoAdded back the automatic build of in head.
Richard Sharpe [Wed, 27 Jun 2001 04:41:01 +0000 (04:41 +0000)]
Added back the automatic build of in head.

This is so I can find out what platforms it fails on. I will pull it again tomorrow if there are too many problems, like > 2 platforms that it fails to build on, but will pop it back in again as I resolve platforms.
(This used to be commit cc72c44e53a36f3da135f4dc10a9391f65c8b6c7)

20 years agoAdded doco for the -d parameter.
Tim Potter [Wed, 27 Jun 2001 04:40:12 +0000 (04:40 +0000)]
Added doco for the -d parameter.
(This used to be commit d8598efb5712c35cc0b59b4e232e3869077d11eb)

20 years agoFix a stupid typo ...
Richard Sharpe [Wed, 27 Jun 2001 04:06:13 +0000 (04:06 +0000)]
Fix a stupid typo ...
(This used to be commit 8a873b5dfb52393541c36fea0a5082771a6c8d63)

20 years agoChanged some of the tests around, made failures for parts actualy count
Andrew Bartlett [Wed, 27 Jun 2001 00:32:52 +0000 (00:32 +0000)]
Changed some of the tests around, made failures for parts actualy count

Andrew Bartlett
(This used to be commit 56a881b2b4957912055fdf053ef37ca2ea3606b8)

20 years agoSGI compiler fixes.
Herb Lewis [Tue, 26 Jun 2001 20:23:45 +0000 (20:23 +0000)]
SGI compiler fixes.
(This used to be commit 45bf995bf62aa6cc176d57e2f954cc2d379717ef)

20 years agoAdd check for working AF_LOCAL sockets, which are borken
Martin Pool [Tue, 26 Jun 2001 07:44:02 +0000 (07:44 +0000)]
Add check for working AF_LOCAL sockets, which are borken
on RH7.0 with _LARGEFILE64_SOURCE, and probably not
present on non-Unix systems like VMS.
(This used to be commit 8b0a5bc436fb44f5123d037b102f2d2c4d3287e8)

20 years agoAdded the basic tests of smb functionality for HEAD
Andrew Bartlett [Tue, 26 Jun 2001 07:41:40 +0000 (07:41 +0000)]
Added the basic tests of smb functionality for HEAD

This works with the new build farm system

Andrew Bartlett
(This used to be commit 542977bc4323e041512e91d7a38422e7abc4e5ae)

20 years agoEnsure we always have a valid pointer on unmarshalling an SD with zero
Jeremy Allison [Tue, 26 Jun 2001 06:31:55 +0000 (06:31 +0000)]
Ensure we always have a valid pointer on unmarshalling an SD with zero
ace entries.
(This used to be commit 274c0f5028d41175222dfaaf446e3ed8f5687a5f)

20 years agoPut an 0x in front of a hex number.
Tim Potter [Tue, 26 Jun 2001 06:26:05 +0000 (06:26 +0000)]
Put an 0x in front of a hex number.
(This used to be commit a48d480ce986ff1c00f2c17f30f23723ce0bb044)

20 years agoFixed bug introduced by changeover of security descriptor code from
Tim Potter [Tue, 26 Jun 2001 06:11:40 +0000 (06:11 +0000)]
Fixed bug introduced by changeover of security descriptor code from
malloc() to talloc().  Previously, creating an ACL containing zero ACEs
would return a non-NULL pointer to zero bytes of memory.  The talloc() code
would return a NULL pointer making the ACL a NULL ACL instead of an empty
one.  The difference is a NULL ACL allows all access and an empty ACL
denies all access.

We solve this by calling talloc(ctx, sizeof(SEC_ACE) * num_aces + 1).
(This used to be commit 89eaaafe7d266788609fab6951fd912c441b3a26)

20 years agoAlways use DOMAIN\user first that this is the more specific case.
Jeremy Allison [Tue, 26 Jun 2001 06:06:42 +0000 (06:06 +0000)]
Always use DOMAIN\user first that this is the more specific case.
(This used to be commit 52143c08536a5f5d888b78b4769c06f7a0a2992b)

20 years agofixed build
Andrew Tridgell [Tue, 26 Jun 2001 05:38:24 +0000 (05:38 +0000)]
fixed build

don't rush commits :)
(This used to be commit 442bf5cc9e6de7888f9a8cc06050f73ef880c4d9)

20 years agofall back to "unsigned" for uint32 on systems that don't have one
Andrew Tridgell [Tue, 26 Jun 2001 05:21:49 +0000 (05:21 +0000)]
fall back to "unsigned" for uint32 on systems that don't have one
(This used to be commit 4d0c3167099f461b46fafaa3a35b14babbadcb93)

20 years agoRemove warning about trapdoor systems for non-root mode.
Andrew Bartlett [Tue, 26 Jun 2001 03:45:45 +0000 (03:45 +0000)]
Remove warning about trapdoor systems for non-root mode.

Andrew Bartlett
(This used to be commit b33000cdc0cafd4888c3f07c56050626743abd14)

20 years agoEnsure numeric group or user names don't get misinterpreted.
Jeremy Allison [Mon, 25 Jun 2001 21:29:33 +0000 (21:29 +0000)]
Ensure numeric group or user names don't get misinterpreted.
(This used to be commit e88da9dcc79801028127bcbe328af001b58e653a)

20 years agoAdded Andrew's pam password change stuff. Needs some testing but looks good !
Jeremy Allison [Mon, 25 Jun 2001 20:44:04 +0000 (20:44 +0000)]
Added Andrew's pam password change stuff. Needs some testing but looks good !
(This used to be commit e94957d548745649ce04423dc6f16bbe3dd4f869)

20 years agoFixed stupid typo that would stop trusted domains working.
Jeremy Allison [Mon, 25 Jun 2001 19:08:30 +0000 (19:08 +0000)]
Fixed stupid typo that would stop trusted domains working.
(This used to be commit fa721b4adfbcac4827251b02f6af7f0b5211c104)

20 years agoCosmetic fixups found while playing with the server manager. Added support
Tim Potter [Mon, 25 Jun 2001 06:13:27 +0000 (06:13 +0000)]
Cosmetic fixups found while playing with the server manager.  Added support
for NET_SRV_SET_INFO rpc call which is made when double-clicking on a
computer in the server manager and changing the description.  We always
return NT_STATUS_NOPROBLEMO as NT doesn't seem to decode any error messages
passed back.

Maybe the changed comment string could be stored in a tdb and regurgitated
instead of the "server string" smb.conf parameter?
(This used to be commit d936ffedd90fe442f990c9ac2e172877f28d7230)

20 years agogot rid of the date headers off all text docs
Andrew Tridgell [Mon, 25 Jun 2001 03:36:09 +0000 (03:36 +0000)]
got rid of the date headers off all text docs
(This used to be commit 9d02041f0095d77753bd96bf070459547ec1339d)

20 years agofixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead...
Andrew Tridgell [Mon, 25 Jun 2001 02:53:13 +0000 (02:53 +0000)]
fixed usage of socklen_t and also tidied up SIG_ATOMIC_T, using a typedef instead of a define
(This used to be commit e2ecff419fdc0a0dc7551b33b377dc11061ef2a3)

20 years agomake sure we have BOOL in autoconf usage of util_sec.c
Andrew Tridgell [Mon, 25 Jun 2001 01:20:47 +0000 (01:20 +0000)]
make sure we have BOOL in autoconf usage of util_sec.c
(This used to be commit 72f63f5144ececdef31c659ab645eb71a88943b5)

20 years agoadded a -L option to smbpasswd to force it to run locally so we can test smbpasswd...
Andrew Tridgell [Mon, 25 Jun 2001 01:15:17 +0000 (01:15 +0000)]
added a -L option to smbpasswd to force it to run locally so we can test smbpasswd as non-root
(This used to be commit ab635202655712a05b812ff40550d00d00552853)

20 years ago- make the regresison test mode code build in by default. This should
Andrew Tridgell [Mon, 25 Jun 2001 00:46:34 +0000 (00:46 +0000)]
- make the regresison test mode code build in by default. This should
  allow us to have test targets without special configure options
- fixed make proto so that it actually does something
(This used to be commit 55109a752578e9389d853cb27ec17c2114ecff77)

20 years agofixed error
Simo Sorce [Sun, 24 Jun 2001 01:41:38 +0000 (01:41 +0000)]
fixed error
using wrong pointer to test and free s/str/s/
(This used to be commit 7e5a9860fad92fee79bcc20f2ea2a3728080dba2)

20 years agoLog debug before and after netbios names copied so we know if they've been
Jeremy Allison [Sat, 23 Jun 2001 20:01:23 +0000 (20:01 +0000)]
Log debug before and after netbios names copied so we know if they've been
(This used to be commit f8c121c69c9561f011a0e08a9d0beaf1cefd1667)

20 years agouhm some pointer went wrong
Simo Sorce [Sat, 23 Jun 2001 15:27:04 +0000 (15:27 +0000)]
uhm some pointer went wrong
(This used to be commit d0acacfc9df86abab24420f1807b4d5253e8c285)

20 years agohandle P_LIST parameters
Simo Sorce [Sat, 23 Jun 2001 15:01:34 +0000 (15:01 +0000)]
handle P_LIST parameters
(This used to be commit 26ab608c91c7357df3a79bc34111194f115de005)

20 years agofix compiler warnings
Simo Sorce [Sat, 23 Jun 2001 14:58:38 +0000 (14:58 +0000)]
fix compiler warnings
(This used to be commit 1959864490e79756257ba10431b188de78b8c8a7)

20 years agofix compiler warnings
Simo Sorce [Sat, 23 Jun 2001 14:13:32 +0000 (14:13 +0000)]
fix compiler warnings
(This used to be commit 7420e2f7898f1d141ba2af3eda07a67862fee842)

20 years agoAdded other_safe_chars to alpha_strcpy(). Needs testing but is a better
Jeremy Allison [Sat, 23 Jun 2001 07:22:16 +0000 (07:22 +0000)]
Added other_safe_chars to alpha_strcpy(). Needs testing but is a better
fix for the problem.
(This used to be commit e059fffd03a1382fb2b7059b6de369d9fc765a17)

20 years agoBetter fix for client name vulnarability.
Jeremy Allison [Sat, 23 Jun 2001 00:22:14 +0000 (00:22 +0000)]
Better fix for client name vulnarability.
(This used to be commit 17c3faa367328d186d10f59f08549de0c608b16a)

20 years agoFix for multibyte default service parameter from TAKAHASHI Motonobu, Samba Users...
Jeremy Allison [Fri, 22 Jun 2001 22:05:47 +0000 (22:05 +0000)]
Fix for multibyte default service parameter from TAKAHASHI Motonobu, Samba Users Group Japan
(This used to be commit a2da1f91c1b08414592d5f014c8539575d0e9637)

20 years agoFixed logic bug in timeout processing spotted by Ying Chen <>.
Jeremy Allison [Fri, 22 Jun 2001 20:56:52 +0000 (20:56 +0000)]
Fixed logic bug in timeout processing spotted by Ying Chen <>.
(This used to be commit 08c168242364bf4d415f49d134e507a7e234611b)

20 years agoFix for race condition found by Herb where we can end up with a NULL dbf.
Jeremy Allison [Fri, 22 Jun 2001 19:46:38 +0000 (19:46 +0000)]
Fix for race condition found by Herb where we can end up with a NULL dbf.
(This used to be commit 5cbb2106735ad0533198a83d62541cabd7beed20)

20 years agoFix from "Jim McDonough" <>" - when we use open_file_shared(),
Jeremy Allison [Fri, 22 Jun 2001 18:58:35 +0000 (18:58 +0000)]
Fix from "Jim McDonough" <>" - when we use open_file_shared(),
we need to close with close_file().
(This used to be commit 5b2ffd160f3b4b9607bb6fd6db1644af9254ad9e)

20 years agoadded the ability to test smbd safely as an ordinary user. The way it works is
Andrew Tridgell [Fri, 22 Jun 2001 15:14:45 +0000 (15:14 +0000)]
added the ability to test smbd safely as an ordinary user. The way it works is
that libsmb/ creates a local tcp socket then launches smbd as a subprocess
attached to that socket. smbd thinks it is being launched from inetd.

to use it do the following:

- compile with -DSMB_REGRESSION_TEST
- run like this (also works with smbtorture etc)
    export SMBD_TEST=1
    export LIBSMB_PROG=bin/smbd
    smbclient //server/share -Uuser%pass

obviously you need to setup a smb.conf etc. Using --prefix to configure
is useful.

The aim of all this stuff is to add a decent set of regression tests
to the build farm, so we know if smbd actually runs correctly on all the
platforms, not just builds. We can run smbtorture, masktest, locktest etc,
plus a bunch of smbclient scripts and any new tests we write.

This doesn't help much with nmbd (at least not yet) but its a good start.
(This used to be commit 7e8e6ae9a88c4d2587eb4e7f0501cd71bd36ebb2)

20 years agosync this function with 2.2 (single check for NULL parameter)
Gerald Carter [Fri, 22 Jun 2001 14:18:27 +0000 (14:18 +0000)]
sync this function with 2.2 (single check for NULL parameter)
(This used to be commit 3ab50e648d682080308d2db6bdb71eef0e303988)

20 years agoRemoved unused (and potentially crash-causing) free function.
Jeremy Allison [Fri, 22 Jun 2001 02:37:52 +0000 (02:37 +0000)]
Removed unused (and potentially crash-causing) free function.
(This used to be commit 54ea00fa870f258b885b18e8684caa8488948607)

20 years agoadd an ignore on proto.h
Andrew Tridgell [Fri, 22 Jun 2001 02:34:34 +0000 (02:34 +0000)]
add an ignore on proto.h
(This used to be commit 0dc9227156823f6a44e6a0260e091b972057baa3)

20 years agoauto-build proto.h if its not there, but don't make it depend
Andrew Tridgell [Fri, 22 Jun 2001 02:33:27 +0000 (02:33 +0000)]
auto-build proto.h if its not there, but don't make it depend
on anything. Delete proto.h from CVS
(This used to be commit 8a37df73ec4d8d1a7db60a49cd5d7d22c4704a88)

20 years agoCleanup of cli_lsa_enum_trust_dom(). talloc() doesn't like attempts to
Tim Potter [Fri, 22 Jun 2001 02:15:02 +0000 (02:15 +0000)]
Cleanup of cli_lsa_enum_trust_dom().  talloc() doesn't like attempts to
allocate 0 bytes.
(This used to be commit 465994cfbca72649474345bc057d436961cccf97)

20 years agoSpelling fix.
Tim Potter [Fri, 22 Jun 2001 01:58:19 +0000 (01:58 +0000)]
Spelling fix.
(This used to be commit 5f4889beb9311fd3912c3dfccf18fc9ab22b964c)

20 years agothe BAD_PTR idea in talloc.h is actually a bad idea - it means callers have no way...
Andrew Tridgell [Fri, 22 Jun 2001 01:56:16 +0000 (01:56 +0000)]
the BAD_PTR idea in talloc.h is actually a bad idea - it means callers have no way of telling if the call really failed
(This used to be commit 7a96ca313e2f6b5ad8a713babd3cac0bbcc4c399)

20 years agoUse cli_read_one() for reading DCE/RPC reply fragments. We need to check
Tim Potter [Fri, 22 Jun 2001 01:19:45 +0000 (01:19 +0000)]
Use cli_read_one() for reading DCE/RPC reply fragments.  We need to check
for and ignore ERRmoredata errors as the client library doesn't support
32-bit error messages.

Added some annotations for the RPC pipe code to make it a bit clearer
(This used to be commit f179e0ff61794073aedcf77544865ad2f18c6e6d)

20 years agoMerged cli_read_one() function for reading DCE/RPC reply fragments.
Tim Potter [Fri, 22 Jun 2001 01:09:40 +0000 (01:09 +0000)]
Merged cli_read_one() function for reading DCE/RPC reply fragments.
(This used to be commit 9e074bc2bf2df34048b67457623bb8219fb1e4d6)

20 years agoAndrew - please look this over. I've fixed a long standing (maybe 4-5
Jeremy Allison [Fri, 22 Jun 2001 00:57:59 +0000 (00:57 +0000)]
Andrew - please look this over. I've fixed a long standing (maybe 4-5
years old) bug when chainging a sessionsetup_and_X and tcon together.
The wrong username was being entered into the tdb, even though the
correct user was used for accessing files. This is related to the fact
that authorise_login() is not used for sessionsetup, but only for tcon
(This used to be commit 0187cd6aef7586d7ad4bdc70c50f3f2e7c69519c)

20 years agoadded some comments to make the cli read code clearer
Andrew Tridgell [Fri, 22 Jun 2001 00:42:53 +0000 (00:42 +0000)]
added some comments to make the cli read code clearer
(This used to be commit bbfbe03cc6166c23c42a704b5acaa19cbdbc39ce)

20 years agouse next_token instead of strtok.
Simo Sorce [Thu, 21 Jun 2001 23:33:12 +0000 (23:33 +0000)]
use next_token instead of strtok.
single elemnts of list cannot be longer than a pstring (1024B now)
(This used to be commit 72b749ec89fa3642c0b3330a5331be645f84e24c)

20 years agoOk - I misspoke.... mmap returns MAP_FAILED, not neccessarily -1 :-).
Jeremy Allison [Thu, 21 Jun 2001 19:56:25 +0000 (19:56 +0000)]
Ok - I misspoke.... mmap returns MAP_FAILED, not neccessarily -1 :-).
(This used to be commit 2d1c6d1f6b55a0a78eb8afbe16d2ad8b3253a220)

20 years agoWhen mmap fails it returns -1 *NOT NULL*.
Jeremy Allison [Thu, 21 Jun 2001 19:50:21 +0000 (19:50 +0000)]
When mmap fails it returns -1 *NOT NULL*.
This got regressed somehow.....
(This used to be commit b77c8b536d4b6d2162f4932227f01cffb730c645)