13 years agoA script to compare the differences in nTSecurityDescriptor between 2 hosts
Nadezhda Ivanova [Fri, 29 May 2009 11:45:24 +0000 (14:45 +0300)]
A script to compare the differences in nTSecurityDescriptor between 2 hosts

This script walks the schema, configuration and domain partitions of the locally
installed Ldb and a remote hosts and compares the descriptors disregarding the
difference in domain SID. The goal is to make sure a freshly provisioned Samba
has the correct descriptors so ACLs work correctly. It outputs the descriptors
in short SDDL, where the correct SIDs are to be replaced during provisioning.
Optionally it can be output as an LDIF file with the current local domain and
domain SIDs.

13 years agoDon't recurse in reopen_logs().
Andrew Bartlett [Thu, 11 Jun 2009 08:53:14 +0000 (18:53 +1000)]
Don't recurse in reopen_logs().

Use the state to avoid recursion in reopen_logs(), as DEBUG() can call
this function.

Andrew Bartlett

13 years agoImplement pdb_ads_set_aliasinfo
Volker Lendecke [Wed, 10 Jun 2009 21:56:51 +0000 (23:56 +0200)]
Implement pdb_ads_set_aliasinfo

13 years agopdb_default_aliasinfo is just fine for pdb_ads right now
Volker Lendecke [Wed, 10 Jun 2009 21:56:20 +0000 (23:56 +0200)]
pdb_default_aliasinfo is just fine for pdb_ads right now

13 years agoImplement pdb_ads_lookup_rids
Volker Lendecke [Wed, 10 Jun 2009 10:54:05 +0000 (12:54 +0200)]
Implement pdb_ads_lookup_rids

13 years agoFix a segfault in pdb_ads_delete_user()
Volker Lendecke [Wed, 10 Jun 2009 09:48:31 +0000 (11:48 +0200)]
Fix a segfault in pdb_ads_delete_user()

If a user comes from the passdb cache, priv is NULL

13 years agos3: Prepare the first set of SMB_VFS_CREATE_FILE callers to take an smb_filename...
Tim Prouty [Wed, 10 Jun 2009 17:37:57 +0000 (10:37 -0700)]
s3: Prepare the first set of SMB_VFS_CREATE_FILE callers to take an smb_filename struct

Some of the callers required minimal changes, while others
(copy_internals) required significant changes.  The task is simplified
a little bit because we are able to do operations and checks on the
base_name when a stream isn't used.

This patch should cause no functional changes.

Volker, Jeremy: Please check

13 years agos3: Add utility function for copying an smb_filename struct
Tim Prouty [Wed, 10 Jun 2009 00:04:10 +0000 (17:04 -0700)]
s3: Add utility function for copying an smb_filename struct

13 years agos3: Remove the now unused CFF_DOS_PATH flag
Tim Prouty [Wed, 10 Jun 2009 17:49:21 +0000 (10:49 -0700)]
s3: Remove the now unused CFF_DOS_PATH flag
All paths are now unix paths, making this flag useless.

This flags argument is now unused and can be safely removed.

13 years agos3: Remove unix_convert handling from createfile implementations
Tim Prouty [Sat, 6 Jun 2009 03:24:17 +0000 (20:24 -0700)]
s3: Remove unix_convert handling from createfile implementations

13 years agos3: Make all callers of SMB_VFS_CREATEFILE call unix_convert first
Tim Prouty [Fri, 5 Jun 2009 01:39:55 +0000 (18:39 -0700)]
s3: Make all callers of SMB_VFS_CREATEFILE call unix_convert first

This step is a requirement to change SMB_VFS_CREATEFILE to take an
smb_filename struct.

13 years agos3: Remove extraneous calls to unix_convert
Tim Prouty [Wed, 10 Jun 2009 16:59:42 +0000 (09:59 -0700)]
s3: Remove extraneous calls to unix_convert

Not only are these unnecessary in spirit because unlink_internals
calls unix_convert, but in practice the return value is simply being
ignored right now.

13 years agos3: Remove unused stat structs being passed to SMB_VFS_CREATE_FILE
Tim Prouty [Fri, 5 Jun 2009 23:13:58 +0000 (16:13 -0700)]
s3: Remove unused stat structs being passed to SMB_VFS_CREATE_FILE

13 years agos3-libwbclient: fix unresolved symbols in libwbclient.
Günther Deschner [Wed, 10 Jun 2009 19:23:12 +0000 (21:23 +0200)]
s3-libwbclient: fix unresolved symbols in libwbclient.

Kai, please check.


13 years agolib-util: move set_blocking() call into own file.
Günther Deschner [Wed, 10 Jun 2009 19:22:33 +0000 (21:22 +0200)]
lib-util: move set_blocking() call into own file.


13 years agoMake ctemp async. Fix the test to pass against W2K3.
Jeremy Allison [Wed, 10 Jun 2009 18:58:00 +0000 (11:58 -0700)]
Make ctemp async. Fix the test to pass against W2K3.

13 years agos3-build: Fix make test_shlibs and test_nss_modules.
Günther Deschner [Wed, 10 Jun 2009 15:25:12 +0000 (17:25 +0200)]
s3-build: Fix make test_shlibs and test_nss_modules.


13 years agomount.cifs: explicitly handle non AF_INET/AF_INET6 addresses
Jeff Layton [Wed, 10 Jun 2009 13:00:21 +0000 (09:00 -0400)]
mount.cifs: explicitly handle non AF_INET/AF_INET6 addresses

If we get a non-AF_INET(6) address, then just skip it and try the next
one in the list.

Signed-off-by: Jeff Layton <>
13 years agos3/docs: Fix typos.
Karolin Seeger [Wed, 10 Jun 2009 06:39:35 +0000 (08:39 +0200)]
s3/docs: Fix typos.

Fix typos reported by OPC oota <t-oota [at]>.


13 years agofixed some places where RPC-SECRETS needs to be changed to RPC-LSA-SECRETS
Andrew Tridgell [Wed, 10 Jun 2009 02:24:12 +0000 (12:24 +1000)]
fixed some places where RPC-SECRETS needs to be changed to RPC-LSA-SECRETS

this copes with a rename of SECRETS to LSA-SECRETS in an earlier patch
by gd

13 years agofixed the encoding/decoding of the reverse attribute for server side sort
Andrew Tridgell [Wed, 10 Jun 2009 01:45:13 +0000 (11:45 +1000)]
fixed the encoding/decoding of the reverse attribute for server side sort

13 years agoadded asn1 functions for handling booleans in a simple context
Andrew Tridgell [Wed, 10 Jun 2009 01:44:47 +0000 (11:44 +1000)]
added asn1 functions for handling booleans in a simple context

13 years agoClarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Donald T. Davis [Wed, 10 Jun 2009 01:38:27 +0000 (11:38 +1000)]
Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005

Compiled with Andrew over a series of phone calls and gobby sessions,
with the aim of documenting Kerberos requirements for Samba to us an
alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <>
13 years agoRemove copy of kerberos-notes.txt added in incorrect location
Andrew Bartlett [Wed, 10 Jun 2009 01:37:49 +0000 (11:37 +1000)]
Remove copy of kerberos-notes.txt added in incorrect location

13 years agoClarify and expand the Kerberos notes made by Andrew Bartlett in 2005
Donald T. Davis [Wed, 10 Jun 2009 01:16:09 +0000 (11:16 +1000)]
Clarify and expand the Kerberos notes made by Andrew Bartlett in 2005

Compiled with Andrew over a series of phone calls and gobby sessions
with Andrew, with the aim of documenting Kerberos requirements for
Samba to us an alternate (ie, MIT) Kerberos library.

Signed-off-by: Andrew Bartlett <>
13 years agofixed server side sort control
Andrew Tridgell [Wed, 10 Jun 2009 00:33:53 +0000 (10:33 +1000)]
fixed server side sort control

when sorting a record that does not have the requested sort attribute
then put those records last in the sort result

13 years agofixed server side sorting of case-insensitive strings
Andrew Tridgell [Wed, 10 Jun 2009 00:13:55 +0000 (10:13 +1000)]
fixed server side sorting of case-insensitive strings

The sort module uses ldb_comparison_fold() as the comparison function
for case-insensitive attributes. In other places the function is being
used to produce a boolean, but for sorting we care about ordering.

The n1 - n2 return was sorting by length, not value

13 years agoIf there are no mods, don't bother the ldap server
Volker Lendecke [Tue, 9 Jun 2009 20:09:41 +0000 (22:09 +0200)]
If there are no mods, don't bother the ldap server

13 years agoSome more fields in pdb_ads_init_ads_from_sam()
Volker Lendecke [Tue, 9 Jun 2009 20:09:14 +0000 (22:09 +0200)]
Some more fields in pdb_ads_init_ads_from_sam()

13 years agoFix installation path of the subunit python modules.
Timur I Bakeyev [Tue, 9 Jun 2009 18:45:03 +0000 (20:45 +0200)]
Fix installation path of the subunit python modules.

Signed-off-by: Jelmer Vernooij <>
13 years agos4-tests: Add separate variable for tap2subunit.
Jelmer Vernooij [Tue, 9 Jun 2009 16:09:27 +0000 (18:09 +0200)]
s4-tests: Add separate variable for tap2subunit.

13 years agoDo not pull samAccountName twice
Volker Lendecke [Tue, 9 Jun 2009 19:46:04 +0000 (21:46 +0200)]
Do not pull samAccountName twice

13 years agos3:smbd: only check the next_status for related requests
Stefan Metzmacher [Tue, 9 Jun 2009 17:48:08 +0000 (19:48 +0200)]
s3:smbd: only check the next_status for related requests


13 years agos3:smbd: response with the same SMB2 flags as given by the client
Stefan Metzmacher [Tue, 9 Jun 2009 17:46:29 +0000 (19:46 +0200)]
s3:smbd: response with the same SMB2 flags as given by the client

...but also add the response flag.


13 years agos3:smbd: only pass the chained file handle for related compounded SMB2 requests
Stefan Metzmacher [Tue, 9 Jun 2009 17:31:15 +0000 (19:31 +0200)]
s3:smbd: only pass the chained file handle for related compounded SMB2 requests


13 years agos3:smbd: make sure we pad compounded SMB2 responses to 8 bytes
Stefan Metzmacher [Tue, 9 Jun 2009 17:21:26 +0000 (19:21 +0200)]
s3:smbd: make sure we pad compounded SMB2 responses to 8 bytes


13 years agos3:smbd: skip file handle checks for SMB2 compounded requests
Stefan Metzmacher [Tue, 9 Jun 2009 16:47:26 +0000 (18:47 +0200)]
s3:smbd: skip file handle checks for SMB2 compounded requests


13 years agos3:smbd: more validation of the incoming SMB2 requests
Stefan Metzmacher [Mon, 8 Jun 2009 11:30:32 +0000 (13:30 +0200)]
s3:smbd: more validation of the incoming SMB2 requests


13 years agos3:smbd: for now ignore all non NBT Session Message requests for SMB2
Stefan Metzmacher [Mon, 8 Jun 2009 11:15:00 +0000 (13:15 +0200)]
s3:smbd: for now ignore all non NBT Session Message requests for SMB2


13 years agos3:smbd: don't include 1 byte padding for the dynamic buffer of SMB2 responses
Stefan Metzmacher [Tue, 9 Jun 2009 15:06:40 +0000 (17:06 +0200)]
s3:smbd: don't include 1 byte padding for the dynamic buffer of SMB2 responses

It seems that Windows 2008 and Windows 7 doesn't do this anymore.


13 years agoSMB2-COMPOUND: add some tests for invalid requests
Stefan Metzmacher [Tue, 9 Jun 2009 16:13:53 +0000 (18:13 +0200)]
SMB2-COMPOUND: add some tests for invalid requests

TODO: check why the INVALID1 tests fails with --signing=required.


13 years agos4:smb2srv: don't allow the related flag on the first request in a compounded chain
Stefan Metzmacher [Tue, 9 Jun 2009 17:32:30 +0000 (19:32 +0200)]
s4:smb2srv: don't allow the related flag on the first request in a compounded chain


13 years agos4: smbcli_transport_send hit the socket right away if possible
Sam Liddicott [Tue, 9 Jun 2009 11:51:44 +0000 (12:51 +0100)]
s4: smbcli_transport_send hit the socket right away if possible

[Metze; "make test" on git master outputs exactly the same test summary
with our without this patch (apart from the "using seed" lines)]

If the transport socket is writable, then push the queue along
rather than wait until the caller returns back to the tevent loop.

This strategy keeps the sockets piping hot, and is particularly good
for cases where reading requests from one socket causes lots of
writes on another socket, or where lots of writes are made in a batch.

It doesn't matter if the socket is not writeable yet, packet_queue_run
will return quite cheaply in such a case.

Signed-off-by: Sam Liddicott <>
Signed-off-by: Stefan Metzmacher <>
13 years agonet: Only use the in memory ccache when not already using a kerberos ticket in net ads
Kai Blin [Tue, 9 Jun 2009 16:05:50 +0000 (18:05 +0200)]
net: Only use the in memory ccache when not already using a kerberos ticket in net ads

13 years agos4:torture: add SMB2-COMPOUND test
Stefan Metzmacher [Mon, 8 Jun 2009 14:26:57 +0000 (16:26 +0200)]
s4:torture: add SMB2-COMPOUND test


13 years agos4:smb2srv: correctly fail remaining compounded requests after a failure
Stefan Metzmacher [Tue, 9 Jun 2009 14:48:25 +0000 (16:48 +0200)]
s4:smb2srv: correctly fail remaining compounded requests after a failure


13 years agos4:smb2srv: remove old TODO comment, we already check the seqnum
Stefan Metzmacher [Tue, 9 Jun 2009 14:35:25 +0000 (16:35 +0200)]
s4:smb2srv: remove old TODO comment, we already check the seqnum


13 years agos4:smb2srv: fix handling of multiple compounded requests
Stefan Metzmacher [Tue, 9 Jun 2009 14:34:52 +0000 (16:34 +0200)]
s4:smb2srv: fix handling of multiple compounded requests


13 years agos4:smb2srv: remove the chained file handle on close
Stefan Metzmacher [Tue, 9 Jun 2009 14:33:46 +0000 (16:33 +0200)]
s4:smb2srv: remove the chained file handle on close


13 years agos4:libcli/smb2: add smb2_transport_credits_ask_num()
Stefan Metzmacher [Mon, 8 Jun 2009 15:59:26 +0000 (17:59 +0200)]
s4:libcli/smb2: add smb2_transport_credits_ask_num()


13 years agos4:libcli/smb2: only add the 1 byte dynamic buffer padding for non compounded requests
Stefan Metzmacher [Tue, 9 Jun 2009 13:04:53 +0000 (15:04 +0200)]
s4:libcli/smb2: only add the 1 byte dynamic buffer padding for non compounded requests


13 years agos4:libcli/smb2: add support sending compounded requests
Stefan Metzmacher [Mon, 8 Jun 2009 14:24:27 +0000 (16:24 +0200)]
s4:libcli/smb2: add support sending compounded requests


13 years agos4:libcli/smb2: prepare SMB2 signing code for compounded requests
Stefan Metzmacher [Tue, 9 Jun 2009 12:52:44 +0000 (14:52 +0200)]
s4:libcli/smb2: prepare SMB2 signing code for compounded requests


13 years agos3-net: fix "net ads testjoin".
Günther Deschner [Tue, 9 Jun 2009 13:41:44 +0000 (15:41 +0200)]
s3-net: fix "net ads testjoin".

This always needs to use machine account credentials.

Kai, please check.


13 years agos4-selftest: change rpc.secrets to rpc.lsa.secrets here as well.
Günther Deschner [Tue, 9 Jun 2009 13:31:51 +0000 (15:31 +0200)]
s4-selftest: change rpc.secrets to rpc.lsa.secrets here as well.


13 years agoNo need to free twice -- thanks gd :-)
Volker Lendecke [Tue, 9 Jun 2009 13:28:21 +0000 (15:28 +0200)]
No need to free twice -- thanks gd :-)

13 years agoImplement pdb_ads_[add|del]_groupmem
Volker Lendecke [Tue, 9 Jun 2009 13:24:06 +0000 (15:24 +0200)]
Implement pdb_ads_[add|del]_groupmem

13 years agoMake "net sam [add|del]mem" work for domain groups
Volker Lendecke [Tue, 9 Jun 2009 13:23:33 +0000 (15:23 +0200)]
Make "net sam [add|del]mem" work for domain groups

13 years agolsa: use the lsa access masks in idl.
Günther Deschner [Tue, 9 Jun 2009 13:14:30 +0000 (15:14 +0200)]
lsa: use the lsa access masks in idl.


13 years agoImplement pdb_ads_delete_dom_group
Volker Lendecke [Tue, 9 Jun 2009 12:46:55 +0000 (14:46 +0200)]
Implement pdb_ads_delete_dom_group

13 years agoImplement "net sam deletedomaingroup"
Volker Lendecke [Tue, 9 Jun 2009 12:46:43 +0000 (14:46 +0200)]
Implement "net sam deletedomaingroup"

13 years agos4-smbtorture: rename SECRETS to LSA-SECRETS.
Günther Deschner [Tue, 9 Jun 2009 10:06:19 +0000 (12:06 +0200)]
s4-smbtorture: rename SECRETS to LSA-SECRETS.


13 years agoIt seems that IRIX doesn't have IOV_MAX
Andrew Tridgell [Tue, 9 Jun 2009 04:54:15 +0000 (14:54 +1000)]
It seems that IRIX doesn't have IOV_MAX

13 years agotry to get PICFLAG right for HP-UX with gcc
Andrew Tridgell [Tue, 9 Jun 2009 04:18:58 +0000 (14:18 +1000)]
try to get PICFLAG right for HP-UX with gcc

13 years agowork around conflict in pidfile() prototype for heimdal on NetBSD5
Andrew Tridgell [Tue, 9 Jun 2009 04:11:20 +0000 (14:11 +1000)]
work around conflict in pidfile() prototype for heimdal on NetBSD5

13 years agofixed socket wrapper to determine family from the right structure
Andrew Tridgell [Tue, 9 Jun 2009 03:33:09 +0000 (13:33 +1000)]
fixed socket wrapper to determine family from the right structure

In convert_in_un_remote() the socket family can be accessed either as
si->family or inaddr->sa_family. We were using the si->family to
determine how to cast the inaddr structure, but if si->family !=
inaddr->sa_family then we will incorrectly be casting a in6 structure
as in4 or vice-versa.

13 years agoReplace the "ipv4" specific strings in libcli/cldap/cldap.c with "ip". CLDAP can
Jeremy Allison [Mon, 8 Jun 2009 22:21:48 +0000 (15:21 -0700)]
Replace the "ipv4" specific strings in libcli/cldap/cldap.c with "ip". CLDAP can
run over IPv4/IPv6, even though some of the netlogon messages are IPv4 specific.
Fix the new ads_cldap_netlogon() to be IPv6/IPv4 agnostic. This compiles but
I don't have a good test env. for this (although as the previous code was
*completely* broken over IPv6 this will expose previously hidden bugs if it's broken :-).

13 years agoImplement pdb_ads_enum_group_members
Volker Lendecke [Mon, 8 Jun 2009 21:57:54 +0000 (23:57 +0200)]
Implement pdb_ads_enum_group_members

13 years agoMake "net ads listmem" also work for domain groups
Volker Lendecke [Mon, 8 Jun 2009 21:57:11 +0000 (23:57 +0200)]
Make "net ads listmem" also work for domain groups

13 years agonsswitch: try to fix segfault in nss_winbind on NetBSD found by torture test.
Günther Deschner [Mon, 8 Jun 2009 21:31:25 +0000 (23:31 +0200)]
nsswitch: try to fix segfault in nss_winbind on NetBSD found by torture test.


13 years agoFix some nonempty blank lines
Volker Lendecke [Mon, 8 Jun 2009 21:11:47 +0000 (23:11 +0200)]
Fix some nonempty blank lines

13 years agos3-lsa: remove old code that we cannot even compile anymore.
Günther Deschner [Mon, 8 Jun 2009 20:58:16 +0000 (22:58 +0200)]
s3-lsa: remove old code that we cannot even compile anymore.


13 years agos4-smbtorture: when testing RPC-SAMR-LARGE-DC its fine to just close the objects.
Günther Deschner [Mon, 8 Jun 2009 20:41:23 +0000 (22:41 +0200)]
s4-smbtorture: when testing RPC-SAMR-LARGE-DC its fine to just close the objects.


13 years agonss_wrapper: fix typo in testsuite.
Günther Deschner [Mon, 8 Jun 2009 20:33:51 +0000 (22:33 +0200)]
nss_wrapper: fix typo in testsuite.


13 years agos4-smbtorture: add test_QueryDisplayInfo_level to RPC-SAMR-LARGE-DC.
Günther Deschner [Mon, 8 Jun 2009 08:24:48 +0000 (10:24 +0200)]
s4-smbtorture: add test_QueryDisplayInfo_level to RPC-SAMR-LARGE-DC.


13 years agolibsamba-util: Fix soversion.
Jelmer Vernooij [Mon, 8 Jun 2009 20:43:36 +0000 (22:43 +0200)]
libsamba-util: Fix soversion.

13 years agopython: Fix samba4.dcerpc.rpcecho.RpcEchoTests.test_surrounding test.
Jelmer Vernooij [Mon, 8 Jun 2009 20:41:39 +0000 (22:41 +0200)]
python: Fix samba4.dcerpc.rpcecho.RpcEchoTests.test_surrounding test.

13 years agoMake open_udp_socket() IPv6 clean. Trying to fix bug #6437 - Unable to join IPv6...
Jeremy Allison [Mon, 8 Jun 2009 20:26:39 +0000 (13:26 -0700)]
Make open_udp_socket() IPv6 clean. Trying to fix bug #6437 - Unable to join IPv6-only ads domain.
Avaiting feedback from submitter before backport to 3.4 and earlier.

13 years agos4:heimdal: fix build on FreeBSD
Björn Jacke [Mon, 8 Jun 2009 20:11:33 +0000 (22:11 +0200)]
s4:heimdal: fix build on FreeBSD

Patch from Timur I. Bakeyev sent to samba-technical:

Heimdal requires openpty() presence. FreeBSD has in in standard libc, so
autodetection works, but compilation fails, as declaration of this function is

This patch adds proper header detection and inclusion for openpty().

13 years agos3-spoolss: add server-support for queries for the "all" architecture in printdriver...
Günther Deschner [Wed, 13 May 2009 13:35:55 +0000 (15:35 +0200)]
s3-spoolss: add server-support for queries for the "all" architecture in printdriver enum calls.


13 years agos4-smbtorture: also test for "all" architecture in enum driver tests in RPC-SPOOLSS.
Günther Deschner [Wed, 13 May 2009 13:35:25 +0000 (15:35 +0200)]
s4-smbtorture: also test for "all" architecture in enum driver tests in RPC-SPOOLSS.


13 years agoFix two 64-bit warnings
Volker Lendecke [Mon, 8 Jun 2009 19:13:24 +0000 (21:13 +0200)]
Fix two 64-bit warnings

13 years agoImplement pdb_[add|del]aliasmem
Volker Lendecke [Mon, 8 Jun 2009 18:37:50 +0000 (20:37 +0200)]
Implement pdb_[add|del]aliasmem

13 years agoAdd tlda_add_mod_str
Volker Lendecke [Mon, 8 Jun 2009 18:36:49 +0000 (20:36 +0200)]
Add tlda_add_mod_str

13 years agoDo not use a variable format string
Volker Lendecke [Mon, 8 Jun 2009 18:15:56 +0000 (20:15 +0200)]
Do not use a variable format string

13 years agoImplement pdb_ads_enum_aliasmem
Volker Lendecke [Mon, 8 Jun 2009 18:04:49 +0000 (20:04 +0200)]
Implement pdb_ads_enum_aliasmem

13 years agoPass a talloc_ctx to pdb_enum_aliasmem
Volker Lendecke [Mon, 8 Jun 2009 17:43:01 +0000 (19:43 +0200)]
Pass a talloc_ctx to pdb_enum_aliasmem

13 years agoImplement pdb_ads_delete_alias
Volker Lendecke [Sun, 7 Jun 2009 21:32:36 +0000 (23:32 +0200)]
Implement pdb_ads_delete_alias

13 years agoImplement pdb_ads_create_dom_group()
Volker Lendecke [Sun, 7 Jun 2009 21:29:58 +0000 (23:29 +0200)]
Implement pdb_ads_create_dom_group()

13 years agos4-smbtorture: fix test_ReportEventLog in RPC-EVENTLOG.
Günther Deschner [Wed, 8 Apr 2009 19:29:16 +0000 (21:29 +0200)]
s4-smbtorture: fix test_ReportEventLog in RPC-EVENTLOG.


13 years agos3-examples: fix usage for eventlog example script.
Günther Deschner [Mon, 27 Apr 2009 09:14:44 +0000 (11:14 +0200)]
s3-examples: fix usage for eventlog example script.


13 years agos3-samr: fix enum_acb_mask type (uint32 instead of uint16).
Günther Deschner [Mon, 8 Jun 2009 15:32:10 +0000 (17:32 +0200)]
s3-samr: fix enum_acb_mask type (uint32 instead of uint16).


13 years agos3-rpcclient: allow to set query size for samr enum calls.
Günther Deschner [Mon, 8 Jun 2009 13:48:24 +0000 (15:48 +0200)]
s3-rpcclient: allow to set query size for samr enum calls.


13 years use LIBDL as make variable instead of a shell variable
Stefan Metzmacher [Mon, 8 Jun 2009 09:51:36 +0000 (11:51 +0200)] use LIBDL as make variable instead of a shell variable


13 years agoFix make test_pam_modules
Timur I. Bakeyev [Sun, 7 Jun 2009 17:05:23 +0000 (17:05 +0000)]
Fix make test_pam_modules

In Samba3 there is a very handy Makefile target 'test_pam_modules'. It let
quickly veryfy, that obtained PAM module actually is loadable and doesn't
miss any dependency libs. the only problem that on FreeBSD it doesn't work
OOTB, as it unconditionally adds -ldl to the list of libraries when FreeBSD
doesn't have it and doesn't need it.

This small patch fixes the problem for FreeBSD and, I hope, still valid
for othe systems, where -ldl is required. Has to be tested there though.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>
13 years agoSmall fix to SMB_LIBRARY macro
Timur I. Bakeyev [Sun, 7 Jun 2009 14:16:51 +0000 (14:16 +0000)]
Small fix to SMB_LIBRARY macro

It seems, that SMB_LIBRARY macro has small bug in the logic, when showing
if shall the SHARED version of the library be build.

If the default value is given as a parameter, it reports "yes" when library
is going to be build(?).

This small patch makes report consistent.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>
13 years agoSIGRTMIN additions
Timur I. Bakeyev [Sun, 7 Jun 2009 15:46:07 +0000 (15:46 +0000)]
SIGRTMIN additions

In addition to [FreeBSD 14] there is another place, where we (re)define
SIGRTMIN - in SMB_IF_RTSIGNAL_BUG macro in /source3/m4/aclocal.m4.

Here is another small patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>
13 years agoSet SIGRTMIN to NSIG
Timur I. Bakeyev [Sun, 7 Jun 2009 13:58:38 +0000 (13:58 +0000)]

In the includes we define SIGRTMIN to 32 if it's not defined already. This
value could be fairly low and it's better to use NSIG(number of defined
signals) as the lower mark for the available signals.

We have similar defenition in the source3/smbd/aio.c, which can be safely
removed, as it comes from includes.h then.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>
13 years agoCheck for dmalloc at the end of the configure
Timur I. Bakeyev [Sun, 7 Jun 2009 12:50:15 +0000 (12:50 +0000)]
Check for dmalloc at the end of the configure

Enabling dmalloc in Samba3 build leads to the wrong detection of the
strndup() function - there isn't one in FreeBSD prior to 7.2, but
dmalloc defines it, so, farther tests with -ldmalloc added wrongly
find it. the cheapest fix is to move dmalloc detection and inclusion
to the bottom of configure, so it can't affect detection of the system

Here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>
13 years agoAdd langinfo.h to the system/locale.h
Timur I. Bakeyev [Sun, 7 Jun 2009 12:39:22 +0000 (12:39 +0000)]
Add langinfo.h to the system/locale.h

This patch for Samba4. It's not really inspired by any real need, just
for the consistency. We define replace/system/locale.h as a generic
header, that includes all locale related headers and we are using
nl_langinfo at least in Samba3. So, it would be consistent to add yet
another locale-related header to the set of locale.h headers.

Here is the patch.

With regards,
Timur Bakeyev.

Signed-off-by: Stefan Metzmacher <>