Jelmer Vernooij [Sun, 4 Mar 2012 15:50:28 +0000 (16:50 +0100)]
selftest.pl: Remove unused --verbose option.
Jelmer Vernooij [Sun, 4 Mar 2012 15:50:21 +0000 (16:50 +0100)]
selftest.py: Remove unused --verbose option.
Jelmer Vernooij [Sun, 4 Mar 2012 15:49:30 +0000 (16:49 +0100)]
selftest.py: Remove unused code, reconcile signal handlers.
Jelmer Vernooij [Sun, 4 Mar 2012 15:39:43 +0000 (16:39 +0100)]
selftest.py: Fix handling of boolean options.
Jelmer Vernooij [Sun, 4 Mar 2012 15:32:56 +0000 (16:32 +0100)]
selftest.py: Fix signal handling.
Jelmer Vernooij [Sun, 4 Mar 2012 15:30:26 +0000 (16:30 +0100)]
Run selftest.py tests.
Jelmer Vernooij [Sun, 4 Mar 2012 15:22:34 +0000 (16:22 +0100)]
selftest: Now runs again for tests that use environment 'none'.
Jelmer Vernooij [Sun, 4 Mar 2012 15:01:18 +0000 (16:01 +0100)]
selftest.target: Add NoneTarget.
Jelmer Vernooij [Sun, 4 Mar 2012 14:11:36 +0000 (15:11 +0100)]
selftest.py: Finish conversion to python - now loads without syntax errors.
Jelmer Vernooij [Sun, 4 Mar 2012 13:55:39 +0000 (14:55 +0100)]
selftest.testlist: Add RestrictedTestManager.from_path.
Jelmer Vernooij [Sun, 4 Mar 2012 04:00:55 +0000 (05:00 +0100)]
selftest: More work on conversion to Python.
Jelmer Vernooij [Sun, 4 Mar 2012 03:19:26 +0000 (04:19 +0100)]
selftest.testlist: Add docstrings.
Jelmer Vernooij [Sun, 4 Mar 2012 03:16:16 +0000 (04:16 +0100)]
selftest.testlist: Add manager for restricted test lists.
Jelmer Vernooij [Sun, 4 Mar 2012 03:01:28 +0000 (04:01 +0100)]
Add TestListFilter definition.
Jelmer Vernooij [Sun, 4 Mar 2012 02:24:10 +0000 (03:24 +0100)]
selftest.testlist: Add read_testlist.
Jelmer Vernooij [Sun, 4 Mar 2012 02:12:35 +0000 (03:12 +0100)]
selftest.testlist: Add read_test_regexes.
Jelmer Vernooij [Sun, 4 Mar 2012 02:02:53 +0000 (03:02 +0100)]
selftest: Add testlist management module.
Jelmer Vernooij [Sun, 4 Mar 2012 01:38:15 +0000 (02:38 +0100)]
selftest.target: Add Environment.get_vars.
Jelmer Vernooij [Sun, 4 Mar 2012 01:37:42 +0000 (02:37 +0100)]
selftest: Add tests for trying to reuse an environment that has gone down.
Jelmer Vernooij [Sun, 4 Mar 2012 01:36:28 +0000 (02:36 +0100)]
selftest: Add tests for NoneEnvironment.
Jelmer Vernooij [Sun, 4 Mar 2012 01:32:26 +0000 (02:32 +0100)]
selftest.target: Test that environments are reused.
Jelmer Vernooij [Sun, 4 Mar 2012 01:31:32 +0000 (02:31 +0100)]
selftest.target: Add tests for get_running_env.
Jelmer Vernooij [Sun, 4 Mar 2012 01:30:42 +0000 (02:30 +0100)]
selftest.target: Add tests for getlog_env.
Jelmer Vernooij [Sun, 4 Mar 2012 01:29:34 +0000 (02:29 +0100)]
selftest.target: Add tests for check.
Jelmer Vernooij [Sun, 4 Mar 2012 01:28:06 +0000 (02:28 +0100)]
selftest.target: Add tests for setup.
Jelmer Vernooij [Sun, 4 Mar 2012 01:18:27 +0000 (02:18 +0100)]
selftest: Add base classes for Target/Environment and their management.
Jelmer Vernooij [Sun, 4 Mar 2012 01:17:52 +0000 (02:17 +0100)]
selftest.socket_wrapper: interface is an integer.
Jelmer Vernooij [Sun, 4 Mar 2012 00:36:16 +0000 (01:36 +0100)]
selftest.socket_wrapper: Add basic unit tests.
Jelmer Vernooij [Sun, 4 Mar 2012 00:36:01 +0000 (01:36 +0100)]
selftest.socket_wrapper: Add docstrings.
Jelmer Vernooij [Sun, 4 Mar 2012 00:31:44 +0000 (01:31 +0100)]
Add test infrastructure for selftest.
Jelmer Vernooij [Sun, 4 Mar 2012 00:30:58 +0000 (01:30 +0100)]
selftest: Add python version of socket wrapper utilities.
Jelmer Vernooij [Sun, 4 Mar 2012 00:24:10 +0000 (01:24 +0100)]
selftest: Add selftest.py.
Jelmer Vernooij [Sun, 4 Mar 2012 00:05:23 +0000 (01:05 +0100)]
kcc: Improve formatting of Python code to be more consistent with our other code.
Michael Adam [Fri, 2 Mar 2012 22:51:26 +0000 (23:51 +0100)]
libcli:smb: define SMB2_HDR_FLAG_REPLAY_OPERATION
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sun Mar 4 15:10:38 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 3 Mar 2012 20:40:27 +0000 (21:40 +0100)]
s3: Fix some && vs & warnings
Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Sun Mar 4 13:31:25 CET 2012 on sn-devel-104
Andrew Bartlett [Sun, 4 Mar 2012 07:34:34 +0000 (18:34 +1100)]
selftest: Rework Samba3.pm process termination
We now store the timelimit child PID in memory, and confirm that the child has exited
with both waitpid() and kill(0, $pid).
By calling Samba::cleanup_child() we get exit status information.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun Mar 4 11:51:12 CET 2012 on sn-devel-104
Andrew Bartlett [Sun, 4 Mar 2012 07:32:44 +0000 (18:32 +1100)]
selftest: Rework Samba4.pm process termination.
We now double-check the waitpid() result with kill(0, $pid)
We now also send a SIGTERM, then a SIGKILL.
Andrew Bartlett
Andrew Bartlett [Sun, 4 Mar 2012 07:10:35 +0000 (18:10 +1100)]
selftest: Fix waitpid termination test
Andrew Bartlett [Sun, 4 Mar 2012 06:30:45 +0000 (17:30 +1100)]
selftest: Use fork()/exec() rather than system()
This follows the Samba3.pm model for starting child processes is to
use fork()/exec(). This reduces the number of processes being created
by selftest.pl, and gives us more information about the child process
and the running state in the parent.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Mar 2012 07:22:10 +0000 (18:22 +1100)]
s3-winbindd: Add stdin handler for winbind
This will help avoid runaway processes in the test env, particularly when
the whole selftest.pl is killed.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Mar 2012 07:21:09 +0000 (18:21 +1100)]
s3-nmbd: Add stdin handler for nmbd
This will help avoid runaway processes in the test env, particularly
when the whole selftest.pl is killed.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Mar 2012 08:32:56 +0000 (19:32 +1100)]
change low FDs are handled in Samba
We now only close fds 0, 1, 2 when we are a forked daemon, and take
care not to close a file descriptor that we might need for foreground
stdin monitoring.
This should fix stdout logging in the lsa and epmapper deamons (ie in
make test).
Andrew Bartlett
Matthieu Patou [Sun, 4 Mar 2012 05:20:59 +0000 (21:20 -0800)]
s3: don't replace the error message if already defined
Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Sun Mar 4 10:13:24 CET 2012 on sn-devel-104
Matthieu Patou [Fri, 2 Mar 2012 00:29:15 +0000 (16:29 -0800)]
s3: print a nice warning when HAVE_ADS is not enabled but you still try to do net rpc keytab vampire
Jelmer Vernooij [Sun, 4 Mar 2012 04:08:26 +0000 (05:08 +0100)]
selftest: Remove unused vde functions.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Mar 4 07:54:51 CET 2012 on sn-devel-104
Jelmer Vernooij [Sun, 4 Mar 2012 00:20:03 +0000 (01:20 +0100)]
selftest/README: Expand inconsistent tabs
Jelmer Vernooij [Sun, 4 Mar 2012 00:19:17 +0000 (01:19 +0100)]
selftest: Remove outdated template.
Jelmer Vernooij [Sun, 4 Mar 2012 00:18:58 +0000 (01:18 +0100)]
selftest: Remove unused and broken target 'windows'.
Jelmer Vernooij [Sat, 3 Mar 2012 21:22:50 +0000 (22:22 +0100)]
samba.7: Remove references to long gone testprns and smbsh utilities.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Sun Mar 4 01:56:19 CET 2012 on sn-devel-104
Volker Lendecke [Sat, 3 Mar 2012 16:02:01 +0000 (17:02 +0100)]
s3: Fix a bogus if (client_len < 0)
On some platforms socklen_t might be unsigned, so comparing for <0
always returns true. Also, tsocket_address_bsd_sockaddr returns
ssize_t.
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Mar 3 23:38:31 CET 2012 on sn-devel-104
Michael Adam [Sat, 3 Mar 2012 16:01:38 +0000 (17:01 +0100)]
selftest: more precisely skip durable-open, not durable.open
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Sat Mar 3 19:17:32 CET 2012 on sn-devel-104
Michael Adam [Mon, 27 Feb 2012 21:56:37 +0000 (22:56 +0100)]
s4:torture:smb2: start a testsuite for durable v2 handles: durable and persistent opens
Michael Adam [Thu, 1 Mar 2012 01:22:36 +0000 (02:22 +0100)]
s4:libcli:smb2: set SMB2_CAP_ALL in the negprot
Stefan Metzmacher [Thu, 1 Mar 2012 00:38:09 +0000 (01:38 +0100)]
s3:libsmb: pass smb2 capabilities and client guid in cli_state_create()
metze
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 29 Feb 2012 23:29:51 +0000 (00:29 +0100)]
s4:libcli:smb2: store the share capabilites in the smb2_tree object
Michael Adam [Wed, 29 Feb 2012 01:02:29 +0000 (02:02 +0100)]
smbXcli: add the possiblilty to negotiate client capabilites in smb >= 2.2
Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
Michael Adam [Mon, 27 Feb 2012 19:27:46 +0000 (20:27 +0100)]
s4:libcli:smb2: allow max protocol 0x0224
Michael Adam [Mon, 27 Feb 2012 19:15:18 +0000 (20:15 +0100)]
s4:libcli:smb2: add support for parsing the durable handle v2 response in smb2_create_recv()
Michael Adam [Mon, 27 Feb 2012 19:15:01 +0000 (20:15 +0100)]
s4:libcli:smb2: add support durable handle reconnect v2 blob in smb2_create_send
Michael Adam [Mon, 27 Feb 2012 19:15:01 +0000 (20:15 +0100)]
s4:libcli:smb2: add support durable handle request v2 blob in smb2_create_send
Michael Adam [Mon, 27 Feb 2012 01:35:24 +0000 (02:35 +0100)]
s4:libcli:smb2: add durable handle v2 data to the smb2_create i/o structure
Michael Adam [Fri, 2 Mar 2012 21:01:01 +0000 (22:01 +0100)]
libcli:smb: define SMB2_DHANDLE_FLAG_PERSISTENT
Michael Adam [Fri, 2 Mar 2012 18:01:50 +0000 (19:01 +0100)]
libcli:smb: add new SMB2 share flags
* FORCE_LEVELII_OPLOCKS
* ENABLE_HASH_V1
* ENABLE_HASH_V2
* ENCRYPT_DATA
Michael Adam [Wed, 29 Feb 2012 23:59:54 +0000 (00:59 +0100)]
libcli:smb: upgrade SMB2_CAP_ALL to include the newly known caps
Michael Adam [Tue, 28 Feb 2012 14:48:46 +0000 (15:48 +0100)]
libcli:smb: add defines for SMB2.2 share capabilities
* continuous avaliability
* cluster
* scaleout
Michael Adam [Tue, 28 Feb 2012 14:47:05 +0000 (15:47 +0100)]
libcli:smb: add defines for SMB2.2 global capabilities
* multi channel
* persistent handles
* directory leasing
* encryption
Michael Adam [Mon, 27 Feb 2012 01:17:20 +0000 (02:17 +0100)]
libcli:smb: define DH2Q and DH2C tags for smb2 extra create blobs
These are the tags for the SMB2_CREATE_DURABLE_HANDLE_REQUEST_V2
and SMB2_CREATE_DURABLE_HANDLE_RECONNECT_V2, the second version
of the SMB2_CREATE_DURABLE_HANDLE_REQUEST (DHnQ) and
SMB2_CREATE_DURABLE_HANDLE_RECONNECT (DHnC), which are only
available for SMB 2.2 (and newer).
Michael Adam [Wed, 29 Feb 2012 22:19:59 +0000 (23:19 +0100)]
s4:torture:smb2: rename some of the durable-handle subtests more systematically
Michael Adam [Wed, 29 Feb 2012 21:59:35 +0000 (22:59 +0100)]
s4:torture:smb2:durable_open: update (C)
Stefan Metzmacher [Thu, 23 Feb 2012 08:16:55 +0000 (09:16 +0100)]
s4:torture:smb2:durable-open: skip the open-with-lease test on servers without lease support
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Tue, 28 Feb 2012 02:07:51 +0000 (03:07 +0100)]
s4:torture:smb2: durable-open: make tables static
Stefan Metzmacher [Thu, 23 Feb 2012 08:16:55 +0000 (09:16 +0100)]
s4:test:smb2:durable_open: skip lease tests when the server does not support leases
Signed-off-by: Michael Adam <obnox@samba.org>
Stefan Metzmacher [Thu, 23 Feb 2012 08:16:37 +0000 (09:16 +0100)]
s4:torture:smb2:durable_open: remove unused lease variables in the open-oplock test
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Sat, 3 Mar 2012 06:14:35 +0000 (07:14 +0100)]
s3:smbd:smb2_write: improve logging in the error case
Matthias Dieter Wallnöfer [Fri, 2 Mar 2012 19:00:04 +0000 (20:00 +0100)]
s4:samba-tool domain level raise command - reference SAMDB object correctly
https://bugzilla.samba.org/show_bug.cgi?id=8787
Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Sat Mar 3 12:54:21 CET 2012 on sn-devel-104
Christian Ambach [Sat, 3 Mar 2012 05:35:22 +0000 (21:35 -0800)]
smb2_constants: fix a typo
Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Sat Mar 3 09:04:40 CET 2012 on sn-devel-104
Christian Ambach [Sat, 3 Mar 2012 05:34:32 +0000 (21:34 -0800)]
s3:smb2_server: use SMB2_WATCH_TREE
it makes the code easier to understand if it uses the names specified in MS-SMB2 instead
of just the underlying values
Christian Ambach [Sat, 3 Mar 2012 05:33:28 +0000 (21:33 -0800)]
smb2_constants: add SMB2_WATCH_TREE
Christian Ambach [Tue, 28 Feb 2012 01:52:21 +0000 (17:52 -0800)]
s3:smb2_server fix a typo
Volker Lendecke [Sat, 3 Mar 2012 00:23:44 +0000 (01:23 +0100)]
s3: Fix some blank line endings
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Mar 3 03:41:03 CET 2012 on sn-devel-104
Volker Lendecke [Fri, 2 Mar 2012 19:02:35 +0000 (20:02 +0100)]
examples: Make examples/VFS/Makefile.in FreeBSD-friendly
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Sat Mar 3 00:53:43 CET 2012 on sn-devel-104
Arvid Requate [Fri, 2 Mar 2012 12:59:30 +0000 (13:59 +0100)]
SEGV in acl_validate_spn_value: dnsHostName NULL
This patch addresses a segfault in acl_validate_spn_value which occurs
when the "dnsHostName" attribute is missing. This seems to be the case
in domains migrated with samba3upgrade. Looks similar to MS KB 817543.
Signed-off-by: Nadezhda Ivanova <nivanova@drizzit.(none)>
Autobuild-User: Nadezhda Ivanova <nivanova@samba.org>
Autobuild-Date: Fri Mar 2 21:26:40 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 2 Mar 2012 11:28:59 +0000 (22:28 +1100)]
selftest: Rework samba4.blackbox.bogusdomain to use a temporary user
This avoids leaving an account in the test environment after the test is run
and therefore avoids issues with interations with other tests.
Also, we now use the local administrator account in the member server to
add the test account.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Mar 2 14:44:36 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 2 Mar 2012 07:20:45 +0000 (18:20 +1100)]
selftest: close stdin and wait with waitpid() for a safer exit
This avoids timelimit sending kill -9 after 1 second, which may
disrupt the writing of gcov data.
Andrew Bartlett
Andrew Bartlett [Fri, 2 Mar 2012 07:01:13 +0000 (18:01 +1100)]
selftest: Put stdin pipe on the environment
This seems to help us close the right pipe at cleanup time.
Andrew Bartlett
Volker Lendecke [Fri, 2 Mar 2012 01:10:52 +0000 (02:10 +0100)]
s3: Test for statfs before statfs64
Autobuild-User: Volker Lendecke <vl@samba.org>
Autobuild-Date: Fri Mar 2 12:04:35 CET 2012 on sn-devel-104
Brad Smith [Fri, 2 Mar 2012 00:34:16 +0000 (01:34 +0100)]
s3: Further fix for bug 8777
Volker Lendecke [Thu, 1 Mar 2012 23:45:51 +0000 (00:45 +0100)]
s3: Enable statvfs usage on NetBSD
linux_statvfs is pretty much what you use when you have susv4.
No real code change, this moves linux_statvfs to the bottom of the
(LINUX) to #ifdef (STAT_STAVFS).
Amitay Isaacs [Fri, 2 Mar 2012 06:56:24 +0000 (17:56 +1100)]
s4-rpc: dnsserver: Fix the typo in comparing two DNS records
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Fri Mar 2 10:27:41 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 14:20:45 +0000 (15:20 +0100)]
s3:rpc_server: initialize struct schannel_state to zero
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Fri Mar 2 08:48:23 CET 2012 on sn-devel-104
Stefan Metzmacher [Mon, 27 Feb 2012 14:20:45 +0000 (15:20 +0100)]
s3:rpc_client: initialize struct schannel_state to zero
metze
Stefan Metzmacher [Mon, 27 Feb 2012 14:20:45 +0000 (15:20 +0100)]
s4:auth/gensec/schannel: initialize struct schannel_state to zero
metze
Stefan Metzmacher [Mon, 27 Feb 2012 14:18:56 +0000 (15:18 +0100)]
s4:auth/gensec/schannel: make a copy of netlogon_creds_CredentialState in the client
This is really a copy for the lifetime of the rpc connection.
metze
Andrew Bartlett [Thu, 1 Mar 2012 06:26:32 +0000 (17:26 +1100)]
s3-selftest: Add tests for ntlm_auth gss-spnego client and server
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Mar 2 07:05:44 CET 2012 on sn-devel-104
Andrew Bartlett [Fri, 2 Mar 2012 02:07:09 +0000 (13:07 +1100)]
s3-rpcclient: Ensure interfaces are loaded after smb.conf
This ensures that the interfaces line in the smb.conf is honoured.
Andrew Bartlett
Jelmer Vernooij [Fri, 2 Mar 2012 02:46:13 +0000 (03:46 +0100)]
pyldb: Fix some more long lines, fix formatting.
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Fri Mar 2 05:26:56 CET 2012 on sn-devel-104
Jelmer Vernooij [Fri, 2 Mar 2012 02:30:51 +0000 (03:30 +0100)]
selftest: Move manual page into a separate file.
(Generated using pod2man from selftest.pl itself)
Andrew Bartlett [Fri, 2 Mar 2012 00:44:56 +0000 (11:44 +1100)]
selftest: Establish a registry of socket wrapper IPs
This fixes a bug where chgdcpass was on the same IP as localsubdc, and
will avoid similar mistakes in future.
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri Mar 2 03:48:05 CET 2012 on sn-devel-104
Andrew Bartlett [Thu, 1 Mar 2012 05:55:04 +0000 (16:55 +1100)]
s3-libsmb: Initialise ticket to ensure we do not invalid memory
The free is however a talloc_free(), which has additional protection against
freeing the wrong thing.
Andrew Bartlett
Signed-off-by: Jeremy Allison <jra@samba.org>
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri Mar 2 01:45:19 CET 2012 on sn-devel-104
Jeremy Allison [Thu, 1 Mar 2012 20:35:27 +0000 (12:35 -0800)]
Move to talloc from malloc.