Jelmer Vernooij [Sat, 14 Mar 2009 20:12:49 +0000 (21:12 +0100)]
Add shared pkg.m4 file with convenience macros for using pkg-config.
Brad Hards [Tue, 10 Mar 2009 16:11:39 +0000 (17:11 +0100)]
Update instructions for checking out pidl.
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
I think we eventually need to pass down the debuglevel here.
Stefan Metzmacher [Tue, 10 Mar 2009 13:02:30 +0000 (14:02 +0100)]
tevent: add tevent_req_callback_data_void() macro
Callers can use it instead of tevent_req_callback_data()
if they use a non talloc private pointer.
metze
Stefan Metzmacher [Tue, 10 Mar 2009 12:54:57 +0000 (13:54 +0100)]
tevent: add tevent_req_received() function
This function can be called as last action of a _recv()
function, it destroys the data attached to the tevent_req.
metze
Simo Sorce [Tue, 10 Mar 2009 14:05:52 +0000 (10:05 -0400)]
Fix extended operation return path.
Extended operations return was not going thorugh the same patch as others
leaving the ctx around. Plus we were neutralizing the spy too early so that it
didn't set the request_terminated flag as it should have.
This should hopefully fix the failures in the build farm.
Stefan Metzmacher [Tue, 10 Mar 2009 11:34:20 +0000 (12:34 +0100)]
s3:libsmb: add an option to cli_push to let the caller provide the buffers
metze
Stefan Metzmacher [Tue, 10 Mar 2009 11:32:48 +0000 (12:32 +0100)]
s3:libsmb: only treat a return 0 as end of file
metze
Stefan Metzmacher [Tue, 10 Mar 2009 09:56:33 +0000 (10:56 +0100)]
s3:libsmb: fix a lot of cli_push() bugs
There were the following problems:
1.) if window_size was a multiple of the chunk_size,
we silently dropped the last truncated chunk.
2.) if window_size was 0 pushed only the first chunk
to the server and silently dropped the rest.
3.) we had only transferred state->num_reqs writes,
even if there would be more data to send.
metze
Stefan Metzmacher [Mon, 9 Mar 2009 16:48:08 +0000 (17:48 +0100)]
socket_wrapper: wrap readv() and writev()
metze
Andrew Tridgell [Tue, 10 Mar 2009 05:45:45 +0000 (16:45 +1100)]
fixed a bug in message handling for code the change notify code
The change notify code registered a separate message handler for each
tree connect. This registration uses the global messaging context.
The messaging code would consider a 2nd registration for the same
messaging type as being an 'update' of the handler, rather than a new
handler. It also would only call the first handler in the linked list
for a given message type when dispatching messages.
This patch changes the messaging code to allow for multiple
registrations of the same message type, and allow for multiple calls
to different messaging handler for one incoming message.
This fixes the problem with the test_notify_tcon() test that I
recently committed to the S4 smbtorture
Andrew Tridgell [Tue, 10 Mar 2009 04:12:48 +0000 (15:12 +1100)]
added a test that triggers a bug in the Samba3 notify code
The Samba3 internal notify code doesn't work correctly when there is
more than one tree connect to the same smbd process. This change to
the RAW-NOTIFY test triggers the bug.
Simo Sorce [Mon, 9 Mar 2009 22:04:38 +0000 (18:04 -0400)]
Fix potential segfaults using freed memory.
In some code paths ltdb_context was still referenced even after we were returned
an error by one of the callbacks. Because the interface assumes that once an
error is returned the ldb_request may be freed, and because the ltdb_context was
allocated as a child of the request, this might cause access to freed memory.
Allocate the ltdb_context on ldb, and keep track of what's going on with the
request by adding a spy children on it. This way even if the request is freed
before the ltdb_callback is called, we will safely free the ctx and just quietly
return.
Jelmer Vernooij [Mon, 9 Mar 2009 20:49:44 +0000 (21:49 +0100)]
Fix prototype mismatch.
Jelmer Vernooij [Mon, 9 Mar 2009 20:42:13 +0000 (21:42 +0100)]
Merge branch 'master' of ssh://git.samba.org/data/git/samba
Björn Jacke [Mon, 9 Mar 2009 16:28:42 +0000 (17:28 +0100)]
use LIB_PATH_VAR in selftest.sh if we have it
if we have LIB_PATH_VAR we should use it, otherwise we'll unobtrusively
complain about not having it and use the most likely LD_LIBRARY_PATH.
Signed-off-by: Jelmer Vernooij <jelmer@samba.org>
Karolin Seeger [Mon, 9 Mar 2009 15:16:20 +0000 (16:16 +0100)]
s3/packaging: Fix typo in comment.
Karolin
Karolin Seeger [Mon, 9 Mar 2009 15:01:30 +0000 (16:01 +0100)]
s3/packaging: Package new files properly.
That is part of the fix for bug #6144.
Thanks to Diego Remolina dijuremo [at] gatech [dot] edu for reporting!
Karolin
Volker Lendecke [Mon, 9 Mar 2009 15:10:59 +0000 (16:10 +0100)]
Fix a typo
Stefan Metzmacher [Mon, 9 Mar 2009 11:35:21 +0000 (12:35 +0100)]
s3:lib: interfaces.c isn't used in the configure tests anymore
libreplace always provides the getifaddr() function.
This fixes the build on sles8.
metze
Björn Jacke [Sun, 8 Mar 2009 14:36:41 +0000 (15:36 +0100)]
fix "dubious escape" warning of Studio compiler
Stefan Metzmacher [Mon, 9 Mar 2009 08:24:45 +0000 (09:24 +0100)]
socket_wrapper: try to make ipv6 support more portable
The internal structure of in6_addr isn't always the same.
metze
Stefan Metzmacher [Sun, 8 Mar 2009 16:20:18 +0000 (17:20 +0100)]
socket_wrapper: downgrade ipv6 sockets to ipv4 is in connect() if the dest is ipv4
We only do this if the socket isn't explicit bound yet.
metze
Stefan Metzmacher [Sun, 8 Mar 2009 16:19:50 +0000 (17:19 +0100)]
socket_wrapper: correctly handle connected dgram sockets
metze
Stefan Metzmacher [Tue, 3 Mar 2009 18:40:57 +0000 (19:40 +0100)]
socket_wrapper: make it possible to bind to '::'
metze
Volker Lendecke [Sun, 8 Mar 2009 11:25:10 +0000 (12:25 +0100)]
Don't copy the winbindd_request in wb_trans
Volker Lendecke [Sun, 8 Mar 2009 11:22:29 +0000 (12:22 +0100)]
Convert wb_open_pipe to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 11:15:39 +0000 (12:15 +0100)]
Convert wb_connect to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 11:10:00 +0000 (12:10 +0100)]
Convert wb_int_trans to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 10:33:03 +0000 (11:33 +0100)]
Add parameter "queue" to wb_int_trans_send
Volker Lendecke [Sun, 8 Mar 2009 09:29:15 +0000 (10:29 +0100)]
Move "struct req_read_state" where it belongs
Volker Lendecke [Sun, 8 Mar 2009 09:28:05 +0000 (10:28 +0100)]
Convert wb_resp_write to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 09:20:27 +0000 (10:20 +0100)]
Convert wb_resp_read to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 09:04:04 +0000 (10:04 +0100)]
Convert wb_req_read to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 08:35:13 +0000 (09:35 +0100)]
Convert wb_req_write to tevent_req
Volker Lendecke [Sun, 8 Mar 2009 08:34:35 +0000 (09:34 +0100)]
Add tevent_req wbc helpers
Volker Lendecke [Sun, 1 Mar 2009 18:43:07 +0000 (19:43 +0100)]
Add "queue" to writev_send
Unless higher levels queue themselves somehow, writev will *always* be queued.
So the queueing should be done at the right level.
Jelmer Vernooij [Sun, 8 Mar 2009 05:57:52 +0000 (06:57 +0100)]
Revert accidental reintroduction of void ** bug.
Volker Lendecke [Thu, 12 Feb 2009 16:48:52 +0000 (17:48 +0100)]
Shape up pdb_search a bit by making it a talloc ctx with a destructor
Volker Lendecke [Fri, 6 Mar 2009 13:24:59 +0000 (14:24 +0100)]
Fix a smbclient segfault against security=share servers
Volker Lendecke [Tue, 3 Mar 2009 13:05:56 +0000 (14:05 +0100)]
Fix some nonempty blank lines
Günther Deschner [Sat, 7 Mar 2009 08:30:11 +0000 (09:30 +0100)]
s4-spoolss: just return OK for dcesrv_spoolss_EnumPrintProcDataTypes for now.
Guenther
Björn Jacke [Wed, 4 Mar 2009 15:52:12 +0000 (16:52 +0100)]
don't rely on shebang's perl path, call our $PERL instead
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Günther Deschner [Sat, 7 Mar 2009 00:12:18 +0000 (01:12 +0100)]
s3-spoolss: remove more leftovers from old enumports call.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:16:10 +0000 (00:16 +0100)]
s3-rpcclient: add enummonitors command to enumerate print monitors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:10:15 +0000 (00:10 +0100)]
s3-spoolss: add rpccli_spoolss_enummonitors convenience wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:04:48 +0000 (00:04 +0100)]
s3-spoolss: remove old spoolss_EnumMonitors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:04:05 +0000 (00:04 +0100)]
s3-spoolss: use pidl for _spoolss_EnumMonitors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:01:11 +0000 (00:01 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:00:27 +0000 (00:00 +0100)]
spoolss: flag spoolss_MonitorInfo structs [public,gensize].
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:36:31 +0000 (23:36 +0100)]
s3-rpcclient: use rpccli_spoolss_enumports wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:27:45 +0000 (23:27 +0100)]
s3-spoolss: add rpccli_spoolss_enumports convenience wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:39:23 +0000 (23:39 +0100)]
s3-spoolss: remove old spoolss_EnumPorts.
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:38:57 +0000 (23:38 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPorts.
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:37:42 +0000 (23:37 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 22:37:14 +0000 (23:37 +0100)]
spoolss: flag spoolss_PortInfo structs as [public,gensize].
Guenther
Günther Deschner [Fri, 6 Mar 2009 23:55:15 +0000 (00:55 +0100)]
s3-rpcclient: add enumprocdatatypes command to enumerate print processor data
types.
Guenther
Günther Deschner [Fri, 6 Mar 2009 21:22:49 +0000 (22:22 +0100)]
s3-spoolss: add rpccli_spoolss_enumprintprocessordatatypes convenience wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:51:52 +0000 (21:51 +0100)]
s3-spoolss: remove old spoolss_EnumPrintProcDataTypes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:51:12 +0000 (21:51 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPrintProcDataTypes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 21:11:09 +0000 (22:11 +0100)]
s3-rpcclient: add enumprocs command to enumerate print processors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 21:09:47 +0000 (22:09 +0100)]
s3-spoolss: add rpccli_spoolss_enumprintprocessors convenience wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 19:23:27 +0000 (20:23 +0100)]
s3-spoolss: remove old spoolss_EnumPrintProcessors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 19:22:17 +0000 (20:22 +0100)]
s3-spoolss: use pidl for _spoolss_EnumPrintProcessors.
Guenther
Günther Deschner [Fri, 6 Mar 2009 19:21:31 +0000 (20:21 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 19:20:51 +0000 (20:20 +0100)]
spoolss: flag spoolss_PrintProcessorInfo1 [public,gensize].
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:50:15 +0000 (21:50 +0100)]
s4-smbtorture: add test_EnumPrintProcDataTypes to RPC-SPOOLSS test.
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:49:31 +0000 (21:49 +0100)]
spoolss: add spoolss_EnumPrintProcDataTypes to enum macro helper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:48:46 +0000 (21:48 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 20:48:01 +0000 (21:48 +0100)]
spoolss: fill in spoolss_EnumPrintProcDataTypes IDL.
Guenther
Stefan Metzmacher [Fri, 6 Mar 2009 15:27:10 +0000 (16:27 +0100)]
s3:make_test: run CHAIN1 test
metze
Stefan Metzmacher [Fri, 6 Mar 2009 11:01:44 +0000 (12:01 +0100)]
s3:libsmb: merge cli_setup_signing_state() into cli_initialise_ex()
metze
Stefan Metzmacher [Fri, 6 Mar 2009 10:52:15 +0000 (11:52 +0100)]
s3:libsmb: remove cli_setup_signing_state() and add struct cli_state *cli_initialise_ex()
This prepares the next changes.
metze
Stefan Metzmacher [Fri, 6 Mar 2009 10:40:21 +0000 (11:40 +0100)]
s3:winbindd_cm: remove useless cli_setup_signing_state(*cli, Undefined) call
cli_setup_signing_state() with Undefined is a noop.
metze
Stefan Metzmacher [Fri, 6 Mar 2009 06:45:06 +0000 (07:45 +0100)]
s3:signing: the seqnum should only be decremented by 1 for ntcancel requests
[MS-SMB] 3.3.5.1 Receiving Any Message says that the seqnum
is incremented by only for ntcancel requests for any other
request it's by incremented by 2, even if it doesn't expect
a response.
metze
Stefan Metzmacher [Fri, 6 Mar 2009 06:38:41 +0000 (07:38 +0100)]
s3:errormap: add ECANCELED, ERRDOS/ERRbadfid, NT_STATUS_CANCELLED mapping
If someone knows a better dos error, please tell me...
metze
Stefan Metzmacher [Fri, 6 Mar 2009 15:18:50 +0000 (16:18 +0100)]
s3:libsmb: smb signing works the same for extented and non-extended security
This is only cosmetic, but it makes it easier to understand.
metze
Günther Deschner [Fri, 6 Mar 2009 13:58:49 +0000 (14:58 +0100)]
s3-spoolss: Fix Coverity ID #891 (UNINIT).
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:04:47 +0000 (12:04 +0100)]
s3-spoolss: remove old _spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:01:54 +0000 (12:01 +0100)]
s3-spoolss: use form flags from idl in rpcclient and net.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:01:14 +0000 (12:01 +0100)]
s3-spoolss: use pidl for _spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 13:24:20 +0000 (14:24 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:05:25 +0000 (12:05 +0100)]
spoolss: flag spoolss_FormInfo1 and 2 with [public,gensize].
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:55:09 +0000 (10:55 +0100)]
s3-spoolss: remove old rpccli_spoolss_enumforms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 10:02:27 +0000 (11:02 +0100)]
s3-net: use new rpccli_spoolss_enumforms wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:55:41 +0000 (10:55 +0100)]
s3-rpcclient: use new rpccli_spoolss_enumforms wrapper.
Guenther
Günther Deschner [Fri, 6 Mar 2009 09:54:19 +0000 (10:54 +0100)]
s3-spoolss: add convencience wrapper around rpccli_spoolss_EnumForms.
Guenther
Günther Deschner [Fri, 6 Mar 2009 13:23:44 +0000 (14:23 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Thu, 5 Mar 2009 17:35:47 +0000 (18:35 +0100)]
spoolss: fix [size_is] declaration for enum calls.
This took me ages to find. Thanks metze!
Guenther
Günther Deschner [Mon, 2 Mar 2009 17:02:04 +0000 (18:02 +0100)]
s4-spoolss: fix spoolss server enum calls after pointer changes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:24:23 +0000 (12:24 +0100)]
s4-smbtorture: exit early in test_EnumPorts when no port info has been returned.
Guenther
Günther Deschner [Fri, 6 Mar 2009 11:20:14 +0000 (12:20 +0100)]
s4-smbtorture: fix s3 flavor rpc spoolss test.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:58:13 +0000 (17:58 +0100)]
s4-smbtorture: fix RPC-SPOOLSS-WIN.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:32:24 +0000 (17:32 +0100)]
s4-smbtorture: fix RPC-SPOOLSS test after enum out info pointer changes.
Guenther
Günther Deschner [Fri, 6 Mar 2009 12:52:39 +0000 (13:52 +0100)]
spoolss: fix spoolss enum calls helper macro code after pointer changes.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:31:29 +0000 (17:31 +0100)]
s3: re-run make samba3-idl.
Guenther
Günther Deschner [Mon, 2 Mar 2009 16:29:15 +0000 (17:29 +0100)]
spoolss: make all enum out info pointers a pointer to an array.
Without this we never can get a reasonable s3 cli_spoolss fn for the enum calls.
Guenther
Stefan Metzmacher [Fri, 6 Mar 2009 06:15:13 +0000 (07:15 +0100)]
s4:errormap: map ECANCELED to NT_STATUS_CANCELLED
metze
Jeremy Allison [Fri, 6 Mar 2009 06:00:22 +0000 (22:00 -0800)]
Get the sense of the integer wrap test the right way around. Sorry.
Jeremy.
Jeremy Allison [Fri, 6 Mar 2009 05:06:48 +0000 (21:06 -0800)]
Now we're allowing a lower bound for auth_len, ensure we
also check for an upper one (integer wrap).
Jeremy.