13 years agoreplace svn references with git ones in Readme
Volker Lendecke [Tue, 22 Jan 2008 12:42:44 +0000 (13:42 +0100)]
replace svn references with git ones in Readme
(This used to be commit e6c92b62a4791fd5b530e6e52e4386e837bd7994)

13 years agoMove samba_extended_info_version to smbd/trans2.c
Volker Lendecke [Tue, 22 Jan 2008 12:00:22 +0000 (13:00 +0100)]
Move samba_extended_info_version to smbd/trans2.c

This is right now only used there, and in version.c it gave linker errors
because some binaries (e.g. smbmnt) don't link in time.o
(This used to be commit 1f0eaaa5911f893c822465a26fe49ab65afb0730)

13 years agoAvoid use of uninitialized memory
Volker Lendecke [Tue, 22 Jan 2008 11:46:51 +0000 (12:46 +0100)]
Avoid use of uninitialized memory
(This used to be commit 85123aacdb13e97c3f44aeded1c80e13af53d83d)

13 years agoGet Samba version or capability information from Windows
Corinna Vinschen [Tue, 22 Jan 2008 10:33:17 +0000 (11:33 +0100)]
Get Samba version or capability information from Windows

On Jan 21 16:18, Danilo Almeida wrote:
> Corina wrote:
> > + time_t samba_gitcommitdate;
> And:
> > +   SIVAL(pdata,28,extended_info.samba_gitcommitdate);
> > +   memcpy(pdata+32,extended_info.samba_version_string,32);
> Note that you are dropping bits on a system w/64-bit time_t, and that this has the 2038 problem.

Right.  I changed samba_gitcommitdate from time_t to NTTIME and shortened
samba_version_string to 28 bytes.  New patch below.

(This used to be commit 28aa1c199d3a22cda34afcaab49c0561eeb0abcb)

13 years agoHide streams from the EA API
Volker Lendecke [Mon, 21 Jan 2008 19:24:23 +0000 (20:24 +0100)]
Hide streams from the EA API
(This used to be commit e9bb3d5067b74a29beb778f85687829778e42b5b)

13 years agolibreplace: getpwent_r/getgrent_r on IRIX are similar to solaris but use size_t
Stefan Metzmacher [Tue, 22 Jan 2008 11:21:55 +0000 (12:21 +0100)]
libreplace: getpwent_r/getgrent_r on IRIX are similar to solaris but use size_t

(This used to be commit 2f460915111066d79f5dc9b4ae4d003918d06852)

13 years agoFix a ton of IBM checker uninitialized variable warnings
Volker Lendecke [Tue, 22 Jan 2008 08:22:14 +0000 (09:22 +0100)]
Fix a ton of IBM checker uninitialized variable warnings

SET_STAT_INVALID only sets nlink, not the other fields

We might consider to change SET_STAT_INVALID to always do ZERO_STRUCT
(This used to be commit 8cf8c5b2034fe093b5db7f069bc6be8d328399bf)

13 years agoFix get_ea_names_from_file for many EAs
Volker Lendecke [Tue, 22 Jan 2008 08:18:40 +0000 (09:18 +0100)]
Fix get_ea_names_from_file for many EAs

Found by the IBM checker
(This used to be commit 8741a9b37496e78b28d59d844aaba12f269171e0)

13 years agoFix a segfault
Volker Lendecke [Tue, 22 Jan 2008 08:13:25 +0000 (09:13 +0100)]
Fix a segfault

Found by the IBM checker.

Jeremy, you changed this from 'dirname == 0' which does not make sense at all
in the old code to '!dirname == 0' which from my point of view makes even less
sense, because the precedence of ! is according to Harbison/Steele higher than
the precedence of ==. Please check that the code now actually does what it's
supposed to do.

(This used to be commit c8def5564739c4c754001f84fcfb77f1093b96c3)

13 years agoAdd another check for talloc failure to libnet_conf
Michael Adam [Mon, 21 Jan 2008 14:35:09 +0000 (15:35 +0100)]
Add another check for talloc failure to libnet_conf

(This used to be commit 196e4ce8c5dd5aab518aaa7d170eb1fb5d66bcd1)

13 years agoFix formatting of multi_sz registry values.
Michael Adam [Mon, 21 Jan 2008 14:31:57 +0000 (15:31 +0100)]
Fix formatting of multi_sz registry values.

Don't print only the last component.

(This used to be commit 654e96208ec847e32797cbd2442ef9e73c014567)

13 years agoUse talloc_stackframe() for temporary contexts throughout libnet_conf.c
Michael Adam [Mon, 21 Jan 2008 14:28:04 +0000 (15:28 +0100)]
Use talloc_stackframe() for temporary contexts throughout libnet_conf.c

(This used to be commit 4d734106b70b9b6029b537fe11f8b3c1aebd42cf)

13 years agoAdd a check for talloc failure. - Pointed out by Volker.
Michael Adam [Mon, 21 Jan 2008 14:24:23 +0000 (15:24 +0100)]
Add a check for talloc failure. - Pointed out by Volker.

(This used to be commit bdc49b07cc6de36c9319254a131858c9a7f9dd53)

13 years agoFix two debug messages.
Michael Adam [Mon, 21 Jan 2008 14:14:16 +0000 (15:14 +0100)]
Fix two debug messages.

(This used to be commit 35e23368dd4240a3c907b4cee882f51119032527)

13 years agoAttempt to fix the darwin build
Volker Lendecke [Mon, 21 Jan 2008 17:07:38 +0000 (18:07 +0100)]
Attempt to fix the darwin build
(This used to be commit 5b05e09daf18eaea5e86dfd607c8070228f7571b)

13 years agoutil_sock: Don't return a pointer to freed memory.
Kai Blin [Mon, 21 Jan 2008 17:01:55 +0000 (18:01 +0100)]
util_sock: Don't return a pointer to freed memory.

Fix a bug in my bugfix. Thanks to vl for spotting that one.
(This used to be commit 24f68b90cca111256a7b03f7062cb57c2b08a0d6)

Volker Lendecke [Mon, 21 Jan 2008 14:10:44 +0000 (15:10 +0100)]

It turns out that this is a necessary operation, separate from statvfs. statvfs
can fail during tcon, so conn->fs_capabilities would never see that we support
streams on a particular share.

James, can you check that I got the darwin variant right? Thanks!
(This used to be commit 3ad798d803b3b023533bb48e6993885f22b96095)

13 years agoLink smbd on AIX with -bexpfull instead of -bexpall
Volker Lendecke [Mon, 21 Jan 2008 14:00:34 +0000 (15:00 +0100)]
Link smbd on AIX with -bexpfull instead of -bexpall

-bexpall only exports the names without leading _, so we don't get
_talloc_reallo_array for example.

Thanks a lot to Heinrich Mislik for the hint!
(This used to be commit 74a71f198866ba0a0217e58a6a47bdc858d5df68)

13 years agoutil_sock: Fix memcache bug in get_mydnsfullname.
Kai Blin [Mon, 21 Jan 2008 12:18:38 +0000 (13:18 +0100)]
util_sock: Fix memcache bug in get_mydnsfullname.

get_mydnsfullname relied on memcache_add(); memcache_lookup() working.
When run from ntlm_auth, the global_cache variable in memcache is NULL, so
the add and lookup both fail. In that case, just return the result of the
getaddrinfo call.

Jeremy, please check.
(This used to be commit 1db41ff52565e9f336a22fb9ffd80d51677e023b)

13 years agolibwbclient: use the same style in each switch case for the error mapping
Stefan Metzmacher [Sat, 19 Jan 2008 10:08:49 +0000 (11:08 +0100)]
libwbclient: use the same style in each switch case for the error mapping

(This used to be commit 0b85f7173d0770f8d9a0bac9e43355eb45bc181f)

13 years agowinbindd: remove useless strcpy
Stefan Metzmacher [Fri, 18 Jan 2008 07:39:47 +0000 (08:39 +0100)]
winbindd: remove useless strcpy

(This used to be commit df08708fc1e8fc8e15b36db29faf35ae5ae64b65)

13 years agoRename lib/util_reg_smbconf.c to registry/reg_init_smbconf.c
Michael Adam [Sun, 20 Jan 2008 23:40:10 +0000 (00:40 +0100)]
Rename lib/util_reg_smbconf.c to registry/reg_init_smbconf.c

This actually is a counterpart to reg_init_full, in that is does
open and initialize the registry too, but only registeres the backends
necessary to access the SMBCONF key.

(This used to be commit 01bda3ab359fb3868c1dc849044f613bf2bc563e)

13 years agoMove reg_frontend_hilvl.c to reg_dispatcher.c
Michael Adam [Sun, 20 Jan 2008 23:34:06 +0000 (00:34 +0100)]
Move reg_frontend_hilvl.c to reg_dispatcher.c

This is actually the dispatcher to the registered registry backends.

(This used to be commit 39d65d11f8eff0aff998d5bfed8480b0f00655bd)

13 years agoExtend/fix comments.
Michael Adam [Sun, 20 Jan 2008 23:32:01 +0000 (00:32 +0100)]
Extend/fix comments.

(This used to be commit 4952417fca89f5d797c861cde9fe74050ae02e2f)

13 years agoExtract regkey_open_internal() from reg_frontend.c to new reg_util_legacy.c
Michael Adam [Sun, 20 Jan 2008 23:28:39 +0000 (00:28 +0100)]
Extract regkey_open_internal() from reg_frontend.c to new reg_util_legacy.c

reg_openpath should be used instead of this function (along with the
reg_api interface). Last callers of this function are in services_db.c

(This used to be commit 0005b88d74fca1ea1410c9911d504b0a636a0472)

13 years agoRename reg_db.c to reg_backend_db.c
Michael Adam [Sun, 20 Jan 2008 23:16:40 +0000 (00:16 +0100)]
Rename reg_db.c to reg_backend_db.c

(This used to be commit c3f695d3b14ee06fc5d517ca094236e885f9e707)

13 years agoRename reg_shares.c to reg_backend_shares.c
Michael Adam [Sun, 20 Jan 2008 23:14:10 +0000 (00:14 +0100)]
Rename reg_shares.c to reg_backend_shares.c

(This used to be commit aaf33ae5b8bfaefd2342c9ce6363577ce7c0c4f1)

13 years agoRename reg_smbconf.c to reg_backend_smbconf.c
Michael Adam [Sun, 20 Jan 2008 23:07:41 +0000 (00:07 +0100)]
Rename reg_smbconf.c to reg_backend_smbconf.c

(This used to be commit b85e5ee45075211dd3ab85ac79c2d856187d5e3e)

13 years agoRename reg_printing.c to reg_backend_printing.c
Michael Adam [Sun, 20 Jan 2008 22:59:06 +0000 (23:59 +0100)]
Rename reg_printing.c to reg_backend_printing.c

Start making naming of source files more systematic
to facilitate understanding of the structures.

(This used to be commit b3c2fb17a4226559788a47fee968ef19b7fbb6b2)

13 years Group together registry related object variables.
Michael Adam [Sun, 20 Jan 2008 22:48:28 +0000 (23:48 +0100)] Group together registry related object variables.

(This used to be commit cf485273f61e3dcd41ab7af756cc82f32131bf08)

13 years extract registry backend objects to common variable.
Michael Adam [Sun, 20 Jan 2008 22:39:16 +0000 (23:39 +0100)] extract registry backend objects to common variable.

(This used to be commit 562c3eb37e2ff2b385203be9d556daf37df7d20e)

13 years agoreg_eventlog.o and reg_perfcount.o are no longer neede for reg_smbconf.
Michael Adam [Sun, 20 Jan 2008 22:44:33 +0000 (23:44 +0100)]
reg_eventlog.o and reg_perfcount.o are no longer neede for reg_smbconf.

This is an effect of the removal of the dynamic registry overlay.
This is the beginning of a restructuring of registry linkage in

(This used to be commit 7453e78a8e63aaaff57c1779d6b7cf0ec8fc263f)

13 years agoFix some "set but never used" warnings
Volker Lendecke [Sun, 20 Jan 2008 16:35:25 +0000 (17:35 +0100)]
Fix some "set but never used" warnings
(This used to be commit 4a6dadc5178f4861e9c032321939db3b639734b5)

13 years agoFree case_state earlier
Volker Lendecke [Sun, 20 Jan 2008 16:32:19 +0000 (17:32 +0100)]
Free case_state earlier

Found by a "set but never used" warning. Thanks to talloc_tos() this was not
really a bug, but this way the code becomes much clearer.
(This used to be commit b326f11dc39a8ce20d957aac976be0cf7108ba9d)

13 years agoActivate SMB_QUERY_FILE_STREAM_INFO
Volker Lendecke [Sun, 20 Jan 2008 14:59:31 +0000 (15:59 +0100)]

gcolley was right, my nt4 does not blue screen with it
(This used to be commit 9f2b5dc1865ca109e1e34c91548479ad9b26f450)

13 years agoActive RAW-STREAMS in make test
Volker Lendecke [Sun, 20 Jan 2008 13:10:51 +0000 (14:10 +0100)]
Active RAW-STREAMS in make test
(This used to be commit 63ee2ef775b48fcaecccf4dc7ef3601ceb8053c5)

13 years agoFix valgrind errors
Volker Lendecke [Sun, 20 Jan 2008 14:09:53 +0000 (15:09 +0100)]
Fix valgrind errors
(This used to be commit d7e6ec2258350c564053371361c8f1d7d0f775b1)

13 years agoNT_STATUS_OBJECT_NAME_NOT_FOUND also means "no streams around :-)"
Volker Lendecke [Sun, 20 Jan 2008 13:44:07 +0000 (14:44 +0100)]
NT_STATUS_OBJECT_NAME_NOT_FOUND also means "no streams around :-)"
(This used to be commit 96b9a7b3eb92c9f133a3f43ffc4d57d0212e4ebd)

13 years agoDon't test split_ntfs_stream_name
Volker Lendecke [Sun, 20 Jan 2008 13:43:30 +0000 (14:43 +0100)]
Don't test split_ntfs_stream_name

This is a hot code path, and if it has a :, the name will be split later on
(This used to be commit 9f7f6b812d89decea1456ccdc37978e645d11a63)

13 years agoDo not use an unfinished fsp in streams_xattr_open
Volker Lendecke [Sun, 20 Jan 2008 13:09:08 +0000 (14:09 +0100)]
Do not use an unfinished fsp in streams_xattr_open
(This used to be commit 023b313d0d4ed3beb8d77177bc8141cadeb86658)

13 years agoIn streams_xattr_pwrite, base_fsp does not have an fd
Volker Lendecke [Sun, 20 Jan 2008 13:05:36 +0000 (14:05 +0100)]
In streams_xattr_pwrite, base_fsp does not have an fd

These bugs haven't shown up when I did my tests with real xattrs, not with the
xattr_tdb backend. It worked because the stream fsp does has the base file as
(This used to be commit b7022f8f7bf83c9c5e73e98d1477b7da766e8c5f)

13 years agoAdd some DEBUG
Volker Lendecke [Sun, 20 Jan 2008 12:55:27 +0000 (13:55 +0100)]
Add some DEBUG
(This used to be commit 8db25aba63b1dffb0dfbc74012c7ebd0ce4d5682)

13 years agoFor pread/pwrite we need to do the setxattr on base_fsp
Volker Lendecke [Sun, 20 Jan 2008 12:51:52 +0000 (13:51 +0100)]
For pread/pwrite we need to do the setxattr on base_fsp
(This used to be commit d481dddc81699aba79e48bca79bfb10e586b5cbb)

13 years agoReally remove the _NEXT_ from vfs_xattr_tdb.c
Volker Lendecke [Sun, 20 Jan 2008 12:49:38 +0000 (13:49 +0100)]
Really remove the _NEXT_ from vfs_xattr_tdb.c

This must have been lost somewhere in my patch-mangling
(This used to be commit c1794375d1fa27d72ec32946bb4bd7b9f96e59fc)

13 years agoSupport XATTR_CREATE and XATTR_REPLACE in vfs_xattr_tdb
Volker Lendecke [Sun, 20 Jan 2008 10:20:58 +0000 (11:20 +0100)]
Support XATTR_CREATE and XATTR_REPLACE in vfs_xattr_tdb
(This used to be commit 3509ee597f0977aadd4c70cfe8830a6aa95cd71f)

13 years agoComplete the ea->xattr rename in vfs_xattr_tdb
Volker Lendecke [Sun, 20 Jan 2008 10:10:06 +0000 (11:10 +0100)]
Complete the ea->xattr rename in vfs_xattr_tdb
(This used to be commit dac468216e7e103b6897f33ec3608412f77265cf)

13 years agoFix a segfault
Volker Lendecke [Sun, 20 Jan 2008 08:03:32 +0000 (09:03 +0100)]
Fix a segfault

Pointed out by Steven Danneman on irc, thanks!

Jerry, G√ľnther, please check!
(This used to be commit 9e71c89ac648040739ef2161a2e6c4299be1e35b)

13 years agoCouple of minor fixes for POSIX pathname processing in the
Jeremy Allison [Sun, 20 Jan 2008 05:53:49 +0000 (21:53 -0800)]
Couple of minor fixes for POSIX pathname processing in the
new stream code. (1) In smbd/filename, don't split the name at
':' if we know it's a posix path (this should be parameterized....).
(2). When calling posix_mkdir, we get the flag FILE_FLAG_POSIX_SEMANTICS
passed to open_directory(). I know for a posix client lp_posix_pathnames
should be true (which is checked for in is_ntfs_stream_name() but we
have an explicit flag here, so let's use it.
(This used to be commit 7bb7a0def6518784befa75e5303289d2b4d36dd4)

13 years agoDo an explicit init_globals() when restarting for "config backend = registry".
Michael Adam [Fri, 18 Jan 2008 15:06:37 +0000 (16:06 +0100)]
Do an explicit init_globals() when restarting for "config backend = registry".

(This used to be commit 487c43f9284598a3c60b06fc60e5c50844e11b87)

13 years agoAdd a debug message to fetch_reg_values().
Michael Adam [Fri, 18 Jan 2008 16:57:32 +0000 (17:57 +0100)]
Add a debug message to fetch_reg_values().

(This used to be commit 239aa59cc1b78f7fb82aa66418cdf92517ebc123)

13 years agoAdd some debugging output to reg_cachehook.c
Michael Adam [Fri, 18 Jan 2008 15:08:52 +0000 (16:08 +0100)]
Add some debugging output to reg_cachehook.c

(This used to be commit 2a278928805f4497e8afa28bdca433cbedc4a8d7)

13 years agoRemove the dynamic registry overlay.
Michael Adam [Sun, 20 Jan 2008 02:45:40 +0000 (03:45 +0100)]
Remove the dynamic registry overlay.

It is unnecessary now the dynamic functions have been made
registry backends of their own.

(This used to be commit e327953bd6b11aeb6f2ae48b49550a942eae8e88)

13 years agoAdd a registry backend perflib that replaces the former dynamic overlay.
Michael Adam [Sun, 20 Jan 2008 02:39:27 +0000 (03:39 +0100)]
Add a registry backend perflib that replaces the former dynamic overlay.

(This used to be commit c3fba415951329ee90c7250b4e8d539f91b227f6)

13 years agoSome reformatting of current_version_fetch_values().
Michael Adam [Sun, 20 Jan 2008 02:25:54 +0000 (03:25 +0100)]
Some reformatting of current_version_fetch_values().

(This used to be commit d2e3814db8a4a5f0fc097e9f56753888470ef213)

13 years agoAdd a registry backend current_version that replaces the former dynamic overlay.
Michael Adam [Sun, 20 Jan 2008 02:24:13 +0000 (03:24 +0100)]
Add a registry backend current_version that replaces the former dynamic overlay.

Make sure to only respond to the exact current version key since subkeys
are registered by other backends (printing and - soon - perflib).

(This used to be commit 2c650bf63ccd9dc5dddbf4700831489544ded055)

13 years agoReorder the registry key name constants in a more systematic way.
Michael Adam [Sun, 20 Jan 2008 01:23:00 +0000 (02:23 +0100)]
Reorder the registry key name constants in a more systematic way.

(This used to be commit faf406a4a1baf2946ea754a0760204748be99541)

13 years agoUse some consts instead of literal strings for registry keys.
Michael Adam [Sun, 20 Jan 2008 00:09:52 +0000 (01:09 +0100)]
Use some consts instead of literal strings for registry keys.

(This used to be commit 80024f4e1c6594c3038e86a765f763d24fd96b59)

13 years agoSome reformatting in hkpt_params_fetch_values().
Michael Adam [Sun, 20 Jan 2008 00:15:31 +0000 (01:15 +0100)]
Some reformatting in hkpt_params_fetch_values().

(This used to be commit f245c4e094ad56080847e286c76976f29c95a221)

13 years agoAdd a registry backend hkpt_params that replaces the former dynamic overlay.
Michael Adam [Sun, 20 Jan 2008 00:00:14 +0000 (01:00 +0100)]
Add a registry backend hkpt_params that replaces the former dynamic overlay.

(This used to be commit 8e8bb6ba120adf9942f612b7fd89bdbced6c1285)

13 years agoSome reformatting in tcpip_params_fetch_values().
Michael Adam [Sun, 20 Jan 2008 00:21:45 +0000 (01:21 +0100)]
Some reformatting in tcpip_params_fetch_values().

(This used to be commit 5b3813b233dc2a60e6d5a9942b4044219d800415)

13 years agoAdd a registry backend tcpip_params that replaces the former dynamic overlay.
Michael Adam [Sat, 19 Jan 2008 22:46:13 +0000 (23:46 +0100)]
Add a registry backend tcpip_params that replaces the former dynamic overlay.

(This used to be commit a8a743b693a162954948ca2438ce4b842c5cba30)

13 years agoSome reformatting in prod_options_fetch_values().
Michael Adam [Sun, 20 Jan 2008 00:25:08 +0000 (01:25 +0100)]
Some reformatting in prod_options_fetch_values().

(This used to be commit 347b9886547516bc2a43190ae7faaf349d2c9d04)

13 years agoAdd a registry backend prod_options that replaces the former dynamic overlay.
Michael Adam [Fri, 18 Jan 2008 15:15:43 +0000 (16:15 +0100)]
Add a registry backend prod_options that replaces the former dynamic overlay.

(This used to be commit d9b89e9d30702f64805b3a3a3612066b19c051d1)

13 years agoSome reformatting in netlogon_params_fetch_values().
Michael Adam [Sun, 20 Jan 2008 00:30:38 +0000 (01:30 +0100)]
Some reformatting in netlogon_params_fetch_values().

(This used to be commit 24f13fb72e4cbaba48235fa840b2a93bf1c5d9c3)

13 years agoRename netlogon_params_fetch_reg_values() to netlogon_params_fetch_values().
Michael Adam [Sat, 19 Jan 2008 21:42:30 +0000 (22:42 +0100)]
Rename netlogon_params_fetch_reg_values() to netlogon_params_fetch_values().

(This used to be commit 54e7c8098565495a833500d4b2a8d5240ed55c82)

13 years agoIn reg_backend_netlogon_params, delegate fetch_subkeys() to regdb.
Michael Adam [Sat, 19 Jan 2008 21:39:33 +0000 (22:39 +0100)]
In reg_backend_netlogon_params, delegate fetch_subkeys() to regdb.

In order to be able to open the netlogon_params key (the new backend replacing
the former dynamic overlay), certain methods need to be provided. Delegate these
to the regdb backend (like e.g. the smbconf backend does).

(This used to be commit 9261b2c4bf48e133eecda9ec0095bd8edf20326c)

13 years agoFix registering Registry backends in reghook_cache_add().
Michael Adam [Fri, 18 Jan 2008 16:51:57 +0000 (17:51 +0100)]
Fix registering Registry backends in reghook_cache_add().

This was broken in 331c0d6216e1a1607a49ed7eb4078e10138ec16a
(pstring removal).

(This used to be commit 7d1e986f3a5ab316a8501ddaca1ba1f0867b4531)

13 years agoUse constant KEY_NETLOGON_PARAMS instead of literal key.
Michael Adam [Fri, 18 Jan 2008 15:13:01 +0000 (16:13 +0100)]
Use constant KEY_NETLOGON_PARAMS instead of literal key.

(This used to be commit daf37c954572bbf652506daae9ff0c9c365b2a9e)

13 years agoVolker is right: why keep commented out migrated dynamic reg overlays around?...
Michael Adam [Fri, 18 Jan 2008 11:13:37 +0000 (12:13 +0100)]
Volker is right: why keep commented out migrated dynamic reg overlays around?...

(This used to be commit a73b8d16aa0f7a3bb7417e9839e04380e6a68629)

13 years agoUse c99 struct initializers for REGISTRY_OPS in reg_shares.c
Michael Adam [Sat, 19 Jan 2008 22:09:38 +0000 (23:09 +0100)]
Use c99 struct initializers for REGISTRY_OPS in reg_shares.c

(This used to be commit 2c4dfd7aaa3c3b384b547451f914a86f59157928)

13 years agoUse c99 struct initializers for REGISTRY_OPS in reg_printing.c
Michael Adam [Sat, 19 Jan 2008 22:06:12 +0000 (23:06 +0100)]
Use c99 struct initializers for REGISTRY_OPS in reg_printing.c

(This used to be commit a89bee4139666ba163385c9e7d15fbc5d623ed6f)

13 years agoUse c99 struct initializers for REGISTRY_OPS in reg_smbconf.c.
Michael Adam [Sat, 19 Jan 2008 22:01:58 +0000 (23:01 +0100)]
Use c99 struct initializers for REGISTRY_OPS in reg_smbconf.c.

(This used to be commit 96d116b003c1187869cbdbc21274a0b5cb1bf7d6)

13 years agoSome systems do not have XATTR_ defined
Volker Lendecke [Sat, 19 Jan 2008 23:44:14 +0000 (00:44 +0100)]
Some systems do not have XATTR_ defined
(This used to be commit 2cac1d3919a96c480f34c93d8b9b07782d46ed23)

13 years agovfs_streams_depot
Volker Lendecke [Sat, 19 Jan 2008 22:36:34 +0000 (23:36 +0100)]

Store streams in a file each. Not 100% finished, and not built by default.
(This used to be commit 5f5fc72b01c8e8fc096375c7cb4a97186c387259)

13 years agovfs_streams_xattr module
Volker Lendecke [Sat, 19 Jan 2008 22:33:11 +0000 (23:33 +0100)]
vfs_streams_xattr module

Store streams in posix xattrs. A kludge, as xattrs are limited in many ways,
but it might be a help for some situations.
(This used to be commit 83a805220e52742119546c76a054d50582e33a24)

13 years agoAdd streams support
Volker Lendecke [Sat, 19 Jan 2008 22:25:36 +0000 (23:25 +0100)]
Add streams support

This is the core of the streams support. The main change is that in
files_struct there is now a base_fsp pointer that holds the main file open
while a stream is open. This is necessary to get the rather strange delete
semantics right: You can't delete the main file while a stream is open without
FILE_SHARE_DELETE, and while a stream is open a successful unlink of the main
file leads to DELETE_PENDING for all further access on the main file or any
(This used to be commit 6022873cc155bdbbd3fb620689715f07a24d6ed1)

13 years agoAdd "split_ntfs_stream_name()" together with a torture test
Volker Lendecke [Sat, 19 Jan 2008 22:10:09 +0000 (23:10 +0100)]
Add "split_ntfs_stream_name()" together with a torture test
(This used to be commit d813bd9e02d9baf916eb96c478be89f0c435e07c)

13 years agoAdd an error mapping for ENOATTR
Volker Lendecke [Sat, 19 Jan 2008 21:44:55 +0000 (22:44 +0100)]
Add an error mapping for ENOATTR
(This used to be commit 9f0d778490415b05224f36287df999672ee16928)

13 years agoAdd the STREAMINFO vfs call
Volker Lendecke [Sat, 19 Jan 2008 19:41:15 +0000 (20:41 +0100)]
Add the STREAMINFO vfs call

Based on jpeach's work, modified the streaminfo prototype

Make use of it in trans2.c together with marshall_stream_info()
(This used to be commit c34d729c7c0600a8f11bf7e489a634a4e37fe88e)

13 years agoUse SAFE_FREE instead of free
Volker Lendecke [Sat, 19 Jan 2008 18:31:02 +0000 (19:31 +0100)]
Use SAFE_FREE instead of free
(This used to be commit 999647329028147d7c29a3348202641b3e03430e)

13 years agoTiny memory leak in lib/version.c
Corinna Vinschen [Sat, 19 Jan 2008 14:14:45 +0000 (15:14 +0100)]
Tiny memory leak in lib/version.c


while implementing the extra_info version stuff, it occured to me that
samba_version_string() potentially allocates memory which is unused but
never free'd.

If SAMBA_VERSION_VENDOR_PATCH is defined, a second call to asprintf
takes place.  The result is stored in tmp_version.  Afterwards,
samba_version is set to tmp_version without free'ing samba_version
first.  Looks like a simple free(samba_version) is missing.  Patch
against 3.2-test below.

Ok, this only happens once over the lifetime of the application, so it's
no big deal, but I though it doesn't hurt to mention it.


* lib/version.c (samba_version_string): Free samba_version
before setting to tmp_version.
(This used to be commit 373a23d48f2dd24e65dbf814ea58b4add2322128)

13 years agoFix error return in xattr_tdb_load_attrs
Volker Lendecke [Sat, 19 Jan 2008 14:44:48 +0000 (15:44 +0100)]
Fix error return in xattr_tdb_load_attrs
(This used to be commit 64e54ea8f76fe57193955aabc1459fe635233aca)

13 years agoThe remote storage op is gone
Volker Lendecke [Sat, 19 Jan 2008 15:19:08 +0000 (16:19 +0100)]
The remote storage op is gone

Alexander, I think this ok...
(This used to be commit 197b08ad789c4968155f1c711ef43a5383a89289)

13 years agoAdd get_ea_names_from_file to sanely list posix xattrs
Volker Lendecke [Sat, 19 Jan 2008 15:07:56 +0000 (16:07 +0100)]
Add get_ea_names_from_file to sanely list posix xattrs

Refactor get_ea_list_from_file to use that.
(This used to be commit aec357a456798050abe565d2a744ed5f17ad5901)

13 years agoMake get_ea_value public
Volker Lendecke [Tue, 15 Jan 2008 12:22:39 +0000 (13:22 +0100)]
Make get_ea_value public
(This used to be commit 0aa406bbba8699063ea3758b19dca24cf42ff15a)

13 years agoFix the build
Volker Lendecke [Sat, 19 Jan 2008 12:37:40 +0000 (13:37 +0100)]
Fix the build

... forgot to "git add" it
(This used to be commit 6d0a727f26dd0945634486f18a55aa8dd5813983)

13 years agoafs: Use talloc_stackframe() instead of talloc_init()
Kai Blin [Sat, 19 Jan 2008 11:27:31 +0000 (12:27 +0100)]
afs: Use talloc_stackframe() instead of talloc_init()

Thanks to vl for pointing this out.
(This used to be commit 76cf5a979bf3014b1de660520e538546b3676b23)

13 years agontlm_auth: Get rid of statics in manage_squid_ntlmssp_request
Kai Blin [Sat, 19 Jan 2008 11:29:03 +0000 (12:29 +0100)]
ntlm_auth: Get rid of statics in manage_squid_ntlmssp_request
(This used to be commit 97768628f5ec533818b7f5165e92c156d668b79b)

13 years agontlm_auth: Rewrite manage_client_ntlmssp_request without statics.
Kai Blin [Fri, 18 Jan 2008 13:40:47 +0000 (14:40 +0100)]
ntlm_auth: Rewrite manage_client_ntlmssp_request without statics.
(This used to be commit af438426222f4990f3e4103babbbb5de03ade93d)

13 years agonltm_auth: Use struct ntlm_auth_state in helper functions.
Kai Blin [Fri, 18 Jan 2008 09:37:16 +0000 (10:37 +0100)]
nltm_auth: Use struct ntlm_auth_state in helper functions.

Now rewriting the helpers one after the other can start.
(This used to be commit 2479a0c3adf46b2d0a9b109ce689c93296f16a62)

13 years agontlm_auth: Prepare for a deeper rewrite of the helper functions
Kai Blin [Wed, 16 Jan 2008 13:45:22 +0000 (14:45 +0100)]
ntlm_auth: Prepare for a deeper rewrite of the helper functions
(This used to be commit f8243d1913cd19401ce6a13f53c6b84a36fc9dd6)

13 years agontlm_auth: Dynamically allocate the read buffer.
Kai Blin [Wed, 16 Jan 2008 08:52:26 +0000 (09:52 +0100)]
ntlm_auth: Dynamically allocate the read buffer.

This ports over my changes from Samba4
(This used to be commit 4a475baf26ba9f99bc05f13dd2745494174a00c1)

13 years agoLink ndr_xattr.o with LIBNDR_GEN_OBJ
Volker Lendecke [Sat, 19 Jan 2008 11:54:46 +0000 (12:54 +0100)]
Link ndr_xattr.o with LIBNDR_GEN_OBJ

It will be used elsewhere (net xattr for example)
(This used to be commit 924c4ede2acbd4e1d327ccdefc92bbbb3d67d7d8)

13 years agoActually test vl's new code and make it work to fix the build farm :-).
Jeremy Allison [Sat, 19 Jan 2008 02:39:27 +0000 (18:39 -0800)]
Actually test vl's new code and make it work to fix the build farm :-).
(This used to be commit 63defd3e9d4ba3f02f36ec5ad7b73463f31962a1)

13 years agoAlways return nlink=1 for directories
Volker Lendecke [Thu, 17 Jan 2008 16:48:33 +0000 (17:48 +0100)]
Always return nlink=1 for directories

I did not test it, but it should not affect cifsfs, there are special posix
calls that also return the stat information unfiltered.
(This used to be commit e96cf1309e45628f4c27d03f77a4eef5e00602df)

13 years agoutil_str: Don't return memory from talloc_tos(), use mem_ctx instead.
Kai Blin [Sat, 19 Jan 2008 01:12:35 +0000 (02:12 +0100)]
util_str: Don't return memory from talloc_tos(), use mem_ctx instead.
(This used to be commit ab0ee6e9a6a9eee317228f0c2bde254ad9a59b85)

13 years agoFix error message for new allinfo command.
Jeremy Allison [Fri, 18 Jan 2008 21:47:10 +0000 (13:47 -0800)]
Fix error message for new allinfo command.
(This used to be commit 3a1bcbfa7ca2b55265eb486e2b7c740e04775698)

13 years agoFix typo that disabled setting group id. Thanks, Henrik.
Derrell Lipman [Fri, 18 Jan 2008 19:22:49 +0000 (14:22 -0500)]
Fix typo that disabled setting group id.  Thanks, Henrik.
(This used to be commit 843e1694cfe4a999ed14a9c215b8e77723d0fe79)

13 years agoRevert "Host SerNet-AIX has __ss_family instead of ss_family in sockaddr_storage"
Stefan Metzmacher [Tue, 15 Jan 2008 15:34:06 +0000 (16:34 +0100)]
Revert "Host SerNet-AIX has __ss_family instead of ss_family in sockaddr_storage"

This reverts commit e33286f4a68352e55df081d06307f64f190773b3.

393bab185e0e9f02aac5740becc2aba2762133c8 is the v4-0-test fix
for the same problem.

(This used to be commit b8a57a24c390355c4950ca499c1d96aff80abad7)

13 years agolibreplace: Escape asterisk.
Jelmer Vernooij [Mon, 14 Jan 2008 21:24:07 +0000 (22:24 +0100)]
libreplace: Escape asterisk.
(cherry picked from commit df36c78549b40ee5e47d5cc79de2eb79f58c567a)
(This used to be commit 174a45ec18fff064d89f6a12b044973ab3c10c54)