ira/wip.git
7 years agoselftest: re-implement directory option for planpythontestsuite.
Jelmer Vernooij [Thu, 10 Nov 2011 12:59:21 +0000 (13:59 +0100)]
selftest: re-implement directory option for planpythontestsuite.

7 years agoRevert "test: added directory option to planpythontestsuite()"
Jelmer Vernooij [Thu, 10 Nov 2011 12:46:01 +0000 (13:46 +0100)]
Revert "test: added directory option to planpythontestsuite()"

This reverts commit b0be72d5080aed3da3f33a45b72f88e90fbe3d13.

I'll add an alternative that uses subunit.run.

7 years agoRevert "test: added -D option to subunitrun"
Jelmer Vernooij [Thu, 10 Nov 2011 12:43:43 +0000 (13:43 +0100)]
Revert "test: added -D option to subunitrun"

This reverts commit ac0bba2ea18e2e9ac578a333a3b260951e4c976e.

"python -m subunit.run" is the preferred way of running tests to
generate subunit. I also don't want to move too far away from
the standard test running infrastructure for python so that
other test runners (nosetests, trial, tribunal, ...) can be used with
Samba code.

7 years agoRevert "pyldb: fixed ldb API test"
Jelmer Vernooij [Thu, 10 Nov 2011 12:40:03 +0000 (13:40 +0100)]
Revert "pyldb: fixed ldb API test"

This reverts commit 333248f08c83cc5b18f8e7e84cb19d79a8309d6e.

This commit made the pyldb tests depend on the Samba testsuite.

7 years agolibcli/cldap/cldap.c - remove outdated comment
Matthias Dieter Wallnöfer [Thu, 10 Nov 2011 16:13:29 +0000 (17:13 +0100)]
libcli/cldap/cldap.c - remove outdated comment

Reviewed-by: metze
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Thu Nov 10 20:32:08 CET 2011 on sn-devel-104

7 years agos3: server_id.pid has turned 64 (bits, that is)
Volker Lendecke [Thu, 10 Nov 2011 16:17:20 +0000 (17:17 +0100)]
s3: server_id.pid has turned 64 (bits, that is)

Fix ctdb_processes_exist protocol. The socket expects pid_t which is 32 bits on
32 bit machines.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu Nov 10 18:57:01 CET 2011 on sn-devel-104

7 years agos3: Avoid a race with the async echo handler
Volker Lendecke [Thu, 10 Nov 2011 08:39:23 +0000 (09:39 +0100)]
s3: Avoid a race with the async echo handler

We can not read from the echo handler socket when we have the main socket
locked. This leads to the echo responder to lock up sitting in the fcntl lock
while the parent wants to read the remainder of a large packet.

7 years agolibcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)
Stefan Metzmacher [Thu, 10 Nov 2011 13:43:55 +0000 (14:43 +0100)]
libcli/cldap: fix a crash bug in cldap_socket_recv_dgram() (bug #8593)

After a calling any wrapper of tevent_req_notify_callback(),
e.g. tevent_req_nterror(), tevent_req_done(), tevent_req_nomem(),
a function has to return immediately otherwise it is very likely to
crash, unless in calls tevent_req_defer_callback() before.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 16:31:59 CET 2011 on sn-devel-104

7 years agos4:finddcs_cldap: debug the correct server address instead of NULL
Stefan Metzmacher [Thu, 10 Nov 2011 12:18:20 +0000 (13:18 +0100)]
s4:finddcs_cldap: debug the correct server address instead of NULL

metze

7 years agos3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)
Stefan Metzmacher [Wed, 9 Nov 2011 15:04:09 +0000 (16:04 +0100)]
s3:smbd: don't limit the number of open dptrs for smb2 (bug #8592)

This fixes a crash bug that is triggered, when a client has more than
256 directory handles with searches.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Thu Nov 10 14:08:14 CET 2011 on sn-devel-104

7 years agos3:smbd: fully construct the dptr before allocating a dnum in the bitmap
Stefan Metzmacher [Wed, 9 Nov 2011 14:59:22 +0000 (15:59 +0100)]
s3:smbd: fully construct the dptr before allocating a dnum in the bitmap

metze

7 years agos3:smbd: avoid string_set() in dir.c
Stefan Metzmacher [Thu, 10 Nov 2011 09:39:34 +0000 (10:39 +0100)]
s3:smbd: avoid string_set() in dir.c

And do some more error checks.

metze

7 years agoFix -Wunused-but-set-variable compiler warnings in tevent_signal.c
Martin Schwenke [Wed, 9 Nov 2011 23:46:10 +0000 (10:46 +1100)]
Fix -Wunused-but-set-variable compiler warnings in tevent_signal.c

The results of some read(2) and write(2) calls are assigned into a
variable that is never used.  Presumably this used to avoid compiler
warnings or similar.

However, from (approximately) GCC 4.6 this produces some warnings:

  [ 609/3910] Compiling lib/tevent/tevent_signal.c
  ../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’:
  ../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
  ../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’:
  ../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]

The simplest thing to do is remove the variables and cast the function
return to void.  There is already a comment above each call.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos4: samba-tool time --help documentation improvements
Theresa Halloran [Thu, 10 Nov 2011 01:16:33 +0000 (20:16 -0500)]
s4: samba-tool time --help documentation improvements

Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104

7 years agos4: samba-tool group --help documentation improvements
Theresa Halloran [Wed, 9 Nov 2011 21:33:37 +0000 (16:33 -0500)]
s4: samba-tool group --help documentation improvements

Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: fixed several tests to use samba.tests
Andrew Tridgell [Wed, 9 Nov 2011 02:28:02 +0000 (13:28 +1100)]
test: fixed several tests to use samba.tests

this fixes error checking. Test failures were not being detected
otherwise

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agosamba-tool: print samaccountname in samba-tool user list
Andrew Tridgell [Wed, 9 Nov 2011 02:27:20 +0000 (13:27 +1100)]
samba-tool: print samaccountname in samba-tool user list

this is the attribute the admin needs for other commands

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: use planpythontestsuite() for ldb.python test
Andrew Tridgell [Wed, 9 Nov 2011 02:10:49 +0000 (13:10 +1100)]
test: use planpythontestsuite() for ldb.python test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: added directory option to planpythontestsuite()
Andrew Tridgell [Wed, 9 Nov 2011 02:10:24 +0000 (13:10 +1100)]
test: added directory option to planpythontestsuite()

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: added -D option to subunitrun
Andrew Tridgell [Wed, 9 Nov 2011 02:10:00 +0000 (13:10 +1100)]
test: added -D option to subunitrun

this allows for:

 subunitrun -D lib/ldb/tests/python api

which makes this easier for developers

7 years agopyldb: fixed ldb API test
Andrew Tridgell [Wed, 9 Nov 2011 02:09:08 +0000 (13:09 +1100)]
pyldb: fixed ldb API test

it was failing previously, but the failure wasn't being noticed

7 years agobuild: only run symbol checking if running all tests
Andrew Tridgell [Wed, 9 Nov 2011 02:08:37 +0000 (13:08 +1100)]
build: only run symbol checking if running all tests

this makes it much faster to run 1 test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agopyldb: enhanced get() method on msg object
Andrew Tridgell [Wed, 9 Nov 2011 02:07:53 +0000 (13:07 +1100)]
pyldb: enhanced get() method on msg object

get() now takes a default value and an idx, allowing for much easier
usage

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agosamba-tool: Added new "user disable" command
Giampaolo Lauria [Tue, 8 Nov 2011 19:59:19 +0000 (14:59 -0500)]
samba-tool: Added new "user disable" command

7 years agosamba-tool: Added "user list" command
Giampaolo Lauria [Tue, 8 Nov 2011 16:51:42 +0000 (11:51 -0500)]
samba-tool: Added "user list" command

7 years agosamba-tool: Change internal argument name in domain machinepassword
Giampaolo Lauria [Mon, 7 Nov 2011 18:39:07 +0000 (13:39 -0500)]
samba-tool: Change internal argument name in domain machinepassword

7 years agosamba-tool: Fix domain machinepassword secret db search
Giampaolo Lauria [Tue, 1 Nov 2011 19:28:54 +0000 (15:28 -0400)]
samba-tool: Fix domain machinepassword secret db search

pair programmed with Jelmer Vernooij
Add search to include secrets.ldb

7 years agosamba-tool: Fix domain machinepassword name search
Giampaolo Lauria [Tue, 1 Nov 2011 19:25:31 +0000 (15:25 -0400)]
samba-tool: Fix domain machinepassword name search

Append '$' to name provided by user to search for a machine account
when necessary

7 years agos4-test: improved error checking in samba-tool time test
Andrew Tridgell [Mon, 7 Nov 2011 04:24:01 +0000 (15:24 +1100)]
s4-test: improved error checking in samba-tool time test

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agos4-socket: detect NULL server in socket connection code
Andrew Tridgell [Mon, 7 Nov 2011 04:19:09 +0000 (15:19 +1100)]
s4-socket: detect NULL server in socket connection code

return NT_STATUS_NOT_FOUND instead of a segfault

Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>

7 years agotest: enable time and user samba-tool tests
Sean Dague [Wed, 2 Nov 2011 14:02:47 +0000 (10:02 -0400)]
test: enable time and user samba-tool tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: add samba-tool user tests
Sean Dague [Wed, 2 Nov 2011 14:02:29 +0000 (10:02 -0400)]
test: add samba-tool user tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: Add samba-tool time tests
Sean Dague [Wed, 2 Nov 2011 14:02:09 +0000 (10:02 -0400)]
test: Add samba-tool time tests

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agotest: add directory and base class for samba-tool tests
Sean Dague [Wed, 2 Nov 2011 14:01:42 +0000 (10:01 -0400)]
test: add directory and base class for samba-tool tests

this allows for more sophisticated testing of samba-tool

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agos4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations
Andrew Bartlett [Thu, 3 Nov 2011 21:45:49 +0000 (08:45 +1100)]
s4-setup Remove servicePrincipalName: DNS/${DNSDOMAIN} from new installations

This servicePrincipalName is incorrect (windows does not use that
servicePrincipalName, as it targets the server it is updating, not the
root of the DNS tree), and now that we have multiple DNS backends that
use the internal database, it is quite incorrect (as it cannot exist
on more than one account).

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104

7 years agos3-py_passdb Ensure that group mapping list input is initailised
Andrew Bartlett [Tue, 8 Nov 2011 21:15:31 +0000 (08:15 +1100)]
s3-py_passdb Ensure that group mapping list input is initailised

This may help to ensure we consistantly crash on an incorrect de-reference.

Andrew Bartlett

7 years agos3-passdb Initialise the correct level of pointer dereference
Andrew Bartlett [Tue, 8 Nov 2011 21:11:32 +0000 (08:11 +1100)]
s3-passdb Initialise the correct level of pointer dereference

*pp_rmap may be NULL or un-initialised data.

This was introduced by 995d1567265be178b4e45f79ea4562a7041ffa52.

Andrew Bartlett

7 years agos4:join.py - fix up "DsAddEntry" against Windows Server 2000
Matthias Dieter Wallnöfer [Wed, 9 Nov 2011 08:32:55 +0000 (09:32 +0100)]
s4:join.py - fix up "DsAddEntry" against Windows Server 2000

It is important to consider the result level regarding error
information. Windows 2000 seems to send us back v2, all other
implementations v3. Consider post "Joining W2k AD domain"

Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov  9 23:37:08 CET 2011 on sn-devel-104

7 years agodocs: Make clear to use the workgroup name not the realm.
Andreas Schneider [Wed, 9 Nov 2011 18:08:16 +0000 (19:08 +0100)]
docs: Make clear to use the workgroup name not the realm.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 21:17:09 CET 2011 on sn-devel-104

7 years agos4: Install samba-tool and samba_kcc to bin/ rather than sbin/.
Jelmer Vernooij [Mon, 7 Nov 2011 13:58:10 +0000 (14:58 +0100)]
s4: Install samba-tool and samba_kcc to bin/ rather than sbin/.

Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov  9 19:43:07 CET 2011 on sn-devel-104

7 years agosamba_kcc: Remove unnecessary return statements.
Jelmer Vernooij [Mon, 7 Nov 2011 01:04:52 +0000 (02:04 +0100)]
samba_kcc: Remove unnecessary return statements.

7 years agoutil/time: Make some functions explicitly public.
Jelmer Vernooij [Thu, 3 Nov 2011 16:22:40 +0000 (17:22 +0100)]
util/time: Make some functions explicitly public.

7 years agoutil/time: Remove unnecessary _PUBLIC_ - that's implicit for things in header files.
Jelmer Vernooij [Thu, 3 Nov 2011 13:34:08 +0000 (14:34 +0100)]
util/time: Remove unnecessary _PUBLIC_ - that's implicit for things in header files.

7 years agos3:registry: prevent unnecessary transactions in regdb_init
Michael Adam [Wed, 9 Nov 2011 10:14:38 +0000 (11:14 +0100)]
s3:registry: prevent unnecessary transactions in regdb_init

Skip the transaction for the upgrade code, if the database
is already at code-level.

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 15:06:59 CET 2011 on sn-devel-104

7 years agos3: Use autotools to set the winbind socket directory.
Andreas Schneider [Wed, 9 Nov 2011 10:33:47 +0000 (11:33 +0100)]
s3: Use autotools to set the winbind socket directory.

Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov  9 13:31:27 CET 2011 on sn-devel-104

7 years agos3:smb2_server: grant credits in async interim responses (bug #8357)
Stefan Metzmacher [Tue, 8 Nov 2011 16:50:43 +0000 (17:50 +0100)]
s3:smb2_server: grant credits in async interim responses (bug #8357)

The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 11:56:29 CET 2011 on sn-devel-104

7 years agos3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)
Stefan Metzmacher [Wed, 9 Nov 2011 07:09:17 +0000 (08:09 +0100)]
s3:libsmb: consistently use state->size in cli_write_andx_create() (bug #5326)

Otherwise we may get unexpected results.

This is a fix that was missing in commit 95595dd93fd04999fcf56ecaab7c29b064d021f8
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov  9 10:13:32 CET 2011 on sn-devel-104

7 years agos4-provision: Create ldap records for DNS partitions similar to windows
Amitay Isaacs [Tue, 20 Sep 2011 07:33:20 +0000 (17:33 +1000)]
s4-provision: Create ldap records for DNS partitions similar to windows

this allows easy comparison between windows and samba ldap trees

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Nov  9 08:27:46 CET 2011 on sn-devel-104

7 years agos4-provision: Set security descriptor for DNS records
Amitay Isaacs [Tue, 20 Sep 2011 07:30:10 +0000 (17:30 +1000)]
s4-provision: Set security descriptor for DNS records

7 years agos4:torture:smb2: rewrite durable-open.open test to use smb2_*_create functions
Michael Adam [Tue, 8 Nov 2011 23:22:55 +0000 (00:22 +0100)]
s4:torture:smb2: rewrite durable-open.open test to use smb2_*_create functions

Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov  9 02:36:36 CET 2011 on sn-devel-104

7 years agos4:torture:smb2: rewrite the durable-open.lock test to use smb2_lease_create()
Michael Adam [Tue, 8 Nov 2011 21:03:04 +0000 (22:03 +0100)]
s4:torture:smb2: rewrite the durable-open.lock test to use smb2_lease_create()

7 years agos4:torture:smb2: rewrite the durable-open.lease test to use smb2_lease_create()
Michael Adam [Tue, 8 Nov 2011 20:59:18 +0000 (21:59 +0100)]
s4:torture:smb2: rewrite the durable-open.lease test to use smb2_lease_create()

7 years agos4:torture:smb2: rewrite the durable-open.oplock test to use smb2_oplock_create()
Michael Adam [Tue, 8 Nov 2011 17:48:25 +0000 (18:48 +0100)]
s4:torture:smb2: rewrite the durable-open.oplock test to use smb2_oplock_create()

7 years agos4:torture:smb2: rewrite the durable-open.file-position test to use smb2_oplock_create()
Michael Adam [Tue, 8 Nov 2011 17:44:54 +0000 (18:44 +0100)]
s4:torture:smb2: rewrite the durable-open.file-position test to use smb2_oplock_create()

7 years agos4:torture:smb2: rewrite the durable-open.open2 test to use smb2_lease_create_share()
Michael Adam [Tue, 8 Nov 2011 17:39:45 +0000 (18:39 +0100)]
s4:torture:smb2: rewrite the durable-open.open2 test to use smb2_lease_create_share()

7 years agos4:torture:smb2: rewrite the durable-open.open1 test to use smb2_oplock_create_share()
Michael Adam [Tue, 8 Nov 2011 17:31:17 +0000 (18:31 +0100)]
s4:torture:smb2: rewrite the durable-open.open1 test to use smb2_oplock_create_share()

7 years agos4:torture:smb2: add smb2_oplock_create_share() that takes sharemode as parameter
Michael Adam [Tue, 8 Nov 2011 17:22:47 +0000 (18:22 +0100)]
s4:torture:smb2: add smb2_oplock_create_share() that takes sharemode as parameter

7 years agos4:torture:smb2: add smb2_lease_create_share() that takes a sharemode as parameter
Michael Adam [Tue, 8 Nov 2011 17:19:54 +0000 (18:19 +0100)]
s4:torture:smb2: add smb2_lease_create_share() that takes a sharemode as parameter

7 years agos4:torture:smb2: add smb2_generic_create_share() that also takes the sharemode as...
Michael Adam [Tue, 8 Nov 2011 17:15:12 +0000 (18:15 +0100)]
s4:torture:smb2: add smb2_generic_create_share() that also takes the sharemode as parameter

7 years agos4:torture:smb2: move the smb2_create_*() utility functions from lease.c to util...
Michael Adam [Tue, 8 Nov 2011 17:13:41 +0000 (18:13 +0100)]
s4:torture:smb2: move the smb2_create_*() utility functions from lease.c to util.c for re-use

7 years agos4:torture:smb2: use smb2_util_oplock_level() in the durable-open test for convenience
Michael Adam [Tue, 8 Nov 2011 15:34:51 +0000 (16:34 +0100)]
s4:torture:smb2: use smb2_util_oplock_level() in the durable-open test for convenience

7 years agos4:torture:smb2: lease: oplock_level is uint8_t, not uint32_t or int
Michael Adam [Tue, 8 Nov 2011 15:33:56 +0000 (16:33 +0100)]
s4:torture:smb2: lease: oplock_level is uint8_t, not uint32_t or int

7 years agos4:torture:smb2: move oplock() from lease.c to smb2_util_oplock_level() in util.c...
Michael Adam [Tue, 8 Nov 2011 15:26:02 +0000 (16:26 +0100)]
s4:torture:smb2: move oplock() from lease.c to smb2_util_oplock_level() in util.c for re-use

7 years agos4:torture:smb2: extract map_sharemode() to smb2_util_share_access() in util.c
Michael Adam [Tue, 8 Nov 2011 07:34:38 +0000 (08:34 +0100)]
s4:torture:smb2: extract map_sharemode() to smb2_util_share_access() in util.c

7 years agos4:torture:smb2: use common smb2_util_lease_state() in the lease tests
Michael Adam [Tue, 8 Nov 2011 07:12:55 +0000 (08:12 +0100)]
s4:torture:smb2: use common smb2_util_lease_state() in the lease tests

7 years agos4:torture:smb2: extract map_lease() to util.c as smb2_util_lease_state().
Michael Adam [Tue, 8 Nov 2011 07:04:28 +0000 (08:04 +0100)]
s4:torture:smb2: extract map_lease() to util.c as smb2_util_lease_state().

7 years agos4:torture:smb2: fix illegal write/uninitialized data bug in the lease.multibreak...
Michael Adam [Wed, 2 Nov 2011 14:46:49 +0000 (15:46 +0100)]
s4:torture:smb2: fix illegal write/uninitialized data bug in the lease.multibreak test

7 years agos4:torture:smb2: lease.update2: some more reasonable struct names and a comment
Michael Adam [Tue, 1 Nov 2011 22:50:01 +0000 (23:50 +0100)]
s4:torture:smb2: lease.update2: some more reasonable struct names and a comment

7 years agos4:torture:smb2: change the test file name in the durable-open.oplock test
Michael Adam [Tue, 1 Nov 2011 13:55:37 +0000 (14:55 +0100)]
s4:torture:smb2: change the test file name in the durable-open.oplock test

to a more reasonable name. This one must have been copied
from the durable-open.lease test.

7 years agosamr: filterModuleName is a lsa_String in userPwdChangeFailureInformation.
Günther Deschner [Tue, 8 Nov 2011 15:00:10 +0000 (16:00 +0100)]
samr: filterModuleName is a lsa_String in userPwdChangeFailureInformation.

The entire marshalling of samr_ChangePasswordUser3 broke with c2685cdedb430ae75a94e86f34484292b4269363.

Matthias, the bad effect of this change was that actually all failed password
change attempts will always return NT_STATUS_OK because the last 4 bytes (the
resulting status code) were not marshalled anymore.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed Nov  9 00:41:13 CET 2011 on sn-devel-104

7 years agos4-smbtorture: demonstrate how broken our samr_ChangePasswordUser3 marshalling is...
Günther Deschner [Tue, 8 Nov 2011 14:58:34 +0000 (15:58 +0100)]
s4-smbtorture: demonstrate how broken our samr_ChangePasswordUser3 marshalling is...

Guenther

7 years agos4:samba-tool user command - always initialise the boolean arguments properly
Matthias Dieter Wallnöfer [Tue, 8 Nov 2011 19:46:25 +0000 (20:46 +0100)]
s4:samba-tool user command - always initialise the boolean arguments properly

It they haven't been specified.

Reviewed-by: Jelmer
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Tue Nov  8 22:28:38 CET 2011 on sn-devel-104

7 years agos4:samba-tool - other fix for Gémes Géza patch regarding parameter handling
Matthias Dieter Wallnöfer [Mon, 7 Nov 2011 16:57:52 +0000 (17:57 +0100)]
s4:samba-tool - other fix for Gémes Géza patch regarding parameter handling

The condition has not been specified correctly since we are expecting a boolean.
Pointed out by Jelmer.

Reviewed-by: Jelmer
7 years agos3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)
Stefan Metzmacher [Tue, 8 Nov 2011 07:25:16 +0000 (08:25 +0100)]
s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326)

Print shares doesn't support CAP_LARGE_WRITEX, while it's negotiated
by the file server part.

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Tue Nov  8 17:01:36 CET 2011 on sn-devel-104

7 years agos3:libsmb: correctly parse the LANMAN2.1 negprot response from OS/2 (bug #8584)
Stefan Metzmacher [Tue, 8 Nov 2011 07:14:31 +0000 (08:14 +0100)]
s3:libsmb: correctly parse the LANMAN2.1 negprot response from OS/2 (bug #8584)

metze

7 years agos3:libsmb: key_len is 8bit only in the NT1 case
Stefan Metzmacher [Tue, 8 Nov 2011 07:13:27 +0000 (08:13 +0100)]
s3:libsmb: key_len is 8bit only in the NT1 case

metze

7 years agos3: Remove two unused variables
Volker Lendecke [Tue, 8 Nov 2011 07:38:20 +0000 (08:38 +0100)]
s3: Remove two unused variables

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Tue Nov  8 10:14:36 CET 2011 on sn-devel-104

7 years agos4-provision: site is passed as an argument to setup_ad_dns()
Amitay Isaacs [Tue, 8 Nov 2011 02:58:45 +0000 (13:58 +1100)]
s4-provision: site is passed as an argument to setup_ad_dns()

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Nov  8 06:07:46 CET 2011 on sn-devel-104

7 years agos4-provision Remove options for LDAP backend to reduce user confusion
Andrew Bartlett [Thu, 3 Nov 2011 22:07:17 +0000 (09:07 +1100)]
s4-provision Remove options for LDAP backend to reduce user confusion

We do not support the LDAP backend any more, but keep the code in case someone
comes up with an interesting use case that could leverage this in a very
particular situation.  In order to keep the code, we must test it, so
we keep just this much of the support around.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Tue Nov  8 04:33:49 CET 2011 on sn-devel-104

7 years agos4-s3-upgrade Add my copyright
Andrew Bartlett [Tue, 1 Nov 2011 01:59:02 +0000 (12:59 +1100)]
s4-s3-upgrade Add my copyright

7 years agoparam: Remove duplicate initialization of 'share backend' parameter
Amitay Isaacs [Tue, 1 Nov 2011 05:29:41 +0000 (16:29 +1100)]
param: Remove duplicate initialization of 'share backend' parameter

7 years agos4-smb_server No longer follow the security=share smb.conf directive
Andrew Bartlett [Tue, 1 Nov 2011 20:43:43 +0000 (07:43 +1100)]
s4-smb_server No longer follow the security=share smb.conf directive

By ignoring the value of security= from the smb.conf, we can allow this
to instead set the value of 'server role' in a manner compatible
with the Samba 3.x release stream.

Andrew Bartlett

7 years agoselftest: Remove the 'all' environment as it is just too slow to start up
Andrew Bartlett [Sat, 24 Sep 2011 18:26:48 +0000 (11:26 -0700)]
selftest: Remove the 'all' environment as it is just too slow to start up

Instead we start the 'dc' environment, and other environments are available as:
make testenv SELFTEST_TESTENV=fl2003dc

Andrew Bartlett

7 years agos4-dnsserver: Test forward zones are not listed in reverse zone search
Amitay Isaacs [Mon, 7 Nov 2011 03:40:06 +0000 (14:40 +1100)]
s4-dnsserver: Test forward zones are not listed in reverse zone search

Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Tue Nov  8 01:26:43 CET 2011 on sn-devel-104

7 years agos4-dnsserver: Fix enumeration of zones in ComplexOperation RPC call
Amitay Isaacs [Thu, 3 Nov 2011 05:59:23 +0000 (16:59 +1100)]
s4-dnsserver: Fix enumeration of zones in ComplexOperation RPC call

zone_request_flags are interpreted in different groups rather than
a single group. This correctly returns 0 zones when there are no
reverse zones and DNS_ZONE_REQUEST_REVERSE is set in zone_request_flags.

7 years agoAdd the SEC_DIR_LIST check to dptr_create().
Jeremy Allison [Fri, 4 Nov 2011 23:46:47 +0000 (16:46 -0700)]
Add the SEC_DIR_LIST check to dptr_create().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Nov  7 21:11:03 CET 2011 on sn-devel-104

7 years agos4:samba-tool - fix Gémes Géza patch regarding parameter handling
Matthias Dieter Wallnöfer [Mon, 7 Nov 2011 16:57:52 +0000 (17:57 +0100)]
s4:samba-tool - fix Gémes Géza patch regarding parameter handling

The new "random-password" parameter has not been evaluated correctly.

Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Mon Nov  7 19:35:05 CET 2011 on sn-devel-104

7 years agoAdd a --random-password option to user create command.
Gémes Géza [Wed, 2 Nov 2011 14:33:35 +0000 (15:33 +0100)]
Add a --random-password option to user create command.

Signed-Off-By: Jelmer Vernooij <jelmer@samba.org>
Signed-off-by: Matthias Dieter Wallnöfer <mdw@samba.org>
7 years agos3-wafbuild: Fix inotify detection (bug 8580)
Björn Baumbach [Mon, 7 Nov 2011 13:24:40 +0000 (14:24 +0100)]
s3-wafbuild: Fix inotify detection (bug 8580)

Enable inotify if sys or kernel inotify is available.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov  7 16:28:38 CET 2011 on sn-devel-104

7 years agos3-build: Fix inotify detection (bug 8580)
Björn Baumbach [Mon, 7 Nov 2011 11:42:28 +0000 (12:42 +0100)]
s3-build: Fix inotify detection (bug 8580)

Enable inotify if sys or kernel inotify is available.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
7 years agos3:libsmb: return NT_STATUS_OK for if a request is not the last one in the chain
Stefan Metzmacher [Mon, 7 Nov 2011 07:55:20 +0000 (08:55 +0100)]
s3:libsmb: return NT_STATUS_OK for if a request is not the last one in the chain

metze

Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Mon Nov  7 11:38:05 CET 2011 on sn-devel-104

7 years agos3:libsmb: make sure have_andx_command() returns false for non AndX commands
Stefan Metzmacher [Mon, 7 Nov 2011 07:54:40 +0000 (08:54 +0100)]
s3:libsmb: make sure have_andx_command() returns false for non AndX commands

metze

7 years agos3:libsmb: remember the seqnum on all chained requests
Stefan Metzmacher [Mon, 7 Nov 2011 07:44:39 +0000 (08:44 +0100)]
s3:libsmb: remember the seqnum on all chained requests

This is needed in order to verify the incoming signature
correctly.

metze

7 years agos3:libsmb: get cmd of the chained request before changing wct_ofs
Stefan Metzmacher [Sat, 5 Nov 2011 11:29:23 +0000 (12:29 +0100)]
s3:libsmb: get cmd of the chained request before changing wct_ofs

metze

7 years agos4: samba-tool user --help documenation improvements
Theresa Halloran [Wed, 2 Nov 2011 14:33:12 +0000 (10:33 -0400)]
s4: samba-tool user --help documenation improvements
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Mon Nov  7 01:39:25 CET 2011 on sn-devel-104

7 years agokcc: fixed program name
Andrew Tridgell [Sun, 6 Nov 2011 22:55:01 +0000 (09:55 +1100)]
kcc: fixed program name

kcccompute -> samba_kcc

7 years agokcc: fixed tabs/spaces in kcc python implementation
Andrew Tridgell [Sun, 6 Nov 2011 22:53:06 +0000 (09:53 +1100)]
kcc: fixed tabs/spaces in kcc python implementation

as spotted by autobuild

7 years agosamba_kcc addtion
Dave Craft [Thu, 3 Nov 2011 17:39:53 +0000 (12:39 -0500)]
samba_kcc addtion

Scaffolding and initial implementations of
portions of the KCC in python.  This code currently
properly computes the graph nodes for the intrasite
topology as well as enumerating all steps for a full
run of the KCC.

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agoadd python KCC utility classes and methods
Dave Craft [Thu, 3 Nov 2011 17:37:24 +0000 (12:37 -0500)]
add python KCC utility classes and methods

New file source4/scripting/python/samba/kcc_utils.py
contains classes and methods for:
   DirectoryServiceAgent
   NTDSConnection
   GraphNode
   NamingContext
   NCReplica
These are consumed by a new samba_kcc python script
for KCC topology computation

Signed-off-by: Andrew Tridgell <tridge@samba.org>
7 years agopython dsdb flag addtions (NTDSSETTINGS, NTDSCONN)
Dave Craft [Thu, 3 Nov 2011 17:33:38 +0000 (12:33 -0500)]
python dsdb flag addtions (NTDSSETTINGS, NTDSCONN)

Add missing flags present in C code base to python
code base dsdb/pydsdb.c
   INSTANCE_TYPE...
   DS_NTDSSETTINGS_OPT...
   NTDSCONN_OPT...
These are consumed by the python KCC scripts

Signed-off-by: Andrew Tridgell <tridge@samba.org>