13 years agor25127: Add to the repo.
Simo Sorce [Thu, 13 Sep 2007 12:51:00 +0000 (12:51 +0000)]
r25127: Add to the repo.
This script is useful for migrating OpenLDAP schema files to FDS/RHDS
lidf schema files.

License kindly updated to GPLv3+ at our request.

(This used to be commit ab7770b34b3202a5836cfa098187eeed1bd16be3)

13 years agor25125: create prototypes for 'bool ' functions
Stefan Metzmacher [Thu, 13 Sep 2007 12:25:28 +0000 (12:25 +0000)]
r25125: create prototypes for 'bool ' functions

(This used to be commit 5afa66970ee831a8be887c9e7eeeaceead6049db)

13 years agor25121: Remove pstring limits from much of our string handling function.
Jeremy Allison [Thu, 13 Sep 2007 01:10:01 +0000 (01:10 +0000)]
r25121: Remove pstring limits from much of our string handling function.
Still a few left (mainly the substitute ones).
(This used to be commit 6552e52979a7c6954faa8b2c9c0f08b3779835c4)

13 years agor25120: One more warning.
Jeremy Allison [Thu, 13 Sep 2007 00:31:02 +0000 (00:31 +0000)]
r25120: One more warning.
(This used to be commit 9cc70e3ccff9c3b20076572235d9dcbfd23e97e5)

13 years agor25119: Fix a couple of warnings.
Jeremy Allison [Thu, 13 Sep 2007 00:29:25 +0000 (00:29 +0000)]
r25119: Fix a couple of warnings.
(This used to be commit 0e655ac94653128566a8764ea804f37c4c7b300f)

13 years agor25118: More pstring elimination.
Jeremy Allison [Wed, 12 Sep 2007 23:50:21 +0000 (23:50 +0000)]
r25118: More pstring elimination.
(This used to be commit 7632f8fb4003657591778d2b55f546d1737859d1)

13 years agor25117: The mega-patch Jerry was waiting for. Remove all pstrings from
Jeremy Allison [Wed, 12 Sep 2007 21:48:20 +0000 (21:48 +0000)]
r25117: The mega-patch Jerry was waiting for. Remove all pstrings from
the main server code paths. We should now be able to cope with
paths up to PATH_MAX length now.
Final job will be to add the TALLOC_CTX * parameter to
unix_convert to make it explicit (for Volker).
(This used to be commit 7f0db75fb0f24873577dcb758a2ecee74fdc4297)

13 years agor25116: Fix talloc_asprintf_append to do the right thing with
Jeremy Allison [Wed, 12 Sep 2007 21:41:36 +0000 (21:41 +0000)]
r25116: Fix talloc_asprintf_append to do the right thing with
truncated strings.
(This used to be commit 93c42fd9b52d9135d8c8b52e97cf342c1c5b5010)

13 years agor25111: Move to talloced pathnames on most code paths.
Jeremy Allison [Tue, 11 Sep 2007 23:57:59 +0000 (23:57 +0000)]
r25111: Move to talloced pathnames on most code paths.
There are now ony 17 pstrings left in reply.c,
and these will be easy to remove (and I'll be
doing that shortly). Had to fix an interesting
bug in pull_ucs2_base_talloc() when a source
string is not null terminated :-).
(This used to be commit 0c9a8c4dff10974dbffd2a302ae982896122fcc0)

13 years agor25109: Remove obsolete argument from ads_guess_service_principal().
Günther Deschner [Tue, 11 Sep 2007 23:35:17 +0000 (23:35 +0000)]
r25109: Remove obsolete argument from ads_guess_service_principal().

(This used to be commit 2dea9464bba76af4315a8207ccd3e564ec19d146)

13 years agor25108: Make ifdef labyrinth in sasl code a bit more readable.
Günther Deschner [Tue, 11 Sep 2007 23:21:50 +0000 (23:21 +0000)]
r25108: Make ifdef labyrinth in sasl code a bit more readable.

(This used to be commit f31949ec3456134de474a0219a8cd5dcd15adea6)

13 years agor25107: Fix const warning caused by the way I reformatted this
Simo Sorce [Tue, 11 Sep 2007 23:04:14 +0000 (23:04 +0000)]
r25107: Fix const warning caused by the way I reformatted this
(This used to be commit 6ce01bf41339b4c48aa458bb0667664727d3dac3)

13 years agor25104: Fix extra lines added by mistake.
Jeremy Allison [Tue, 11 Sep 2007 21:52:44 +0000 (21:52 +0000)]
r25104: Fix extra lines added by mistake.
(This used to be commit a28a35f9cdddb9da1b2adb9e2e6c86d78cf07ea6)

13 years agor25103: Ensure we don't return unwritten memory (valgrind caught).
Jeremy Allison [Tue, 11 Sep 2007 19:27:34 +0000 (19:27 +0000)]
r25103: Ensure we don't return unwritten memory (valgrind caught).
(This used to be commit b3f0d39d11fa18b7bfef6cec88efaf4a2be2d6e0)

13 years agor25102: Rewrite msdfs code to use talloced filenames. Passes make test
Jeremy Allison [Tue, 11 Sep 2007 18:31:29 +0000 (18:31 +0000)]
r25102: Rewrite msdfs code to use talloced filenames. Passes make test
and make valgrindtest. Final step will be to change srvstr_get_path()
to return talloced memory in the major codepaths.
(This used to be commit cf6b6f9c3a38b68d2671c753f412772344506742)

13 years agor25099: Commit fix for CVE-2007-4138 from 3.0.26 release.
Gerald Carter [Tue, 11 Sep 2007 18:08:07 +0000 (18:08 +0000)]
r25099: Commit fix for CVE-2007-4138 from 3.0.26 release.
(This used to be commit aa768a4a20930833d6921ed112601873b228a64d)

13 years agor25092: Add support for storing trusted domain passwords in LDAP for
Michael Adam [Tue, 11 Sep 2007 16:50:32 +0000 (16:50 +0000)]
r25092: Add support for storing trusted domain passwords in LDAP for
passdb backend = ldapsam.

Along with reproducing the functionality of the secrets.tdb
code, I have prepared the handling of the previous trust password
(in case we are contacting a dc which does not yet know of a recent
password change). This information has still to be propagated
to the outside, but this requires a change of the api and also
a change of the secrets.tdb code.

(This used to be commit 6c3c20e6c4a2b04de8111f2c79b431f0775c2a0f)

13 years agor25091: Start adding support for storing trusted domain passwords in LDAP
Michael Adam [Tue, 11 Sep 2007 16:38:31 +0000 (16:38 +0000)]
r25091: Start adding support for storing trusted domain passwords in LDAP
(for passdb backen = ldapsam). At a first step, add the hooks,
calling the secrets_ functions.

(This used to be commit 9c03cdf3a449149c50451a44deb420341e65af34)

13 years agor25090: Fix a syntax error just introduced into the LDAP schema.
Michael Adam [Tue, 11 Sep 2007 16:30:38 +0000 (16:30 +0000)]
r25090: Fix a syntax error just introduced into the LDAP schema.

(This used to be commit 7dc68ce0fb4490761326eaaca516fde3bf642ed5)

13 years agor25088: Change the objectclass sambaTrustedDomainPassword to
Michael Adam [Tue, 11 Sep 2007 16:25:47 +0000 (16:25 +0000)]
r25088: Change the objectclass sambaTrustedDomainPassword to
have the current and possibly the previous trust password
stored as clear text passwords. (Previous use of NTPassword
was a mistake - this is a hash value.)

(This used to be commit 0beae52ff469903adbfefdffd93a34bb7ad7d68d)

13 years agor25087: Reformatting: Get rid of an abundance of leading tabs...
Michael Adam [Tue, 11 Sep 2007 16:18:14 +0000 (16:18 +0000)]
r25087: Reformatting: Get rid of an abundance of leading tabs...
(This used to be commit d8676f30d5b8168ff0c82993fb51cff18bea1f96)

13 years agor25086: Fix interdomain trusts (this povides the fix expected in r22709):
Michael Adam [Tue, 11 Sep 2007 16:15:36 +0000 (16:15 +0000)]
r25086: Fix interdomain trusts (this povides the fix expected in r22709):

Fix winbindd on a Samba DC talking to a trusted domain DC by
making it use the trusted domain password...


I hope this does not brake any other setup.
(This used to be commit 2322fe5cd76c5b7214c66f8a403debe1e36a82d6)

13 years agor25080: Once we decrypted the packet but have timing problems (closkew, tkt not yet or
Günther Deschner [Tue, 11 Sep 2007 14:56:43 +0000 (14:56 +0000)]
r25080: Once we decrypted the packet but have timing problems (closkew, tkt not yet or
no longer valid) there is no point to bother the keytab routines.

(This used to be commit 7e4dcf8e7ecfd35668e86e22bed5a9280ae83959)

13 years agor25074: as all requests in the winbindd child are sync, we can use talloc_tos()
Stefan Metzmacher [Tue, 11 Sep 2007 10:21:34 +0000 (10:21 +0000)]
r25074: as all requests in the winbindd child are sync, we can use talloc_tos()

(This used to be commit 6e238fe5b458fc6b9184144fa124f497c81eec8d)

13 years agor25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the
Günther Deschner [Mon, 10 Sep 2007 23:12:27 +0000 (23:12 +0000)]
r25068: Older samba3 DCs will return DCERPC_FAULT_OP_RNG_ERROR for every opcode on the
LSARPC_DS pipe, continue with no_lsarpc_ds mode here as well to get
domain->initialized set to True. This avoids permanent scanning of Samba3 DCs
in winbindd. Thanks Michael, for pointing this out.

(This used to be commit 9b85f7ca43896ddd40dd8cb4a52969e94914db43)

13 years agor25064: We use BOOL/True/False not bool/true/false
Simo Sorce [Mon, 10 Sep 2007 19:19:59 +0000 (19:19 +0000)]
r25064: We use BOOL/True/False not bool/true/false
(This used to be commit f624a269bf242630e9bda7a89b9b0e8e12646982)

13 years agor25063: Fix segfault in smbldp_set_creds when we want to use anonymous, the
Simo Sorce [Mon, 10 Sep 2007 19:14:22 +0000 (19:14 +0000)]
r25063: Fix segfault in smbldp_set_creds when we want to use anonymous, the
code was not passing in the "anon" flag correctly and was passing
NULL pointers.
(This used to be commit 6316a9c14d8bc467c84c1604248a9e30abaacd2f)

13 years agor25062: Reformat, remove trailing spaces and fit lines into 80 columns
Simo Sorce [Mon, 10 Sep 2007 19:04:57 +0000 (19:04 +0000)]
r25062: Reformat, remove trailing spaces and fit lines into 80 columns
(This used to be commit 1850d1c10f1fe77402e0ed79d6980d55d90637fb)

13 years agor25061: Pro-actively shut up Coverity :-)
Volker Lendecke [Mon, 10 Sep 2007 17:49:51 +0000 (17:49 +0000)]
r25061: Pro-actively shut up Coverity :-)
(This used to be commit f2ce4a803cfd04fa993d2d87720b4b6f67fc46db)

13 years agor25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars
Simo Sorce [Mon, 10 Sep 2007 16:56:51 +0000 (16:56 +0000)]
r25060: Fix formatting, remove trailing spaces and cut lines longer than 80 chars
(This used to be commit 7a4d4658904a601ae42ec1804db06cda734553d2)

13 years agor25059: Apply to 3.2 as well
Simo Sorce [Mon, 10 Sep 2007 16:21:55 +0000 (16:21 +0000)]
r25059: Apply to 3.2 as well
(This used to be commit 17a7d33b3bede85d6d64ecadfa065e71739517be)

13 years agor25057: Add a schema file ready to be used in Fedora/RedHat Directory Server
Simo Sorce [Mon, 10 Sep 2007 15:14:39 +0000 (15:14 +0000)]
r25057: Add a schema file ready to be used in Fedora/RedHat Directory Server
(This used to be commit 501e8b6c79afdefb9955b92e5c25dbe1033ab518)

13 years agor25055: Add file_id_string_tos
Volker Lendecke [Mon, 10 Sep 2007 10:56:07 +0000 (10:56 +0000)]
r25055: Add file_id_string_tos

This removes file_id_string_static and file_id_string_static2
(This used to be commit 638c848c9afe374feb30e34c494f89b2a6c64f7b)

13 years agor25049: Set new, more secure defaults for Samba 3.2.
Andrew Bartlett [Mon, 10 Sep 2007 02:14:18 +0000 (02:14 +0000)]
r25049: Set new, more secure defaults for Samba 3.2.

Andrew Bartlett
(This used to be commit 87d39f61b498c1327c2b3a818e41bb6451fe7518)

13 years agor25040: Add "net sam rights"
Volker Lendecke [Sat, 8 Sep 2007 20:30:51 +0000 (20:30 +0000)]
r25040: Add "net sam rights"

Not strictly in the SAM, but close enough. This command acts directly on
the local tdb, no running smbd required

This also changes the root-only check to a warning
(This used to be commit 0c5657b5eff60e3c52de8fbb4ce9346d0341854c)

13 years agor25036: Fix a become/unbecome_root() pair
Volker Lendecke [Sat, 8 Sep 2007 17:08:59 +0000 (17:08 +0000)]
r25036: Fix a become/unbecome_root() pair
(This used to be commit 9e53f50e9489a5f6cfa40eed59be39e8a294db7d)

13 years agor25032: Contact an off site DC if non is available on site.
Lars Müller [Sat, 8 Sep 2007 14:56:11 +0000 (14:56 +0000)]
r25032: Contact an off site DC if non is available on site.
(This used to be commit 50879e6de5101b6c5ab8b3fb954f1d2a48530716)

13 years agor25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
Lars Müller [Sat, 8 Sep 2007 13:53:08 +0000 (13:53 +0000)]
r25030: ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
(This used to be commit 287604a1c7dc7dede4b278de92ad8233f597d0b6)

13 years agor25025: Remove an unused function
Volker Lendecke [Sat, 8 Sep 2007 10:30:11 +0000 (10:30 +0000)]
r25025: Remove an unused function
(This used to be commit 858f7b7d786ca352ffebb56b9fda40c636acef74)

13 years agor25024: Fix a whole bunch of Coverity bugs
Volker Lendecke [Sat, 8 Sep 2007 09:15:08 +0000 (09:15 +0000)]
r25024: Fix a whole bunch of Coverity bugs

The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.
(This used to be commit bc8b74dbfec965ede7bf45118d1a863b28d000fd)

13 years agor25023: Coverity #455. Not actually a bug, but this clarifies
Jeremy Allison [Sat, 8 Sep 2007 05:35:10 +0000 (05:35 +0000)]
r25023: Coverity #455. Not actually a bug, but this clarifies
the code a lot.
(This used to be commit 5ba12eefbed209a8a6b474da479efd190f91638e)

13 years agor25022: Fix coverity #395. Resource leak on error.
Jeremy Allison [Sat, 8 Sep 2007 05:18:08 +0000 (05:18 +0000)]
r25022: Fix coverity #395. Resource leak on error.
(This used to be commit 6a237600b825f4df2241277bdd80e98669f69685)

13 years agor25021: Fix coverity #435. Use of -1.
Jeremy Allison [Sat, 8 Sep 2007 05:12:17 +0000 (05:12 +0000)]
r25021: Fix coverity #435. Use of -1.
(This used to be commit f789186086b55a81c52e05d1f8c97c33b69131bd)

13 years agor25020: Fix coverity #374, possible null deref.
Jeremy Allison [Sat, 8 Sep 2007 04:57:17 +0000 (04:57 +0000)]
r25020: Fix coverity #374, possible null deref.
(This used to be commit 82b3656b4b26ff63d894eed975d73ef3c8b5d2b2)

13 years agor25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
Jeremy Allison [Sat, 8 Sep 2007 04:45:59 +0000 (04:45 +0000)]
r25019: Fix coverity bug #105, run #332. Use of uninitialized variable.
(This used to be commit a58de8cee51c1396a2607ee743c92d58d7703547)

13 years agor25011: We don't use mangle_map any more.
Jeremy Allison [Fri, 7 Sep 2007 22:54:43 +0000 (22:54 +0000)]
r25011: We don't use mangle_map any more.
(This used to be commit 2e0999c1df33c192fee5f739070a0e4c3d22dff8)

13 years agor25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
Jeremy Allison [Fri, 7 Sep 2007 20:57:01 +0000 (20:57 +0000)]
r25009: Large patch discussed with Volker. Move unix_convert to a talloc-based
interface. More development will come on top of this. Remove the
"mangled map" parameter.
(This used to be commit dee8beba7a92b8a3f68bbcc59fd0a827f68c7736)

13 years agor25002: Refactor out code duplication created by the previous
Michael Adam [Fri, 7 Sep 2007 15:45:39 +0000 (15:45 +0000)]
r25002: Refactor out code duplication created by the previous
unification of r24998.

(This used to be commit 6026d132537f2fb2a963fa54377a926fa99eeb35)

13 years agor24999: Use the new regval_compose() function in regval_ctr_addvalue().
Michael Adam [Fri, 7 Sep 2007 14:54:30 +0000 (14:54 +0000)]
r24999: Use the new regval_compose() function in regval_ctr_addvalue().

(This used to be commit dab9ffe602eaca478a73f3b882f543629ce3001e)

13 years agor24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
Michael Adam [Fri, 7 Sep 2007 14:41:49 +0000 (14:41 +0000)]
r24998: Add a function regval_compose() to compose a REGISTRY_VALUE from
input data. Use this function in a first step to refactor
the canonicalization code of smbconf_store_values().

(This used to be commit f4caa2d7d412e2b9bb2a1ce71514551569ccf373)

13 years agor24996: Eliminate more trailing spaces...
Michael Adam [Fri, 7 Sep 2007 13:54:56 +0000 (13:54 +0000)]
r24996: Eliminate more trailing spaces...
(This used to be commit 1ee1b75113c7035c8882fe53981dba7cfc3aa187)

13 years agor24993: Apply some const
Volker Lendecke [Fri, 7 Sep 2007 12:13:16 +0000 (12:13 +0000)]
r24993: Apply some const
(This used to be commit 613b9fcd18bcc29bf5313e2287b53b8de430d17e)

13 years agor24991: Kill all those lots of trailing whitespaces from secrets.c.
Michael Adam [Fri, 7 Sep 2007 09:14:44 +0000 (09:14 +0000)]
r24991: Kill all those lots of trailing whitespaces from secrets.c.
These red bars in vi really hurt my eyes... :-o

(This used to be commit 2e99e141c3254fe072756697b8db3cbd4e4f1db4)

13 years agor24990: Kill an incredible amount of trailing whitespaces...
Michael Adam [Fri, 7 Sep 2007 08:54:48 +0000 (08:54 +0000)]
r24990: Kill an incredible amount of trailing whitespaces...
Further reformat get_trust_pw to conform to coding rules.

(This used to be commit b9e76a479e933084b1ee081ef5d8bd6bdbd7fadf)

13 years agor24981: - Use the formal syntax for calling functions through pointers. I've wanted
Derrell Lipman [Thu, 6 Sep 2007 13:21:31 +0000 (13:21 +0000)]
r24981: - Use the formal syntax for calling functions through pointers.  I've wanted
  to make this change for ages, but now with the issue of "open" requiring it,
  this is the time to just do all of them.

(This used to be commit e746aaaf4db7099252ef048da7857bd488cb681f)

13 years agor24978: move domain_init_recv() near the functions that uses it
Stefan Metzmacher [Thu, 6 Sep 2007 11:08:44 +0000 (11:08 +0000)]
r24978: move domain_init_recv() near the functions that uses it

(This used to be commit 18e830a935d4712bfbff54f94b531e30cea8a1f9)

13 years agor24977: Ensure negative caching for name2sid, sid2name and rids2names
Rafal Szczesniak [Thu, 6 Sep 2007 11:07:58 +0000 (11:07 +0000)]
r24977: Ensure negative caching for name2sid, sid2name and rids2names

(This used to be commit 3a9b5eabf97e892e761184da37465d850b5d774c)

13 years agor24974: catch SIGINT and SIGQUIT like SIGTERM
Stefan Metzmacher [Thu, 6 Sep 2007 10:51:17 +0000 (10:51 +0000)]
r24974: catch SIGINT and SIGQUIT like SIGTERM

(This used to be commit ab15f5c3e72df6272db9a4431f720f604fcf40f2)

13 years agor24970: Polish some comments and add my (C).
Michael Adam [Wed, 5 Sep 2007 16:01:27 +0000 (16:01 +0000)]
r24970: Polish some comments and add my (C).

(This used to be commit aa043bb446ec8ab90a8e61c590be8d33b6a2d42d)

13 years agor24969: Fwd port "open" patch
Simo Sorce [Wed, 5 Sep 2007 12:53:56 +0000 (12:53 +0000)]
r24969: Fwd port "open" patch
(This used to be commit 113d62682ae8b045ff0132a743a32f3bc4856d54)

13 years agor24955: Reformat some object lists in to minimize the diff.
Michael Adam [Tue, 4 Sep 2007 14:54:00 +0000 (14:54 +0000)]
r24955: Reformat some object lists in to minimize the diff.
(This used to be commit 5d94c3dab2dfab68f170e18e6af9374026f6f194)

13 years agor24954: Fix the build without krb5.
Günther Deschner [Tue, 4 Sep 2007 14:32:28 +0000 (14:32 +0000)]
r24954: Fix the build without krb5.

(This used to be commit 9df961914c3119eb6b20ecdc05d963480dea3521)

13 years agor24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
Günther Deschner [Tue, 4 Sep 2007 14:06:33 +0000 (14:06 +0000)]
r24952: Set the kdc locator env vars. This makes the krb5 locator plugin fully
operational (from within winbindd and outside).

(This used to be commit 800645d5388d7df1f8cf31b4218bfc7dd5b4d12a)

13 years agor24951: Warn if "os level" > 255
Volker Lendecke [Tue, 4 Sep 2007 13:21:24 +0000 (13:21 +0000)]
r24951: Warn if "os level" > 255

Thanks to Karolin Seeger <>
(This used to be commit 3abf06efc1286090caf380eb685e90ba7f412748)

13 years agor24949: Remove some static buffers
Volker Lendecke [Tue, 4 Sep 2007 10:15:04 +0000 (10:15 +0000)]
r24949: Remove some static buffers
(This used to be commit df648d47ff3c4e24f439fda839653bda98323100)

13 years agor24943: Some stackframes
Volker Lendecke [Tue, 4 Sep 2007 05:39:06 +0000 (05:39 +0000)]
r24943: Some stackframes
(This used to be commit cddb9f11d5fafcd3797cb242775c37f0c04d4f15)

13 years agor24920: Reformatting.
Günther Deschner [Mon, 3 Sep 2007 12:23:45 +0000 (12:23 +0000)]
r24920: Reformatting.

(This used to be commit 62426a055513c309a381d0d96d60edc07e6dfcdf)

13 years agor24903: One more tick in #if 0 code
Volker Lendecke [Sun, 2 Sep 2007 17:50:05 +0000 (17:50 +0000)]
r24903: One more tick in #if 0 code
(This used to be commit e0b4fb55e3176785a85d66efece15d0a366a35f1)

13 years agor24902: DEBUG might use talloc_tos() itself...
Volker Lendecke [Sun, 2 Sep 2007 17:48:01 +0000 (17:48 +0000)]
r24902: DEBUG might use talloc_tos() itself...
(This used to be commit 1b39374a173bf6b40426000d010d092e94afc4d7)

13 years agor24879: Activate the winbindd cache-validation message handler.
Michael Adam [Sun, 2 Sep 2007 00:32:57 +0000 (00:32 +0000)]
r24879: Activate the winbindd cache-validation message handler.
Now the winbindd cache can be checked at runtime by
calling "smbcontrol winbindd validate-cache".

For the execution of the validation code, I fork a child
and in the child restore the default SIGCHLD handler in
order for the fork/waitpid mechanism of tdb_validate to work.

(This used to be commit f379a5c47d5004a5a66b6c12ec119c739b9e146d)

13 years agor24877: Don't panic in tdb validation code when the fork or waitpid fails.
Michael Adam [Sun, 2 Sep 2007 00:23:02 +0000 (00:23 +0000)]
r24877: Don't panic in tdb validation code when the fork or waitpid fails.
Return error instead.

(This used to be commit 9b25355dd66519afd548fecbf2da7608b024a35b)

13 years agor24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
Derrell Lipman [Sat, 1 Sep 2007 18:34:50 +0000 (18:34 +0000)]
r24864: - Correct failure of libsmbclient against a version of Windows found on a NAS
  device.  The device resets a NBT connection on port 139 when it receives a
  NetBIOS keepalive request.  That request should be supported when NetBIOS is
  in use; Windows is behaving badly.

  libsmbclient needs a way to determine if a connection is still alive, and
  was using a NetBIOS keepalive request if port 139 was in use (on the
  assumption that it was probably NBT), and getpeername() when port 139 was
  not being used (assuming naked transport).

  This patch simplifies the code by exclusively using getpeername() to check
  whether a connection is still alive.  The NetBIOS keepalive request is
  optional anyway (with preference being given to using TCP mechanisms for the
  same purpose), so this should be both simpler and more reliable.

(This used to be commit 1f122352b02e3f4be9ac2d638b18807dafd05429)

13 years agor24853: Rename function as Jerry asked.
Rafal Szczesniak [Fri, 31 Aug 2007 21:25:53 +0000 (21:25 +0000)]
r24853: Rename function as Jerry asked.

(This used to be commit 86af9fedad71697f22cc739518340f7753b8f9da)

13 years agor24848: Make tdb_validate() take an open tdb handle instead of a file name.
Michael Adam [Fri, 31 Aug 2007 16:30:40 +0000 (16:30 +0000)]
r24848: Make tdb_validate() take an open tdb handle instead of a file name.
A new wrapper tdb_validate_open() takes a filename an opens and closes
the tdb before and after calling tdb_validate() respectively.

winbindd_validata_cache_nobackup() now dynamically calls one of
the above functions depending on whether the cache tdb has already
been opened or not.

(This used to be commit dc0b08e6590caa4974fd4d9f34f39f261d1f1dee)

13 years agor24847: Change standard failure return code of tdb_validate from "-1" to "1".
Michael Adam [Fri, 31 Aug 2007 15:51:05 +0000 (15:51 +0000)]
r24847: Change standard failure return code of tdb_validate from "-1" to "1".
(This is more safely used with casts from int to uint8, e.g.)

(This used to be commit cb3583b39212688a627a29bbddb2e98497714d42)

13 years agor24845: Fix a segfault in smbcontrol when called with parameters but no extra args.
Michael Adam [Fri, 31 Aug 2007 15:34:26 +0000 (15:34 +0000)]
r24845: Fix a segfault in smbcontrol when called with parameters but no extra args.

(This used to be commit f1bbf9bc18fc615a5660674f8346b4a7bed50044)

13 years agor24843: Add a "validate-cache" control message to winbindd.
Michael Adam [Fri, 31 Aug 2007 15:24:43 +0000 (15:24 +0000)]
r24843: Add a "validate-cache" control message to winbindd.
So there is a new subcommand "smbcontrol winbindd validate-cache" now.

This change provides the infrastructure:
The function currently returns "true" unconditionally.
The call of a real cache validation function will be incorporated
in subsequent changes.

(This used to be commit ef92d505c04397614cb0dd5ede967e9017a5e302)

13 years agor24842: Fix build warning.
Günther Deschner [Fri, 31 Aug 2007 15:01:50 +0000 (15:01 +0000)]
r24842: Fix build warning.

(This used to be commit 205ef6ab3e9332a2a4a4f775c2cdddbcd3ec739d)

13 years agor24841: The locator has no dependencies to ldap libs anymore. Also fix the build.
Günther Deschner [Fri, 31 Aug 2007 14:58:26 +0000 (14:58 +0000)]
r24841: The locator has no dependencies to ldap libs anymore. Also fix the build.

(This used to be commit ce7c816083db6fc844b936a14dd593fe1ef07374)

13 years agor24838: Now for real: build the locator, if we can.
Günther Deschner [Fri, 31 Aug 2007 13:51:02 +0000 (13:51 +0000)]
r24838: Now for real: build the locator, if we can.

(This used to be commit 28f9b8d98dabd9ba8e812ca01bcf4fc192fb5e44)

13 years agor24836: Initialize some uninitialized variables.
Michael Adam [Fri, 31 Aug 2007 13:39:51 +0000 (13:39 +0000)]
r24836: Initialize some uninitialized variables.
This prevents a segfault when get_kdc_ip_string() is called
with sitename == NULL.

(This used to be commit 58d31e057b57bc69a96e63aabba9aa1da5418d83)

13 years agor24833: Move locator to nsswitch (does not belong to libads anymore).
Günther Deschner [Fri, 31 Aug 2007 12:21:18 +0000 (12:21 +0000)]
r24833: Move locator to nsswitch (does not belong to libads anymore).

(This used to be commit af90c6949c929c82d4390b2f87a420bd598275dd)

13 years agor24832: In the winbind-locator recursion case, try to pick up the kdc from the
Günther Deschner [Fri, 31 Aug 2007 12:18:21 +0000 (12:18 +0000)]
r24832: In the winbind-locator recursion case, try to pick up the kdc from the

(This used to be commit 7f42fe4e08c0899f5e8addbc5135d87af193ee68)

13 years agor24830: Add a winbindd cache validation function that does not do
Michael Adam [Fri, 31 Aug 2007 10:47:42 +0000 (10:47 +0000)]
r24830: Add a winbindd cache validation function that does not do
backup and corrupt file handling. (To be used in subsequent
(This used to be commit b3dcadbed0b4a1b7bb2e83df2c66bca9dcbcad60)

13 years agor24829: Make use of a variable, that is available... :-)
Michael Adam [Fri, 31 Aug 2007 10:30:14 +0000 (10:30 +0000)]
r24829: Make use of a variable, that is available... :-)
(This used to be commit 90626652084c2ada6b2eb041db652720c03a1c3b)

13 years agor24828: Give smbcontrol an initial talloc stackframe.
Michael Adam [Fri, 31 Aug 2007 10:06:37 +0000 (10:06 +0000)]
r24828: Give smbcontrol an initial talloc stackframe.
(This used to be commit 55020b07b5568104091352fd3ae21e2b29e34501)

13 years agor24827: Give smbstatus an initial talloc stackframe.
Michael Adam [Fri, 31 Aug 2007 09:54:30 +0000 (09:54 +0000)]
r24827: Give smbstatus an initial talloc stackframe.
Rewrite main() so as to exit only at a single point
where the stack frame is freed, too.

(This used to be commit dbe38995ec6d2251562a3b10e750bbd681008e16)

13 years agor24826: Fix two memleaks in idmap_cache.c, bug 4917
Volker Lendecke [Fri, 31 Aug 2007 09:39:11 +0000 (09:39 +0000)]
r24826: Fix two memleaks in idmap_cache.c, bug 4917

Thanks again to Patrick Rynhart for persisting :-)

Simo, please check!
(This used to be commit 0a9171f9efc2322954c0d06757b91d9124ab8a8e)

13 years agor24825: Give testparm an initial talloc stackframe, so it does not complain
Michael Adam [Fri, 31 Aug 2007 09:15:57 +0000 (09:15 +0000)]
r24825: Give testparm an initial talloc stackframe, so it does not complain
it is leaking.
(This used to be commit 705336ee1098a2c4d6e933dfa3e2f2968fa717ad)

13 years agor24824: Create an initial talloc stackframe for the net binary.
Michael Adam [Fri, 31 Aug 2007 09:10:54 +0000 (09:10 +0000)]
r24824: Create an initial talloc stackframe for the net binary.
(This used to be commit c97600b96f6315df8ab0d7ad186423ab75dd4ab5)

13 years agor24813: Reformat to 80 columns.
Jeremy Allison [Thu, 30 Aug 2007 23:07:10 +0000 (23:07 +0000)]
r24813: Reformat to 80 columns.
(This used to be commit c6c8f5a897602d53876fe75e86283d97a394037d)

13 years agor24811: Simple reformatting to fit the 80 columns rule.
Jeremy Allison [Thu, 30 Aug 2007 21:46:42 +0000 (21:46 +0000)]
r24811: Simple reformatting to fit the 80 columns rule.
(This used to be commit 0cdf046dae8ba0741bb7786aa4e85c34fc35dade)

13 years agor24809: Consolidate the use of temporary talloc contexts.
Volker Lendecke [Thu, 30 Aug 2007 19:48:31 +0000 (19:48 +0000)]
r24809: Consolidate the use of temporary talloc contexts.

This adds the two functions talloc_stackframe() and talloc_tos().

 * When a new talloc stackframe is allocated with talloc_stackframe(), then
 * the TALLOC_CTX returned with talloc_tos() is reset to that new
 * frame. Whenever that stack frame is TALLOC_FREE()'ed, then the reverse
 * happens: The previous talloc_tos() is restored.
 * This API is designed to be robust in the sense that if someone forgets to
 * TALLOC_FREE() a stackframe, then the next outer one correctly cleans up and
 * resets the talloc_tos().

The original motivation for this patch was to get rid of the
sid_string_static & friends buffers. Explicitly passing talloc context
everywhere clutters code too much for my taste, so an implicit
talloc_tos() is introduced here. Many of these static buffers are
replaced by a single static pointer.

The intended use would thus be that low-level functions can rather
freely push stuff to talloc_tos, the upper layers clean up by freeing
the stackframe. The more of these stackframes are used and correctly
freed the more exact the memory cleanup happens.

This patch removes the main_loop_talloc_ctx, tmp_talloc_ctx and
lp_talloc_ctx (did I forget any?)

So, never do a

tmp_ctx = talloc_init("foo");

anymore, instead, use

tmp_ctx = talloc_stackframe()


(This used to be commit 6585ea2cb7f417e14540495b9c7380fe9c8c717b)

13 years agor24808: Fix the same problem Volker noticed.
Jeremy Allison [Thu, 30 Aug 2007 17:34:47 +0000 (17:34 +0000)]
r24808: Fix the same problem Volker noticed.

For some funny reason us4/gcc seems to fall over the '

(This used to be commit 229e02d732c1612c7dc4510325da1dcf50050a95)

13 years agor24807: Add WINBINDD_LOCATOR_KDC_ADDRESS env which will be used for the case when the
Günther Deschner [Thu, 30 Aug 2007 16:24:51 +0000 (16:24 +0000)]
r24807: Add WINBINDD_LOCATOR_KDC_ADDRESS env which will be used for the case when the
locator gets called from within winbindd.

(This used to be commit 46dbd6034ec2c6475f428cd2d5cce56268bc34a7)

13 years agor24806: Fix the build, sorry...
Günther Deschner [Thu, 30 Aug 2007 16:02:22 +0000 (16:02 +0000)]
r24806: Fix the build, sorry...

(This used to be commit cd1fccaf8f2ad6e6e4c51909aa7a925efc0a13c4)

13 years agor24805: When we can build the locator, build it.
Günther Deschner [Thu, 30 Aug 2007 15:55:59 +0000 (15:55 +0000)]
r24805: When we can build the locator, build it.

(This used to be commit 91d10fe1598b92090a94286f84395caa1bdf7a41)

13 years agor24804: As a temporary workaround, also try to guess the server's principal in the
Günther Deschner [Thu, 30 Aug 2007 15:39:51 +0000 (15:39 +0000)]
r24804: As a temporary workaround, also try to guess the server's principal in the
"not_defined_in_RFC4178@please_ignore" case to make at least LDAP SASL binds
succeed with windows server 2008.

(This used to be commit f5b3de4d3069eaa750240e3422bac5cb169b6c0a)

13 years agor24803: For some funny reason us4/gcc seems to fall over the '
Volker Lendecke [Thu, 30 Aug 2007 14:55:32 +0000 (14:55 +0000)]
r24803: For some funny reason us4/gcc seems to fall over the '
(This used to be commit 08e309e955eea58df1eb88f848386eb2acbd31ba)

13 years agor24802: Activate new tests
Volker Lendecke [Thu, 30 Aug 2007 14:16:20 +0000 (14:16 +0000)]
r24802: Activate new tests

(This used to be commit 1f396cc237e3861b216d03a7af9e461578cf448a)