14 years agos3: re-run make idl.
Günther Deschner [Mon, 13 Jul 2009 21:38:16 +0000 (23:38 +0200)]
s3: re-run make idl.


14 years agosamr: add missing samr_ValidationStatus codes.
Günther Deschner [Mon, 13 Jul 2009 20:46:51 +0000 (22:46 +0200)]
samr: add missing samr_ValidationStatus codes.


14 years agoreject ACLs with DESC_DACL_PROTECTED on GPFS
Christian Ambach [Thu, 9 Jul 2009 12:45:23 +0000 (14:45 +0200)]

as GPFS does not support the ACE4_FLAG_NO_PROPAGATE NFSv4 flag (which would be the mapping for the DESC_DACL_PROTECTED flag), the status of this flag is currently silently ignored by Samba. That means that if you deselect the "Allow inheritable permissions..." checkbox in Windows' ACL dialog and then apply the ACL, the flag will be back immediately.

To make sure that automatic migration with e.g. robocopy does not lead to ACLs silently (and unintentionally) changed, this patch adds an explicit check for this flag and if set, it will return NT_STATUS_NOT_SUPPORTED so errors are shown up on the Windows side and the Administrator is aware of the ACLs not being settable like intended

Signed-off-by: Christian Ambach <>
14 years agoMake cli_posix_lock/unlock asynchronous.
Jeremy Allison [Tue, 14 Jul 2009 01:43:10 +0000 (18:43 -0700)]
Make cli_posix_lock/unlock asynchronous.

14 years agoFix set_posix_lock check which had been reversed in the recent
Jeremy Allison [Tue, 14 Jul 2009 00:17:37 +0000 (17:17 -0700)]
Fix set_posix_lock check which had been reversed in the recent

14 years agos3-pdb_ads: set correct pdb field with the value from 'accountExpires' attribute.
Günther Deschner [Mon, 13 Jul 2009 19:56:31 +0000 (21:56 +0200)]
s3-pdb_ads: set correct pdb field with the value from 'accountExpires' attribute.


14 years agos3:net: Fix Bug #6222. Default to DRSUAPI replication for net rpc vampire keytab
Stefan Metzmacher [Mon, 13 Jul 2009 11:24:19 +0000 (13:24 +0200)]
s3:net: Fix Bug #6222. Default to DRSUAPI replication for net rpc vampire keytab


Signed-off-by: Günther Deschner <>
14 years agos3-rpc_server: pass down full unix token to map_max_allowed_access().
Günther Deschner [Mon, 29 Jun 2009 18:34:03 +0000 (20:34 +0200)]
s3-rpc_server: pass down full unix token to map_max_allowed_access().

Also use unix_token->uid instead of geteuid() when checking for mapping of the


14 years agolibds: merge the UF<->ACB flag mapping functions.
Günther Deschner [Fri, 12 Jun 2009 13:20:48 +0000 (15:20 +0200)]
libds: merge the UF<->ACB flag mapping functions.


14 years agolibds: share UF_ flags between samba3 and 4.
Günther Deschner [Fri, 12 Jun 2009 12:27:19 +0000 (14:27 +0200)]
libds: share UF_ flags between samba3 and 4.


14 years agos3:smbd: close_file() handles named pipes just fine, no reason to return NOT_SUPPORTED
Stefan Metzmacher [Mon, 13 Jul 2009 11:14:39 +0000 (13:14 +0200)]
s3:smbd: close_file() handles named pipes just fine, no reason to return NOT_SUPPORTED


14 years agos3:smbd: make smbd_do_qfsinfo() non static for use in SMB2 GetInfo
Stefan Metzmacher [Mon, 13 Jul 2009 10:05:34 +0000 (12:05 +0200)]
s3:smbd: make smbd_do_qfsinfo() non static for use in SMB2 GetInfo


14 years agos3:smbd: split out smbd_do_qfsinfo() from call_trans2qfsinfo()
Stefan Metzmacher [Mon, 13 Jul 2009 09:54:20 +0000 (11:54 +0200)]
s3:smbd: split out smbd_do_qfsinfo() from call_trans2qfsinfo()


14 years agos3:smbd: make smbd_do_setfilepathinfo() non static for use in SMB2 SetInfo
Stefan Metzmacher [Mon, 13 Jul 2009 07:01:56 +0000 (09:01 +0200)]
s3:smbd: make smbd_do_setfilepathinfo() non static for use in SMB2 SetInfo


14 years agos3:smbd: split out smbd_do_setfilepathinfo() from call_trans2setfilepathinfo()
Stefan Metzmacher [Mon, 13 Jul 2009 06:59:32 +0000 (08:59 +0200)]
s3:smbd: split out smbd_do_setfilepathinfo() from call_trans2setfilepathinfo()


14 years agos3:smbd: start SMB2 GetInfo support for File*Information levels
Stefan Metzmacher [Fri, 10 Jul 2009 18:39:08 +0000 (20:39 +0200)]
s3:smbd: start SMB2 GetInfo support for File*Information levels

TODO: the EA levels are not fully supported.


14 years agos3:smbd: add support for marshalling SMB2 FileFullEaInformation
Stefan Metzmacher [Sun, 12 Jul 2009 14:40:58 +0000 (16:40 +0200)]
s3:smbd: add support for marshalling SMB2 FileFullEaInformation


14 years agos3:smbd: add support for marshalling SMB2 FileAllInformation
Stefan Metzmacher [Sun, 12 Jul 2009 15:08:18 +0000 (17:08 +0200)]
s3:smbd: add support for marshalling SMB2 FileAllInformation


14 years agos3:smbd: filter out SMB2 specific private query info levels for SMB1
Stefan Metzmacher [Sun, 12 Jul 2009 15:06:05 +0000 (17:06 +0200)]
s3:smbd: filter out SMB2 specific private query info levels for SMB1


14 years agos3:smbd: make smbd_do_qfilepathinfo() non static for use in SMB2
Stefan Metzmacher [Fri, 10 Jul 2009 18:02:44 +0000 (20:02 +0200)]
s3:smbd: make smbd_do_qfilepathinfo() non static for use in SMB2


14 years agos3:smbd: split calculation and mashalling of file index and access_mask
Stefan Metzmacher [Sun, 12 Jul 2009 14:37:49 +0000 (16:37 +0200)]
s3:smbd: split calculation and mashalling of file index and access_mask


14 years agos3:smbd: split out smbd_do_qfilepathinfo() from call_trans2qfilepathinfo()
Stefan Metzmacher [Fri, 10 Jul 2009 17:04:58 +0000 (19:04 +0200)]
s3:smbd: split out smbd_do_qfilepathinfo() from call_trans2qfilepathinfo()

This prepares SMB2 GetInfo.


14 years agos3:smbd: add missing return after reply_nterror()
Stefan Metzmacher [Fri, 10 Jul 2009 16:51:59 +0000 (18:51 +0200)]
s3:smbd: add missing return after reply_nterror()


14 years agoRemove reply_unixerror() - no longer needed. Should make Metze's refactoring a lot...
Jeremy Allison [Sat, 11 Jul 2009 01:23:00 +0000 (18:23 -0700)]
Remove reply_unixerror() - no longer needed. Should make Metze's refactoring a lot easier.

14 years agoAdd hash values to the xattr ACLS to determine when
Jeremy Allison [Fri, 10 Jul 2009 22:50:40 +0000 (15:50 -0700)]
Add hash values to the xattr ACLS to determine when
an underlying POSIX ACL is changed out from under us.
Passes RAW-ACL test up to "invalid owner" problem when
trying to create a file owned by Everyone. Now needs
porting to modules/vfs_acl_tdb.c

14 years agoReturn 0 domains from enum_trusteddoms
Volker Lendecke [Thu, 9 Jul 2009 13:58:10 +0000 (15:58 +0200)]
Return 0 domains from enum_trusteddoms

14 years agoQuieten events and tldap debug messages
Volker Lendecke [Sun, 5 Jul 2009 12:39:16 +0000 (14:39 +0200)]
Quieten events and tldap debug messages

14 years agos3 smb2: Remove unused variable
Tim Prouty [Fri, 10 Jul 2009 19:03:51 +0000 (12:03 -0700)]
s3 smb2: Remove unused variable

14 years agoFix&Run local-gencache
Volker Lendecke [Fri, 10 Jul 2009 15:36:18 +0000 (17:36 +0200)]
Fix&Run local-gencache

14 years agoFix our base64 implementation for blobs of length 4....
Volker Lendecke [Fri, 10 Jul 2009 15:29:22 +0000 (17:29 +0200)]
Fix our base64 implementation for blobs of length 4....

The additional length check bit us exactly at 4, removing it. The
torture test survives valgrind up to 2000 bytes :-)

14 years agos3:smbd: add support for SMB2 Lock
Stefan Metzmacher [Wed, 8 Jul 2009 11:13:32 +0000 (13:13 +0200)]
s3:smbd: add support for SMB2 Lock


14 years agos3:smbd: make smbd_do_locking() non static
Stefan Metzmacher [Tue, 7 Jul 2009 16:09:16 +0000 (18:09 +0200)]
s3:smbd: make smbd_do_locking() non static


14 years agos3:smbd: abstract the main locking logic from the LockingAndX parsing
Stefan Metzmacher [Tue, 7 Jul 2009 15:24:25 +0000 (17:24 +0200)]
s3:smbd: abstract the main locking logic from the LockingAndX parsing

This prepares SMB2 Lock support.


14 years agos3:smbd: pass down the client pid to smbd_smb2_lock_send()
Stefan Metzmacher [Thu, 9 Jul 2009 09:34:14 +0000 (11:34 +0200)]
s3:smbd: pass down the client pid to smbd_smb2_lock_send()


14 years agos3:smbd: fix parsing of SMB2 Lock requests with lock_count > 1
Stefan Metzmacher [Thu, 9 Jul 2009 09:33:58 +0000 (11:33 +0200)]
s3:smbd: fix parsing of SMB2 Lock requests with lock_count > 1

We should not reuse the variable 'i'.


14 years agos3:smbd: fix parsing of invalid SMB2 requests.
Stefan Metzmacher [Wed, 8 Jul 2009 15:02:00 +0000 (17:02 +0200)]
s3:smbd: fix parsing of invalid SMB2 requests.

Because of 0 - 2 => 0xFFFFFFFE, we got EMSGSIZE
from the tstream layer. And terminate the transport
connection. Instead we should let the caller deal with
the invalid parameter, when checking the body size.
So the caller always gets at least a 2 byte body.


14 years agoAttempt to fix the build -- jlayton, please check!
Volker Lendecke [Fri, 10 Jul 2009 09:59:00 +0000 (11:59 +0200)]
Attempt to fix the build -- jlayton, please check!

14 years agocifs.upcall: use pid value from kernel to determine KRB5CCNAME to use
Jeff Layton [Fri, 10 Jul 2009 01:04:08 +0000 (21:04 -0400)]
cifs.upcall: use pid value from kernel to determine KRB5CCNAME to use

If the kernel sends the upcall a pid of the requesting process, we can
open that process' /proc/<pid>/environ file and scrape the KRB5CCNAME
value out of it.

Signed-off-by: Jeff Layton <>
14 years agos3: Fix two arguments that broke when plumbing smb_filneame through dos_mode()
Tim Prouty [Thu, 9 Jul 2009 22:56:36 +0000 (15:56 -0700)]
s3: Fix two arguments that broke when plumbing smb_filneame through dos_mode()

14 years agoMake escape_ldap_string take a talloc context
Volker Lendecke [Thu, 9 Jul 2009 20:03:52 +0000 (22:03 +0200)]
Make escape_ldap_string take a talloc context

14 years agos4:dsdb Allow unicodePwd to be set when adding a user
Andrew Bartlett [Thu, 9 Jul 2009 04:53:26 +0000 (14:53 +1000)]
s4:dsdb Allow unicodePwd to be set when adding a user

Windows 7 sets it's join password using the unicodePwd attribute (as a
quoted, utf16 string), and does so during the LDAPAdd of the object.
Previously, this code only handled unicodePwd for modifies.

Andrew Bartlett

14 years agoAdd const
Andrew Bartlett [Thu, 9 Jul 2009 00:08:02 +0000 (10:08 +1000)]
Add const

14 years agos3: Repace a char * with an smb_filename struct in reply_rmdir
Tim Prouty [Thu, 9 Jul 2009 03:15:02 +0000 (20:15 -0700)]
s3: Repace a char * with an smb_filename struct in reply_rmdir

14 years agos3: Prepare open.c to switch fsp_name to an smb_filename struct
Tim Prouty [Wed, 8 Jul 2009 23:53:01 +0000 (16:53 -0700)]
s3: Prepare open.c to switch fsp_name to an smb_filename struct

14 years agos3 plumb smb_filename through smb_set_file_allocation_info()
Tim Prouty [Thu, 9 Jul 2009 00:53:05 +0000 (17:53 -0700)]
s3 plumb smb_filename through smb_set_file_allocation_info()

14 years agos3: Change the share_mode_lock struct to store a base_name and stream_name
Tim Prouty [Wed, 8 Jul 2009 23:22:44 +0000 (16:22 -0700)]
s3: Change the share_mode_lock struct to store a base_name and stream_name

14 years agos3: Make some arguments to (parse|unparse)_share_modes() const
Tim Prouty [Wed, 8 Jul 2009 21:27:06 +0000 (14:27 -0700)]
s3: Make some arguments to (parse|unparse)_share_modes() const

14 years agos3: Remove is_ntfs_stream_name() and split_ntfs_stream_name()
Tim Prouty [Wed, 8 Jul 2009 21:08:04 +0000 (14:08 -0700)]
s3: Remove is_ntfs_stream_name() and split_ntfs_stream_name()

Actually I moved split_ntfs_stream_name into torture.c which is the one
consumer of it.  This could probably be changed at some point.

14 years agos3: Plumb smb_filename through dos_mode() and related funtions
Tim Prouty [Wed, 8 Jul 2009 19:24:03 +0000 (12:24 -0700)]
s3: Plumb smb_filename through dos_mode() and related funtions

14 years agos3: convert unix_mode to take an smb_filename
Tim Prouty [Wed, 8 Jul 2009 02:20:22 +0000 (19:20 -0700)]
s3: convert unix_mode to take an smb_filename

14 years agoRename update_stat_ex_writetime() -> update_stat_ex_mtime()
Jeremy Allison [Thu, 9 Jul 2009 01:05:30 +0000 (18:05 -0700)]
Rename update_stat_ex_writetime() -> update_stat_ex_mtime()
to better describe what we're doing here.

14 years agoThe migration to struct stat_ex broke the calculation of
Jeremy Allison [Thu, 9 Jul 2009 00:51:35 +0000 (17:51 -0700)]
The migration to struct stat_ex broke the calculation of
create time from the existing timestamps (for systems
that need to do this). Once the write time is changed
via a sticky write, the create time might need to be
recalculated. To do this I needed to add a bool into
struct stat_ex to remember if the st_ex_btime field
was calculated, or read from the OS. Also fixed the
returning of modified write timestamps in the return
from NTCreateX, SMBattr and SMBattrE (which weren't
taking into account the modified timestamp stored
in the open file table). Attempting to fix an issue
with Excel 2003 and offline files. Volker and Metze,
please review.

14 years agoWhen faking a create time, use the full timespec values, not time_t.
Jeremy Allison [Wed, 8 Jul 2009 19:28:01 +0000 (12:28 -0700)]
When faking a create time, use the full timespec values, not time_t.

14 years agoFix make test_shlibs for libnss_wins and libnetapi (zlib)
Jim McDonough [Wed, 8 Jul 2009 17:12:26 +0000 (13:12 -0400)]
Fix make test_shlibs for libnss_wins and libnetapi (zlib)

14 years agoFix cifs.upcall builds on some platforms (zlib)
Jim McDonough [Wed, 8 Jul 2009 12:02:04 +0000 (08:02 -0400)]
Fix cifs.upcall builds on some platforms (zlib)

14 years agodocs: flesh out options section of umount.cifs manpage
Shirish Pargaonkar [Wed, 8 Jul 2009 11:43:43 +0000 (07:43 -0400)]
docs: flesh out options section of umount.cifs manpage

Signed-off-by: Shirish Pargaonkar <>
Signed-off-by: Jeff Layton <>
14 years agos4:auth/ntlmssp: let _unwrap fallback to seal if sign only doesn't work
Stefan Metzmacher [Wed, 8 Jul 2009 07:22:39 +0000 (09:22 +0200)]
s4:auth/ntlmssp: let _unwrap fallback to seal if sign only doesn't work

s4:auth/ntlmssp: let _unwrap fallback to seal if sign only doesn't work

Windows always uses SEAL with NTLMSSP on LDAP connection even if not negotiated.


14 years agoTest for schemaUpdateNow command
Anatoliy Atanasov [Fri, 3 Jul 2009 12:24:52 +0000 (15:24 +0300)]
Test for schemaUpdateNow command

14 years agoFix for schemaUpdateNow command
Anatoliy Atanasov [Fri, 3 Jul 2009 12:24:40 +0000 (15:24 +0300)]
Fix for schemaUpdateNow command

14 years agos3 onefs: Fix a few bugs from the smb_filename migration
Tim Prouty [Mon, 6 Jul 2009 22:44:09 +0000 (15:44 -0700)]
s3 onefs: Fix a few bugs from the smb_filename migration

14 years agos3: Migrate a few functions in open.c to take smb_filename
Tim Prouty [Wed, 8 Jul 2009 00:56:49 +0000 (17:56 -0700)]
s3: Migrate a few functions in open.c to take smb_filename

14 years agos3: Remove unnecessary const qualifiers
Tim Prouty [Wed, 8 Jul 2009 00:27:50 +0000 (17:27 -0700)]
s3: Remove unnecessary const qualifiers

14 years agomount.cifs: clarify mapchars option
Shirish Pargaonkar [Tue, 7 Jul 2009 20:35:06 +0000 (16:35 -0400)]
mount.cifs: clarify mapchars option

Signed-off-by: Shirish Pargaonkar <>
Signed-off-by: Jeff Layton <>
14 years agos3: QNX doesn't know uint - replace with uint_t
Björn Jacke [Tue, 7 Jul 2009 20:11:50 +0000 (22:11 +0200)]
s3: QNX doesn't know uint - replace with uint_t

14 years agoAttempt to fix the build of vfs_catia.c -- Tim, please check!
Volker Lendecke [Tue, 7 Jul 2009 18:40:39 +0000 (20:40 +0200)]
Attempt to fix the build of vfs_catia.c -- Tim, please check!

14 years agos3:smbd: cancel all locks that are made before the first failure
Stefan Metzmacher [Tue, 7 Jul 2009 13:16:21 +0000 (15:16 +0200)]
s3:smbd: cancel all locks that are made before the first failure

s3:smbd: cancel all locks that are made before the first failure

We never reached the cleanup code and directly returned the error.


14 years agos4:auth It is easier to copy the session key than get talloc right.
Andrew Bartlett [Tue, 7 Jul 2009 03:27:47 +0000 (13:27 +1000)]
s4:auth It is easier to copy the session key than get talloc right.

The session keys as supplied already have a reference on them, so
stealing them creates challenges.  For 16 bytes, it is just easier to
be consistant and copy them.

Andrew Bartlett

14 years agos3: Update streaminfo implementations now that only base names are passed through...
Tim Prouty [Mon, 6 Jul 2009 22:26:57 +0000 (15:26 -0700)]
s3: Update streaminfo implementations now that only base names are passed through the vfs

14 years agos3 smb2: Fix unused variable warning
Tim Prouty [Mon, 6 Jul 2009 21:18:05 +0000 (14:18 -0700)]
s3 smb2: Fix unused variable warning

14 years agos3 audit: Fix a memory leak
Tim Prouty [Sat, 4 Jul 2009 00:15:30 +0000 (17:15 -0700)]
s3 audit: Fix a memory leak

14 years agos3: Plumb smb_filename through SMB_VFS_NTIMES
Tim Prouty [Thu, 2 Jul 2009 20:39:20 +0000 (13:39 -0700)]
s3: Plumb smb_filename through SMB_VFS_NTIMES

14 years agos3 catia: Remove pointless VOPs from catia
Tim Prouty [Thu, 2 Jul 2009 20:13:14 +0000 (13:13 -0700)]
s3 catia: Remove pointless VOPs from catia

14 years agos3 sticky write time: Removed unused args and tighten up a function by making an...
Tim Prouty [Thu, 2 Jul 2009 17:27:01 +0000 (10:27 -0700)]
s3 sticky write time: Removed unused args and tighten up a function by making an arg const

14 years agos3: Plumb smb_filename around SMB_VFS_CHFLAGS
Tim Prouty [Mon, 6 Jul 2009 21:36:16 +0000 (14:36 -0700)]
s3: Plumb smb_filename around SMB_VFS_CHFLAGS

SMB_VFS_CHFLAGS isn't actually getting the smb_filename struct for now
since it only operates on the basefile.  This is the strategy for all
path-based operations that will never actually operate on a stream.

By clarifying the meaning of path based operations that don't take an
smb_filename struct, modules that implement streams such as vfs_onefs
no longer need to implement SMB_VFS_CHFLAGS to ensure it's only called
on the base_name.

14 years agos3: Change some filename_convert to pass in NULL for char **fname argument
Tim Prouty [Wed, 1 Jul 2009 23:15:52 +0000 (16:15 -0700)]
s3: Change some filename_convert to pass in NULL for char **fname argument

14 years agos3: Add ability to pass NULL to filename_convert for the char *fname
Tim Prouty [Wed, 1 Jul 2009 23:14:40 +0000 (16:14 -0700)]
s3: Add ability to pass NULL to filename_convert for the char *fname

The goal is to eventually remove the need for the char **fname argument
once all callers have standardized on smb_filename.

14 years agos3: Plumb smb_filename through SMB_VFS_UNLINK
Tim Prouty [Thu, 2 Jul 2009 16:27:44 +0000 (09:27 -0700)]
s3: Plumb smb_filename through SMB_VFS_UNLINK

14 years agos3 audit: Remove some recently introduced memory leaks in the audit modules
Tim Prouty [Wed, 1 Jul 2009 06:08:02 +0000 (23:08 -0700)]
s3 audit: Remove some recently introduced memory leaks in the audit modules

14 years agos3 audit: Remove the usesless static function declarations from the audit modules
Tim Prouty [Wed, 1 Jul 2009 05:44:39 +0000 (22:44 -0700)]
s3 audit: Remove the usesless static function declarations from the audit modules

14 years agos3 onefs: Fix failure in POSIX smbtorture test
Tim Prouty [Tue, 30 Jun 2009 23:41:48 +0000 (16:41 -0700)]
s3 onefs: Fix failure in POSIX smbtorture test

The return value of readlink was a bool instead of an int,
which caused the length of the returned value to never be

14 years agos3: Plumb smb_filename through SMB_VFS_RENAME
Tim Prouty [Wed, 1 Jul 2009 00:04:38 +0000 (17:04 -0700)]
s3: Plumb smb_filename through SMB_VFS_RENAME

14 years agoFix some typos pointed out by Oota Toshiya.
Jelmer Vernooij [Mon, 6 Jul 2009 20:41:21 +0000 (22:41 +0200)]
Fix some typos pointed out by Oota Toshiya.

14 years agoRAW-LOCK: fix a compiler warning and make a global static const
Stefan Metzmacher [Mon, 6 Jul 2009 13:48:32 +0000 (15:48 +0200)]
RAW-LOCK: fix a compiler warning and make a global static const


14 years agoRAW-LOCK: fix the run against w2k3, w2k8, win7rc and samba3/4
Stefan Metzmacher [Mon, 6 Jul 2009 13:36:03 +0000 (15:36 +0200)]
RAW-LOCK: fix the run against w2k3, w2k8, win7rc and samba3/4

We now allow --target=w2k8.

The strange thing is that w2k8 and win7rc only do half of the timeout
that was given by the client.


14 years agoSMB2-NOTIFY: windows7 uses a different maximum buffer size
Stefan Metzmacher [Mon, 6 Jul 2009 10:03:33 +0000 (12:03 +0200)]
SMB2-NOTIFY: windows7 uses a different maximum buffer size


14 years agos4:heimdal: readd heimdal/lib/asn1/asn1parse.y which was parse.y before the last...
Stefan Metzmacher [Mon, 6 Jul 2009 11:26:09 +0000 (13:26 +0200)]
s4:heimdal: readd heimdal/lib/asn1/asn1parse.y which was parse.y before the last import

Also commit the regenerated files for systems without yacc and lex.

This fixes the build with automatic dependecies for me.


14 years agodoc: clarify that mount.cifs never uses smb.conf
Suresh Jayaraman [Mon, 6 Jul 2009 10:31:30 +0000 (06:31 -0400)]
doc: clarify that mount.cifs never uses smb.conf

For some users who are used to smbclient, it is not clear that
mount.cifs never uses smb.conf for configuring client specific
parameters. So, let's add this information to mount.cifs man page.

Signed-off-by: Suresh Jayaraman <>
14 years agodo not merge ACEs with different SMB_ACE4_INHERIT_ONLY_ACE flag, this leads to wrong...
Christian Ambach [Sun, 5 Jul 2009 14:03:15 +0000 (16:03 +0200)]
do not merge ACEs with different SMB_ACE4_INHERIT_ONLY_ACE flag, this leads to wrong inheritance flags in the ACL e.g. (on GPFS) user:10000036:rwxc:allow (X)READ/LIST (X)WRITE/CREATE (X)MKDIR (X)SYNCHRONIZE (X)READ_ACL (X)READ_ATTR (X)READ_NAMED (X)DELETE (X)DELETE_CHILD (X)CHOWN (X)EXEC/SEARCH (X)WRITE_ACL (X)WRITE_ATTR (X)WRITE_NAMED




would be merged to



so the explicit right for the user on the parent directory will be gone (the InheritOnly flag only accounts to subdirectories)
thus leaving the user without access to the directory itself

Signed-off-by: Christian Ambach <>
14 years agos4:net Move net_vampire() to net_vampire.c
Andrew Bartlett [Mon, 6 Jul 2009 06:41:42 +0000 (16:41 +1000)]
s4:net Move net_vampire() to net_vampire.c

14 years agos4:ldb Rework use of talloc and ldif objects in python wrapper
Andrew Bartlett [Sun, 5 Jul 2009 23:31:38 +0000 (09:31 +1000)]
s4:ldb Rework use of talloc and ldif objects in python wrapper

The talloc hirarchy here was a bit odd - we would both steal the
parsed ldif onto 'NULL', then reference it onto a python talloc

Now we just leave the reference, after we complete building the object.

Andrew Bartlett

14 years agos4:ldb Fix talloc hirarchy in LDIF parsing code
Andrew Bartlett [Sun, 5 Jul 2009 23:24:18 +0000 (09:24 +1000)]
s4:ldb Fix talloc hirarchy in LDIF parsing code

The problem here was that some parts of the ldb_message were still
attached to the ldb_ldif structure, and when only the message was
taken (and the ldif free'ed to reclaim memory) we refereced free'ed

Andrew Bartlett

14 years agoUse null_ndr_syntax_id instead of zeroing null_interface manually
Volker Lendecke [Sun, 5 Jul 2009 08:23:56 +0000 (10:23 +0200)]
Use null_ndr_syntax_id instead of zeroing null_interface manually

14 years agoAdd const to init_rpc_hdr_ba
Volker Lendecke [Sun, 5 Jul 2009 08:21:39 +0000 (10:21 +0200)]
Add const to init_rpc_hdr_ba

14 years agoRemove "typedef struct ndr_syntax_id RPC_IFACE;"
Volker Lendecke [Sun, 5 Jul 2009 08:13:03 +0000 (10:13 +0200)]
Remove "typedef struct ndr_syntax_id RPC_IFACE;"

14 years agoIntroduce null_ndr_syntax_id
Volker Lendecke [Sun, 5 Jul 2009 08:21:06 +0000 (10:21 +0200)]
Introduce null_ndr_syntax_id

14 years agoMake check_bind_req static to rpc_server/srv_pipe.c
Volker Lendecke [Sun, 5 Jul 2009 07:43:23 +0000 (09:43 +0200)]
Make check_bind_req static to rpc_server/srv_pipe.c

14 years agoActually increase PASSDB_INTERFACE_VERSION to 18 :-)
Volker Lendecke [Sun, 5 Jul 2009 14:20:05 +0000 (16:20 +0200)]
Actually increase PASSDB_INTERFACE_VERSION to 18 :-)

14 years agoFix some nonempty blank lines
Volker Lendecke [Sun, 5 Jul 2009 21:15:34 +0000 (23:15 +0200)]
Fix some nonempty blank lines

14 years agolibreplace: update library search path variables
Björn Jacke [Sun, 5 Jul 2009 20:42:29 +0000 (22:42 +0200)]
libreplace: update library search path variables

14 years agos3:configure: honor CFLAGS in compile tests
Björn Jacke [Sun, 5 Jul 2009 09:28:05 +0000 (11:28 +0200)]
s3:configure: honor CFLAGS in compile tests

When compilation is done for the architecture that's not the compiler's
default, for example by setting CFLAGS to -m64, then compile tests might fail
when they are done with the comiler's default arch. This should fix
bugzilla #6162.