ira/wip.git
12 years agoFix coverity CID 930. Pointer check can never be null here.
Jeremy Allison [Sat, 18 Jul 2009 04:29:28 +0000 (21:29 -0700)]
Fix coverity CID 930. Pointer check can never be null here.
Jeremy

12 years agoFix coverity CID 931. This check is redundent as smb_fname can
Jeremy Allison [Sat, 18 Jul 2009 04:26:16 +0000 (21:26 -0700)]
Fix coverity CID 931. This check is redundent as smb_fname can
never be null in this function.
Jeremy.

12 years agoFix a typo reading uninitialized memory. Caught by valgrind.
Jeremy Allison [Sat, 18 Jul 2009 01:05:10 +0000 (18:05 -0700)]
Fix a typo reading uninitialized memory. Caught by valgrind.
Jeremy.

12 years agoMove the initialization of smbd_server_conn from smbd/process,
Jeremy Allison [Sat, 18 Jul 2009 00:57:48 +0000 (17:57 -0700)]
Move the initialization of smbd_server_conn from smbd/process,
after the accept and fork, to smbd_init_globals(), so it's
done immediately on server startup. This is needed as some
messages are sent to all active smbd processes (including
the master listening daemon). If it gets a message that
forces it to scan it's current connections (ie. conn_find())
then it discovers that sconn->smb1.tcons.Connections dereferences
null (as sconn == NULL in the parent) and crashes. Yes,
I could fix all cases where sconn is used and explicitly
check for NULL but this fix is easier. It means that
the smbd_event_context() is initialized in the master
daemon and then re-initialized after fork, but that
should be being done correctly in every fork call anyway.
Without this change the previous fix 6a9e0039100b57f9626e87defec6720c476b9789
still panics in the reproducible test case for bug
6564, as this is one case where such a message
(MSG_SMB_CONF_UPDATED) is sent to the parent. Metze
please check. This change passes valgrind.
Jeremy.

12 years agoFix bug #6564 - SetPrinter fails (panics) as non root.
Jeremy Allison [Sat, 18 Jul 2009 00:36:26 +0000 (17:36 -0700)]
Fix bug #6564 - SetPrinter fails (panics) as non root.
Missing become_root()/unbecome_root() around reload_services.
Jeremy.

12 years ago3.4 is released...
Volker Lendecke [Fri, 17 Jul 2009 20:40:24 +0000 (22:40 +0200)]
3.4 is released...

12 years agos4-spoolss: fix the build after OsVersion changes.
Günther Deschner [Fri, 17 Jul 2009 15:16:44 +0000 (17:16 +0200)]
s4-spoolss: fix the build after OsVersion changes.

Guenther

12 years agospoolss: fill in some unknowns in spoolss_OSVersion and spoolss_OSVersionEx.
Günther Deschner [Fri, 17 Jul 2009 14:47:48 +0000 (16:47 +0200)]
spoolss: fill in some unknowns in spoolss_OSVersion and spoolss_OSVersionEx.

Guenther

12 years agos3: add failure check.
Bo Yang [Sat, 18 Jul 2009 06:07:33 +0000 (14:07 +0800)]
s3: add failure check.

Signed-off-by: Bo Yang <boyang@samba.org>
12 years agos3-rpcclient: add createprinteric command.
Günther Deschner [Fri, 17 Jul 2009 13:39:40 +0000 (15:39 +0200)]
s3-rpcclient: add createprinteric command.

Guenther

12 years agospoolss: fill in spoolss_Create/DeletePrinterIC + rerun make samba3-idl.
Günther Deschner [Fri, 17 Jul 2009 13:38:40 +0000 (15:38 +0200)]
spoolss: fill in spoolss_Create/DeletePrinterIC + rerun make samba3-idl.

Guenther

12 years agos3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.
Günther Deschner [Wed, 15 Jul 2009 23:05:25 +0000 (01:05 +0200)]
s3-lsa: let _lsa_Delete return NT_STATUS_NOT_SUPPORTED as w2k3 does.

Guenther

12 years agos3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().
Günther Deschner [Thu, 16 Jul 2009 16:45:29 +0000 (18:45 +0200)]
s3-lsa: Fix access_mask calculation for new handle in _lsa_CreateAccount().

Guenther

12 years agos3-lsa: add (not yet activate) level specific access checks for _lsa_QueryInfoPolicy.
Günther Deschner [Thu, 16 Jul 2009 14:32:04 +0000 (16:32 +0200)]
s3-lsa: add (not yet activate) level specific access checks for _lsa_QueryInfoPolicy.

Guenther

12 years agos3-lsa: also implement level 13 in lsa_QueryInfoPolicy.
Günther Deschner [Thu, 16 Jul 2009 14:28:11 +0000 (16:28 +0200)]
s3-lsa: also implement level 13 in lsa_QueryInfoPolicy.

Guenther

12 years agos3-lsa: Fix policy handle memleak and handle type check in _lsa_DeleteObject().
Günther Deschner [Fri, 17 Jul 2009 11:44:55 +0000 (13:44 +0200)]
s3-lsa: Fix policy handle memleak and handle type check in _lsa_DeleteObject().

Guenther

12 years agos3-rpcclient: add LSA storeprivatedata command.
Günther Deschner [Fri, 17 Jul 2009 11:37:08 +0000 (13:37 +0200)]
s3-rpcclient: add LSA storeprivatedata command.

Guenther

12 years agos3-rpcclient: add LSA retrieveprivatedata command.
Günther Deschner [Fri, 17 Jul 2009 11:30:37 +0000 (13:30 +0200)]
s3-rpcclient: add LSA retrieveprivatedata command.

Guenther

12 years agos3-rpcclient: add LSA setsecret command.
Günther Deschner [Fri, 17 Jul 2009 10:56:30 +0000 (12:56 +0200)]
s3-rpcclient: add LSA setsecret command.

Guenther

12 years agos3-rpcclient: add LSA querysecret command.
Günther Deschner [Fri, 17 Jul 2009 10:03:58 +0000 (12:03 +0200)]
s3-rpcclient: add LSA querysecret command.

Guenther

12 years agos3-rpcclient: add LSA deletesecret command.
Günther Deschner [Fri, 17 Jul 2009 09:58:10 +0000 (11:58 +0200)]
s3-rpcclient: add LSA deletesecret command.

Guenther

12 years agos3-rpcclient: add LSA createsecret command.
Günther Deschner [Fri, 17 Jul 2009 09:54:49 +0000 (11:54 +0200)]
s3-rpcclient: add LSA createsecret command.

Guenther

12 years agolsa: fill in lsa_StorePrivateData and lsa_RetrievePrivateData and rerun make samba3...
Günther Deschner [Fri, 17 Jul 2009 11:09:26 +0000 (13:09 +0200)]
lsa: fill in lsa_StorePrivateData and lsa_RetrievePrivateData and rerun make samba3-idl.

Guenther

12 years agos3: compile warning and upn handling
Bo Yang [Sat, 18 Jul 2009 02:46:11 +0000 (10:46 +0800)]
s3: compile warning and upn handling

Signed-off-by: Bo Yang <boyang@samba.org>
12 years agos3: don't do this, upper callbacks will check it
Bo Yang [Sat, 18 Jul 2009 00:03:57 +0000 (08:03 +0800)]
s3: don't do this, upper callbacks will check it

Signed-off-by: Bo Yang <boyang@samba.org>
12 years agos3: Fix crsh in net usershare list
Bo Yang [Sat, 18 Jul 2009 00:01:56 +0000 (08:01 +0800)]
s3: Fix crsh in net usershare list

Signed-off-by: Bo Yang <boyang@samba.org>
12 years agoMore conversions of NULL -> talloc_autofree_context()
Jeremy Allison [Fri, 17 Jul 2009 01:28:58 +0000 (18:28 -0700)]
More conversions of NULL -> talloc_autofree_context()
so we at least know when we're using a long-lived context.
Jeremy.

12 years agoReplace more long-lived contexts with talloc_autofree_context().
Jeremy Allison [Fri, 17 Jul 2009 01:14:56 +0000 (18:14 -0700)]
Replace more long-lived contexts with talloc_autofree_context().
Jeremy.

12 years agoReplace short-lived NULL talloc contexts with talloc_tos().
Jeremy Allison [Fri, 17 Jul 2009 01:13:46 +0000 (18:13 -0700)]
Replace short-lived NULL talloc contexts with talloc_tos().
Jeremy.

12 years agoRemove an unused talloc context.
Jeremy Allison [Fri, 17 Jul 2009 01:12:17 +0000 (18:12 -0700)]
Remove an unused talloc context.
Jeremy.

12 years agoRevert "s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version"
Andrew Bartlett [Thu, 16 Jul 2009 22:39:51 +0000 (08:39 +1000)]
Revert "s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version"

This is now handled correctly in the newly imported Heimdal

This reverts commit 4a754d029b0eb229b23980aa4a80dae2b485a302.

12 years agos4:heimdal: import lorikeet-heimdal-200907162216 (commit d09910d6803aad96b52ee626327e...
Andrew Bartlett [Thu, 16 Jul 2009 22:29:03 +0000 (08:29 +1000)]
s4:heimdal: import lorikeet-heimdal-200907162216 (commit d09910d6803aad96b52ee626327ee55b14ea0de8)

This includes in particular changes to the KDC to resolve bug 6272,
originally by Matthieu Patou <mat+Informatique.Samba@matws.net>.  We
need to sort the AuthorizationData elements to put the PAC first, or
else WinXP breaks when browsed from Win2k8.

Andrew Bartlett

12 years agos4:kdc Rework KDC to pull in less attributes for krbtgt lookups
Andrew Bartlett [Thu, 16 Jul 2009 07:37:36 +0000 (17:37 +1000)]
s4:kdc Rework KDC to pull in less attributes for krbtgt lookups

Each attribute we request from LDB comes with a small cost, so don't
lookup any more than we must for the (very) frequent krbtgt lookup
case.  Similarly, we don't need to build a PAC for a server (as a
target), so don't ask for the PAC attributes here either.

Andrew Bartlett

12 years agos4:kdc rename functions from LDB_ to hdb_samba4
Andrew Bartlett [Thu, 16 Jul 2009 02:47:57 +0000 (12:47 +1000)]
s4:kdc rename functions from LDB_ to hdb_samba4

The LDB_ prefix is misleading, and stomps on the LDB namespace.  This
is a Samba4 hdb module, and not something generic.

Andrew Bartlett

12 years agoRevert "fix LSA-PRIVILEGES"
Günther Deschner [Thu, 16 Jul 2009 16:39:06 +0000 (18:39 +0200)]
Revert "fix LSA-PRIVILEGES"

This reverts commit 0d9fdbceedddb08dbea8ed84e06a218d3ec562f4.

12 years agoRevert "fix LSA-TRUSTED-DOMAINS"
Günther Deschner [Thu, 16 Jul 2009 16:38:55 +0000 (18:38 +0200)]
Revert "fix LSA-TRUSTED-DOMAINS"

This reverts commit 3c9b26276083002124674678ac757e859fb6b20e.

12 years agos4-smbtorture: use secinfo flags instead of numbers in lsa test.
Günther Deschner [Thu, 16 Jul 2009 16:38:25 +0000 (18:38 +0200)]
s4-smbtorture: use secinfo flags instead of numbers in lsa test.

Guenther

12 years agos3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().
Günther Deschner [Thu, 16 Jul 2009 16:37:19 +0000 (18:37 +0200)]
s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().

Guenther

12 years agos3-lsa: implement _lsa_LookupPrivName().
Günther Deschner [Thu, 16 Jul 2009 16:32:53 +0000 (18:32 +0200)]
s3-lsa: implement _lsa_LookupPrivName().

Guenther

12 years agos3-lsa: implement _lsa_EnumAccountsWithUserRight().
Günther Deschner [Thu, 16 Jul 2009 00:25:43 +0000 (02:25 +0200)]
s3-lsa: implement _lsa_EnumAccountsWithUserRight().

Guenther

12 years agoTidyup prompted by #6554 - Wrong deallocation in sam_account_ok.
Jeremy Allison [Thu, 16 Jul 2009 16:54:14 +0000 (09:54 -0700)]
Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.
Jeremy.

12 years agos4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version
Stefan Metzmacher [Thu, 16 Jul 2009 10:21:29 +0000 (12:21 +0200)]
s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version

Otherwise heimdal/lib/gssapi/gssapi/gssapi.h will just define it to
__attribute__ ((deprecated)) which is not supported by all compilers
we care about.

This should fix the build on Tru64

metze

12 years agos4:heimdal_build: try to fix the build on systems without ifaddrs.h
Stefan Metzmacher [Thu, 16 Jul 2009 10:08:56 +0000 (12:08 +0200)]
s4:heimdal_build: try to fix the build on systems without ifaddrs.h

metze

12 years agotevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART defined
Stefan Metzmacher [Thu, 16 Jul 2009 07:06:42 +0000 (09:06 +0200)]
tevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART defined

metze

12 years agos4:heimdal_build: tell heimdal we have inet_aton()
Stefan Metzmacher [Thu, 16 Jul 2009 08:51:34 +0000 (10:51 +0200)]
s4:heimdal_build: tell heimdal we have inet_aton()

This should fix problems on Solaris.

metze

12 years agos4-smbtorture: use torture_comment in RPC-LSA tests.
Günther Deschner [Thu, 16 Jul 2009 09:13:26 +0000 (11:13 +0200)]
s4-smbtorture: use torture_comment in RPC-LSA tests.

Guenther

12 years agofix LSA-PRIVILEGES
Günther Deschner [Thu, 16 Jul 2009 09:07:14 +0000 (11:07 +0200)]
fix LSA-PRIVILEGES

12 years agofix LSA-TRUSTED-DOMAINS
Günther Deschner [Thu, 16 Jul 2009 09:07:06 +0000 (11:07 +0200)]
fix LSA-TRUSTED-DOMAINS

12 years agos4-smbtorture: move all privilege tests to RPC-LSA-PRIVILEGES.
Günther Deschner [Thu, 16 Jul 2009 00:10:23 +0000 (02:10 +0200)]
s4-smbtorture: move all privilege tests to RPC-LSA-PRIVILEGES.

Guenther

12 years agos4-smbtorture: move all trusted domain tests to RPC-LSA-TRUSTED-DOMAINS.
Günther Deschner [Wed, 15 Jul 2009 22:56:17 +0000 (00:56 +0200)]
s4-smbtorture: move all trusted domain tests to RPC-LSA-TRUSTED-DOMAINS.

Guenther

12 years agos4:heimdal_build: try to fix the build on Solaris
Stefan Metzmacher [Thu, 16 Jul 2009 06:51:51 +0000 (08:51 +0200)]
s4:heimdal_build: try to fix the build on Solaris

The problem seems to be #define flock rk_flock

heimdal/../heimdal_build/replace.c: In function `rk_flock':
heimdal/../heimdal_build/replace.c:64: error: storage size of 'lock' isn't known
heimdal/../heimdal_build/replace.c:64: warning: unused variable `lock'

metze

12 years agotsocket: rename sa_len => sa_socklen, because sa_len is a macro on some platforms
Stefan Metzmacher [Thu, 16 Jul 2009 06:20:17 +0000 (08:20 +0200)]
tsocket: rename sa_len => sa_socklen, because sa_len is a macro on some platforms

metze

12 years agos4:kdc Initialise new hdb function pointers.
Andrew Bartlett [Tue, 7 Jul 2009 02:34:55 +0000 (12:34 +1000)]
s4:kdc Initialise new hdb function pointers.

Soon we will add implementations for these.

12 years agos4:heimdal: import lorikeet-heimdal-200907152325 (commit 2bef9cd5378c01e9c2a74d622176...
Andrew Bartlett [Wed, 15 Jul 2009 23:53:14 +0000 (09:53 +1000)]
s4:heimdal: import lorikeet-heimdal-200907152325 (commit 2bef9cd5378c01e9c2a74d6221761883bd11a5c5)

12 years agolsa: fix typo in lsa_TrustDomInfoEnum enum in IDL.
Günther Deschner [Thu, 16 Jul 2009 00:48:34 +0000 (02:48 +0200)]
lsa: fix typo in lsa_TrustDomInfoEnum enum in IDL.

Guenther

12 years agos3-ldapsam: bring Fedora DS LDAP schema in line with OpenLDAP schema.
Günther Deschner [Thu, 16 Jul 2009 00:08:17 +0000 (02:08 +0200)]
s3-ldapsam: bring Fedora DS LDAP schema in line with OpenLDAP schema.

Guenther

12 years agos3-rpc_parse: remove more unused code.
Günther Deschner [Wed, 15 Jul 2009 21:16:19 +0000 (23:16 +0200)]
s3-rpc_parse: remove more unused code.

Guenther

12 years agos3-spoolss: make some of the command hooks static.
Günther Deschner [Wed, 15 Jul 2009 19:59:05 +0000 (21:59 +0200)]
s3-spoolss: make some of the command hooks static.

Guenther

12 years agos4-smbtorture: some work on getprinterdriver and getprinterdriver2 tests.
Günther Deschner [Fri, 3 Jul 2009 20:01:01 +0000 (22:01 +0200)]
s4-smbtorture: some work on getprinterdriver and getprinterdriver2 tests.

Guenther

12 years agos4:gensec Rework gensec_krb5 mutual authentication defaults
Andrew Bartlett [Wed, 15 Jul 2009 22:29:43 +0000 (08:29 +1000)]
s4:gensec Rework gensec_krb5 mutual authentication defaults

When emulating Samba3 (which we do to ensure we don't break
compatability), don't do mutual authentication by default, as it
breaks the session key with AES and isn't what Samba3 does anyway.

Andrew Bartlett

12 years agos4:heimdal The implied GSS_C_MUTUAL_FLAG depends on AP_OPTS_MUTUAL_REQUIRED
Andrew Bartlett [Tue, 14 Jul 2009 03:22:38 +0000 (13:22 +1000)]
s4:heimdal The implied GSS_C_MUTUAL_FLAG depends on AP_OPTS_MUTUAL_REQUIRED

We had previously assumed it was unconditional.  Samba3 didn't mind
very much, but Samba4's samba3-like client did, and the behaviour
differed to Win2008 behaviour.

Andrew Bartlett

12 years agos4:gensec Allow mutual auth to be turned off in 'fake_gssapi_krb5'
Andrew Bartlett [Tue, 14 Jul 2009 00:19:16 +0000 (10:19 +1000)]
s4:gensec Allow mutual auth to be turned off in 'fake_gssapi_krb5'

This allows the older 'like Samba3' GENSEC krb5 implementation to work
against Windows 2008.  I'm using this to track down interop issues in
this area.

Andrew Bartlett

12 years agos4:dsdb Handle dc/domain/forest functional levels properly
Andrew Bartlett [Mon, 13 Jul 2009 22:15:50 +0000 (08:15 +1000)]
s4:dsdb Handle dc/domain/forest functional levels properly

Rather than have the functional levels scattered in 4 different,
unconnected locations, the provision script now sets it, and the
rootdse module maintains it's copy only as a cached view onto the
original values.

We also use the functional level to determine if we should store AES
Kerberos keys.

Andrew Bartlett

12 years agoAdd a way to set an opaque integer onto a samdb
Andrew Bartlett [Mon, 13 Jul 2009 22:00:09 +0000 (08:00 +1000)]
Add a way to set an opaque integer onto a samdb

This will allow us to set some more flags into ldb during the provision.

12 years agoAdd ad-schema/*.txt and utils to the installmisc.sh
Timur I. Bakeyev [Sun, 12 Jul 2009 23:36:08 +0000 (23:36 +0000)]
Add ad-schema/*.txt and utils to the installmisc.sh

Install other useful scripts from the setup/ directory, not only
provisioning ones.

Also install setup/ad-schema/*.txt files to the SETUPDIR. These are
necessary for 'provision' to work properly.

12 years agoFix bug #6551 - win98 clients cannot connect after server upgrade to samba-3.4.0.
Jeremy Allison [Wed, 15 Jul 2009 20:59:11 +0000 (13:59 -0700)]
Fix bug #6551 - win98 clients cannot connect after server upgrade to samba-3.4.0.
The values of vuid and tid were not being correctly updated in the struct smb_request
when passed to chain_reply inside sessionsetupX and tconX.
Jeremy.

12 years agos3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type
Stefan Metzmacher [Wed, 15 Jul 2009 19:02:42 +0000 (21:02 +0200)]
s3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type

metze

12 years agos3:libsmb: we need to include "includes.h" as first header to let code build on all...
Stefan Metzmacher [Wed, 15 Jul 2009 18:58:11 +0000 (20:58 +0200)]
s3:libsmb: we need to include "includes.h" as first header to let code build on all platforms

This should fix the Tru64 build.

metze

12 years agos3:tldap: fix the build - a void function should not return a value
Stefan Metzmacher [Wed, 15 Jul 2009 18:54:01 +0000 (20:54 +0200)]
s3:tldap: fix the build - a void function should not return a value

metze

12 years agoMake cli_unlock and cli_unlock64 async. Fix POSIX lock test.
Jeremy Allison [Wed, 15 Jul 2009 18:49:33 +0000 (11:49 -0700)]
Make cli_unlock and cli_unlock64 async. Fix POSIX lock test.
Jeremy.

12 years agos4:winbind: rename uint => uint32_t as uint isn't portable
Stefan Metzmacher [Wed, 15 Jul 2009 18:47:07 +0000 (20:47 +0200)]
s4:winbind: rename uint => uint32_t as uint isn't portable

metze

12 years agos4:libnet: rename uint => uint32_t because uint is not portable
Stefan Metzmacher [Wed, 15 Jul 2009 18:45:53 +0000 (20:45 +0200)]
s4:libnet: rename uint => uint32_t because uint is not portable

metze

12 years agos4:heimdal_build: try to fix the build on Solaris
Stefan Metzmacher [Wed, 15 Jul 2009 18:43:23 +0000 (20:43 +0200)]
s4:heimdal_build: try to fix the build on Solaris

We need the definition of 'struct flock'.

metze

12 years agos4:ntvfs/ipc: replace unnesessary talloc_reference() by a simple talloc_strdup()
Stefan Metzmacher [Wed, 15 Jul 2009 17:23:12 +0000 (19:23 +0200)]
s4:ntvfs/ipc: replace unnesessary talloc_reference() by a simple talloc_strdup()

metze

12 years agos3:ntvfs/posix: avoid unnesessary talloc_reference()
Stefan Metzmacher [Wed, 15 Jul 2009 17:17:57 +0000 (19:17 +0200)]
s3:ntvfs/posix: avoid unnesessary talloc_reference()

This caused the panics on the RAW-SETFILEINFO.RENAME test,
because we returned an empty strings.

The problem was:

ERROR: talloc_steal with references at ntvfs/posix/pvfs_setfileinfo.c:215
       reference at ntvfs/posix/pvfs_resolve.c:799

metze

12 years agos4:heimdal: teach heimdal we have (v)aѕprintf in libreplace
Björn Jacke [Wed, 15 Jul 2009 16:40:57 +0000 (18:40 +0200)]
s4:heimdal: teach heimdal we have (v)aѕprintf in libreplace

12 years agoѕ4:heimdal: teach heimdal that we have strnlen via libreplcae
Björn Jacke [Wed, 15 Jul 2009 16:32:58 +0000 (18:32 +0200)]
ѕ4:heimdal: teach heimdal that we have strnlen via libreplcae

12 years agos3: make linking of rpcclient --as-needed safe
Björn Jacke [Wed, 15 Jul 2009 15:24:14 +0000 (17:24 +0200)]
s3: make linking of rpcclient --as-needed safe

12 years agos3: make linking of cifs.upcall --as-needed safe
Peter Volkov [Wed, 15 Jul 2009 15:36:25 +0000 (17:36 +0200)]
s3: make linking of cifs.upcall --as-needed safe

See http://www.gentoo.org/proj/en/qa/asneeded.xml for details.

12 years agos3:dbwrap: fix embarrassing typo :-)
Michael Adam [Wed, 15 Jul 2009 14:59:07 +0000 (16:59 +0200)]
s3:dbwrap: fix embarrassing typo :-)

Michael

12 years agos3:registry: db backend: add my C
Michael Adam [Tue, 7 Jul 2009 15:16:21 +0000 (17:16 +0200)]
s3:registry: db backend: add my C

Michael

12 years agos3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()
Michael Adam [Wed, 15 Jul 2009 10:50:55 +0000 (12:50 +0200)]
s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()

This way, we always return what has really been read from the db,
and not more. The callers assume exactly this, but one could hand
in an already pre-filled subkey container...

Michael

12 years agos3:registry: add function regsubkey_ctr_reinit()
Michael Adam [Wed, 15 Jul 2009 10:47:12 +0000 (12:47 +0200)]
s3:registry: add function regsubkey_ctr_reinit()

This reinitializes an already allocated regsubkey_ctr structure,
emptying out the subkey array and hash table.

Michael

12 years agos3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type
Michael Adam [Wed, 15 Jul 2009 10:45:43 +0000 (12:45 +0200)]
s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type

This way, more error information is propagated to the callers.

Michael

12 years agos3:registry: use transaction wrapper in create_sorted_subkeys()
Michael Adam [Mon, 13 Jul 2009 15:15:14 +0000 (17:15 +0200)]
s3:registry: use transaction wrapper in create_sorted_subkeys()

Michael

12 years agos3:registry: restructure logic of create_sorted_subkes() slightly
Michael Adam [Thu, 9 Jul 2009 10:54:16 +0000 (12:54 +0200)]
s3:registry: restructure logic of create_sorted_subkes() slightly

This makes it clearer to me, and it also makes it easier to
use the transaction retry wrapper in the next step.

Michael

12 years agos3:registry: use transaction wrapper in regdb_delete_subkey().
Michael Adam [Thu, 9 Jul 2009 09:04:20 +0000 (11:04 +0200)]
s3:registry: use transaction wrapper in regdb_delete_subkey().

Michael

12 years agos3:registry: add a comment header for the delete_subkey set of commands.
Michael Adam [Thu, 9 Jul 2009 08:54:18 +0000 (10:54 +0200)]
s3:registry: add a comment header for the delete_subkey set of commands.

Michael

12 years agos3:registry: add a comment header for the create_subkey set of functions
Michael Adam [Thu, 9 Jul 2009 08:52:40 +0000 (10:52 +0200)]
s3:registry: add a comment header for the create_subkey set of functions

Michael

12 years agos3:registry: use transaction wrapper in regdb_create_subkey()
Michael Adam [Thu, 9 Jul 2009 08:41:59 +0000 (10:41 +0200)]
s3:registry: use transaction wrapper in regdb_create_subkey()

Michael

12 years agos3:registry: use transaction wrapper in regdb_store_keys_internal().
Michael Adam [Thu, 9 Jul 2009 08:28:29 +0000 (10:28 +0200)]
s3:registry: use transaction wrapper in regdb_store_keys_internal().

Michael

12 years agos3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()
Michael Adam [Wed, 8 Jul 2009 22:21:46 +0000 (00:21 +0200)]
s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()

and catch one potential talloc failure.

Michael

12 years agos3:registry: unify exit logic and remove leaking to talloc_stack in regdb_store_keys_...
Michael Adam [Wed, 8 Jul 2009 22:10:08 +0000 (00:10 +0200)]
s3:registry: unify exit logic and remove leaking to talloc_stack in regdb_store_keys_internal()

Michael

12 years agos3:registry: change regdb_store_keys_internal2() to return WERROR
Michael Adam [Wed, 8 Jul 2009 15:26:06 +0000 (17:26 +0200)]
s3:registry: change regdb_store_keys_internal2() to return WERROR

instead of bool for better error propagation.

Michael

12 years agos3:registry: refactor adding of builtin reg values out
Michael Adam [Wed, 8 Jul 2009 11:58:52 +0000 (13:58 +0200)]
s3:registry: refactor adding of builtin reg values out

into regdb_ctr_add_value(). For readability.

Michael

12 years agos3:registry: use transaction wrapper in init_registry_data()
Michael Adam [Wed, 8 Jul 2009 11:10:37 +0000 (13:10 +0200)]
s3:registry: use transaction wrapper in init_registry_data()

Michael

12 years agos3:registry: add regdb_store_values_internal() that takes a db_context argument
Michael Adam [Wed, 8 Jul 2009 10:38:41 +0000 (12:38 +0200)]
s3:registry: add regdb_store_values_internal() that takes a db_context argument

Michael

12 years agos3:registry: add a regdb_fetch_values_internal() that takes a db_context argument
Michael Adam [Wed, 8 Jul 2009 10:32:48 +0000 (12:32 +0200)]
s3:registry: add a regdb_fetch_values_internal() that takes a db_context argument

Michael

12 years agos3:registry: use transaction wrapper in init_registry_key().
Michael Adam [Tue, 7 Jul 2009 21:58:03 +0000 (23:58 +0200)]
s3:registry: use transaction wrapper in init_registry_key().

Michael

12 years agos3:registry: add db_context argument to init_registry_key_internal()
Michael Adam [Tue, 7 Jul 2009 21:03:46 +0000 (23:03 +0200)]
s3:registry: add db_context argument to init_registry_key_internal()

Michael