Jeremy Allison [Fri, 17 Jul 2009 01:14:56 +0000 (18:14 -0700)]
Replace more long-lived contexts with talloc_autofree_context().
Jeremy.
Jeremy Allison [Fri, 17 Jul 2009 01:13:46 +0000 (18:13 -0700)]
Replace short-lived NULL talloc contexts with talloc_tos().
Jeremy.
Jeremy Allison [Fri, 17 Jul 2009 01:12:17 +0000 (18:12 -0700)]
Remove an unused talloc context.
Jeremy.
Andrew Bartlett [Thu, 16 Jul 2009 22:39:51 +0000 (08:39 +1000)]
Revert "s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version"
This is now handled correctly in the newly imported Heimdal
This reverts commit
4a754d029b0eb229b23980aa4a80dae2b485a302.
Andrew Bartlett [Thu, 16 Jul 2009 22:29:03 +0000 (08:29 +1000)]
s4:heimdal: import lorikeet-heimdal-
200907162216 (commit
d09910d6803aad96b52ee626327ee55b14ea0de8)
This includes in particular changes to the KDC to resolve bug 6272,
originally by Matthieu Patou <mat+Informatique.Samba@matws.net>. We
need to sort the AuthorizationData elements to put the PAC first, or
else WinXP breaks when browsed from Win2k8.
Andrew Bartlett
Andrew Bartlett [Thu, 16 Jul 2009 07:37:36 +0000 (17:37 +1000)]
s4:kdc Rework KDC to pull in less attributes for krbtgt lookups
Each attribute we request from LDB comes with a small cost, so don't
lookup any more than we must for the (very) frequent krbtgt lookup
case. Similarly, we don't need to build a PAC for a server (as a
target), so don't ask for the PAC attributes here either.
Andrew Bartlett
Andrew Bartlett [Thu, 16 Jul 2009 02:47:57 +0000 (12:47 +1000)]
s4:kdc rename functions from LDB_ to hdb_samba4
The LDB_ prefix is misleading, and stomps on the LDB namespace. This
is a Samba4 hdb module, and not something generic.
Andrew Bartlett
Günther Deschner [Thu, 16 Jul 2009 16:39:06 +0000 (18:39 +0200)]
Revert "fix LSA-PRIVILEGES"
This reverts commit
0d9fdbceedddb08dbea8ed84e06a218d3ec562f4.
Günther Deschner [Thu, 16 Jul 2009 16:38:55 +0000 (18:38 +0200)]
Revert "fix LSA-TRUSTED-DOMAINS"
This reverts commit
3c9b26276083002124674678ac757e859fb6b20e.
Günther Deschner [Thu, 16 Jul 2009 16:38:25 +0000 (18:38 +0200)]
s4-smbtorture: use secinfo flags instead of numbers in lsa test.
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:37:19 +0000 (18:37 +0200)]
s3-lsa: Fix pointless check for sec_info flags in _lsa_QuerySecurity().
Guenther
Günther Deschner [Thu, 16 Jul 2009 16:32:53 +0000 (18:32 +0200)]
s3-lsa: implement _lsa_LookupPrivName().
Guenther
Günther Deschner [Thu, 16 Jul 2009 00:25:43 +0000 (02:25 +0200)]
s3-lsa: implement _lsa_EnumAccountsWithUserRight().
Guenther
Jeremy Allison [Thu, 16 Jul 2009 16:54:14 +0000 (09:54 -0700)]
Tidyup prompted by #6554 - Wrong deallocation in sam_account_ok.
Jeremy.
Stefan Metzmacher [Thu, 16 Jul 2009 10:21:29 +0000 (12:21 +0200)]
s4:heimdal_build: predefine GSSAPI_DEPRECATED depending on the compiler version
Otherwise heimdal/lib/gssapi/gssapi/gssapi.h will just define it to
__attribute__ ((deprecated)) which is not supported by all compilers
we care about.
This should fix the build on Tru64
metze
Stefan Metzmacher [Thu, 16 Jul 2009 10:08:56 +0000 (12:08 +0200)]
s4:heimdal_build: try to fix the build on systems without ifaddrs.h
metze
Stefan Metzmacher [Thu, 16 Jul 2009 07:06:42 +0000 (09:06 +0200)]
tevent: try to fix the build on QNX qnx18 6.4.1 it doesn't have SA_RESTART defined
metze
Stefan Metzmacher [Thu, 16 Jul 2009 08:51:34 +0000 (10:51 +0200)]
s4:heimdal_build: tell heimdal we have inet_aton()
This should fix problems on Solaris.
metze
Günther Deschner [Thu, 16 Jul 2009 09:13:26 +0000 (11:13 +0200)]
s4-smbtorture: use torture_comment in RPC-LSA tests.
Guenther
Günther Deschner [Thu, 16 Jul 2009 09:07:14 +0000 (11:07 +0200)]
fix LSA-PRIVILEGES
Günther Deschner [Thu, 16 Jul 2009 09:07:06 +0000 (11:07 +0200)]
fix LSA-TRUSTED-DOMAINS
Günther Deschner [Thu, 16 Jul 2009 00:10:23 +0000 (02:10 +0200)]
s4-smbtorture: move all privilege tests to RPC-LSA-PRIVILEGES.
Guenther
Günther Deschner [Wed, 15 Jul 2009 22:56:17 +0000 (00:56 +0200)]
s4-smbtorture: move all trusted domain tests to RPC-LSA-TRUSTED-DOMAINS.
Guenther
Stefan Metzmacher [Thu, 16 Jul 2009 06:51:51 +0000 (08:51 +0200)]
s4:heimdal_build: try to fix the build on Solaris
The problem seems to be #define flock rk_flock
heimdal/../heimdal_build/replace.c: In function `rk_flock':
heimdal/../heimdal_build/replace.c:64: error: storage size of 'lock' isn't known
heimdal/../heimdal_build/replace.c:64: warning: unused variable `lock'
metze
Stefan Metzmacher [Thu, 16 Jul 2009 06:20:17 +0000 (08:20 +0200)]
tsocket: rename sa_len => sa_socklen, because sa_len is a macro on some platforms
metze
Andrew Bartlett [Tue, 7 Jul 2009 02:34:55 +0000 (12:34 +1000)]
s4:kdc Initialise new hdb function pointers.
Soon we will add implementations for these.
Andrew Bartlett [Wed, 15 Jul 2009 23:53:14 +0000 (09:53 +1000)]
Günther Deschner [Thu, 16 Jul 2009 00:48:34 +0000 (02:48 +0200)]
lsa: fix typo in lsa_TrustDomInfoEnum enum in IDL.
Guenther
Günther Deschner [Thu, 16 Jul 2009 00:08:17 +0000 (02:08 +0200)]
s3-ldapsam: bring Fedora DS LDAP schema in line with OpenLDAP schema.
Guenther
Günther Deschner [Wed, 15 Jul 2009 21:16:19 +0000 (23:16 +0200)]
s3-rpc_parse: remove more unused code.
Guenther
Günther Deschner [Wed, 15 Jul 2009 19:59:05 +0000 (21:59 +0200)]
s3-spoolss: make some of the command hooks static.
Guenther
Günther Deschner [Fri, 3 Jul 2009 20:01:01 +0000 (22:01 +0200)]
s4-smbtorture: some work on getprinterdriver and getprinterdriver2 tests.
Guenther
Andrew Bartlett [Wed, 15 Jul 2009 22:29:43 +0000 (08:29 +1000)]
s4:gensec Rework gensec_krb5 mutual authentication defaults
When emulating Samba3 (which we do to ensure we don't break
compatability), don't do mutual authentication by default, as it
breaks the session key with AES and isn't what Samba3 does anyway.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jul 2009 03:22:38 +0000 (13:22 +1000)]
s4:heimdal The implied GSS_C_MUTUAL_FLAG depends on AP_OPTS_MUTUAL_REQUIRED
We had previously assumed it was unconditional. Samba3 didn't mind
very much, but Samba4's samba3-like client did, and the behaviour
differed to Win2008 behaviour.
Andrew Bartlett
Andrew Bartlett [Tue, 14 Jul 2009 00:19:16 +0000 (10:19 +1000)]
s4:gensec Allow mutual auth to be turned off in 'fake_gssapi_krb5'
This allows the older 'like Samba3' GENSEC krb5 implementation to work
against Windows 2008. I'm using this to track down interop issues in
this area.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jul 2009 22:15:50 +0000 (08:15 +1000)]
s4:dsdb Handle dc/domain/forest functional levels properly
Rather than have the functional levels scattered in 4 different,
unconnected locations, the provision script now sets it, and the
rootdse module maintains it's copy only as a cached view onto the
original values.
We also use the functional level to determine if we should store AES
Kerberos keys.
Andrew Bartlett
Andrew Bartlett [Mon, 13 Jul 2009 22:00:09 +0000 (08:00 +1000)]
Add a way to set an opaque integer onto a samdb
This will allow us to set some more flags into ldb during the provision.
Timur I. Bakeyev [Sun, 12 Jul 2009 23:36:08 +0000 (23:36 +0000)]
Add ad-schema/*.txt and utils to the installmisc.sh
Install other useful scripts from the setup/ directory, not only
provisioning ones.
Also install setup/ad-schema/*.txt files to the SETUPDIR. These are
necessary for 'provision' to work properly.
Jeremy Allison [Wed, 15 Jul 2009 20:59:11 +0000 (13:59 -0700)]
Fix bug #6551 - win98 clients cannot connect after server upgrade to samba-3.4.0.
The values of vuid and tid were not being correctly updated in the struct smb_request
when passed to chain_reply inside sessionsetupX and tconX.
Jeremy.
Stefan Metzmacher [Wed, 15 Jul 2009 19:02:42 +0000 (21:02 +0200)]
s3:smbd: try to fix a compiler warning on i386 : left shift count >= width of type
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:58:11 +0000 (20:58 +0200)]
s3:libsmb: we need to include "includes.h" as first header to let code build on all platforms
This should fix the Tru64 build.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:54:01 +0000 (20:54 +0200)]
s3:tldap: fix the build - a void function should not return a value
metze
Jeremy Allison [Wed, 15 Jul 2009 18:49:33 +0000 (11:49 -0700)]
Make cli_unlock and cli_unlock64 async. Fix POSIX lock test.
Jeremy.
Stefan Metzmacher [Wed, 15 Jul 2009 18:47:07 +0000 (20:47 +0200)]
s4:winbind: rename uint => uint32_t as uint isn't portable
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:45:53 +0000 (20:45 +0200)]
s4:libnet: rename uint => uint32_t because uint is not portable
metze
Stefan Metzmacher [Wed, 15 Jul 2009 18:43:23 +0000 (20:43 +0200)]
s4:heimdal_build: try to fix the build on Solaris
We need the definition of 'struct flock'.
metze
Stefan Metzmacher [Wed, 15 Jul 2009 17:23:12 +0000 (19:23 +0200)]
s4:ntvfs/ipc: replace unnesessary talloc_reference() by a simple talloc_strdup()
metze
Stefan Metzmacher [Wed, 15 Jul 2009 17:17:57 +0000 (19:17 +0200)]
s3:ntvfs/posix: avoid unnesessary talloc_reference()
This caused the panics on the RAW-SETFILEINFO.RENAME test,
because we returned an empty strings.
The problem was:
ERROR: talloc_steal with references at ntvfs/posix/pvfs_setfileinfo.c:215
reference at ntvfs/posix/pvfs_resolve.c:799
metze
Björn Jacke [Wed, 15 Jul 2009 16:40:57 +0000 (18:40 +0200)]
s4:heimdal: teach heimdal we have (v)aѕprintf in libreplace
Björn Jacke [Wed, 15 Jul 2009 16:32:58 +0000 (18:32 +0200)]
ѕ4:heimdal: teach heimdal that we have strnlen via libreplcae
Björn Jacke [Wed, 15 Jul 2009 15:24:14 +0000 (17:24 +0200)]
s3: make linking of rpcclient --as-needed safe
Peter Volkov [Wed, 15 Jul 2009 15:36:25 +0000 (17:36 +0200)]
s3: make linking of cifs.upcall --as-needed safe
See http://www.gentoo.org/proj/en/qa/asneeded.xml for details.
Michael Adam [Wed, 15 Jul 2009 14:59:07 +0000 (16:59 +0200)]
s3:dbwrap: fix embarrassing typo :-)
Michael
Michael Adam [Tue, 7 Jul 2009 15:16:21 +0000 (17:16 +0200)]
s3:registry: db backend: add my C
Michael
Michael Adam [Wed, 15 Jul 2009 10:50:55 +0000 (12:50 +0200)]
s3:registry: flush the provided subkey_ctr in regdb_fetch_keys_internal()
This way, we always return what has really been read from the db,
and not more. The callers assume exactly this, but one could hand
in an already pre-filled subkey container...
Michael
Michael Adam [Wed, 15 Jul 2009 10:47:12 +0000 (12:47 +0200)]
s3:registry: add function regsubkey_ctr_reinit()
This reinitializes an already allocated regsubkey_ctr structure,
emptying out the subkey array and hash table.
Michael
Michael Adam [Wed, 15 Jul 2009 10:45:43 +0000 (12:45 +0200)]
s3:registry: turn regdb_fetch_keys_internal() from int to WERROR return type
This way, more error information is propagated to the callers.
Michael
Michael Adam [Mon, 13 Jul 2009 15:15:14 +0000 (17:15 +0200)]
s3:registry: use transaction wrapper in create_sorted_subkeys()
Michael
Michael Adam [Thu, 9 Jul 2009 10:54:16 +0000 (12:54 +0200)]
s3:registry: restructure logic of create_sorted_subkes() slightly
This makes it clearer to me, and it also makes it easier to
use the transaction retry wrapper in the next step.
Michael
Michael Adam [Thu, 9 Jul 2009 09:04:20 +0000 (11:04 +0200)]
s3:registry: use transaction wrapper in regdb_delete_subkey().
Michael
Michael Adam [Thu, 9 Jul 2009 08:54:18 +0000 (10:54 +0200)]
s3:registry: add a comment header for the delete_subkey set of commands.
Michael
Michael Adam [Thu, 9 Jul 2009 08:52:40 +0000 (10:52 +0200)]
s3:registry: add a comment header for the create_subkey set of functions
Michael
Michael Adam [Thu, 9 Jul 2009 08:41:59 +0000 (10:41 +0200)]
s3:registry: use transaction wrapper in regdb_create_subkey()
Michael
Michael Adam [Thu, 9 Jul 2009 08:28:29 +0000 (10:28 +0200)]
s3:registry: use transaction wrapper in regdb_store_keys_internal().
Michael
Michael Adam [Wed, 8 Jul 2009 22:21:46 +0000 (00:21 +0200)]
s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()
and catch one potential talloc failure.
Michael
Michael Adam [Wed, 8 Jul 2009 22:10:08 +0000 (00:10 +0200)]
s3:registry: unify exit logic and remove leaking to talloc_stack in regdb_store_keys_internal()
Michael
Michael Adam [Wed, 8 Jul 2009 15:26:06 +0000 (17:26 +0200)]
s3:registry: change regdb_store_keys_internal2() to return WERROR
instead of bool for better error propagation.
Michael
Michael Adam [Wed, 8 Jul 2009 11:58:52 +0000 (13:58 +0200)]
s3:registry: refactor adding of builtin reg values out
into regdb_ctr_add_value(). For readability.
Michael
Michael Adam [Wed, 8 Jul 2009 11:10:37 +0000 (13:10 +0200)]
s3:registry: use transaction wrapper in init_registry_data()
Michael
Michael Adam [Wed, 8 Jul 2009 10:38:41 +0000 (12:38 +0200)]
s3:registry: add regdb_store_values_internal() that takes a db_context argument
Michael
Michael Adam [Wed, 8 Jul 2009 10:32:48 +0000 (12:32 +0200)]
s3:registry: add a regdb_fetch_values_internal() that takes a db_context argument
Michael
Michael Adam [Tue, 7 Jul 2009 21:58:03 +0000 (23:58 +0200)]
s3:registry: use transaction wrapper in init_registry_key().
Michael
Michael Adam [Tue, 7 Jul 2009 21:03:46 +0000 (23:03 +0200)]
s3:registry: add db_context argument to init_registry_key_internal()
Michael
Michael Adam [Tue, 7 Jul 2009 10:42:09 +0000 (12:42 +0200)]
s3:registry: panic upon error at transaction_cancel in create_sorted_subkeys
Michael
Michael Adam [Tue, 7 Jul 2009 10:41:09 +0000 (12:41 +0200)]
s3:registry: fix a comment in create_sorted_subkeys()
Michael
Michael Adam [Tue, 7 Jul 2009 10:39:32 +0000 (12:39 +0200)]
s3:registry: don't loop transaction_commit in create_sorted_subkeys() upon error
This would try to commit a higher level transaction upon commit-error.
Michael
Michael Adam [Tue, 7 Jul 2009 10:27:26 +0000 (12:27 +0200)]
s3:registry: in regdb_delete_subkey(), don't use the transaction wrappers.
This way, the db handle gets used explicitly and the core of the
function can be abstracted.
Michael
Michael Adam [Tue, 7 Jul 2009 10:24:25 +0000 (12:24 +0200)]
s3:registry: in regdb_delete_subkey(), panic if transaction_cancel fails
Michael
Michael Adam [Tue, 7 Jul 2009 10:20:23 +0000 (12:20 +0200)]
s3:registry: panic upon failed transaction_cancel in regdb_create_subkey()
Michael
Michael Adam [Tue, 7 Jul 2009 09:41:08 +0000 (11:41 +0200)]
s3:registry: don't use exported transaction wrappers in regdb_create_subkey()
So that the regdb handle is again explicit and the core of the
function can be abstracted.
Michael
Michael Adam [Tue, 7 Jul 2009 09:31:28 +0000 (11:31 +0200)]
s3:registry: create regdb_store_keys_internal() with db_context argument
and let exported regdb_store_keys() just call regdb_store_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
Michael Adam [Tue, 7 Jul 2009 09:11:10 +0000 (11:11 +0200)]
s3:registry: rename regdb_store_keys_internal() to regdb_store_keys_internal2()
Michael
Michael Adam [Fri, 3 Jul 2009 15:39:17 +0000 (17:39 +0200)]
s3:registry: create regdb_fetch_keys_internal() with db_context argument
and let exported regdb_fetch_keys() just call regdb_fetch_keys_internal()
with regdb as an argument. Internally, in reg_backend_db.c, always use the
_internal version.
Michael
Michael Adam [Fri, 3 Jul 2009 15:18:19 +0000 (17:18 +0200)]
s3:registry: add db_context argument to scan_parent_subkeys()
Michael
Michael Adam [Fri, 3 Jul 2009 15:10:09 +0000 (17:10 +0200)]
s3:registry: add db_context argument to regdb_fetch_key_internal()
Michael
Michael Adam [Fri, 3 Jul 2009 15:00:44 +0000 (17:00 +0200)]
s3:registry: add db_context argument to regdb_store_keys_internal()
Michael
Michael Adam [Fri, 3 Jul 2009 14:51:26 +0000 (16:51 +0200)]
s3:registry: add db_context argument to regdb_delete_key_lists()
Michael
Michael Adam [Fri, 3 Jul 2009 14:48:36 +0000 (16:48 +0200)]
s3:registry: add db_context argument to regdb_delete_subkeylist()
Michael
Michael Adam [Fri, 3 Jul 2009 14:44:20 +0000 (16:44 +0200)]
s3:registry: add db_context argument to regdb_delete_secdesc()
Michael
Michael Adam [Fri, 3 Jul 2009 14:42:20 +0000 (16:42 +0200)]
s3:registry: add db_context argument to regdb_delete_values()
Michael
Michael Adam [Fri, 3 Jul 2009 14:40:43 +0000 (16:40 +0200)]
s3:registry: add db_context argument to regdb_delete_key_with_prefix()
Michael
Michael Adam [Wed, 8 Jul 2009 14:16:18 +0000 (16:16 +0200)]
s3:registry: don't store differently cased entries for the same keys.
This happened for instance during registry initialization, when
entries for HKLM\Software and HKLM\SOFTWARE were created.
Searching these entries was case insensitive though.
But the entries ended up in the subkey-lists anyways.
This is solved by making the subkeys_hash in the regsubkey_container
structs case insensitive (using the new _bystring_upper() wrappers).
Michael
Michael Adam [Wed, 15 Jul 2009 07:58:02 +0000 (09:58 +0200)]
s3:dbwrap_util: add my C
Michael
Michael Adam [Wed, 8 Jul 2009 14:13:07 +0000 (16:13 +0200)]
s3:dbwrap: add dbwrap_fetch_bystring_upper().
To fetch a key whose name is stored but not given in upper case.
Michael
Michael Adam [Wed, 8 Jul 2009 14:08:41 +0000 (16:08 +0200)]
s3:dbwrap: add dbwrap_store_bystring_upper().
This stores a key under the uppercase version of the given keyname.
Michael
Michael Adam [Wed, 8 Jul 2009 14:02:19 +0000 (16:02 +0200)]
s3:dbwrap: add dbwrap_delete_bystring_upper()
To delete a key whose name is not given in but stored in uppercase.
Michael
Michael Adam [Wed, 15 Jul 2009 12:00:42 +0000 (14:00 +0200)]
s3:dbwrap: add a wrapper dbwrap_trans_do()
This function wraps the action() callback into a db
transaction and the transaction is either committed
or cancelled, depending on the return value of
the action function.
Michael
Stefan Metzmacher [Wed, 15 Jul 2009 10:14:32 +0000 (12:14 +0200)]
torture/smb2: add missing new line to the new SMB2-DIR.FILE-INDEX test
Without this the subunit formated output would be invalid and make test
reports: "UNEXPECTED(error): samba4.smb2.dir (dc).FILE-INDEX"
metze
Stefan Metzmacher [Mon, 13 Jul 2009 07:23:57 +0000 (09:23 +0200)]
s3:smbd: add support for SMB2 SetInfo File*Information
metze
Stefan Metzmacher [Mon, 13 Jul 2009 10:08:20 +0000 (12:08 +0200)]
s3:smbd: implement SMB2 GetInfo with Fs*Information
metze