ira/wip.git
12 years agoFix compile and linking errors since last this code was tested
Derrell Lipman [Sun, 13 Jan 2008 17:07:18 +0000 (12:07 -0500)]
Fix compile and linking errors since last this code was tested
(This used to be commit 2f432842442859f98ecd263464ce02821ab10fca)

12 years agoAs long as DsGetDcName is not part of libnetapi, lowercase the fn name.
Günther Deschner [Fri, 11 Jan 2008 14:32:20 +0000 (15:32 +0100)]
As long as DsGetDcName is not part of libnetapi, lowercase the fn name.

Guenther
(This used to be commit 19a980f52044a170618629e5b0484c1f6b586e5f)

12 years agoFix libnetapi error string callers.
Günther Deschner [Fri, 11 Jan 2008 14:28:24 +0000 (15:28 +0100)]
Fix libnetapi error string callers.

Guenther
(This used to be commit 1ad7a0a361edfa5ac738f011db1d6a9db256ac2c)

12 years agoRemove '\n' from error strings in libnet_join context.
Günther Deschner [Fri, 11 Jan 2008 14:03:31 +0000 (15:03 +0100)]
Remove '\n' from error strings in libnet_join context.

Guenther
(This used to be commit 9cc0d874f6c064e8752d36e72fcc85bf4c85e656)

12 years agoSet error string when ads_leave_realm() has failed in libnetjoin.
Günther Deschner [Fri, 11 Jan 2008 13:50:10 +0000 (14:50 +0100)]
Set error string when ads_leave_realm() has failed in libnetjoin.

Guenther
(This used to be commit 01690f85bc7d052d4c57181d74aef27d1776169c)

12 years agoInclude some basic headers in netapi.h.
Günther Deschner [Fri, 11 Jan 2008 13:47:52 +0000 (14:47 +0100)]
Include some basic headers in netapi.h.

Guenther
(This used to be commit 23b92a6fa57858c8a23c737a9cd00c076ef5dadd)

12 years agoRefactor libnetapi error string functions a bit.
Günther Deschner [Fri, 11 Jan 2008 13:47:23 +0000 (14:47 +0100)]
Refactor libnetapi error string functions a bit.

Guenther
(This used to be commit 3b450a8bcc97b6d03c4b7b9373a3a382c0fcea30)

12 years agoIgnore result of libnet_conf_delete_parameter here, as realm may be not there.
Günther Deschner [Fri, 11 Jan 2008 13:43:56 +0000 (14:43 +0100)]
Ignore result of libnet_conf_delete_parameter here, as realm may be not there.

Guenther
(This used to be commit 2e2d058b7e90a158612af4b0a489578431f748e5)

12 years agoRemove some more references to global_myname() in libnet_join.
Günther Deschner [Fri, 11 Jan 2008 13:42:48 +0000 (14:42 +0100)]
Remove some more references to global_myname() in libnet_join.

Guenther
(This used to be commit ed4960baccf687b77c2b0f4ee64cbce2005f3abb)

12 years agoUse domain_is_ad bool.
Günther Deschner [Fri, 11 Jan 2008 13:41:34 +0000 (14:41 +0100)]
Use domain_is_ad bool.

Guenther
(This used to be commit 9707a5eb008788460937104575b7afd733a9f741)

12 years agoAdd domain_is_ad bool to libnetjoin ctx.
Günther Deschner [Fri, 11 Jan 2008 13:40:06 +0000 (14:40 +0100)]
Add domain_is_ad bool to libnetjoin ctx.

Guenther
(This used to be commit 16ca8d2746a5c2fc7a583d1cf2ebb4d3aa003842)

12 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Fri, 11 Jan 2008 00:36:05 +0000 (16:36 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 767e0164adf8803df50b0b7bd8e81d25af72bb78)

12 years agoDon't switch user contexts unless you have to. Saves
Jeremy Allison [Fri, 11 Jan 2008 00:35:54 +0000 (16:35 -0800)]
Don't switch user contexts unless you have to. Saves
a bunch of syscalls on close. Noticed by Volker.
Jeremy.
(This used to be commit 3caeeaea162e2083a087c242b850c107a3be1bf9)

12 years agoCombine fsp and tofd to tofsp in SMB_VFS_RECVFILE().
Michael Adam [Fri, 11 Jan 2008 00:26:54 +0000 (01:26 +0100)]
Combine fsp and tofd to tofsp in SMB_VFS_RECVFILE().

Michael
(This used to be commit 3958abffaf2866c69ad9e13ec345364fde5c78bb)

12 years agoRemove now redundant parameter fd from prime_cache().
Michael Adam [Thu, 10 Jan 2008 23:56:06 +0000 (00:56 +0100)]
Remove now redundant parameter fd from prime_cache().

Michael
(This used to be commit 63acaf1b9755cd5be5342929e1210afa06e170f3)

12 years agoCombine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().
Michael Adam [Thu, 10 Jan 2008 23:51:19 +0000 (00:51 +0100)]
Combine fsp and fromfd to fromfsp in SMB_VFS_SENDFILE().

Michael
(This used to be commit a52cfb7d777157c93c9dc26c67f457be592dd537)

12 years agoDon't print out debug messages at level 0 if we can't
Jeremy Allison [Thu, 10 Jan 2008 23:15:01 +0000 (15:15 -0800)]
Don't print out debug messages at level 0 if we can't
bind to a socket if we've already bound to one (this
prevents :
bind failed on port 445 socket_addr = 0.0.0.0.
Error = Address already in use
bind failed on port 139 socket_addr = 0.0.0.0.
Error = Address already in use
messages when trying to bind to an IPv4 address
when we've already bound to the IPv6 equivalent.
Jeremy.
(This used to be commit 3936de735a7bb548df8ce7f06f2cc8f7ffdf56cd)

12 years agoFix the build of the cacheprime VFS module after API changes.
Michael Adam [Thu, 10 Jan 2008 22:40:13 +0000 (23:40 +0100)]
Fix the build of the cacheprime VFS module after API changes.

Sorry, that had escaped my attention.

Michael
(This used to be commit 88102b5b7c4eaad5445e9cb96e547dd918abc0c2)

12 years ago--enable-libwbclient-shared
Volker Lendecke [Mon, 7 Jan 2008 17:27:10 +0000 (18:27 +0100)]
--enable-libwbclient-shared

This patch adds the configure option --enable-libwbclient-shared that defaults
to yes. If you set --enable-developer=yes, then you can say
--enable-libwbclient-shared=no to avoid problems you might have with the wrong
shared libaries.

Jerry, is this acceptable to you? If yes, please push.

Thanks!

Volker
(This used to be commit 7a88cd61e09f6db9db38916704ae65e03b33139c)

12 years agoTiny cosmetic fix
Volker Lendecke [Thu, 10 Jan 2008 12:22:51 +0000 (13:22 +0100)]
Tiny cosmetic fix
(This used to be commit c82c1d462be6ddccd6e395b4a9630df91dacbda2)

12 years agoRemove redundant parameter fd from SMB_VFS_WRITE().
Michael Adam [Thu, 10 Jan 2008 14:49:35 +0000 (15:49 +0100)]
Remove redundant parameter fd from SMB_VFS_WRITE().

Michael
(This used to be commit c8ae7d095a2a6a7eac920a68ca7244e3a423e1b1)

12 years agoRemove redundant parameter fd from SMB_VFS_READ().
Michael Adam [Thu, 10 Jan 2008 14:33:51 +0000 (15:33 +0100)]
Remove redundant parameter fd from SMB_VFS_READ().

Michael
(This used to be commit a8fc2ddad8d5f7c6c00cb36c74a32a02d69d1d04)

12 years agoMove transfer_file and transfer_file_internal to a module of their own.
Michael Adam [Thu, 10 Jan 2008 13:27:52 +0000 (14:27 +0100)]
Move transfer_file and transfer_file_internal to a module of their own.

Also, don't auto-generate prototypes of the (two) exported functions
but make a start in having handwritten prototypes in dedicated header
files (not in includes.h ... :-)

Michael
(This used to be commit 395f29d8b768a56af20b37f185eccdc5f37b68d5)

12 years agoReformat some code I just touched.
Michael Adam [Thu, 10 Jan 2008 12:55:46 +0000 (13:55 +0100)]
Reformat some code I just touched.

Michael
(This used to be commit 4ed238b1e46f7680a29ebdbfe9500d16718f9057)

12 years agoMake casts to (void *) explicit to remove compiler warnings.
Michael Adam [Thu, 10 Jan 2008 12:55:16 +0000 (13:55 +0100)]
Make casts to (void *) explicit to remove compiler warnings.

Michael
(This used to be commit cbbfbd7a63fe0fc479a1b63b4552c713633dd6be)

12 years agoFix a really silly typo.
Michael Adam [Thu, 10 Jan 2008 13:18:46 +0000 (14:18 +0100)]
Fix a really silly typo.

Michael
(This used to be commit 7b0af7cdc97d4bbcbd73a9474871217511b92c3a)

12 years agoCorrectly abstract the transfer_file mechanism with callbacks and void ptrs.
Michael Adam [Thu, 10 Jan 2008 12:30:43 +0000 (13:30 +0100)]
Correctly abstract the transfer_file mechanism with callbacks and void ptrs.

This removes the in_fsp and out_fsp global variables hack from smbd/vfs.c.

Michael
(This used to be commit b2e7cdc6e899ca3c16edbb6c8786ff9aa999fa6e)

12 years agouse talloc_tos() in share_access_check()
Volker Lendecke [Sun, 6 Jan 2008 13:17:15 +0000 (14:17 +0100)]
use talloc_tos() in share_access_check()
(This used to be commit ac2bb838d537ca563ad2fe770b3e1c2fe8b1d9e7)

12 years agoSome more talloc_tos()
Volker Lendecke [Sun, 6 Jan 2008 15:15:45 +0000 (16:15 +0100)]
Some more talloc_tos()
(This used to be commit 444e35e7df1f13fc285183da8fb41b30ad99a3fa)

12 years agouse talloc_tos in a few more places
Volker Lendecke [Sun, 6 Jan 2008 13:21:25 +0000 (14:21 +0100)]
use talloc_tos in a few more places
(This used to be commit 65dd869bea351010c67f02046ae4134bdada1a4c)

12 years agoRemove unused string.
Günther Deschner [Thu, 10 Jan 2008 10:13:23 +0000 (11:13 +0100)]
Remove unused string.

Guenther
(This used to be commit 88d6683872f4bb9c3074280f385f73c7af9de784)

12 years agoFix a c++ warning
Volker Lendecke [Thu, 10 Jan 2008 10:35:40 +0000 (11:35 +0100)]
Fix a c++ warning
(This used to be commit ee905a085fff5410d02c3e5fa2664e989de4afd4)

12 years agotalloc_free_children can only reset pool if it's empty
Volker Lendecke [Thu, 10 Jan 2008 10:35:17 +0000 (11:35 +0100)]
talloc_free_children can only reset pool if it's empty
(This used to be commit 0272b46515b4c4515d5cad8e86fab61d8e91e29e)

12 years agoMark talloc_pool memory for valgrind
Volker Lendecke [Thu, 10 Jan 2008 10:34:07 +0000 (11:34 +0100)]
Mark talloc_pool memory for valgrind
(This used to be commit d89e42f1d2faa018c584025296d6be8195cbcf20)

12 years agoFix suspicious Makefile line
Volker Lendecke [Thu, 10 Jan 2008 09:55:20 +0000 (10:55 +0100)]
Fix suspicious Makefile line

If @WINBIND_KRB5_LOCATOR@ is not defined, this leads to a line with just one
tab in.
(This used to be commit af07adaf4293899fcbded666289ffa7479ca0501)

12 years agoForm a proper hierarchy in talloc_stack
Volker Lendecke [Thu, 10 Jan 2008 08:53:51 +0000 (09:53 +0100)]
Form a proper hierarchy in talloc_stack

This way talloc_stackframe() can benefit from a pool put on the stack further
up. No need to remove talloc_stackframe().
(This used to be commit be6fe381168321ae62e079cd977cbef675c532d4)

12 years agoFixup hot paths - add macro for toupper (c < 0x80).
Jeremy Allison [Thu, 10 Jan 2008 01:32:26 +0000 (17:32 -0800)]
Fixup hot paths - add macro for toupper (c < 0x80).
This now matches 3.0.x on my micro-tests.
Jeremy.
(This used to be commit 329b924cba8225002ca40db26c45b31d141a0925)

12 years agoMake use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy Allison [Thu, 10 Jan 2008 01:11:04 +0000 (17:11 -0800)]
Make use of talloc_pool in the main codepaths. Remove the sub-contexts.
Jeremy.
(This used to be commit bc932b8ad4396f76b71c43efe9a6346f89c3632c)

12 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Thu, 10 Jan 2008 01:08:20 +0000 (17:08 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit f98c68a8a4882cb0a1b7e8985f3eba5ebb8287e3)

12 years agoAdd the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy Allison [Thu, 10 Jan 2008 01:07:58 +0000 (17:07 -0800)]
Add the calls to make use of talloc_pools in a talloc_stackframe.
Jeremy.
(This used to be commit d27e6c0548d21394f6399d3b737d175ffed8420d)

12 years agoImplement talloc_pool()
Volker Lendecke [Sat, 5 Jan 2008 17:26:54 +0000 (18:26 +0100)]
Implement talloc_pool()

A talloc pool is a chunk of memory that can be used as a context for further
talloc calls. Allocations with the pool as the parent just chew from that
memory by incrementing a pointer. If the talloc pool is full, then we fall back
to the normal system-level malloc(3) to get memory.

The use case for talloc pools is the transient memory that is used for handling
a single SMB request. Incrementing a pointer will be way faster than any malloc
implementation.

There is a downside of this: If you use talloc_steal() to move something out of
the pool, the whole pool memory is kept around until the last object inside the
pool is freed. So if you talloc_free() the pool, it might happen that the
memory is freed later. So don't hang anything off a talloc pool that should
live long.

Volker
(This used to be commit 287e29d988813007eeebc0c2bef3b46ab8bedee9)

12 years agoTry and fix the AIX build.
Michael Adam [Thu, 10 Jan 2008 00:04:47 +0000 (01:04 +0100)]
Try and fix the AIX build.

The __ss_family workaround is in lib/replace/system/network.h ...

Michael
(This used to be commit 778199cf00196f81fd96deae1370d8cbc438c5bf)

12 years agoEnable building the notify_fam module.
Michael Adam [Wed, 9 Jan 2008 23:45:54 +0000 (00:45 +0100)]
Enable building the notify_fam module.

Found by Timur I. Bakeyev <timur@com.bat.ru>.

Michael
(This used to be commit ece34fd2fe4bcd3f88a31a42faaba89248da3ba9)

12 years agoMerge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
Jeremy Allison [Wed, 9 Jan 2008 22:35:37 +0000 (14:35 -0800)]
Merge branch 'v3-2-test' of ssh://jra@git.samba.org/data/git/samba into v3-2-test
(This used to be commit 92fcf22b79809393c734e4005c34a5e7e4aaa912)

12 years agoTry and fix the AIX build.
Jeremy Allison [Wed, 9 Jan 2008 22:35:15 +0000 (14:35 -0800)]
Try and fix the AIX build.
Jeremy.
(This used to be commit 231a148badf1f9b868ed1d37532020defa27bbd6)

12 years agoEnsure we don't take address of one past buffer.
Jeremy Allison [Wed, 9 Jan 2008 22:35:00 +0000 (14:35 -0800)]
Ensure we don't take address of one past buffer.
Jeremy.
(This used to be commit 318cbcfae51fc5dae549c60107d12480d8e478c8)

12 years agoFix the max_dead_record calculations
Volker Lendecke [Wed, 9 Jan 2008 22:00:48 +0000 (23:00 +0100)]
Fix the max_dead_record calculations
(This used to be commit 2a5c53220a5cc2b4a80fc7c6cb38e87789c5e797)

12 years agoTry to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.
Michael Adam [Wed, 9 Jan 2008 22:15:56 +0000 (23:15 +0100)]
Try to fix the build on hosts that HAVE_LDAP but don't HAVE_KRB5.

Michael
(This used to be commit 829de79051cd1d1cc67c4c40fdc8e08c44450a09)

12 years agoFix a memleak found by the IBM checker.
Michael Adam [Wed, 9 Jan 2008 21:25:52 +0000 (22:25 +0100)]
Fix a memleak found by the IBM checker.

Michael
(This used to be commit b4a37a66bbd8f5346de743d4ab427d6671e29075)

12 years agoFix memleak in ldapsam_rename_sam_account() found by IBM checker.
Michael Adam [Wed, 9 Jan 2008 21:09:55 +0000 (22:09 +0100)]
Fix memleak in ldapsam_rename_sam_account() found by IBM checker.

The check for out of memory was the wrong way round.

Michael
(This used to be commit d7a7b793203b986823859ac5171d2d4c30e52415)

12 years agoAnother attempt to fix builds w/o ldap and/or krb5.
Günther Deschner [Wed, 9 Jan 2008 11:47:13 +0000 (12:47 +0100)]
Another attempt to fix builds w/o ldap and/or krb5.

Guenther
(This used to be commit e73e3da772bd024f1d74fc41b832f181ba5c43bd)

12 years agoRe-run make idl to get even nicer pidl generated server code.
Günther Deschner [Wed, 9 Jan 2008 11:28:44 +0000 (12:28 +0100)]
Re-run make idl to get even nicer pidl generated server code.

Guenther
(This used to be commit 6169dea4dc3c4fc5eb1caefde828ed896cf048c5)

12 years agoCorrect comment. Default debug level of smbclient is 1, not 0.
Karolin Seeger [Tue, 8 Jan 2008 18:21:26 +0000 (19:21 +0100)]
Correct comment. Default debug level of smbclient is 1, not 0.
(This used to be commit 9c81125e6d3df49806e1c0b39409ffac8e3a0fd1)

12 years agoAttempt to fix the compile of source/utils/net_dns.c
Volker Lendecke [Wed, 9 Jan 2008 10:44:40 +0000 (11:44 +0100)]
Attempt to fix the compile of source/utils/net_dns.c

Jeremy, please check!
(This used to be commit 66d3012bf422b2ffc47fa6a405269bad2a80bd6f)

12 years agoRe-run make idl. The pidl generated code now fully complies to coding standards.
Günther Deschner [Wed, 9 Jan 2008 10:59:11 +0000 (11:59 +0100)]
Re-run make idl. The pidl generated code now fully complies to coding standards.

Guenther
(This used to be commit 3d34c87612138e4457e824e1a6e3981d1c3fe238)

12 years agoFix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.
Michael Adam [Wed, 9 Jan 2008 10:22:29 +0000 (11:22 +0100)]
Fix memory handling in torture/cmd_vfs.c:cmd_open and don't leak fsp_name.

Michael
(This used to be commit f93fc818143a7442a6e8a90f16f60c536a5b8f9e)

12 years agoReduce stat cache size default
Volker Lendecke [Tue, 8 Jan 2008 09:17:05 +0000 (10:17 +0100)]
Reduce stat cache size default

Now that we have a LRU scheme for the stat cache we can live with a lot less
(This used to be commit 9e736aab07b91744d4c14a55f6f7c55f51dd80f6)

12 years agoReplace an uninitialized variable
Volker Lendecke [Wed, 9 Jan 2008 09:29:34 +0000 (10:29 +0100)]
Replace an uninitialized variable

Reported by the IBM checker
(This used to be commit 48f61e4b9fce5ea4f4bc3cf55530bb757c0def07)

12 years agoAdd libnet_join_derive_salting_principal().
Günther Deschner [Tue, 8 Jan 2008 17:59:57 +0000 (18:59 +0100)]
Add libnet_join_derive_salting_principal().

Guenther
(This used to be commit 95129a28cfa57d8e5bd767b92f065abd1d32a569)

12 years agoFix build warning for libsmbclient example.
Günther Deschner [Tue, 8 Jan 2008 15:57:16 +0000 (16:57 +0100)]
Fix build warning for libsmbclient example.

Guenther
(This used to be commit 8f411753b2130e9c1f260a15d031f57ba07b62a1)

12 years agogit-ignore generated files under examples/VFS/
Michael Adam [Wed, 9 Jan 2008 01:35:34 +0000 (02:35 +0100)]
git-ignore generated files under examples/VFS/

Michael
(This used to be commit 7b3724fe861408c393e94260f8a8cc504f2a48d0)

12 years agoIgnore test directory.
Michael Adam [Wed, 9 Jan 2008 01:32:56 +0000 (02:32 +0100)]
Ignore test directory.

Michael
(This used to be commit 0aef0e38c26c59b779b5d7b48ef41e4aaa2fa729)

12 years agoensure uni_name.buffer is initialised
Volker Lendecke [Wed, 9 Jan 2008 06:59:12 +0000 (07:59 +0100)]
ensure uni_name.buffer is initialised

merge from http://samba.org/~tridge/3_0-ctdb
(This used to be commit 2938e74dea1695c813d6220a839b248dbc3b1d8f)

12 years agoFix CID 461 - resource leak on error.
Jeremy Allison [Wed, 9 Jan 2008 02:51:55 +0000 (18:51 -0800)]
Fix CID 461 - resource leak on error.
Jeremy.
(This used to be commit eea07b0c83985af60395f8a31de5bac4e5398cff)

12 years agoFix CID 460 - resource leak on error.
Jeremy Allison [Wed, 9 Jan 2008 02:48:04 +0000 (18:48 -0800)]
Fix CID 460 - resource leak on error.
Jeremy.
(This used to be commit d61831164b482d02e0eef3c28aeed93d3e44433f)

12 years agoFix resource leak found by coverity (CID 521).
Jeremy Allison [Wed, 9 Jan 2008 02:44:19 +0000 (18:44 -0800)]
Fix resource leak found by coverity (CID 521).
Jeremy.
(This used to be commit acfb233acc7324b8d431d5cb777a1933d173b3dc)

12 years agoChange registry_create_admin_token() to return NTSTATUS.
Michael Adam [Wed, 9 Jan 2008 00:17:13 +0000 (01:17 +0100)]
Change registry_create_admin_token() to return NTSTATUS.

Michael
(This used to be commit 9cd30fb25c42e79946b5140994d0bf2ef4c62f90)

12 years agoMove content of comment.
Michael Adam [Tue, 8 Jan 2008 23:25:27 +0000 (00:25 +0100)]
Move content of comment.

Michael
(This used to be commit ed4dd00c5ae8e4995ace9326f915ae4bd15d96b3)

12 years agoConvert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.
Michael Adam [Tue, 8 Jan 2008 23:11:31 +0000 (00:11 +0100)]
Convert add_sid_to_array() add_sid_to_array_unique() to return NTSTATUS.

Michael
(This used to be commit 6b2b9a60ef857ec31da5fea631535205fbdede4a)

12 years agoFix prototype: Add a void to an empty function parameter list.
Michael Adam [Tue, 8 Jan 2008 22:02:50 +0000 (23:02 +0100)]
Fix prototype: Add a void to an empty function parameter list.

Michael
(This used to be commit 3f89aea8e4df3a2de8c5e4c6f4e417567adb2d67)

12 years agoDon't leak data.dptr on error path.
Michael Adam [Tue, 8 Jan 2008 20:51:07 +0000 (21:51 +0100)]
Don't leak data.dptr on error path.

Michael
(This used to be commit d14de0692c623ff07dada45a3d7bec03ceca2b7e)

12 years agoExtend a comment.
Michael Adam [Tue, 8 Jan 2008 14:21:08 +0000 (15:21 +0100)]
Extend a comment.

Michael
(This used to be commit 081435250709af734ec1e49e2539b091f2d92dfb)

12 years agoAdd a comment.
Michael Adam [Wed, 9 Jan 2008 00:35:43 +0000 (01:35 +0100)]
Add a comment.

Michael
(This used to be commit 3a4bf4b7c3081048f0d5491dae6610388c268c2f)

12 years agoFix talloctort: move size check after referenced ptr check.
Michael Adam [Wed, 9 Jan 2008 00:34:21 +0000 (01:34 +0100)]
Fix talloctort: move size check after referenced ptr check.

Michael
(This used to be commit 45b219642c529865a898625eeb0433c60b233867)

12 years agoSimplify... plus add a debug message.
Jeremy Allison [Wed, 9 Jan 2008 00:08:39 +0000 (16:08 -0800)]
Simplify... plus add a debug message.
Jeremy.
(This used to be commit bedc493874adaf783362ba7b821e2a6d985b96ea)

12 years agoCorrectly identify enc/non-enc packets.
Jeremy Allison [Tue, 8 Jan 2008 23:57:08 +0000 (15:57 -0800)]
Correctly identify enc/non-enc packets.
Jeremy.
(This used to be commit 647f13d0f1a270a68263b3b0403436f9d6cf1a0e)

12 years agoSave one popular malloc
Volker Lendecke [Tue, 8 Jan 2008 22:18:03 +0000 (23:18 +0100)]
Save one popular malloc
(This used to be commit 2150663d9eaf5cdab08de2ad1fcc952d7e85936c)

12 years agoDon't shrink a talloc area if we have less than 1k to gain
Volker Lendecke [Tue, 8 Jan 2008 21:42:27 +0000 (22:42 +0100)]
Don't shrink a talloc area if we have less than 1k to gain
(This used to be commit 28a72ebd4541fb54f284da49081345e54130c75a)

12 years agoFix returns in void functions.
Michael Adam [Tue, 8 Jan 2008 21:51:21 +0000 (22:51 +0100)]
Fix returns in void functions.

Michael
(This used to be commit ef7c9a765bcdb1c774ff4f6d14053c4aa3815f31)

12 years agoFix examples/VFS after VFS API changes.
Michael Adam [Tue, 8 Jan 2008 21:13:25 +0000 (22:13 +0100)]
Fix examples/VFS after VFS API changes.

Michael
(This used to be commit c88555ce45aa2998037d316f3a8edccd04be04a4)

12 years agoOnly realloc the talloc stack if necessary
Volker Lendecke [Tue, 8 Jan 2008 21:12:35 +0000 (22:12 +0100)]
Only realloc the talloc stack if necessary
(This used to be commit c7cb98d486ef8af1dc7111c2316fd73db9fef9f8)

12 years agoAllocate dirp->name_cache on demand only
Volker Lendecke [Tue, 8 Jan 2008 20:45:21 +0000 (21:45 +0100)]
Allocate dirp->name_cache on demand only
(This used to be commit 1a15778331393f9ece9aac9450828e799b20a058)

12 years agoMove the DNS tsig update to using struct sockaddr_storage
Jeremy Allison [Tue, 8 Jan 2008 21:11:12 +0000 (13:11 -0800)]
Move the DNS tsig update to using struct sockaddr_storage
from struct in_addr. Still only does IPv4 updates but now
it'll be easy to add IPv6 when we have time.
Jeremy.
(This used to be commit ac3a433befca2c6b674fc7e7f2f2c700d78b0a0c)

12 years agoPedantic cosmetics: rerun make idl.
Günther Deschner [Tue, 8 Jan 2008 17:07:55 +0000 (18:07 +0100)]
Pedantic cosmetics: rerun make idl.

Guenther
(This used to be commit d1fa8049b1c0a3cebbc2c64e245e8055c8d3e84b)

12 years agoMerge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
Jelmer Vernooij [Tue, 8 Jan 2008 14:43:11 +0000 (15:43 +0100)]
Merge branch 'v3-2-test' of ssh://git.samba.org/data/git/samba into v3-2-test
(This used to be commit ea36c3add588061cf338deabb2d8952f2213a8bd)

12 years agoUse ads_get_upn() in net_derive_salting_principal().
Günther Deschner [Tue, 8 Jan 2008 13:06:18 +0000 (14:06 +0100)]
Use ads_get_upn() in net_derive_salting_principal().

Guenther
(This used to be commit a3b348b113f248d2eccffd6073560619a97a2976)

12 years agoFix define check s/WITH_LDAP/HAVE_LDAP/ in libnet_join.
Günther Deschner [Tue, 8 Jan 2008 13:03:12 +0000 (14:03 +0100)]
Fix define check s/WITH_LDAP/HAVE_LDAP/ in libnet_join.

Guenther
(This used to be commit 045a69c59c3b0732bb12a8b0efc8c9675e811719)

12 years agoDo not ignore provided machine_name in ads_get_upn().
Günther Deschner [Tue, 8 Jan 2008 12:46:54 +0000 (13:46 +0100)]
Do not ignore provided machine_name in ads_get_upn().

Guenther
(This used to be commit ddc1307844379f99b3dde48fc351d0326d22a7ce)

12 years agoAdd missing quote. Fix bug 5172. Thanks to Jason Filley <jason@snakelegs.org> for...
Karolin Seeger [Tue, 8 Jan 2008 11:23:25 +0000 (12:23 +0100)]
Add missing quote. Fix bug 5172. Thanks to Jason Filley <jason@snakelegs.org> for reporting!

Karolin
(This used to be commit 6be1ee8e6fb4e7fd413098c40b40569a980bd7a5)

12 years agoCorrectly talloc ctx->remote_path in libgpo (thanks Michael for the pointer).
Günther Deschner [Tue, 8 Jan 2008 11:25:47 +0000 (12:25 +0100)]
Correctly talloc ctx->remote_path in libgpo (thanks Michael for the pointer).

Guenther
(This used to be commit 2ea57a76a6bc8f9c835818780fcc9324896d5c1f)

12 years agoRemove redundant parameter fd from SMB_VFS_AIO_CANCEL().
Michael Adam [Tue, 8 Jan 2008 11:20:51 +0000 (12:20 +0100)]
Remove redundant parameter fd from SMB_VFS_AIO_CANCEL().

Michael
(This used to be commit 3c997ae0002d4c50e8899600c17ddf74ac61f6f0)

12 years agoCorrectly free buffers in netdomjoin-gui.
Günther Deschner [Tue, 8 Jan 2008 10:55:45 +0000 (11:55 +0100)]
Correctly free buffers in netdomjoin-gui.

Guenther
(This used to be commit 04d78d4d9a8cffe44c927036038aef1d6d6b44b2)

12 years agoMake name_buffer in NetGetJoinInformation() talloced.
Günther Deschner [Tue, 8 Jan 2008 10:54:51 +0000 (11:54 +0100)]
Make name_buffer in NetGetJoinInformation() talloced.

Guenther
(This used to be commit 421905fb608df6736944ac21ac67abee24991521)

12 years agoAdd NetApiBufferFree() to libnetapi.
Günther Deschner [Tue, 8 Jan 2008 10:53:38 +0000 (11:53 +0100)]
Add NetApiBufferFree() to libnetapi.

Guenther
(This used to be commit c49196954d38f0c2851abbfe25086cd6fe660a2e)

12 years agoFix crash bug when strequal is used too late in libnetapi_free.
Günther Deschner [Tue, 8 Jan 2008 10:49:35 +0000 (11:49 +0100)]
Fix crash bug when strequal is used too late in libnetapi_free.

Guenther
(This used to be commit ba2b8a310e1d6f78116350e24c17ae4db08b9bed)

12 years agoWhen unjoining fails (e.g. missing creds) make sure we still correct config.
Günther Deschner [Tue, 8 Jan 2008 10:46:11 +0000 (11:46 +0100)]
When unjoining fails (e.g. missing creds) make sure we still correct config.

Guenther
(This used to be commit 7f51583f681b1acc9bfbab6ee0e2d1c13d2c4ca4)

12 years agoRemove redundant parameter fd from SMB_VFS_FSETXATTR().
Michael Adam [Tue, 8 Jan 2008 10:47:33 +0000 (11:47 +0100)]
Remove redundant parameter fd from SMB_VFS_FSETXATTR().

Michael
(This used to be commit 0bd2643463a9160c8a1c7e1c2f8cca7b89060e09)

12 years agoRemove redundant parameter fd from SMB_VFS_FREMOVEXATTR().
Michael Adam [Tue, 8 Jan 2008 10:29:09 +0000 (11:29 +0100)]
Remove redundant parameter fd from SMB_VFS_FREMOVEXATTR().

Michael
(This used to be commit bfc3b5a27f707d3e4b8d5d66192891e22365fbb3)

12 years agoRemove redundant parameter fd from SMB_VFS_FLISTXATTR().
Michael Adam [Tue, 8 Jan 2008 09:51:40 +0000 (10:51 +0100)]
Remove redundant parameter fd from SMB_VFS_FLISTXATTR().

Michael
(This used to be commit 167649b3b8bc293f8434ffc9fb5f80463e4e75be)

12 years agoRemove redundant parameter fd from SMB_VFS_FGETXATTR().
Michael Adam [Tue, 8 Jan 2008 09:00:47 +0000 (10:00 +0100)]
Remove redundant parameter fd from SMB_VFS_FGETXATTR().

Michael
(This used to be commit 2cb739a82dc6bb194d60718cc74b26ee7c1c46a7)