ira/wip.git
8 years agobuild: Allow the C code to know if this is a waf build
Andrew Bartlett [Sun, 8 May 2011 15:35:05 +0000 (17:35 +0200)]
build: Allow the C code to know if this is a waf build

This allows addition of functionality that can't be handled (for
example, due to dependencies) in the autoconf build.

Andrew Bartlett

8 years agos4-interfaces: keep interfaces in the order they were declared
Andrew Tridgell [Sun, 8 May 2011 10:55:41 +0000 (12:55 +0200)]
s4-interfaces: keep interfaces in the order they were declared

the spoolss notify test depends on the interfaces order

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Sun May  8 13:57:58 CEST 2011 on sn-devel-104

8 years agos3-test: build smbtorture with --enable-developer
Andrew Tridgell [Sun, 8 May 2011 10:55:00 +0000 (12:55 +0200)]
s3-test: build smbtorture with --enable-developer

this makes debugging of tests much easier, as we get debug symbols

8 years agolib/socket: Remove outdated comment
Andrew Bartlett [Tue, 3 May 2011 10:24:39 +0000 (20:24 +1000)]
lib/socket: Remove outdated comment

The autoconf and waf tests for interfaces logic are in libreplace now.

8 years agos4-interfaces Rename interfaces code so not to conflict with source3/
Andrew Bartlett [Mon, 2 May 2011 05:57:19 +0000 (15:57 +1000)]
s4-interfaces Rename interfaces code so not to conflict with source3/

The iface_count, iface_n_bcast, and load_interfaces functions
conflicted with functions of the same name in source3, so the source4
functions were renamed.  Hopefully we can actually wrap one around the
other in future.

Andrew Bartlett

8 years agos3-lib Use common lib/socket code for get_interfaces() et al
Andrew Bartlett [Mon, 2 May 2011 02:20:21 +0000 (12:20 +1000)]
s3-lib Use common lib/socket code for get_interfaces() et al

8 years agolib/socket move interfaces code to the top level
Andrew Bartlett [Mon, 2 May 2011 03:02:17 +0000 (13:02 +1000)]
lib/socket move interfaces code to the top level

8 years agos4-lib/socket Samba4 is not IPv6 compatible
Andrew Bartlett [Tue, 3 May 2011 09:41:41 +0000 (19:41 +1000)]
s4-lib/socket Samba4 is not IPv6 compatible

Don't add IPv6 interfaces until we actually support them.

I'll soon have IPv6 service at home, and then I'll make it my buisness
to sort this out once and for all.

Andrew Bartlett

8 years agos4-lib merge get_interfaces() from Samba3 to Samba4
Andrew Bartlett [Mon, 2 May 2011 02:09:19 +0000 (12:09 +1000)]
s4-lib merge get_interfaces() from Samba3 to Samba4

8 years agos3-smbd: expose smbd_set_server_fd()
Andrew Tridgell [Mon, 2 May 2011 23:32:01 +0000 (09:32 +1000)]
s3-smbd: expose smbd_set_server_fd()

this allows the fd to be setup by subsystems that want to use the s3
server core code

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Sun May  8 12:01:13 CEST 2011 on sn-devel-104

8 years agos3-waf: expose the server_exit code in the smbd_base library
Andrew Tridgell [Mon, 2 May 2011 23:33:17 +0000 (09:33 +1000)]
s3-waf: expose the server_exit code in the smbd_base library

these functions are called from the rest of smbd_base

8 years agobuild: allow s3 libraries to be built with no undefined symbols
Andrew Tridgell [Fri, 6 May 2011 14:49:13 +0000 (00:49 +1000)]
build: allow s3 libraries to be built with no undefined symbols

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos4-param Don't set variables such as the debuglevel unless global
Andrew Bartlett [Sun, 8 May 2011 08:30:36 +0000 (10:30 +0200)]
s4-param Don't set variables such as the debuglevel unless global

This ensures that when a second lp_ctx is created, that it does not
set global variables such as the debug level, log file etc,
potentially overriding the settings created by another context.

In particular this matters when loading Samba4 modules into Samba3.

Andrew Bartlett

8 years agoImprove debug messages when creating socket directories
Andrew Bartlett [Sun, 8 May 2011 08:28:03 +0000 (10:28 +0200)]
Improve debug messages when creating socket directories

This makes clear what the permissions error and directory name actually is

Andrew Bartlett

8 years agolibds: moved enum security_types to a common header
Andrew Tridgell [Sat, 7 May 2011 11:32:20 +0000 (13:32 +0200)]
libds: moved enum security_types to a common header

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agos3-utils Set dyn_CONFIGFILE from -c on smbpasswd command line
Andrew Bartlett [Sun, 8 May 2011 04:56:47 +0000 (06:56 +0200)]
s3-utils Set dyn_CONFIGFILE from -c on smbpasswd command line

This is similar to the code in popt_common and allows the smb.conf to
be re-loaded from this file later in the code (or for Samba4 plugins
to attempt to parse the same smb.conf).

Andrew Bartlett

8 years agoselftest Use die() less often, as it fails to allow cleanup
Andrew Bartlett [Sun, 8 May 2011 04:54:50 +0000 (06:54 +0200)]
selftest Use die() less often, as it fails to allow cleanup

8 years agoauth: allow auth_common.h to be included multiple times without error
Andrew Bartlett [Sat, 7 May 2011 06:36:06 +0000 (08:36 +0200)]
auth: allow auth_common.h to be included multiple times without error

8 years agos4-auth Rename auth -> auth4 to avoid conflict with s3 auth
Andrew Bartlett [Sat, 7 May 2011 06:14:06 +0000 (08:14 +0200)]
s4-auth Rename auth -> auth4 to avoid conflict with s3 auth

8 years agos4-ntvfs: Rename brl_*() -> brlock_*() to avoid conflict with brlock_init in s3
Andrew Bartlett [Sat, 7 May 2011 06:12:54 +0000 (08:12 +0200)]
s4-ntvfs: Rename brl_*() -> brlock_*() to avoid conflict with brlock_init in s3

8 years agos4-auth: remove unused prototype
Andrew Tridgell [Fri, 6 May 2011 14:49:38 +0000 (00:49 +1000)]
s4-auth: remove unused prototype

8 years agos3: Fix including libsmb/proto.h without prior ads.h
Volker Lendecke [Sat, 7 May 2011 08:38:12 +0000 (10:38 +0200)]
s3: Fix including libsmb/proto.h without prior ads.h

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Sat May  7 11:38:11 CEST 2011 on sn-devel-104

8 years agoFix Samba3 on OpenIndiana.
Gordon Ross [Fri, 6 May 2011 23:00:08 +0000 (16:00 -0700)]
Fix Samba3 on OpenIndiana.

I'd like Samba to use the native OpenLDAP and MIT Kerberos libs.
Attached are some patches to do that. (relative to git master)
It does not build for me without these.

(OpenIndiana is an off-shoot of OpenSolaris  See http://www.openindiana.org)

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat May  7 02:20:14 CEST 2011 on sn-devel-104

8 years agoA couple more off-by-one calculations with strlcpy.
Jeremy Allison [Fri, 6 May 2011 14:54:18 +0000 (07:54 -0700)]
A couple more off-by-one calculations with strlcpy.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 18:39:17 CEST 2011 on sn-devel-104

8 years agos4-smbd: fix randseed_init() usage.
Günther Deschner [Fri, 6 May 2011 14:22:41 +0000 (16:22 +0200)]
s4-smbd: fix randseed_init() usage.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 17:37:11 CEST 2011 on sn-devel-104

8 years agos3-includes: no need to globally include libads/ads_status.h.
Günther Deschner [Fri, 6 May 2011 10:54:59 +0000 (12:54 +0200)]
s3-includes: no need to globally include libads/ads_status.h.

Guenther

8 years agos3-includes: finally only include client.h when libsmb is used.
Günther Deschner [Fri, 6 May 2011 10:53:38 +0000 (12:53 +0200)]
s3-includes: finally only include client.h when libsmb is used.

Guenther

8 years agos3-libsmb: move protos to libsmb/proto.h
Günther Deschner [Fri, 6 May 2011 09:47:43 +0000 (11:47 +0200)]
s3-libsmb: move protos to libsmb/proto.h

Guenther

8 years agos3-proto: remove some duplicate prototypes.
Günther Deschner [Fri, 6 May 2011 12:03:00 +0000 (14:03 +0200)]
s3-proto: remove some duplicate prototypes.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 16:21:08 CEST 2011 on sn-devel-104

8 years agos3-spoolss: remove unused struct in construct_notify_printer_info().
Günther Deschner [Thu, 5 May 2011 19:52:57 +0000 (21:52 +0200)]
s3-spoolss: remove unused struct in construct_notify_printer_info().

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Fri May  6 12:07:17 CEST 2011 on sn-devel-104

8 years agolibcli/security: fix build warning, cr_descr_log_acl() is not used currently.
Günther Deschner [Thu, 5 May 2011 10:52:29 +0000 (12:52 +0200)]
libcli/security: fix build warning, cr_descr_log_acl() is not used currently.

Guenther

8 years agotdb: fix a build warning.
Günther Deschner [Thu, 5 May 2011 10:52:05 +0000 (12:52 +0200)]
tdb: fix a build warning.

Guenther

8 years agos3: only include tdb headers where needed.
Günther Deschner [Thu, 5 May 2011 09:25:29 +0000 (11:25 +0200)]
s3: only include tdb headers where needed.

Guenther

8 years agolib/util don't use enum protocol_types in ms_fnmatch_protocol
Andrew Bartlett [Wed, 4 May 2011 11:20:57 +0000 (21:20 +1000)]
lib/util don't use enum protocol_types in ms_fnmatch_protocol

This makes it easier to compile this in the top level with s3 and s4
headers.

Andrew Bartlett

Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Fri May  6 08:50:52 CEST 2011 on sn-devel-104

8 years agolibcli/smb Move cifs posix helper functions and headers in common
Andrew Bartlett [Wed, 4 May 2011 11:19:46 +0000 (21:19 +1000)]
libcli/smb Move cifs posix helper functions and headers in common

unix_perms_to_wire() was a duplicate symbol in the top level build.

Andrew Bartlett

8 years agolib/util Use lib/util/ms_fnmatch.c in common for gen_fnmatch()
Andrew Bartlett [Wed, 4 May 2011 10:57:12 +0000 (20:57 +1000)]
lib/util Use lib/util/ms_fnmatch.c in common for gen_fnmatch()

gen_fnmatch was a duplicate symbol in the top level build.

gen_fnmatch() used for simple non-CIFS pattern matching, so selecting
the lib/util implementation should not be a concern.

Andrew Bartlett

8 years agolib/util Rename ms_fnmatch() to ms_fnmatch_protocol() to avoid dup symbol
Andrew Bartlett [Wed, 4 May 2011 10:53:33 +0000 (20:53 +1000)]
lib/util Rename ms_fnmatch() to ms_fnmatch_protocol() to avoid dup symbol

This verison of the function takes a protcol as argument to determine
matching rules.

Andrew Bartlett

8 years agoerrors: Remove unused unix_to_werror()
Andrew Bartlett [Wed, 4 May 2011 07:00:23 +0000 (17:00 +1000)]
errors: Remove unused unix_to_werror()

8 years agolibcli/util Move NTSTATUS table to the top level
Andrew Bartlett [Wed, 4 May 2011 05:50:07 +0000 (15:50 +1000)]
libcli/util Move NTSTATUS table to the top level

8 years agonterr: Add mem_ctx for return string from get_nt_error_c_code()
Andrew Bartlett [Wed, 4 May 2011 05:30:01 +0000 (15:30 +1000)]
nterr: Add mem_ctx for return string from get_nt_error_c_code()

It is clearer to avoid the implicit return on talloc_tos()

Andrew Bartlett

8 years agos3-smbd ntstatus_to_dos() pulls the DOS error codes out internally
Andrew Bartlett [Wed, 4 May 2011 06:16:13 +0000 (16:16 +1000)]
s3-smbd ntstatus_to_dos() pulls the DOS error codes out internally

This means we don't need to duplicate that logic here.

Andrew Bartlett

8 years agolibcli/util Merge ntstatus_to_dos() ntstatus_to_werror() to the top level
Andrew Bartlett [Wed, 4 May 2011 03:59:57 +0000 (13:59 +1000)]
libcli/util Merge ntstatus_to_dos() ntstatus_to_werror() to the top level

This takes the Samba4 version, with the NT_STATUS_IS_DOS() check.
This will be used in smbd/error.c shortly.

Andrew Bartlett

8 years agoerrors: Merge source3/ werror_to_ntstatus() code to source4/
Andrew Bartlett [Wed, 4 May 2011 06:51:23 +0000 (16:51 +1000)]
errors: Merge source3/ werror_to_ntstatus() code to source4/

8 years agoerrors: Merge ntstatus -> DOS error table between Samba3 and Samba4.
Andrew Bartlett [Wed, 4 May 2011 03:47:26 +0000 (13:47 +1000)]
errors: Merge ntstatus -> DOS error table between Samba3 and Samba4.

They are now identical

Andrew Bartlett

8 years agos3-lib Remove unused dos error codes from errmap_unix
Andrew Bartlett [Wed, 4 May 2011 01:39:21 +0000 (11:39 +1000)]
s3-lib Remove unused dos error codes from errmap_unix

This also makes unix_nt_errmap private to errmap_unix.c and errormap.c
so the tables themselves cannot be duplicate symbols until merged.

Andrew Bartlett

8 years agolib/util Move source3 tdb_wrap_open() into the common code.
Andrew Bartlett [Wed, 4 May 2011 00:28:15 +0000 (10:28 +1000)]
lib/util Move source3 tdb_wrap_open() into the common code.

This #if _SAMBA_BUILD == 3 is very unfortunate, as it means that in
the top level build, these options are not available for these
databases.  However, having two different tdb_wrap lists is a worse
fate, so this will do for now.

Andrew Bartlett

8 years agos3-winbind: another strlcpy()/fstring fix
Andrew Tridgell [Fri, 6 May 2011 04:49:36 +0000 (14:49 +1000)]
s3-winbind: another strlcpy()/fstring fix

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Fri May  6 07:50:33 CEST 2011 on sn-devel-104

8 years agos3-auth: fixed bug with usernames longer than sizeof(char *)
Andrew Tridgell [Fri, 6 May 2011 04:00:27 +0000 (14:00 +1000)]
s3-auth: fixed bug with usernames longer than sizeof(char *)

using sizeof(user) when user is "fstring user" as a C parameter
actually returns sizeof(char *), which means that long usernames
aren't allowed.

Jeremy, you need a longer username :-)

Cheers, Tridge

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

8 years agoFix const in smbtorture.
Jeremy Allison [Thu, 5 May 2011 23:44:27 +0000 (16:44 -0700)]
Fix const in smbtorture.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 02:45:00 CEST 2011 on sn-devel-104

8 years agoFix broken interface to set_namearray() - don't modify incoming string.
Jeremy Allison [Thu, 5 May 2011 23:32:01 +0000 (16:32 -0700)]
Fix broken interface to set_namearray() - don't modify incoming string.

8 years agoFixup use of const.
Jeremy Allison [Thu, 5 May 2011 23:31:41 +0000 (16:31 -0700)]
Fixup use of const.

8 years agoMore const fixes. Remove CONST_DISCARD.
Jeremy Allison [Thu, 5 May 2011 23:19:49 +0000 (16:19 -0700)]
More const fixes. Remove CONST_DISCARD.

8 years agoChange the char * pointers in the struct to const char * (which is how they're treated).
Jeremy Allison [Thu, 5 May 2011 23:19:23 +0000 (16:19 -0700)]
Change the char * pointers in the struct to const char * (which is how they're treated).

8 years agoMore const fixes... getting near the end now.
Jeremy Allison [Thu, 5 May 2011 21:56:30 +0000 (14:56 -0700)]
More const fixes... getting near the end now.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Fri May  6 00:57:00 CEST 2011 on sn-devel-104

8 years agoMore simple const fixups.
Jeremy Allison [Thu, 5 May 2011 21:36:55 +0000 (14:36 -0700)]
More simple const fixups.

8 years agoMore simple const fixes.
Jeremy Allison [Thu, 5 May 2011 21:22:11 +0000 (14:22 -0700)]
More simple const fixes.

8 years agoMore const fixes for compiler warnings from the waf build.
Jeremy Allison [Thu, 5 May 2011 20:42:05 +0000 (13:42 -0700)]
More const fixes for compiler warnings from the waf build.

8 years agoFixup build without --with-aio.
Jeremy Allison [Thu, 5 May 2011 18:38:06 +0000 (11:38 -0700)]
Fixup build without --with-aio.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May  5 21:38:23 CEST 2011 on sn-devel-104

8 years agoMore const compiler warning fixes.
Jeremy Allison [Thu, 5 May 2011 18:29:01 +0000 (11:29 -0700)]
More const compiler warning fixes.

8 years agoFix many const compiler warnings.
Jeremy Allison [Thu, 5 May 2011 17:41:59 +0000 (10:41 -0700)]
Fix many const compiler warnings.

8 years agoDon't reuse a non-const pointer when manipulating const.
Jeremy Allison [Thu, 5 May 2011 17:41:40 +0000 (10:41 -0700)]
Don't reuse a non-const pointer when manipulating const.

8 years agos3: Fix a typo
Volker Lendecke [Thu, 5 May 2011 13:09:09 +0000 (15:09 +0200)]
s3: Fix a typo

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 16:10:35 CEST 2011 on sn-devel-104

8 years agos3: Fix dup_smb2_vec3
Volker Lendecke [Thu, 5 May 2011 10:17:41 +0000 (12:17 +0200)]
s3: Fix dup_smb2_vec3

Metze, Jeremy, please check!

Thanks,

Volker

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Thu May  5 13:39:40 CEST 2011 on sn-devel-104

8 years agos4-auth: removed the password combinations code in auth_unix
Andrew Tridgell [Thu, 5 May 2011 03:59:08 +0000 (13:59 +1000)]
s4-auth: removed the password combinations code in auth_unix

this code never did anything due to a typo, and was untested. We
should not be inluding a password cracker in Samba anyway.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu May  5 07:00:14 CEST 2011 on sn-devel-104

8 years agos3-rpc_server: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:58:27 +0000 (00:58 +0200)]
s3-rpc_server: run minimal_includes.pl.

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Thu May  5 03:04:38 CEST 2011 on sn-devel-104

8 years agos3-rpc_client: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:54:56 +0000 (00:54 +0200)]
s3-rpc_client: run minimal_includes.pl.

Guenther

8 years agos3-rpcclient: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:51:12 +0000 (00:51 +0200)]
s3-rpcclient: run minimal_includes.pl.

Guenther

8 years agos3-printing: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:48:26 +0000 (00:48 +0200)]
s3-printing: run minimal_includes.pl.

Guenther

8 years agos3-param: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:36:51 +0000 (00:36 +0200)]
s3-param: run minimal_includes.pl.

Guenther

8 years agos3-libsmb: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:31:42 +0000 (00:31 +0200)]
s3-libsmb: run minimal_includes.pl.

Guenther

8 years agos3-libnet: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:25:31 +0000 (00:25 +0200)]
s3-libnet: run minimal_includes.pl.

Guenther

8 years agos3-libads: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:22:05 +0000 (00:22 +0200)]
s3-libads: run minimal_includes.pl.

Guenther

8 years agos3-lib: run minimal_includes.pl.
Günther Deschner [Wed, 4 May 2011 22:10:23 +0000 (00:10 +0200)]
s3-lib: run minimal_includes.pl.

Guenther

8 years agos3-auth: run minimal_includes.pl
Günther Deschner [Wed, 4 May 2011 22:03:48 +0000 (00:03 +0200)]
s3-auth: run minimal_includes.pl

Guenther

8 years agos4-samba-tool: allow specification of targetdir when joining as (RO)DC
Matthieu Patou [Mon, 21 Mar 2011 15:03:50 +0000 (18:03 +0300)]
s4-samba-tool: allow specification of targetdir when joining as (RO)DC

Autobuild-User: Matthieu Patou <mat@samba.org>
Autobuild-Date: Thu May  5 02:04:13 CEST 2011 on sn-devel-104

8 years agoClean up some const and other compiler warnings.
Jeremy Allison [Wed, 4 May 2011 21:57:37 +0000 (14:57 -0700)]
Clean up some const and other compiler warnings.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Thu May  5 00:59:40 CEST 2011 on sn-devel-104

8 years agoI added them, so I get to kill them :-). Finally remove all uses of safe_strcpy and...
Jeremy Allison [Tue, 3 May 2011 23:43:27 +0000 (16:43 -0700)]
I added them, so I get to kill them :-). Finally remove all uses of safe_strcpy and safe_strcat. Change to strlcpy, strlcat.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May  4 22:14:14 CEST 2011 on sn-devel-104

8 years agoFix warning messages caused by addition of null check in fstrcpy macro.
Jeremy Allison [Wed, 4 May 2011 18:38:26 +0000 (11:38 -0700)]
Fix warning messages caused by addition of null check in fstrcpy macro.

8 years agoTidy up some missing checks for NULL in strlcpy.
Jeremy Allison [Tue, 3 May 2011 23:42:17 +0000 (16:42 -0700)]
Tidy up some missing checks for NULL in strlcpy.

8 years agoAdd in bufflen limit when storing NetBIOS names. Remove safe_strcpy.
Jeremy Allison [Tue, 3 May 2011 21:52:01 +0000 (14:52 -0700)]
Add in bufflen limit when storing NetBIOS names. Remove safe_strcpy.

8 years agoConvert safe_strXX to strlXXX. Clean up off-by-ones.
Jeremy Allison [Tue, 3 May 2011 21:51:25 +0000 (14:51 -0700)]
Convert safe_strXX to strlXXX. Clean up off-by-ones.

8 years agoRemove magic numbers. Standardize on macro. Move from safe_strcat to strlcat.
Jeremy Allison [Tue, 3 May 2011 21:08:27 +0000 (14:08 -0700)]
Remove magic numbers. Standardize on macro. Move from safe_strcat to strlcat.

8 years agoCope with +1 change on moving from safe_strcat to strlcat.
Jeremy Allison [Tue, 3 May 2011 21:06:32 +0000 (14:06 -0700)]
Cope with +1 change on moving from safe_strcat to strlcat.

8 years agoFold null terminator into listlen length, change to strlcpy.
Jeremy Allison [Tue, 3 May 2011 21:15:04 +0000 (14:15 -0700)]
Fold null terminator into listlen length, change to strlcpy.

8 years agoFix the only place we reply on the NULL handling for the source in safe_strcpy.
Jeremy Allison [Tue, 3 May 2011 21:01:20 +0000 (14:01 -0700)]
Fix the only place we reply on the NULL handling for the source in safe_strcpy.

8 years agoFix off-by-one when used with safe_strcpy.
Jeremy Allison [Tue, 3 May 2011 20:57:30 +0000 (13:57 -0700)]
Fix off-by-one when used with safe_strcpy.

8 years agosasl_secret_t ends in a char [1] size. This means the extra character is implicit...
Jeremy Allison [Tue, 3 May 2011 20:53:30 +0000 (13:53 -0700)]
sasl_secret_t ends in a char [1] size. This means the extra character is implicit in the safe_strcpy. When changing to strlcpy ensure we allocate an extra char for it. This fixes a bug where secret->len+1 used with safe_strcpy could actually write into secret->len+2.

8 years agoSimple +1 changes in hardcoded lengths when changing from safe_strcpy to strlcpy.
Jeremy Allison [Tue, 3 May 2011 20:52:06 +0000 (13:52 -0700)]
Simple +1 changes in hardcoded lengths when changing from safe_strcpy to strlcpy.

8 years agoBUGFIX when converting from safe_strcpy to strlcpy.
Jeremy Allison [Tue, 3 May 2011 20:49:28 +0000 (13:49 -0700)]
BUGFIX when converting from safe_strcpy to strlcpy.

We must have a blob legth > 0 in order to safely copy
the (possibly) 16 bytes + 1 byte zero character safely.

8 years agoRemove overmalloc_safe_strcpy - can be simple strlcpy.
Jeremy Allison [Tue, 3 May 2011 20:40:07 +0000 (13:40 -0700)]
Remove overmalloc_safe_strcpy - can be simple strlcpy.

8 years agoRemove obvious use of safe_strcpy + safe_strcat -> strlcpy + strlcat.
Jeremy Allison [Tue, 3 May 2011 20:19:27 +0000 (13:19 -0700)]
Remove obvious use of safe_strcpy + safe_strcat -> strlcpy + strlcat.

8 years agoChange safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the...
Jeremy Allison [Tue, 3 May 2011 20:14:46 +0000 (13:14 -0700)]
Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here as the original macro auto-added the -1.

8 years agoFix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.
Jeremy Allison [Tue, 3 May 2011 20:10:01 +0000 (13:10 -0700)]
Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.

8 years agos3-torture: Add a test for notify upon read&x
Volker Lendecke [Wed, 4 May 2011 15:45:34 +0000 (17:45 +0200)]
s3-torture: Add a test for notify upon read&x

This makes sure that when a file is brought online by a read call
we notify the client for FILE_NOTIFY_CHANGE_ATTRIBUTES.

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 21:09:22 CEST 2011 on sn-devel-104

8 years agoAlways build before commit ... :-)
Volker Lendecke [Wed, 4 May 2011 15:48:12 +0000 (17:48 +0200)]
Always build before commit ... :-)

8 years agoRemove unused function parse_add_domuser().
Jeremy Allison [Tue, 3 May 2011 19:55:42 +0000 (12:55 -0700)]
Remove unused function parse_add_domuser().

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Wed May  4 20:05:42 CEST 2011 on sn-devel-104

8 years agos3-waf: add vfs_gpfs_hsm_notify to the build.
Günther Deschner [Wed, 4 May 2011 16:01:04 +0000 (18:01 +0200)]
s3-waf: add vfs_gpfs_hsm_notify to the build.

Volker, can you please check this is correct ?

Guenther

Autobuild-User: Günther Deschner <gd@samba.org>
Autobuild-Date: Wed May  4 19:03:45 CEST 2011 on sn-devel-104

8 years agoRHEL-CTDB: Build vfs_gpfs_hsm_notify
Volker Lendecke [Wed, 4 May 2011 14:02:15 +0000 (16:02 +0200)]
RHEL-CTDB: Build vfs_gpfs_hsm_notify

Autobuild-User: Volker Lendecke <vlendec@samba.org>
Autobuild-Date: Wed May  4 17:12:14 CEST 2011 on sn-devel-104

8 years agovfs_gpfs: Properly notify the offline->online changes
Volker Lendecke [Wed, 4 May 2011 13:48:27 +0000 (15:48 +0200)]
vfs_gpfs: Properly notify the offline->online changes

This needs to be a separate module that cooperates with vfs_gpfs. If aio_fork
is used early in the module chain it (correctly) does not propagate the aio ops
down, so vfs_gpfs does not see them. This slim module must come early in the
chain for notifies to work properly.

8 years agovfs_gpfs: Block sendfile for offline files
Volker Lendecke [Wed, 4 May 2011 13:47:42 +0000 (15:47 +0200)]
vfs_gpfs: Block sendfile for offline files